- 16 Oct, 2018 40 commits
-
-
Frank Tang authored
This the Chromium side of adding usage counter for Intl objects functions. It depends on https://chromium-review.googlesource.com/c/v8/v8/+/1255628 Bug: v8:8250 Change-Id: I3a56c6948bbe6059b5b997a4199c4ea612c9ee3d Reviewed-on: https://chromium-review.googlesource.com/c/1255629Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#599989}
-
Morten Stenshorne authored
The tests incorrectly assumed that block-size:-webkit-fill-available on absolutely positioned children were resolved against the available *content* box size. But for absolutely positioned descendants, the containing block size is based on the *padding* box. (Fun fact: -webkit-fill-available, when used on *inline* sizes, is handled correctly in legacy, i.e. we use the padding box, then) NG does it correctly in both dimensions. So mark the test as failing in legacy and passing in NG. Updated the tests to look prettier when rendered correctly. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I3f987660920ee0e03974dabb6928c0591717766a Reviewed-on: https://chromium-review.googlesource.com/c/1281967Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#599988}
-
kylechar authored
Replace passing around an array+size with passing a vector to cleanup code. Bug: none Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I04eb35d9af0c96db0cddaa2a6b5f526517d7ec3e Reviewed-on: https://chromium-review.googlesource.com/c/1280858Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#599987}
-
Ehsan Karamad authored
The API for attaching inner and outer WebContentses only supports a RenderFrameHost which is same-process and origin with its parent. This is due to the fact that all GuestViews start off with a blank <iframe> which is later swapped out with a proxy during attaching process. For MimeHandlerViewGuest it is not guaranteed that the starting frame in an <embed> or <object> is in 'about:blank'. This CL circumvents the problem by first navigating a plugin frame (on the browser side) to 'about:blank' and then proceeding with the attaching process. Bug: 659750 Change-Id: I57d41a38e957b22c4ba3c29cb11122115373946f Reviewed-on: https://chromium-review.googlesource.com/c/1240635 Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#599986}
-
Sergio Villar Senin authored
After successfully migrating the ProcessDiceHeaderDelegateImpl we can complete the job by also migrating the unit test. Several fake objects were removed in favour of IdentityTestEnvironment which also provides an IdentityManager. Bug: 890791 Change-Id: Ie689268b0b9e2569a4cce5c4abe645d3daa82c7e Reviewed-on: https://chromium-review.googlesource.com/c/1282743Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Sergio Villar <svillar@igalia.com> Cr-Commit-Position: refs/heads/master@{#599985}
-
Esmael El-Moslimany authored
The profile name already has a data binding. When the /manageProfile page loads first, the profile name has not yet been retrieved when setting the input resulting in setting the input value to undefined which leads to a momentary invalid input. Once the profile name is set, the data binding to the input value will do the necessary update. Bug: 895205 Change-Id: Ibf3ef6c81e0e7fa73b52944ee4cdf8c72f1748d6 Reviewed-on: https://chromium-review.googlesource.com/c/1281222Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#599984}
-
Fady Samuel authored
Prior to this CL, if a child initiates a synchronization event and submits a CompositorFrame with a deadline in the past then the CompositorFrame will immediately activate, but the surface will not be marked and so future CompositorFrames to the same surface will result in blocking until embedding or deadline again and again. This could slow down activation and skew deadline duration reporting. This CL marks a surface such that additional CompositorFrames submitted to the surface will not block on embedding. Bug: 672962, 890767 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: Ia942e39266ac11dd20cea3f3ae4a087511a98c1d Reviewed-on: https://chromium-review.googlesource.com/c/1281885 Commit-Queue: Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#599983}
-
Charlie Harrison authored
Currently, the icon persists across navigations, which is wrong. Bug: 894955 Change-Id: I5e2028668a249c0baeb3976297c499df3e61b3b3 Reviewed-on: https://chromium-review.googlesource.com/c/1279208 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#599982}
-
Jordan Demeulenaere authored
Before this change, small timing issues in scripts could result in actions failing to find the element they need. The java implementation includes a short wait before most actions, so there's no need to add a WaitForDom for short delays. This patch reproduces that behavior. After this change, scripts requiring a selector wait for up to 2s for the element they need to appear. Bug: 806868 Change-Id: I4518d1d4260e32dc59b7f9455cda00f86ac24543 Reviewed-on: https://chromium-review.googlesource.com/c/1280283 Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#599981}
-
gogerald authored
Bug: 806868 Change-Id: I22b21ccbb386e89d5ac2b0cd8d80e53cc14b447a Reviewed-on: https://chromium-review.googlesource.com/c/1282362 Commit-Queue: Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#599980}
-
Brian Osman authored
Change-Id: Ia77210022ac412d00be1fc2f8831eb973e07de62 Reviewed-on: https://chromium-review.googlesource.com/c/1280786Reviewed-by:
Mike Klein <mtklein@chromium.org> Commit-Queue: Brian Osman <brianosman@google.com> Cr-Commit-Position: refs/heads/master@{#599979}
-
Christos Froussios authored
The test is 50% flaky. TBR=rbpotter@chromium.org Bug: 895832 Change-Id: Ic97a551542ae757c10e81a2440454b213aa05f05 Reviewed-on: https://chromium-review.googlesource.com/c/1282959Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Commit-Queue: Christos Froussios <cfroussios@chromium.org> Cr-Commit-Position: refs/heads/master@{#599978}
-
Jonathan Backer authored
This introduces an --enable-raster-to-sk-image flag that can be used to OOP raster to an SkImage directly. This can be combined with other flags for Vulkan prototyping with OOP-D, OOP-R, SkiaRenderer and SkDDL. Notable changes: - adds a temporary SHARED_IMAGE_USAGE_OOP_RASTERIZATION SharedImage usage flag for OOP-R - adds a --enable-raster-to-sk-image flag to create a WrappedSkImage for OOP-R. This to prevent malicious renderer from turning on this untested (temporary) code path. - Added GetType to TextureBase so that we can safely downcast. - Added GetTracingId TextureBase so that we can memory dump with Vulkan. Currently does not support passthrough. This is not a regression, but remains future work. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ia273d3055b01239f66f33f77296575ee58f09c50 Reviewed-on: https://chromium-review.googlesource.com/c/1127445Reviewed-by:
Eric Karl <ericrk@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#599977}
-
Liquan(Max) Gu authored
In order to report Largest/LastImagePaint to UKM, this CL is to plumb Largest/LastImagePaint to WebPerformance, but a follow-up CL has to be done to pick up the metric results from the browser side. Before this CL, the metrics report the result by dumping a trace event. This CL adds a new way of reporting. When the metrics fire new results. The results will be stored in the detector class. At the same time, the detector will notify web performance of the new result so that the web performance will pick up the metric results. This CL also refactors the OnLargest/LastImagePaintDetected function in ImagePaintTimingDetector for better readability. Bug: 869924 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I9b198b8bacac52e5dae66ea3ab9c2bedc56cfb8f Reviewed-on: https://chromium-review.googlesource.com/c/1280844Reviewed-by:
Steve Kobes <skobes@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Commit-Queue: Liquan (Max) Gǔ <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#599976}
-
Kevin McNee authored
This effectively reverts https://chromium-review.googlesource.com/c/chromium/src/+/614084 which added this hack. This is no longer necessary as wheel listeners can now prevent the double-tap to zoom gesture (see issue 802369) and the PDF viewer has the necessary behaviour already (see testPreventNativeZoomFromWheel in gesture_detector_test.js). Bug: 676668, 802369 Change-Id: I4cb840d9f383c0f8aa4a47851d749de41004816b Reviewed-on: https://chromium-review.googlesource.com/c/1281172Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
dsinclair <dsinclair@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#599975}
-
Hans Wennborg authored
A new version of Clang made the -Wshadow warning also apply to enumerators, warning that the blink::WebSettings::V8CacheOptions enumerators shadow the enumerators from blink::V8CacheOptions, e.g. 49344/58815] CXX obj/third_party/blink/renderer/core/core_generated/v8_code_cache.o In file included from ../../third_party/blink/renderer/bindings/core/v8/v8_code_cache.cc:9: ../../third_party/blink/public/web/web_settings.h:66:5: warning: declaration shadows a variable in namespace 'blink' [-Wshadow] kV8CacheOptionsDefault, ^ ../../third_party/blink/renderer/bindings/core/v8/v8_cache_options.h:37:3: note: previous declaration is here kV8CacheOptionsDefault, // Use whatever the current default is. ^ Bug: 895475 Change-Id: I6de82855f3db4655c1bfaa4bb8d77fab1466188e Reviewed-on: https://chromium-review.googlesource.com/c/1282445Reviewed-by:Kentaro Hara <haraken@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#599974}
-
Christos Froussios authored
gpu_tests.context_lost_integration_test.ContextLostIntegrationTest.ContextLost_WebGLUnblockedAfterUserInitiatedReload in context_lost_tests is flaky on Win10 Debug TBR=kbr@chromium.org Bug: 895765, 879423 Change-Id: Ic36400494df68f257329e040be2c72f1ad2ec3a6 Reviewed-on: https://chromium-review.googlesource.com/c/1283049 Commit-Queue: Christos Froussios <cfroussios@chromium.org> Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Cr-Commit-Position: refs/heads/master@{#599973}
-
Reza.Zakerinasab authored
TBR=fserb@chromium.org Bug: 894673 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I81df01f11d97763281b0282288ba3c068071eff6 Reviewed-on: https://chromium-review.googlesource.com/c/1281240Reviewed-by:
Mohammad Reza Zakerinasab <zakerinasab@chromium.org> Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org> Cr-Commit-Position: refs/heads/master@{#599972}
-
Ulan Degenbaev authored
Bug: 878390 Change-Id: I9415f702715ec0332720829f2e385f3787d77ec7 Reviewed-on: https://chromium-review.googlesource.com/c/1261982Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#599971}
-
Kurt Horimoto authored
The owners are kkhorimoto@ (original author), and gambard@ (reviewer). Bug: 880672 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I2d099c944b12e77c04106dc6de6de428824f1272 Reviewed-on: https://chromium-review.googlesource.com/c/1220720Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#599970}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/a81ac2dc02bf..5f1cbf4f7262 git log a81ac2dc02bf..5f1cbf4f7262 --date=short --no-merges --format='%ad %ae %s' 2018-10-16 fmayer@google.com Merge "Fix Chrome build." 2018-10-16 lalitm@google.com trace_processor: fix build 2018-10-16 lalitm@google.com trace_processor: add sort and filter support to counter table 2018-10-16 lalitm@google.com trace_processor: add diff testing for trace processor 2018-10-15 treehugger-gerrit@google.com Merge "profiling: Allow to set sampling rate on command line." 2018-10-15 lalitm@google.com trace_processor: fix build for Google3 2018-10-15 fmayer@google.com Merge "profiling: Add instructions for heapprofd" 2018-10-15 fmayer@google.com Fix GCC build. 2018-10-15 lalitm@google.com trace_processor: fix missing noexcept breaking build in Google3 2018-10-15 lalitm@google.com Merge "perfetto: switch sys stats counter to use proto lite not pzero" 2018-10-12 primiano@google.com Fix chromium builb - Consumer API 2018-10-12 hjd@google.com Merge "perfetto-ui: Add vsync track" 2018-10-11 primiano@google.com Fix gcc build 2018-10-11 primiano@google.com Add public API for Perfetto consumer 2018-10-11 primiano@google.com Merge "Remove cycling dependency between ftrace_proto_gen and protos" 2018-10-11 primiano@google.com Merge "Rename libtraced_shared to libperfetto" 2018-10-11 hjd@google.com Merge changes I83a22f93,I9bd0ea85 2018-10-11 treehugger-gerrit@google.com Merge "Remove UnixSocketTest::SendIsAtomic." 2018-10-11 treehugger-gerrit@google.com Merge "Watchdog: disable fatal timers if Watchdog is not enabled" 2018-10-11 primiano@google.com ftrace: Add kmem trace events 2018-10-11 primiano@google.com Merge "Fix libfuzzer GN target on mac standalone builds" 2018-10-08 lalitm@google.com perfetto: add Android-only target for merged proto for use in Java Created with: gclient setdep -r src/third_party/perfetto@5f1cbf4f7262 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:117596113,chromium:117604753,chromium:115601774,chromium:117460566,chromium:117295297 TBR=perfetto-bugs@google.com Change-Id: Ia6bc6236bbf1ff860e14979b65ce5455595128f0 Reviewed-on: https://chromium-review.googlesource.com/c/1283232Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#599969}
-
Raphael Kubo da Costa authored
These were removed in https://chromium-review.googlesource.com/c/chromium/src/+/1283150. Since the test are flaky, they happened to pass in the latest WPT import (which also updated them) despite some occasional failures in the Blink and CQ bots. Readd them to TestExpectations to prevent them from flaking in the future. TBR=foolip, robertma No-Try: True Change-Id: I9fa87e29900d5a84a8bef9493bc48cac930a77a9 Reviewed-on: https://chromium-review.googlesource.com/c/1283036Reviewed-by:
Raphael Kubo da Costa (CET) <raphael.kubo.da.costa@intel.com> Commit-Queue: Raphael Kubo da Costa (CET) <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#599968}
-
Patrik Höglund authored
I made a mistake in my earlier config CL: these tests are supposed to be swarmed. There are no phones on the Android tester so it fails when it tries to run locally. Bug: 877018 Tbr: kbr@chromium.org Change-Id: Id1cdef0c68ce3a50c9b7d2dec6bcd0d4c8f3e86b Reviewed-on: https://chromium-review.googlesource.com/c/1282950Reviewed-by:
Patrik Höglund <phoglund@chromium.org> Commit-Queue: Patrik Höglund <phoglund@chromium.org> Cr-Commit-Position: refs/heads/master@{#599967}
-
Chromium WPT Sync authored
Using wpt-import in Chromium c82467fd. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/26300 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, robertma@chromium.org, smcgruer@chromium.org: external/wpt/infrastructure guidou@chromium.org: external/wpt/mediacapture-streams meade@chromium.org: external/wpt/web-animations mkwst@chromium.org: external/wpt/trusted-types NOAUTOREVERT=true TBR=raphael.kubo.da.costa@intel.com No-Export: true Change-Id: I0574afa5e55c3f8e4fa8394d1adba1a82fb1b477 Reviewed-on: https://chromium-review.googlesource.com/c/1283150 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#599966}
-
Patrik Höglund authored
Appears you can't have filter files for non swarmed tests. Bug: 877018 Tbr: kbr@chromium.org Change-Id: If294ff3679889978fe27e7eced642b00f7102508 Reviewed-on: https://chromium-review.googlesource.com/c/1283289Reviewed-by:
Patrik Höglund <phoglund@chromium.org> Commit-Queue: Patrik Höglund <phoglund@chromium.org> Cr-Commit-Position: refs/heads/master@{#599965}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/dcefe396..4edb5e25 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Binary-Size: autoroller Change-Id: Ia5790cc18c21592bea054c2e41f4392cdcc5324a Reviewed-on: https://chromium-review.googlesource.com/c/1282395Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#599964}
-
David Bokan authored
The linked bug is a result of the fact that we send and handle browser controls state updates on both the main and compositor threads. When a non-animated hide is followed by a animated hide, we start an animation on the compositor thread but immediately hide the top controls on the main thread. When we commit the browser controls delta, the controls hide but the animation continues to play so the next frame re-shows the controls. Additional updates may stop the animation so we'd see the controls in a half-way hidden state. Currently, UpdateBrowserControlsState sends animated commands to be handled by CC (since Blink doesn't know how to animate), but because of https://crbug.com/754346, non-animated commands are sent to Blink. When the browser process sends a series of interweaved commands to the render this leads the the clamping bug discussed above. This CL fixes this issue by making the compositor-side the real source- of-truth and pushing the changes to Blink. Both CC and Blink must be made aware of the browser controls constraints, since scrolls may be handled by either. However, we now always inform CC first and let it push the differences to Blink. This happens as part of ApplyViewportChanges during a commit. Reland Note: The original patch broke MSAN as it forgot to initialize ScrollAndScaleSet::browser_controls_constraint_changed. This CL fixes that issue. TBR=enne@chromium.org,chrishtr@chromium.org,alexmos@chromium.org Bug: 861618 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I77964a893a9e376ceb29a69c6bef8b699801ed82 Reviewed-on: https://chromium-review.googlesource.com/c/1283249Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#599963}
-
Ned Nguyen authored
Bug: 894261 Change-Id: I6d161b6e1c7b7cbfe039fc15747f71acb3042f70 Reviewed-on: https://chromium-review.googlesource.com/c/1281170Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#599962}
-
Elly Fong-Jones authored
This change: 1) Has BridgedNativeWidgetHostImpl notify the owning Widget when it becomes minimized 2) Has session restore not activate minimized browser windows when selecting a restored tab 3) Has session restore not show a newly created browser window if it's minimized restore save; without this change, the widget will not get saved as minimized. window. On Mac, showing/activating a window implies de-minimizing it, so this is required to avoid de-minimizing saved minimized windows, but I think it is necessary on other platforms as well. Test steps: 1) Start Chromium 2) Create a second browser window (cmd-n) and minimize it 3) In the first window, chrome://restart Before this change, both browser windows appear after restart; after this change, the first window appears and the second stays minimized. Note that there is a graphical glitch when first restoring a window that is minimized this way: the window paints as blank for a few frames while running the deminiaturize animation. Bug: 888218 Change-Id: I8ac121408336a7d6aeedd2b27cd2c9c9d20a18f2 Reviewed-on: https://chromium-review.googlesource.com/c/1268396Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#599961}
-
Etienne Pierre-doray authored
This CL uses ScopedBlockingCall to mark blocking calls in /chrome/browser/ui/views/frame. This CL was created by replacing calls to AssertBlockingAllowed() with instantiations of ScopedBlockingCall(MAY_BLOCK). I kindly ask the reviewer to make sure of the following: - ScopedBlockingCall is instantiated in a scope with minimal CPU usage. If this is not the case, ScopedBlockingCall should be instantiated closer to the blocking call. See scoped_blocking_call.h for more info. Please let me know when/where the blocking call happens if this needs to be changed. - Parameter |blocking_type| matches expectation (MAY_BLOCK/WILL_BLOCK). See BlockingType for more info. While I assumed MAY_BLOCK by default, that might not be the best fit if we know that this callsite is guaranteed to block. - The ScopedBlockingCall's scope covers the entirety of the blocking operation previously asserted against by the AssertBlockingAllowed(). This CL was uploaded by git cl split. Bug: 874080 Change-Id: I6664a62f27ae599144ffcac09f43aaf48e1948d3 Reviewed-on: https://chromium-review.googlesource.com/c/1194328 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#599960}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/03c087e3eafe..2129101d5e9b Created with: gclient setdep -r src-internal@2129101d5e9b The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I98060f703178d72c816c660a306d19cf4c57230e Reviewed-on: https://chromium-review.googlesource.com/c/1283230Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#599959}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/eea449a1e82a..ab45d6915434 git log eea449a1e82a..ab45d6915434 --date=short --no-merges --format='%ad %ae %s' 2018-10-16 greg@lunarg.com Fix ADCE liveness to include all enclosing control structures. (#1975) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@ab45d6915434 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ifbb6ced7ea2fdda2eac74d6b11f44dcac657d934 Reviewed-on: https://chromium-review.googlesource.com/c/1283233Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#599958}
-
Justin Cohen authored
This is a reland of eb25f32f The CL was reverted with https://chromium-review.googlesource.com/c/chromium/src/+/1282949 but it looks like an infra problem instead TBR=justincohen@chromium.org,jbudorick@chromium.org Original change's description: > [ios] Move xcode-clang builders to Xcode 10. > > Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs > Change-Id: Ie5bdc140b82f49151ca891b39f65112bf6210eac > Reviewed-on: https://chromium-review.googlesource.com/c/1278332 > Reviewed-by: Justin Cohen <justincohen@chromium.org> > Reviewed-by: John Budorick <jbudorick@chromium.org> > Commit-Queue: Justin Cohen <justincohen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#599804} Change-Id: I335dff58404b7bab44a5eab3c5b0337b38a572e3 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/c/1283016 Commit-Queue: Christos Froussios <cfroussios@chromium.org> Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Cr-Commit-Position: refs/heads/master@{#599957}
-
Luke Zielinski authored
This field is always true going forward. Bug: 662944 Change-Id: I4dc3a3ac5aa5d7abf6d1a33b5f1a21f046881250 Reviewed-on: https://chromium-review.googlesource.com/c/1277867Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Commit-Queue: Luke Z <lpz@chromium.org> Cr-Commit-Position: refs/heads/master@{#599956}
-
Hitoshi Yoshida authored
Before this CL, IDL parser didn't accept types with extended atttributes as union members. This CL makes it possible. For example, ([TreatNullAs=EmptyString] DOMString or [Clamp] long) was an error, but it became acceptable. Bug: 894469 Change-Id: I2980256f5090f4465bef1b2a8665b0a9a9643b76 Reviewed-on: https://chromium-review.googlesource.com/c/1278614 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#599955}
-
Zhuoyu Qian authored
https://google.github.io/styleguide/cppguide.html#Namespace_Names > Namespace names are all lower-case. This CL has no behavior changes. Bug: 889726 Change-Id: I897e124f0320106f49bc9f7f99533d7cfd0b125b Reviewed-on: https://chromium-review.googlesource.com/c/1282644Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Zhuoyu Qian <zhuoyu.qian@samsung.com> Cr-Commit-Position: refs/heads/master@{#599954}
-
Brian Salomon authored
This also enables per-edge AA for tile quads in SkiaRenderer. Bug: skia:8444 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: Iaa14e6bd74128b838a5fcfac86789777d1936a7f Reviewed-on: https://chromium-review.googlesource.com/c/1266902Reviewed-by:
weiliangc <weiliangc@chromium.org> Commit-Queue: Brian Salomon <bsalomon@google.com> Cr-Commit-Position: refs/heads/master@{#599953}
-
Etienne Pierre-doray authored
This is a reland of 8aeb9cc9 Original change's description: > [TaskScheduler]: Add section to faq: when to annotate with ScopedBlockingCall. > > Developpers are often wondering whether or not ScopedBlockingCall is redundant. > > Change-Id: Ic7936ef805f43f7fc02d0ad3020c31d8364b099d > Reviewed-on: https://chromium-review.googlesource.com/c/1271878 > Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> > Reviewed-by: François Doray <fdoray@chromium.org> > Cr-Commit-Position: refs/heads/master@{#599626} Change-Id: I0850821994e3b4a1b0c3bb238725bc28867d18f5 Reviewed-on: https://chromium-review.googlesource.com/c/1280281 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#599952}
-
Lukasz Suder authored
It's the basic version, that asks for payment and shipping details. (billing address cannot be saved yet.) Bug: 806868 Change-Id: Ic2f55e659f8254b3088dd99d8b388446fcb0cf7d Reviewed-on: https://chromium-review.googlesource.com/c/1280767 Commit-Queue: Lukasz Suder <lsuder@google.com> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#599951}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/079a94f7aec0..70bac6b6f68d git log 079a94f7aec0..70bac6b6f68d --date=short --no-merges --format='%ad %ae %s' 2018-10-16 ahassani@chromium.org paygen: catch and ignore GSNoSuchKey exception when looking for payloads Created with: gclient setdep -r src/third_party/chromite@70bac6b6f68d The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Ib0640877c41bffcfca312f49bf825d6bb467004b Reviewed-on: https://chromium-review.googlesource.com/c/1282352Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#599950}
-