GitLab

...due to flakiness.

Bug: 892484
Change-Id: Ic947c7c7f9a7868249ec200e760ef3cdcf52ca1b
TBR: hnakashima@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/1264381Reviewed-by: Martin Šrámek <msramek@chromium.org>
Commit-Queue: Martin Šrámek <msramek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597060}

Bug: NONE
Change-Id: I596b793a81a4e4d29e05d7459b273028a96c4a99
Reviewed-on: https://chromium-review.googlesource.com/c/1264380Reviewed-by: Olga Sharonova <olka@chromium.org>
Commit-Queue: Olga Sharonova <olka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597059}

TestingFactory is a base::Callback<> while TestingFactoryFunction
is a function pointer. Convert ProfileInvalidationProviderFactory
to the callback based type.

Bug: 809610
Change-Id: Id6ddc4e75960f5fd1ed952877d4bebdca515b706
Reviewed-on: https://chromium-review.googlesource.com/c/1246166Reviewed-by: Bartosz Fabianowski <bartfab@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Pavel Yatsuk <pavely@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597058}

This CL allows media to play and be seekable when service worker
provides the response from cache storage.
Live demo from Jake Archibald: https://static-misc.glitch.me/sw-audio-bug/

This CL fixes two things:
- Supports blob responses from service worker for partial requests with
  a range of [x, -1] where x is not 0 (the zero case was already
  supported). This requires changes to
  ServiceWorkerLoaderHelpers::ReadBlobResponseBody and
  mojom.Blob.ReadRange().
- Sets ResourceResponseInfo.content_length based on the HTTP header
  Content-Length for service worker loaders. This allows Chromium's
  media code to allow seeking over the media source.

Bug: 892227
Change-Id: I9e6f6faaae7b83ad3aee9c0f217834d62c214b85
Reviewed-on: https://chromium-review.googlesource.com/c/1263739Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597057}

https://skia.googlesource.com/skia.git/+log/787bb77798ed..92d10833de63


git log 787bb77798ed..92d10833de63 --date=short --no-merges --format='%ad %ae %s'
2018-10-05 skia-bookmaker@skia-swarming-bots.iam.gserviceaccount.com Update markdown files


Created with:
  gclient setdep -r src/third_party/skia@92d10833de63

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
TBR=mtklein@chromium.org

Change-Id: Ie852c315e773c8c2ab5c47e35805b0cbc630592e
Reviewed-on: https://chromium-review.googlesource.com/c/1263867Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#597056}

TestingFactoryFunction is a simple function pointer. It is
deprecated in favor of TestingFactory which is a Callback<>.
Convert indirect uses by using base::BindRepeating() in all
invocation of SetTestingFactory/AddTestingFactory.

This converts uses in src//chrome/browser/ui/webui.

This CL was uploaded by git cl split.

R=calamity@chromium.org

Bug: 809610
Change-Id: I7c730e9e509e911411e693892b817ce8992517c6
Reviewed-on: https://chromium-review.googlesource.com/c/1259025Reviewed-by: calamity <calamity@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597055}

This CL implements these classes in Blink:
JSBasedEventListener                       (The base class for
 |                                          EventLisntener/EventHandler)
 +- JSEventListener                        (Implements EventListener)
 +- JSEventHandler                         (Implements EventHandler and
     |                                      other special types)
     +- JSEventHandlerForContentAttribute  (Supports lazy compilation
                                            for content attribute)
EventHandlers start to support incumbent realm using
blink::V8EventHandlerNonNull that inherits blink::CallbackFunctionBase.
(EventListener already supports incumbent realm.)

These four classes are no longer referenced from anywhere:
  blink::V8AbstractEventListener
  blink::V8EventListenerOrEventHandler
  blink::V8ErrorHandler
  blink::V8LazyEventListener
Although these are no longer necessary, this CL does not remove them
so that we can easily switch which classes to use in case new classes
contains some problems.

regarding crbug.com/759461 :
OnErrorEventHandler for content attribute, which has different number
of arguments, gets supported by blink::JSEventHandler and
blink::JSEventHandlerForContentAttribute.

regarding crbug.com/664676 :
|js_event| in the relevant realm of |event|'s target is created in
blink::JSBasedEventListener::handleEvent().

Bug: 872138, 849236, 759461, 664676, 606900
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I356734fc16611277ad9f3f279a676e7dc8083408
Reviewed-on: https://chromium-review.googlesource.com/c/1215512
Commit-Queue: Yuki Yamada <yukiy@google.com>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Hayato Ito <hayato@chromium.org>
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597054}

V8 API will deprecate the non maybe versions of v8::Object::Has
and v8::Object::Delete. Updated pepper implementation to use
maybe versions.

Bug: v8:7284
Change-Id: Ie582b1ef97f3943ba06e8f3f76d2225f9fffe616
Reviewed-on: https://chromium-review.googlesource.com/c/1254145
Commit-Queue: Mythri Alle <mythria@chromium.org>
Reviewed-by: Bill Budge <bbudge@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597053}

TestingFactoryFunction is a simple function pointer. It is
deprecated in favor of TestingFactory which is a Callback<>.
Convert indirect uses by using base::BindRepeating() in all
invocation of SetTestingFactory/AddTestingFactory.

This converts uses in src//chrome/browser/chromeos/file_manager.

This CL was uploaded by git cl split.

R=fukino@chromium.org

Bug: 809610
Change-Id: I08597fe6bfc322399ae478451c9f2f9091d87ae7
Reviewed-on: https://chromium-review.googlesource.com/c/1258175Reviewed-by: Naoki Fukino <fukino@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597052}

The test has a helper method CreateFormManager, which takes
a FormData argument and should build a NewPasswordFormManager
for that FormData.

However, due to a typo, that method always builds the NPFM
for |observed_form_| instead.

This CL fixes that typo.

Bug: 831123

Change-Id: Ibb313866f8f04d444f68f4af046716ac5ad264be
Reviewed-on: https://chromium-review.googlesource.com/c/1262515Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597051}

TestingFactoryFunction is a simple function pointer. It is
deprecated in favor of TestingFactory which is a Callback<>.
Convert indirect uses by using base::BindRepeating() in all
invocation of SetTestingFactory/AddTestingFactory.

This converts uses in src//chrome/browser/chromeos/extensions/users_private.

This CL was uploaded by git cl split.

R=emaxx@chromium.org

Bug: 809610
Change-Id: Ie2a188fc12106a28474818c9e57dc4dbac233841
Reviewed-on: https://chromium-review.googlesource.com/c/1258769Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597050}

TestingFactoryFunction is a simple function pointer. It is
deprecated in favor of TestingFactory which is a Callback<>.
Convert indirect uses by using base::BindRepeating() in all
invocation of SetTestingFactory/AddTestingFactory.

This converts uses in src//chrome/browser/extensions/api.

This CL was uploaded by git cl split.

R=tbarzic@chromium.org

Bug: 809610
Change-Id: Iff395f785271dc038e2e9e07f3569d91d956f27e
Reviewed-on: https://chromium-review.googlesource.com/c/1259034Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597049}

TestingFactoryFunction is a simple function pointer. It is
deprecated in favor of TestingFactory which is a Callback<>.
Convert indirect uses by using base::BindRepeating() in all
invocation of SetTestingFactory/AddTestingFactory.

This converts uses in src//chrome/browser/spellchecker.

This CL was uploaded by git cl split.

R=groby@chromium.org

Bug: 809610
Change-Id: Idc50a6ffd6c25fa2c321c0d39f4fa62412581a64
Reviewed-on: https://chromium-review.googlesource.com/c/1258918Reviewed-by: Rachel Blum <groby@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597048}

TestingFactoryFunction is a simple function pointer. It is
deprecated in favor of TestingFactory which is a Callback<>.
Convert indirect uses by using base::BindRepeating() in all
invocation of SetTestingFactory/AddTestingFactory.

This converts uses in src//chrome/browser/extensions/api/downloads.

This CL was uploaded by git cl split.

R=dtrainor@chromium.org

Bug: 809610
Change-Id: Ia28860b92100550ef7e0989566293b4e6ca302fd
Reviewed-on: https://chromium-review.googlesource.com/c/1258908Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597047}

TestingFactoryFunction is a simple function pointer. It is
deprecated in favor of TestingFactory which is a Callback<>.
Convert indirect uses by using base::BindRepeating() in all
invocation of SetTestingFactory/AddTestingFactory.

This converts uses in src//extensions/browser/api.

This CL was uploaded by git cl split.

R=tbarzic@chromium.org

Bug: 809610
Change-Id: Id9e8d81f60c29865b75ea219472a029c0ba7e487
Reviewed-on: https://chromium-review.googlesource.com/c/1257793Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597046}

This patch lets SignedExchangeSignatureVerifier ignore signature
timestamp errors if the Signed Exchange's main certificate is listed in
--ignore-certificate-errors-spki-list flag, and ContentBrowserClient::
CanIgnoreCertificateErrorIfNeeded() returns true.

This enables us to write layout tests and web-platform-tests for signed
exchange loading, without using UA-specific testing API that overrides
signature verification time.

This patch also removes setSignedExchangeVerificationTime() calls from
existing layout tests, because they already run with
--ignore-certificate-errors-spki-list flag. This means we lose layout
test coverage for expired SXG loading, so I added a test case in
signed_exchange_request_handler_browsertest.cc.

Bug: 803774
Change-Id: Ia2f9dc5f28036c30e76acc344137ab8873bfb7c6
Reviewed-on: https://chromium-review.googlesource.com/c/1253167
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597045}

Using wpt-import in Chromium 3a213f73.
With Chromium commits locally applied on WPT:
65d72632 "Make DTMF tone change more deterministic"


Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/25866

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

NOAUTOREVERT=true
TBR=markdittmer

No-Export: true
Change-Id: I6745f5932e622acf7f91d3d1aa34c94aea4ea8d9
Reviewed-on: https://chromium-review.googlesource.com/c/1263884
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597044}

TestingFactoryFunction is a simple function pointer. It is
deprecated in favor of TestingFactory which is a Callback<>.
Convert indirect uses by using base::BindRepeating() in all
invocation of SetTestingFactory/AddTestingFactory.

This converts uses in src//chrome/browser/ui/webui/sync_internals_message_handler_unittest.cc.

This CL was uploaded by git cl split.

R=jkrcal@chromium.org

Bug: 809610
Change-Id: Idd87a49ccd46ebc7d7aedd0a8cf47916fcd6fffd
Reviewed-on: https://chromium-review.googlesource.com/c/1258768Reviewed-by: Jan Krcal <jkrcal@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597043}

TestingFactoryFunction is a simple function pointer. It is
deprecated in favor of TestingFactory which is a Callback<>.
Convert indirect uses by using base::BindRepeating() in all
invocation of SetTestingFactory/AddTestingFactory.

This converts uses in src//chrome/browser/engagement.

This CL was uploaded by git cl split.

R=raymes@chromium.org

Bug: 809610
Change-Id: I903a5ae6c2d436837cfac97b3bfa1519be66bb1b
Reviewed-on: https://chromium-review.googlesource.com/c/1259013Reviewed-by: Raymes Khoury <raymes@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597042}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/fdd620c6..be4324e9

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I9d3728a514024eb16a3ff849278baef6b7688350
Reviewed-on: https://chromium-review.googlesource.com/c/1263886Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#597041}

Looks like GetExecutionContext() may return nulptr in terminate().

Bug: 884091
Change-Id: Ibd2756220a83ba490c0e23966650178e0b856423
Reviewed-on: https://chromium-review.googlesource.com/c/1264337
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597040}

For cr_dialog to behave modaaly, it's better to stop propagation of
'keydown' events. To support this, introduce consume-keydown-event
to cr_dialog. If this property is true, cr_dialog will consume
keydown events.


Bug: 883221
Change-Id: If2981794cad08dfa6dbca8e08d2d16351fad47bd
Reviewed-on: https://chromium-review.googlesource.com/c/1254001
Commit-Queue: Sang Woo Ko <sangwoo108@chromium.org>
Reviewed-by: calamity <calamity@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597039}

UMA metrics Sync.ModelTypeMemoryKB.<datatype> are often used to
compare two implementations of sync (pre-USS and USS), to analyze impact
on memory use, and expected to improve with USS.

With the recently introduced SyncableServiceBasedBridge, making a fair
comparison requires accounting for the memory consumed by the bridge
itself, which keeps an in-memory copy of all entities (similarly to the
legacy directory itself). In this patch, we implement such accounting,
by introducing a new method in ModelTypeSyncBridge.

Bug: 870624
Change-Id: Idd632f7bccdd39a530aa2a1c024e55604bd9ba17
Reviewed-on: https://chromium-review.googlesource.com/c/1264375Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597038}

Add addvice for base::Bind*

Currently we are told not to use something, but it's not always clear what
we should use instead. This allows adding advice for the correct alternative
to the forbidden identifies.

This reapplies 6592bd30, fixes a bug
in that and adds a test to validate the compiled config.

Change-Id: I4ac12f7748be3f7fbcc03de36e44f35a15cb033e
Reviewed-on: https://chromium-review.googlesource.com/c/1260127Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Fergal Daly <fergal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597037}

This change applies clang-tidy's modernize-use-auto [1] in /net.
This change does not rewrite new and cast expressions.

Reproduction steps:
- run clang-tidy's modernize-use-auto
- run git cl format
- manually remove unused typedefs due to -Wunused-local-typedef error
  in //net/test/url_request/url_request_slow_download_job.cc.

[1] https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-auto.html

This CL was uploaded by git cl split.

R=eroman@chromium.org

Bug: 890902
Change-Id: Idf97f430cc571be05d1b69615d43ff34ef1ce64d
Reviewed-on: https://chromium-review.googlesource.com/c/1257843Reviewed-by: Eric Roman <eroman@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597036}

If a model (or SyncableService) reports an error, let's plumb it through
to base::debug::DumpWithoutCrashing() via ReportUnrecoverableError(),
which does it only for canary&dev channels, with random sampling. This
achieves feature parity with the directory-based setup and may allow
future investigations if we see datatypes with high error rates.

Bug: 870624
Change-Id: Idb3d00b178167a8b7b9eabb560858197e03aecb2
Reviewed-on: https://chromium-review.googlesource.com/c/1264198Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597035}

This patch just removes the functions.

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: Ie0bcda4080ff4390cf29cad4661dca67ead9ad44
Reviewed-on: https://chromium-review.googlesource.com/c/1264156Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597034}

This reverts commit d270ec39.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 596972 as the
culprit for flakes in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vZDI3MGVjMzkwMmFmZTU4OTg4MjM0ODMyYjdjMzNmN2U1Y2U5MmFhNgw

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-dbg/8178

Sample Failed Step: viz_browser_tests

Sample Flaky Test: GalleryBrowserTest.DeleteSingleOpenPhotoOnDownloads

Original change's description:
> Hide filename edit field when there is no image
> 
> Hide |filenameEdit_| line edit box when there is no image to be displayed.
> This fixes an undesired grey line appearing as the bottom of this edit box.
> Changing the "disabled" state doesn't change the style of this box,
> "disabled" state is only used for read-only behaviour not style.
> 
> R=fukino@chromium.org
> 
> Bug: 796503
> Change-Id: I6fc9a4eb218231781325ba7a5af992b12610b929
> Reviewed-on: https://chromium-review.googlesource.com/c/1212263
> Reviewed-by: Noel Gordon <noel@chromium.org>
> Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
> Commit-Queue: Alexander Nohe <nohe@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#596972}

Change-Id: I5a64c57351cc39d641af6052567c8f8d150542cc
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 796503, 892543
Reviewed-on: https://chromium-review.googlesource.com/c/1263887
Cr-Commit-Position: refs/heads/master@{#597033}

This change adds a highlight element action which updates the css shadow of a
given element.

R=gogerald@chromium.org

Bug: 806868
Change-Id: Ife28259e4020721fd87487770b154c452425a48c
Reviewed-on: https://chromium-review.googlesource.com/c/1262555
Commit-Queue: Mathias Carlen <mcarlen@chromium.org>
Reviewed-by: Ganggui Tang <gogerald@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597032}

This change adds code to react when a Trusted Web Activity client is
uninstalled or has its data wiped. Currently it does nothing on this
trigger, that will come in a later CL.

Bug: 888447
Change-Id: I354e5d0ade9327659f198e9ba099875daf89f378
Reviewed-on: https://chromium-review.googlesource.com/c/1243485
Commit-Queue: Peter Conn <peconn@chromium.org>
Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597031}

This CL may cause a small binary size increase, roughly proportional
to how long it's been since our last AFDO profile roll. For larger
increases (around or exceeding 100KB), please file a bug against
gbiv@chromium.org. Additional context: https://crbug.com/805539

Please note that, despite rolling to chrome/android, this profile is
used for both Linux and Android.

The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=gbiv@chromium.org

Change-Id: I2a8532f6292c4d8f79a3d153bd66c3058409f994
Reviewed-on: https://chromium-review.googlesource.com/c/1263868Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#597030}

This change applies clang-tidy's modernize-use-auto [1] in /chrome/browser/sync_file_system.
This change does not rewrite new and cast expressions.

Reproduction steps:
- run clang-tidy's modernize-use-auto
- run git cl format
- manually remove unused typedefs due to -Wunused-local-typedef error

[1] https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-auto.html

This CL was uploaded by git cl split.

R=nhiroki@chromium.org

Bug: 890902
Change-Id: I787a26b538cb11b45a42dbf4573fcf7adef06e75
Reviewed-on: https://chromium-review.googlesource.com/c/1257907Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597029}

Now we have the QuickView <webview> infra to detect the 'loaded' state
of thew <webview> content, add a <file-safe-media> video test and also
check the <webview> renders its content on a transparent black body.

Bug: 891150
Change-Id: I634a60ba733bfff79ed72b0e75d7024da4c8182c
Reviewed-on: https://chromium-review.googlesource.com/c/1264097
Commit-Queue: Noel Gordon <noel@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597028}

Added a comment to LayoutInline, pointing out that LayoutNG is doing the
right thing already, while legacy is wrong.

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I026404af70c33b0a94900773636d5e138a725976
Reviewed-on: https://chromium-review.googlesource.com/c/1261436Reviewed-by: Aleks Totic <atotic@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597027}

Feature toggles cannot change during runtime, so let's make sure the
final values are fixed before a profile is created for tests. This fixes
flakiness in TSAN bots due to recent unrelated changes, where a
KeyedService's backend thread reads a feature toggle (although the
feature is unrelated to this test suite).

TBR=rockot@chromium.org

Bug: 891906
Change-Id: I385c8d5ff38c660d84465cbaaa1bcbeca6b9482a
Reviewed-on: https://chromium-review.googlesource.com/c/1264161Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597026}

external/wpt/interfaces.html was removed in http://crrev.com/c/1154644.
Remove dangling interfaces-expected.

Bug: N/A
Change-Id: Ibff4c1f20dee384c4d4df2c45f4a140623003527
Reviewed-on: https://chromium-review.googlesource.com/c/1263637Reviewed-by: Fredrik Söderquist <fs@opera.com>
Commit-Queue: Amos Lim <eui-sang.lim@samsung.com>
Cr-Commit-Position: refs/heads/master@{#597025}

Bug: 891150
Change-Id: I571b3ec2d402d9eee7bf49eae65d3bec8f6c2132
Reviewed-on: https://chromium-review.googlesource.com/c/1264096
Commit-Queue: Noel Gordon <noel@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597024}

This CL introduces two counters.

- kFormDisabledAttributePresent
  'disabled' attribute is updated on <form> elements.

- kFormDisabledAttributePresentAndSubmit
  A <form> element is submitted while it has 'disabled' attribute.

Background:
In WHATWG HTML, we're discussing on adding 'disabled' content attribute
to <form>. It will prevent form submission though no browsers implement
it now.
We're afraid there are web sites using 'disabled' attribute on <form>,
and they will stop working if browsers implement 'disabled' attribute.
This CL add counters to know how many such sites and how many sites
will be broken.  If the numbers are high, we may change the attribute
name, or we won't standardize it.

Bug: https://github.com/whatwg/html/issues/3682
Change-Id: Id4daa27ebdb3600b00b47c0e82814673243c37aa
Reviewed-on: https://chromium-review.googlesource.com/c/1263679
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597023}

https://skia.googlesource.com/skia.git/+log/4f87e2255b8a..787bb77798ed


git log 4f87e2255b8a..787bb77798ed --date=short --no-merges --format='%ad %ae %s'
2018-10-05 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset


Created with:
  gclient setdep -r src/third_party/skia@787bb77798ed

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
TBR=mtklein@chromium.org

Change-Id: I15ba57e68fc6a771eda3819f7f7eeb6bf1f3891e
Reviewed-on: https://chromium-review.googlesource.com/c/1263865Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#597022}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7659b7123080..30f82e022cc4


Created with:
  gclient setdep -r src-internal@30f82e022cc4

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: Ib9b4a4c7b952f1261802cf74ed0f19ea4f116d92
Reviewed-on: https://chromium-review.googlesource.com/c/1263866Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#597021}