GitLab

This reverts CL 779191.

Wraps omnibox textfield into a container that positions the textfield
inside of itself and clips its bounds so that the optimal clipping is
used. The clipping logic replicates that of the pre-iOS 11 solution
with UITextField overrides that are now broken in iOS 11.
To mask the clipped ends of the omnibox, a ClippingMaskView is used
as a maskView of the clipping view.
All of this is behind kClippingTextfield flag that is enabled by
default.

Bug: 749788
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I4cc6673200a8fbdc57451dc9120dfd4eeec5a853
Reviewed-on: https://chromium-review.googlesource.com/844079
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526693}

A late arriving CompositorFrame should not activate if the dependent CF has
been dropped. This can happen if a CompositorFrame is marked for destruction
and then pulled out of the destruction queue ("surface resurrection").

This CL ensures that when a surface is reset, a SurfaceDiscarded notification
is sent to the SurfaceDependencyTracker followed by SurfaceCreated to mimic
creating a new surface.

Bug: 796602
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: I20d1e96526db6464f9a095d59ea9633f81ddd615
TBR: samans@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/848633
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526692}

TEST=PaymentRequestPaymentAppTest*

Bug: 781287
Change-Id: I81317d3b6299b5617c1886e37596dcbb7f4435de
Reviewed-on: https://chromium-review.googlesource.com/814575
Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526691}

ScriptExecutionCallbackHelper is the name of two different
helper functions which in some non-standard jumbo configurations
(huuuge jumbo chunks) end up in the same translation unit. This
patch changes the scope of one of the classes to not clash.

Bug: 745732
Change-Id: Ifed9bcd247c43afb110c9b008062383a2a7d74df
Reviewed-on: https://chromium-review.googlesource.com/848835Reviewed-by: Fredrik Söderquist <fs@opera.com>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#526690}

Demangle failure may cause superficial diffs between .size ELFs
created from Gold (using c++filt) vs. from LLD (using llvm-cxxfilt).
This CL logs the number of such failures, using the '_Z' prefix as
a heuristical indicator.

Bug: 723798
Change-Id: I1ffa247939f5efccfb66ebfddaf781adc0203496
Reviewed-on: https://chromium-review.googlesource.com/846530Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: Samuel Huang <huangs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526689}

Since there is only one implementation of TouchEventQueue now it no
longer needs to have a pure virtual interface. Instantiate the
concrete class always.

BUG=None
TBR=jochen@chromium.org

Change-Id: If267c326e7008bca6685b9a0734c7eb3e95f9318
Reviewed-on: https://chromium-review.googlesource.com/846313
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Mustaq Ahmed <mustaq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526688}

This CL deprecates Net.URLRequestContext.OutstandingRequests and
Net.URLRequestContext.OutstandingRequests.Type histograms.

This CL left URLRequestAnnotationType in
tools/metrics/histograms/enums.xml as is, because enums.xml
doesn't need deprecation.

We know from these histograms that majority of users have
reasonable number of outstanding requests. In fact, 50th
percentile of users on desktop and on mobile have < 100
outstanding requests for a URLRequestContext. Most of requests
that become outstanding are from blink resource loader.
There are pathological cases where a single URLRequestContext
has more than 20k outstanding requests, but we do not know what
caused those cases. These histograms won't help us on that
either. They are taking a lot of space, so I am removing them
ahead of M65 branch date

This CL essentially reverts the following commits:

- "Add UMA to track the number of live URLRequests."
  crrev.com/3fcbcc19.
- "Use NetworkTrafficAnnotation in URLRequestContext UMA logging"
  crrev.com/669c3102

Bug:711721, 797615

Change-Id: Idc3a5ae5f8cc32b2d12d00881a58be02745d68ca
Reviewed-on: https://chromium-review.googlesource.com/847455
Commit-Queue: Helen Li <xunjieli@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526687}

Bug: 793267
Change-Id: Ia3bfa5852b2d00031a8467e75b4ee9f686397660
Reviewed-on: https://chromium-review.googlesource.com/816869Reviewed-by: Ted Choc (back but slow, ping me) <tedchoc@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Peter Conn <peconn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526686}

Change-Id: Ifccfac91fe63ea626d885c65b7c4a7e57bb021de
Reviewed-on: https://chromium-review.googlesource.com/848917
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526685}

Chrome implementation: https://chromium-review.googlesource.com/c/615424
W3C UIEvents issue: https://github.com/w3c/uievents/issues/154

BUG=488886

Change-Id: I732ef83ea7ca916d564d3af0419f4da0e3db1d45
Reviewed-on: https://chromium-review.googlesource.com/615146
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Mustaq Ahmed <mustaq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526684}

https://skia.googlesource.com/skia.git/+log/ecdadd98e0ae..aebad197dcaf

$ git log ecdadd98e..aebad197d --date=short --no-merges --format='%ad %ae %s'
2018-01-03 angle-skia-autoroll Roll skia/third_party/externals/angle2/ 910a3dafd..d8724a947 (1 commit)

Created with:
  roll-dep src/third_party/skia


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=jcgregorio@chromium.org

Change-Id: Ic36bac7906748c356da43f913ca55d5aa41ecee7
Reviewed-on: https://chromium-review.googlesource.com/848741Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526683}

Expectation should fit for Win7 and Win10.

Bug: 796926
Change-Id: I6a05bfddfe7ab65597e4a6a65463c9cdf071cd88
Tbr: rogerm@chromium.org, eae@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/846981
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Reviewed-by: Dominik Röttsches <drott@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526682}

Bug: 760317
Change-Id: I70f61a33dac932d7f28502e3abc46f81a59b1260
Reviewed-on: https://chromium-review.googlesource.com/847288Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526681}

When a surface is evicted and then is "resurrected", we drop the active and pending
frame. However, we do not return resources or call draw callbacks. This prevents video
from updating the content in its texture. In this CL, if a surface is resurrected
to the same client, then we return resources and call draw callbacks on the previously
held frames.

Bug: 796541
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: I12e8c8a31324887afe24300bc1b8ccbb4354ec86
Reviewed-on: https://chromium-review.googlesource.com/847336
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Saman Sami <samans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526680}

This reverts commit f5c15f9c.

Reason for revert: Breaks https://ci.chromium.org/buildbot/chromium.win/Win%207%20Tests%20x64%20(1)/32917

Original change's description:
> [oilpan] Fix stack limit check for recursive tracing
> 
> The limit was defined as ~0ul (unsigned long) which is unsigned 32bit on Windows
> 64bit and thus extended with 0 for uintptr_t. This results in bogus return of
> StackFrameDepth::IsSafeToRecurse of true even though recursion might be disabled
> due to stack pressure.
> 
> Bug: chromium:798479
> Change-Id: I13710b3dca4d3785e35aedd8ba5f7ece167b20e4
> Reviewed-on: https://chromium-review.googlesource.com/847580
> Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#526666}

TBR=haraken@chromium.org,mlippautz@chromium.org

Change-Id: I11083aa7a596161e556f1f03521105db36f91668
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:798479
Reviewed-on: https://chromium-review.googlesource.com/848853Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526679}

The SigninPromoViewMediator should not be deallocated until the sign-in
is finished. When the user clicks on "Continue as ...", the sign-in
is done as soon as the sign-in dialogs arrives.

RecentTabsTableViewController should not be updated as long as the
sign-in started by SigninPromoViewMediator is in progress.

Once the sign-in is done, the RecentTabsTableViewController can be
reloaded.

cronet;master.tryserver.chromium.mac:ios-simulator-full-configs

Bug: 798443
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I4a0937986e236473a7c0314c056cf437a0088c36
Reviewed-on: https://chromium-review.googlesource.com/846995
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526678}

Bug: 755727
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: I25f46d97d5ba065edd15aeeb9fc31cc4747354ee
Reviewed-on: https://chromium-review.googlesource.com/846645
Commit-Queue: Jinho Bang <jinho.bang@samsung.com>
Reviewed-by: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526677}

GenericURLRequestJob already reads cookies, but it didn't write them.

Bug: 
Change-Id: I2b3b93d652e8c3a79c6f8bb854b0ddec84fe1a93
Reviewed-on: https://chromium-review.googlesource.com/848993Reviewed-by: Eric Seckler <eseckler@chromium.org>
Commit-Queue: Alex Clarke <alexclarke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526676}

Bug: 755727
Change-Id: I561768ad3d03c177a90a1917d489abab53805973
Reviewed-on: https://chromium-review.googlesource.com/846647Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Jinho Bang <jinho.bang@samsung.com>
Cr-Commit-Position: refs/heads/master@{#526675}

Bug: 755727
Change-Id: Ie2f107a708ee7d4dcd90a8067aa8d43e13c410a9
Reviewed-on: https://chromium-review.googlesource.com/846646Reviewed-by: Kazuhiro Inaba <kinaba@chromium.org>
Commit-Queue: Jinho Bang <jinho.bang@samsung.com>
Cr-Commit-Position: refs/heads/master@{#526674}

Removes most usage of scoped_nsobject in ios/, except

- ios/web/net/request_tracker_impl.{h|mm}
- ios/web/public

Bug: 717540
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I02cff4e1786f7405d055faf1ca7f8b1cc40ac417
Reviewed-on: https://chromium-review.googlesource.com/846803
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526673}

As promised in

https: //chromium-review.googlesource.com/c/chromium/src/+/847476#message-b6237dac069f8501f2ece3d48bff044e49a5260e
Change-Id: I27b97ae09db0a26660f7d44df8082dac5c8da250
Reviewed-on: https://chromium-review.googlesource.com/848912Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526672}

https://webrtc.googlesource.com/src.git/+log/9cc67dc56e08..731082ce7ea6

$ git log 9cc67dc56..731082ce7 --date=short --no-merges --format='%ad %ae %s'

Created with:
  roll-dep src/third_party/webrtc


The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I624ac6b42a58c7fb890bed749e3fd5ca2b4ac60b
Reviewed-on: https://chromium-review.googlesource.com/848738
Commit-Queue: WebRTC Roll Bot <webrtc-autoroll@chromium.org>
Reviewed-by: WebRTC Roll Bot <webrtc-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526671}

(for real this time)

TBR=nednguyen@google.com
NOTRY=true

Bug: 797261
Change-Id: I68bf8771f4b3eb0b8e0cd662b87067b805b8a259
Reviewed-on: https://chromium-review.googlesource.com/848933Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526670}

This CL changes AccountManagerFacadeTest to use
LocalRobolectricTestRunner instead of BaseJUnit4ClassRunner.

Bug: 779568
Change-Id: I2ed4af8c6ee239fbbb8c888cc41259f5ad643cfc
Reviewed-on: https://chromium-review.googlesource.com/846744Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Ted Choc (back but slow, ping me) <tedchoc@chromium.org>
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526669}

Chromium allowed std::initializer_list soon after base::Optional was
added to the codebase [1,2], rendering the top level comment incorrect.
This change introduces appropriate overloads for the construcor,
emplace() and make_optional().

[1] https://crrev.com/53f6b258355ce36752ea7a8dcf8953560b5be818
[2] https://crrev.com/0fcb776029fb1380c8e8c9d4cbdcaf7a217ddb5c

Bug: 521269
Change-Id: Iba10136c8ff84d4aa1f77148f8dc238db5c1be4c
Reviewed-on: https://chromium-review.googlesource.com/840008
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526668}

content::NavigationData is a copyable interface for embedders to pass
opaque data to content/.

To make the NetworkService or the NavigationMojoResponse features work,
we need to pass this object with mojo. This isn't possible
since content/ doesn't know how to serialize it.

This CL removes content::NavigationData. To mitigate its removal, a
base::Value can be used instead.

This CL implements the ChromeNavigationData <=> base::Value conversion.

Bug: 705744
Change-Id: I49e2bf617322200b0dfe1462da94880fc6651b8f
Reviewed-on: https://chromium-review.googlesource.com/817556
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526667}

The limit was defined as ~0ul (unsigned long) which is unsigned 32bit on Windows
64bit and thus extended with 0 for uintptr_t. This results in bogus return of
StackFrameDepth::IsSafeToRecurse of true even though recursion might be disabled
due to stack pressure.

Bug: chromium:798479
Change-Id: I13710b3dca4d3785e35aedd8ba5f7ece167b20e4
Reviewed-on: https://chromium-review.googlesource.com/847580
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526666}

In order to move the behavior of PrimaryAccountAccessTokenFetcher closer
to what it will be once it is interacting with the Identity Service, I
will shortly be changing this class to fetch
access tokens strictly asynchronously (by posting a task to the current
message loop to call into ProfileOAuth2TokenService). In particular,
this change is necessary to preserve the expected ordering with other
soon-to-be-introduced IdentityManager APIs that will interact
asynchronously with ProfileOAuth2TokenService (e.g., to invalidate
access tokens).

The RemoteSuggestionsFetcher unittests currently assume that
AccessTokenFetcher interacts synchronously with PO2TS. This CL relaxes
these assumptions so that the tests will continue to work as-is when the
above change is made.

Bug: 654990
Change-Id: Ic61fd2bf9ef4ffdbba82c7eeff5f54e3766f310b
Reviewed-on: https://chromium-review.googlesource.com/844675
Commit-Queue: Colin Blundell <blundell@chromium.org>
Reviewed-by: Jan Krcal <jkrcal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526665}

In order to move the behavior of PrimaryAccountAccessTokenFetcher closer
to what it will be once it is interacting with the Identity Service, I
will shortly be changing this class to fetch
access tokens strictly asynchronously (by posting a task to the current
message loop to call into ProfileOAuth2TokenService). In particular,
this change is necessary to preserve the expected ordering with other
soon-to-be-introduced IdentityManager APIs that will interact
asynchronously with ProfileOAuth2TokenService (e.g., to invalidate
access tokens).

The SubscriptionManager unittests currently assume that
AccessTokenFetcher interacts synchronously with PO2TS. This CL relaxes
these assumptions so that the tests will continue to work as-is when the
above change is made.

Bug: 654990
Change-Id: Ib0a863c0b00133379819319129e1a49a46647d88
Reviewed-on: https://chromium-review.googlesource.com/844575
Commit-Queue: Colin Blundell <blundell@chromium.org>
Reviewed-by: Jan Krcal <jkrcal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526664}

In order to move the behavior of PrimaryAccountAccessTokenFetcher closer
to what it will be once it is interacting with the Identity Service, I
will shortly be changing this class to fetch
access tokens strictly asynchronously (by posting a task to the current
message loop to call into ProfileOAuth2TokenService). In particular,
this change is necessary to preserve the expected ordering with other
soon-to-be-introduced IdentityManager APIs that will interact
asynchronously with ProfileOAuth2TokenService (e.g., to invalidate
access tokens).

The PrimaryAccountAccessTokenFetcher unittests currently assume that
AccessTokenFetcher interacts synchronously with PO2TS. This CL relaxes
these assumptions so that the tests will continue to work as-is when the
above change is made.

Bug: 654990
Change-Id: I9f3c8bef926ece573480123136b82df42e71abbc
Reviewed-on: https://chromium-review.googlesource.com/844595
Commit-Queue: Colin Blundell <blundell@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526663}

In order to move the behavior of PrimaryAccountAccessTokenFetcher closer
to what it will be once it is interacting with the Identity Service, I
will shortly be changing this class to fetch
access tokens strictly asynchronously (by posting a task to the current
message loop to call into ProfileOAuth2TokenService). In particular,
this change is necessary to preserve the expected ordering with other
soon-to-be-introduced IdentityManager APIs that will interact
asynchronously with ProfileOAuth2TokenService (e.g., to invalidate
access tokens).

The ContextualSuggestionsFetcher unittests currently assume that
AccessTokenFetcher interacts synchronously with PO2TS. This CL relaxes
these assumptions so that the tests will continue to work as-is when the
above change is made.

Bug: 654990
Change-Id: Ia1ee647c3c97af9482e21c2605e1dcd5a4af7894
Reviewed-on: https://chromium-review.googlesource.com/844596
Commit-Queue: Colin Blundell <blundell@chromium.org>
Reviewed-by: Jan Krcal <jkrcal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526662}

https://webrtc.googlesource.com/src.git/+log/fa2260d08dcf..9cc67dc56e08

$ git log fa2260d08..9cc67dc56 --date=short --no-merges --format='%ad %ae %s'

Created with:
  roll-dep src/third_party/webrtc
BUG=None


The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I8e7bd203f2a6220d8df060c2673cf85de402ca89
Reviewed-on: https://chromium-review.googlesource.com/848493Reviewed-by: WebRTC Roll Bot <webrtc-autoroll@chromium.org>
Commit-Queue: WebRTC Roll Bot <webrtc-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526661}

TBR=wangxianzhu@chromium.org

Bug: 798116
Change-Id: I39eb1eb0ad4cb300066c278e4150670bc69cdfdc
Reviewed-on: https://chromium-review.googlesource.com/848773Reviewed-by: Dominic Battré <battre@chromium.org>
Commit-Queue: Dominic Battré <battre@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526660}

This CL removes kTabModelTabDidFinishLoadingNotification, the last TabModel notification.

The sole consumer of it was ChromeOverlayWindow, which used it to (on iPad-idiom devices)
record the size class at each page load.

Because the method used to record this metric was state-independent, it can be changed
to a class method. This CL removes the call site in ChromeOverlayWindow (and all associated
notification code) and moves it to the appropriate TabModelObserver method in the BVC.

Bug: 320877
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I2d42755ffdbd7480d500b1f89c30be9e347dd2b2
Reviewed-on: https://chromium-review.googlesource.com/847005Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526659}

Removed WebStorageQuotaDispatcherCallback and replace usages with
WebStorageQuotaCallbacks directly.

Later, WebStorageQuotaCallbacks will be removed as well and replaced
with a mojo callback type.

Bug: 781643
Change-Id: Ie233b20ad3d676ba0df220caefe05ac3ecd59ebf
Reviewed-on: https://chromium-review.googlesource.com/833438
Commit-Queue: Sasha Morrissey <sashab@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526658}

As a part of Onion Soup, the screen_orientation_dispatcher will be
moved into blink where the base::IDMap is not allowed to use. So we
remove the base::IDMap first in this CL, which makes the next moving
step easier.

BUG=678545

Change-Id: Id46a80d07c4da90ce8807b1e97a9bee947b1944f
Reviewed-on: https://chromium-review.googlesource.com/846699
Commit-Queue: Ke He <ke.he@intel.com>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526657}

This CL removes kTabModelAllTabsDidCloseNotification, one of the two remaining TabModel
notifications. StackViewController was its only observer.

This CL moves the notification into a TabModelObserver method. Since StackViewController isn't
a TabModelObserver itself, a method is added to CardSetObserver (since the card sets are the
objects that observe the tab models in the stack view).

Prior to this CL, the flow of events when closing all tabs in the stack view was:

[1] The card set whose cards are being deleted (in removeAllCardsFromSet:) calls
    [cardSet setIgnoresTabModelChanges:YES].
[2] The cards are animated out
[3] A completion handler is called when the animation completes; it calls -closeAllTabs on the
    cardSet's TabModel.
[4] The tab model deletes the tabs and sends the kTabModelAllTabsDidCloseNotification
[5] StackViewController catches the notification and calls -allModelTabsHaveClosed:, which in
    turn sets [cardSet setIgnoresTabModelChanges:NO]

It's important to note that [cardSet setIgnoresTabModelChanges:NO] removes |cardSet| as a
TabModelObserver. Functionally in this flow, tab model observation is disabled, then the
notification is used to bypass the disabled observation and to signal that observation should be
reenabled.

After this CL some of the steps in the above flow are changed:
[3] A completion handler is called when the animation completes; it calls
    [cardSet setIgnoresTabModelChanges:NO] and then -closeAllTabs on the cardSet's TabModel.
[4] The tab model deletes the tabs and tells its observers.
[5] CardSet (a TabModelObserver) gets the -tabModelClosedAllTabs call and sends its observer
    a cardSetDidCloseAllTabs: method.
[6] StackViewController gets the cardSetDidCloseAllTabs: call and handles the cleanup.

Bug: 320877
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I98ac82d272d696f2182aa54c5b603cf6c737e073
Reviewed-on: https://chromium-review.googlesource.com/847004
Commit-Queue: Mark Cogan <marq@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526656}

When a page is opened, unless the page auto-focuses an element,
the document <body> is the activeElement (aka focused element).

In this case, spatnav uses heuristics in its search for the next
focusable element to navigate to: the search starts at the visual
viewport.

This fixes the regression (caused by an adaption to root layer
scrolling) described in the bug as well as adding 3 automated
tests that check that spatnav correctly uses the visual viewport.

Bug: 796493

Change-Id: Ie6cd71deaf1d7d7b100792feeaef57ab3fbff903
Reviewed-on: https://chromium-review.googlesource.com/847513Reviewed-by: Steve Kobes <skobes@chromium.org>
Commit-Queue: Hugo Holgersson <hugoh@vewd.com>
Cr-Commit-Position: refs/heads/master@{#526655}

Previously, UpdateWallpaper() is needed in the WallpaperDelegate
interface because it relies on Chrome to set the correct image. After
everything is migrated, it no longer needs to call into Chrome.
(Eventually WallpaperDelegate will be deleted as well.)

All the tests in |wallpaper_manager_browsertest.cc| have been migrated
(some of them are deleted because they have been disabled for a long
time). But there is some untested code path in wallpaper_manager and
we'll add more tests in follow-up CLs.

TBR=oshima@chromium.org

Bug: 779221, 794725
Change-Id: I81b0a0b6b2a96423a1191054e154761b10304382
Reviewed-on: https://chromium-review.googlesource.com/826325Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526654}