- 13 Jun, 2019 40 commits
-
-
Robbie McElrath authored
StoragePartition::GetURLRequestContext won't work with the network service enabled. Bug: 966633 Change-Id: Ic1442e75315fa3e84d5e155c188ae5707cfa29de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659198Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#668968}
-
Robert Sesek authored
Granted: - com.apple.security.device.audio-input and .camera for WebRTC. - com.apple.security.device.bluetooth for WebBluetooth and WebAuthn. - com.apple.security.device.usb for WebUSB and WebAuthn. - com.apple.security.device.print for printing. Not granted because testing did not reveal them to be necessary: - com.apple.security.device.microphone: The difference between this entitlement and .audio-input is undocumented. The .microphone key is associated with the App Sandbox, which Chrome does not use, while .audio-input is associated with CoreAudio, which is used. - com.apple.security.automation.apple-events: Chrome only sends one Apple event, and that goes to another instance of itself when the ProcessSingleton detects another instance of Chrome running. - com.apple.security.personal-information.location: This entitlement is only needed for CoreLocation, which Chrome does not use for the Geolocation API. Bug: 850193 Change-Id: Ie10b39d9be5dca35526d797dbd35f6ecb0037e08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1620286 Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#668967}
-
Jimmy Gong authored
- Regression was introduced when PPD label div was added. - Fix is to align item with flex. - Removed min-height for this css style as it was never used. Bug: 972003 Test: End to End Manual Change-Id: I347e5dcf233e320aed843ede13d10ca46e71b5d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1656736Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: jimmy gong <jimmyxgong@chromium.org> Cr-Commit-Position: refs/heads/master@{#668966}
-
Eugene But authored
This changes makes ios_web_shell_egtests consistent with ios_chrome_egtests, which were updated in crrev.com/c/1650271 to serve files from module instead of runner. Bug: 866147 Change-Id: I5764180c0ecb85c2719242b98cd99577231d7a98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1654280Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#668965}
-
Kenneth Russell authored
Run the same set of tests on both to ensure that all test suites run correctly when triggered from the Linux VM. Bug: 952071 Change-Id: I877509f20f837f73927419df8fa2a7fc3e634142 No-Try: True Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659027 Auto-Submit: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#668964}
-
Roberto Carrillo authored
These will now be triggered by the all-platforms-code-coverage builder from a separate bucket. R=liaoyuke,nodir Bug: 944752 Change-Id: I1a032995175fadd3147d1e005826eef5b58e318c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1656435Reviewed-by:
Nodir Turakulov <nodir@chromium.org> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Auto-Submit: Roberto Carrillo <robertocn@chromium.org> Cr-Commit-Position: refs/heads/master@{#668963}
-
Chris Lu authored
Fixes a bug where an accessibility element would be present for the Infobar Badge even when it was not visible. This change adds and removes the badge as an accessibility element when the badge is being displayed/hidden. Change-Id: I618ee3f7b684cb479fc70fbafbd329b99e27e18c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1652045 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#668962}
-
Fabrice de Gans-Riberi authored
Zircon VMOs are now created non-resizeable by default. This family of flags is now a no-op and they will soon be removed. Bug: 973981 Change-Id: I4d319641b85c402e05a2975ec6d0f7540ac769d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659021 Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Auto-Submit: Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#668961}
-
Fabrice de Gans-Riberi authored
* The zx_vmo_clone syscall was renamed in Zircon. * Also remove uses of the ZX_VMO_*NON_RESIZEABLE in the same file. This macro is now a no-op and will soon be removed from Zircon. Bug: 973978, 973981 Change-Id: Ia544daa03627b73af496183847067e019253109e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659017 Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Auto-Submit: Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by:
-
Misha Efimov authored
Change-Id: Ife8ee2b69f6fa6efff15f2905e39e3b8c20ba66d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1652656Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#668959}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I4de3240c3e3d0b64e1b1d87594c8e8a3fd669629 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659200Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#668958}
-
Natalie Chouinard authored
Migrate the Homepage settings preference fragment from the deprecated Framework classes to the Preference Support Library. This is the first settings page with a switch preference (or any widget), so it requires some layout and style modifications to match the existing Chrome preference style. Migrating to the support library preference widget also has the side benefit of fixing a bug with frequently missing animations in Framework-extending preference classes: https://crbug.com/967858. Bug: 967058, 967858 Change-Id: I523d4e2faa763c807033ca3df75253324cd09fab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1647140Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#668957}
-
Alberto Herrera authored
Bug: 785758 Change-Id: Id1520ec0e074350adef549cd119c924d20a49a80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1654828Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: Alberto Herrera <ahrfgb@google.com> Cr-Commit-Position: refs/heads/master@{#668956}
-
wutao authored
Previous footer visibility depended on indicator processor status, which was wrong. It should depend on the query and response status. To address this, also add a parameter |due_to_commit| to OnPendingQueryCleared() to reflect the status. Bug: b/134764910 Test: Manual Change-Id: I90bf619f6664fc2e61f306bda3b0b5b43e993293 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648767 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#668955}
-
Carlos IL authored
Bug: 973664 Change-Id: I97fab27401a1b9905005d60609fc34ff0b6f1724 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1656812Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#668954}
-
Peter Wen authored
Follow-up downstream CL: https://crrev.com/i/1309325 Image fetcher has very few dependencies (BitmapCache and ConversionUtils), so it is a good candidate for the lib/ layer. Created lib/util to house classes in the util package that can be easily moved. The rest will be moved later, when their dependencies, including some resources, are also split out. There may be browser-specific util classes that remain in browser.util. TBR +base/android DEPS addition since these libraries being moved already depend on base. Tbr: nyquist@chromium.org Bug: 846440 Change-Id: I9be429ec8789438a34314a3da6a02119f6c3e549 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614967 Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#668953}
-
Esmael El-Moslimany authored
Bug: 967793 Change-Id: I0e6d1cf6acdd0272bb0131a8383600857571cfd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658829Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#668952}
-
Lukasz Anforowicz authored
This CL adds ScopedAllowRendererCrashes to browser tests that (expectedly or unexpectedly) might trigger a renderer crash. Right now a browser test might pass, even if a renderer process crashed during the test execution. After https://crrev.com/c/1650463 a renderer crash will trigger an explicit test failure, but before this enforcement can start, existing tests that experience renderer crashes (expectedly or unexpectedly) need to declare this via ScopedAllowRendererCrashes. This CL was uploaded by git cl split. R=bengr@chromium.org Bug: 972220 Change-Id: Ib3b1a206e69b4519f654333a1fcd3aa3f26c5e9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1653628 Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Ben Greenstein <bengr@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#668951}
-
John Abd-El-Malek authored
Disable RenderProcessHostTest.SpareProcessVsCustomStoragePartition when network service is disabled. Custom storage partitions are only used by Chrome which only runs with network service enabled. The test is in content though and it started failing on Android which is running the old path for WebView temporarily. Since WebView doesn't need this functionality, early exit. TBR=paulmiller@chromium.org Bug: 973945 Change-Id: Ib62c16ffd9898884e0741e265853a64e04408e71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659014Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#668950}
-
Kenneth Russell authored
This bot uses a thin Linux VM to trigger Swarming tasks on physical Windows hardware. All dependent bugs are now fixed, so attempt to re-enable all tests. Bug: 952071 Change-Id: I3948d111bf8474ea89c8f34cfa9e8a920775d5eb No-Try: True Tbr: ynovikov@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659018Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#668949}
-
yilkal authored
Bug: 966892 Change-Id: If7294cafdeec92b76da35c6c0fbcb3c91a41cb65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1647149 Commit-Queue: Yilkal Abe <yilkal@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#668948}
-
Peter Collingbourne authored
Bug: 464945 Change-Id: I1a615f31cabbce06e8d0583b3dc3ec4077846f90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658712Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Peter Collingbourne <pcc@chromium.org> Cr-Commit-Position: refs/heads/master@{#668947}
-
Rohit Rao authored
Previously these tests were loading URLs by typing in the omnibox, but explicit UI interaction is not necessary. BUG=973708 Change-Id: I5939bc2016f04af9f1e038bf7af5dcfa2836c55c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658229Reviewed-by:
Robbie Gibson <rkgibson@google.com> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#668946}
-
Matthew Mourgos authored
Bug: 971620 Change-Id: Ib714189183d672995f427bf02799bda67fc42020 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1657360 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#668945}
-
Bruce Dawson authored
This updates Chrome to build with a toolchain based on VS 2017 15.9.12 and the Windows 10.0.18362.0 SDK. This package contains the 17134 version of d3dcompiler_47.dll, to avoid gaining a dependency on the universal CRT which would cause problems for some Windows 7 machines (bug 919163). Packaging was done on a Windows Server 2019 VM, cleanly created for this purpose. The package was created by downloading VS 2017 Update 9.3, from https://visualstudio.microsoft.com/vs/older-downloads and downloading the 15.9 Visual Studio Professional 2017, and then running the installer like this: $ PATH_TO_INSTALLER.EXE ^ --add Microsoft.VisualStudio.Workload.NativeDesktop ^ --add Microsoft.VisualStudio.Component.VC.ATLMFC ^ --add Microsoft.VisualStudio.Component.VC.Tools.ARM64 ^ --add Microsoft.VisualStudio.Component.VC.MFC.ARM64 ^ --includeRecommended --passive Then the 10.0.18362.0 SDK was installed from: https://developer.microsoft.com/en-US/windows/downloads/windows-10-sdk Then the packaging script was run like this: python depot_tools\win_toolchain\package_from_installed.py 2017 -w 10.0.18362.0 Since the new d3dcompiler_47.dll uses the UCRT and we want to avoid shipping that the final packaging step was to unzip the package, copy over the two copies of that DLL from win_sdk\Redist, and then repackage the toolchain with: > python package_from_installed.py --repackage=<full-path-to-toolchain-dir> This is needed to make progress towards two-phase lookup. Bug: 970064 Change-Id: Ib502b34f3281cb062eafff93e6d1054a968d4e9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1650599Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/c6cb20db2cb3..b988e6b45063 git log c6cb20db2cb3..b988e6b45063 --date=short --no-merges --format='%ad %ae %s' 2019-06-13 google-shaderc-autoroll@skia.org Roll third_party/googletest 89656ddbe62f..af4c2cb098a3 (2 commits) (#702) Created with: gclient setdep -r src/third_party/shaderc/src@b988e6b45063 The AutoRoll server is located here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=radial-bots+chrome-roll@google.com Change-Id: Ib7a8450e093f3fc8b54638d88cc61629cffba3f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658499Reviewed-by:
-
Katie D authored
Adds a working autoclick scroll pad with minimal, temporary UX. Adds tests for scroll pad integration. See go/chromeos-dwell-scroll-design for design, and https://screenshot.googleplex.com/7DT5MbsRWLU.png for the UX at this point (note that it's behind a flag and also unfinished). TEST=AutoclickTest.ScrollClosesWhenHoveredOverScrollButton TEST=AutoclickMenuBubbleControllerTest.ScrollBubbleShowsAndCloses TEST=AutoclickMenuBubbleControllerTest.ScrollBubblePositioning Bug: 947068 Change-Id: I4b90a22cb969c8a03958d970cd4c147bb42df657 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1650603 Commit-Queue: Katie Dektar <katie@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#668942}
-
Aleks Totic authored
Bug: 972047 Change-Id: I2c4bce0e4b6b4ada67b20251b382be3f3df796a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1651036Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#668941}
-
sczs authored
This is a followup to https://crrev.com/c/1654408. After adding the banner as an A11y element, we also need to remove it once it has been dismissed. Bug: 973262 Change-Id: I1d2a3a3e2504e651db35407b4e6194212ca4d525 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658708Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#668940}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/444aa0fe64da..b08d53d3c1c6 git log 444aa0fe64da..b08d53d3c1c6 --date=short --no-merges --format='%ad %ae %s' 2019-06-13 spang@chromium.org Reland "Vulkan: Build validation layers with asserts only" 2019-06-13 jonahr@google.com Clean up and expose frontend features to egl. 2019-06-13 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/spirv-tools/src 9c0830133b07..42830e5a68c3 (2 commits) Created with: gclient setdep -r src/third_party/angle@b08d53d3c1c6 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jmadill@google.com Change-Id: Ic207cfbe61e4e6a6dd99cab798d8dca97cef9473 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658500Reviewed-by:
-
Miguel Casas authored
This CL modifies GLCopyTextureCHROMIUMTest.InternalFormat to use for-range loops like the other tests around (e.g. the previous one ImmutableTexture). It also symbolises the formats that fail for good measure. I just stumbled upon this cleanup while adding P010 tests (which anyway cannot be easily added). No new functionality intended. Bug: 911754 Change-Id: I9bf844a2f961b35fb92cea1568a504f7c8a43597 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1656072 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#668938}
-
Xiaohui Chen authored
The previous description was incorrect about the "not set" state. It should be allowing users to choose themselves. Bug: None Change-Id: I055dc271d04c1f049394ceb2576827d40bc7ce6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655386Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#668937}
-
Sunny Sachanandani authored
TBR=kbr@chromium.org Bug: None Change-Id: I1ad3e250500659b9e32b3d9fbb77c667c3cc8dde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658673Reviewed-by:
-
Jose Dapena Paz authored
Brace initializer used for populating one of the FakeTestUnwinder instances in WalkStack_AuxThenNative was adding an extra nesting level that was not really needed. In GCC, this would actually make method resolution fail. Bug: 819294 Change-Id: I711aaaa7988c421dae2221e7cafbba22ecf8ab5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658014Reviewed-by:
Mike Wittman <wittman@chromium.org> Commit-Queue: José Dapena Paz <jose.dapena@lge.com> Cr-Commit-Position: refs/heads/master@{#668935}
-
Yue Li authored
Bug: b/135137356 Test: Local build Change-Id: Ia2cd4ad65039bfa61322f8278590a9484a46a58c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1656193Reviewed-by:
-
Chase Phillips authored
Bug: 972239 Change-Id: Ifc22d6e51b945ed37b7f76a44d4ea095afbcb145 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658768 Commit-Queue: Chase Phillips <cmp@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#668933}
-
John Budorick authored
waitForConnection takes a timeout duration but currently just uses that as the duration of each wait in a loop. If the child process never connects, this will wait indefinitely. This CL fixes that behavior -- waitForConnection will now return false if the child process doesn't connect before the provided timeout expires. Bug: 790202 Change-Id: Ie6ec06431f9145221e1593b969f73d982474b0fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658416Reviewed-by:
Yun Liu <yliuyliu@google.com> Commit-Queue: Yun Liu <yliuyliu@google.com> Auto-Submit: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#668932}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9c505b558004..22b387d76825 Created with: gclient setdep -r src-internal@22b387d76825 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome BUG=chromium:934251 TBR=mmentovai@google.com,aboxhall@google.com,mstensho@google.com,oksamyt@google.com Change-Id: I3a210b4ee0b4c13a4c277995eb9ab5f2b785ebb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658495Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#668931}
-
Maks Orlovich authored
The warn-about-cookie list was being collected from URLRequest before it actually parsed the cookies. This also fixes URLRequest state for this after ::ClearAuth. Bug: 971680 Change-Id: Ib19651f1f9fd808cc2fbfd9b996b7be4073ae88d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1647517 Commit-Queue: Maks Orlovich <morlovich@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#668930}
-
Aaron Leventhal authored
Inconsistent reparenting logic in AXTree leads to old AXNodes being used for blink events, even though they no longer own their data. Specifically: when a node is simultaneously removed and changed, it is being treated as a reparented node, which causes the node to lose data ownership. In addition, subtree callbacks are used instead of node deletion callbacks, which leads to BrowserAccessibilityManager not removing the nodes from its id cache, and trying to still fire blink events on the dead nodes. Bug: 948907 Change-Id: I939006fb155e10399029890b58b108df4312c514 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1652247 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Zachary Kuznia <zork@chromium.org> Cr-Commit-Position: refs/heads/master@{#668929}
-
