GitLab

Refactor the key_desktop_move_cases page set and merge it into the
rendering.desktop page set.

Bug: 760553
Change-Id: Ib604085a2e3fcd83dc23ef36b4b7bf58a00b8ddb
Reviewed-on: https://chromium-review.googlesource.com/1066174
Commit-Queue: Amy Qiu <amyqiu@google.com>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#562059}

Currently many layout test runs are flaking because swarming is not expecting child processes to outlive the browser. This is happening because TerminateProcess fails sometimes because there's pending I/O.

Bug: 820996
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I7595c131faccae03c268cde1139394c0ad48a7b4
Reviewed-on: https://chromium-review.googlesource.com/1071100
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Penny MacNeil <pennymac@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562058}

This cl adds tracing to see why ScrollAnimationUpdateTarget returns false.

Bug: 797708
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I40b0e2b71d25ddaa4a0d685cfb223bd83dd8f1b2
Reviewed-on: https://chromium-review.googlesource.com/1073754
Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562057}

When the safe area viewport adjustment mode is selected, the browser
container view will be laid out using the full bounds of the screen, and
the top safe area inset will be updated to push top-aligned fixed-
position elements into view.  Bottom-aligned fixed-position elements are
not affected by the safe area.

Bug: none
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I8bbe41c3c8af2945cba1c17ad174ce42f78ae0f8
Reviewed-on: https://chromium-review.googlesource.com/1066784
Commit-Queue: Peter Lee <pkl@chromium.org>
Reviewed-by: Peter Lee <pkl@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562056}

The CompositorFrame StructTraits uses the traits of RenderPass and
CompositorFrameMetadata, so they should be included.

R=weiliangc@chromium.org

Bug: 755319
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: If8a895128953dc4049e7c446667bdfb022a94ae3
Reviewed-on: https://chromium-review.googlesource.com/1073965
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: weiliangc <weiliangc@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562055}

It is flaky.

BUG=845844

Change-Id: I02639a86467eda5311c750b3bacf957ab6adfca8
Reviewed-on: https://chromium-review.googlesource.com/1073964Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562054}

Fix connection migration cause when alternate network comes up after path is degrading so that data is collected in Net.QuicSession.ConnectionMigration.OnPathDegrading instead of Net.QuicSession.ConnectionMigration.OnNetworkConnected.

Bug: 804048
Change-Id: Ic200bb845388ac10d414c3377d1f65d2c4fc8836
Reviewed-on: https://chromium-review.googlesource.com/1068034Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Zhongyi Shi <zhongyi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562053}

Currently, FrameSchedulerImpl keeps a set of throttling observers that
it notifies when throttling state changes. This includes each worker's
WorkerSchedulerProxy.

This CL moves throttling observers to the base class,
FrameOrWorkerScheduler, allowing each nested worker to register its
WorkerSchedulerProxy with its parent WorkerScheduler, so the
WorkerScheduler can then propagate throttling state to the nested
worker.

Bug: 829119
Change-Id: If005e3ec781b2fc0ecd3ba1ba73fa4b0e6ef1a0f
Reviewed-on: https://chromium-review.googlesource.com/994060Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Nate Chapin <japhet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562052}

This and AshWindowTreeHostMusMirroringUnified are unused now that we
have deprecated ash::Config::MUS as part of the switch to
//services/ui/ws2

Bug: 841941
Test: compiles
Change-Id: I76cab0b5717b81eedfe168d67cf98ba0eac38abb
Reviewed-on: https://chromium-review.googlesource.com/1074009Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562051}

Add the class structure required to support the actual View in the new
download home code layout.  This adds the required adapters, model
change processors, view binders, etc..  Currently they all just inflate
to a TextView, but this is the rough structure the code will be in as
the Views get built out.

BUG=842345

Change-Id: I385ab70a7537254832f57ccb410bb75498a99545
Reviewed-on: https://chromium-review.googlesource.com/1072947
Commit-Queue: David Trainor <dtrainor@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562050}

This test runs too slowly on Fuchsia bots, due to emulation overheads.

Bug: 826408, 844416
Change-Id: Ieada8fc8ca56583a34d8c24f1eecbcc4f6b45852
Reviewed-on: https://chromium-review.googlesource.com/1073731Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562049}

Put touchable app context menus and notification indicators under two
different flags.

The notification indicator flag will also control the notifications in
context menu feature.

These features are still very related, but the ability to enable
them selectively is desirable for dogfooding.

Bug: 845316
Change-Id: Id30715dae05fe50c7d4eed9a462df13ccd1cec6c
Reviewed-on: https://chromium-review.googlesource.com/1068149Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562048}

Resize the ui::Compositor's size in BrowserCompositorMac's
SynchronizeVisualProperties method.

Re-disable using a unified ui::Compositor (it was accidentally enabled
by a botched merge).

Bug: 840173
Change-Id: I701574e385ae288b991adce81e1ab5efde23e0c2
Reviewed-on: https://chromium-review.googlesource.com/1073682Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562047}

Use of QuitCurrent*Deprecated() is ambiguous, since RunLoops can be
nested, and so is unsafe to use in general.

TBR: bartfab
Bug: 845966, 844016, 749312
Change-Id: I537862ea02c4ed67887db32993f40e53f614b3cd
Reviewed-on: https://chromium-review.googlesource.com/1019967Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562046}

This particular stat() variant was not being handled in the same
way as the others.

Bug: 846800
Change-Id: I2ec9b94f704f9f00aa3dd1dbd0a3be71a0583b75
Reviewed-on: https://chromium-review.googlesource.com/1073869Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562045}

Improves the support for requestSession in WebXR mainly focused on
allowing ARCoreDevice to receive a call when the session request
is made.

Also adds a check to both supportSession and requestSession to ensure
the device supports AR capabilities when the hit-test flag is enabled.

Bug: 835037

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr
Change-Id: I8090f64a981114b130e446025ec6299fbb5619e4
Reviewed-on: https://chromium-review.googlesource.com/1046107
Commit-Queue: Iker Jamardo <ijamardo@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Reviewed-by: Biao She <bshe@chromium.org>
Reviewed-by: David Dorwin <ddorwin@chromium.org>
Reviewed-by: Bill Orr <billorr@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562044}

Speculative revert, see build failures on Win10 Tests x64 (dbg):
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20Tests%20x64%20%28dbg%29/803

Bug: http://crbug.com/846837

This reverts commit 983e926b.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> Re-land: Avoid serializing the same accessibility node twice in the same message
> 
> Originally landed: r560165, crrev.com/c/1063007
> Reverted: r561246, crrev.com/c/1069891
> 
> TBR=dtseng@chromium.org
> Bug: 651614, 845778
> 
> Change-Id: I77b54de28cb0c4a231b5b0758ba4708100d27fff
> Reviewed-on: https://chromium-review.googlesource.com/1072875
> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#561913}

TBR=dmazzoni@chromium.org,dtseng@chromium.org

Change-Id: I5cbf8006e4917a9c008143ae4b746543d2b038c2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 651614, 845778, 846837
Reviewed-on: https://chromium-review.googlesource.com/1074050Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562043}

This works around a bug (https://llvm.org/pr37592) in LLD, where if
foo.lib appears on the link line without -wholearchive:, it doesn't take
effect. Instead, only pass the -wholearchive:foo.lib flag, which adds
the library as an input and turns on the wholearchive behavior that we
need.

Fixes base_unittests StackSamplingProfilerTest.OtherLibrary and related
tests, which were failing because chrome.exe was missing an exported
function.

Remove the /include flag workaround for https://crbug.com/777087.

BUG=777087,844398
R=mmoroz@chromium.org

Change-Id: I493e1dcf6963048f7e83df1c937b4a4a62dd96bb
Reviewed-on: https://chromium-review.googlesource.com/1073890Reviewed-by: Max Moroz <mmoroz@chromium.org>
Commit-Queue: Reid Kleckner <rnk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562042}

This CL unconditionally enables the fullscreen exit UI as we get all
approvals on the launch bug.

Bug: 829606
Change-Id: Ia8dd65b0946999d5cba9d897f068f4c9858ff163
Reviewed-on: https://chromium-review.googlesource.com/1073625Reviewed-by: Robert Liao <robliao@chromium.org>
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562041}

This saves 140 KB of chrome binary size on 64-bit Intel.

Previously for --enable-features=Mus we were running the window service
on a background thread in the browser process, so it was slightly more
efficient to use lazy serialization for mojo calls.

We have eliminated the "Mus" config and with ws2 the window service
mojo implementations will be directly implemented in the "ash"
service/process. All mojo calls will be cross-process, so there's no
advantage to using lazy serialization.

This is a revert of:
https://chromium-review.googlesource.com/c/chromium/src/+/849657

Bug: 798800, 799072
Test: bots
Change-Id: I3f1ffe0e598e6bee7d3a54f41ffbbce23fd592e6
Reviewed-on: https://chromium-review.googlesource.com/1072460Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562040}

No change to logic.

This adds startup traces to track how long it takes to invoke the
constructors of AwContentsClient and AwContentsClientCallbackHelper.

These are both called as part of the work for instantiating the
WebViewContentsClientAdapter.

Bug: 838702
Test: N/A
Change-Id: Id04cde3f65d18522893c1bc82621a0740242962b
Reviewed-on: https://chromium-review.googlesource.com/1073915
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Reviewed-by: Changwan Ryu <changwan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562039}

https://chromium.googlesource.com/angle/angle.git/+log/d0a7d10f397d..1478afaf119e

$ git log d0a7d10f3..1478afaf1 --date=short --no-merges --format='%ad %ae %s'
2018-05-17 lfy GLES1: Lighting and materials (renderer)
2018-05-17 lfy Reland "GLES1: Entry points for lighting and materials"

Created with:
  roll-dep src/third_party/angle


The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=lucferron@chromium.org

Change-Id: Iec45f84d4ffead93ac64f0d61deacf72c753faee
Reviewed-on: https://chromium-review.googlesource.com/1073667
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#562038}

The "cc" traces in the component become "viz".
The "cc.debug.overdraw" becomes "viz.overdraw".
The "cc.debug.triangles" becomes "viz.triangles".
The "cc.debug.quads" becomes "viz.quads". There is one instance of this
in cc/ as well, but renamed it to be consistent. The idea is to trace
quads that arrive in viz and include the quads from the cc origin, so
I *think* this makes sense.

R=weiliangc@chromium.org

Bug: 751814
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I6b25ac8e86ffe8a2bbefc0824929e96eb12be104
Reviewed-on: https://chromium-review.googlesource.com/1073889Reviewed-by: weiliangc <weiliangc@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562037}

This is a reland of b422141f

Original change's description:
> Clean up scrim logic in LocationBarLayout
> 
> Scrim visibility in the location bar is now completely controlled by
> a single function. The scrim observer is now added and removed based
> on the scrim visibility to avoid conflict with other observers (like
> the bottom sheet).
> 
> Bug: 834927
> Change-Id: I172ca637dde5bc026b1b7f629bc34c6d939dff2d
> Reviewed-on: https://chromium-review.googlesource.com/1026168
> Commit-Queue: Matthew Jones <mdjones@chromium.org>
> Reviewed-by: Ted Choc <tedchoc@chromium.org>
> Reviewed-by: Theresa <twellington@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#558785}

Bug: 834927
Change-Id: I8c5d5a93574024f8f5783e71d0db29e76dc4acab
Reviewed-on: https://chromium-review.googlesource.com/1073490Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562036}

To easily visualize the green luci builders.

Bug: 840631
Change-Id: Ic06e92870f7a169a8a720140fa3ab0615e92672c
Reviewed-on: https://chromium-review.googlesource.com/1073962Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Ryan Tseng <hinoka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562035}

This change adds support for tabbing through the controls in the window.
Previously, the user can only utilise mouse clicks to interact with the
controls.

ControlButton will likely be updated to accommodate the addition of a
non-constant number of custom actions in the future.

UI affordances for the currently focused control will be added in a
separate patch.

BUG: 836389
Change-Id: Ic25524cfab9ceeba1d17ef00975347f6e3d562e6
Reviewed-on: https://chromium-review.googlesource.com/1072516
Commit-Queue: apacible <apacible@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562034}

This fixes the presentation of this histogram in the UMA dashboards
where it currently shows as representing a numeric value.

Bug: 794828
Change-Id: I549d7460440435861cb4364f303845cfcac5d2e0
Reviewed-on: https://chromium-review.googlesource.com/1072712Reviewed-by: Brian White <bcwhite@chromium.org>
Commit-Queue: Carlos Knippschild <carlosk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562033}

UseCounter now checks if a page is an ordinary page when it logs usage.
This means all UseCounter realted unit tests need to use a dummy page
holder that is added to ordinary pages. Previously a dummy page holder
is added to ordinary pages upon construction, which is not ideal. This
CL only explicitly add a dummy page holder to ordinary pages when needed.

Change-Id: I7b48d894a546849797e656e66cad13cc58b20635
Reviewed-on: https://chromium-review.googlesource.com/1070670
Commit-Queue: Luna Lu <loonybear@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562032}

We need to allocate the native pixmap for the unittest using the
SCANOUT_VDA_WRITE usage flag like we do in Chrome so we get the
right tiling.

Bug: 845076
Test: video_decode_accelerator_unittest passes
Change-Id: I877bf94e6f7f90c14973be76c1f53d841aed4305
Reviewed-on: https://chromium-review.googlesource.com/1072638Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Commit-Queue: Kristian H. Kristensen <hoegsberg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562031}

If an NGPhysicalTextFragment is created from first-letter, its
GetNode() method returns nullptr, which leads to false negative
when hit-testing on this fragment.

This patch adds a new method to obtain the text node for first-
letter fragments, and applies it in hit test code, so that we
can correctly obtain the text node when hit-testing the first
letter.

Bug: 811502
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I70e5cd4948f248a6e51e3a1732273779ef36509c
Reviewed-on: https://chromium-review.googlesource.com/1072691
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562030}

Bug: 836310
Change-Id: Ib2d8796129e34c22c922e21b492e474130ea4420
Reviewed-on: https://chromium-review.googlesource.com/1057434
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562029}

This adds max_concurrent_invocations on a per-builder basis for chromium.lkgr builders.

Bug: 840631
Change-Id: Id45281695c35b7d0f1549183ac5e72fd8e5ae957
Reviewed-on: https://chromium-review.googlesource.com/1073925Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Ryan Tseng <hinoka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562028}

Bug: 794289
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: If1ed00732e07bd0f9b3bdf2cf97cd257d8054f8e
Reviewed-on: https://chromium-review.googlesource.com/1069793Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562027}

This is a new User Policy that is used to determine if Sync Consent
should be displayed for the user during login.

TBR=atwilson@chroumium.org

Bug: 841156
Change-Id: Ibf5e0bdbe7a1037b6c2760032901e3cbe1924146
Reviewed-on: https://chromium-review.googlesource.com/1073623
Commit-Queue: Aga Wronska <agawronska@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562026}

This adds the missing override of viz::OutputSurface::UpdateGpuFence
to content::VulkanBrowserCompositorOutputSurface.

Bug: none
Test: compile

Change-Id: I8dc0c40d98c16f4bb85c404b51f654f90bce47ca
Reviewed-on: https://chromium-review.googlesource.com/1073063Reviewed-by: ccameron <ccameron@chromium.org>
Commit-Queue: Michael Spang <spang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562025}

This optional method is not implemented by native content classes.

Bug: 725239
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I70bb3e0e308762bd90c354769eccd1cc2616ed73
Reviewed-on: https://chromium-review.googlesource.com/1073676Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562024}

With these gn args:
is_clang = false
target_cpu = "x64"

the file fails to compile due to uint64 -> uint32_t conversion.

Change-Id: I76126e6d170f01eedcccfd3a17f6aa4184753fe9
Reviewed-on: https://chromium-review.googlesource.com/1071287Reviewed-by: John Rummell <jrummell@chromium.org>
Commit-Queue: John Rummell <jrummell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562023}

This CL:
1. Stops null-checking the WebContents when considering to block popups.
   All callers pass in a valid contents already.

2. Tests the case when a caller calls ShowBlockedPopup with an invalid
   id. This seemed like a more reasonable API to be defensive with, but
   it wasn't tested.

Bug: None
Change-Id: I3913ed540b06f57e7fd31cae1f7da7de4da37dab
Reviewed-on: https://chromium-review.googlesource.com/1073847Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562022}

Bug: 823365
Change-Id: I847384bf51dfe78dcb772afde72d7d19c876b44b
Reviewed-on: https://chromium-review.googlesource.com/1073659Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562021}

Remove FrameTokenAllocator since it is no longer needed or used.

BUG=811961

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I760a1dcaf220dd13d8b4ac448de911ec46acf593
Reviewed-on: https://chromium-review.googlesource.com/1073081Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562020}