- 16 Oct, 2019 40 commits
-
-
Renjie Tang authored
Change-Id: I8ffb26d392a312e18a7b5982b02337a1120fd7aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859639 Commit-Queue: Renjie Tang <renjietang@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#706295}
-
Xida Chen authored
At this moment, CSSPaintValue keeps a CSSPaintImageGenerator which is associated with a Document. In the test case that is reported in the bug, the GetImage is called on a new Document. While the old Document could have gone out of the scope, the GetImage function would crash. This CL makes CSSPaintValue keeps a hash map from Document to CSSPaintImageGenerator. In this case, we can use the correct generator whenever GetImage is called. A unit test case is added. Bug: 998439 Change-Id: Id625e7c0b6840a6f27e2b4e6ea39623c7eaf904b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838674Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#706294}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/a27dfcf868bf..8cde4063d097 git log a27dfcf868bf..8cde4063d097 --date=short --no-merges --format='%ad %ae %s' 2019-10-16 swiftshader.regress@gmail.com Regres: Update test lists @ a27dfcf8 Created with: gclient setdep -r src/third_party/swiftshader@8cde4063d097 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: None Change-Id: Ie6ddefd682eefc7eb7f0758021efdf256aee8779 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863519Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#706293}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=cmasso@chromium.org Change-Id: I6403ba30a79ae7caaff045e6b3f75f010eadccdb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864350Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#706292}
-
Jay Harris authored
The particular motivation for this CL is file handling on Linux, as registering and unregistering file handlers requires regenerating app shortcuts, making a BMO agnostic approach to regenerating shortcuts desirable. (Note: BMO is a refactoring effort to move WebApps of the extensions system). Bug: 860581 Change-Id: Iec10bbc48f2dfa00ff407eb9c0aa2546aad01ce9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846422 Commit-Queue: Jay Harris <harrisjay@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#706291}
-
Shuo-Peng Liao authored
ImageProcessor stores input and output's configuration with VideoFrameLayout object and VideoFrame::StorageType. However, VideoFrameLayout is unable to represent proprietary format, e.g. MT21, so it is not suitable to represent IP's input/output config. Instead of storing individual configuration properties (format, visible_size, color_plane_layout, storage_type), we modify an existing class, ImageProcessor::PortConfig, to store ImageProcessor's input/output configuration. BUG=1004727, 1005636 TEST=Run VDA test on hana TEST=Run VEA test on kevin TEST=pass webrtc.DecodeAccelUsedVP8 on kevin Change-Id: Id5cef9c77903f42de95612311569cb08f6e9afb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855142 Auto-Submit: Chih-Yu Huang <akahuang@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#706290}
-
Yutaka Hirano authored
This is a follow up change for https://crrev.com/8ee3f7e6d3a79b15824b6e286eb71c0a96c4d879. See its CL description for details. Bug: 961614, 1006292 Change-Id: Idff6f6645cf01cc7ea8c873cbde9039e641f7ecc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862014Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#706289}
-
Chase Phillips authored
This CL moves the date assumed for corrupted caches from Tue Jan 29, 2019 to Sun Jul 6, 2019. We expect this change to land in master and be backported to M78. The CL currently has placeholder text where information about the affected regions of response timestamp vs max-age/TTL will go in a later change. AppCache is currently deprecated with removal targeted for M82. We expect that either we'll deploy a more permanent solution by M82 or AppCache will be removed in that milestone. Bug: 1014794 Change-Id: I98fb5042aea144048f82d686025ff7d84ee10ed5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860143 Commit-Queue: Chase Phillips <cmp@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Auto-Submit: Chase Phillips <cmp@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#706288}
-
Hirokazu Honda authored
crrev.com/c/1847432 introduced the bug that VaapiWrapper is destroyed when VaapiWrapper::CreateContextAndSurfaces is successful. This CL fixes the wrong check on the return value. Bug: 1009297, 1005205 Test: https://appr.tc/?debug=loopback&vsc=vp8&video=maxWidth=640,maxHeight=360,minWidth=640,minHeight=360&debug=loopback Change-Id: I9a31b305c991cee5e28139d307f87430c20b45e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862880Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Ricky Liang <jcliang@chromium.org> Auto-Submit: Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#706287}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/821fe40443ea..120275e84dca Created with: gclient setdep -r src-internal@120275e84dca If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Ia1f8a53d516202af8748cb0e66d2592e8119c741 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864089Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#706286}
-
Fergal Daly authored
This test is already passing for blink but some other browsers fail. This test is a clone of simple.html but moves the color inline. Bug: 1014400 Change-Id: I4810222d43f99ae229afa58458e1830202b7d444 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862134Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#706285}
-
Lei Zhang authored
Use more C++11. Along the way, also use base::Contains() in more places and improve STL usage. Change-Id: I34e96d3d9801bcdf30f0f10eea2f5ca91ed43508 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863157Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#706284}
-
Mitsuru Oshima authored
of defaultTests because lockScreen test changes the session state. Bug: None Test: No functionality change. Change-Id: I3c6f6353525e97b6a547684066f26a30d8c9f3cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862718 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#706283}
-
Ian Barkley-Yeung authored
Add the AIRA role of "alert" to the "selected file is too big" error message. This should convince screen readers to announce the error. It's time sensitive (per aira "alert" role guidelines) because if the user presses "Send" before hearing the alert, they won't know the file wasn't sent. Not perfect (if the user chooses another file that is too big, the error is not re-announced), but better than what we have currently. Also add aira-describedby to the attach file window, so that the screen readers treat "File will be sent to Google for debugging" as an extra description of the field. BUG=chromium:1005559, chromium:1005528 TEST=ChromeVox on ChromeOS. "Selected file is too big" was announced after selecting a large file. (Took a long time, but it was announced). "File will be sent to Google for debugging" was spoken after "Attach file No file chosen". R=afakhry@chromium.org Change-Id: Ic60b811cd1902e6e621048ed6e9ab6da838ba267 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863363Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Auto-Submit: Ian Barkley-Yeung <iby@chromium.org> Cr-Commit-Position: refs/heads/master@{#706282}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/22f14e2a1c49..ac6afeb999e9 git log 22f14e2a1c49..ac6afeb999e9 --date=short --no-merges --format='%ad %ae %s' 2019-10-16 gbiv@google.com afdo: add indirect call redaction to merged profiles 2019-10-16 vapier@chromium.org cros_build_lib.run: drop old signal workaround 2019-10-16 vapier@chromium.org wrapper: require Python 2.7.5+ and 3.4+ 2019-10-16 vapier@chromium.org run_tests: turn on more python3 coverage 2019-10-15 vapier@chromium.org signer_payloads_client: read hashes as binary data Created with: gclient setdep -r src/third_party/chromite@ac6afeb999e9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I4d8c00b371bee014b1686c9e41b4a56d50e386eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864099Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#706281}
-
Xinghui Lu authored
Since high confidence allowlist is currently not available on GMSCore, we plan to have it hardcoded in our code. This is similar to what we have done for CSD allowlist. Bug: 1014202 Change-Id: I5489b3d4ed56b8dd7ad7a79ea205b403b444a077 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860980Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#706280}
-
Peter Kasting authored
* Use GetPreferredSize() where applicable instead of CalculatePreferredSize() * Format * Remove unnecessary and now-outdated section-divider comment blocks * Use AddChildView(unique_ptr) * Remove duplicated code * Shorten * Don't bother with named constants that add no clarity * Fix comments * Use GetCornerRadiusMetric() * Remove dead code * Use in-declaration initializers Bug: none Change-Id: I3850f944311eb7521ab5827accfc9720532979a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856925 Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#706279}
-
Lei Zhang authored
The global |kRawData| std::map constant have to be initialized when the program starts. Instead, make it a static local by wrapping it in a GetRawData() function so the map is initialized on first use instead. This remove 14 static initializers. Along the way, make some globals fully const, use |kKeyMapCount| in more places instead of hardcoding its value, simplify some code, and make the modified files free of lint errors. Bug: 537099 Change-Id: I1b6d059f608db108bb4ecb672119a5f43634bef5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824067Reviewed-by:
Shu Chen <shuchen@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#706278}
-
Hirokazu Honda authored
This adds if statement to cause a software encoder fallback if non GBM based VideoFrame is given in native input mode. This CL also changes DCHECK_EQs to if-statements in MojoVideoEncodeAccelerator. It is because, if the conditions are false, it causes a renderer process crash. Bug: 1014209 Test: webrtc.DecodeAccelUsedVP8 Change-Id: I7aefe0c8e37dae5f086c6f0ce49651a3816194d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862355Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#706277}
-
Evan Stade authored
Use the standard creation path for KeyedServices. Bug: 268984 Change-Id: Id4a555cad9a64d00376e16cc1d072f2bf39b0e3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852578Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#706276}
-
Robert Liao authored
This isn't needed as of http://crrev.com/186382 BUG= TBR=sky@chromium.org Change-Id: Ib68322494d89754f47e0bfa2e504827804d9586c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864091Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#706275}
-
Gary Kacmarcik authored
This cl also updates the dialog strings to include "Chrome Remote Desktop" in the title - for both Accessibility and Screen Recording. Bug: 1012545 Change-Id: Ia7fb4e13fe103802d4130e67a8ae59cb7d2c50b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863640 Auto-Submit: Gary Kacmarcik <garykac@chromium.org> Commit-Queue: Gary Kacmarcik <garykac@chromium.org> Commit-Queue: Jamie Walch <jamiewalch@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#706274}
-
Jihwan Marc Kim authored
Move error histograms in IndexedDB to use function instead to reduce code size. Bug: 1012881, 945578 Change-Id: I4f211651bda3437fd956302c9b00fbd422ae769d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857798Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#706273}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/20c626aa2358..634d15032d37 git log 20c626aa2358..634d15032d37 --date=short --no-merges --format='%ad %ae %s' 2019-10-16 lsalzman@mozilla.com fix SkTextBlob::getIntercepts regression no longer considering glyph vertical offset Created with: gclient setdep -r src/third_party/skia@634d15032d37 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC csmartdalton@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=csmartdalton@google.com Bug: None Change-Id: Iedbee32247601b3f998586213bb8fdb5c43e6dd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864028Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#706272}
-
David Benjamin authored
We map key types from the TLS code points to Android key types so choosePrivateKeyAlias can filter the selection. Prior to Android 10, the API ignored the parameter so it didn't actually matter what was passed in. Starting Android 10, the filter is applied. We had mapped ECDSA to "ECDSA", however the actual string is "EC". See: https://developer.android.com/reference/android/security/KeyChain.html#choosePrivateKeyAlias(android.app.Activity,%20android.security.KeyChainAliasCallback,%20java.lang.String%5B%5D,%20java.security.Principal%5B%5D,%20java.lang.String,%20int,%20java.lang.String) https://developer.android.com/reference/android/security/keystore/KeyProperties.html#KEY_ALGORITHM_EC https://docs.oracle.com/javase/7/docs/technotes/guides/security/StandardNames.html#KeyFactory Tested manually by importing an EC key on an Android 10 device and testing with a TLS 1.2 server. (Note TLS 1.3 doesn't use the old client certificate types anymore and we do not currently do anything with the new values.) Bug: none Change-Id: I8fd222093c603962f8455b3fbde76d7a0d511042 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863377 Auto-Submit: David Benjamin <davidben@chromium.org> Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#706271}
-
Patrick Monette authored
The condition before invoking |terminate_all_workers_callback_| in TestSharedWorkerServiceImpl::OnRemoteSharedWorkerConnectionLost() should match the one in DestroyHost(). Both of these functions can be invoked when the callback is not set. Bug: 1008257 Change-Id: I9dd5f7812bbe01dfba8bb3a5fca0481e6a4ee7aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862892 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#706270}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/65084e6f..ecd11dd1 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ie1f1b70946759c2206a08efe6e65831c5c8a90d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863438Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#706269}
-
Jeroen Dhollander authored
Currently the ash::mojom::AssistantState::READY signal is sent out when LibAssistant is created, not when it finished starting. This puts us in a limbo state where we're told everything is up and running, but any query sent out will be rejected. To fix that, a new signal ash::mojom::AssistantState::NEW_READY has been introduced that will only be sent out when LibAssistant signals it is ready to process queries. This signal should eventually replace the old |READY| signal, but for now it is added as a new signal to allow us to check it is sent out consistently on all devices. Internally this is achieved by introducing a new |AssistantStateObserver| which is used to inform |Service| about all state changes to the |AssistantManagerService::State|. These state changes are then forwarded to |AssistantClient::OnStatusChanged|. BUG: b/141264108 Change-Id: I38d9635001be5ef13e80090102646559e5c17158 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835183 Commit-Queue: Jeroen Dhollander <jeroendh@google.com> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#706268}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/af0aa0977370..2f6e525099a0 git log af0aa0977370..2f6e525099a0 --date=short --no-merges --format='%ad %ae %s' 2019-10-15 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 1c1107d4..bdc89d87 (705985:706176) Created with: gclient setdep -r src/third_party/webrtc@2f6e525099a0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: I736f0fa0b0922202a959cac5ff3d1ce03302c61c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864017Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#706267}
-
George Burgess IV authored
This reverts commit af31b7d5. The problem bit us again in crbug.com/1005023, so I implemented a more general fix. As a result, we should now be safe to turn AFDO back on here. Bug: 916130 Change-Id: I0f29059f9eccaf62dfeeccf543a8cabbeeaf86a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860881Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: George Burgess <gbiv@chromium.org> Cr-Commit-Position: refs/heads/master@{#706266}
-
Sergey Ulanov authored
Previously WebEngine was crashing when user clicks on a drop-down box. The issue was that WindowParentingClient interface wasn't implemented for root Aura windows that are used to host web frames. This CL adds WindowParentingClient implementation. Also updated LayoutManager implementation to handle drop-down menu windows properly. Bug: fuchsia:34997, fuchsia:36350 Change-Id: I173febd62825dbe460844742451cc8581e41b3b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1861039 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#706265}
-
Peter Kasting authored
Some places called Layout() instead of InvalidateLayout(), which is less efficient and works poorly with layout managers. Some places did not SchedulePaint() when changing characteristics that would affect paint, e.g. text color. Some places called InvalidateLayout() or SchedulePaint() unnecessarily, e.g. after calling another function that should do these as needed. Bug: none Change-Id: Ie2cf7f01c0e1bccaf0a98365ed0e6fb63bfe7f67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857569 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#706264}
-
Hiroki Nakagawa authored
The test is flaky on several bots. See the issue for details. Bug: 1014790 Change-Id: Ib438e3fabf825b2ebafc5d59a1de6248a260c5cd Tbr: bsazonov@chromium.org Notry: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862879Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#706263}
-
Sergey Ulanov authored
This reverts commit a2c0ced3. Reason for revert: Breaks webengine in some scenarios Original change's description: > [Fuchsia] Reenable protected mode in WebEngine > > Bug: 982922, fuchsia:24570 > Change-Id: If9fb495249488c43f97e4451a14f0193911d600f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804527 > Reviewed-by: Sergey Ulanov <sergeyu@chromium.org> > Commit-Queue: Emircan Uysaler <emircan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#697683} TBR=sergeyu@chromium.org,emircan@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 982922, fuchsia:24570, fuchsia:38358 Change-Id: Ifa2cc465d53891484ff23b7f737ee69169b8dd09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864094Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#706262}
-
Yusuke Sato authored
BUG=b:139700524 TEST=no code change Change-Id: Ia532872f4709f8dbacae84795b8b475ea76682af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850757Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#706261}
-
Dominic Mazzoni authored
JAWS calls IndexInParent on nodes in the accessibility tree frequently. Try to use the efficient version rather than recomputing it. Bug: 1008558 Change-Id: Ieadfe193b0b294eb1bdb2efbcfd118ff5e1fecc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828066Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#706260}
-
James Darpinian authored
https://crrev.com/c/1812241 reads the monitor refresh rate with xrandr when we're using desktop GL on Linux Nvidia. This applies the same fix when we're using ANGLE (--use-cmd-decoder=passthrough). Also fixes X11 errors when the primary display is disconnected. Bug: 1012262, 535392 Change-Id: I0c54371496aa141643c5f6a2950935e22ba0f534 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857091 Commit-Queue: James Darpinian <jdarpinian@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#706259}
-
Nathan Zabriskie authored
This Cl adds a flag for ANGLE's D3D11on12 backend: https://chromium-review.googlesource.com/c/angle/angle/+/1814404/3 This backend is being added to evaluate potential challenges in creating a full D3D12 implementation. Bug: angleproject:3919 Change-Id: I2e20f50b79399a14beb8d0e64e54f55d98be7582 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818430 Commit-Queue: Nathan Zabriskie <nazabris@microsoft.com> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#706258}
-
Nasko Oskov authored
This test was disabled as flaky a long time ago, so trying to enable it since lots of code has changed since then. Bug: 452018 Change-Id: I803cb8d52a7a9ce5fb0dec83ee9deb99f04a8ff5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864019Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#706257}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/9c927784e714..22f14e2a1c49 git log 9c927784e714..22f14e2a1c49 --date=short --no-merges --format='%ad %ae %s' 2019-10-15 dburger@chromium.org Invoke determine_android_version with iterable. Created with: gclient setdep -r src/third_party/chromite@22f14e2a1c49 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I757234e68a624cb25c22ac948ee43992a3b8533b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862272Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#706256}
-