GitLab

I added the UIPage layer which is the shared structure between all the
WebUI pages. This involved fleshing out the ButtonNavigationBehavior to
allow links appearing in the UIPage to have page-specific customized
callbacks for links appearing in the messages (and the behavior was
accordingly renamed UiPageContainerBehavior).

To make sure that the structure was functional, I added links into the
placeholder text for the pages' messages where they are supposed to
appear in the actual text and tested that they can access custom
callbacks.

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I4963c9e573e83ea4c699920639cfe197fe6e1613
Reviewed-on: https://chromium-review.googlesource.com/1029531Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Jordy Greenblatt <jordynass@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554203}

This fixes an issue where the browser actions bar disappears after
disabling the last extension (intended) and cannot come. Before this
change when re-enabling an extension the bar would not be resized to
include its resize handle so it could not be pulled to bring out the
newly added extension.

The fix seems fairly safe which is good as it needs to be merged into
M67. I'm intending to revisit this part of the code as part of cleanup
work to unify ToolbarActionsBar and BrowserActionsContainer.

Bug: chromium:836182
Change-Id: I2a196edc867ec70dd74aa4690576540b31548b97
Reviewed-on: https://chromium-review.googlesource.com/1030891
Commit-Queue: Peter Boström <pbos@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554202}

When a download is being destroyed while a CheckClientDownloadRequest
is in-flight, we ignore the callback to CheckClientDownloadDone.
This prevents crash that caused by DownloadManagerImpl being destructed
before CheckClientDownloadDone during browser shutdown.

A new UMA enum is added to track this special case.

Bug: 830303
Change-Id: Iff5146a163e357ebd9b97b97cf48c6d7af9a7783
Reviewed-on: https://chromium-review.googlesource.com/1024864
Commit-Queue: Jialiu Lin <jialiul@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554201}

Bug: 798569
Change-Id: Icbf148140ecf76f02f795bf8022e5a397933d638
Reviewed-on: https://chromium-review.googlesource.com/1030818Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554200}

chrome://discards displays tab favicons by URL.

Bug: 837420
Change-Id: Ia5c2a0386f4707b0d550cec0deee4927a32d34ba
Reviewed-on: https://chromium-review.googlesource.com/1031057Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554199}

The LUCI builders are now "prod", the Buildbot builders
are not needed and can now be fully removed.

Bug: 790378,790311,790308
Change-Id: Idf44fa3993173a9b40c899c187a0c3b50526ece6
Reviewed-on: https://chromium-review.googlesource.com/1031379
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Reviewed-by: Ryan Tseng <hinoka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554198}

Bug: 837190,832173,837137
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I185bf0e3c4e0a4bdb3a15d4288c60c91bed1221b
Reviewed-on: https://chromium-review.googlesource.com/1030881
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554197}

This matches the behavior we have in UI.ToolbarMenuButton

Bug: 830320
Change-Id: Icb8692cebda088acdfb87abe391f033ffd2bd168
Reviewed-on: https://chromium-review.googlesource.com/1014632Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Joel Einbinder <einbinder@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554196}

Custom DIAL patch part 2. (diffbase = 1012744)


Running Dial MRP on IO thread allows it to access DMSSImpl directly
without the need for additional layer of caching and trampolining,
greatly simplifying the interaction between the two objects. To do this,
DMSSImpl* is temporarily exposed from DualMSS. This won't be needed
once we no longer need to provide DIAL sinks to the extension.

Also, renamed the feature name to DialMediaRouteProvider to be
consistent with Cast.


Bug: 816628
Change-Id: I29b7c7751072e4bd60c72f2ae7c5738f4c3df323
Reviewed-on: https://chromium-review.googlesource.com/1014722
Commit-Queue: Derek Cheng <imcheng@chromium.org>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554195}

Previously, the plugin completely skipped virtual specifier checks on
Gmock objects since it wasn't smart enough to filter out warnings caused
by Gmock macros. In preparation for making the plugin smarter, this CL
fixes existing virtual specifier warnings in //device.

Bug: 837148
Change-Id: Ife28dad1274c14770ee8fdcaae286052e15ccfee
Reviewed-on: https://chromium-review.googlesource.com/1031197Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554194}

paper-button styles were moved from cr-shared-style to paper-button-style
at r553689.

Bug: 837144
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I6f58d55bee359c199552370b11a0da8661264609
Reviewed-on: https://chromium-review.googlesource.com/1030822Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554193}

The failure expectations for some wpt/fetch/corb/*tentative* tests were
only needed while CORB was still disabled by default.  These test
expectations can be removed now, because CORB is enabled by default
since r553830.

Bug: 802835
Change-Id: If09646e3cfec268e2a9ec72aa870d8fa2a4460e3
Reviewed-on: https://chromium-review.googlesource.com/1030612Reviewed-by: Charlie Reis <creis@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554192}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/aa6cca46950b..74d7d171a121

$ git log aa6cca469..74d7d171a --date=short --no-merges --format='%ad %ae %s'
2018-04-25 yunlian chromeos_config: only set USE=thinlto for amd64 toolchain builders.
2018-04-12 bmgordon cbuildbot_launch: Track state of the previous build
2018-04-23 levarum Copy ndk-translation artifacts when uprevving android

Created with:
  roll-dep src/third_party/chromite
BUG=chromium:827217,chromium:829665


The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: Ida506a20c73f9feffdc2c0aac80d5eb872ae115d
Reviewed-on: https://chromium-review.googlesource.com/1031170Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#554191}

Change-Id: Iab15b87fc3eb8a695af47b413de8b555db0eec9e
Reviewed-on: https://chromium-review.googlesource.com/1026234
Commit-Queue: Ryan Hamilton <rch@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554190}

Small fixes in style, also removing TODO after analyzing whether or not
we could replace the use of |render_process_host_id| and |routing_id| in
favor of WebContents.

Bug: None
Test: Build.
Change-Id: I33fcfc91feb45f076e3fd97288460a1b1f211880
Reviewed-on: https://chromium-review.googlesource.com/1026562Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Commit-Queue: David Jacobo <djacobo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554189}

In printing, 2-up, 3-up, or more generally N-up refers to a page
layout strategy in which multiple pages are composited onto a
single page.

1. Added ability to pass the N-up feature UI settings(which will be
   added in the next CL) to the print preview workflow, so that the
   PDF plugin can take action based on user's input.
2. Added N-up feature support to pdfium_engine, so that when the
   source is PDF, pdf plugin will generate the N-up output doc based
   on user's input.

These changes have been reviewed in:
https://chromium-review.googlesource.com/c/chromium/src/+/1014628.

Bug: 775999
Change-Id: I552c9c91e32af0faa6ffaa8c42ac0652f470f791
Reviewed-on: https://chromium-review.googlesource.com/1028992Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Shirleen Lou <xlou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554188}

This includes the implementation in ash, but no clients
(dependent CL will follow).

Bug: 682402
Change-Id: I9fe82f915f2b2ddacc29c27f039a47bc8b8a043b
Reviewed-on: https://chromium-review.googlesource.com/1011563
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Malay Keshav <malaykeshav@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554187}

Change-Id: If97f64f59c4c653713b3e481ec8a368a85c288ee
Reviewed-on: https://chromium-review.googlesource.com/1026272
Commit-Queue: Ryan Hamilton <rch@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554186}

Disable this test on L only.  Seems to work fine on all other
versions of Android.

TBR=yfriedman@chromium.org

BUG=837423

Change-Id: Ib0ca3d638425a0459ea9e06486884fdeed2fbaca
Reviewed-on: https://chromium-review.googlesource.com/1031558
Commit-Queue: Donn Denman <donnd@chromium.org>
Reviewed-by: Donn Denman <donnd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554185}

TBR=tandrii@chromium.org

Change-Id: I8f4bb2b3c9d654779b77aeff8f36ea71c9f9454e
Reviewed-on: https://chromium-review.googlesource.com/1031616Reviewed-by: Jao-ke Chin-Lee <jchinlee@chromium.org>
Commit-Queue: Jao-ke Chin-Lee <jchinlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554184}

Fix FlippedBlocks overflow

Fix overflow-basic-002.html per spec.

Bug: 728378
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I0b42895b327f17e7896d6d03026555aa0aba67da
Reviewed-on: https://chromium-review.googlesource.com/1026250
Commit-Queue: Aleks Totic <atotic@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554183}

If the text is empty, skip the unfocusing animation
logic as it causes the weird jumps shown (because of the
different in width between the unfocused and focused views).

Also when updating the URL direction (i.e. when switching
from a normal tab with LTR text to a new incognito tab w/
RTL hint text), ensure that you rescroll the TLD to avoid
it being blank on the first incognito tab.

BUG=836273,822869

Change-Id: Ib3413a6810ca651cdf38d9f9e9c59798a7051ecf
Reviewed-on: https://chromium-review.googlesource.com/1031382
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554182}

Using wpt-import in Chromium 90eaf58b.
With Chromium commits locally applied on WPT:
303956b6 "Enable WPT tests for the Generic Sensor classes"
7c13f644 "Subtract scrollbar in PerpendicularContainingBlockLogicalHeight"
a8385691 "Make web font timeouts work for preloaded fonts"


Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/16272

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
jsbell@chromium.org:
  external/wpt/encoding
  external/wpt/resources

TBR=foolip

No-Export: true
Change-Id: Iabf7930816b9f0f1a0f7c9dc54518a5fabb88941
Reviewed-on: https://chromium-review.googlesource.com/1031391
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554181}

When cryptohome-based PIN lands, these will become parameterized tests which
test both the PIN and cryptohome backends.

Bug: 826773
Change-Id: I41cb1ff286d423b96e3c4bb1f26a49a3d32b7468
Reviewed-on: https://chromium-review.googlesource.com/998688
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554180}

https://ci.chromium.org/buildbot/tryserver.chromium.chromiumos/linux-chromeos-rel/110109

TBR=ortuno@chromium.org

Bug: 837277
Change-Id: I194d586b15f29b9e544ff2d170fb25b59ad2cff8
Reviewed-on: https://chromium-review.googlesource.com/1031490
Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554179}

Original CL:
https://chromium-review.googlesource.com/c/chromium/src/+/1029203

Revert CL:
https://chromium-review.googlesource.com/c/chromium/src/+/1031250

Bug: b/77637813
Change-Id: I841a8b841e5db3703f32f6ce959759678b2766e9
Reviewed-on: https://chromium-review.googlesource.com/1031202Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Commit-Queue: David Black <dmblack@google.com>
Cr-Commit-Position: refs/heads/master@{#554178}

Add a slash. Without it codesearch displays this error:
"""
Can't load 'chromium/src/tools/perf/benchmarks': Could not resolve path
src/tools/perf/benchmarks.
"""

NOTRY=true

Bug: None
Change-Id: Idac1d1ec0ae0c9ec745913b334545b0567e1e5d3
Reviewed-on: https://chromium-review.googlesource.com/1030557
Commit-Queue: Egor Pasko <pasko@chromium.org>
Reviewed-by: Egor Pasko <pasko@chromium.org>
Reviewed-by: Annie Sullivan <sullivan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554177}

VSync paramteters are specified in two places.
1. In SW and HW compositing,  to the ui::Compositor via
   RenderWidgetHostViewMac::UpdateDisplayVSyncParameters
2. Via viz::SoftwareOutputDeviceMac through its
   gfx::VSyncProvider implementation.

The parameters specified by method 2 are ignored, and are a cause of
lots of extra plumbing. Remove them, and make SoftwareOutputDeviceMac
return nullptr for its vsync provider.

Bug: 821651
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I0f48d1e5a4ae5235d87d840c19f4ce0c8f16e5eb
Reviewed-on: https://chromium-review.googlesource.com/1029958Reviewed-by: enne <enne@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554176}

In this case, always use |last_used_profile| which contains the profile id
extracted from the notification launch id, rather than |last_opened_profiles|.

Bug: 833663, 734095
Change-Id: I1f8721ba1dcb7b7ab60264dfcae873f664d8121e
Reviewed-on: https://chromium-review.googlesource.com/1031010
Commit-Queue: Xi Cheng <chengx@chromium.org>
Reviewed-by: Tommy Martino <tmartino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554175}

Bug: 832886
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: If566aa3fd7d00c6310b1919909f9a536a375627a
Tbr: kbr@chromium.org
No-try: true
Reviewed-on: https://chromium-review.googlesource.com/1030900
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554174}

PinBackend will use either PinStoragePrefs or PinStorageCryptohome for
PIN related management functions.

PinStorageCryptohome is currently stubbed and will be filled out in a
later CL.

BUG=826773

Change-Id: Id09ca628ef75ae48f7a500e716446134e3adf855
Reviewed-on: https://chromium-review.googlesource.com/988653
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554173}

This updates the Crostini launcher integration so that it includes the
icons. Icons are stored in the user's storage directory and the file path
for the icons is generated based on the app_id. We use the
CrostiniManager for requesting the icons from the Linux container.
Resizing of returned icons is performed if we do not get the size/scale
factor we requested from Linux.

Bug: 836044
Test: Verified icons load, handles scaling and app removal/addition
Change-Id: I37c4297af6219ddadc200598cec52d7c40140758
Reviewed-on: https://chromium-review.googlesource.com/1028588
Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com>
Reviewed-by: Nicholas Verne <nverne@chromium.org>
Reviewed-by: Timothy Loh <timloh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554172}

Previously, the plugin completely skipped virtual specifier checks on
Gmock objects since it wasn't smart enough to filter out warnings caused
by Gmock macros. In preparation for making the plugin smarter, this CL
fixes existing virtual specifier warnings in //extension.

Bug: 837148
Change-Id: I0d567df519e54e8e4758fe74be2c7863a2a477a4
Reviewed-on: https://chromium-review.googlesource.com/1031183Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554171}

Bug: 781655
Change-Id: I2bb5975fbdcbb3e888c089eeb9be674b7e16a723
Reviewed-on: https://chromium-review.googlesource.com/1013687
Commit-Queue: Adithya Srinivasan <adithyas@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554170}

Bug: 798851

Change-Id: I42429952cc7f2cc0be001fbe4930a4f6cadf3d13
Reviewed-on: https://chromium-review.googlesource.com/1025049
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554169}

* const -> constexpr
* Move various constants to right where they're used.  In some of these cases
  Refresh won't need the constants, and keeping them inside non-Refresh
  conditionals should help us clean up the code later.  In other cases I was
  just being consistent.  I left things file-scope when used by multiple places.
* Make private some stuff that turns out not to need to be public after all

BUG=none
TEST=none

Change-Id: I7d725fc942c38ceeb8368f3456c391d078e1b924
Reviewed-on: https://chromium-review.googlesource.com/1031181Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554168}

(both inclusive).

Bug: 835701
Change-Id: I93f2aeed4bd615e5380f6d877479df0a46367f3d
Reviewed-on: https://chromium-review.googlesource.com/1031172
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Helen Li <xunjieli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554167}

This is a mechanical refactoring. A future CL will change the behavior to
allow injecting nullptr as a CrxComponent when the CRX is uninstalled
during an update check.

Bug: 837371,722942

Change-Id: I5f70fdd032a37c08bf35a286c51b109a2ca07ce0
Reviewed-on: https://chromium-review.googlesource.com/1027116Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Sorin Jianu <sorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554166}

This reverts commit d7a83cd8.

Reason for revert: bots are still infra failing

Original change's description:
> Re-add layout tests to win7 bot
> 
> Bug: 831585
> Change-Id: I3436ca3abe39a648a150d703173715f69756e508
> Reviewed-on: https://chromium-review.googlesource.com/1028009
> Commit-Queue: Stephen Martinis <martiniss@chromium.org>
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Reviewed-by: John Budorick <jbudorick@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#553868}

TBR=dpranke@chromium.org,martiniss@chromium.org,jbudorick@chromium.org

Change-Id: I4d08d6e21a0ac4622d7a936ff92a5bd795d5af13
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 831585
Reviewed-on: https://chromium-review.googlesource.com/1031530Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554165}

- git --follow and --reverse don't work together. Just
  --follow is extremely slow, so use a best estimation
  with git blame on L1.
- For third_party, use OWNERS file to determine owners.
- Add skip_owners attribute to allow skipping of owners
  file.
- Fix review nits from last cl.

R=mmoroz@chromium.org
Bug:821574

Change-Id: I89fad0beae8a66ac3c6acfde0faa9b7d4be22383
Reviewed-on: https://chromium-review.googlesource.com/1030269Reviewed-by: Max Moroz <mmoroz@chromium.org>
Reviewed-by: Jonathan Metzman <metzman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554164}