- 31 Aug, 2016 40 commits
-
-
qyearsley authored
Reason: When downloading expectations for newly imported/updated w3c tests, we only want to download baselines for tests that are modified in the CL, because w3c test update CLs only modify tests (not Blink source code). This should prevent downloading baselines for other tests that failed on the try bots on some platform. BUG=629275 Review-Url: https://codereview.chromium.org/2291153003 Cr-Commit-Position: refs/heads/master@{#415787}
-
tedchoc authored
BUG=606513 Review-Url: https://codereview.chromium.org/2296833002 Cr-Commit-Position: refs/heads/master@{#415786}
-
sebmarchand authored
BUG=629006, 630372 Review-Url: https://codereview.chromium.org/2298273003 Cr-Commit-Position: refs/heads/master@{#415785}
-
fgorski authored
This makes an update to OfflinePageUtilsTest.testCopyToShareableLocation to make it more reliable (by ensuring a more proper clean up). BUG=640319 patch from issue 2259413002 at patchset 1 (http://crrev.com/2259413002#ps1) Review-Url: https://codereview.chromium.org/2303443002 Cr-Commit-Position: refs/heads/master@{#415784}
-
toyoshim authored
wasCached() does not contain memory cache hit case. But WebFonts intervention study's results imply memory cache hit case is not minor group, but probably bigger one than Miss group. This patch adds one additional group MemoryHit to WebFoint.CacheHit metric to ensure memory cache hit ratio. Review-Url: https://codereview.chromium.org/2289113002 Cr-Commit-Position: refs/heads/master@{#415783}
-
tdanderson authored
Adds the initial plumbing needed in order to move Ash-specific .icon files out of ui/gfx/vector_icons and into ash/common/resources/vector_icons. As a result, these icons will only be included when the 'ash' component is built. Previously, the icon file foo_bar.icon would be identified in code as the enum value gfx::VectorIconId::FOO_BAR. For Ash-specific icons, foo_bar.icon is now identified in code as the constant ash::kFooBarIcon, which maps to a VectorIcon struct (also introduced in this CL). The eventual goal is for all icons to be identified in this manner, and for the gfx::VectorIconId struct to be removed. BUG=626786 TEST=manual Review-Url: https://codereview.chromium.org/2251643011 Cr-Commit-Position: refs/heads/master@{#415782}
-
waffles authored
the version is lower. BUG=642323 Review-Url: https://codereview.chromium.org/2298343002 Cr-Commit-Position: refs/heads/master@{#415781}
-
isherman authored
This experiment is rolled out to 100% of users server-side, so: (1) Update the client code to default to the new code path, and (2) Remove the old code path, which is no longer reachable. BUG=none TEST=none R=mlliu@chromium.org Review-Url: https://codereview.chromium.org/2282273002 Cr-Commit-Position: refs/heads/master@{#415780}
-
rch authored
BUG=642709 Review-Url: https://codereview.chromium.org/2295043004 Cr-Commit-Position: refs/heads/master@{#415779}
-
jonross authored
The highlight animations for download item views was being posted to a non-nested loop. This allowed them to clear after returning from a blocking menu call. Menus do not block now. Updating the animations to register a callback with DownloadShelfContextMenuView so that they can clear the highlight once the menu has closed. TEST=manually test download visuals BUG=642672 Review-Url: https://codereview.chromium.org/2295323002 Cr-Commit-Position: refs/heads/master@{#415778}
-
brettw authored
This removes the duplication of outputs from core/inspector:protocol_sources to the compiled version in core:core_generated. A new target is created core/inspector:protocol that uses get_target_outputs on :protocol_sources to avoid duplicating the sources list. To make this easier to implement, the core_config_add and core_config_remove configs list were moved to core.gni so it can be shared with multiple core build files. The inspector_protocol.gni file was changed from listing the sources to defining a template to run the script. This elimiates some duplicated code between the two users of this script. BUG= Review-Url: https://codereview.chromium.org/2294123002 Cr-Commit-Position: refs/heads/master@{#415777}
-
fgorski authored
Revert of Remove default begin frame sources from the renderer (patchset #11 id:200001 of https://codereview.chromium.org/2083423006/ ) Reason for revert: Speculative revert as there are some bots failing with a common and related stack. Original issue's description: > Remove default begin frame sources from the renderer > > This changes both cc proxies to no longer create default begin frame > sources. In cc, it must either be the case that an external begin frame > source is provided (with use_external_begin_frame_source set) or the > output surface provides a begin frame source (with > use_output_surface_begin_frame_source). > > This changes the world from three states of BFS creation (default, > output surface provided, and external) to only two (output surface > provided and external). In the future, external will also be removed. > > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel > > Committed: https://crrev.com/da025c649b0c2339771f2b06c482dcf8e388e889 > Cr-Commit-Position: refs/heads/master@{#415757} TBR=danakj@chromium.org,sievers@chromium.org,enne@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/2296353002 Cr-Commit-Position: refs/heads/master@{#415776}
-
weiran authored
BUG=630753 Review-Url: https://codereview.chromium.org/2247063002 Cr-Commit-Position: refs/heads/master@{#415775}
-
joedow authored
This change moves the connection validation logic for It2Me from the host factory and into a callback in the It2Mehost class. A subsequent change will move the confirmation dialog into this new method as well but that is a larger change and I wanted to keep the initial change small. BUG=617185 Review-Url: https://codereview.chromium.org/2271933002 Cr-Commit-Position: refs/heads/master@{#415774}
-
fdoray authored
This field trial has expired. BUG=557984 Review-Url: https://codereview.chromium.org/2280183002 Cr-Commit-Position: refs/heads/master@{#415773}
-
hanxi authored
After request to update a WebAPK, a APK is downloaded by WebAPKInstaller. This CL enables to install the downloaded WebAPK to finish the updating. This CL depends on CL (https://codereview.chromium.org/2259553002/). BUG=631025, 637097 Review-Url: https://codereview.chromium.org/2264753002 Cr-Commit-Position: refs/heads/master@{#415772}
-
vakh authored
Since the verdict field is currently marked as 'required', whenever Chrome (or Firefox) can't parse this field properly, it leads to an overall failure in parsing the entire proto message. Making it optional with a default value (SAFE) solves that problem. See: cl/131841696 BUG= Review-Url: https://codereview.chromium.org/2292963004 Cr-Commit-Position: refs/heads/master@{#415771}
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) build: https://crrev.com/f835a9107ae607130e9c658067a23c7334b22f83 Revert of lightweight builds archiving for mac and win64 (patchset #8 id:140001 of https://codereview.chromium.org/2279953002/ ) (miimnk@google.com) TBR=martiniss@chromium.org,phajdan.jr@chromium.org BUG=604452 Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Review-Url: https://codereview.chromium.org/2298873003 Cr-Commit-Position: refs/heads/master@{#415770}
-
hush authored
Both drag and drop and context menu use the same gesture: long press on Android. In order to maintain backwards compatibility, we need to suppress drag and drop for links on Android and continue to use long press gesture for context menus. This change also applies to other platforms with a touch screen, so that touch screen behavior is consistent on all platforms. BUG=636005 Review-Url: https://codereview.chromium.org/2247963002 Cr-Commit-Position: refs/heads/master@{#415769}
-
dmazzoni authored
Add a PRESUBMIT rule that enforces that both ax_enums.idl and automation.idl have matching enums so we don't accidentally let them get out of sync. Fix one missing enum, and add a few missing enums directly to ChromeVox too. BUG=641179 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2290763002 Cr-Commit-Position: refs/heads/master@{#415768}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/3d16d190..4877527d Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2301643002 Cr-Commit-Position: refs/heads/master@{#415767}
-
pdfium-deps-roller authored
https://pdfium.googlesource.com/pdfium.git/+log/fc9b11358a47..21b111fcf71e $ git log fc9b11358..21b111fcf --date=short --no-merges --format='%ad %ae %s' 2016-08-31 thestig Attempt to fix potential integer overflow in CFX_FaceCache::LoadGlyphPath(). 2016-08-31 dsinclair Use CheckedNumeric for strength calculation. BUG=641333,639506 TBR=dsinclair@chromium.org Review-Url: https://codereview.chromium.org/2300793002 Cr-Commit-Position: refs/heads/master@{#415766}
-
brettw authored
Delete chrome/chrome_renderer.gypi. TBR=dpranke@chromium.org Review-Url: https://codereview.chromium.org/2301453003 Cr-Commit-Position: refs/heads/master@{#415765}
-
xunjieli authored
CronetUrlRequestTest#testFailures() simulates callback failures in each response step. However, the response step is not updated in onFailed, so maybeThrowCancelOrPause() will throw an exception again. This results in a flake in the Java implementation. This CL updates response step in TestUrlRequestCallback, and adds two more tests to make sure throwing exception or canceling does nothing in terminal callbacks (onFailed, onCanceled, onSucceeded) R=kapishnikov@chromium.org BUG=635026 Review-Url: https://codereview.chromium.org/2292113002 Cr-Commit-Position: refs/heads/master@{#415764}
-
sky authored
StrongBinding means GpuServiceInternal is deleted when the pipe is closed, defeating the singleton nature. By converting to Binding when the pipe is closed GpuServiceInternal is not deleted. BUG=none TEST=none R=sadrul@chromium.org Review-Url: https://codereview.chromium.org/2302523002 Cr-Commit-Position: refs/heads/master@{#415763}
-
cbiesinger authored
And use that to add a test for ng_block_layout_algorithm that tests layout with children. BUG=635619 R=eae@chromium.org,glebl@chromium.org,ikilpatrick@chromium.org Review-Url: https://codereview.chromium.org/2291273002 Cr-Commit-Position: refs/heads/master@{#415762}
-
estade authored
Redirect all mouse input to Alt+Tab window when it's visible, effectively disabling the mouse. Capture is reset when the widget is destroyed. original review: https://codereview.chromium.org/2284763002/ BUG=641171 Review-Url: https://codereview.chromium.org/2296763002 Cr-Commit-Position: refs/heads/master@{#415761}
-
nyquist authored
This CL creates a BlimpView that is owned by the native BlimpContentsViewAndroid. It is created whenever the BlimpContentsViewAndroid is created, which is done when BlimpContentsImpl is created. The BlimpView needs access to the current Android Context, which is now passed through the call to CreateBlimpContents() as a NativeWindow which on Android is a WindowAndroid. When a BlimpContents is available and Blimp is enabled, this also hooks up the BlimpView to TabContentViewParent. The BlimpView is with this patch attached to the view hierarchy, and sends onSizeChanged events to the BlimpContentsImpl. The touch events are piped through to the BlimpCompositorManager. The old BlimpView in //blimp/client/app was colliding with the new, so it has been moved in to the namespace blimp::client:app. BUG=608759 Review-Url: https://codereview.chromium.org/2270323004 Cr-Commit-Position: refs/heads/master@{#415760}
-
pdr authored
This test is still failing after the suppression in [1]: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=css3%2Ffilters%2Ffilter-repaint-turbulence.html This patch marks the test as pass/fail for both debug and release. [1] https://crrev.com/079ac671bc155405d5d544ce2fe27b017e668e8e BUG=598051 NOTRY=true Review-Url: https://codereview.chromium.org/2301523004 Cr-Commit-Position: refs/heads/master@{#415759}
-
justincohen authored
Temporarilly set FLAGS_quic_enable_version_35, FLAGS_quic_enable_version_36 and FLAGS_quic_enable_version_36_v2 to true. BUG=642709 TBR=rch Review-Url: https://codereview.chromium.org/2301623002 Cr-Commit-Position: refs/heads/master@{#415758}
-
enne authored
This changes both cc proxies to no longer create default begin frame sources. In cc, it must either be the case that an external begin frame source is provided (with use_external_begin_frame_source set) or the output surface provides a begin frame source (with use_output_surface_begin_frame_source). This changes the world from three states of BFS creation (default, output surface provided, and external) to only two (output surface provided and external). In the future, external will also be removed. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Review-Url: https://codereview.chromium.org/2083423006 Cr-Commit-Position: refs/heads/master@{#415757}
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) build: https://crrev.com/50bd0c2f545a5cff594a628ca45182915632dd82 Remove gerrit_rebase_patch_ref from run_presubmit.py (andybons@chromium.org) TBR=martiniss@chromium.org,phajdan.jr@chromium.org BUG=602906 Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Review-Url: https://codereview.chromium.org/2303453002 Cr-Commit-Position: refs/heads/master@{#415756}
-
https://codereview.chromium.org/2270433002/thakis authored
BUG=none TBR=thestig@chromium.org NOTRY=true Review-Url: https://codereview.chromium.org/2298013004 Cr-Commit-Position: refs/heads/master@{#415755}
-
catapult-deps-roller authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/08327b978d86..7764fcd16aac $ git log 08327b978..7764fcd16 --date=short --no-merges --format='%ad %ae %s' 2016-08-31 alexandermont Change some remaining instances of power to powerInW. TBR=catapult-sheriff@chromium.org Review-Url: https://codereview.chromium.org/2296763005 Cr-Commit-Position: refs/heads/master@{#415754}
-
dgozman authored
- allow importing all domains in single header; - support for <includes.h>; - separate export macro/header for lib, protocol and exported; - improved code for defaults. BUG=637032 Review-Url: https://codereview.chromium.org/2296043004 Cr-Commit-Position: refs/heads/master@{#415753}
-
emircan authored
Revert of Use webrtc::VideoFrame timestamp in RTCVideoEncoder (patchset #7 id:260001 of https://codereview.chromium.org/2205623002/ ) Reason for revert: This CL caused some regressions regarding BWE stats and HW encoder performance. Reasons include: 1) Modifying scoped_refptr<media::VideoFrame>'s timestamp causes problems for other clients using the same media::VideoFrame. 2) WebRTC's RTP timestamp isn't suitable for using as presentation timestamp in Mac and Win HW encoders. BUG=641230 Original issue's description: > Use webrtc::VideoFrame timestamp in RTCVideoEncoder > > This CL fixes input timestamp mismatch in RTCVideoEncoder, which > broke googAvgEncodeMs and googEncodeUsagePercent stats in webrtc-internals > for hardware encoders. > With this change, we start using WebRTC given timestamp() so that > OveruseFrameDetector can match the timestamps and calculate the stats. > > BUG=597087 > TEST=googAvgEncodeMs and googEncodeUsagePercent works on Mac(H264) and > veyron_jerry(VP8). > > Committed: https://crrev.com/e3195490a63d9545fb1bfe560aa21680ba0b5843 > Cr-Commit-Position: refs/heads/master@{#414589} TBR=wuchengli@chromium.org,pbos@chromium.org,posciak@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=597087 Review-Url: https://codereview.chromium.org/2296273002 Cr-Commit-Position: refs/heads/master@{#415752}
-
hcarmona authored
UI remains the same. BUG=626878 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2300433002 Cr-Commit-Position: refs/heads/master@{#415751}
-
asvitkine authored
The new domain is clientservices.googleapis.com. Also, removes testing config for VarationsServiceControl 30m interval trial, since that's the client default. Updates the parameter code for the fetch interval to fix the typo in the trial name. Note: Should not be submitted until we verify that the new URL is working. BUG=635680 Review-Url: https://codereview.chromium.org/2223263002 Cr-Commit-Position: refs/heads/master@{#415750}
-
stanisc authored
Revert of Disabled flaky test AppBackgroundPageApiTest.NoJsBackgroundPage (patchset #1 id:1 of https://codereview.chromium.org/2294113003/ ) Reason for revert: The bug is now fixed so disabling this test is no longer needed. See https://codereview.chromium.org/2293293002/ Original issue's description: > Disabled flaky test AppBackgroundPageApiTest.NoJsBackgroundPage > > BUG=642482 > TBR=stanisc@chromium.org,nick@chromium.org > > Committed: https://crrev.com/940f8f135b20b2e5bca8c76ad036eb98e142def0 > Cr-Commit-Position: refs/heads/master@{#415620} TBR=nick@chromium.org,battre@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=642482 Review-Url: https://codereview.chromium.org/2299803002 Cr-Commit-Position: refs/heads/master@{#415749}
-
lgcheng authored
Arc enable sync pref is false by default if user never modify sync settings. This patch enables arc sync service to start when user never manually modify sync settings. BUG= http://b/31156650 TEST=Manual test on a machine that sync settings is never modified. Review-Url: https://codereview.chromium.org/2289163003 Cr-Commit-Position: refs/heads/master@{#415748}
-