- 12 Jun, 2018 40 commits
-
-
Philip Rogers authored
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I36517164645aad4ac3132c8a510bb8ddab024a9f Reviewed-on: https://chromium-review.googlesource.com/1086274 Commit-Queue: Philip Rogers <pdr@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#566425}
-
Hans Wennborg authored
One of the tests was previously disabled in #565985, but the other tests fail in the same way, so this disables them too. TBR=mlamouri Bug: 850870 Change-Id: I3c222c3d2e7b01dec946cf93f46fa5239f8c13de Reviewed-on: https://chromium-review.googlesource.com/1097328Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#566424}
-
Patrick Monette authored
Before this change, it took two relaunches to disable the blocking of third-party modules. This is because the deletion of the cache was only done once after startup, and then another launch was needed so that chrome_elf.dll wouldn't initialize with a existing cache file. Now the pref is observed so that the cache file can be deleted during runtime, making sure that it won't exist on relaunch. If Chrome is not running when the pref is disabled, one launch will still be needed to delete the cache and another one to truly have the blocking disabled. Change-Id: I577e8a55a87f3caa4a3cea63bd67c31a8b542fd7 Reviewed-on: https://chromium-review.googlesource.com/1083811Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#566423}
-
Makoto Shimazu authored
Currently we pass kURLLoadOptionNone when creating MojoAsyncResourceHandler regardless of options passed at OnRequestResourceWithMojo(). This CL is to plumb the options to MojoAsyncResourceHandler to get correct information. For example, when loading a service worker's main script, SSLInfo should be attached with the response. Bug: 851831 Change-Id: I34b6bea644ef34b0b2b0dfd856b8541e3aa1368c Reviewed-on: https://chromium-review.googlesource.com/1096731Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#566422}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/0e2608e84fe5..8e4d09ae7af1 git log 0e2608e84fe5..8e4d09ae7af1 --date=short --no-merges --format='%ad %ae %s' 2018-06-12 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 d73a61117dff..a8802477752f (1 commits) Created with: gclient setdep -r src/third_party/skia@8e4d09ae7af1 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=csmartdalton@chromium.org Change-Id: I5bfcae47fb0a1e8203d09ec0596ce95a59235cb1 Reviewed-on: https://chromium-review.googlesource.com/1097095Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#566421}
-
Calder Kitagawa authored
Adds support for AnnotationsDirectoryItem references. These take a similar form to variable length reference lists; however, the header for the list is not just the size of one list but rather three sublists and also contains a reference to class annotations within the header. The CL adds a parser for these items and a few types. The ReferenceReader is reused from the CachedItemListReferenceReader. There isn't a noticeable change in generation or apply time but the memory footprint can potentially be much larger as each annotation can produce on average a few offsets and there can be thousands of instances. Bug: 847571 Change-Id: I04afe4c6e35c66c0c9157ed3ac3e5bf338931f03 Reviewed-on: https://chromium-review.googlesource.com/1095645 Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#566420}
-
Jeremy Roman authored
Detected by LSAN bots. Bug: 831667 Change-Id: I60b0188cd1ce7e9ad4666da3ee2880ea57056c1a Reviewed-on: https://chromium-review.googlesource.com/1095644Reviewed-by:
Lucas Gadani <lfg@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#566419}
-
Mathieu Perreault authored
Bug: 850078 Change-Id: Ife7bb7f4e611a32d66ffd1d3a940de53f5d3b7c8 Reviewed-on: https://chromium-review.googlesource.com/1097220Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#566418}
-
Randy Rossi authored
Instance var was not actually being set. Lost in a bad merge. Test: Manual Bug: b/73383411 Change-Id: I1932345299527ae8fe602e6525493443dbb62e2b Reviewed-on: https://chromium-review.googlesource.com/1093560Reviewed-by:
Alex Sakhartchouk <alexst@chromium.org> Commit-Queue: Randy Rossi <rmrossi@chromium.org> Cr-Commit-Position: refs/heads/master@{#566417}
-
Adithya Srinivasan authored
Bug: 781655 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr Change-Id: Ibb77d27b07e71440052b32f2aaa55925f8594d4e Reviewed-on: https://chromium-review.googlesource.com/1072747Reviewed-by:
Tommi <tommi@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#566416}
-
Dave Tapuska authored
strlen returns size_t which can be 64 bits yet all of the WTF strings use 32 storage lengths. Add a helper function string_unsigned which returns the strlen with a SafeCast to unsigned. Place it in an implementation file to avoid increase in binary size due to inlining. BUG=588506 Change-Id: I3b5025c1fee9b1eda9cd017af6bdfc66d808e802 Reviewed-on: https://chromium-review.googlesource.com/1096133Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuta Kitamura <yutak@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#566415}
-
David Bokan authored
Added tests that currently fail on ToT. Change-Id: Ibb8720bdf54cc8f37c3cb0019c8d821ba3592cf6 Reviewed-on: https://chromium-review.googlesource.com/1097155 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#566414}
-
Mikel Astiz authored
If a CCT is active at the time the browser app itself is closed, the shutdown transition from having a tabbed window (prior to the browser being closed) to not having one (when only the CCT remains) is problematic. Unless the scenario has special treatment, sync code sees how tabs disappear one by one (they become null) and proceeds as if the tabs were closed. Instead, let's be strict about when a window is considered syncable, and prevent updates as soon as at least one tab is null. Bug: 639009 Change-Id: Iec64b31addc29a8c41e39b9f7aad8cd6fdfcd601 Reviewed-on: https://chromium-review.googlesource.com/1096235 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#566413}
-
Javier Fernandez authored
The CSS WG resolved [1] that Content Alignment should account to the track sizing algorithm. The sizing algorithm has been modified so that two new steps (1.5 and 2.5) were added to compute the Content Alignment offsets after resolving the columns' and rows' sizes respectively. This change decouples the Content Alignment logic from the tracks position, so that we can use it as part of the track sizing algorithm. I also had to store the whole ContentAlignmentData structure in two class attributes. We need both, position and distribution offsets, to be used in different parts of the layout logic. Finally, since the ContentAlignmentData is now used as persistent memory, we had to remove the STACK_ALLOCATED flag; hence, I think using DISALLOW_COPY_AND_ASSIGN and let the functions update the structure's internal field is a more efficient approach to commit this change. [1] https://github.com/w3c/csswg-drafts/issues/2557 Added WPT * grid-content-distribution-must-account-for-track-sizing-001.html * grid-content-distribution-must-account-for-track-sizing-002.html Bug: 844744 Change-Id: I90019a96b148d3713467e35fde9482d0d39b1ced Reviewed-on: https://chromium-review.googlesource.com/1067918 Commit-Queue: Javier Fernandez <jfernandez@igalia.com> Reviewed-by:
Manuel Rego Casasnovas <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#566412}
-
Mounir Lamouri authored
When an out of process iframe is deleted from the DOM, the player does not notify the the browser process that it should leave the Picture-in-Picture mode. This is also fixing a TODO and updates a DCHECK. The TODO is because of a refactor and the DCHECK was failing on a test that was just added. Bug: 848044 Change-Id: I53ce77879cc08b70566449a705cdfb6723b4b013 Reviewed-on: https://chromium-review.googlesource.com/1095838Reviewed-by:
apacible <apacible@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#566411}
-
Tim Schumann authored
Mark http/tests/devtools/tracing/timeline-style/timeline-style-recalc-all-invalidator-types.js as flaky on MSAN. Move it to the right expectations file as the flakiness is gone from the other builders since crbug/850892 got fixed. Bug: 851497 Change-Id: I15fb5f7444c743e5a2ec193736c3f9efc4696c98 Reviewed-on: https://chromium-review.googlesource.com/1096762Reviewed-by:
Tim Schumann <tschumann@chromium.org> Reviewed-by:
Tatiana Gornak <melandory@chromium.org> Commit-Queue: Tim Schumann <tschumann@chromium.org> Cr-Commit-Position: refs/heads/master@{#566410}
-
Ingvar Stepanyan authored
Fix `FilterBar::_update` to pass `false` for disabled items and not `undefined` as `classList.toggle` treats them differently. Bug: 850641 Change-Id: I964c528ad6da495e2fd4078cde415e7cc250a13f Reviewed-on: https://chromium-review.googlesource.com/1091312 Commit-Queue: Ingvar Stepanyan <ingvar@cloudflare.com> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#566409}
-
Colin Blundell authored
A common use case (*the* common use case) for clients of PrimaryAccountAccessTokenFetcher is for these clients to want to destroy the fetcher when they receive the callback that the access token request completed. However, PrimaryAccountAccessTokenFetcher passes the arguments of that callback as const references, meaning that it's not safe for clients to destroy the fetcher until the callback completes. Clients currently go through a moderately complicated dance to ensure that this flow occurs safely. This CL changes that callback to take its parameters by value, making it safe for clients to simply destroy the fetcher from within the invocation of the callback. This CL also goes through the clients, simplifying any that can now be simplified. TBR=jochen@chromium.org Bug: 796544 Change-Id: Iaaf151a5025be3e455a129c6334fb1ec6170901a Reviewed-on: https://chromium-review.googlesource.com/1090710 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#566408}
-
Amy Qiu authored
When MobileRenderingSharedState is used, the blogspot_pinch test fails because pages in this page set are meant for mobile desktop sites. To prevent this, make the tough_pinch_zoom page set desktop-only and set the target_scale_factor based on platform instead of shared_page_state. Bug: 851499 Change-Id: I9001784c37612a7da689fa8af3bcf3f0121dafec Reviewed-on: https://chromium-review.googlesource.com/1096154 Commit-Queue: Amy Qiu <amyqiu@google.com> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#566407}
-
Greg Thompson authored
A final bg write wasn't being waited for, leading to flaky failures when trying to read the metadata file. Also fixed some incorrect use of ASSERT_* macros in helper functions. BUG=845811 R=proberge@chromium.org Change-Id: Ie1021ceafc03501180324195fe3a1da4dc312890 Reviewed-on: https://chromium-review.googlesource.com/1097076Reviewed-by:
proberge <proberge@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#566406}
-
Colin Blundell authored
As promised on https://chromium-review.googlesource.com/c/chromium/src/+/1092575. Change-Id: Ibd9946dda44bc9ec2a8f2594cbc1a27930f1bbb7 Reviewed-on: https://chromium-review.googlesource.com/1097084Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#566405}
-
Jeremy Roman authored
Change-Id: If63c916d8d405efb2f84794ec85dae110a20400a Reviewed-on: https://chromium-review.googlesource.com/1096339Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#566404}
-
Harald Alvestrand authored
This adds (as a drive-by) logging when unknown values are used in UMA-from-webrtc, since this indicates an incomplete change. Bug: chromium:718508 Change-Id: Ic21551e677a58f34d8e2418c17d1bf3256928cdb Reviewed-on: https://chromium-review.googlesource.com/1082476Reviewed-by:
Henrik Boström <hbos@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#566403}
-
Chris Hamilton authored
BUG=829933 Change-Id: I40610c73441837327b827480cadddd325ac27fbf Reviewed-on: https://chromium-review.googlesource.com/1096312Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#566402}
-
Jan Krcal authored
This CL performs a one-off clean-up in the typed_url_sync_metadata table in the history DB. A previous bug in the code (from M64 Stable) caused that metadata for expired URLs stayed in the table. This CL removes such orphanaged metadata. Bug: 827111 Change-Id: If200517752298b889b79fbfe2b5371c4489b4773 Reviewed-on: https://chromium-review.googlesource.com/1078227 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#566401}
-
Hans Wennborg authored
Disable IncompatibleApplicationsBrowserTest.InjectIncompatibleDLL in viz_browser_tests in official builds Bug: 850517 Change-Id: If948bf58245436ea071b63935f611c879c914307 Reviewed-on: https://chromium-review.googlesource.com/1096773Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#566400}
-
Dominic Battre authored
Bug: 846694 Change-Id: Iecf328d8a43c96dd6772b48d0f0f80760a8a51e1 Reviewed-on: https://chromium-review.googlesource.com/1093096 Commit-Queue: Dominic Battré <battre@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#566399}
-
Tiger Oakes authored
Continuation of work in bug 646094. This CL was uploaded by git cl split. R=jianli@chromium.org Bug: 846456 Change-Id: Ife19a981980ee18798721000d8d12d8730231e12 Reviewed-on: https://chromium-review.googlesource.com/1095991Reviewed-by:
Jian Li <jianli@chromium.org> Commit-Queue: Tiger Oakes <tigero@google.com> Cr-Commit-Position: refs/heads/master@{#566398}
-
Tiger Oakes authored
Removed context#getApplicationContext calls from /chrome/android/java/src/org/chromium/chrome/browser/firstrun Continuation of work in bug 646094. This CL was uploaded by git cl split. R=bsazonov@chromium.org Bug: 846456 Change-Id: Iabb1d50cbdce25c3b4c96c749d8853c48da619f2 Reviewed-on: https://chromium-review.googlesource.com/1095992Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Tiger Oakes <tigero@google.com> Cr-Commit-Position: refs/heads/master@{#566397}
-
Tiger Oakes authored
Removed context#getApplicationContext calls from /chrome/android/java/src/org/chromium/chrome/browser/media Continuation of work in bug 646094. This CL was uploaded by git cl split. R=mlamouri@chromium.org Bug: 846456 Change-Id: Ie0c0102c78325c15650ffc577b48cf77981a01ac Reviewed-on: https://chromium-review.googlesource.com/1096007Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Tiger Oakes <tigero@google.com> Cr-Commit-Position: refs/heads/master@{#566396}
-
Bernhard Bauer authored
Bug: 847420 Change-Id: I0e0441c339b53e12eb87735de2eb5ab978eecea4 Reviewed-on: https://chromium-review.googlesource.com/1095174Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Commit-Queue: Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#566395}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=amineer@chromium.org Change-Id: I9b1371d303248dd7f4cd2f201a6be7869574b897 Reviewed-on: https://chromium-review.googlesource.com/1096603Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#566394}
-
David Bokan authored
Similar to https://crrev.com/c/1079608, this CL replaces uses of the viewport scroll layers with the equivalent scroll node from the property tree. This prepares for enabling blink-generated-property-trees since we wont create the viewport scroll layers in that case, only the property tree nodes. This patch makes call sites use an accessor method which grabs the scroll node from the viewport layer. A follow up patch will change this helper to use the property tree directly if we're in BGPT mode. Some more involved uses of the viewport layers remain and will have to be fixed in future CLs but this is enough to enable basic scale-and-scroll funcionality. Note: while we did convert some uses of the outer viewport layer here, we're mainly concerned with the inner viewport. That's because the outer viewport is a scroller that generates content (like other scrollers) and will continue to create and use a layer in BGPT. The inner viewport layer is conceptual and will thus not generate a layer. This CL should have no functional changes. Bug: 836910 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ifa83fed2fa9b1847729ffafe75846da08e204237 Reviewed-on: https://chromium-review.googlesource.com/1085639 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
Tien-Ren Chen <trchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#566393}
-
Colin Blundell authored
IdentityTestEnvironment (and identity_test_utils.h) have an API for setting a refresh token for a given account. However, this API has a hidden gotcha: IdentityManager assumes that when a refresh token is updated, AccountTrackerService knows about the account. This assumption is valid in production, but IdentityTestEnvironment doesn't make any attempt to ensure it in this testing context. The only reason that this gotcha hasn't yet been tripped is because all uses of this API are currently for the primary account, which AccountTrackerService *does* already know about. This CL sharpens this API to be just about setting a refresh token for the primary account, with the constraint that the primary account must itself already be set. A followup CL will add an API for adding an account, as this will shortly be needed for porting PrimaryAccountAccessTokenFetcher unittests. Bug: 798699 Change-Id: Id734e582eb9841b3150b380486556b046212269c Reviewed-on: https://chromium-review.googlesource.com/1095108Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#566392}
-
David 'Digit' Turner authored
This prepares for a future CL that will ensure the set of PAK files extracted by this class match the UI language used by the Android framework to display localized strings. BUG=846633 R=agrieve@chromium.org, astevenson@chromium.org Change-Id: I316dc53b23f3fc9139af845c1f9fad7e5b4138a6 Reviewed-on: https://chromium-review.googlesource.com/1091310Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: David Turner <digit@chromium.org> Cr-Commit-Position: refs/heads/master@{#566391}
-
Maxim Kolosovskiy authored
username A generated password and a captured username should be presaved once a user accepts a password generated by Chrome. If there is an entry with the captured usernmae in the store, then Chrome presaves only password (the username is empty). Before this CL, Chrome always presaved only password. This CL also ensures that a presaved entry is updated when the username value has been changed by user. Bug: 809019 Change-Id: I1f36f23d8ba12f09617b89791ce10a467f8dfa23 Reviewed-on: https://chromium-review.googlesource.com/1092745 Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#566390}
-
Mark Pilgrim authored
Bug: 714018 Change-Id: I024f77e3642a225302f748595430cb478de75fe9 Reviewed-on: https://chromium-review.googlesource.com/1093052Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Mark Pilgrim <pilgrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#566389}
-
Vaclav Brozek authored
This CL extends the browser-side FormData parser in password manager to use server predictions to determine roles of input fields. This support is incomplete and does not handle well partial predictions yet, e.g., if only the USERNAME is predicted. It also does not handle the "NOT_PASSWORD" prediction. Those will get addressed in separate CLs. Bug: 845426 Change-Id: If8e444fb865c2c8358b122fed875386a9aa05ec8 Reviewed-on: https://chromium-review.googlesource.com/1087066 Commit-Queue: Vaclav Brozek <vabr@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#566388}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/8c6b49718210..0e2608e84fe5 git log 8c6b49718210..0e2608e84fe5 --date=short --no-merges --format='%ad %ae %s' 2018-06-12 skia-bookmaker@skia-swarming-bots.iam.gserviceaccount.com Update markdown files Created with: gclient setdep -r src/third_party/skia@0e2608e84fe5 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=csmartdalton@chromium.org Change-Id: I9718923a5d3260226083d1d33cdbd995462ef35f Reviewed-on: https://chromium-review.googlesource.com/1096705Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#566387}
-
Oriol Brufau authored
These properties provide the author with the ability to control paddings through logical, rather than physical, direction and dimension mappings. Intent to Implement and Ship: CSS flow-relative margins, paddings and borders https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/tkN-r119eNc Spec: https://drafts.csswg.org/css-logical/#padding-properties BUG=850000 TEST=external/wpt/css/css-logical/logical-box-padding.html The test still has some failures because sideways writing modes have not been implemented yet (http://crbug.com/680331). Change-Id: Ic76da56385f2ef8c9638f90c9a358e4874d7c338 Reviewed-on: https://chromium-review.googlesource.com/1091313Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Yoav Weiss <yoav@yoav.ws> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Manuel Rego Casasnovas <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#566386}
-