- 24 Sep, 2018 40 commits
-
-
Michael Lippautz authored
Replace direct GC calls that expect objects to die with asyncGC calls that are guaranteed to run without stack. Bug: chromium:843903 Change-Id: Ie708567fae153d0f1a20109fe170025afdc1715b Reviewed-on: https://chromium-review.googlesource.com/1238451Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#593551}
-
Michael Lippautz authored
Update asyncGC function to the latest version to guarantee that GCs are indeed run without stack. Bug: chromium:843903 Change-Id: Iaa61f27cacd99854665358720d2354522b756302 Reviewed-on: https://chromium-review.googlesource.com/1238623Reviewed-by:
-
Dominic Battre authored
In the past 2 weeks I had one case where I, as a sheriff, tried to disable a test with a "DISABLE_" prefix (should be "DISABLED_") and one case, where I was TBRs on someone elses' typo. This presubmit script warns the committer in these cases (C++ only for now). Bug: 888425 Change-Id: Iff555a90db674ecd4df77819f1fa82270fbd715d Reviewed-on: https://chromium-review.googlesource.com/1240279 Commit-Queue: Dominic Battré <battre@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#593549}
-
Mohamed Amir Yosef authored
uss_migrator is responsible for migration (meta)data from the directory to the USS architecture upon first time switching to USS. USS assumes that all bookmarks have valid unique_position. This CL adds a DCHECK that this is actually the case. Directory is responsible for assigning valid unique positions for legacy bookmarks that are missing the field. Bug: 516866 Change-Id: Ib963016a56c4c9275649a1ff78f440d7fbe23023 Reviewed-on: https://chromium-review.googlesource.com/1240296 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#593548}
-
Jan Krcal authored
Bug: 853688 Change-Id: Idfd02f83693ad4861015d9edd3a9b23c7c6e174c Reviewed-on: https://chromium-review.googlesource.com/1238175Reviewed-by:
Robert Kaplow (sloooow) <rkaplow@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#593547}
-
Colin Blundell authored
OAuth2TokenService.java has methods that trigger the firing of various refresh token-related notifications by ProfileOAuth2TokenService [the C++ class]. These methods are not used (thanks to bsazonov@ for detecting that!), and their tests are problematic, as they cause the notifications to be fired without the accounts actually being available in PO2TS; this fact violates an invariant that we would like to put in place wherein PO2TS only fires refresh token available notifications for accounts for which it has a refresh token. This CL simply eliminates these unused methods and their tests. TBR=msarda@chromium.org Bug: 883722 Change-Id: Ib44be7db2fbe5341588a9e7ff786f5d166d1ae6c Reviewed-on: https://chromium-review.googlesource.com/1240275 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#593546}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/0a3864651457..de54d7c5e325 git log 0a3864651457..de54d7c5e325 --date=short --no-merges --format='%ad %ae %s' 2018-09-24 kjlubick@google.com Update autodetects for newer fuzzers Created with: gclient setdep -r src/third_party/skia@de54d7c5e325 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=bsalomon@chromium.org Change-Id: I13a4eca0762d075f7f3dab5b8e4fa2958889e39a Reviewed-on: https://chromium-review.googlesource.com/1239489Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#593545}
-
Yao Xiao authored
1. Currently there is a bug: when subframe navigation is blocked, the console message is like: |<URL> on this site ...|; while the expected message should be |Chrome blocked resource <URL> on this site ...|. The reason is that in the code the prefix is put in the constructor of ostringstream but that call doesn't advance the write pointer. There was a test for it but the test also did it in the wrong way. 2. Fixed another potential issue: Test SubresourceFilterBrowserTest.SubFrameActivation is referring to kDisallowSubframeConsoleMessagePrefix/Suffix but the generated string actually comes from GetErrorStringForDisallowedLoad() in blink/renderer/core/loader/subresource_filter.cc. Right now the two strings are the same thus the test is passing now, but this should be fixed. Bug: N/A Change-Id: I28548d809ecaae019321bf97551d2493f2af7703 Reviewed-on: https://chromium-review.googlesource.com/1237173Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Yao Xiao <yaoxia@chromium.org> Cr-Commit-Position: refs/heads/master@{#593544}
-
Nico Weber authored
Bug: 832676 Change-Id: I38359d01373d4bd237c6a0f7fe5ffc051a3318c5 Reviewed-on: https://chromium-review.googlesource.com/1240164Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#593543}
-
Finnur Thorarinsson authored
When they were disabled for flakiness, an open bug was linked. This bug has long since been fixed, so I have reason to believe that they will run. And if not, this will give me data to sort through to figure out why they were flaky. Change-Id: Ib5735788d3d4d32772017d3c3161c9ecc5793c75 Reviewed-on: https://chromium-review.googlesource.com/1238558Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#593542}
-
Armando Miraglia authored
Considering that audio paramters are passed but not used by the AudioCaptureSettings, it is better remove them for now. Later, we will change the implementation so that AudioCaptureSettings directly stores the parameters that are not related to audio processing. BUG=731170 TESTED=ran content_unittests & ran the browser + called getUserMedia. Change-Id: I530d1dbe50e9d2438df189d28c9f4ade42dd271d Reviewed-on: https://chromium-review.googlesource.com/1238723Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Armando Miraglia <armax@chromium.org> Cr-Commit-Position: refs/heads/master@{#593541}
-
Philip Rogers authored
This reverts commit 45013dfc. Reason for revert: Performance regressions on touch_handler_scrolling.html This patch turned up a few performance regressions, primarily: tough_scheduling_cases/touch_handler_scrolling.html (see: https://crbug.com/888269). Other performance regressions: https://chromeperf.appspot.com/group_report?rev=593255 Original change's description: > Promote PaintTouchActionRects to stable > > This change enables PaintTouchActionRects by default. This is a > new implementation of how the blink->cc logic works for the css > touch-action feature. The big idea behind PaintTouchActionRects is to > compute touch-action rects during paint, in paint order, as part of the > background paint phase. > > With this change we expect better performance (primarily a drop in > ScrollingCoordinator time: Blink.ScrollingCoordinator.UpdateTime) as > well as observable bug fixes (e.g., https://crbug.com/826746). > > Bug: 836905, 881894 > Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I47a26250bad4c9e208b4f9b11e8eea3cf4d182aa > Reviewed-on: https://chromium-review.googlesource.com/1233114 > Reviewed-by: Philip Rogers <pdr@chromium.org> > Commit-Queue: Xida Chen <xidachen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#593255} TBR=pdr@chromium.org,xidachen@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 836905, 881894 Change-Id: I775e60074f4d5bca5a907a1da104f5441212769a Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1240184 Commit-Queue: Philip Rogers <pdr@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#593540}
-
Nico Weber authored
Removes ContentSettingDecoration, KeywordHintDecoration, SaveCreditCardDecoration, StarDecoration, TranslateDecoration. Also removes c/b/ui/cocoa/translate/. Bug: 832676 Change-Id: I82f5873091502c847e77efb2671d8cc5583f8ba4 Reviewed-on: https://chromium-review.googlesource.com/1240161Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#593539}
-
Peter E Conn authored
I'm adding myself as OWNER of the recently created dependency_injection folder and to the top level OWNERS files for all Java tests. Change-Id: I40d83db663d4d33bc19d9d9aae557c8eb7be0259 Reviewed-on: https://chromium-review.googlesource.com/1238455Reviewed-by:
-
Joanmarie Diggs authored
The whitespace characters surrounding the text to be displayed for a label element should not be treated as part of the accessible name of the element being labeled. Stripping out this whitespace makes us consistent with what other user agents do. Bug: 887624 Change-Id: I1ff691ee7d970435b2b912a2d2b565089b1fc7a3 Reviewed-on: https://chromium-review.googlesource.com/1238774Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#593537}
-
David Bokan authored
This reverts commit 432553b5. Reason for revert: width == height isn't enough since the system bar affects only height. Broke 887064, 887330, 887899 Original change's description: > Improve rotation check on viewport resize > > Since rotation used to be supported only on Android, where windows can't > be resized, we made the assumption that if the width changes it must be > a rotation. > > This changes in ChromeOS where entering tablet mode enables rotation but > also resizes the window (when entering tablet mode). This caused > inappropriate rotation anchoring. > > The underlying issue has been fixed in other patches linked to this bug, > the rotation trigger should be improved to check that the width and > height are swapped. > > Bug: 831473 > Change-Id: I0acd39d16319d8cb7819faac4c4ce54b6f7a2e46 > Reviewed-on: https://chromium-review.googlesource.com/1224711 > Reviewed-by: Dave Tapuska <dtapuska@chromium.org> > Commit-Queue: David Bokan <bokan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#591430} TBR=bokan@chromium.org,dtapuska@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 831473,887899,887064,887330 Change-Id: Ib0f3cad366a80506effc62fcc352e1c75f2fcd55 Reviewed-on: https://chromium-review.googlesource.com/1239726 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#593536}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/26fc9ad8..2c8e12da Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I01511d4d2439dcb48968cd0808e1d4bf6bb39e08 Reviewed-on: https://chromium-review.googlesource.com/1240183Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#593535}
-
Pavol Marko authored
Make CertLoader explicitly aware of authority certificates provided by device and user policy. Rationale: Since the refactoring in https://crbug.com/787602, policy-provided certificates are not imported into the user's NSS Database anymore. As a bonus, this also makes device policy proivded CA certificates available to CertLoader (and thus the chromeos network UI). To do this in a clean way, (*) The PolicyCertificateProvider interface has been moved from chrome/browser/chromeos/policy/ to chromeos/ so it is accessible from chromeos/cert_loader.{h,cc}. (*) Implementation of the PolicyCertificateProvider has been pushed from UserNetworkConfigurationUpdater into the base class NetworkConfigurationUpdater, so DeviceNetworkConfigurationUpdater also implements the interface now. (*) CertLoader can now accept a PolicyCertificateProvider for device and user policy. (*) The chromeos-specific code in chrome/browser/chromeos now passes the global DeviceNetworkConfigurationUpdater and the primary profile's UserNetworkConfigurationUpdater to CertLoader. browser_test --gtest_filter=PolicyProvidedTrustAnchorsRegularUserTest.AuthorityAvailableThroughCertLoader Bug: 882641, 787602 Test: chromeos_unittests --gtest_filter=*CertLoader* && Change-Id: Iafb213150f3c9dbfdfe1ecd1a1f9d2a0099a30f2 Reviewed-on: https://chromium-review.googlesource.com/1231937 Commit-Queue: Pavol Marko <pmarko@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#593534}
-
Aaron Leventhal authored
Also add tests for caret events. Bug: 877487 Change-Id: Ib9ac49e60c218169e8108ef83b000fcaaf176570 Reviewed-on: https://chromium-review.googlesource.com/1189184 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#593533}
-
Peng Huang authored
Bug: 811661 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I4bdcc4edf654c8c46c5015a1b4e6bc42ca79c381 Reviewed-on: https://chromium-review.googlesource.com/1239220Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#593532}
-
Daniel Vogelheim authored
The functionality is behind a flag. The interstitial content is preliminary and will be replaced in a subsequent CL with something more suitable for the public. Bug: 751996 Change-Id: I0a7cf6fec4a9ceaea10adac6ed2fcd1c7ccac799 Reviewed-on: https://chromium-review.googlesource.com/1204170Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> Cr-Commit-Position: refs/heads/master@{#593531}
-
Dan Elphick authored
Replace use of deprecated Value::ToString(Isolate*) with Value::ToString(Local<Context>) in third_party/blink/renderer/bindings/core/v8. Bug: v8:7279, v8:8015 Change-Id: Ia5959d15bd649f00ba5cc45829acabc3bea53e20 Reviewed-on: https://chromium-review.googlesource.com/1238449Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#593530}
-
Mikel Astiz authored
The initial value of ModelTypeController::delegate_ is never read because the delegate is only used once the controller starts running. However, let's make sure it's initially null to detect CHECK failures if there is a violation of the API. Bug: 885019 Change-Id: I4a5623986b2bbd6c96a02f218438367d8e78a7fc Reviewed-on: https://chromium-review.googlesource.com/1238729 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#593529}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/868fbbf41b33..f19e5d119588 git log 868fbbf41b33..f19e5d119588 --date=short --no-merges --format='%ad %ae %s' 2018-09-24 perezju@chromium.org [pinpoint_cli] Add api.Job() method 2018-09-24 perezju@chromium.org [pinpoint_cli] Add verbose -v command line option Created with: gclient setdep -r src/third_party/catapult@f19e5d119588 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:879526,chromium:879526 TBR=sullivan@chromium.org Change-Id: Ieb1ed481849dba4ce999ba89dadb4d1bbc095367 Reviewed-on: https://chromium-review.googlesource.com/1239488Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c955a1645148..0a3864651457 git log c955a1645148..0a3864651457 --date=short --no-merges --format='%ad %ae %s' 2018-09-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 77db6f4af19f..f668a4b5fb72 (1 commits) Created with: gclient setdep -r src/third_party/skia@0a3864651457 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=bsalomon@chromium.org Change-Id: I4e7c03255c13ad97eb099c5c91d176effa9702f1 Reviewed-on: https://chromium-review.googlesource.com/1239487Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f4a7342c6fc4..e2ea26c8b521 git log f4a7342c6fc4..e2ea26c8b521 --date=short --no-merges --format='%ad %ae %s' 2018-09-24 primiano@google.com Merge "Chrome trace events: bind_id can be 64bit" Created with: gclient setdep -r src/third_party/perfetto@e2ea26c8b521 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I66e8651496ba1c466ffdad6e988441dd90f2d80c Reviewed-on: https://chromium-review.googlesource.com/1239485Reviewed-by:
-
John Budorick authored
TBR=justincohen@chromium.org No-Try: true Bug: 888400 Change-Id: I7a6095dda1c10009b5649338439b09b0c9433d5f Reviewed-on: https://chromium-review.googlesource.com/1240177 Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#593525}
-
Justin Cohen authored
Bug: 888107 TBR: sczs@chromium.org Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I6a75a2d96039d3cc3ef177799d02a32f6ea87851 Reviewed-on: https://chromium-review.googlesource.com/1240162 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#593524}
-
Rune Lillesveen authored
The background-clip property affects background-color visually, so we need to say a layer is visually different even without an image. We had a wpt test for this which had a stray line which made the test always pass. Bug: 887350 Change-Id: Icc585f9e631485970b6509e015eff1e2007e4f0b Reviewed-on: https://chromium-review.googlesource.com/1238448Reviewed-by:
Anders Ruud <andruud@chromium.org> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#593523}
-
Daniel Bratell authored
Bug: 826218 Change-Id: I176e1aeb0b24b21c6b4e5ee40910dce2bce52c95 Reviewed-on: https://chromium-review.googlesource.com/1239461Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#593522}
-
Ned Nguyen authored
This is flaky on 'Win 7 Nvidia GPU Perf' Bug:876636 Change-Id: Ide6e0ceff3b7963f86b7160345a3239542d476c1 TBR=kouhei@chromium.org, ksakamoto@chromium.org No-Try: true Change-Id: Ide6e0ceff3b7963f86b7160345a3239542d476c1 Reviewed-on: https://chromium-review.googlesource.com/1240316Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#593521}
-
Javier Ernesto Flores Robles authored
This replaces the old URLRequestContextGetter, and is 1/2 CLs to fix the internal repo. Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Ia69ee02311aa9923156f9f56961fd3c315fb0967 Reviewed-on: https://chromium-review.googlesource.com/1240122Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Eric Noyau <noyau@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#593520}
-
Mikel Astiz authored
This helps datatypes that are interested in the syncing account ID, without having to wait until sync engine starting (which is usually deferred for about 10 seconds). This field is convenient for user consents, although leveraging this data is not included in this patch. A dedicated method is introduced in ModelTypeChangeProcessor although it is somewhat redundant with IsTrackingMetadata(). The rationale is most datatypes don't care so it seems overkill to update all tests with extra boilerplate. Bug: 830535 Change-Id: I623b87c693894b5c0845fc3d03772b2701292a00 Reviewed-on: https://chromium-review.googlesource.com/1138236 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#593519}
-
Thomas Tangl authored
This is a follow up to https://chromium-review.googlesource.com/1238499. The update of the sync settings during migration can happen at the same time as updating the sync settings because of a sync state change. To resolve inconsistencies in the configuration updates, the update method UpdateSyncSettingsIfPossible now takes different parameters. Bug: 886912, 887706 Change-Id: I27555172164b99332cdce101f79564e58cc05eff Reviewed-on: https://chromium-review.googlesource.com/1238572 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
-
Vaclav Brozek authored
The histograms PasswordManager.Android.PasswordCredentialEntry.Password and PasswordManager.Android.PasswordCredentialEntry.Username do have defined corresponding enums, but the histograms.xml file has a copy-paste mistake linking those to a wrong enum. This leads in wrong labels in the UMA dashboard. This CL corrects the association to the enum. It also replaces melandory@ with vabr@ as the owner of histograms for this area, because melandory@ changed teams last year. Bug: 885245 Change-Id: I0e53feb7c17ebbd63d9537bafa05fbd26138e728 Reviewed-on: https://chromium-review.googlesource.com/1236001Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#593517}
-
Koji Ishii authored
Following bot results are included. 9879 9883 9888 9891 9892 9895 9904 9910 9914 9919 9924 9927 9935 9938 9949 9956 9960 9961 9962 9963 9965 9966 9967 9968 9969 9970 9973 9974 0 lines were removed and 3 lines were deflaked by consecutive results since 9960. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Icc3b2264bc3de4cad3233357e76849fe8b4e14be Reviewed-on: https://chromium-review.googlesource.com/1235361 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#593516}
-
Thomas Tangl authored
The revoke reason kUserSignedOut should only be recorded when the user opted into unified consent before. This CL fixes this. Bug: 868892 Change-Id: I746ca040a554ec78599f16871e831acc11c7afcf Reviewed-on: https://chromium-review.googlesource.com/1238583Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#593515}
-
Nico Weber authored
Bug: 832676 Change-Id: I7b1fbbbc4cf83d470b81874e12fbda2b7a6a9194 Reviewed-on: https://chromium-review.googlesource.com/1240157Reviewed-by:
-
François Beaufort authored
This CL makes sure we never show play/pause and scrim controls when there is no video in Picture-in-Picture window. Bug: 879529 Change-Id: I8d9ee5dcde24e9dc1b3e89af091c3385d338b046 Reviewed-on: https://chromium-review.googlesource.com/1235580 Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Reviewed-by:
apacible <apacible@chromium.org> Cr-Commit-Position: refs/heads/master@{#593513}
-
David Roger authored
The DCHECK was comparing emails by doing a simple string comparison. This is incorrect, because emails have to be normalized first. In particular emails are case insensitive. Bug: 882362 Change-Id: I1b0009bb1f6b77114638db250252d79126f2267d Reviewed-on: https://chromium-review.googlesource.com/1240295Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#593512}
-
