Skip to content

GitLab

T
tangled
Switch branch/tag
  1. 14 Aug, 2018 36 commits
  3. 13 Aug, 2018 4 commits
    • Esmael El-Moslimany's avatar
      Settings: cr-expand-button, use pointer cursor for label · 7d6f04d4
      Esmael El-Moslimany authored 
      The label when clicked toggles expansion. The bug as reported was
selecting the label text causes expansion. Without the pointer cursor
it's surprising to the user that an action will be taken while clicking
on the label text during selection. The problem is the surprising
expansion and not the expansion on clicking the text.

Bug: 870205
Change-Id: I5c5200f54a54bba50cb6fc67c668b8d298b98c94
Reviewed-on: https://chromium-review.googlesource.com/1166216Reviewed-by: default avatarScott Chen <scottchen@chromium.org>
Reviewed-by: default avatarHector Carmona <hcarmona@chromium.org>
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582755}
      7d6f04d4
    • Toni Barzic's avatar
      Update offline demo mode resources location · 0f2805cb
      Toni Barzic authored 
      Updates the location from which offline policy blobs are loaded to match
the new location (set by demo_mode_resources package, rather than
chromeos-assets)

BUG=None

Change-Id: If63e35898c9329d287364ba9f959007824e2db26
Reviewed-on: https://chromium-review.googlesource.com/1173490Reviewed-by: default avatarAga Wronska <agawronska@chromium.org>
Commit-Queue: Toni Baržić <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582754}
      0f2805cb
    • Christian Fremerey's avatar
      Reland #2 [Media Recorder] Fix video freeze on short recording. · 0013a455
      Christian Fremerey authored 
      Reason for the revert was duplicate initialization that happened because a
different fix for the initialization issue had already landed in the master
branch.

Original CL description:

Fixes an issue where VideoTrackRecorder when used in combination with
VEAEncoder and very short recording durations (just 1 frame) would
occasionally hold on to video frames forever, causing frame buffers
from the buffer pool to become permanently blocked, eventually leading
to video capture freezing.

The cause was a circular ownership that would happen if only 1 frame
is recorded.

This CL additionally fixes a crash that could happen on initialization
of VEAEncoder. This issue was revealed during testing of the above fix.
Since it is not 100% if this crash was masked by the other issue, and
would only start occurring with the above fix, I am making a fix for that
part of this CL as well.

The cause for the crash issue was that class VEAEncoder, which uses
RefCountedThreadSafe<>, would post an asynchronous task from its
constructor. If this task would finish executing before the newly
constructed instance was assigned to a scoped_refptr<> by however
called the constructor, the instance would destroy itself, because
of the AddRef() and subsequent Release() done by the posting and
running of the asynchronous task.

The fix for this is to use a new method Initialize() instead of
posting a task from the constructor.

TBR=emircan@chromium.org

Bug: 859610
Change-Id: I77d6865be574bf86afca7d0908ce2339f6ecd91e
Reviewed-on: https://chromium-review.googlesource.com/1173408Reviewed-by: default avatarEmircan Uysaler <emircan@chromium.org>
Reviewed-by: default avatarChristian Fremerey <chfremer@chromium.org>
Commit-Queue: Christian Fremerey <chfremer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582753}
      0013a455
    • gogerald's avatar
      Set virtual/user-activation-v2/fast/events/autoscroll-iframe-no-scrolling.html timeout pass · dfa4c566
      gogerald authored 
      TBR: hayato@chromium.org
Bug: 873829
Change-Id: I321d85a63971b1f9b01bb42d4b5d93db44125c92
Reviewed-on: https://chromium-review.googlesource.com/1173437
Commit-Queue: Ganggui Tang <gogerald@chromium.org>
Reviewed-by: default avatarGanggui Tang <gogerald@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582752}
      dfa4c566