GitLab

This is a general cleanup of some minor issues, mostly style and
comments, for SSLHostStateDelegate and related classes and methods. This
was done originally as a C++ readability review request, originally
based on https://codereview.chromium.org/369703002/.

Review URL: https://codereview.chromium.org/441043005

Cr-Commit-Position: refs/heads/master@{#293443}

It's unnecessary because nothing appears to depend on it,
and it blocks use of C++11 in base.

The IRT build is still enabled because the IRT is the primary user of base_nacl.
The pnacl_newlib build is still enabled because the remoting client uses it.

BUG=360096
R=thakis@chromium.org,mseaborn@chromium.org

Review URL: https://codereview.chromium.org/540093002

Cr-Commit-Position: refs/heads/master@{#293442}

This changes the index parameters in start() and end() to size_t so that
they match what size() returns. This fixes some compiler warnings that
become errors on some of the Windows bots.

BUG=408338

Review URL: https://codereview.chromium.org/539203002

Cr-Commit-Position: refs/heads/master@{#293441}

TBR=scottmg@chromium.org

Review URL: https://codereview.chromium.org/542973002

Cr-Commit-Position: refs/heads/master@{#293440}

We only allow one MessageLoop instance alive at any given time on a thread. If
we use IPCTestBase::set_message_loop(), we need to do it in two steps: first set
the message loop to NULL, and then set it to a newly-created message loop.

Therefore, I changed the interface of IPCTestBase to make it a little
more friendly.

BUG=None

TEST=ipc_perftests should not crash in debug build.

Review URL: https://codereview.chromium.org/538593002

Cr-Commit-Position: refs/heads/master@{#293439}

BUG=393908
TEST=None

Review URL: https://codereview.chromium.org/531523002

Cr-Commit-Position: refs/heads/master@{#293438}

Enable the InputEventStreamValidator by default on Android. Also add
some basic unit tests, and clean up several corner cases that previously
went unnoticed.

BUG=345372

Review URL: https://codereview.chromium.org/537733003

Cr-Commit-Position: refs/heads/master@{#293437}

The code lives in src/extensions but it was running in Chrome's unit_tests.
* Switch to ExtensionsTest
* Remove unnecessary UI loop run-until-idle

Also fix uninitialized member in TestExtensionsBrowserClient.

BUG=397164
TEST=extensions_unittests Bluetooth*

Review URL: https://codereview.chromium.org/544753003

Cr-Commit-Position: refs/heads/master@{#293436}

In OOBE screen, shelf is not yet ready fully so that work_area_
isn't set well. It needs to be initialized here.

BUG=401743
R=stevenjb@chromium.org
TEST=manually

Review URL: https://codereview.chromium.org/544883002

Cr-Commit-Position: refs/heads/master@{#293435}

The CLs here
https://codereview.chromium.org/489793003
and here
https://codereview.chromium.org/395913006

In isolation look correct but taken together cause a overflow or underflow
bug. Basically the message loop was calling Time::ActivateHighResolutionTimer(false)
all the time (or very often) so the g_high_res_timer_count was underflowing
or overflowing.

Now messageloop only calls ActivateHighResolutionTimer in a balanced way.

This can make the base_unittests fail as well with
--gtest_filter=MessageLoopTest.HighResolutionTimer

BUG=153139
TEST=included, see bug for manual testing.

Review URL: https://codereview.chromium.org/541203002

Cr-Commit-Position: refs/heads/master@{#293434}

Currently, the code clamps alpha up to to 100% within the window shape and
down to 0% outside the shape. This means that windows with shape *and*
transparency enabled effectively lose their transparency.

This change makes it so that the alpha is clamped up to 0% within the window
shape, which preserves the window's transparency.

BUG=405751

Review URL: https://codereview.chromium.org/499503002

Cr-Commit-Position: refs/heads/master@{#293433}

BUG=411083

Review URL: https://codereview.chromium.org/546573003

Cr-Commit-Position: refs/heads/master@{#293432}

This fixes two related issues:
* Scrolling was broken in apps v2, due to window-body div not being
  full-height.
* Scrolling was broken post-disconnect, due to the addition of an explicit
  scroller node, separate from the body.
* The dialog screen was off by 1px, due to the addition of the window-body
  div.

Since this has broken a few times now, I plan to add a browser to test to verify
the behaviour, but I don't want to hold up this CL for that.

BUG=251443

Review URL: https://codereview.chromium.org/539403002

Cr-Commit-Position: refs/heads/master@{#293431}

- Treat *.msi files (typical extension for installer) as PC exe.
- Link to webstore top page. Finding apps associated to .exe or .msi
  doesn't make much sense.

TEST=Double click a file named setup.msi in Files.app.
BUG=none
R=hirono@chromium.org

Review URL: https://codereview.chromium.org/541593003

Cr-Commit-Position: refs/heads/master@{#293430}

This is required for WebGL conformance tests and cannot be passed
on the cmdline the way WebView overrides this from AwSettings.

Review URL: https://codereview.chromium.org/546643002

Cr-Commit-Position: refs/heads/master@{#293429}

R=piman@chromium.org

Review URL: https://codereview.chromium.org/538273002

Cr-Commit-Position: refs/heads/master@{#293428}

See changes:
https://codereview.chromium.org/539193002
(nee https://codereview.chromium.org/442023002)
https://codereview.chromium.org/539173003/

R=tomfinegan@chromium.org

BUG=400684

Review URL: https://codereview.chromium.org/541003002

Cr-Commit-Position: refs/heads/master@{#293427}

In preparation for the upcoming integration with service workers, which
need to do a lot of asynchronous work before the renderers are frozen,
have the RendererFreezer grab a suspend readiness callback that it will
run at some point in the future when it is ready to suspend.

BUG=364339,411046
Signed-off-by: Chirantan Ekbote <chirantan@chromium.org>

Review URL: https://codereview.chromium.org/536753004

Cr-Commit-Position: refs/heads/master@{#293426}

BUG=410560
TEST=about:gpu page on Linux
R=piman@chromium.org,kbr@chromium.org

Review URL: https://codereview.chromium.org/541133002

Cr-Commit-Position: refs/heads/master@{#293425}

This needs:
 - Changing AthenaWindowTreeClient to return parent of a transient
   parent as its transient child's default parent;
 - Relaxing the assumption that home card container can only contain the
   home card. It can also contain touch selection handles and quick
   menu;
 - Moving touch selection handles when a textfield view is moved around.
   Currently, handles are moved only when the window is moved.

BUG=401109

Review URL: https://codereview.chromium.org/533403002

Cr-Commit-Position: refs/heads/master@{#293424}

r1973: Changes the ninja generator to output phony targets for
uninteresting targets

BUG=410410
TEST=none
R=thakis@chromium.org

Review URL: https://codereview.chromium.org/546633002

Cr-Commit-Position: refs/heads/master@{#293423}

The spec doesn't restrict the namespace of cache names, and the
implementation uses hashes to generate filenames from cache names,
so just delete the code.

BUG=408359
R=gavinp@chromium.org,jkarlin@chromium.org,michaeln@chromium.org

Review URL: https://codereview.chromium.org/539673003

Cr-Commit-Position: refs/heads/master@{#293422}

Currently reload/stop button is not present in chrome shell. If user
has to do reload operation then only option to do that is select
the url bar and click go button. Similarly stop button is not present.
To stop loading of page only option is to press back button.
Added code to support stop/reload option.

BUG=

Review URL: https://codereview.chromium.org/541713002

Cr-Commit-Position: refs/heads/master@{#293421}

This reverts commit 45db74f8.

We have the crash logs we need from the canary.

BUG=407376
TBR=creis@chromium.org,rsesek@chromium.org

Review URL: https://codereview.chromium.org/542603003

Cr-Commit-Position: refs/heads/master@{#293420}

reports bypasses for requests that don't pass the data reduction
proxy bypass rules or didn't go through the proxy because of
managed PAC.

Now DataReducitonProxy.BypassedBytes.ManagedPac reports whenever
there is a managed config regardless of whether the data reduction
proxy was used.

LocalBypassRules reports for proxies when the data reduction proxy
was the effective configuration and the request does not pass
the data reduction proxy rules.

Also changed {Short|Medium}TriggeringRequest, {Short|Medium}All,
and ShortAudioVideo so that they are all mutually exclusive.

BUG=401305

Review URL: https://codereview.chromium.org/510353004

Cr-Commit-Position: refs/heads/master@{#293419}

BUG=none

Review URL: https://codereview.chromium.org/541493002

Cr-Commit-Position: refs/heads/master@{#293418}

This only applies to Chrome OS mode on Windows 7. In the corresponding handler on the browser side
we request the compositor to schedule a paint for the whole window.

BUG=409765
TBR=jschuh

Review URL: https://codereview.chromium.org/546503002

Cr-Commit-Position: refs/heads/master@{#293417}

This way --disable-gpu-compositing will force the browser and renderer to use software compositing, but allow webgl to use the GPU process. This is the same mode as SwiftShader uses.

BUG=410515

Review URL: https://codereview.chromium.org/546593002

Cr-Commit-Position: refs/heads/master@{#293416}

FrameLoadWaiter relies on DidFinishLoad, which correctly takes into account sub-frame loads as well, so this should fix the test flakiness.

BUG=391894

Review URL: https://codereview.chromium.org/537023002

Cr-Commit-Position: refs/heads/master@{#293415}

It works as desired. An abstract class to handle overview representations of unloaded WebContents has still to be added, but since the CL is already quite big as is, I split this up into a follow up CL.

BUG=408826, 408834
TEST=AppActivityTest.*, ResourceManager.* and visual

Review URL: https://codereview.chromium.org/536013002

Cr-Commit-Position: refs/heads/master@{#293414}

The upcoming OS X / iOS H.264 hardware encoder for media/cast uses CoreMedia, VideoToolbox and CoreVideo APIs that are not available in Chromium's minimum systems (10.6, 6.0). As a preparation for additional glue code to support the encoder, media glue code should be relocated to a more neutral location now that it will serve multiple "clients".

BUG=409194
R=tommi, sky, rsesek, mcasas, DaleCurtis, perkj

Review URL: https://codereview.chromium.org/518313003

Cr-Commit-Position: refs/heads/master@{#293413}

Instead of providing a 'Translated' value in managed ONC dictionaries,
use a well understood naming convention.

This also moves the onc helper methods to their own JS module.

BUG=279351
For proxy_settings.html:
TBR=xiyuan@chromium.org

Review URL: https://codereview.chromium.org/539573002

Cr-Commit-Position: refs/heads/master@{#293412}

BUG=

Review URL: https://codereview.chromium.org/543803004

Cr-Commit-Position: refs/heads/master@{#293411}

If an EventProcessor starts to process a ui::Event while
it is already being processed by another EventProcessor,
then the properties of the event (e.g., target, phase)
should not be mutated by the inner processor before
control is returned to the outer processor. The exception
being whether or not the event has been handled.

To guarantee this, the inner processor should dispatch
a copy of the event rather than the original event
itself. This CL also introduces the static
ui::Event::Clone() method, which is used to create a
copy of a ui::Event.

BUG=404232
TEST=EventProcessorTest.NestedEventProcessing,
     updated WindowManagerTest.Focus

Review URL: https://codereview.chromium.org/519113002

Cr-Commit-Position: refs/heads/master@{#293410}

Move files:
-Move chrome/browser/extensions/api/app_window/* to extensions/browser.
-Move app_window.idl, app_window_custom_bindings.{cc,h}, app_window_custom_bindings.js to extensions.
-Move window_controls.js and window_controls_template.html to extensions.

Move switches and code:
- Move kEnableAppWindowControls switch to extensions/common/switches.h.
- Move dummy WebContentsModalDialogManager::CreateNativeWebModalManager implementation from athena's web_contents_view_delegate_factory_impl.cc to a new file shell_web_contents_modal_dialog_manager.cc.

Fix dispatchers:
- Move code from chrome_extensions_dispatcher_delegate.cc to extensions/renderer/dispatcher.cc

BUG=387288

Review URL: https://codereview.chromium.org/534163002

Cr-Commit-Position: refs/heads/master@{#293409}

Make DidCommitAndDraw always change the value of the layer's opacity to
force commits and draws rather than depending on a static bool.

LayerTreeHostPerfTestLeafInvalidates had a static bool for whether to
flip a layer to 1.0 or 0.5 opacity.  The leaf layer happens to start at
opacity 1.0.  So, on the first run, the tree would draw once,
DidCommitAndDraw would get called, and opacity would be set to the same
value.  This would cause no damage, so the tree would never draw again.
Because it would never draw again, DidCommitAndDraw wouldn't get called
again, and the opacity would never change again.  The tree kept
committing (because of the test harness) but would never draw again.

The second test would do the same thing, draw once, and then encounter
this static boolean (now false).  It would flip the opacity to zero (an
actual change), and would then keep alternating back and forth because
each draw would succeed.

Therefore, any test that was fast would always be followed by a slow
test, and any slow test would have a 50% chance of being followed by a
fast or a slow test.

This was exposed by r291451 because it made perf tests use the
scheduler (and would then early out of drawing for single-threaded).
The threaded version always had this bug.

*** Note: unsurprisingly, this will "regress" the performance of
LayerTreeHostPerfTestLeafInvalidates.TenTenSingleThread because it's
now doing something real.

R=danakj@chromium.org
BUG=407117

Review URL: https://codereview.chromium.org/544853002

Cr-Commit-Position: refs/heads/master@{#293408}

This directory hasn't been checked out by DEPS for a long time.  There
is no need for the "ios" section to override it to prevent this
directory being checked out.

BUG=none
TEST=none

Review URL: https://codereview.chromium.org/530143003

Cr-Commit-Position: refs/heads/master@{#293407}

Make BrowserThemePack stop assuming that the maximum persistent ID is related to
the the size of kPersistingImages. https://codereview.chromium.org/453213002
broke this assumption on Mac. This assumption has been broken on Windows for a
long time

BUG=405105
TEST=None

Review URL: https://codereview.chromium.org/542833002

Cr-Commit-Position: refs/heads/master@{#293406}

BUG=410438

Review URL: https://codereview.chromium.org/546523002

Cr-Commit-Position: refs/heads/master@{#293405}

This provides a mechanism for GLImage implementations to optimize
blit image to texture.

In the case of GLImageMemory, this allows us to upload directly
to the destination texture instead of first uploading to a temporary
texture copying pixels from this texture to the destination texture.

BUG=374962

Review URL: https://codereview.chromium.org/536353002

Cr-Commit-Position: refs/heads/master@{#293404}