- 18 Jun, 2019 40 commits
-
-
Paul Miller authored
Variations studies can have country filters so they only apply to users in certain countries. WebView must persist these prefs to support this. Studies configured for "session consistency" can use a different country on every run. These studies compare their country filter to the current country, which is stored in kVariationsCountry. Studies configured for "permanent consistency" will continue using the original country if the user moves countries. These studies compare their country filter to all the past countries listed in kVariationsPermanentConsistencyCountry. See CheckStudyCountry() in study_filtering.cc for how this works. BUG=823410 Change-Id: I76d6fc3e69a173d8b2de07ea886c215ad91f2f81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1665468Reviewed-by:
Tao Bai <michaelbai@chromium.org> Commit-Queue: Paul Miller <paulmiller@chromium.org> Cr-Commit-Position: refs/heads/master@{#670271}
-
Johannes Henkel authored
This is a reland of 65941216 TBR=lgrey@chromium.org Original change's description: > Reland "[DevTools] Roll inspector_protocol and migrate to std::vector." > > This reverts commit 3a73cee4. > > Reason for revert: <INSERT REASONING HERE> > > Original change's description: > > Revert "[DevTools] Roll inspector_protocol and migrate to std::vector." > > > > This reverts commit dc15ca61. > > > > Reason for revert: suspected to be causing link failures on android > > "ld.lld: error: thunk creation not co" when linking lib_components_browsertests__library.so > > eg: https://ci.chromium.org/p/chromium/builders/try/android-kitkat-arm-rel/288408 > > > > Original change's description: > > > [DevTools] Roll inspector_protocol and migrate to std::vector. > > > > > > New revision: 83b1154a9661d22bba9a368d368214cc20880419 > > > > > > This updates the usages of the protocol types to the new > > > definitions, using std::vector-based implementations > > > of protocol::Array. > > > - In many places we can now use the C++11 style for( : ) loops. > > > - We use std::make_unique for creation. > > > - We use emplace_back to insert elements, which sometimes > > > allows us to create strings etc. in place. > > > - Accessing strings in arrays is cheaper, since vector[i] > > > returns a reference (protocol::Array::get made a copy!). > > > - One can assert equivalence of vectors with strings > > > in tests (EXPECT_THAT(foo, testing::ElementsAre("bar", "baz")); > > > - Overall the code is shorter, as the vector API is > > > more concise. > > > > > > Change-Id: I6c8e152987fb0dcfbb01f9086ee48b284a0e5adb > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1657628 > > > Commit-Queue: Johannes Henkel <johannes@chromium.org> > > > Reviewed-by: Andrey Kosyakov <caseq@chromium.org> > > > Reviewed-by: Leonard Grey <lgrey@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#669857} > > > > TBR=alph@chromium.org,caseq@chromium.org,lgrey@chromium.org,johannes@chromium.org,kvitekp@chromium.org > > > > Change-Id: Iabcd0386f28787f5042e1f252c9e330330cc525f > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663403 > > Reviewed-by: Ben Pastene <bpastene@chromium.org> > > Commit-Queue: Ben Pastene <bpastene@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#669922} > > TBR=alph@chromium.org,caseq@chromium.org,bpastene@chromium.org,lgrey@chromium.org,johannes@chromium.org,kvitekp@chromium.org > > Change-Id: Ia917b8b41af985303dbf6a129ee2d281f7cecc1f > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1665168 > Reviewed-by: Johannes Henkel <johannes@chromium.org> > Commit-Queue: Johannes Henkel <johannes@chromium.org> > Cr-Commit-Position: refs/heads/master@{#670151} Change-Id: If2161c0e35c2809b746b1ec2737d068ef791eb59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1664979 Commit-Queue: Johannes Henkel <johannes@chromium.org> Reviewed-by:
Johannes Henkel <johannes@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#670270}
-
Ryan Hansberry authored
Several popular headphones (e.g., Bose QuietComforts, Sennheiser 550s, Sony WH-1000XM3s, etc.), as well as other peripherals like printers, send out BLE advertisements while on but not pairable. The current Chrome OS behavior of displaying these advertisements is confusing to users (because they try to pair them and can't) and noisy. This CL filters these advertisements out (by way of not filtering out dual mode devices whose type/appearance are not set), while still surfacing the headphones in the UI once they become truly pairable. Bug: 930229 Change-Id: I252c3e391aac3d546e455ab01e626c08af0c64b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1656971 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Sonny Sasaka <sonnysasaka@chromium.org> Cr-Commit-Position: refs/heads/master@{#670269}
-
Becky Zhou authored
Add dark variant on render tests of ArticleSnippetsTest, and update golden images. Bug: 948443 Change-Id: Ib2a39f3f3b25c246b50bea000e09c6c686aa4913 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1656668 Commit-Queue: Becky Zhou <huayinz@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#670268}
-
Marialicia Villarreal Garcia authored
This change implements HelpText property for views by exposing one of the following: 1. If Placeholder is available, set its value as the HelpText. 2. If the element has NameFrom::kTitle or NameFrom::kPlaceholder, expose StringAttribute::kName as the HelpText. 3. If Tooltip is available, set its value as the HelpText. 4. Return S_FALSE if there is no help information available. This change also adds an AXPlatformNodeWinTest to test the new implementation of HelpText property. Change-Id: I8a3d0d38273da75d7969a60f70a4627c96e8ffde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661003Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Commit-Queue: Maria Villarreal <mavill@microsoft.com> Cr-Commit-Position: refs/heads/master@{#670267}
-
Mario Bianucci authored
CursorType and WebCursorInfo were mirrors of each other, existing to avoid dependencies between ui and Blink. Recently however, other enums in a similar position were merged together in order to simplify things[1], and so it was decided that it would be best to do the same thing here. The two merged enums were in blink/public/platform/web_cursor_info.h and ui/base/cursor/cursor_type.h. blink/renderer/platform/cursor.h also had the enum, so I removed it there too. I also removed any code that was necessary for translating between them. [1]: crrev.com/e15b80b4 TBR=alexmos@chromium.org,caseq@chromium.org,oshima@chromium.org Bug: 969904 Change-Id: Ib20d0e3b003820b78a8740b4e352b289edd728f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648895 Commit-Queue: Mario Bianucci <mabian@microsoft.com> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#670266}
-
Lukasz Anforowicz authored
This CL goes through CORB histograms that work with and without NetworkService and: 1. Marks as obsolete and stops logging ones that are no longer needed: - SiteIsolation.XSD.Browser.Blocked.ContentLength.WasAvailable - SiteIsolation.XSD.Browser.Blocked.ContentLength.ValueIfAvailable - SiteIsolation.XSD.Browser.BytesReadForSniffing 2. Removes expiration date for ones that should be useful for the long-term: - SiteIsolation.XSD.Browser.Action" 3. Keeps temporary ones that should help evaluate the impact of protecting additional MIME types in M76: - SiteIsolation.XSD.Browser.Blocked.CanonicalMimeType Bug: 940785 Change-Id: I1272c93158587120c597e2a64cf050ad2bce6706 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1652371 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#670265}
-
dpapad authored
Bug: None Change-Id: Ie37d787653831c833b5ec9490fab6f79bb2ee196 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1665349 Commit-Queue: Dan Beam <dbeam@chromium.org> Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#670264}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/872c1d7fe98a..92cdeaaf810b git log 872c1d7fe98a..92cdeaaf810b --date=short --no-merges --format='%ad %ae %s' 2019-06-18 rharrison@chromium.org Rolling 4 dependencies Created with: gclient setdep -r src/third_party/dawn@92cdeaaf810b The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Change-Id: I29d6dabb542036c08b14016aea5e1af863c07b45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1665293Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#670263}
-
Piotr Bialecki authored
Removes old references to hit test from plane detection sample. Change-Id: I741c81fd82016c974b7a95b7bf66f5ea1a8e0f74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1665908Reviewed-by:
Bill Orr <billorr@chromium.org> Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#670262}
-
Eugene But authored
This reverts commit 8d972fd2. This CL removes the usage of CHROME_EG_ASSERT_NO_ERROR from autofil automation tests. TBR=rohitrao@chromium.org Bug: 963613 Change-Id: I7cf6effb15c38d1b5082e016f7d2767554210dc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662838Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#670261}
-
John Lee authored
Bug: 973674 Change-Id: I2d9971b41bd2f399914a6ab57c995cb5f1ca383b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662730 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#670260}
-
Matt Simmons authored
R=yusufo@chromium.org Bug: 976213 Change-Id: Ia31e1a8c93c77e657bc7f0ca1b22d5bebe364e5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663383 Commit-Queue: Matt Simmons <mattsimmons@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#670259}
-
Yuwei Huang authored
The CRD Android app version code had been fallback to "1" in official build for some reason. This CL explicitly sets the version code to `chrome_version_code` to be consistent with what we had been using. Bug: 976461 Change-Id: Id801c01da274eb307dcc316d4e76dd18d391b686 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666129 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Commit-Queue: Jamie Walch <jamiewalch@chromium.org> Auto-Submit: Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#670258}
-
Eric Aleshire authored
This follows the model of ChromeEarlGrey by: * Creating an AppInterface class that handles all the app interaction, and calling the AppInterface from the original SignInEarlGreyUtils class, which will live test-side in EG2. * Inheriting from BaseEGTestHelperImpl and asserting failures inside the helpers, always returning nil instead of returning NSError* on failure. In a follow-up CL, these methods will be converted to void and the callsites modified to remove the NSError* check. This CL does NOT create EG2 app and test support targets for auth, but does confirm that the AppInterface works for EG1. Change-Id: I083ea7397b0ad787611d91ab5f6901971bca2486 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1656058 Commit-Queue: ericale <ericale@chromium.org> Reviewed-by:
-
Lucas Furukawa Gadani authored
This CL fixes the HTMLPortalElement so that when the Frame is disconnected by the ChildFrameDisconnector we also consume the portal. This prevents anything being executed between the disconnection of the Frame and the portal being consumed (which is where we fire focus events and unload events). Bug: 971702 Change-Id: Ic4cedb1c48df35984ee8a1b02111762aab780089 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655381 Commit-Queue: Lucas Gadani <lfg@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#670256}
-
Victor Costan authored
Interfaces are base classes that only consist of virtual methods. This CL adds the following: * deleted copy constructor and assignment - prevent unintended slicing * protected constructors - prevent unintended direct instantiation * protected destructors - prohibit the user of an interface implementation from destructing the implementation, enforcing that the user does not own the implementation Change-Id: I2bb093e430cacb870846c74397051917ce50c83e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663462 Commit-Queue: Victor Costan <pwnall@chromium.org> Auto-Submit: Victor Costan <pwnall@chromium.org> Reviewed-by:
Staphany Park <staphany@chromium.org> Cr-Commit-Position: refs/heads/master@{#670255}
-
Daniel McArdle authored
Bug: 972412 Change-Id: I985783b4dcb695d4714dcd74246a185c94cd0825 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1652545Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Commit-Queue: Dan McArdle <dmcardle@chromium.org> Cr-Commit-Position: refs/heads/master@{#670254}
-
Henrik Lundin authored
These are monitored as part of experiments from time to time. Bug: none Change-Id: I2f40fef29348873ab18b3f4d179a983d0faab875 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663511Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Henrik Lundin <hlundin@chromium.org> Cr-Commit-Position: refs/heads/master@{#670253}
-
Daniel Murphy authored
This change adds the time it takes from creating the IDBOpenDBRequest till when: 1. The upgradeneeded event is dispatched, or 2. The success event is dispatched without a prior upgradeneeded event The goal is to measure the time it takes for both a warm (files already open) and cold (unopened) initialization of IndexedDB, from the perspective of the renderer. R=cmp@chromium.org Change-Id: Ie3495458e76dbd10d6ed6349254e78832e85c7c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1647335Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Chase Phillips <cmp@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#670252}
-
Dale Curtis authored
We aren't using (or have ever used) the metrics around why we're falling back, so go ahead and remove them. We mostly just care if we're still falling back. This switches the code to use the histogram functions and not the macros since they are infrequently reported. Some of the Media.Hardware metrics are marked as expire never, since we do want ongoing monitoring of our hardware audio population. BUG=975072 TEST=none Change-Id: Ibd7e211d8afa062e0d0f3ac6cf29871b3b87ec3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663375 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#670251}
-
Khushal authored
R=zmo@chromium.org Bug: 974485,976060 Change-Id: Ifd40d06facc31e0f9e0629490cb1a136c0fad0c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663736 Auto-Submit: Khushal <khushalsagar@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#670250}
-
Sinan Sahin authored
The Revamped context menu header doesn't show a title if the image/video doesn't have alt/title. This CL fixes the issue by using the name of the image/video extracted from the source URL if the alt/title is empty. Bug: 971500 Change-Id: I366532d3fbbd5b19e7b542c533df20ac020c21df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1664991Reviewed-by:
-
Felipe Cerqueira authored
Bug: 927957 Change-Id: Iba5628ea881350cff723a2ec9116f7fe3adba5ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1664430 Commit-Queue: Felipe Cerqueira <cerqueira@google.com> Reviewed-by:
-
Mustaq Ahmed authored
Bug: 959850 Change-Id: I3c63d5d9540bbc565582242dcf2b0b6d9b2a3398 TBR: rkaplow@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658948 Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Reviewed-by:
-
Lucas Furukawa Gadani authored
Bug: 908139 Tbr: boliu@chromium.org, bengr@chromium.org, seantopping@chromium.org, lazyboy@chromium.org, scottmg@chromium.org Change-Id: I24a403afe5d7b5f5a58e4ac6f8d3d82eb23f2611 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661149 Commit-Queue: Lucas Gadani <lfg@chromium.org> Reviewed-by:
Scott Graham <scottmg@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
-
Regan Hsu authored
Change-Id: I022f2aa29b468a43d2dbfecac5275575b9317e57 Bug: 825150 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660880 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
-
Jesse Schettler authored
When an event target is not an exo::Surface, let another handler process the event. BUG=b:135076290 TEST=Confirm arrow keys work correctly in a custom tab and a normal ARC app (such as Google Docs) TEST=exo_unittests --gtest_filter=KeyboardTest.OnKeyboardKey Change-Id: I8218aeced9f5a7e15db55099da45ce4cd72e83b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659488 Commit-Queue: Jesse Schettler <jschettler@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#670244}
-
Xing Liu authored
This CL adds a delegate class in DownloadDirectoryProvider, so we can mock this behavior in test. This is needed for the DownloadContentProvider effort for testing purposes. Bug: 970072 Change-Id: I585e51f60d5a356ffe1b5cb0116e615ceababad0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663249Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#670243}
-
Tommy Nyquist authored
The following histograms: - Android.PackageStats.CacheSize - Android.PackageStats.DataSize - Android.PackageStats.CodeSize were added to be able to keep track of various sizes of the package Chrome is installed under. Given the focus on binary size and other size-related issues, these histograms continue to provide real value and are poised to becoming even more important shortly, therefore extending their lifetime ~1 year for now. Also, adding another owner, so there are more people to contact in the future. Bug: 975303 Change-Id: Ic9de7d73fd0a2b266f063ae83cce55e9fca3fbba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663397 Auto-Submit: Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
-
Sidney San Martín authored
Toggling substitution types via this menu is temporary, which is consistent with other Mac apps' behavior. Bug: 42434 Change-Id: Ifa07909464f8a10f1e77be176fc456eb8855f093 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1654188Reviewed-by:
-
Robert Ogden authored
Change-Id: I2e829fd56258fd6218a7de3a09b51e025ebef2ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660959Reviewed-by:
-
Xianzhu Wang authored
Paint invalidation tracking was a good feature. It shows paint invalidation events in timeline and indicates the reasons (not generic reasons like "style", "layout", but specific reasons that can link to the javascript code etc.) However it has a problem that we often fail to match paint invalidation events to other invalidation events by node ids to find the reasons, and discard these events. This is because the paint invalidation caused by style or layout change on one node may not happen on that node, but on other nodes. This problem makes the feature incorrect in many cases, and it's hard to fix. We could show paint invalidation events without specific reasons, but I doubt how much value that would provide to web developers. So I'm removing the feature to avoid the maintenance burden. Change-Id: I2de2135dbb69041683bac49242b5e9bb6484ee02 Bug: 410701 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661690Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#670239}
-
Mike Wasserman authored
http://crrev.com/c/1660107 (PS1 here) was reverted for MSAN failures. This CL also initializes AccessibilityFocusRingInfo's members. Replace mojom with an abstract singleton controller, c++ struct & enums. Update impl & tests, expose a protected static helper for simplicity. Remove an unnecessary test subclass, unit test passes without this. Bug: 958129 Test: Automated; no accessibility focus ring regressions. Change-Id: I6071ee33dd5bdbfd3d5933e638ad27e703f206d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1664872 Commit-Queue: Michael Wasserman <msw@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#670238}
-
Anatoliy Potapchuk authored
Bug: 971593 Change-Id: I19d34abc6b0861debb5b6052976954ea87a3e0d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648242Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Cr-Commit-Position: refs/heads/master@{#670237}
-
Michael Crouse authored
When the HintsFetcherTopHostBlacklist is initialized, the top hosts currently in the Site Engagement Service are added to the blacklist. The number of hosts is limited to two times the number of hosts that hints can be fetched for by the HintsFetcher. Metrics are also added for the number of hosts added to the blacklist on initialization and the number of hosts in the blacklist when top hosts are requested. The next change will remove hosts from the TopHostBlacklist if the blacklist has been initialized and the user navigates to the host. Browser tests will also be added in a future change along with functionality to force a request for top hosts to be made without a delay. Bug: 943846 Change-Id: I129a90985b318815361d17a25361a75eedd21c3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1650080 Commit-Queue: Michael Crouse <mcrouse@chromium.org> Auto-Submit: Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#670236}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/e1814403169a..342f98b11765 git log e1814403169a..342f98b11765 --date=short --no-merges --format='%ad %ae %s' 2019-06-18 srte@webrtc.org Fixes for flexfec crash in scenario tests. 2019-06-18 sprang@webrtc.org Add support within PacedSender and pacer queue for owning rtp packets. 2019-06-18 mbonadei@webrtc.org Support __EMSCRIPTEN__ in rtc_base. 2019-06-18 ssilkin@webrtc.org Add/rewrite H264 VUI video signal type description. 2019-06-18 srte@webrtc.org Cleanup of resources from removed remote bitrate estimate test framework. 2019-06-18 mbonadei@webrtc.org Stop running 'bwe_simulations_tests'. Created with: gclient setdep -r src/third_party/webrtc@342f98b11765 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I9cbc8fe85bfec357af1489012384d8940ec5949b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1665208Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/7b8008e2e7e4..40ee745abc3b git log 7b8008e2e7e4..40ee745abc3b --date=short --no-merges --format='%ad %ae %s' 2019-06-18 evanhernandez@chromium.org test: Fix usage of LoopbackPartitions. 2019-06-18 evanhernandez@chromium.org test: MoblabVmTest assumes it is outside chroot Created with: gclient setdep -r src/third_party/chromite@40ee745abc3b The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Change-Id: I4c3bbd6783132c56ffdb2b3ab81bad996bfd6dfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1665248Reviewed-by:
-
Eugene But authored
UI>Browser>Navigation is the most appropriate component for this directory. Bug: None Change-Id: I6a639892931977244188948011553c56c087fe00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1665557 Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#670233}
-
Toby H authored
Bug: 943208 Change-Id: Ic5fc323d86f5f9818027011948a8af85c43da287 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663380Reviewed-by:
-
