- 25 May, 2018 40 commits
-
-
Chromium WPT Sync authored
Using wpt-import in Chromium adb006d2. With Chromium commits locally applied on WPT: 7a0d5e18 "[Mojo Blob URLs] Handle more navigation cases." 036419b1 "Fix errors in wpt/css/css-masking/* tests" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/18565 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=kereliuk No-Export: true Change-Id: I1879eb89c8685abb13c27c634c2658e2f5d00692 Reviewed-on: https://chromium-review.googlesource.com/1073403 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#561934}
-
Luna Lu authored
This reverts commit 69141da0. Reason for revert: core.stacktrace_unittest.TabStackTraceTest.testValidDump is failing on Win 7, disabling this test for now. Original change's description: > Revert "Disable core.stacktrace_unittest.TabStackTraceTest.testValidDump on win" > > This reverts commit 216e6d16. > > Reason for revert: culrpit CL was reverted > > BUG:chromium:846313 > > Original change's description: > > Disable core.stacktrace_unittest.TabStackTraceTest.testValidDump on win > > > > TBR=kbr@chromium.org > > NOTRY=true # net_unittests flake > > > > Bug: 846289 > > Change-Id: I7fa42786ebdb448fd424e37a7c777e60df6b3c36 > > Reviewed-on: https://chromium-review.googlesource.com/1071868 > > Commit-Queue: Ned Nguyen <nednguyen@google.com> > > Reviewed-by: Ned Nguyen <nednguyen@google.com> > > Cr-Commit-Position: refs/heads/master@{#561594} > > TBR=nednguyen@google.com > > Change-Id: Ibf328d3ea480b094e47c5037a7498f198ef94e62 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 846289 > Reviewed-on: https://chromium-review.googlesource.com/1073091 > Commit-Queue: Ned Nguyen <nednguyen@google.com> > Reviewed-by: Ned Nguyen <nednguyen@google.com> > Cr-Commit-Position: refs/heads/master@{#561881} TBR=nednguyen@google.com Change-Id: I039a5ffa03afbd50d79c57529d1b561def58ccdf No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 846289 Reviewed-on: https://chromium-review.googlesource.com/1073492Reviewed-by:
Luna Lu <loonybear@chromium.org> Commit-Queue: Luna Lu <loonybear@chromium.org> Cr-Commit-Position: refs/heads/master@{#561933}
-
James Hawkins authored
This change also animates the ellipses while the operation is executing. R=jdufault@chromium.org Bug: 845313 Test: LoginAuthUserViewUnittest.PressReturnWithTapToUnlockEnabled Change-Id: I5054a49177049070db5169e4c7e594dfe0a45baf Reviewed-on: https://chromium-review.googlesource.com/1072804Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Commit-Queue: James Hawkins <jhawkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#561932}
-
Koji Ishii authored
Following bot results are included. 5862 5867 5874 5880 125 lines were removed and 5 lines were deflaked by consecutive results since 5829. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I84d7148e920796f0b2ec0a41b7908cbb5e94904c Reviewed-on: https://chromium-review.googlesource.com/1073174 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#561931}
-
Dominic Mazzoni authored
As a follow-up to http://crrev.com/c/1015291, this change makes it so that all bubbles with an anchor view are now part of the focus order of their anchor view. Bug: 764918 Change-Id: I76fd7b5d8c8c5c10d5f7ff9c0278f6207f4db4d6 Reviewed-on: https://chromium-review.googlesource.com/1025372 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#561930}
-
Yusuf Ozuysal authored
After creating the intent for OpenInChrome, this resolves it to see whether Chrome can handle it. If not, falls back to a VIEW intent instead. BUG=834427 Change-Id: If39dc930521f78c0bdcd2818b9996694cff57b1c Reviewed-on: https://chromium-review.googlesource.com/1072166Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#561929}
-
Wez authored
This reverts commit c348474f. Reason for revert: Filter was added to the wrong test suite, so had no effect. Original change's description: > Fuchsia: Filter PipelineIntegrationTest.TrackStatusChangesWhileSuspended. > > PipelineIntegrationTest.TrackStatusChangesWhileSuspended times out > frequently on the FYI bots, so filter it out for now. > > Bug: 836785 > Change-Id: Id209d83a72e16a52cd7cc8b9281bf167a63cf636 > Reviewed-on: https://chromium-review.googlesource.com/1068617 > Reviewed-by: Wez <wez@chromium.org> > Commit-Queue: Wez <wez@chromium.org> > Cr-Commit-Position: refs/heads/master@{#561561} TBR=wez@chromium.org,kmarshall@chromium.org Change-Id: I057d4db914418cfd2a65a03a827c36a72c9439b0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 836785 Reviewed-on: https://chromium-review.googlesource.com/1073491Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#561928}
-
Daniel Nicoara authored
All callers have been updated to use VideoPlaneController::SetGeometry, so remove the deprecated call. Bug: None Test: Compiled Change-Id: I6c0a57c10ea8dd8282205359864854a9e36a0e73 Reviewed-on: https://chromium-review.googlesource.com/1067684Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#561927}
-
John Z Wu authored
Tests all public methods. Bug: 778764 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I10d254c9c70761c780024a4711493889fedd4cb7 Reviewed-on: https://chromium-review.googlesource.com/1070598 Commit-Queue: John Wu <jzw@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#561926}
-
Luna Lu authored
Bug: 846747 Change-Id: I917e61d4db2a30a3a537892aa972cdf505cbaf43 Reviewed-on: https://chromium-review.googlesource.com/1073406Reviewed-by:
Luna Lu <loonybear@chromium.org> Commit-Queue: Luna Lu <loonybear@chromium.org> Cr-Commit-Position: refs/heads/master@{#561925}
-
Luna Lu authored
Bug: 846753 Change-Id: I917f1efaab85b2ddf10c64c17f5f763d8256e2c8 Reviewed-on: https://chromium-review.googlesource.com/1073570Reviewed-by:
Luna Lu <loonybear@chromium.org> Commit-Queue: Luna Lu <loonybear@chromium.org> Cr-Commit-Position: refs/heads/master@{#561924}
-
Mike Wasserman authored
Have ws2::WindowService own a ClipboardImpl, like ws::Service. Enables copy/paste within the ksv app, but not to/from ash/chrome. (run ksv app via --keyboard-shortcut-viewer-app, press Ctrl+Alt+/). TODO: Support copy-paste between mojo apps and Chrome/Ash. Bug: 839591 Change-Id: I02b05cb9f830b0053dc0f1ad9e8e702505ad10a4 Reviewed-on: https://chromium-review.googlesource.com/1073572 Commit-Queue: Michael Wasserman <msw@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#561923}
-
Xi Cheng authored
The notification_platform_bridge_win* files are not moved for now for consistency reasons. There are no functionality changes at all. This makes the files in notifications/ more organized and eliminates the need of various per-file rules in the OWNERS file. Bug: 734095 Change-Id: I6d792a92d343841da4585edd1938295183b344be Reviewed-on: https://chromium-review.googlesource.com/1072698Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Xi Cheng <chengx@chromium.org> Cr-Commit-Position: refs/heads/master@{#561922}
-
Patrick Noland authored
Bug: 830919 Change-Id: I1fd9bdbd5f15003d1006518b6883111b5c6e6a5e Reviewed-on: https://chromium-review.googlesource.com/1043095 Commit-Queue: Patrick Noland <pnoland@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#561921}
-
Aaron Leventhal authored
In HTML via <ins>/<del>, and planned for ARIA 1.2, it is possible to mark insertions and deletions in a document. These need to be exposed to screen readers so that they can read revision changes or change suggestions from document reviewers. For now, ins/del are now mapped to internal roles, automation roles and OS X subroles. We are waiting for roles from IA2 for the new roles there. Here is the github issue: https://github.com/LinuxA11y/IAccessible2/issues/4 TBR=spang@chromium.org Bug: 843744 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I90e6d3140f6136a71e0d2f49b0b8d615485536bb Reviewed-on: https://chromium-review.googlesource.com/1067362 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#561920}
-
Findit authored
This reverts commit 80bae8d5. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 561872 as the culprit for flakes in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vODBiYWU4ZDVlYjNiOTc4YjQ4ZGU5YWFmNjM1OTI2YTkwMzU3NjMzZQw Sample Failed Build: https://ci.chromium.org/buildbot/chromium.mac/Mac10.11%20Tests/26622 Sample Failed Step: sync_integration_tests on Mac-10.11 Sample Flaky Test: TwoClientPreferencesSyncTest.LateRegisteredPrefsShouldSync_E2ETest Original change's description: > Support late registration of syncable preferences. > > Today, there's already a race when registering a preference > through the mojo preference service: the asynchronous > registration call might be slower than starting sync. As > more services are being implemented, those scenarios are > getting more likely -- especially as services could be > started at arbitrary times. > > Before this path, the synced preferences implementation did > not support this scenario. This patch changes the synced > preference implementation to receive and persist remote > data for preferences before they get registered. Currently, > this only applies for a whitelisted set of preferences. > More details about the approach can be found in the design > doc linked from the crbug/840332. > > Bug: 840332 > Change-Id: I90f046d7b59098a303e7b92350cc29e5de9cc244 > Reviewed-on: https://chromium-review.googlesource.com/1064750 > Commit-Queue: Tim Schumann <tschumann@chromium.org> > Reviewed-by: Dominic Battré <battre@chromium.org> > Reviewed-by: Ilya Sherman <isherman@chromium.org> > Reviewed-by: Marc Treib <treib@chromium.org> > Reviewed-by: Mikel Astiz <mastiz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#561872} Change-Id: I50c2cc6742cf32ea96af4c30e9d857e6dac56144 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 840332, 846791 Reviewed-on: https://chromium-review.googlesource.com/1073104 Cr-Commit-Position: refs/heads/master@{#561919}
-
John Z Wu authored
Adds a unit test for every method in public API. Bug: 778764 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I0db0ef7f9d7dee1e6486bcc49953edb5a0b76f2a Reviewed-on: https://chromium-review.googlesource.com/1065127 Commit-Queue: John Wu <jzw@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#561918}
-
Mathieu Perreault authored
Removing support for various experiments, except the feature code for |isIconAtStart| on Android, which may be useful in the future and used by other features reusing the dropdown. Bug: 841772 Test: visual Change-Id: I5a73b706ec30652348957a84ea6e095e493f006a Reviewed-on: https://chromium-review.googlesource.com/1061582Reviewed-by:
Tao Bai <michaelbai@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Commit-Queue: Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#561917}
-
https://crbug.com/843523arthursonzogni authored
Test that document.querySelector(":target") works when called in the window.load event. This test is a subset of dom/nodes/Element-matches.html, the difference is that this test is more lightweight. It causes the window.load event to be sent earlier. There is a race condition. Currently, it will only work when FrameLoader::ProcessFragment is called before Document::ImplicitClose(). Probable fix: https://chromium-review.googlesource.com/c/chromium/src/+/1057507 Bug: 843523 Change-Id: Ibf7b0d7621b18c3dfefaaa323bbd335d86ce0652 Reviewed-on: https://chromium-review.googlesource.com/1061456 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#561916}
-
Sky Malice authored
Monochrome.apk_Dex +2 entries fields +15 entries methods +4 entries types +7 entries strings Monochrome.apk_Breakdown (+16,364 bytes) -173 bytes Zip Overhead +657 bytes Non-compiled Android resources size +12,528 bytes Native code size +132 bytes Package metadata size +432 bytes Java code size +2,788 bytes Compiled Android resources size Monochrome.apk_Specifics +17,492 bytes normalized apk size +2 zip entries file count +12,528 bytes main lib size +1,128 bytes main dex size Bug: 844007 Change-Id: Id753ce08cebbee9d56679eee3452f6215d1f9907 Reviewed-on: https://chromium-review.googlesource.com/1073402Reviewed-by:Filip Gorski <fgorski@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#561915}
-
Steven Bennetts authored
Bug: 846488 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ib5e5fcc8b6eb51016c0a9a0f682a4afc4c657210 Reviewed-on: https://chromium-review.googlesource.com/1072923 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#561914}
-
Dominic Mazzoni authored
Originally landed: r560165, crrev.com/c/1063007 Reverted: r561246, crrev.com/c/1069891 TBR=dtseng@chromium.org Bug: 651614, 845778 Change-Id: I77b54de28cb0c4a231b5b0758ba4708100d27fff Reviewed-on: https://chromium-review.googlesource.com/1072875Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#561913}
-
Parastoo Geranmayeh authored
Logs the skipping decision for hidden or representational fields. Generally, we need to skip the hidden/representational fields, but to support reflected synthetic fields, we don't skip them if they are of 'select' form control type. Test added. See go/1038546-ukm-review for UKM collection review. Bug: 836949 Change-Id: I68c284d39a25176a008f2ad5305f5844a7b4c697 Reviewed-on: https://chromium-review.googlesource.com/1038546 Commit-Queue: Parastoo Geranmayeh <parastoog@google.com> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Cr-Commit-Position: refs/heads/master@{#561912}
-
Philip Rogers authored
This patch removes: LocalFrameView::IsEnclosedInCompositingLayer LocalFrameView::UpdateLayersAndCompositingAfterScrollIfNeeded Incidentally, this removes the last DisableCompositingQueryAsserts from LocalFrameView. Bug: 823365 Change-Id: I2cc8ef49252be320b994578570919ff5b2a34586 Reviewed-on: https://chromium-review.googlesource.com/1072908 Commit-Queue: Philip Rogers <pdr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#561911}
-
Michael Thiessen authored
It seems like the races between the hiding propagating and us showing the controls goes away when we turn off animations. I don't remember why we originally had to animate the controls, but I think whatever problems that was working around have since been fixed. Bug: 840891 Change-Id: I5420ba311c82ef284514667d5c8eb66b9e387654 Reviewed-on: https://chromium-review.googlesource.com/1072735Reviewed-by:
Biao She <bshe@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#561910}
-
jonross authored
SitePerProcessBrowserTest had its own custom class to wait for CompositorFrame submission, ChildFrameCompositorFrameSwapCounter. However this relied on the pre-viz submission path. This change updates those tests to use the browser_tests_utils RenderFrameSubmissionObserver which handles both classic display compositor as well as viz. TEST=SitePerProcessBrowserTest.CompositorFrameSwapped TEST=SitePerProcessBrowserTest.HiddenOOPIFWillNotGenerateCompositorFrames TEST=SitePerProcessBrowserTest.HiddenOOPIFWillNotGenerateCompositorFramesAfterNavigation TESt=SitePerProcessBrowserTest.SubframeVisibleAfterRenderViewBecomesSwappedOut Bug: 787941 Change-Id: I69aefc2fe455d4d90bbf70dbebb174a97a36b924 Reviewed-on: https://chromium-review.googlesource.com/1070609 Commit-Queue: Jonathan Ross <jonross@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#561909}
-
Felicia Lim authored
Bug: 842528 Change-Id: Ic19806411dd784bf820a27a65abb1b6bb14517cc Reviewed-on: https://chromium-review.googlesource.com/1072869Reviewed-by:
Henrik Andreasson <henrika@chromium.org> Commit-Queue: Felicia Lim <flim@chromium.org> Cr-Commit-Position: refs/heads/master@{#561908}
-
Egor Pasko authored
The test causes problems for mojo-ified SessionStorage. Remove the test to unblock the effort. The purpose of the test is to exercise a scenario that includes webcontents swap-in, which does not happen in the field any more (unless forced by a user with about:flags - this ability is going away soon). Bug: 755921 Change-Id: I489be7ece2b7d163448126e6b95a00b5a11126d5 Reviewed-on: https://chromium-review.googlesource.com/1073286 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#561907}
-
Nate Chapin authored
State is stored when starting certain ThreadableLoaderClients, to be used when the DocumentThreadableLoader is constructed. In any case where a DocumentThreadableLoader begins a fetch, WillSendRequest() will be called, so perfrom this work in WillSendRequest() and reduce the number of calls to InspectorNetworkAgent Change-Id: Ia8a5e130df73b0022755ddcde9bcbb754ceaca3c Reviewed-on: https://chromium-review.googlesource.com/1070617Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#561906}
-
Lukasz Anforowicz authored
Bug: 792546 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Ib2ed466f5b99ac4c6000eb2c4012e7feef186a31 Reviewed-on: https://chromium-review.googlesource.com/1033535 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#561905}
-
chaopeng authored
There are 3 changes make in absolute-position-behind-scrollbar: 1. update tests to use testharness.js 2. call rAFs before start input 3. use promise_test and gpuBenchmarking events This should fix the (absolute/fixed)-position-behind-scrollbar.html flaky on virtual/threaded test suites. Bug: 841567, 846424 Change-Id: I3744198054fdf7351ffc769ebfafea11044baf4c Reviewed-on: https://chromium-review.googlesource.com/1072270 Commit-Queue: Jianpeng Chao <chaopeng@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#561904}
-
Steven Bennetts authored
There is no particular reason for this code to be part of the delegate. This allows the code to run in Mash and Mus modes. Bug: 665064 Change-Id: I0c9a7b1872f82b3487aa51412294b5baeea33b9b Reviewed-on: https://chromium-review.googlesource.com/1071873 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#561903}
-
Dirk Pranke authored
It is failing, for unclear reasons. Disable to unblock the CQ until someone can make it work again. TBR=sandersd@chromium.org NOTRY=true Bug: 846729 Change-Id: I5bb455036799fbce53ae302ff5c3761d2da2a27e Reviewed-on: https://chromium-review.googlesource.com/1072451Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#561902}
-
Mohamed Heikal authored
Adds more tracing calls in ChromeActivity and other related startup code. Also fixes two presubmit warnings. Change-Id: Ida5d6ac0024dfa42a7e9c4aa3179bd7b55c4363f Reviewed-on: https://chromium-review.googlesource.com/1072409 Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#561901}
-
Kyle Horimoto authored
This class handles connection failures specific to BLE listener. Because listener roles wait until a connection occurs, this class only encounters a fatal error when the remote device is invalid. Bug: 824568, 752273 Change-Id: I2bc162549572aab1b9e9b5e1bfb16cb5e54e8073 Reviewed-on: https://chromium-review.googlesource.com/1072952Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#561900}
-
stkhapugin@chromium.org authored
Makes the location bar not show any icon on NTP. Adds a new offline icon and uses it for offline pages. Bug: 821804, 845956 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Icd8aba94af4fcabed9c35f3e322312624cb24835 Reviewed-on: https://chromium-review.googlesource.com/1071511 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#561899}
-
Ken Rockot authored
Migrates Service Manager away from the EDK invitation API and over to the new public API. Mostly a PoC CL for porting the old stuff to the new stuff, but this also means that Service Manager now only depends on EDK for initialization. Bug: 844763,844764 Change-Id: I10e40a95fdd4760cabd537b2a4ac4c56fb4e33e1 Reviewed-on: https://chromium-review.googlesource.com/1070533 Commit-Queue: Ken Rockot <rockot@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#561898}
-
Ken Rockot authored
Bug: 844764 Change-Id: I73023a683708249f2b3bb139e616e2bef1df1b1e Reviewed-on: https://chromium-review.googlesource.com/1067749Reviewed-by:
Jay Civelli <jcivelli@chromium.org> Commit-Queue: Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#561897}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/97db69faaeb4..be0f656a8e61 $ git log 97db69faa..be0f656a8 --date=short --no-merges --format='%ad %ae %s' 2018-05-25 dsinclair Add code to display XFA JS log messages Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ie444a6902b3c16cff23cbfd815b5963ae517fe1a Reviewed-on: https://chromium-review.googlesource.com/1073399 Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#561896}
-
Fredrik Söderquist authored
It's a layout-related gizmo. Take this opportunity to forward-declare IntrinsicSizingInfo and only include where used. Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I39750738147dbfce05ac1e77042fecfc02b2a92d Reviewed-on: https://chromium-review.googlesource.com/1070374Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#561895}
-