- 16 Feb, 2018 40 commits
-
-
bsheedy authored
Increases the timeout of VR tests running on Nougat to 30 minutes (from 16). The number of tests has grown to the point where 16 minutes can end up being flaky. The number should go back down eventually once WebVR is completely replaced by WebXR, but that's still a ways off. Bug: 812306 Change-Id: Ia3b74c8f11c524b3b01121e8842e1051692efce0 Reviewed-on: https://chromium-review.googlesource.com/920661 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#537157}
-
Robert Kaplow authored
Increase max of UKM.Entries.SerializedCount to a larger value. Start tracking #entries dropped from sampling Bug: 0 Change-Id: I08ddba346f8f8347840462d46a45166d9d33c14f Reviewed-on: https://chromium-review.googlesource.com/922781 Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#537156}
-
Kenneth Russell authored
They're running 10.12, not 10.10 as I thought. NOTRY=true TBR=jmadill@chromium.org, ynovikov@chromium.org Bug: 764803 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ibbe5f33ee540ff8f471932ad0753b7b1f9ee0214 Reviewed-on: https://chromium-review.googlesource.com/923411 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
-
Randy Smith authored
Historically, the on-disk Cookie DB has required unique creation time across all cookies, which is not a restriction classes higher in the stack have or enforce. This CL shifts the unique constraint over to (name, domain, path), which is supported by the spec. Bug: 800414 Change-Id: I8ab14f2a2cf81257ef51a34aca78a80f1886e356 Reviewed-on: https://chromium-review.googlesource.com/906675 Commit-Queue: Randy Smith <rdsmith@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#537154}
-
Kenichi Ishibashi authored
We should delay completing a resource request until all data has been received. Before this CL, we completed a request immediately after the response header comes in. To delay completing requests this CL introduces ServiceWorkerSubresourceLoader::StreamWaiter, which is similar to ServiceWorkerURLLoaderJob::StreamWaiter. It completes a request after OnCompleted() callback is called (or OnAborted() is called). This CL also fixes some typos. Bug: 778110 Change-Id: I6f3292eeb483b83e74f0d0be1df8b5e555e8c8f5 Reviewed-on: https://chromium-review.googlesource.com/920045 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#537153}
-
Joel Hockey authored
Bug: 762667 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Iebf2bf6bc2adf62e723013602f92f3451aed8038 Reviewed-on: https://chromium-review.googlesource.com/920203Reviewed-by:
Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#537152}
-
David Valleau authored
This change is built off of https://crrev.com/c/887858 which added basic verification to user-selected PPD files in order to provide them with more immediate feedback when they select an invalid file. This change is simply adding an error message that is displayed to the user. Here are some screenshots of what this change looks like in the UI: - invalid PPD (https://screenshot.googleplex.com/YKH4CPFTJpV.png) - valid PPD (https://screenshot.googleplex.com/ube7K8v9QtT.png) R=dpapad@chromium.org, xdai@chromium.org Bug: 778462,806915 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I6992a594cbf0c086e136c32814b8070724b1ed71 Reviewed-on: https://chromium-review.googlesource.com/898432Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: David Valleau <valleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#537151}
-
Eugene But authored
Bug: 810911 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I97693b9e6cb628ef98b7fca20f7c0d17defc0749 Reviewed-on: https://chromium-review.googlesource.com/919664Reviewed-by:
Danyao Wang <danyao@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#537150}
-
Rune Lillesveen authored
We used to pass through html and body style recalc twice for viewport style propagation. When we moved to propagating such styles to after the style recalc, the viewport style is not up-to-date right after body style is calculated and overlay scrollbar theming did not update correctly. Instead move the theme update to PropagateStyleToViewport after style is set on LayoutView. Bug: 811725 Change-Id: If51c580b7162f512377eecb48d85ca71bd5e7628 Reviewed-on: https://chromium-review.googlesource.com/921801Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#537149}
-
Jiaquan He authored
This is a preflight commit for switching AppList calls into mojo interfaces. Since we'll have AppListModel in ash, we want to make sure chrome tests are using FakeAppListModelUpdater. Specifically, this commit: - renames ChromeAppListModelUpdaterDelegate to AppListModelUpdaterDelegate; - puts more shared interfaces into AppListModelUpdater so that we can switch between ChromeAppListModelUpdater and FakeAppListModelUpdater in more cases; - overrides with a FakeAppListModelUpdater in tests; - fixes previous typo "preffer" -> "prefer". Bug: 733662 Change-Id: I0dec61341ae5cee772ae07afaed3e43fa4a52fbb Reviewed-on: https://chromium-review.googlesource.com/917003 Commit-Queue: Jiaquan He <hejq@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#537148}
-
Qiang Xu authored
changes: This CL includes Is{Set}VirtualKeyboardEnabled and Is{Set}StickKeysEnabled. Bug: 594887 Test: device test, observing tray accessibility updates. Change-Id: I6a790bd883969e0c457361ab29260210fb4db43a Reviewed-on: https://chromium-review.googlesource.com/912514 Commit-Queue: Qiang Xu <warx@google.com> Reviewed-by:James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#537147}
-
Steve Kobes authored
To optimize baselines properly, rebaseline-cl needs mac10.13_blink_rel in its try bot set, because mac10.13 is the only port whose baseline search path begins with "platform/mac". If BaselineOptimizer doesn't see a baseline in platform/mac, it will consolidate matching baselines from other Mac ports under platform/mac-mac10.12, and fail to merge them with matching baselines in platform/win into the generic path. Bug: 812784, 774301 Change-Id: Ifda7a0051bed79a044ab516b40c0795242247b46 Reviewed-on: https://chromium-review.googlesource.com/922791 Commit-Queue: Steve Kobes <skobes@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#537146}
-
Tommy C. Li authored
Adds a affordance for keyboard users to open PDFs for accessibility. Bug: 737787, 800399 Change-Id: Ifc234ab950357a512818ae0875fa6c156bc2ba1e Reviewed-on: https://chromium-review.googlesource.com/922681Reviewed-by:
Anthony LaForge <laforge@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#537145}
-
Daniel Murphy authored
This change fixes lifetime issues where the mojo service, created with mojo::MakeStrongBinding, stayed alive after the Profile, AppCache service, and things like the URLRequestContext have been destroyed. This is a little scary, as the AppCacheDispatcherHost and general AppCache code holds lots of raw pointers, and I'm sure this was the cause of other strange bugs. Prior to r522566 (when IPCs were converted to Mojo), the dispatcher object was owned by the RenderProcessHostImpl, and created during message filter creation. The filters were explicitly destroyed, which made the lifetime deterministic. Bug: 800391 Change-Id: Ie56839de3202be5c63080cf31e7a1391eb7ce405 Reviewed-on: https://chromium-review.googlesource.com/922919Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
-
Chris Harrelson authored
This re-introduces the fast path implemented in PLC::FrameViewDidScroll. Test coverage: all layout tests which use main-thread scrolling of a composited layer (e.g. using window.scrollBy or gestures on scrollbars). Bug: 770343 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I93a43072d19871611fa8845758410b094d67a8f7 Reviewed-on: https://chromium-review.googlesource.com/923089Reviewed-by:
-
Tom Anderson authored
CreateNotificationBridgeLinux() used to take 5 arguments, and if the caller wanted to change just one of them from the default, they would have to redundantly supply the defaults for the other 4. This CL makes CreateNotificationBridgeLinux() take a structure instead. R=thestig BUG=None Change-Id: I04c3dfedc9e4bac5d869adf3138bc24750254fb1 Reviewed-on: https://chromium-review.googlesource.com/923219 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#537142}
-
Trent Apted authored
GetNativeWidgetForNativeWindow() will later interrogate the NSWindow delegate, but we can't trust that delegate to be a valid object. Bug: 788271 Change-Id: Icc6b9b3738c553ec66f28c4154ad9d4a12581216 Reviewed-on: https://chromium-review.googlesource.com/920564Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#537141}
-
Kyle Horimoto authored
Instant Tethering only uses BLE connections. This filter was not previously used due to a potential workaround which had been resolved (see https://crbug.com/759090). Bug: 759091, 672263 Change-Id: I161efd638f683d21596e445a5f1db2f90a838e75 Reviewed-on: https://chromium-review.googlesource.com/919426Reviewed-by:
Rahul Chaturvedi <rkc@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#537140}
-
Becky Zhou authored
The modern tab buttons was at the top of the tab switcher. Moved them to the bottom and make the tab button indicator appear on the top. Bug: 803090 Change-Id: I1eedd513b0acc63657719ff4f67aeaddb7f2e202 Reviewed-on: https://chromium-review.googlesource.com/907316 Commit-Queue: Becky Zhou <huayinz@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#537139}
-
edchin authored
This is a first pass at GridCell. Icon, title, close button, and the snapshot were added. Styling is already pretty close but will require more tweaking. A showcase entry displays various uses of this cell including different sizes and dark/light themes. This approach attempts to solve for dark variants without the need to subclass. Bug: 804526 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I5bbeb5d8adb5ee93e6941d77bcac2b481569da74 Reviewed-on: https://chromium-review.googlesource.com/920627 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#537138}
-
Zhenyao Mo authored
Unless GPU process launching with real GPU already has crashed enough times. BUG=812406 TEST=GpuProcess telemetry test (newly added) R=piman@chromium.org Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ic07d7007e39705dbd2b9c9391072b6626062c843 Reviewed-on: https://chromium-review.googlesource.com/920501 Commit-Queue: Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#537137}
-
Meredith Lane authored
An accessor that was missed when the first round of string accessors were implemented. Follows the same pattern as all other accessors. BUG=792783 Change-Id: Ida6967a152c565b44d32d928156801d13ed13a42 Reviewed-on: https://chromium-review.googlesource.com/920042 Commit-Queue: Meredith Lane <meredithl@google.com> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#537136}
-
Bence Béky authored
WebSocketSpdyStreamAdapter wraps a SpdyStream so that it can be used by the future WebSocketHttp2HandshakeStream class to do the WebSocket handshake, then handed off to WebSocketBasicStream. Bug: 801564 Change-Id: Icac1d4e19d12b390bd61562de9150698be81f5f7 Reviewed-on: https://chromium-review.googlesource.com/912009Reviewed-by:
Ryan Hamilton <rch@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#537135}
-
Erik Luo authored
- Adds a check for valid CommandMenu extensions (category actions must have a title, otherwise CommandMenu fails to populate) - Fixes 'debugger.previous/next-call-frame's title - Adds 'Step*' actions to CommandMenu Bug: 812715 Change-Id: I9396f797d474556c593b678c372f9423bf2d04b1 Reviewed-on: https://chromium-review.googlesource.com/922505 Commit-Queue: Erik Luo <luoe@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#537134}
-
https://skia.googlesource.com/skia.git/+log/240516f772ea..f6f7b67ac230 $ git log 240516f77..f6f7b67ac --date=short --no-merges --format='%ad %ae %s' 2018-02-15 egdaniel When creating emptyp MipMap proxies, don't instantiate them immediately. Attempt 3 2018-02-14 csmartdalton Drop unused shader support for sample variables 2018-02-15 brianosman Fix flicker when changing backend on Mac viewer 2018-02-15 reed use conservative bounds to disable clipping 2018-02-15 egdaniel Disable texstorage for BGRA on ES devices that aren't apple 2018-02-15 rmistry Test change 2018-02-15 reed use safe increment for edge walker 2018-02-15 skcms-skia-autoroll Roll skia/third_party/externals/skcms/ 0e69310d6..c42baa572 (1 commit) 2018-02-15 reed abort blur if the sigma is too small Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=caryclark@chromium.org Change-Id: I4a2e6a058d9da115171d4f5835ff7fe2c8325e90 Reviewed-on: https://chromium-review.googlesource.com/922880Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#537133}
-
Takuto Ikuta authored
Let me use fdebug-prefix-map when strip_absolute_paths_from_debug_symbols is enabled for all except mac, windows and nacl. Change-Id: Id60f2cbdede4efa739fab67e57ab5af31607f71c Reviewed-on: https://chromium-review.googlesource.com/915242 Commit-Queue: Takuto Ikuta <tikuta@google.com> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
-
Steven Holte authored
Bug:812729 Change-Id: I418d2b540302805c08f78d63635f394f02fe3ac5 Reviewed-on: https://chromium-review.googlesource.com/922722Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#537131}
-
https://chromium.googlesource.com/angle/angle.git/+log/0bc6024a01d9..b92f92a780a1 $ git log 0bc6024a0..b92f92a78 --date=short --no-merges --format='%ad %ae %s' 2018-02-15 oetuaho Clean up dead insertion of unmangled symbols 2018-02-12 thakis Enable -Wimplicit-fallthrough for ANGLE. 2018-02-14 lfy GLES1: macOS: Add rpath to libGLESv1_CM.dylib Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=lucferron@chromium.org Change-Id: I4015bd45a9211f05398fe6a66fc4698f67d383bb Reviewed-on: https://chromium-review.googlesource.com/922870Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#537130}
-
Evan Stade authored
Bug: none Change-Id: Ibdc7005290606bfd7f956b03a2fcdbb930e64b98 Reviewed-on: https://chromium-review.googlesource.com/920797Reviewed-by:
-
mrefaat authored
Created wk_navigation_action_utils that has a utility function examine if the navigation action was user intended or not. Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I9103cf1b19fb241233aaa8c5d3a28343dd576320 Reviewed-on: https://chromium-review.googlesource.com/898364Reviewed-by:
Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#537128}
-
Dmitry Titov authored
This causes some test breakage since feature is still in development. The previously landed CL is https://chromium.googlesource.com/chromium/src/+/ccee22ccb0ed0ebf4f1ec417bddee0a0219132e2 Bug: 812899 Change-Id: I16657bc47fd69048cb8673ee4eca0aa77686da64 Reviewed-on: https://chromium-review.googlesource.com/923167Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Commit-Queue: Dmitry Titov <dimich@chromium.org> Cr-Commit-Position: refs/heads/master@{#537127}
-
Aaron Leventhal authored
The keyword hint, which is shown when a tab key will begin a keyword search, tells users about the feature and should be spoken via screen readers. - The alert ends up being fired only when the keyword changes. - It is fired the first time the hint is shown and not again until a different hint his shown, even if the hint disappears and reappears during that time (e.g backspace + retyping a character). this is less noisy overall for the screen reader user. - The alert event exists on all platforms we support. Bug: 812647 Change-Id: Ibcfa0da3e40aeb54cc8da43e77b869a3eb20836f Reviewed-on: https://chromium-review.googlesource.com/922021Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#537126}
-
David Bokan authored
Fixes DevTools' inspector-protocol getLayoutMetrics call to use the actual layout viewport when --root-layer-scrolls is turned on, rahter than explicitly using the FrameView. When the flag is on, this will be the LayoutView's PaintLayerScrollableArea (and FrameView if the flag is off). TEST=inspector-protocol/page/get-layout-metrics.js Bug: 417782 Change-Id: I2fad0323e40fd153b578253d86bb152c39077423 Reviewed-on: https://chromium-review.googlesource.com/923007Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#537125}
-
Charles 'Buck' Krasic authored
R=rch@chromium.org Change-Id: Ie34f61b29a3c686968e92d214e4279a30e0dec1f Bug: 802894 Change-Id: Ie34f61b29a3c686968e92d214e4279a30e0dec1f Reviewed-on: https://chromium-review.googlesource.com/922864 Commit-Queue: Buck Krasic <ckrasic@chromium.org> Reviewed-by:
-
Yixin Wang authored
This may cause the client to send HTTP/2 PRIORITY frames to inform server of new HTTP/2 stream dependencies. Change-Id: I025cd6ad4d1a887fa8190e7cd21bc7f92642b4e3 Reviewed-on: https://chromium-review.googlesource.com/914109 Commit-Queue: Yixin Wang <wangyix@chromium.org> Reviewed-by:
-
Malay Keshav authored
The clip path for tab is not being scaled based on the device scale leading to incorrectly clipped tabs at HiDPI. Bug: 812472 Change-Id: I4f016dec409dbd61eb569efc21eeab98dc3cfd74 Component: Tab, Clipping Reviewed-on: https://chromium-review.googlesource.com/922454Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Cr-Commit-Position: refs/heads/master@{#537122}
-
Aaron Leventhal authored
Address a collection of missing a11y names in browser UI found by iterating through views in the primary UI and checking for non-empty accessible names where the view is focusable. The browser view itself intentionally has no name, so it uses the explicitly empty name attribute flag. The textfield control has been updated so that SetAssociatedLabel can be used to automatically set the name. When this is used the accessibility labelledby relationship is also automatically set. Bug: 781485 Change-Id: Ie6359af94938156ae2ee7f36b73059fe2830cbdc Reviewed-on: https://chromium-review.googlesource.com/905592 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
-
chcunningham authored
Several flakes over last few days. Potentially related to some difference in Mac 10.13. Disabling while owners investigate. Bug: 811685 Change-Id: Ided6dafc0f9589af9434a076bdcdcebd72d98b48 TBR: ellyjones@chromium.org,tkent@chromium.org,yosin@chromium.org Reviewed-on: https://chromium-review.googlesource.com/922961Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#537120}
-
Carlos IL authored
Added an AboutUI page for chrome://connection-help, that displays a subset of the information available at support.google.com/chrome/answer/6098869. On a separate CL, logic will be added to redirect users who visit the online help center and get an interstitial to the chrome://connection-help site. Bug: 811382 Change-Id: Ic53d81a902fd8f59894f935a691b90c6eec98c11 Reviewed-on: https://chromium-review.googlesource.com/854793 Commit-Queue: Carlos IL <carlosil@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#537119}
-
https://pdfium.googlesource.com/pdfium.git/+log/625e6fec9ddd..2388506a1ba1 $ git log 625e6fec9..2388506a1 --date=short --no-merges --format='%ad %ae %s' 2018-02-15 dsinclair Revert "Actually enable -Wimplicit-fallthrough for pdfium." 2018-02-15 thakis Actually enable -Wimplicit-fallthrough for pdfium. 2018-02-15 npm Fix roll-freetype script 2018-02-15 dsinclair Make the CFX_XMLNode a MaybeOwned pointer Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I62db53c68c48e431a74452e5e967f6f785b07efb Reviewed-on: https://chromium-review.googlesource.com/923086Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#537118}
-
