- 20 Sep, 2016 40 commits
-
-
rickyz authored
BUG=None Review-Url: https://codereview.chromium.org/2349353004 Cr-Commit-Position: refs/heads/master@{#419898}
-
wangxianzhu authored
Previously blink's trace_event was implemented in the way to make blink a standalone library: TRACE_EVENT macros -> TRACE_EVENT internal macros -> EventTracer -> Chromium's trace event C++ API Now blink is no longer a standalone library, so we can use chromium's trace_event macros directly. This CL - removes blink's trace_event implementation - lets blink's TraceEvent.h include chromium's trace_event.h, - lets blink's TracedValue implement ConvertableToTraceFormat, - keeps support of blink CString type as trace values. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2341333003 Cr-Commit-Position: refs/heads/master@{#419897}
-
bsheedy authored
CL containing tests is at https://codereview.chromium.org/2335643002/ BUG= Review-Url: https://codereview.chromium.org/2356983002 Cr-Commit-Position: refs/heads/master@{#419896}
-
jinsukkim authored
Ensure container is attached to Window when acquiring an anchor view. BUG=646320 Review-Url: https://codereview.chromium.org/2346183002 Cr-Commit-Position: refs/heads/master@{#419895}
-
brettw authored
This file is actually used in the Windows build (it is where the cursors come from) so the comment about that it should be removed was incorrect. This patch deletes that comment. R=sky@chromium.org Review-Url: https://codereview.chromium.org/2353463003 Cr-Commit-Position: refs/heads/master@{#419894}
-
donnd authored
Updates unit tests for FieldTrial (which were misspelled FieldTrail). BUG= Review-Url: https://codereview.chromium.org/2351903004 Cr-Commit-Position: refs/heads/master@{#419893}
-
skym authored
BUG=634388 Review-Url: https://codereview.chromium.org/2342353004 Cr-Commit-Position: refs/heads/master@{#419892}
-
sadrul authored
Turn on sandbox for mojo apps by default. Apps that need to run without a sandbox need to include 'shell:unsandboxed' in their capabilities in manifest for mojo:shell. Update manifests for mojo:ui, mojo:font_service, mojo:file_system, and mojo:leveldb services to include 'shell:unsandboxed'. BUG=645602, 646376 Review-Url: https://codereview.chromium.org/2338793003 Cr-Commit-Position: refs/heads/master@{#419891}
-
Rebaseline Bot authored
https://chromium.googlesource.com/chromium/src/+/f5ff44ae7 BUG=644059 TBR=bsep@chromium.org Review URL: https://codereview.chromium.org/2355973003 . Cr-Commit-Position: refs/heads/master@{#419890}
-
manzagop authored
BUG=648185 Review-Url: https://codereview.chromium.org/2351533004 Cr-Commit-Position: refs/heads/master@{#419889}
-
catapult-deps-roller authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/cc78bd596aa7..87d7635e7c15 $ git log cc78bd596..87d7635e7 --date=short --no-merges --format='%ad %ae %s' 2016-09-20 alexandermont Add in power metric for video playback. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=catapult-sheriff@chromium.org Review-Url: https://codereview.chromium.org/2352113003 Cr-Commit-Position: refs/heads/master@{#419888}
-
finnur authored
The |category| sent down will never be ALL_SITES, but it should also be notified of changes. BUG=None CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2351153002 Cr-Commit-Position: refs/heads/master@{#419887}
-
sammc authored
BUG=634568, 637174 Review-Url: https://codereview.chromium.org/2217813003 Cr-Commit-Position: refs/heads/master@{#419886}
-
kylechar authored
Adds a builder for FakeDisplaySnapshot to allow us to easily construct the display snapshots. Will update more tests to use this functionality in a follow up CL. Update platform_screen_ozone_unittests.cc to use FakeDisplaySnapshot instead of DisplaySnapshotVirtual. Update --screen-config to take display DPI and able to start without any initial displays. BUG=611475 Review-Url: https://codereview.chromium.org/2340383002 Cr-Commit-Position: refs/heads/master@{#419885}
-
dmazzoni authored
BUG=644758 Review-Url: https://codereview.chromium.org/2352213002 Cr-Commit-Position: refs/heads/master@{#419884}
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) build: https://crrev.com/cee7475ca3ab8eba9c9760cdf086cc7c703df15c [Bisect] Account for tir_label-level summaries in parse_metric (eakuefner@chromium.org) TBR=martiniss@chromium.org,phajdan.jr@chromium.org BUG=644865 Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Review-Url: https://codereview.chromium.org/2354113002 Cr-Commit-Position: refs/heads/master@{#419883}
-
jwd authored
This DCHECK is very easy to trigger by developers, googlers specifically, without actually violating the intent of the DCHECK. BUG=648594 Review-Url: https://codereview.chromium.org/2353133003 Cr-Commit-Position: refs/heads/master@{#419882}
-
grt authored
We can't have chrome.exe depending on browser code since doing so can unexpectedly cause the size of chrome.exe to bloat. This change accomplishes the breakage by passing the main exe entry TimeTicks through to chrome.dll directly by way of ChromeMain and ChromeMainDelegate rather than via an environment variable. BUG=647223 R=brucedawson@chromium.org Review-Url: https://codereview.chromium.org/2345933002 Cr-Commit-Position: refs/heads/master@{#419881}
-
pdfium-deps-roller authored
https://pdfium.googlesource.com/pdfium.git/+log/5a399de2945d..60e903c33480 $ git log 5a399de29..60e903c33 --date=short --no-merges --format='%ad %ae %s' 2016-09-20 npm Change protected to private in CPDF_CID2UnicodeMap and CPDF_ToUnicodeMap 2016-09-20 npm Delete unused methods and variables in CPDF_CMapManager and in CPDF_CMapParser 2016-09-20 npm Delete unused GetBitMap() in fx_agg_driver TBR=dsinclair@chromium.org Review-Url: https://codereview.chromium.org/2359633002 Cr-Commit-Position: refs/heads/master@{#419880}
-
boliu authored
BUG=648749 TBR=bengr@chromium.org Review-Url: https://codereview.chromium.org/2354103002 Cr-Commit-Position: refs/heads/master@{#419879}
-
bajones authored
Specced as part of the WebVR API to associate Gamepad devices with a headset when applicable. See: https://w3c.github.io/webvr/#interface-gamepad BUG=389343 Review-Url: https://codereview.chromium.org/2352713004 Cr-Commit-Position: refs/heads/master@{#419878}
-
eugenebut authored
Currently Bookmarks bubble is anchored to center-top, so its right part may be displayed offscreen. Regression happened after this CL: https://codereview.chromium.org/1759453002/patch/240001/250007 which defer anchoring to LocationBarBubbleDelegateView (which in it's turn uses NONE arrow, and makes center-top anchoring). bookmark_bubble_view.cc was the only bubble that lost its explicit TOP_RIGHT. So other bubbles don't need a similar update. Regression affects MacViews, but not other platforms, because other platforms infer a TOP_RIGHT in location_bar_bubble_delegate_view.cc. MacViews does not, because it's anchored to a point, not a View. This change restores anchoring to top right and does not impact other platforms (tested on Windows). The change makes MacViews version worse in RTL, because omnibox is not mirrored on mac. Since omnibox will be mirrored eventually, leaving it as it is. BUG=600209 Review-Url: https://codereview.chromium.org/2351593002 Cr-Commit-Position: refs/heads/master@{#419877}
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) build: https://crrev.com/9672983b7e4143ea26754935e0132a0838f2b326 Add flutter_services (abarth@chromium.org) TBR=martiniss@chromium.org,phajdan.jr@chromium.org BUG= Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Review-Url: https://codereview.chromium.org/2356033002 Cr-Commit-Position: refs/heads/master@{#419876}
-
fs authored
Where possible, use the "standard" message for read-only objects from ExceptionMessages. Move the setup of the ExceptionState with this message to SVGPropertyTearOffBase and reuse. It also saves a small chunk of code-space. Also drop a bunch of vspace, reorder checks in SVGPreserveAspectRatioTearOff to check for immutability first and do less work on error in SVGMatrixTearOff. Review-Url: https://codereview.chromium.org/2357463002 Cr-Commit-Position: refs/heads/master@{#419875}
-
ericrk authored
Currently, we do not flush our GL contexts after cleaning up LayerTreeHostImpl (LTHI) resources. This delays the time it takes for these deletes to reach the GPU process, and can allow driver caches to grow unnecessarily. This CL does a ShallowFlushCHROMIUM after freeing LTHI resources, which reduces cache growth on some platforms (observed on N9). R=vmpstr BUG=643251 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Review-Url: https://codereview.chromium.org/2358593002 Cr-Commit-Position: refs/heads/master@{#419874}
-
mbjorge authored
When run with tsan and ubsan, the net_unittests take many hours to complete and waste build machine resources. The tests can be re-enabled once the source of the slowdown is found. BUG= internal b/31279943 Review-Url: https://codereview.chromium.org/2349373003 Cr-Commit-Position: refs/heads/master@{#419873}
-
pmonette authored
The affected function are TabInsertedAt() and TabPinnedStateChanged(). This change includes no functional changes and it will be used in a subsequent CL. Review-Url: https://codereview.chromium.org/2354673004 Cr-Commit-Position: refs/heads/master@{#419872}
-
jyquinn authored
Revert of Add work-around to symlink.gni to avoid "not up-to-date" ninja errors (patchset #1 id:1 of https://codereview.chromium.org/2344243002/ ) Reason for revert: Breaks iOS build with failure: FAILED: gen/linked_src/third_party/objective_c/google_toolbox_for_mac python ../../build/symlink.py --update-target-mtimes -f ../../../../../../third_party/google_toolbox_for_mac/src gen/linked_src/third_party/objective_c/google_toolbox_for_mac Traceback (most recent call last): File "../../build/symlink.py", line 65, in <module> sys.exit(Main(sys.argv)) File "../../build/symlink.py", line 56, in Main os.utime(s, None) OSError: [Errno 2] No such file or directory: '../../../../../../third_party/google_toolbox_for_mac/src' Original issue's description: > Add work-around to symlink.gni to avoid "not up-to-date" ninja errors > > Ninja bug: https://github.com/ninja-build/ninja/issues/1186 > > BUG=646165 > > Committed: https://crrev.com/80f464d5151c3eec102604faf5fa36d9369b64aa > Cr-Commit-Position: refs/heads/master@{#419751} TBR=dpranke@chromium.org,agrieve@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=646165 Review-Url: https://codereview.chromium.org/2356973002 Cr-Commit-Position: refs/heads/master@{#419871}
-
dtapuska authored
Touchpad flings that have only passive event listeners were forced to be main thread. Handle event injection to the main thread event queue for when we get passive events so it can be entirely done on the compositor thread. BUG=646592 TBR=ben@chromium.org Review-Url: https://codereview.chromium.org/2341873002 Cr-Commit-Position: refs/heads/master@{#419870}
-
clm authored
The way CronetJavaEngine (which uses JavaUrlRequest) is implemented in regards to chunked uploads: 1) Is inconsistent with it's native counterpart which almost immediately writes the obtained data to the wire. 2) Makes it impossible to slowly stream data (like during a voice search) in a controlled manner. No data is sent other than at JavaUrlRequest.DEFAULT_CHUNK_LENGTH (8192) intervals. BUG=b/31592204 Review-Url: https://codereview.chromium.org/2356923002 Cr-Commit-Position: refs/heads/master@{#419869}
-
jianli authored
In order to trigger reloading currently-displayed as offline page with network condition check, we resend the request with same extra request header with reason field updated. BUG=644943 Review-Url: https://codereview.chromium.org/2337363002 Cr-Commit-Position: refs/heads/master@{#419868}
-
bsep authored
The current zoom logic in image documents interacts badly with use-zoom-for-dsf, in addition to having some weird behavior already. This patch changes three things: 1. When loading a large image when page zoom was not 100% the image would start at a strange scaling factor until it was clicked. This is fixed. 2. When page zoom is at 100% a large image will always scale to fit the window regardless of the device scale factor. Previously with use-zoom-for-dsf on it would scale too large for the window. 3. When an image that fits in the window is zoomed in until it doesn't it is no longer clickable. Previously it would start acting like a large image, which was strange. Also added a test suite for ImageDocument. BUG=324086,644059 Review-Url: https://codereview.chromium.org/2319863006 Cr-Commit-Position: refs/heads/master@{#419867}
-
dpranke authored
If you ran `gn analyze` on a list of files that changed a build file, the list of compile targets and output targets should've been returned unchanged, but if the additional_compile_targets input included "all", the returned list was left empty. R=brettw@chromium.org BUG=648532 Review-Url: https://codereview.chromium.org/2350963006 Cr-Commit-Position: refs/heads/master@{#419866}
-
vakh authored
Also, some DCHECKS for ensuring methods run on expected threads. BUG=543161 Review-Url: https://codereview.chromium.org/2349603003 Cr-Commit-Position: refs/heads/master@{#419865}
-
xunjieli authored
This CL adds a virtual function to net::BidirectionalStreamImpl to get LoadTimingInfo. There will be follow-up CLs to add the implementation for H2 and QUIC separately. This is a part of the effort to expose timing metrics to net embedders. BUG=648346 Review-Url: https://codereview.chromium.org/2349363002 Cr-Commit-Position: refs/heads/master@{#419864}
-
pkotwicz authored
Chrome and the WebAPK server parse URLs differently. For instance, the WebAPK server currently does not do URL escaping. The WebAPK server populates the WebAPK's Android Manifest with the URLs that it has parsed. This CL makes ManifestUpgradeDetector canonicalize URLs before comparing them. BUG=638077 TEST=ManifestUpgradeDetectorTest.* Review-Url: https://codereview.chromium.org/2341163002 Cr-Commit-Position: refs/heads/master@{#419863}
-
catapult-deps-roller authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/7d41d5873cc4..cc78bd596aa7 $ git log 7d41d5873..cc78bd596 --date=short --no-merges --format='%ad %ae %s' 2016-09-20 benjhayden Add tr.v.d.Scalar 2016-09-20 nednguyen Add script for slimming trace file 2016-09-20 alexandermont Put all power metrics in one file. 2016-09-20 charliea Fix more camelcase violations in tracing/ CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=catapult-sheriff@chromium.org Review-Url: https://codereview.chromium.org/2357493003 Cr-Commit-Position: refs/heads/master@{#419862}
-
maxbogue authored
- Move function definitions inside the class declaration. - Move static functions to an anonymous namespace. - Introduce kTagN, kValueN, and kHashN constants. - Remove 14 methods that were simply forwards to calls on the processor or server and add direct accessors to those classes instead. BUG=648705 Review-Url: https://codereview.chromium.org/2355993002 Cr-Commit-Position: refs/heads/master@{#419861}
-
pdfium-deps-roller authored
https://pdfium.googlesource.com/pdfium.git/+log/9972ff99285c..5a399de2945d $ git log 9972ff992..5a399de29 --date=short --no-merges --format='%ad %ae %s' 2016-09-20 tsepez Make CPDF_Array not do indirect object creation. 2016-09-20 dsinclair CPDF_Document friend cleanup 2016-09-20 dsinclair CPDF_OCContext and CPDF_Document are no longer friends 2016-09-20 dsinclair CPDF_Document and CPDF_DataAvail are no longer friends 2016-09-20 dsinclair Cleanup CPDFXFA and CPDF document methods 2016-09-20 tsepez Re-land "Make CPDF_IndirectObjectHolder use unique_ptr to objects"" 2016-09-20 art-snake Fix memory leaking on ClosePage. 2016-09-20 tsepez Assert that dictionary can own the objects it is given. BUG=79367,48791 TBR=dsinclair@chromium.org Review-Url: https://codereview.chromium.org/2355983002 Cr-Commit-Position: refs/heads/master@{#419860}
-
kcwu authored
Review-Url: https://codereview.chromium.org/2354003002 Cr-Commit-Position: refs/heads/master@{#419859}
-