GitLab

https://crbug.com/873999 shows that placeholder text in <input> could
be selected by long press below it.

This is because for this code path we passed a corrected click point.
y-coordinate was adjusted to 0, which will lead
|LayoutBlock::PositionForPointIfOutsideAtomicInlineLevel()| give a
incorrect result, then in
|SelectionController::SelectClosestWordFromHitTestResult()|, it gets
the placeholder <div> in the <input> Shadow DOM as the hit test result
position.

We now pass the normal point so it could figure out the position is
at <input>, which is more reasonable.

Bug: 873999
Change-Id: I6d9ee4d03778ad65493eff8735d58cf271d07a57
Reviewed-on: https://chromium-review.googlesource.com/1174963
Commit-Queue: Shimi Zhang <ctzsm@chromium.org>
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585208}

This is only used for ANGLE, and geofflang suggests that this doesn't
apply to ANGLE any more, as it does mostly the same thing in both cases.

Bug: 829614
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I25371dcef4043edd0abbdf4e943778771246918e
Reviewed-on: https://chromium-review.googlesource.com/1185283Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: enne <enne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585207}

Renaming this class to remove "Install" because it will also be
used to actually launch the app after installation. The change to
add the launching capability is separated from this one to keep
things clean.

Bug: 870093
Change-Id: I78798632084670feef64dadfb119ff9ed8f0960b
Reviewed-on: https://chromium-review.googlesource.com/1183693
Commit-Queue: Jeremy Klein <jlklein@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585206}

Change-Id: I89e4c117c81c0990a9fba071d8e09656545facb6
TBR: nhiroki
Reviewed-on: https://chromium-review.googlesource.com/1184134Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585205}

This patch does a few things to hopefully speed up the viewport update
during pre-paint:

- Only process overlay scrollbars if we're on a platform that uses
them.
- Cache the element id on the visual viewport rather than creating it
each time the getter is used.
- Use passed in node pointers for the current context, rather than
assuming we should use the root nodes.

With these changes, we also reenable running this viewport update in
!enable-blink-gen-property-trees mode.

Bug: 868927
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I161b8b1901cb2183f060130ecec058ca5f693170
Reviewed-on: https://chromium-review.googlesource.com/1183983
Commit-Queue: David Bokan <bokan@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585204}

The "TODO: Deprecate" was ambiguous. I think the intent is that new code
shouldn't use it and the TODO is to migrate existing code.

Bug: 796799
Change-Id: I73b135b937d65649ff2f0c5fc99723353065e9bb
Reviewed-on: https://chromium-review.googlesource.com/1184136Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585203}

The observer model was a source of crashes since it had tricky lifetime
as the ServiceWorkerRegisterJob keeps a reference to
ServiceWorkerVersion but tries to observe its EmbeddedWorkerInstance
which can be reset to another instance at any time. We tried to mitigate
it before with OnWillBeDestroyed() but it wasn't sufficient.

Just use a callback instead.

Bug: 876541, 855852
Change-Id: Ic3546716108fa0e7af1e3fada8ca79ec32846a8a
TBR: kinuko
Reviewed-on: https://chromium-review.googlesource.com/1184133Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585202}

First some background (true both before and after this CL).
NavigationURLLoaderImpl roughly operates like this:
1. Ask interceptors whether they want to handle a request until
   one says yes (call MaybeCreateLoader).
2. Apply URLLoaderThrottles to the request, possibly rewriting it.
3. Have the interceptor handle the request (invoke its RequestHandler).

But before this CL, the interceptor could not observe the rewritten
request. Therefore, this CL:
1. Adds |resource_request| to RequestHandler signature.
2. Renames the request passed to MaybeCreateLoader to
   |tentative_resource_request| to make more clear that it is not
   necessarily the final request.

Of course, in the current code, interceptors are treating
|tentative_resource_request| as the final request, so this CL adds TODOs
to those interceptors.

The motivation of this CL is service worker interception. Before this
CL, service worker interception would dispatch the fetch event and get a
response before calling the LoaderCallback indicating whether the
service worker wants to handle the request. This was convenient for
network fallback in case the service worker fetch event did not provide
a response.

This CL changes service worker interception to operate after throttling.
This has several motivations:
1. The service worker fetch event may provide an inappropriate response
   for the request if it sees the pre-throttled request rather than the
   post-throttled request.
2. If throttling changes the URL, it would result in a simulated
   redirect, so the service worker interception would have been
   wasteful.
3. This also fixes the missing variation header for navigation preload
   requests, since the throttles will add the header before the fetch
   event.

Change-Id: If13ff956e46de91abb43f3919f869dc5e1eba3e6
Bug: 873061, 873575, 876531, 876527
Reviewed-on: https://chromium-review.googlesource.com/1174204Reviewed-by: Victor Costan <pwnall@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585201}

This is a follow up to
https://chromium-review.googlesource.com/c/chromium/src/+/1155470
where the code to report the metrics was added.

Bug: 750639
Change-Id: Ib2ed87109d04837560bb6768020765e6d7183e8e
Reviewed-on: https://chromium-review.googlesource.com/1184969Reviewed-by: Gayane Petrosyan <gayane@chromium.org>
Commit-Queue: Annie Sullivan <sullivan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585200}

This reverts commit 87b3a36a.

Reason for revert: Causes crash issue https://bugs.chromium.org/p/chromium/issues/detail?id=874745

Original change's description:
> [Image Capture, Android] Fix various threading issues
> 
> This CL simplifies the threading of class VideoCaptureCamera2.java
> and by doing so resolves potential issues caused by concurrent
> access to member variables and Android video API calls.
> 
> See https://bugs.chromium.org/p/chromium/issues/detail?id=857530 for
> details on issues.
> 
> The simplified model is to (still) have the constructor and public API
> calls happen on a native thread, and to use a single dedicated thread
> owned by the class instance to post to, do work on, and call back into
> the native code.
> 
> This CL is part of a series, see Design Doc at
> https://docs.google.com/document/d/1h1kva4VR1gaV3HVXaSYZFY41icfaB58j-WnHmJdyqc8/edit?usp=sharing
> 
> Bug: 857530
> Change-Id: I75ffcc4a14f2395d833d80f300acef7b456676e8
> Reviewed-on: https://chromium-review.googlesource.com/1117857
> Commit-Queue: Christian Fremerey <chfremer@chromium.org>
> Reviewed-by: Emircan Uysaler <emircan@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#576155}

TBR=emircan@chromium.org,chfremer@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 857530
Change-Id: Ifc02ccd8b8282b0ec31e2f4f36dbe831eee551a2
Reviewed-on: https://chromium-review.googlesource.com/1185262Reviewed-by: Christian Fremerey <chfremer@chromium.org>
Commit-Queue: Christian Fremerey <chfremer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585199}

Bug: 876568
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I30ca8030e94f34245d4d53dfc25a463d66bca00e
Reviewed-on: https://chromium-review.googlesource.com/1185462Reviewed-by: Matt Mueller <mattm@chromium.org>
Commit-Queue: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585198}

Fullscreen and orientation systems were abusing platform to
communicate a flag through it. The patch makes this explicit,
with orientation directly allowing fullscreen.

Change-Id: Ic0f16e7c6e3f70f00c8983dd7efc8f905249d695
Reviewed-on: https://chromium-review.googlesource.com/1157032
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585197}

This reverts commit cc2b634d.

Reason for revert: Multiple PPAPI tests have begun failing on different OSes after this patch lands. See crbug.com/876824

Original change's description:
> Make PepperUdpSocketMessageFilter use NetworkService UDP API.
> 
> This CL moves all of the logic over to the UI thread, to keep things
> relatively simple and minimize thread hops, since that's where core
> network service objects live.
> 
> It also fixes a pre-existing bug in the PPAPI UDP code, where read
> errors that occur when there's no pending read are converted into
> 0-byte read successes.
> 
> Bug: 848078
> Cq-Include-Trybots: luci.chromium.try:linux_mojo
> Change-Id: Id6d23c26c1ac085211dfcfe23502a307fc29a284
> Reviewed-on: https://chromium-review.googlesource.com/1171568
> Commit-Queue: Matt Menke <mmenke@chromium.org>
> Reviewed-by: John Abd-El-Malek <jam@chromium.org>
> Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
> Reviewed-by: Helen Li <xunjieli@chromium.org>
> Reviewed-by: Bill Budge <bbudge@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#585057}

TBR=bbudge@chromium.org,jam@chromium.org,mmenke@chromium.org,xunjieli@chromium.org,rhalavati@chromium.org

Change-Id: I68b625673615275c102a95aac7df7583a2f7c97d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 848078
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Reviewed-on: https://chromium-review.googlesource.com/1185682Reviewed-by: Jonathan Ross <jonross@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585196}

As per the latest update to https://github.com/dtapuska/useractivation
exposing the UserActivation on the MessagePort was needed. So this
adds the code and a few tests.

BUG=861735

Change-Id: I3439b67c75e53666243a2ec36d8d93e6c23de5b4
Reviewed-on: https://chromium-review.googlesource.com/1183683
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585195}

The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio
TBR=cr-fuchsia+bot@chromium.org

Change-Id: I775137391965f8ecbc6e28269a81550ea4a25cbb
Reviewed-on: https://chromium-review.googlesource.com/1185489Reviewed-by: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#585194}

Change the RelaunchNotificationController so that it sends notifications
to the system tray and to ash, to be shown in Chrome OS as they should
be, in the notification center (instead of bubbles and dialogs, the
Chrome dekstop way).

Bug: 846425
Change-Id: Iea8cd8cc1c2c3457a44f74f10c72fa56b0b378bd
Reviewed-on: https://chromium-review.googlesource.com/1150227
Commit-Queue: Stefan Teodorescu <fane@google.com>
Reviewed-by: Lutz Justen <ljusten@chromium.org>
Reviewed-by: Marton Hunyady <hunyadym@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Greg Kerr <kerrnel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585193}

This change adds a check for the NetworkFileSharesAllowed policy
when starting up SmbService. If the policy is set to false, meaning
that Network File Shares should not be allowed, SmbService will not
be registered with the FSP, removing the entry point from the
"Add new services" menu in the Files App.

Additionally, since the Settings UI picks up policy changes on the fly
but the NetworkFileSharesAllowed policy does not support dynamic
refresh, SmbService respects the state of the policy at login.

Bug: 757625
Test: verified by setting policy locally.
Change-Id: I2d7cc147e51b584255679a00f233750f1b8cb4fe
Reviewed-on: https://chromium-review.googlesource.com/1153488Reviewed-by: Scott Chen <scottchen@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585192}

content/renderer/OWNERS has things like:
per-file foo.*=person

But this exclused foo_unittest.cc.

This patch gives those owners the ability to also approve the unit tests
which cover their owned areas.

BUG=876133

Change-Id: Id34003749c63fd044716f31907f91a84c2c264cc
Reviewed-on: https://chromium-review.googlesource.com/1182609Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Chris Blume <cblume@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585191}

Deobfuscation appears to be hanging in ways that cause it to peg
bots' CPUs and kill test runs. This CL temporarily disables it as
a mitigation.

Bug: 876539
Change-Id: I6dced1a4c80e630bb701a17eaa8322450661adc5
Reviewed-on: https://chromium-review.googlesource.com/1185294Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585190}

AttemptsCountBeforeSuccess should be recorded before OnAuthSuccess which
will reset all the unlock attempt.
Also add some vlog for fingerprint unlock.

Bug: 862295
Change-Id: I3bbef2d9a9d8a59058ab074fa4959090325bc7f6
Reviewed-on: https://chromium-review.googlesource.com/1185486
Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585189}

With this change Scenic will be accessible in /svc in the GPU process.

TBR=nasko@chromium.org (trivial change in content/common/BUILD.gn)

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Iacc8f6e11af204ce2ac783a67c6229410c775120
Reviewed-on: https://chromium-review.googlesource.com/1178978
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585188}

../../components/crash/content/app/minidump_with_crashpad_info.cc(142,45):  error: implicit conversion loses integer precision: 'int64_t' (aka 'long long') to 'crash_reporter::(anonymous namespace)::FilePosition' (aka 'unsigned int') [-Werror,-Wshorten-64-to-32]
  FilePosition next_available_byte = file_->Seek(base::File::FROM_END, 0);
               ~~~~~~~~~~~~~~~~~~~   ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~

BUG=588506

Change-Id: Ie5a6d95d459587e88e253ed3b3b35cdd714f2cdb
Reviewed-on: https://chromium-review.googlesource.com/1184339Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Will Harris <wfh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585187}

This CL prevents the following messages from being sent to renderers when surface
sync is enabled:

FrameMsg_FirstSurfaceActivation
BrowserPluginMsg_FirstSurfaceActivation

This is because the extra IPC for updating is not needed anymore after fallback surfaces
are fully optional.

Bug: 870452
Change-Id: I4a96fc759e230031d82ed4feb3c7c5697ca3c3c8
TBR: tsepez@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1183588
Commit-Queue: Andre Kaba <akaba@google.com>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585186}

https://pdfium.googlesource.com/pdfium.git/+log/3caad939aead..03fdf3a2b5ee


git log 3caad939aead..03fdf3a2b5ee --date=short --no-merges --format='%ad %ae %s'
2018-08-22 thestig@chromium.org Mark CFX_XMLNode pointers as const in various places.
2018-08-22 thestig@chromium.org Add GetLowerCaseElementAttributeOrDefault() helper function.
2018-08-22 npm@chromium.org Fix integer overflow in CPDF_CIDFont::GetCharBBox
2018-08-22 thestig@chromium.org Simplify GetEmbeddedObj() methods.


Created with:
  gclient setdep -r src/third_party/pdfium@03fdf3a2b5ee

The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:875924
TBR=dsinclair@chromium.org

Change-Id: I409a99ffb7e201035f4134f8d951c9a807831189
Reviewed-on: https://chromium-review.googlesource.com/1184868Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#585185}

This is to support mojo sockets. With mojo sockets, we always try to read from
mojo data pipes, and we need a way to cancel pending reads without having
buffered data in socket subclasses.

Bug: 875855
Change-Id: I1b34c15ff9b848517185caa222cce9109497b78e
Reviewed-on: https://chromium-review.googlesource.com/1183996
Commit-Queue: Helen Li <xunjieli@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585184}

They will also be needed for the pop-up transport selection menu.

This CL also removes the duplicate AuthenticatorTransport enum, and
makes it just an alias for device::FidoTransportProtocol.

Bug: 849323
Change-Id: I5b9e6c38de71e4b4139d6101acd898daaf86b707
Reviewed-on: https://chromium-review.googlesource.com/1185181
Commit-Queue: Balazs Engedy <engedy@chromium.org>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585183}

It's "Certificate Error Assistant" now.

Bug: 863762
Change-Id: I1b853703df5f2f630cd4300c2c77a417028ab7d7
Reviewed-on: https://chromium-review.googlesource.com/1180424Reviewed-by: Carlos IL <carlosil@chromium.org>
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Commit-Queue: Mustafa Emre Acer <meacer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585182}

Clarified existing behavior in preparation for mass refactor.

R=fdoray@chromium.org

Bug: 874080
Change-Id: If495bbfa2f412ee1505d1f977c7dfc8d14f037db
Reviewed-on: https://chromium-review.googlesource.com/1185201
Commit-Queue: Gabriel Charette <gab@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585181}

https://skia.googlesource.com/skia.git/+log/e6ab998bc2e6..4a0ba280b94c


git log e6ab998bc2e6..4a0ba280b94c --date=short --no-merges --format='%ad %ae %s'
2018-08-22 scroggo@google.com Fix flutter build
2018-08-22 robertphillips@google.com Remove occluder parameter from SkMaskFilter::MakeBlur factory
2018-08-22 bsalomon@google.com Reland "Add ability to specify different GP textures for each mesh in a draw."
2018-08-22 brianosman@google.com Remove sRGB pixel config code from DDL tests
2018-08-22 benjaminwagner@google.com Add iOS Metal Test job.
2018-08-22 nigeltao@google.com Rename SkCodec::kNone to SkCodec::kNoFrame
2018-08-22 nigeltao@google.com Add more comments to SkCodec::getRepetitionCount


Created with:
  gclient setdep -r src/third_party/skia@4a0ba280b94c

The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=fmalita@chromium.org

Change-Id: I832a06b61f42ab2f4ac0ea8eeaab7f00c7a8d66c
Reviewed-on: https://chromium-review.googlesource.com/1184867Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#585180}

../..\mojo/core/ports/event.h(131,42):  error: implicit conversion loses integer precision: 'const uint64_t' (aka 'const unsigned long long') to 'uint32_t' (aka 'unsigned int') [-Werror,-Wshorten-64-to-32]
  uint32_t sequence_num() const { return sequence_num_; }
                                  ~~~~~~ ^~~~~~~~~~~~~

../../mojo/public/cpp/bindings/lib/message_dumper.cc(69,46):  error: implicit conversion loses integer precision: 'uint64_t' (aka 'unsigned long long') to 'uint32_t' (aka 'unsigned int') [-Werror,-Wshorten-64-to-32]
MessageDumper::MessageDumper() : identifier_(base::RandUint64()) {}
                                            ~^~~~~~~~~~~~~~~~~~

../../mojo/public/cpp/bindings/lib/message_dumper.cc(74,48):  error: implicit conversion loses integer precision: 'size_t' (aka 'unsigned long long') to 'uint32_t' (aka 'unsigned int') [-Werror,-Wshorten-64-to-32]
  MessageEntry entry(message->data(), message->data_num_bytes(),
               ~~~~~                  ~~~~~~~~~^~~~~~~~~~~~~~~~

BUG=588506

Change-Id: Iae866dfe8b15023c966841d623968d224fec6ab4
Reviewed-on: https://chromium-review.googlesource.com/1184379Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Will Harris <wfh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585179}

This is a refactoring CL to pave the way for a TouchEventAckQueue
implementation that will allow us to ensure the ordering of acks
when multiple renderers are present, i.e. OOPIF subframes exist.

Bug: 848050
Change-Id: Ib446486ac6521c66cbfe3f552355e597107070db
Reviewed-on: https://chromium-review.googlesource.com/1181765Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Commit-Queue: James MacLean <wjmaclean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585178}

If the background task scheduler started Chrome it could happen that we
wanted to schedule a component update before the update callback was
set. This caused seg faults. Instead, add a delay to give enough time
for all components to finish registering and set the update callback. If
there is still no update callback set finish the task and retry after a
default delay.

Bug: 867354, 876424
Change-Id: I3ef8277a4e45384531a08652d5534831f8fd2056
Reviewed-on: https://chromium-review.googlesource.com/1183961Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: Sorin Jianu <sorin@chromium.org>
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585177}

This should alleviate flaky errors when translating on iOS.

When translate is tapped, translate_ios.js polls translate.js to wait
for translate element ready and then later polls again to wait for the
translation result. Polling can often time out due to network slowness.

Bug: 869729, 876425
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I237a02bf42fe09af30dab4579c19c32cf1b0edad
Reviewed-on: https://chromium-review.googlesource.com/1178691Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Hiroshi Ichikawa <ichikawa@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: John Wu <jzw@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#584549}
Reviewed-on: https://chromium-review.googlesource.com/1184102
Cr-Commit-Position: refs/heads/master@{#585176}

This patch combines three classes into one with two constructors. This is
in preparation for using ContentsProperties instead of a specific contents properties'
clip. There are situations where we do want only the clip and only if the
contents properties' clip is different from local border box properties clip,
so that's left for a follow-up patch.

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I2ed2f0c45918c8f1d79db054ef975234e46821ea
Reviewed-on: https://chromium-review.googlesource.com/1171674Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585175}

This CL adds a mojo interface to initialize the portal which creates
a WebContents on the browser process.

Bug: 865565
Change-Id: Ib28d2a720ab02e9d41f44e2b5a36d5248a248c11
Reviewed-on: https://chromium-review.googlesource.com/1178574Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Commit-Queue: Lucas Gadani <lfg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585174}

Dice Milestone 3 has now be launched, and Milestone 2 is no longer needed.

TBR=ellyjones

Bug: 777774
Change-Id: Id82bb13fbd277a014bb3fb8961d8d98eecb32124
Reviewed-on: https://chromium-review.googlesource.com/1183662
Commit-Queue: David Roger <droger@chromium.org>
Reviewed-by: Thomas Tangl <tangltom@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585173}

Implement Journal storage JNI call from java bridge to C++ bridge.
C++ bridge empty now, will implement C++ bridge in separate CL. Also,
will delete old storage stuff like bridge, database in separate CL as
well.

Bug:875902

Change-Id: Ia8adf37bd6bf7f6d5b47f8258cf886617930bb69
Reviewed-on: https://chromium-review.googlesource.com/1180727
Commit-Queue: Gang Wu <gangwu@chromium.org>
Reviewed-by: Filip Gorski <fgorski@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585172}

LayoutMenuList can have an overflow clip, but UpdateLocalBorderBoxContext doesn't
check that, relying on other conditions to check if we need local border box properties.

This patch changes it so that it also explicitly considers existence of the overflow
clip when deciding whether to create local border box properites.

This is needed for us to be able to get the ContentsProperties, which would include
the overflow clip. Existence of ContentsProperties, or our ability to get them,
depends on the existence of the LocalBorderBoxProperties.

R=pdr@chromium.org, chrishtr@chromium.org

Bug: 870521
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I1a6c08f94c3066c7524b2557b4f884e3fc7dd61a
Reviewed-on: https://chromium-review.googlesource.com/1183851Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585171}

This interface can be used by chrome embedders to provide additional
scrolling fixes for FullscreenControllerObserver callbacks.

Bug: none
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ie6ce56c484ea7bc5a48a6802b626589d03ccf1cb
Reviewed-on: https://chromium-review.googlesource.com/1184171
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585170}

Bug: 876359
Change-Id: I554cdd9a7124312da670e6d1878b0bcddb2d74f5
Reviewed-on: https://chromium-review.googlesource.com/1183887
Commit-Queue: Jason Roberts <jasonroberts@chromium.org>
Reviewed-by: Peng Huang <penghuang@chromium.org>
Reviewed-by: David Reveman <reveman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585169}