- 03 May, 2018 40 commits
-
-
Antonio Gomes authored
Of the various unittests associated with the migration that were reworked to work with the TestURLLoaderFactory machinery, two particularly became unneeded: - OneGoogleBarFetcherImplTest::SecondRequestOverridesFirst. The test exercised a premise of SimpleURLLoader that says once an instance is deleted its completion call will not be called. - OneGoogleBarFetcherImplTest, HttpErrorIsFatal The latest CL does not distinguish between server and common HTTP errors any more. CL also updates OneGoogleBarFetcherImplTests::thread_bundle_ to initialize with IO_MAINLOOP, so that it accommodates network requests being made on UI threa BUG=773295 Change-Id: I1a186f4067eb64f0e36d1b88ccbe9c8914a67480 Reviewed-on: https://chromium-review.googlesource.com/1031450 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#555724}
-
jonross authored
PushMessagingBrowserTest.UnsubscribeSuccess is flaking on Windows, so I'm disabling it. TBR=peter@chromium.org TEST=PushMessagingBrowserTest.UnsubscribeSuccess Bug: 838759 Change-Id: I7cf36aa034f8666639830a510aa1d18da6189911 Reviewed-on: https://chromium-review.googlesource.com/1042366Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#555723}
-
Alex Newcomer authored
When an event occurs that closes the Context Menu, do not repost the event. This cl also updates a few tests that broke once the change was made. Bug: 826517 Change-Id: I9fa29ab37f55ebbd62ef0764750174db1057043c Reviewed-on: https://chromium-review.googlesource.com/1038757Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#555722}
-
John Budorick authored
TBR=rdevlin.cronin@chromium.org Bug: 839371 Change-Id: I828d3038e4651275905ae82c984bc58d7262917e Reviewed-on: https://chromium-review.googlesource.com/1042367Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#555721}
-
Leonard Grey authored
In https://chromium-review.googlesource.com/c/chromium/src/+/852978, TabWindowController was changed to no longer subclass NSWindowController. But, since many callers assumed that a browser window's window controller was also its delegate, the new window controller proxies NSWindowDelegate methods to the TabWindowController. Unfortunately, it turns out that callers also make assumptions about the delegate, and if we only forward NSWindowDelegate methods, some fall through the cracks. This change removes the NSWindowDelegate check from the forwarding code, to ensure that TabWindowController receives all method calls meant for it. Bug: 835296 Change-Id: Ia16b8018c7c110e44a34b0f4cb1a636a143c3415 Reviewed-on: https://chromium-review.googlesource.com/1040945Reviewed-by:
Sidney San Martín <sdy@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#555720}
-
chaopeng authored
This issue is caused by: 1. When user tap on screen, we receive TapDown, ShowPress, Tap. TapDown and ShowPress will active the tapped element. Then Tap checks the LastShowPressTimeStamp() to stay active or cancel. 2. Each frame has GestureManager and we store LastShowPressTimeStamp() in GestureManager. 3. We check the root frame GestureManager LastShowPressTimeStamp() before hit test so we read the wrong LastShowPressTimeStamp(). In this patch, we move last_show_press_timestamp_ to root frame EventHandler so we don't need to hit test and figure which GestureManager should use. Bug: 714573 Change-Id: I80c75bf2f0493a6cbfd3b24873e1127da4fd7a27 Test: EventHandlerSimTest_TapActiveInFrame Test: Manual test for OOPIF Reviewed-on: https://chromium-review.googlesource.com/1041065Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Jianpeng Chao <chaopeng@chromium.org> Cr-Commit-Position: refs/heads/master@{#555719}
-
Christian Fremerey authored
The API of the video capture service currently depends on a native enum VideoPixelFormat and a struct media.mojom.MailboxVideoFrameData declared in media_types.mojom. This CL breaks this dependency by defining a (non-native) Mojo enum VideoCapturePixelFormat and a struct media.mojom.MailboxBufferHandleSet specifically for the video capture service. This has two benefits: 1.) It makes it clear from the API that the video capture service actually only supports a much more limited set of pixel formats. 2.) It allows the reuse of the API definition in the mojom files in contexts where media/ and type mappings to native enums are not available. In particular, this is the case when trying to use the video capture service API from ChromiumOS. This is purely an interface refactoring. There is no intent for functional change. TBR=xjz@chromium.org Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I418e5bb95bd92da0600afd874b6fde71e982761a Reviewed-on: https://chromium-review.googlesource.com/1026795Reviewed-by:
Christian Fremerey <chfremer@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Commit-Queue: Christian Fremerey <chfremer@chromium.org> Cr-Commit-Position: refs/heads/master@{#555718}
-
Roman Sorokin authored
Problem is gssapi library (which Chrome uses for Kerberos SSO) uses krb5.conf settings. So even if DisableAuthNegotiateCnameLookup is enabled, GSSAPI still does canonicalization internally. This can be toggled in krb5.conf by setting dns_canonicalize_hostname, so this CL modifies the krb5.conf we get from authpolicy accordingly. It also sets reverse dns (rdns) to false, because Chrome does not do reverse search BUG=chromium:815158 TEST=ExistingUserControllerActiveDirectoryTest.PolicyChangeTriggersFileUpdate Change-Id: I418ed028d1bc4ba58883b01fb9f3c314fbed7c1c Reviewed-on: https://chromium-review.googlesource.com/1016802 Commit-Queue: Roman Sorokin <rsorokin@chromium.org> Reviewed-by:
Lutz Justen <ljusten@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#555717}
-
Max Moroz authored
This reverts commit d6e2784f. Reason for revert: llvm-cov is also using 'coverage' directory, so this change doesn't work well: https://github.com/llvm-mirror/llvm/blob/master/tools/llvm-cov/SourceCoverageView.h#L97 Original change's description: > [Code Coverage] Use platform name for the root directory instead of 'coverage'. > > That single-line change would be very helpful for hosting reports at GCS, as it > provides a multi-platform dir structure for free. > > Bug: 836663 > Change-Id: Ic9a984360cb352a23ace780d4aa600084be98a36 > Reviewed-on: https://chromium-review.googlesource.com/1041282 > Reviewed-by: Abhishek Arya <inferno@chromium.org> > Commit-Queue: Abhishek Arya <inferno@chromium.org> > Cr-Commit-Position: refs/heads/master@{#555664} TBR=inferno@chromium.org,mmoroz@chromium.org,liaoyuke@chromium.org Change-Id: I9812e8dde9ed121a4b379fef336336b7f62508c6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 836663 Reviewed-on: https://chromium-review.googlesource.com/1042465Reviewed-by:
Max Moroz <mmoroz@chromium.org> Commit-Queue: Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#555716}
-
Charlie Harrison authored
This refactors main.cc into a class RulesetConverter to make things a bit more testable. This CL only contains one behavior change: instead of using a colon separated list of directories as input, we instead use a comma separated list. Paths in windows frequently have colons in them :) Bug: 833419 Change-Id: I51c3b9c2b8ac6ce93a193d07f8bafaff897f3fdf Reviewed-on: https://chromium-review.googlesource.com/1036243 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#555715}
-
Jérôme Lebel authored
The tests were broken because UIScrollView doesn't scroll when animated, while WaitUntilConditionOrTimeout() is running. Those tests check if the displayed strings for the user consent are correct. Those tests work only if the user consent scroll view is scrolled to bottom. It was broken for iPhone 5s and SE. To avoid the issue above, this CL finds the first UIScollView in the sign-in screen, and then scrolls it to the bottom without animation (instead of simulating a tap on the More button). Tests broken: crrev.com/c/1010346 Tests disabled: crrev.com/c/1040346 Bug: 839001 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ibb82222275d9d24d7bdfbb6b63111e69651cbe7a Reviewed-on: https://chromium-review.googlesource.com/1041085Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#555714}
-
https://webrtc.googlesource.com/src.git/+log/2e28edaa8a25..01042067beb1 $ git log 2e28edaa8..01042067b --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=chromium:838854,chromium:None The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ie4430832d12b820c23370ae2ecc2045f0b9e0a28 Reviewed-on: https://chromium-review.googlesource.com/1042026 Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#555713}
-
Elly Fong-Jones authored
TBR=jbudorick@chromium.org Bug: 828031 Change-Id: I30eec44d2abf35a594874a2e20a0d6906a1a92f7 Reviewed-on: https://chromium-review.googlesource.com/1042206Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
-
Helen Li authored
This CSP test fails when network service flag is on. wpt/content-security-policy/inside-worker/dedicated-inheritance.html TBR=jam@chromium.org Bug: 729849 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I5488b1eb50040792f84d0cbf9efd3c1d68fcaf2d Reviewed-on: https://chromium-review.googlesource.com/1041405 Commit-Queue: Helen Li <xunjieli@chromium.org> Reviewed-by:
Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#555711}
-
Marc Treib authored
TBR=riajiang@chromium.org Bug: 838835 Change-Id: Ie69310cde0d51472d3446c57b8bbd66bc703a602 Reviewed-on: https://chromium-review.googlesource.com/1041957Reviewed-by:
-
Samuel Huang authored
- Move bucket to gs://chromium-binary-patching/zucchini-testdata, which is more specific, and has a manifest file: gsutil cat gs://chromium-binary-patching/zucchini_testdata/manifest.json - Old file copies are kept in root as legacy. - Move destination path to Zucchini root, and make it recursively look for .sha1 files. The reaosn is that we'll add fuzzing data in a different directory, and want to use the same hook name. Details: Change-Id: Ie96cb99de9e0727d3cb6dfb0afa25c08cf4f31c3 Reviewed-on: https://chromium-review.googlesource.com/1038047Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#555709}
-
Devlin Cronin authored
The ExtensionFunction::GetAssociatedWebContentsDeprecated() method is unpredictable and can return surprising values in certain circumstances. It is deprecated and should be removed to ensure that callers are using the WebContents they expect. Update the passwordsPrivate API to use GetSenderWebContents() instead. Bug: 461394 Change-Id: I24b75989786d06aa14a64f403d134e293eb9902a Reviewed-on: https://chromium-review.googlesource.com/1040530Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#555708}
-
jonross authored
BrowserSideFlingBrowserTest.AutoscrollFling is flaking on ChromeOS, so I'm disabling it. TBR=dtapuska@chromium.org TEST=BrowserSideFlingBrowserTest.AutoscrollFling Bug: 838769 Change-Id: I1d8bc6ed78c9e15258ff90ccef9535e42d8189cf Reviewed-on: https://chromium-review.googlesource.com/1042029Reviewed-by:
-
Sigurdur Asgeirsson authored
This is in preparation for adding and testing memory measurement. Bug: 755840 Change-Id: I2883368c48cc34b0ec10d247eaf374063c4fcf18 Reviewed-on: https://chromium-review.googlesource.com/1037244 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#555706}
-
Sigurdur Asgeirsson authored
Bug: 755840 Change-Id: I099a7fc07f057e686a49b3b245c5b1095e2ec7c7 Reviewed-on: https://chromium-review.googlesource.com/1035535Reviewed-by:
-
Helen Li authored
The field is unused. Bug: 837333 Change-Id: I1179efd6af649d52d43f041fc7409125a7df7b1d Reviewed-on: https://chromium-review.googlesource.com/1040207Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#555704}
-
Helen Li authored
Bug: 837333 Change-Id: Idf0f6723d4bc0c771bd6a415bff2269fdef40e06 Reviewed-on: https://chromium-review.googlesource.com/1040206Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#555703}
-
Farah Charab authored
Modify the task queue selection logic to only increment the starvation scores when tasks of corresponding priorities are present. Change-Id: Ia2a290691ba29b5f0077e0a007348152fcc4e66e Reviewed-on: https://chromium-review.googlesource.com/1027835 Commit-Queue: Farah Charab <farahcharab@chromium.org> Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#555702}
-
Guido Urdaneta authored
This change is in anticipation to add full support for the constrainable groupId property in MediaStreamTrack.getSettings() and MediaDevices.getUserMedia(). See follow-up CL: crrev.com/c/1019323 Drive-by: Fix minor whitespace/style issues. Bug: 833333 Change-Id: I821d2e34f7684dd1c0f8692e6219360cc1a77f66 Reviewed-on: https://chromium-review.googlesource.com/1021772 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#555701}
-
Rayan Kanso authored
Move UI Title to its own storage entry. Allows for faster title updates without having to load/store the entire metadata proto. Also add number of fetch requests to the metadata proto, since the only way to currently query that would require 3 storage accesses (num_pending + num_active + num_completed). Bug: 826257 Change-Id: Iafee5e71f5f5a6d626b626d888a6004a6c249370 Reviewed-on: https://chromium-review.googlesource.com/1030630 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#555700}
-
Marc Treib authored
It occasionally crashes instead of timing out on Linux, Windows, and Mac (all debug). Flakiness link for convenience: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=virtual/outofblink-cors/http/tests/xmlhttprequest/redirect-cross-origin-post.html TBR=toyoshim@chromium.org Bug: 736308 Change-Id: If30ac47f075df6766b4e14221db4c9d75f195048 Reviewed-on: https://chromium-review.googlesource.com/1041953Reviewed-by:
-
Michael Lippautz authored
Includes incremental garbage collection infrastructure in regular builds. Does not enable incremental marking at runtime! This CL may cause throughput regressions and is an attempt to collect a broad range of potential performance issues. Bug: chromium:757440 Change-Id: If4d91be2eb325417736a38e27c481ab23ce7a0e9 Reviewed-on: https://chromium-review.googlesource.com/1041986Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#555698}
-
Guido Urdaneta authored
The video-capture subsystem currently does not support the concept of group IDs, which exists in the MediaStreams spec. To support video group IDs, we use a heuristic that finds associations between video and audio devices. Prior to this CL, this heuristic was used to patch results requested by the MediaDevices.enumerateDevices() JavaScript function, but low-level enumerations used by other parts of Chrome may have kept video group IDs empty. To ensure that device associations are found, low-level video enumerations will also trigger a possibly cached audio enumeration and the heuristic is run after both results are obtained. This CL is preparation for full support for the groupId constrainable property in getUserMedia() and related MediaStreamTrack methods. Bug: 834281 Change-Id: I428c9a2cb65f755cdee366d6e43e4fe9ad898e20 Reviewed-on: https://chromium-review.googlesource.com/1019245 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Tommi <tommi@chromium.org> Cr-Commit-Position: refs/heads/master@{#555697}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 2b5594d0. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/16750 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=kereliuk No-Export: true Change-Id: I82b769eb76ee1b5162be57bc41cedc2cb55f7f1d Reviewed-on: https://chromium-review.googlesource.com/1041555 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#555696}
-
Marc Treib authored
This reverts commit bde742c2. Reason for revert: LayeredAPITest.GetSourceText is failing on Android CFI and WebKit Android (Nexus4): https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Android%20%28Nexus4%29/?limit=100 https://ci.chromium.org/buildbot/chromium.memory/Android%20CFI/ Original change's description: > [Layered API] Implement Layered API infrastructure behind a flag > > This CL > 1. Maps std:x|y URLs to std:x (according to the draft spec [1]), > 2. Then maps to std-internal://x/index.js (not spec'ed [2]) > in GetInternalURL(), > 3. Then retrieves and serves the script contents for std-internal: > URLs in GetSourceText() using ui::ResourceBundle() > from blink_resources.pak. > > The source JavaScript files for Layered APIs are placed under > third_party/blink/renderer/core/script/resources/layered_api > and bundled into blink_resources.pak. > > This CL introduces std: and std-internal: schemes that are used in Blink side > (std: is user-facing while std-internal: is mostly invisible for users) > but not outside Blink. > > [1] Spec: > https://github.com/drufball/layered-apis/blob/master/spec.md > [2] Implementation design doc: > https://docs.google.com/document/d/1V-WaCZQbBcQJRSYSYBb8Y6p0DOdDpiNDSmD41ui_73s/edit > > Bug: 829084 > Change-Id: I61fc0a2f17d937db6e859303ab8a84e4b2b87850 > Reviewed-on: https://chromium-review.googlesource.com/1013321 > Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Kouhei Ueno <kouhei@chromium.org> > Cr-Commit-Position: refs/heads/master@{#555524} TBR=kinuko@chromium.org,thakis@chromium.org,hiroshige@chromium.org,kouhei@chromium.org Change-Id: I6e13216a99d4ed199f9a52d370f3cad35900f408 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 829084 Reviewed-on: https://chromium-review.googlesource.com/1042065Reviewed-by:
-
Christos Froussios authored
LoginDatabase uses encryption everywhere but Linux. In order to migrate Chrome to use encryption on Linux too, LoginDatabase needs to support both modes during the migration phase. Bug: 829857 Change-Id: I975114f6848923f47bc1a34e7b8cd16480dec0dc Reviewed-on: https://chromium-review.googlesource.com/1019204Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Christos Froussios <cfroussios@chromium.org> Cr-Commit-Position: refs/heads/master@{#555694}
-
Rune Lillesveen authored
Relying on normal layout for widths works. Gets rid of mutable style access for input placeholders. TEST=fast/forms Bug: 813068 Change-Id: Ie8501137f9c9ed5ef04505ca5147ad691f0cfaed Reviewed-on: https://chromium-review.googlesource.com/1039785Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#555693}
-
https://webrtc.googlesource.com/src.git/+log/6f7e6d6ff353..2e28edaa8a25 $ git log 6f7e6d6ff..2e28edaa8 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=chromium:838854 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I9c256dab6bd3be85a2bacaffbf8be217d6a6ca13 Reviewed-on: https://chromium-review.googlesource.com/1041806 Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
-
Marc Treib authored
This reverts commit 6e6741a1. Reason for revert: DeclarativeNetRequestBrowserTest_Packed.PageWhitelistingAPI became flaky on ChromeOS debug and ASan/LSan: https://ci.chromium.org/buildbot/chromium.memory/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/?limit=100 https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-dbg/?limit=100 https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=DeclarativeNetRequestBrowserTest_Packed.*PageWhitelist Original change's description: > DNR tests: Use ExtensionTestMessageListener to detect background page load. > > This CL changes declarative net request browsertests to use > ExtensionTestMessageListener to detect background page load instead of relying > on the notification system, which is deprecated. Also, add a > extension_id_for_message() method to ExtensionTestMessageListener. This is > useful to detect the extension id, the message was received from. > > BUG=696822 > > Change-Id: Ie1fc74d547d4ee417c5f6b2d5a7082adbc9d164a > Reviewed-on: https://chromium-review.googlesource.com/1034155 > Commit-Queue: Karan Bhatia <karandeepb@chromium.org> > Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#555005} TBR=lazyboy@chromium.org,karandeepb@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 696822, 838536 Change-Id: Ic714040d602db9e0a4abb266c0f84adb10029625 Reviewed-on: https://chromium-review.googlesource.com/1041946 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
-
Mounir Lamouri authored
It's now enabled by default on trunk. Bug: None Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Ia03fccccc09b591e61e663f87efdc9246e26066c Reviewed-on: https://chromium-review.googlesource.com/1039749 Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#555690}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/6a74bf33..fc1a04fd Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I4f3185d713c3808869fdfccb7ff6b8879875f02f Reviewed-on: https://chromium-review.googlesource.com/1041551Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#555689}
-
Mounir Lamouri authored
Bug: 839332 Change-Id: I07e98cae8763a0b6075eb59f6bf559aa0c244b85 Reviewed-on: https://chromium-review.googlesource.com/1041930Reviewed-by:
-
Guido Urdaneta authored
This is a better match for the spec, which says that group IDs are browsing-session unique, not frame-unique. This CL also reorganizes code in preparation for better support for the groupId constrainable property. Drive-by: Some minor fixes in WebRtcGetMediaDevicesBrowserTest. Bug: 833333 Change-Id: I4b7309fafc1f2c336bbe0d61f736992aa5d7f36e Reviewed-on: https://chromium-review.googlesource.com/1015560 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#555687}
-
Jérôme Lebel authored
Moving all files related to unified consent into: ios/chrome/browser/ui/authentication/unified_consent/ Original patch: crrev.com/c/1039187 Fix in Patchset 4 Reverted with: crrev.com/c/1039745 Bug: 827072 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I053db355aee79630eb4d97812c14ffede1241972 Reviewed-on: https://chromium-review.googlesource.com/1041926Reviewed-by:
-
Xiaohan Wang authored
This will prevent decoding error caused by destroyed MediaService during page navigation. See Bug for more details. Bug: 821171 Change-Id: I515fe3731ced2c38c6ccbb364d05a6122c9a4461 Reviewed-on: https://chromium-review.googlesource.com/1018821 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#555685}
-
