GitLab

This is useful for files that are only read by the linker, such as
orderfiles. We were normally getting this right in the case where
the target contained at least one source file, as the output file
would transitively depend on the inputs via the source files, but if
the target only contained dependencies on other targets, the inputs
wouldn't be depended on at all.

Bug: 835622
Change-Id: Ic7fb39caeacd4698b7ec6cfb0cb583a429a117dd
Reviewed-on: https://chromium-review.googlesource.com/1041274Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Peter Collingbourne <pcc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555931}

In the case, the fullscreen strategy is used for scanning out fullscreen
scaled buffers (i.e. fullscreen youtube), instead of single on top strategy.
It makes the case not submit the unnecessary primary plane to display engine.

TEST=Youtube https://youtu.be/w8RN8T13rjE on soraka
BUG=683347

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I8c82c7dd6182c34c0420ff4819ba37d5881039f0
Reviewed-on: https://chromium-review.googlesource.com/656222
Commit-Queue: Dongseong Hwang <dongseong.hwang@intel.com>
Reviewed-by: Kristian H. Kristensen <hoegsberg@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: Dongseong Hwang <dongseong.hwang@intel.com>
Cr-Commit-Position: refs/heads/master@{#555930}

Bug: 832908
Change-Id: Ibf6b40fc043dfded18d500d71fa5f5316d1a31af
Reviewed-on: https://chromium-review.googlesource.com/1042219Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Commit-Queue: Maks Orlovich <morlovich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555929}

So calling it should be a noop, not an error.

Change-Id: Id92d427c1e5e9f5795881de30f322a4556f6ade1
Reviewed-on: https://chromium-review.googlesource.com/1042958Reviewed-by: Bill Orr <billorr@chromium.org>
Commit-Queue: Fernando Serboncini <fserb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555928}

This reverts commit 66531351.

Reason for revert: broke webgl_conformance_gl_passthrough_tests on all Linux bots; see https://bugs.chromium.org/p/chromium/issues/detail?id=776877#c31 .

Original change's description:
> Turn on presentation feedback for Linux
> 
> Bug: 776877
> Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
> Change-Id: I9d9590a5174db94392a447ab280e9218b37c2958
> Reviewed-on: https://chromium-review.googlesource.com/1040725
> Reviewed-by: Antoine Labour <piman@chromium.org>
> Commit-Queue: Peng Huang <penghuang@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#555782}

TBR=penghuang@chromium.org,piman@chromium.org

Change-Id: Ib7da20d9bfb7729a6afadf075c7b99a58131014a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 776877
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/1043227Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555927}

MP4 'cbcs' boxes specify an encryption scheme when used with encrypted
media. Although the current CDMs don't support this scheme, it will in
the future so enable desktop builds to parse these headers and pass it
to the CDM.

BUG=658026
TEST=existing 'cbcs' browser_tests still pass

Change-Id: I6dc6c1596cf6bd1ecd776877fe45b5908fea4dce
Reviewed-on: https://chromium-review.googlesource.com/1041266
Commit-Queue: John Rummell <jrummell@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555926}

Bug: None
Test: No visible change expected.
Change-Id: I40f440cc25f8ab447a7a5c3cef84d76805d64537
Reviewed-on: https://chromium-review.googlesource.com/1040879Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555925}

Bug: 721408
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Ifd9be7ae953b43bdeca09ec7f2c8dfa51dcbe7d1
Reviewed-on: https://chromium-review.googlesource.com/1042857
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555924}

BUG=762641
TBR=warx@google.com

Change-Id: Ic1beb219a4494c552daa3835dc43a228be4a6e06
Reviewed-on: https://chromium-review.googlesource.com/1043028
Commit-Queue: ChromeOS Commit Bot <chromeos-commit-bot@chromium.org>
Reviewed-by: ChromeOS Commit Bot <chromeos-commit-bot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555923}

Add a AddEntriesMessage helper to convert the JSON dictionary value of
the addEntries command to an AddEntriesMessage |message|.

In the addEntries command, use that converter to extract the |message|
and also FAIL if the message.volume is an invalid volume type.

Covered by existing FileManager browser tests.

Bug: 833834
Change-Id: Ib7ec56fee7c5b4857ccdfb0155a414430db73e97
Reviewed-on: https://chromium-review.googlesource.com/1042125Reviewed-by: Noel Gordon <noel@chromium.org>
Reviewed-by: Stuart Langley <slangley@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555922}

Test: browser_tests --gtest_filter=ArcVoiceInteractionArcHomeServiceTest.*
Change-Id: I25e45f2663767d5d7ef20bd8bb5637b077c6eb44
Reviewed-on: https://chromium-review.googlesource.com/1014464
Commit-Queue: Muyuan Li <muyuanli@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555921}

BUG=838398

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr
Change-Id: I0cf62fc688cdcd8b05320f1eb96543c50a8fca51
Reviewed-on: https://chromium-review.googlesource.com/1036249
Commit-Queue: Avi Drissman <avi@chromium.org>
Reviewed-by: Drew Wilson <atwilson@chromium.org>
Reviewed-by: Leonard Grey <lgrey@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555920}

Bug: 836391, 832184
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I1ae3418e5b153a89b6d6bd5169365cc50bab7a15
Reviewed-on: https://chromium-review.googlesource.com/1040273Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555919}

In some cases the Metadata for a RWHVA is set before VR code calls
SetIsInVr on the RWHVA, so we miss the initial top controls update.

(The only reason we care about VR-ness when updating the frame metadata
is that sending the initial top controls update breaks interstitials)

Bug: 837807
Change-Id: Ic108fa324725e7c126c9f721c27e4c5f99521af6
Reviewed-on: https://chromium-review.googlesource.com/1042500Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555918}

This is a reland of 85d8d125

Original change's description:
> Stop using RenderedPosition in VisibleUnitsLine
>
> VisibleUnitsLine uses RenderedPosition instances without using
> the bidi-related functionalities.
>
> Since RenderedPosition is a wrapper of InlineBoxPosition with bidi
> utility functions added, this patch changes VisibleUnitsLine to
> use InlineBoxPosition directly for simplicity.
>
> Bug: 822575
> Change-Id: I158ddfb3dec1ead3f8b66e1255f3465f3f0353a2
> Reviewed-on: https://chromium-review.googlesource.com/1024645
> Reviewed-by: Yoichi Osato <yoichio@chromium.org>
> Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#553008}

Tbr: yosin@chromium.org, yoichio@chromium.org
Bug: 822575
Change-Id: I1fd854234f2c9265a758578023e07e220e63b86a
Reviewed-on: https://chromium-review.googlesource.com/1042615Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555917}

This way it can be responsible for various interfaces that need to be
registered. This also makes it easier to use in consuming code. I
deleted from the README with the expectation that I'll update it later
on once things are further along.

BUG=837689
TEST=none

Change-Id: I07f8f2902d02a6f2a8183bf141855494661a33d3
Reviewed-on: https://chromium-review.googlesource.com/1042879
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555916}

BUG=838858

Change-Id: Ibbdf3500626a11b7c73c179f582aaee3f452498f
Reviewed-on: https://chromium-review.googlesource.com/1043259Reviewed-by: Peter Collingbourne <pcc@chromium.org>
Commit-Queue: Peter Collingbourne <pcc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555915}

This was suggested by dcheng in
https://chromium-review.googlesource.com/c/chromium/src/+/1038808.

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I4e9de0aaf4d126de446b9134c7d1e6062d397385
Reviewed-on: https://chromium-review.googlesource.com/1041189Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Johannes Henkel <johannes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555914}

BUG=839362,838785

Change-Id: I09528458d875c93e7c821c7789fc013f3f836b0a
Reviewed-on: https://chromium-review.googlesource.com/1043283Reviewed-by: Peter Collingbourne <pcc@chromium.org>
Commit-Queue: Peter Collingbourne <pcc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555913}

The API of video_capture.mojom.DeviceFactory allows clients to register virtual
video capture devices which use shared memory buffers for transporting frames
from producer to consumers. This CL expands the API with a second type of
virtual video capture device, which is fed with textures (via MailboxHolder),
which are subsequently passed down all the way to the consumers.

This allows for displaying frames fed into such devices without the frame data
having to be moved/copied out of the GPU memory/context.

Design Doc: https://docs.google.com/document/d/1Vt8ME9foAR7vs9azwTP0mAQYUxAEbA1SOQ7hzrcXxP8/edit?usp=sharing

      virtual devices. An integration test has already been written and will be
      put up for review in the next CL of the series.

Bug: 834478
Test: Note, that this cannot be tested manually, since there is no UI for adding
Change-Id: I3a031fe849aa3eb69ce0a429b2ea803ae1855a2b
Reviewed-on: https://chromium-review.googlesource.com/1028582
Commit-Queue: Christian Fremerey <chfremer@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Emircan Uysaler <emircan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555912}

This patch is for refactoring aria-haspopup following latest spec.

Changed the value type of aria-haspopup from boolean
to token in ARIA 1.1 [1].
Also, the implicit value for role combobox was changed
from true to listbox.

Supported values are :
- true
- false (default)
- menu
- listbox
- tree
- grid
- dialog

We expose both of "HASPOPUP" state and "haspopup:" values
for backwards compatibility.

[1] https://www.w3.org/WAI/ARIA/wiki/ARIA_1.1_Changes

Bug: 740137
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ib4988026c8728f64dfe4b30e842ef68620f093a5
Reviewed-on: https://chromium-review.googlesource.com/896672
Commit-Queue: DongJun Kim <djmix.kim@samsung.com>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Keishi Hattori <keishi@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555911}

This wires up text query functionality. Note that the bubble this view
is housed in is InActive when shown and DialogPlate does not yet request
focus on its textfield. So the user must activate the widget and focus
the textfield manually.

See bug for demo.

Bug: b:79108829
Change-Id: I55a48076208b967031f48d6693bea2e8125c3641
Reviewed-on: https://chromium-review.googlesource.com/1040532
Commit-Queue: David Black <dmblack@google.com>
Reviewed-by: Tao Wu <wutao@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555910}

This CL adds a warn-before-quitting flag.  When enabled, pressing Ctrl+Shift+Q
will show a bubble asking to continue holding the shortcut to quit.  Pressing
the shortcut a second time while the bubble is showing will also confirm the
quit.

R=sky
BUG=243164

Change-Id: I97c4dc37cb5107fde975a4162f349e1ea5337b5d
Reviewed-on: https://chromium-review.googlesource.com/1031097Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555909}

This is a first step towards moving BrowserFrameHeaderAsh into
//ash/public and making it useable both in Ash (for Mash) and Chrome
(for classic).

Bug: 836992
Change-Id: I76109ef3949f803e87c153008c0bf462e8228492
Reviewed-on: https://chromium-review.googlesource.com/1042786
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555908}

FileManagerBrowserTest is a parametric test: none of the other browser
tests are (Gallery, VideoPlayer, AudioPlayer).

Having the Param postfix in the getter names is a leftover from a time
when there was only FileManagerBrowserTest. Remove the Param postfix.

Bonus points: the implementation details of the test extension browser
tests is no longer exposed. FileManageBrowserTestBase does not need to
know, nor does it care.

Bug: 833834
Change-Id: I3919b3751122afdccd1f6f0689107ab91440c427
Reviewed-on: https://chromium-review.googlesource.com/1042426Reviewed-by: Stuart Langley <slangley@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555907}

Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester
Change-Id: I264fd1b0fd9275ed36a960dad24ccc048501c4e9
Reviewed-on: https://chromium-review.googlesource.com/1042929
Commit-Queue: Paul Jensen <pauljensen@chromium.org>
Commit-Queue: Andrei Kapishnikov <kapishnikov@chromium.org>
Reviewed-by: Andrei Kapishnikov <kapishnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555906}

Bug: 839445
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I5193b544cc3e6db8d03b40d807c7d7f93dea94a5
Reviewed-on: https://chromium-review.googlesource.com/1043267Reviewed-by: Mohammad Refaat <mrefaat@chromium.org>
Reviewed-by: Peter Lee <pkl@chromium.org>
Commit-Queue: Daniel Blakemore <danblakemore@google.com>
Cr-Commit-Position: refs/heads/master@{#555905}

Currently, we only set WindowEventTarget to DirectManipulationHelper
when receive DM_POINTERHITTEST. But the crash shows OnContentUpdate
may come before DM_POINTERHITTEST. To prevent the crash we set the
WindowEventTarget when DirectManipulationHelper create.

Bug: 839338
Change-Id: I2921277178771f9124a37325a8dff47196500322
Reviewed-on: https://chromium-review.googlesource.com/1042381Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Jianpeng Chao <chaopeng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555904}

Bug:833964

Change-Id: Ia365a3fa7aba1bedd57d38ff392a5663cd0d15c7
Reviewed-on: https://chromium-review.googlesource.com/1043086Reviewed-by: Filip Gorski <fgorski@chromium.org>
Commit-Queue: Patrick Noland <pnoland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555903}

It appears like calling ResetTimeForTesting is not actually needed for
this test to pass. Since it is causing flake due to the double/TimeTick
round-trips (see bug), just remove it.

Bug: 838676
Change-Id: Ice3e2c88e3afbdf07c52abfb8bffc9d8e0d0c8b1
Reviewed-on: https://chromium-review.googlesource.com/1042380Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555902}

This class will be used to forward feature usage events to the site
characteristics database.

Bug: 773382
Change-Id: Ibe7197a44c68f231c7aea61c85fe2ba77c3d5076
Reviewed-on: https://chromium-review.googlesource.com/1042906
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555901}

These commands create then mount fake USB and MTP volumes for testing.
Add ASSERTs that Mount() calls on these fake volumes succeeds in test.

No change in behavior, no new tests.

Bug: 833834
Change-Id: I49c9a21b629cdb6285982d622e1020b6c16dee73
Reviewed-on: https://chromium-review.googlesource.com/1042005Reviewed-by: Stuart Langley <slangley@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555900}

Bring the FakeTestVolume comments up-to-date. Add a private helper for
getting the external mount points to make Mount() simpler.

FakeTestVolume could be used for testing read-only volumes, but is not
currently used for that: make read-only as const bool member for now.

Bug: 833834
Change-Id: I4da213998e224d3b469c8221f6902fb3f8221e25
Reviewed-on: https://chromium-review.googlesource.com/1042425Reviewed-by: Stuart Langley <slangley@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555899}

The spec is here:
https://drafts.csswg.org/css-animations/#interface-animationevent

A layout test is changed to test this API.

Bug: 437132
Change-Id: Ic463b19488271e1caeb78afa6120bb53f7d5e94d
Reviewed-on: https://chromium-review.googlesource.com/1019383Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555898}

Now Search+D, as approved by Chrome UI Review

Bug: 837819
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: If0c9343d95fd8da342df41a7530260455020e4e3
Reviewed-on: https://chromium-review.googlesource.com/1033928Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Zach Helfinstein <zhelfins@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555897}

Minor: the code is similar but was not formatted the same way. Make it
formatted the same way for the reader's sake.

Bug: 833834
Change-Id: I68f8b3b46f7d02c988e59887d1dc30f1284cbb34
Reviewed-on: https://chromium-review.googlesource.com/1042325Reviewed-by: Stuart Langley <slangley@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555896}

For compiler protection in switch statements, etc.

R=khorimoto@chromium.org

Bug: none
Test: none
Change-Id: Icf86013c87d89b233d6bc27646bad8f79830af6e
Reviewed-on: https://chromium-review.googlesource.com/1043098
Commit-Queue: James Hawkins <jhawkins@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555895}

This CL turns removes --enable-raster-decoder and turns on RasterDecoder
whenever --enable-oop-rasterization is passed from the command line
when starting chrome.

This is not yet true for tests. We will still use
RasterImplementationGLES and GLES2Decoder if
attribs.enable_oop_rasterization and attribs.enable_gles2_interface.
This was done to maintain coverage of both RasterImplementationGLES and
RasterImplementation.  I will clean this up in separate CLs as I rip out
OOP-R code from GLES2{Impl,Decoder}.

TBR: achuith@chromium.org, sadrul@chromium.org
Bug: 789238
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I3e0bd4606c70f4bb9c52117c5aa0baa6ded37665
Reviewed-on: https://chromium-review.googlesource.com/1031012
Commit-Queue: Jonathan Backer <backer@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555894}

Minor clickNotificationButton re-org while I was running my ruler over
this code. No change in behavior, no new tests.

Tbr: slangley
Bug: 833834
Change-Id: Ic23e13e89ab0d3a30d17d456c6c12c781fbc02f4
Reviewed-on: https://chromium-review.googlesource.com/1041368
Commit-Queue: Noel Gordon <noel@chromium.org>
Reviewed-by: Stuart Langley <slangley@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555893}

Initially appbar support was added to SettingsRootTableViewController,
as that was the only view controller which needed it.  But now, we
expect to support MDCAppBar in bookmarks screens as well, so this CL
moves it to a common base class.  We follow the pattern set by
CollectionViewController and include an appBarStyle parameter which
determines whether or not an MDCAppBar is created.

BUG=839439,839450,839460

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I057b15113987d91451ca3a104aba95dd17667cda
Reviewed-on: https://chromium-review.googlesource.com/1043006
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555892}