- 17 Jul, 2018 40 commits
-
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/54edfa4e534d..40bacee96a94 git log 54edfa4e534d..40bacee96a94 --date=short --no-merges --format='%ad %ae %s' 2018-07-17 jbudorick@chromium.org Revert "gclient_scm: Use cherry-picking instead of rebasing." Created with: gclient setdep -r src/third_party/depot_tools@40bacee96a94 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:850812 TBR=agable@chromium.org Change-Id: I92f8c9d26defb8aebd679271f50cc2edb74b8768 Reviewed-on: https://chromium-review.googlesource.com/1139675Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#575553}
-
Ian Kilpatrick authored
I remember we had a conversation about this at some stage, when a single NGLineBreaker instance was being re-used for multiple lines, (so we could easily reset the state). It doesn't seem like we'll go back to this (reusing for multiple lines) and removing this seems likes it simplifies a few things. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I48248f3bf871fbb3eda6aaebe0786f7a61d3f390 Reviewed-on: https://chromium-review.googlesource.com/1139104Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#575552}
-
Jiajia Qin authored
This patch uses Platform::ContextType instead of unsigned int as the webgl version type. Meanwhile, a new context type kWebGL2ComputeContextType is added to correspond to the webgl2-compute context. Bug: 859249 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I6b8a19970c33e3a35ba54c38a0e55acccda567e3 Reviewed-on: https://chromium-review.googlesource.com/1136224Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Jiajia Qin <jiajia.qin@intel.com> Cr-Commit-Position: refs/heads/master@{#575551}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/056d811b6a04..4597e0c46fc5 git log 056d811b6a04..4597e0c46fc5 --date=short --no-merges --format='%ad %ae %s' 2018-07-17 buildbot@webrtc.org Roll chromium_revision 6a67eff9..c0988740 (575413:575517) 2018-07-16 jtteh@webrtc.org Revert "Remove RTPVideoHeader::h264() accessors." 2018-07-16 buildbot@webrtc.org Roll chromium_revision 36688868..6a67eff9 (575305:575413) 2018-07-16 jtteh@webrtc.org Revert "Move allocation and rtp conversion logic out of payload router." Created with: gclient setdep -r src/third_party/webrtc@4597e0c46fc5 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:None,chromium:none,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ia7c71c96135c5c392c1e17d36970ced50144de05 Reviewed-on: https://chromium-review.googlesource.com/1139436Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#575550}
-
Lily Houghton authored
NetworkChangeNotifier::IPAddress Observer is being deprecated. This CL migrates DataReductionProxy to use NetworkChangeObserver instead. Bug: 754695 Change-Id: I473ad45e88cff01a9f33a183033a9d86f59aef4e Reviewed-on: https://chromium-review.googlesource.com/1133330Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Lily Houghton <lilyhoughton@chromium.org> Cr-Commit-Position: refs/heads/master@{#575549}
-
Hitoshi Yoshida authored
Updates idl-dictionary-unittest to test the change http://crrev.com/574083 Because we can't test IDL dictionary types directly in JS, we use an interface DictionaryTest as a intermediate path. This CL also updates the behavior of DictionaryTest to be consistent with InternalDictionary. Bug: 855968 Change-Id: I0ad4530a0143185bbf859a0e0b5371e5e0aefa26 Reviewed-on: https://chromium-review.googlesource.com/1136331 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Dominic Farolino <domfarolino@gmail.com> Cr-Commit-Position: refs/heads/master@{#575548}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/0c64e52aea82..9fb90f83997a git log 0c64e52aea82..9fb90f83997a --date=short --no-merges --format='%ad %ae %s' 2018-07-17 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@9fb90f83997a The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=bungeman@chromium.org Change-Id: I41b245545d5c7961fdbfc518009aca08f08491ce Reviewed-on: https://chromium-review.googlesource.com/1139673Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#575547}
-
Eric Willigers authored
Intent to implement: https://groups.google.com/a/chromium.org/d/msg/blink-dev/gXXMY1grZ-o/b0y3ENIaCQAJ This CL implements parsing and serialization for the full spec grammar auto | [ under || [ left | right ] ] The new values left and right are hidden behind an experimental feature flag, TextUnderlinePositionLeftRight. (Support for auto | under has shipped previously.) This CL does not include painting support for the new values. Bug: 313888 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ie1ba7ecb253e8966b0a9d6f0d0b15df310dfa0a1 Reviewed-on: https://chromium-review.googlesource.com/1135109Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#575546}
-
Christian Biesinger authored
This also required adding a check in NGBlockNode::ComputeMinMaxSize for whether we are inside of PerformLayout -- on Mac, we can compute preferred sizes outside of layout; however, we can't do actual layout in that case, so we have to fallback to legacy min/max size in this case (c.f. RenderViewImpl::CheckPreferredSize()) Bug: 635619 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I0caf0c6c79264074ccaf9f45b83a420950dab715 Reviewed-on: https://chromium-review.googlesource.com/1131562 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#575545}
-
Christian Biesinger authored
The length type enum has changed since this code was written. R=tzik@chromium.org Change-Id: I24a294968d3c4157be41e6a597c78cc731fa868d Reviewed-on: https://chromium-review.googlesource.com/1135907Reviewed-by:
Taiju Tsuiki <tzik@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#575544}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/e076a2327f0d..6fb8ba4e8660 git log e076a2327f0d..6fb8ba4e8660 --date=short --no-merges --format='%ad %ae %s' 2018-07-17 jmadill@chromium.org DisplayD3D: Don't release bound texture in restoreLostDevice. 2018-07-16 jmadill@chromium.org Surface: Use ref count for bindTexImage. 2018-07-16 theoking@google.com Vulkan: Fixed improperly set env variable Created with: gclient setdep -r src/third_party/angle@6fb8ba4e8660 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I4b2a7e18e53ba7abfbe6c2c3600497e3dfe61548 Reviewed-on: https://chromium-review.googlesource.com/1139434Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#575543}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/fb734036f4b5..54edfa4e534d git log fb734036f4b5..54edfa4e534d --date=short --no-merges --format='%ad %ae %s' 2018-07-17 ehmaldonado@chromium.org Update metrics.README.md 2018-07-17 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-07-16 ehmaldonado@chromium.org gclient_scm: Use cherry-picking instead of rebasing. Created with: gclient setdep -r src/third_party/depot_tools@54edfa4e534d The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None,chromium:850812 TBR=agable@chromium.org Change-Id: I25afce41886a2c38c9afb4bcfe6e217829766fc2 Reviewed-on: https://chromium-review.googlesource.com/1139393Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#575542}
-
Erik Luo authored
Style sidebar's empty text updates visibility when the filter changes. It should also update when the inspected node changes. Bug: 849208 Change-Id: I1f5e2eeb12deecef312fbc9b50f69afd3317ab06 Reviewed-on: https://chromium-review.googlesource.com/1132348Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Commit-Queue: Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#575541}
-
Joel Hockey authored
The css !important is no longer needed since crostini is not using the nassh FSP provided volume type. Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I8a2803b934efbe7a1af8bbba0dd897987f28b3b7 Reviewed-on: https://chromium-review.googlesource.com/1139833 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#575540}
-
Shakti Sahu authored
Implemented image list item for the new download home. Bug: 850595 Change-Id: Ie82086b6b619a9a9b17a2fc4a6da9d5341fe74dd Reviewed-on: https://chromium-review.googlesource.com/1123159 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#575539}
-
Ian Clelland authored
This is used immediately for clearing up the logic around allowfullscreen and allowpayment request, and can also be used for more complex container policy logic in the future. Change-Id: I9cc702e0344d86d56a91894dc7a5a25bcdc26424 Reviewed-on: https://chromium-review.googlesource.com/1136909 Commit-Queue: Ian Clelland <iclelland@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#575538}
-
Chih-Yu Huang authored
Time::FromTimeVal() method will add the offset of UNIX epoch, and breaks the timestamp check at video_encode_accelerator_unittest. This CL change it to Time::FromMicroseconds(). BUG=chromium:853185 TEST=pass video_encode_accelerator_unittest at Kevin device Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ia13027141062015f904be74b9323a988697fea3a Reviewed-on: https://chromium-review.googlesource.com/1133612 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Pawel Osciak <posciak@chromium.org> Cr-Commit-Position: refs/heads/master@{#575537}
-
Erik Luo authored
UI.Toolbars give 'flex: none' to their shadow :host. In [1], an extra element was placed in between the Toolbar and the flex container, breaking the 'flex: none'. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1080036 Screenshot: https://imgur.com/a/wyacU7H Bug: 860476 Change-Id: If12df76e2bf711c93acee8df5d7f0bbb0a5a868d Reviewed-on: https://chromium-review.googlesource.com/1139049Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#575536}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=amineer@chromium.org Change-Id: Ia8c2213b2fad3834d7201b1b6b86aeffeb15f3ba Reviewed-on: https://chromium-review.googlesource.com/1139815Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#575535}
-
Hiroshi Ichikawa authored
Bug: 862537 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ie69f12655aae22a9c48452d86ef27bafafadae68 Reviewed-on: https://chromium-review.googlesource.com/1132912 Commit-Queue: Hiroshi Ichikawa <ichikawa@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#575534}
-
Scott Violet authored
Because of the way manifests were setup the browser was connecting to ws2, but it wasn't configuring aura/views correctly. BUG=none TEST=none Change-Id: I1e5f858d3b513d99f56d12fef6bfb137c7eaeabf Reviewed-on: https://chromium-review.googlesource.com/1139181 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#575533}
-
Chromium WPT Sync authored
Using wpt-import in Chromium ce49be89. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/21472 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: mkwst@chromium.org, andypaicu@chromium.org: external/wpt/content-security-policy TBR=raphael.kubo.da.costa@intel.com No-Export: true Change-Id: I72d7b8eb15d0e21f732e4ba861d18a7b437ab2bb Reviewed-on: https://chromium-review.googlesource.com/1139316 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#575532}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c45a5c559365..0c64e52aea82 git log c45a5c559365..0c64e52aea82 --date=short --no-merges --format='%ad %ae %s' 2018-07-17 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-07-16 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 ddd8eaa8dca0..e076a2327f0d (7 commits) 2018-07-16 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-07-16 bungeman@google.com Remove SkRefDict. 2018-07-16 bsalomon@google.com Stop running gltestpersistentcache in PreAbandonContext mode 2018-07-16 herb@google.com Remove processText last vestige of drawText 2018-07-16 herb@google.com Remove drawText support from SkOverdrawCanvas 2018-07-16 bsalomon@google.com Blacklist dftext from gltestpersistentcache 2018-07-16 bsalomon@google.com Test GrContextOptions persistent cache on linux/quadrop400 bots. Created with: gclient setdep -r src/third_party/skia@0c64e52aea82 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=bungeman@chromium.org Change-Id: I1f23a3f20de8c9bf2997fa5f8910858df62c4d6b Reviewed-on: https://chromium-review.googlesource.com/1139007Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#575531}
-
Benoit L authored
This reverts commit d1fef2b1. Reason for revert: Suspected culprit for crbug.com/863786 Original change's description: > blink/wtf: Really move MovableStrings when DCHECK_IS_ON. > > When a MovableString is parked, actually park the content, and poison > the previous allocation. This is intended to find cached raw pointer > accesses, which are not allowed beyond the UI thread task per the > contract of the class. > Enabled only when DCHECK_IS_ON to prevent potential crashes. > > Changes with and without DCHECK()s: > - Cache some String properties in MovableStringImpl > - Add a parked_strings_ to MovableStringTable for accounting, and > update tests accordingly. > > Changes with DCHECK()s: > - Add a parked_string_ member to MovableStringImpl > - Copy the string to the parked version in Park(), and poison the > previous allocation. > - Restore the string in Unpark(). > > Bug: 837659 > Change-Id: Ib7631d5e12471826c9e71a424e30d26cf8f1f042 > Reviewed-on: https://chromium-review.googlesource.com/1133169 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Commit-Queue: Benoit L <lizeb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#574529} TBR=haraken@chromium.org,lizeb@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 837659, 863786 Change-Id: I380210859a1eed42d869c1548d0d93b0e8606e58 Reviewed-on: https://chromium-review.googlesource.com/1138873 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#575530}
-
David Black authored
Known issues - Settings icon fades in/out. Will address in follow up. - ActionView is just a wrapper now for a LogoView. Will do a follow up CL to further clean this up. See bug for spec/demo. Bug: b:111500701 Change-Id: Iee2902f0c34b33cce579a78fb91b4519a2dff8c7 Reviewed-on: https://chromium-review.googlesource.com/1137843 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#575529}
-
David Black authored
Pressing Assistant UI when it is in mini state should cause it to re-expand. We only do this when NOT using stylus input modality. The implementation uses a delegate pattern analogously to what was done previously with CaptionBar(Delegate). Bug: b:110986383 Change-Id: I3dfdb85542b9ae591e3ec3f2f74eb4e7065a3859 Reviewed-on: https://chromium-review.googlesource.com/1137483 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#575528}
-
Yan,Shaobo authored
In current Deferred Error Callback implementation, CallDeferredErrorCallbacks will be invoked in every GPU_CLIENT_SINGLE_THREAD_CHECK(). Current implementation of CallDeferredErrorCallbacks will do extra deque created and swap operation even there is no errors. This impact performance. This patch fixed this by adding a flag and skip CallDeferredErrorCallbacks if there are no errors. Bug: 862069 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ie64aca137ac20bd7a19895a9dafed2a1744348ae Reviewed-on: https://chromium-review.googlesource.com/1131010Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Shaobo Yan <shaobo.yan@intel.com> Cr-Commit-Position: refs/heads/master@{#575527}
-
cathiechen authored
Like legacy layout, in order to match other browsers when list-style-type is none, pretend there's an invisible marker in <LI>. Bug: 725277 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I35d3122f9a99a4262ee41236650ff41aa09ff53d Reviewed-on: https://chromium-review.googlesource.com/1138044Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: cathie chen <cathiechen@tencent.com> Cr-Commit-Position: refs/heads/master@{#575526}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/481749905d44..ff402c2c4ce8 git log 481749905d44..ff402c2c4ce8 --date=short --no-merges --format='%ad %ae %s' 2018-07-17 tsepez@chromium.org Check for global flag on global proxy objects. 2018-07-16 tsepez@chromium.org Make JSGetObject<C>() return UnownedPtr<C>. 2018-07-16 tsepez@chromium.org Use UnownedPtr/Optional in cfxa_layoutcontext.cpp 2018-07-16 tsepez@chromium.org Use UnownedPtr<> to v8::Isolates. 2018-07-16 hnakashima@chromium.org Fix crash when typing letters into an XFA datetime field. 2018-07-16 rharrison@chromium.org Alert embedder when attempting to save XFA form 2018-07-16 thestig@chromium.org Fix some nits in CPDF_Document. 2018-07-16 vmiklos@collabora.co.uk Add FPDFFormObj_GetObject() API 2018-07-16 rharrison@chromium.org Process data changes regardless if they can be formatted 2018-07-16 tsepez@chromium.org Use UnownedPtr in CXFA_LocaleMgr 2018-07-16 tsepez@chromium.org Remove unused member from CPDF_DataAvail. Created with: gclient setdep -r src/third_party/pdfium@ff402c2c4ce8 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:862059,chromium:857521 TBR=dsinclair@chromium.org Change-Id: I34c5767262f39734719d87120febf1c2c8193a9a Reviewed-on: https://chromium-review.googlesource.com/1139006Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#575525}
-
Luciano Pacheco authored
Add iconName property on VolumeEntry and on crostini FakeItem. Change FileType.getIcon to prefer iconName property if available. Change CSS to add icon to file-type-icon which is used on file list and file grid. The changes above fix crostini (a FakeEntry), downloads and android (VolumeEntry) to be displayed with proper icons on RHS. Change directory tree (LHS) icon for shortcut, from "drive" to a new dedicated icon for shortcuts. Bug: 846587 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I44e08f9f6d711c45a4e698acbb203e9cb3a87d9d Reviewed-on: https://chromium-review.googlesource.com/1132258 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#575524}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/66a2db59..381ff28a Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I1545c2c73bfd4720ea398826a6844645f5297872 Reviewed-on: https://chromium-review.googlesource.com/1139096Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#575523}
-
junweifu authored
Only move code without modifying the implementation so that Barcode Detection can reuse it. BUG=848182 Cq-Include-Trybots: luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win10_chromium_x64_rel_ng Change-Id: Ia04a56efbd2ace4eb05f0ebaa4e341ef7a032fa4 Reviewed-on: https://chromium-review.googlesource.com/1128625 Commit-Queue: Junwei Fu <junwei.fu@intel.com> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#575522}
-
Bence Béky authored
Bug: 807724 Change-Id: I71ddcf48ef586baa4d784a76f3d281988e6c2fc4 Reviewed-on: https://chromium-review.googlesource.com/1128180Reviewed-by:
Adam Rice <ricea@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#575521}
-
Xiaocheng Hu authored
Bug: 833380 Change-Id: Icebd24dbe4514239ae0a627dd97dd9276f18c40d Tbr: kenrb@chromium.org NoTry: True Reviewed-on: https://chromium-review.googlesource.com/1139533Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#575520}
-
Devlin Cronin authored
Add additional details on the permission requirements for the tabs.captureVisibleTab() method, including that activeTab is required for sensitive sites that the extension wouldn't otherwise be allowed access to. Bug: 839857 Change-Id: I6fa1a68e8dc50bc7c3553fb32740b4c963276395 Reviewed-on: https://chromium-review.googlesource.com/1138634 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#575519}
-
Tom Anderson authored
This CL removes the last remaining references to exe_and_shlib_deps (3 were added since my first CL that removed them). In addition, I also rename the group to something ridiculously long: executable_and_loadable_module_and_shared_library_deps. This is because we cannot set visibility=["//build/config:executable", ...] because those are templates. Renaming ensures folks who were used to adding the dependency no longer add it, and makes sure that no third party projects have any references either (I checked and they don't, but this is just to make sure). The long name discourages adding the dep manually. BUG=845700 TBR=dpranke Change-Id: I1e8861b1045716f488fdbc90b4b8d0ec95abc0a6 Reviewed-on: https://chromium-review.googlesource.com/1132557 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#575518}
-
Nick Harper authored
TBR=bnc@chromium.org Change-Id: Iaa2eebc6f4534212b7b9b6a9fc50f5408ce9b815 Reviewed-on: https://chromium-review.googlesource.com/1138860Reviewed-by:
Nick Harper <nharper@chromium.org> Reviewed-by:
Bence Béky <bnc@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#575517}
-
Xiaocheng Hu authored
Change-Id: I17dfd6ca8e94db3b610cca28e0feca2b63bb3d01 Tbr: xiaochengh@chromium.org NoTry: True Bug: 860706 Reviewed-on: https://chromium-review.googlesource.com/1139435Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#575516}
-
Maks Orlovich authored
They are complex to compute, and the results are basically there isn't any: 1) There is usually only one read ongoing (>99% of the time, except I broke this bucket in M63...) 2) For writes, basically 90+% of the time we have only a single write to an entry, too. Most of the rest it's a second write following an optimistic write, which can't be easily parallelized since HttpCache writes with truncate = true. This isn't entirely impossible, though. Bug: 757682 Change-Id: I7c65988e14a6d413b95122e9c7c39c922f77524f Reviewed-on: https://chromium-review.googlesource.com/1122706Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#575515}
-
Yafei Duan authored
Adding a new flag for controlling whether homepage tile should be used and inserted into Most Visited tiles on New Tab Page. This will be checked along with NTPButton Enabled. Default value is enabled. Change-Id: I37ba92a2fe0b40c2c682adf1d34d6306242ece53 Bug: 864191 Reviewed-on: https://chromium-review.googlesource.com/1134587 Commit-Queue: Yafei Duan <romax@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#575514}
-