- 28 Apr, 2018 40 commits
-
-
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0cbdbd28b508..5148f0652738 $ git log 0cbdbd28b..5148f0652 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src-internal BUG=chromium:822826 The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I23e6fe0831080cbf78d39e06c48a3f989665dd4f Reviewed-on: https://chromium-review.googlesource.com/1034121Reviewed-by:
src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#554636}
-
Siddhartha authored
1. Reading elf for the current binary could lead to seg fault if the full library is not loaded in memory. So, the util only takes mapped address and works on it. The caller must ensure the library is mapped. 2. Add function to read soname from the .dynamic section in elf file. 3. The Linux executable does not contain so name. So, use malloc_wrapper library to test. BUG=734705 Change-Id: I1327f4786726143daba57a2aaa1eddd608143c04 Reviewed-on: https://chromium-review.googlesource.com/1031854 Commit-Queue: Siddhartha S <ssid@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#554635}
-
Xiaohan Wang authored
EmeCodec is for a single codec (in one or more container), while SupportedCodecs is a bit mask representing one or more EmeCodecs. Previously common bit masks are also part of EmeCodec enum, causing some confusings. This CL separates them. This CL also updates how the EmeCodecs list is build. Previously there are too many if/defs which makes the code really hard to read and work with. This CL use constexpr functions to build them at compile time. Bug: 773863 Test: No functionality change. Change-Id: I0f844735699baa5faa4bf1b93905b045e9fcb8e3 Reviewed-on: https://chromium-review.googlesource.com/1034004 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#554634}
-
https://webrtc.googlesource.com/src.git/+log/de2ed7dc18d5..9546f37c0366 $ git log de2ed7dc1..9546f37c0 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=chromium:None The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I9e4b90cf30030da1ad0a3b52928089e98ace399a Reviewed-on: https://chromium-review.googlesource.com/1034129Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#554633}
-
Abhishek Arya authored
This reverts commit 58eabf0b. Reason for revert: Broke ChromeOS ASan builder Original change's description: > Build 32- and 64-bit Android mojo_core for Chrome OS distribution > > Causes Chrome builds for Chrome OS to emit additional 32-bit and > 64-bit copies of the mojo_core shared library built against the > Android toolchain, for use from within the ARC++ container. > > In order to support building these library targets, this also > modifies DEPS to include a minimal set of required Android support > tools and libraries in chromeos checkouts. > > Bug: 822034 > Change-Id: I219837de3076490cdea8315e6cc98c5432871ea0 > Reviewed-on: https://chromium-review.googlesource.com/1026203 > Commit-Queue: Ken Rockot <rockot@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#554617} TBR=rockot@chromium.org,dpranke@chromium.org Change-Id: I2e2b0d3500aa948f15ec7cf0ff024f7a82fd719d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 822034 Reviewed-on: https://chromium-review.googlesource.com/1033369Reviewed-by:
Abhishek Arya <inferno@chromium.org> Commit-Queue: Abhishek Arya <inferno@chromium.org> Cr-Commit-Position: refs/heads/master@{#554632}
-
Karandeep Bhatia authored
LocalNtpSource serves resources for the local New Tab page. It makes browser requests to fetch one google bar data over the network. This is then served to the local NTP renderer. Currently, extensions can intercept these requests using the Web Request API. However, this is not desired as the NTP is a semi-privileged process. Hide these requests from extensions. BUG=797461 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Ic8bb3268ba37ec859237f6805bba9a96cae6d464 Reviewed-on: https://chromium-review.googlesource.com/1026996 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#554631}
-
Timothy Loh authored
As it may take several seconds for the Crostini container to spin up, dismiss the app launcher so there is some sort of user feedback when tapping an app. Eventually we should show a spinner or something. Change-Id: I62bda8b7a673bbdf10d6d6b85003a1516df00b8b Reviewed-on: https://chromium-review.googlesource.com/1032352Reviewed-by:
Nicholas Verne <nverne@chromium.org> Commit-Queue: Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#554630}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/14d7a4ab..fad57b13 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Iba787dc1396b980d40527f3efaf5b8e013a81775 Reviewed-on: https://chromium-review.googlesource.com/1033909Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#554629}
-
Renee Wright authored
Doesn't close/message on error yet. Bug: 833125 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I8ab6007c0d9c5bbdb7e8bf84759355ad500e4cca Reviewed-on: https://chromium-review.googlesource.com/1023510 Commit-Queue: Renée Wright <rjwright@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#554628}
-
https://chromium.googlesource.com/chromiumos/chromite.git/+log/7c0757b099e5..117b08a5550a $ git log 7c0757b09..117b08a55 --date=short --no-merges --format='%ad %ae %s' 2018-04-27 manojgupta SimpleChrome: Attempt to fix SimpleChromeWorkflow. Created with: roll-dep src/third_party/chromite BUG=chromium:837794 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: If6311515375dcee38066d337fd42d0ffa4336a7f Reviewed-on: https://chromium-review.googlesource.com/1034154Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#554627}
-
Xianzhu Wang authored
Now all paint property nodes are owned by ObjectPaintProperties (and LocalFrameView temporarily before removing non-RLS mode). Others just use raw pointers or references. Bug: 833496 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I2d544fe153bb94698623248748df63c8aa2081ae Reviewed-on: https://chromium-review.googlesource.com/1031101Reviewed-by:
Tien-Ren Chen <trchen@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#554626}
-
Kenneth Russell authored
We should add a better way to define mixins like these, but for the time being, add exceptions to trigger these jobs on physical hardware. It's not feasible to run these tests on MSAN right now. Tbr: thakis@chromium.org Bug: 830659, 835072 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_chromium_asan_rel_ng;master.tryserver.chromium.linux:linux_chromium_msan_rel_ng;master.tryserver.chromium.linux:linux_chromium_tsan_rel_ng;master.tryserver.chromium.linux:linux_chromium_cfi_rel_ng Change-Id: Ifbc4d86262dfd203dd8b57670aac989e433b1f46 Reviewed-on: https://chromium-review.googlesource.com/1023333 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#554625}
-
https://webrtc.googlesource.com/src.git/+log/e80689fcabde..de2ed7dc18d5 $ git log e80689fca..de2ed7dc1 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I0e189494d09afc26553970afd3c5b326881b8e07 Reviewed-on: https://chromium-review.googlesource.com/1034153 Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#554624}
-
Xiaohan Wang authored
Clean up proprietary codec checks for EME. MP4 is not treated as "proprietary" anymore. So "proprietary codec" should only be used for real proprietary codes, e.g. AVC1 or AAC. Bug: 327115,837783 Test: Tests updated. Change-Id: I18b762ab543f2cf08c7dec195c28d3ee62143eb8 Reviewed-on: https://chromium-review.googlesource.com/1033695 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#554623}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/90942960..14d7a4ab Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I461cb43e7926d9ea96e00ccb50d71f24c90cad38 Reviewed-on: https://chromium-review.googlesource.com/1033904Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#554622}
-
Will Harris authored
BUG=837888 Change-Id: I9cadbc1cf7f8103c28f1a7f3f4f327c7393bd885 Reviewed-on: https://chromium-review.googlesource.com/1024795 Commit-Queue: Will Harris <wfh@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#554621}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: Idd7cefe36dae06a08fc8f7a788b4b70d5961482d Reviewed-on: https://chromium-review.googlesource.com/1033906Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#554620}
-
Wei Li authored
Feature flag use-pdf-compositor-service-for-print was accidentally removed from chrome://flags page in commit 48a4a526 due to use of build flag. Now we added it back so this feature can be controlled by users. BUG= TEST=Check chrome://flags, use-pdf-compositor-service-for-print should show up in that page. Change-Id: Iedd2d7a3d124b5c63de6d4488fa5f28fced1e06d Reviewed-on: https://chromium-review.googlesource.com/1033808Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#554619}
-
https://skia.googlesource.com/skia.git/+log/275df2e87306..7df62b559a65 $ git log 275df2e87..7df62b559 --date=short --no-merges --format='%ad %ae %s' 2018-04-28 angle-skia-autoroll Roll third_party/externals/angle2/ de279590a..bb3255b5a (5 commits) Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=stani@chromium.org Change-Id: I6e332d41eda950fed3fcba6eb76d840d2fee2671 Reviewed-on: https://chromium-review.googlesource.com/1034117 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#554618}
-
Ken Rockot authored
Causes Chrome builds for Chrome OS to emit additional 32-bit and 64-bit copies of the mojo_core shared library built against the Android toolchain, for use from within the ARC++ container. In order to support building these library targets, this also modifies DEPS to include a minimal set of required Android support tools and libraries in chromeos checkouts. Bug: 822034 Change-Id: I219837de3076490cdea8315e6cc98c5432871ea0 Reviewed-on: https://chromium-review.googlesource.com/1026203 Commit-Queue: Ken Rockot <rockot@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#554617}
-
Devlin Cronin authored
Completely remove chrome.send() from drag_and_drop_handler.js, and use developerPrivate.installDroppedFile() for the remaining method call that was used by chrome.send(). Bug: 820187 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I7da13b41c17bbdc16d929cfaac58daa081d41184 Reviewed-on: https://chromium-review.googlesource.com/1031116 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#554616}
-
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8c9979e745c1..0cbdbd28b508 $ git log 8c9979e74..0cbdbd28b --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src-internal BUG=chromium:None The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ib7b64058179ca534bf9e2d826f22bc4f9c1e592e Reviewed-on: https://chromium-review.googlesource.com/1034113Reviewed-by:
src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#554615}
-
https://chromium.googlesource.com/angle/angle.git/+log/696434382359..bb3255b5a507 $ git log 696434382..bb3255b5a --date=short --no-merges --format='%ad %ae %s' 2018-04-27 jiawei.shao Remove redundant computations on combined interface block counts 2018-04-24 jiawei.shao ES31: Add REFERENCED_BY_GEOMETRY_SHADER as program interface property Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: I900ede76870f25c9c817a39705184c105851e3a7 Reviewed-on: https://chromium-review.googlesource.com/1034111 Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#554614}
-
https://webrtc.googlesource.com/src.git/+log/658ad8816b7e..e80689fcabde $ git log 658ad8816..e80689fca --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=chromium:None The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I70553c388b2fad59791a3498905deb0ec3310c10 Reviewed-on: https://chromium-review.googlesource.com/1033800Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#554613}
-
Xianzhu Wang authored
The crash reports are null pointer crashes at: resolved_inner_node->GetLayoutObject()->UpdateHitTestResult(... The code is executed only when resolved_inner_node is not null, so the only cause is the layout object is null. No test case because we don't have a reproduction. Bug: 835523 Change-Id: I707dcfa05d95e43c29091fc33723c29b0b28134c Reviewed-on: https://chromium-review.googlesource.com/1028366Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Ella Ge <eirage@chromium.org> Reviewed-by:
Rick Byers <rbyers@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#554612}
-
Christopher Thompson authored
This adds a new UrlFormatter.formatUrlForDisplayWithNormalEscaping() function, and uses it in the Android PageInfoPopup to make its URL display correctly de-punycode URLs that are safe to convert back to Unicode for display. This also adds url_formatter unittests for the specific usage of FormatUrl that the new function uses under a variety of URL conditions. Bug: 818839 Change-Id: Id0f50a6a37be7309c684ef180acc78f84895d729 Reviewed-on: https://chromium-review.googlesource.com/1015229 Commit-Queue: Christopher Thompson <cthomp@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#554611}
-
Sonny Sasaka authored
BlueZ bug makes it wrong to assume that the Discovering property is updated when StartDiscovery/StopDiscovery returns (crbug.com/822104). BlueZ bug fixing is deprioritized so here we remove the DCHECK first until BlueZ bug is fixed. This is a left-over from https://crrev.com/c/963845. BUG=814595,836427 TEST=No longer crashes Change-Id: I81167db3c3d31225279798e37bede79c56037622 Reviewed-on: https://chromium-review.googlesource.com/1033455Reviewed-by:
Miao-chen Chou <mcchou@chromium.org> Commit-Queue: Sonny Sasaka <sonnysasaka@chromium.org> Cr-Commit-Position: refs/heads/master@{#554610}
-
Chris Mumford authored
On CrOS a WebUI resource request is being made that isn't one of our allowed hosts. Temporarily adding a crash key to reveal this host to facilitate debugging. Bug: 837328 Change-Id: I26b103ee73229c92f1876448364c132cc58ad42f Reviewed-on: https://chromium-review.googlesource.com/1033998 Commit-Queue: Chris Mumford <cmumford@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#554609}
-
Paul Jensen authored
This change builds maven modules for Cronet. Each maven module includes: 1. POM file defining module and listing dependent modules 2. Jars 3. Proguard files (optional) 4. Native libraries (optional) 5. Resources (optional) 6. Javadocs (optional) We build four maven modules: 1. cronet-api: the Cronet API 2. cronet-embedded: the Cronet native implementation 3. cronet-fallback: the Cronet fallback implementation 4. cronet-common: Cronet implementation in common with #3 and #4 To test the maven modules, this change builds the Cronet sample app using gradle. You can install and run the resulting app by: ninja -C out/Debug cronet_maven_test_build adb install -r out/Debug/cronet_maven/test/build/outputs/apk/debug/test-debug.apk adb install -r out/Debug/cronet_maven/test/build/outputs/apk/androidTest/debug/test-debug-androidTest.apk adb shell am instrument -w org.chromium.cronet_sample_apk.test/android.support.test.runner.AndroidJUnitRunner Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I5ed27e86f3e01dc3a6441ab449bbe942553343af Reviewed-on: https://chromium-review.googlesource.com/998019 Commit-Queue: Paul Jensen <pauljensen@chromium.org> Reviewed-by:
Andrei Kapishnikov <kapishnikov@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#554608}
-
Alex Moshchuk authored
Bug: 837009 Change-Id: Ia239d85b546c2265e77564356d2c1a2e2fc3aa74 Reviewed-on: https://chromium-review.googlesource.com/1029006Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#554607}
-
Devlin Cronin authored
Update the context menu access strings for extensions with click-to-script enabled, and reorder the items to match the mocks. New strings: Allow access -> On click On all sites On example.com Note the host name should just include the domain, and should strip any leading www. Bug: 837701 Change-Id: I5f579d1922abb2c261ad566c16e0a3b7af8840cf Reviewed-on: https://chromium-review.googlesource.com/1033334Reviewed-by:Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#554606}
-
Emily Stark authored
This CL enables the HTTP-Bad feature by default and sets it to warn on all http:// pages, and updates tests accordingly. Bug: 837034 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I470aa09220df9e02833de8f8636ea2e66e2a6b05 Reviewed-on: https://chromium-review.googlesource.com/1029415 Commit-Queue: Emily Stark <estark@chromium.org> Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/master@{#554605}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/bf02b736..90942960 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I21bd1f8ac887fd53615281c1f696e03bb86536cd Reviewed-on: https://chromium-review.googlesource.com/1033933Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#554604}
-
John Budorick authored
This reverts commit 13dfb327. Reason for revert: Suspected cause of many test failures in https://luci-milo.appspot.com/p/chromium/builders/luci.chromium.ci/Linux%20Tests%20%28dbg%29%281%29/71676 Original change's description: > Load resources.pak earlier in service manager main > > We need to use the content in resources.pak in service manager, but at > that time resource bundle has not been initialized. Create data pack to > load resources.pak and append the data pack to resource bundle during the > initialization. > > Move path FILE_RESOURCES_PACK from chrome_paths.h to ui_base_paths.cc. > > Bug: 729596, 815230 > Change-Id: Iec3a9409cbd9c10775afb72944e66e26650f1181 > Reviewed-on: https://chromium-review.googlesource.com/962679 > Reviewed-by: Yaron Friedman <yfriedman@chromium.org> > Reviewed-by: Ken Rockot <rockot@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Xi Han <hanxi@chromium.org> > Commit-Queue: Ran Ji <ranj@chromium.org> > Cr-Commit-Position: refs/heads/master@{#554500} TBR=sky@chromium.org,yfriedman@chromium.org,rockot@chromium.org,hanxi@chromium.org,ranj@chromium.org Change-Id: Ia23016b542b772581096492898b57f6c6ed3e075 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 729596, 815230 Reviewed-on: https://chromium-review.googlesource.com/1034132Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#554603}
-
https://skia.googlesource.com/skia.git/+log/34a388edbd27..275df2e87306 $ git log 34a388edb..275df2e87 --date=short --no-merges --format='%ad %ae %s' 2018-04-25 bungeman Just pass color glyph masks to filters. Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=stani@chromium.org Change-Id: Icabb57b36bbd525f4e585b7ac09d4ece88b37a20 Reviewed-on: https://chromium-review.googlesource.com/1034026 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#554602}
-
Siddhartha authored
This reverts commit cc0afbf7. Reason for revert: Move the variable to test file and use it only on official builds. Both Chromeos component and official build works. Original change's description: > Revert "Add utils to read elf binary and get Build id" > > This reverts commit 61248f1a. > > Reason for revert: Suspected breaking component builds (bug 837817) > > Original change's description: > > Add utils to read elf binary and get Build id > > > > Adds code to parse elf binary to get build id from > > .note.gnu.build-id section. The build ID is needed to symbolize > > heap dumps from the users. > > > > BUG=734705 > > > > Change-Id: If4365e232c060ba96071ba1e1c43618f9807e39c > > Reviewed-on: https://chromium-review.googlesource.com/1028995 > > Commit-Queue: Siddhartha S <ssid@chromium.org> > > Reviewed-by: Lei Zhang <thestig@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#554304} > > TBR=thestig@chromium.org,ssid@chromium.org > > Change-Id: If512434b55bcc912990e3997a86f6f93722b15fb > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 734705 > Reviewed-on: https://chromium-review.googlesource.com/1033795 > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> > Cr-Commit-Position: refs/heads/master@{#554532} TBR=thestig@chromium.org,ssid@chromium.org,thomasanderson@chromium.org Change-Id: Ie2fb8f7fe0759dc418a1bc4ffc57bdb4542ba606 Bug: 734705, 837817 Reviewed-on: https://chromium-review.googlesource.com/1033498 Commit-Queue: Siddhartha S <ssid@chromium.org> Reviewed-by:
Siddhartha S <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#554601}
-
https://chromium.googlesource.com/catapult.git/+log/32f02b5d358b..a4814ecb93e6 $ git log 32f02b5d3..a4814ecb9 --date=short --no-merges --format='%ad %ae %s' 2018-04-27 dtu [pinpoint] Refactor Job creation and /api/new handler. Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: I0c7778c140a2dbe12bf6876b8582e16640d2f963 Reviewed-on: https://chromium-review.googlesource.com/1033809 Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#554600}
-
Tommy Steimel authored
This is a reland of crrev.com/c/1028483. This CL removes a CSS rule that centered the audio element on the MediaDocument page. This fixes an issue where the overflow menu position calculation was incorrect. Bug: 835279 Change-Id: I028383f5201c5bee741a6fb5dd5a825a9a808736 Reviewed-on: https://chromium-review.googlesource.com/1033914 Commit-Queue: Tommy Steimel <steimel@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#554599}
-
Scott Chen authored
This CL does the following: - add an <iron-collapse> containing <settings-personalization-options> in the sync subpage when unified-consent is enabled. - hide <settings-personalization-options> when unified-consent is enabled, and instead show description with a link to the sync subpage. screenshots: https://imgur.com/a/3keIzR3 Bug: 800973, 800975 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I94e0e2abde13c9260f5dbd8a0a444244c556f253 Reviewed-on: https://chromium-review.googlesource.com/1025314 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#554598}
-
Emily Hanley authored
Bug: 836037 Change-Id: I9a927fe4655261a77965ca27cdfcf1055a9a0f1d Reviewed-on: https://chromium-review.googlesource.com/1030773 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Reviewed-by:
David Tu <dtu@chromium.org> Cr-Commit-Position: refs/heads/master@{#554597}
-