- 19 Jun, 2018 40 commits
-
-
Zhongyi Shi authored
This test verifies that migration will be timed out after kWaitTimeForNewNetworkSecs and closes the connection if there's no network available. Bug: 818259, 843299 Change-Id: I58e4945d84e153f621187a1b1b46ac9dbb4e3372 Reviewed-on: https://chromium-review.googlesource.com/1107106 Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#568634}
-
Steven Holte authored
TBR=sky NOTRY=true Bug: 854294 Change-Id: Ic904d41cbc236a8812472e7f0dba0cb45396f256 Reviewed-on: https://chromium-review.googlesource.com/1107135Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#568633}
-
Kyle Horimoto authored
Previously, the test assumed that the service did not actually start up until an API call was made on one of its exposed interfaces. However, that was actually incorrect; the service starts up as soon as a client binds to it. The issue was actually that I had forgotten to call SecureChannelPtr::FlushForTesting() at the end of SetUp(). Bug: 824568, 752273 Change-Id: I4ffd1f49f096fec5b72ce18870efd112d1ea0124 Reviewed-on: https://chromium-review.googlesource.com/1106972Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#568632}
-
Chris Harrelson authored
* Don't intersect with the overall dirty rect except at changes of root layer, because otherwise the location and rect don't change * Early out intersections when a ClipRect is infinite (since it has no effect) * Don't adjust infinite ClipRects (since it has no effect) * Simplify / resolve TODOs in some cases where we previously had to construct an "infinite" layout rect In local testing, this CL yields a 10% improvement on the intersection-observer/deep-layers.html performance test due to faster hit testing. Bug: 831762 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ie7a1e2fb5cbeb8f7f9a267489785266ed7b8ca47 Reviewed-on: https://chromium-review.googlesource.com/1104964 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#568631}
-
Lindsay Pasricha authored
Bug: 852019 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I06eaac40d540fd1581fcbac01595d41bab969374 Reviewed-on: https://chromium-review.googlesource.com/1101241 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#568630}
-
gogerald authored
Bug: 853924 Change-Id: I69570abedd76a9f21fa42269061445e54f23fcfa Reviewed-on: https://chromium-review.googlesource.com/1106702 Commit-Queue: Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#568629}
-
Liquan(Max) Gu authored
Change-Id: Idc618ff767e6015b9e4043d74db3f141ccf43b44 Reviewed-on: https://chromium-review.googlesource.com/1106763Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Liquan (Max) Gǔ <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#568628}
-
src-internal-chromium-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/dd1a2724e60e..208cf41c691b Created with: gclient setdep -r src-internal@208cf41c691b The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:853368 TBR=mmoss@chromium.org Change-Id: I2711ddb8757e18dad036816b7b4eca511f4b1a66 Reviewed-on: https://chromium-review.googlesource.com/1106564Reviewed-by:
src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#568627}
-
Adrienne Walker authored
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I12a5bfe98138afea0b0f32a7cd6a74f2c41ca74d Reviewed-on: https://chromium-review.googlesource.com/1106813 Commit-Queue: enne <enne@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#568626}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/79d42dfb1174..179059f63e9e git log 79d42dfb1174..179059f63e9e --date=short --no-merges --format='%ad %ae %s' 2018-06-19 vasili.skurydzin@ibm.com AIX: Enable usage of fetch and gclient Created with: gclient setdep -r src/third_party/depot_tools@179059f63e9e The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Ided779339acc6adff403b2c44461a8420590d969 Reviewed-on: https://chromium-review.googlesource.com/1106565Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#568625}
-
Chris Lu authored
Adds the clear data type cells to the table view. Video: https://drive.google.com/open?id=11wNSwTOGKwI9r_6-ojWkLmMHYc-lqvAH Bug: 805201 Change-Id: I6729233d8a3c4d42bc4b649d56ae0f786ec59b5b Reviewed-on: https://chromium-review.googlesource.com/1101907 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#568624}
-
Anita Woodruff authored
- Renamed onRequestPermissionsResult -> handlePermissionResult in the AndroidPermissionDelegate interface; this avoids a name-clash with the method on FragmentActivity, hopefully making it easier to reason about what is calling what. - Made handlePermissionResult return a boolean indicating whether the result was handled. - *Actually return false sometimes instead of always true from ActivityAndroidPermissionDelegate/ActivityWindowAndroid* <-- this is the only bit that actually might change behaviour. - Made WindowAndroid an AndroidPermissionDelegate itself so it's now a proper decorator pattern - it had most of the methods already and this will allow easier unit testing. R=tedchoc@chromium.org Change-Id: I3787529184ce1acafd3d71d6f511941478026ecc Reviewed-on: https://chromium-review.googlesource.com/1105042 Commit-Queue: Anita Woodruff <awdf@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#568623}
-
Sarah Hu authored
Bug: 840013 Change-Id: I1e1e8a21144d2b1cdf62b40b33f7b16f8d157d98 Reviewed-on: https://chromium-review.googlesource.com/1106707 Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#568622}
-
erikchen authored
This CL is not intended to have any behavior change. We need to update some keyEquivalents in MainMenu.xib, and it is much easier to update the whole file to use Xcode 8.3.2 than to try to get an instance of Xcode 5.1.1 running on a macOS 10.9.5 device. We refrain from updating all xibs since most of them are going away with the migration to Views, and historically, updating xibs has had subtle behavior changes. Bug: 851714 Change-Id: Ibae17d5d645a373f29549d08b9d3c1bf95c0b08a Reviewed-on: https://chromium-review.googlesource.com/1106897Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#568621}
-
Chris Mumford authored
DeleteFile ignores db lock file so leveldb_chrome::DestroyDB is preferred. Bug: 802298 Change-Id: I15af9ae4c402f94d537a5b4495e8a60f6dd906fe Reviewed-on: https://chromium-review.googlesource.com/1069415 Commit-Queue: Chris Mumford <cmumford@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Cr-Commit-Position: refs/heads/master@{#568620}
-
Jacob Dufault authored
This is a reland of https://chromium-review.googlesource.com/c/chromium/src/+/1093741, which was reverted in https://chromium-review.googlesource.com/c/1105240/ Bug: 851012 Change-Id: Icc587ff829e187b2eae7456aec227f5d66beb1ee Reviewed-on: https://chromium-review.googlesource.com/1106641Reviewed-by:
-
Dirk Pranke authored
The mac10.12-blink-rel bot has no machines that can run its tasks. To fix this, and to be explicit about the other configurations needed, this CL makes the swarming dimensions explicitly specified for those mac builders. TBR=robertma@chromium.org BUG=854039 Change-Id: Id4e79d9c0f47f36fd258769cfcc5f39b8c12e677 Reviewed-on: https://chromium-review.googlesource.com/1106613Reviewed-by:
Robert Ma <robertma@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#568618}
-
Dirk Pranke authored
They weren't using it before, but it should work, so this turns it on. NOTRY=true Change-Id: I4f47b37ef00cee52639e7bf482a9e32a90458c7d Reviewed-on: https://chromium-review.googlesource.com/1106766 Commit-Queue: Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Ryan Tseng <hinoka@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#568617}
-
Mohamed Heikal authored
onTrimMemory tries to get a reference to the ControlContainer view and calls getToolbarResourceAdapter().dropCachedBitmap() on it. If the UI has not finished inflation yet, then the findViewById(R.id.control_container) returns null causing a crash. This cl adds a null check before calling methods on the ControlContainer. Bug: 853682 Change-Id: I621d21a92509c0c3211da99841cd59991cb38813 Reviewed-on: https://chromium-review.googlesource.com/1106900Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#568616}
-
Eugene But authored
Updated BuildNavigationItemImpl to call SetURL instead of assigning to ivar. This way ErrorRetryStateMachine::SetURL gets called as required. Bug: 725241 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I72ee391dabe18c60ea2c01c384fa3485b9bee1e9 Reviewed-on: https://chromium-review.googlesource.com/1106973Reviewed-by:
Danyao Wang <danyao@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#568615}
-
chaopeng authored
This issue is causing by: 1. MainThreadScheduler set TouchStartExpectedSoon based on the gesture event sequence when page has touchstart event handler 2. Scroll latching makes mouse wheels to gesture events. We change it the check from page has touchstart event handler to we actually cc blocking event. In the issue case, page has touchstart event handler but no wheel event handler, user scroll with wheel will not cause a cc blocking event so it would not block the network request. We also change TouchStartExpectedSoon to BlockingInputExpectedSoon. Bug: 828235 Change-Id: Iefff163ca091f2761542a527e2c4432bc1078f4c Reviewed-on: https://chromium-review.googlesource.com/1075719 Commit-Queue: Jianpeng Chao <chaopeng@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#568614}
-
Reid Kleckner authored
Windows ASan hotpatches executables and allocates RWX code pages, which means we can't intercept memmove/memset, which ASan needs. Reimplementing ASan's interception mechanism to avoid hotpatching is an extended long term project. R=pennymac@chromium.org BUG=805414 Change-Id: I4b05235e5c8abac1055a3ed56a26ca2ba4b7ad22 Reviewed-on: https://chromium-review.googlesource.com/1105513Reviewed-by:
Penny MacNeil <pennymac@chromium.org> Commit-Queue: Reid Kleckner <rnk@chromium.org> Cr-Commit-Position: refs/heads/master@{#568613}
-
Siddhartha authored
Some metrics are owned by Erik and some by me depending on when it was added. Just add both to all metrics. Change-Id: Id586f13cfbaf8036d23b31169f16c1bae1d270f6 Reviewed-on: https://chromium-review.googlesource.com/1106611Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#568612}
-
Sébastien Marchand authored
This reverts commit 8f4ffc9a. Reason for revert: Break some tests on CrOS. Original change's description: > RC: Connect the Local DB to TabHelper and add browsertests. > > Bug: 773382 > Change-Id: Ie7cbbf2c74bfbf1f1522b2a1f775a392545ad0a9 > Reviewed-on: https://chromium-review.googlesource.com/1088196 > Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> > Reviewed-by: François Doray <fdoray@chromium.org> > Cr-Commit-Position: refs/heads/master@{#568519} TBR=fdoray@chromium.org,sebmarchand@chromium.org Change-Id: Id145ad7b9de4422794daba06eedeb2f54e5d28a1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 773382 Reviewed-on: https://chromium-review.googlesource.com/1106978Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#568611}
-
Taylor Brandstetter authored
This is just the standardized name for "maxRetransmitTime", which we've already supported for a while. Also adding deprecation notice saying that maxRetransmitTime is being replaced by maxPacketLifeTime and will be removed in M70. Bug: chromium:696681 Change-Id: I14dc14ebc103bb3f6a233fd753d9ffbd1dd734d6 Reviewed-on: https://chromium-review.googlesource.com/1101473Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Taylor Brandstetter <deadbeef@chromium.org> Cr-Commit-Position: refs/heads/master@{#568610}
-
Aldo Culquicondor authored
This is a reland of d51d3420 Previously, we were DCHECKing that touch handles were not being enabled during VR browsing. This caused some tests to crash, since the VR browser can not control when those calls are produced. Instead, this CL merges all the requirements for disabling the touch handles, including the VR mode. Original change's description: > VR: Adding move support for the platform UI > > This enables touch interaction with the web contents, effectively > enabling long press, drag, selection, etc. > > Context menu and selection handles are disabled for VR in this CL. > > Bug: 842916, 733656, 848740 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux_vr > Change-Id: If50401ddbc130abde697b57d580bc492de2c4dda > Reviewed-on: https://chromium-review.googlesource.com/1091281 > Commit-Queue: Aldo Culquicondor <acondor@chromium.org> > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Timothy Dresser <tdresser@chromium.org> > Reviewed-by: Michael Thiessen <mthiesse@chromium.org> > Cr-Commit-Position: refs/heads/master@{#567745} Bug: 842916, 733656, 848740 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:ios-simulator-full-configs;luci.chromium.try:linux_layout_tests_slimming_paint_v2;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I405c57fb91324758834f2d7afe21bb9c2bc937d4 Reviewed-on: https://chromium-review.googlesource.com/1104638Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Commit-Queue: Aldo Culquicondor <acondor@chromium.org> Cr-Commit-Position: refs/heads/master@{#568609}
-
Yafei Duan authored
Implements ExploreSitesBridge::GetIcon using ImageFetcher, which takes url and return fetched image via callback. Bug: 852075 Change-Id: I8d3acd770cb2510639cd7896a79a81499874d50d Reviewed-on: https://chromium-review.googlesource.com/1099771 Commit-Queue: Yafei Duan <romax@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Cathy Li <chili@chromium.org> Cr-Commit-Position: refs/heads/master@{#568608}
-
Philip Rogers authored
When the window has a blocking event handler, we need to ensure touch action rects are painted. This patch paints the window touch action rects using the LayoutView. In the PrePaint tree walk, blocking touch event handlers on the window are considered when computing the LayoutView's effective touch action. With this change, ScrollingCoordinatorTest.IframeWindowTouchHandler now passes with PaintTouchActionRects. Bug: 851660 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux-blink-gen-property-trees Change-Id: Ifbc9a9c60086ac8c92b6ff4829b3eda0513e3a36 Reviewed-on: https://chromium-review.googlesource.com/1104780 Commit-Queue: Philip Rogers <pdr@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#568607}
-
Clark DuVall authored
This matches the implementation in ChromeNetworkDelegate. Bug: 789632 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I68c00d635fd1eb527aa2e80851acf8a3fd7325af Reviewed-on: https://chromium-review.googlesource.com/1104937 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#568606}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/7df52383cfdf..41b453a48844 git log 7df52383cfdf..41b453a48844 --date=short --no-merges --format='%ad %ae %s' 2018-06-19 geofflang@chromium.org WGL: Track current context per thread. 2018-06-19 geofflang@chromium.org WGL: Update the Renderer to own the native GL context. 2018-06-19 lucferron@chromium.org Vulkan: Enable some more fbo.render dEQP tests 2018-06-19 lucferron@chromium.org Vulkan: Enable a bunch of texture related tests 2018-06-19 lucferron@chromium.org Vulkan: Support RGB5A1 correctly 2018-06-19 brandon1.jones@intel.com Change Validation For Indexed Draw Without ELEMENT_ARRAY_BUFFER Created with: gclient setdep -r src/third_party/angle@41b453a48844 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I0e54437cac4779e89de01770d173d497b7eaf7ee Reviewed-on: https://chromium-review.googlesource.com/1106563Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#568605}
-
Patrick Noland authored
-Supports specification of a css selector using the "targetElement=" prefix -The first matching element will be used as the target element -Adds a RuntimeEnabledFeature and chrome://flags entry I2I: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/aKI6doxffgQ Explainer: https://github.com/bryanmcquade/scroll-to-css-selector Change-Id: Ic7ef167d5b8beae7d7a43194f47d8c603030c4a6 Reviewed-on: https://chromium-review.googlesource.com/1103300 Commit-Queue: Patrick Noland <pnoland@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#568604}
-
Mike Dougherty authored
This reverts commit 0928665a. Reason for revert: This behavior is causing more confusion for users than it is helping. See crbug.com/854274 for details. Original change's description: > Do not recover incognito tabs if user deliberately terminates Chrome. > > Previously incognito tabs were always recovered no matter how the app > was last shutdown. > > Instead, do not restore the incognito tabs if the user explicitly closes > Chrome. If the system terminates the app, the tabs should be restored. > (This can happen at any time and without user notice, so such > terminations should not lead to a loss of the user's incognito tabs.) > > Bug: 653248 > Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs > Change-Id: I018cdf5cda2004e32e1010c4d9bab4bd10c0ae99 > Reviewed-on: https://chromium-review.googlesource.com/835532 > Reviewed-by: Eugene But <eugenebut@chromium.org> > Commit-Queue: Mike Dougherty <michaeldo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#526099} TBR=marq@chromium.org,eugenebut@chromium.org,michaeldo@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 653248, 854274 Change-Id: I952db05d6364d0944c3e46b9fa78b1432e889830 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Reviewed-on: https://chromium-review.googlesource.com/1106777 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#568603}
-
Danil Chapovalov authored
Stop including webrtc/api/optional.h In files that need to set optionals in webrtc structs use absl::optional Bug: webrtc:9078 Change-Id: I21e8561152cac722b182e1aa72224fcb308cff68 Reviewed-on: https://chromium-review.googlesource.com/1105820Reviewed-by:
Per Kjellander <perkj@chromium.org> Commit-Queue: Danil Chapovalov <danilchap@chromium.org> Cr-Commit-Position: refs/heads/master@{#568602}
-
Fabio Tirelo authored
Sets the style for explanation, footer disclaimer, and expiration dates to secondary, in order to match the new spec. Also sets style for credit card number as primary. Sets context for labels as CONTEXT_BODY_TEXT_LARGE, so that they get the correct font size (13dp). Also changes the disclaimer test in the DialogBrowserTest to make it easier to inspect link changes. Bug: 852094 Test: ./out/Debug/browser_tests --gtest_filter=BrowserUiTest.Invoke --ui=SaveCardBubbleControllerImplTest.InvokeUi_Server --test-launcher-interactive Change-Id: Ib9b7ef57119c1314848e079122f3677d5db80901 Reviewed-on: https://chromium-review.googlesource.com/1099486Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#568601}
-
Danil Chapovalov authored
Bug: webrtc:9078 Change-Id: I6cce5b13e6178834bcd2c5287f840e10d9f183b2 Reviewed-on: https://chromium-review.googlesource.com/1104463Reviewed-by:
-
Shimi Zhang authored
This CL converts delete-across-editable-content-boundaries-2 to utilize |selection_test()|. In preparing for http://crrev/c/1102157, make it easier for us to handle the behavior change. Bug: 847192 Change-Id: I85ace72d163656fed187b679f287fed2c053d227 Reviewed-on: https://chromium-review.googlesource.com/1106547Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#568599}
-
Shimi Zhang authored
In preparing for http://crrev/c/1102157, make it easier for us to handle the behavior change. Bug: 847192 Change-Id: I5b4053056e96b7c2ecec879b3fea722b3d68d511 Reviewed-on: https://chromium-review.googlesource.com/1105575Reviewed-by:
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/96aa535b782f..80452bee11eb git log 96aa535b782f..80452bee11eb --date=short --no-merges --format='%ad %ae %s' 2018-06-19 fmalita@chromium.org Fold SkJSON into Skia/utils Created with: gclient setdep -r src/third_party/skia@80452bee11eb The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=kjlubick@chromium.org Change-Id: Ia64b7049ba052d31311abbead1897e2543b11cf2 Reviewed-on: https://chromium-review.googlesource.com/1106561Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#568597}
-
Andrew Grieve authored
Test is very flakey. On many bots, it fails at least once per run. Bug: 756550 Change-Id: I8eac5aa374999a20382e30c689761bedb6f23c65 Reviewed-on: https://chromium-review.googlesource.com/1106760 Commit-Queue: agrieve <agrieve@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#568596}
-
David Black authored
See bug for specs, details, and demo. In order to implement the new spec, this CL: - Adds concept of committed/pending query to AssistantInteractionModel. - Adds AssistantHeaderView. - Adds AssistantMainStage. - Modifies AssistantQueryView to observe committed or pending query. - Modifies AssistantTextElementView UI. - Moves SuggestionContainerView into AssistantMainStage. - Modifies AssistantController so that the stage is only cleared on query commit and UI dismiss. Note: - AssistantInteractionModel is becoming convoluted. I will do a follow up to create an AssistantMainStageModel so that the interaction model can focus on more purely interaction related state (e.g. mic open/close, input modality, etc.) and less on the UI elements that will be rendered in the main stage. That state will be maintained by AssistantMainStageModel. - This CL does NOT implement motion specs which are still to be delivered. Bug: b:110228421 Change-Id: Ia15917844133ccf7eb60d1fead05f69cfac3d9ed Reviewed-on: https://chromium-review.googlesource.com/1101973 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#568595}
-
