GitLab

The previous behavior was to select all on mouse down and clear on mouse up. This matched the Cocoa NSSearchField behavior.
On Android the button may be so small users couldn't tap it reliably and only mousedown would fire.

BUG=329326

Review URL: https://codereview.chromium.org/93863007

git-svn-id: svn://svn.chromium.org/blink/trunk@170202 bbb929c8-8fbe-4397-9dbb-9b2b20218538

wrap-unwrap.html becomes these files:

 * wrapKey-unextractable.html
 * wrapKey-lacks-usage.html
 * wrapKey-badParameters.html
 * unwrapKey-lacks-usage.html
 * unwrapKey-badParameters.html

BUG=245025

Review URL: https://codereview.chromium.org/214263002

git-svn-id: svn://svn.chromium.org/blink/trunk@170201 bbb929c8-8fbe-4397-9dbb-9b2b20218538

When firing null-events stop DeviceSensorEventController only after the event has propagated to window.

When no sensors are available chrome should fire an all-null event
into blink. However at the time of firing the active DOM objects
can be suspended or stopped, which can prohibit propagation of the
event to window. Currently the controller will be unregistered in
any case because the event is a null-event. This results in the
potential loss of null-events and the javascript callback is never
executed. To avoid this issue the firing of a null-event should
happen until it effectively propagates to window.

BUG=356750
TEST=http://jsbin.com/pivimoga/1/ (manual)
TEST=https://codereview.chromium.org/214763002/ (browsertest)

Review URL: https://codereview.chromium.org/212983007

git-svn-id: svn://svn.chromium.org/blink/trunk@170200 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=wibling@chromium.org,haraken@chromium.org
BUG=340522

Review URL: https://codereview.chromium.org/214563004

git-svn-id: svn://svn.chromium.org/blink/trunk@170199 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Gauge if removing these compatibility properties is feasible.

R=jochen@chromium.org
BUG=357112

Review URL: https://codereview.chromium.org/214563002

git-svn-id: svn://svn.chromium.org/blink/trunk@170198 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is a follow up that adds a simple layout test to test
https://codereview.chromium.org/201673004/

This test creates an audio context at 48 kHz and a 3 kHz sine wave in
an AudioBuffer that is played through the context. The test verifies
that the output is sufficiently close to the expected sine wave output.

BUG=344375

Review URL: https://codereview.chromium.org/213153003

git-svn-id: svn://svn.chromium.org/blink/trunk@170197 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is split out from 206533004, as it's largely unrelated to
the remaining changes there.

BUG=

Review URL: https://codereview.chromium.org/212793013

git-svn-id: svn://svn.chromium.org/blink/trunk@170196 bbb929c8-8fbe-4397-9dbb-9b2b20218538

allows to have less function paramenters. This patch also
streamlines a bit the code in calculateUnscaledKernelSize.

BUG=356329

Review URL: https://codereview.chromium.org/211513003

git-svn-id: svn://svn.chromium.org/blink/trunk@170195 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Avoid unnecessary descents into nested boxes with floats. (https://codereview.chromium.org/195363007/)

Reason for revert:
Caused a lot of float crashes in ClusterFuzz
https://code.google.com/p/chromium/issues/detail?id=357242

Original issue's description:
> Avoid unnecessary descents into nested boxes with floats.
> 
> Steal a bit from RenderBlock to avoid descending through the same
> stack of nested boxes multiple times while preparing to lay them out.
> 
> 
> This CL creates a 4% improvement in the 
> Performance/Layout/floats_*_nested.html tests.
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170060

TBR=ojan@chromium.org,leviw@chromium.org,bjonesbe@adobe.com,jchaffraix@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/214523007

git-svn-id: svn://svn.chromium.org/blink/trunk@170194 bbb929c8-8fbe-4397-9dbb-9b2b20218538

beyond the end of the color table.  Instead, draw these pixels as black.

This matches Firefox and IE.

BUG=176678
TEST=none
R=abarth@chromium.org, hclam@chromium.org

Review URL: https://codereview.chromium.org/213613002

git-svn-id: svn://svn.chromium.org/blink/trunk@170193 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Also, make ProgressTracker a frame-level concept rather than a page-level concept and merge it with FrameLoader's FrameProgressTracker helper. Send per-frame progress change notifications accordingly.

This depends on https://codereview.chromium.org/180113003/ landing in chromium.

BUG=347643

Review URL: https://codereview.chromium.org/183793002

git-svn-id: svn://svn.chromium.org/blink/trunk@170192 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=vsevik

Review URL: https://codereview.chromium.org/214693006

git-svn-id: svn://svn.chromium.org/blink/trunk@170191 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Drive-by: Do not subscribe each message to the timestamp display setting but rather the ConsoleMessageView

R=eustas, vsevik
BUG=357175
NOTRY=true

Review URL: https://codereview.chromium.org/214693005

git-svn-id: svn://svn.chromium.org/blink/trunk@170190 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL removes explicit SkCanvas::SaveFlags from Blink: they are being
deprecated in Skia, and we are only passing defaults anyway.

R=schenney@chromium.org, reed@google.com, senorblanco@chromium.org

Review URL: https://codereview.chromium.org/212643013

git-svn-id: svn://svn.chromium.org/blink/trunk@170189 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Review URL: https://codereview.chromium.org/214713004

git-svn-id: svn://svn.chromium.org/blink/trunk@170188 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=279426
TBR=joaoe@opera.com

Review URL: https://codereview.chromium.org/214833003

git-svn-id: svn://svn.chromium.org/blink/trunk@170187 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=caseq@chromium.org

Review URL: https://codereview.chromium.org/213003002

git-svn-id: svn://svn.chromium.org/blink/trunk@170186 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=ager@chromium.org, erik.corry@gmail.com, haraken@chromium.org, oilpan-reviews@chromium.org, tkent@chromium.org, vegorov@chromium.org, zerny@chromium.org
BUG=341815

Review URL: https://codereview.chromium.org/213173002

git-svn-id: svn://svn.chromium.org/blink/trunk@170185 bbb929c8-8fbe-4397-9dbb-9b2b20218538

With this API, we can get rid of the precompilation phase. When the script is
compiled the first time, the compilation will produce the lazy function
data (the same data which the precompilation used to produce). This data is then
cached and used when the script is compiled again. Note that the caching only
happens inside one renderer, and the data is not stored on disk.

Getting rid of the separate precompilation phase enables various improvements on
the V8 side, for example, using multiple threads for parsing: one will run a
fast parser to produce the lazy function data, another will run the real
(slower) parser and use the lazy function data to skip over functions.

Perf note: This doesn't regress morejs warm times. That means that the data is
generated and used correctly.

BUG=
R=haraken@chromium.org

Review URL: https://codereview.chromium.org/212983011

git-svn-id: svn://svn.chromium.org/blink/trunk@170183 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=357003
TBR=tkent

Review URL: https://codereview.chromium.org/214683004

git-svn-id: svn://svn.chromium.org/blink/trunk@170182 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=vsevik

Review URL: https://codereview.chromium.org/210243005

git-svn-id: svn://svn.chromium.org/blink/trunk@170181 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Oilpan: Move database closing task in ~DatabaseBackendSync to a pre-finalization hook with HeapHashMap.

This is a preparation to move DatabaseContext class to Oilpan heap.

We need to access a DatabaseContext during closing a database. So, we can't
close the database in ~DatabaseBackendSync if we make DatabaseContext class
GarbageCollected.

We have a HashSet in DatabaseContext to close opening DatabaseBackendSync on
context shutdown.
 - If a DatabaseBackendSync is alive until context shutdown, DatabaseContext can
   close it as ever.

 - If a DatabaseBackendSync is garbage-collected before context shutdown, we
   need to detect it is about to finalized and need to close it. We change the
   HashSet to HeapHashMap<WeakMember<DatabaseBackendBase>,
   OwnPtr<DatabaseCloser>>.  It realizes pre-finalization hook.

BUG=347902

Review URL: https://codereview.chromium.org/214163004

git-svn-id: svn://svn.chromium.org/blink/trunk@170180 bbb929c8-8fbe-4397-9dbb-9b2b20218538

plugins/touch-events-details.html and plugins/transformed-events.html
started to fail when touch point locations became floating point.

This patch fixes that. This depends on
https://codereview.chromium.org/210083002/.

BUG=354787

Review URL: https://codereview.chromium.org/210093002

git-svn-id: svn://svn.chromium.org/blink/trunk@170179 bbb929c8-8fbe-4397-9dbb-9b2b20218538

I forgot to replace a couple of adoptRef() in r170164. This CL fixes them.

TBR=ager
BUG=340522

Review URL: https://codereview.chromium.org/212593012

git-svn-id: svn://svn.chromium.org/blink/trunk@170178 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=
R=pfeldman@chromium.org

Review URL: https://codereview.chromium.org/214633002

git-svn-id: svn://svn.chromium.org/blink/trunk@170177 bbb929c8-8fbe-4397-9dbb-9b2b20218538

When ShardStyleFinder checks whether a given element can reuse other element's style
or not, it uses SelectorChecker with SharingRules mode.
However, RuleFeatureSet used in SharingRules mode doesn't have any information about styles' scope, i.e. SelectorCheckingContext's scope.
So Blink should treat as if scope and behavior are set correctly.

BUG=353428
TEST=fast/dom/shadow/style-sharing-with-content-and-host.html

Review URL: https://codereview.chromium.org/203303002

git-svn-id: svn://svn.chromium.org/blink/trunk@170176 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TEST=no new tests, just refactoring.
BUG=172051

Review URL: https://codereview.chromium.org/214333003

git-svn-id: svn://svn.chromium.org/blink/trunk@170175 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL plumbs the Skia culling API in GraphicsContext, and uses it for
container (RenderSVGContainer & RenderBlock) culling (currently behind
an experimental setting).

R=schenney@chromium.org,senorblanco@chromium.org,pdr@chromium.org

Review URL: https://codereview.chromium.org/204093002

git-svn-id: svn://svn.chromium.org/blink/trunk@170174 bbb929c8-8fbe-4397-9dbb-9b2b20218538

FlameChart was renamed to CPUProfileFlameChart
FlameChart.MainPane was renamed to FlameChart.

BUG=
R=pfeldman@chromium.org

Review URL: https://codereview.chromium.org/212593009

git-svn-id: svn://svn.chromium.org/blink/trunk@170173 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=vsevik

Review URL: https://codereview.chromium.org/214653002

git-svn-id: svn://svn.chromium.org/blink/trunk@170172 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This change made bug 347020 obvious in the sense that without CL 208333018,
LayoutTests would crash.

A side effect of this change is that mac-specific results can be removed.

BUG=347020

Review URL: https://codereview.chromium.org/208243016

git-svn-id: svn://svn.chromium.org/blink/trunk@170171 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Review URL: https://codereview.chromium.org/212773005

git-svn-id: svn://svn.chromium.org/blink/trunk@170170 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Under the Web Animations API it's now possible for new animation players to be
started or existing players modified during frame callbacks. Since timing
updates are lazy it was possible for them to be delayed until the next frame.

This patch forces an update of any outdated players following the execution
of frame callbacks.

NOTRY=true

Review URL: https://codereview.chromium.org/212393002

git-svn-id: svn://svn.chromium.org/blink/trunk@170169 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This means that when style sharing we don't always have to push the bloom
filter and parent stack and also avoids pushing the stack for elements that
only have text node children. Similarly this improves the performance of things
like editing that will insert a text node and immediately call recalcStyle to
cause it to attach by avoiding the parent stack since it's not needed.

I had tried to make the StyleResolverParentPusher smarter to push implicitly in
https://codereview.chromium.org/68253003 but it was reverted in
https://codereview.chromium.org/59883011 because it caused a perf regression by
making us push the filter for elements that only had text node children in
recalcStyle. In fixing that I realized that we push inside ::attach() even if
there are only text children and could get a similar perf improvement by avoiding
pushing in those cases.

R=ojan@chromium.org,eseidel@chromium.org

Review URL: https://codereview.chromium.org/102273004

git-svn-id: svn://svn.chromium.org/blink/trunk@170168 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=ager@chromium.org, erik.corry@gmail.com, haraken@chromium.org, oilpan-reviews@chromium.org, tkent@chromium.org, vegorov@chromium.org, zerny@chromium.org
BUG=341815

Review URL: https://codereview.chromium.org/214503002

git-svn-id: svn://svn.chromium.org/blink/trunk@170167 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Implements transform-style as defined in CSS Transforms[1]. Behavior is
identical to -webkit-transform-style.

Note, this property is guarded by the CSSTransformsUnprefixed runtime feature
(enabled only for testing).

[1] http://www.w3.org/TR/css3-transforms/

BUG=154772

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170013

Review URL: https://codereview.chromium.org/211123002

git-svn-id: svn://svn.chromium.org/blink/trunk@170166 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The browser side is https://codereview.chromium.org/205033002/

BUG=354112

Review URL: https://codereview.chromium.org/205013002

git-svn-id: svn://svn.chromium.org/blink/trunk@170165 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is a minimal change to make [WillBeGarbageCollected] in Event.idl workable.

- This CL adds [WillBeGarbageCollected] to Event.idl and makes minimal changes
to the code base to make it workable.

- This CL is almost just replacing:

  PassRefPtr<XEvent> XEvent::create() { return adoptRef(new XEvent); }

with

  PassRefPtrWillBeRawPtr<XEvent> XEvent::create() { return
adoptRefWillBeRefCountedGarbageCollected(new XEvent); }

BUG=340522
NOTRY=true

Review URL: https://codereview.chromium.org/213363006

git-svn-id: svn://svn.chromium.org/blink/trunk@170164 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Previously, override value was quickly replaced by real data from sensors.
Now, we put sensor data on hold until override is disabled.

This patch also fixes the cleanup/navigation issues with override enabled.

BUG=none

Review URL: https://codereview.chromium.org/209333008

git-svn-id: svn://svn.chromium.org/blink/trunk@170163 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Review URL: https://codereview.chromium.org/211403002

git-svn-id: svn://svn.chromium.org/blink/trunk@170162 bbb929c8-8fbe-4397-9dbb-9b2b20218538