GitLab

Now, PendingConnectionRequestBase handles notifying the
ConnectionDelegate of connection failures itself. This moves the
responsibility for mapping an arbitrary FailureDetailType to
PendingConnectionRequestBase itself; this is the more appropriate place
to handle this since this class it the one responsible for determining
if connection requests should fail without a successful connection.

Bug: 824568, 752273
Change-Id: I022f7030325314157fceeaf41338877b0ec967fc
Reviewed-on: https://chromium-review.googlesource.com/1054207Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557916}

test fonts are now packages as part of app package on fuchsia, so they
can be loaded from /pkg/test_fonts.

Bug: 787020
Change-Id: Ie8507d42cb92b518b83193a448643145c3539fe1
Reviewed-on: https://chromium-review.googlesource.com/1054573Reviewed-by: Peter Beverloo <peter@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557915}

This is a follow-up CL to https://crrev.com/c/1028984.

Change-Id: I16edc81639f67b115761f1f6c5d5351dca2f2f11
Reviewed-on: https://chromium-review.googlesource.com/1054514Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Bence Béky <bnc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557914}

This CL implements a switch to turn off the file view in the coverage
report.

Change-Id: Ia4209e572a18914f9bdb5754ef13cd3c19046950
Reviewed-on: https://chromium-review.googlesource.com/1055599
Commit-Queue: Abhishek Arya <inferno@chromium.org>
Reviewed-by: Max Moroz <mmoroz@chromium.org>
Reviewed-by: Abhishek Arya <inferno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557913}

On ChromeOS there are two different ui events for wheel scrolling:
ui:ET_SCROLL is the event type when the user scrolls with the touchpad
and ui::ET_MOUSEWHEEL is the event type when the user scrolls using an
external mouse wheel device. Wheel scroll latching works differently for
these two types of wheel scrolling:
For touchpad scrolling the sequence starts when the user touches the
touchpad (on a GFC) and ends when the user lifts their fingers (on a
GFS); While for wheel scrolling the sequence starts with the first wheel
event and ends when no wheel event has arrived for the past 500ms.

We always receive a GFC when the user puts their finger down on the
touchpad, but we receive a GFS only at the end of a scroll. So without this
cl if the user lifts their fingers from touchpad without scrolling,
scrolling with mouse wheel will get stuck to the same scrolling sequence
till the next time that the user touches the touchpad again.

This cl makes sure that these two logic for latching don't interfere
with each other: On arrival of a ui::ET_MOUSEWHEEL we reset the
touchpad scrolling state and when the user puts their finger on the
touchpad we end the timer-based latching sequence before setting the
touchpad_scroll_phase_state_.

Bug: 838457
Test: *.ScrollingWithExternalMouseBreaksTouchpadScrollLatching
Change-Id: Id5466e5645f08e6bf44c00f4471dbb3bbf9afc89
Reviewed-on: https://chromium-review.googlesource.com/1052853
Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557912}

Bug: 831829
Change-Id: I328377efd74d64820a66ec4469b688847de43e50
Reviewed-on: https://chromium-review.googlesource.com/1045489Reviewed-by: Tao Bai <michaelbai@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Changwan Ryu <changwan@chromium.org>
Commit-Queue: Tao Bai <michaelbai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557911}

This CL moves the responsibility for acknowledging that swap has
occurred from SoftwareOutputSurface to SoftwareOutputDevice. This is to
allow handling asynchronous swap better. This CL should have no change
in behaviour but a follow up CL will add an overridden implementation of
SoftwareOutputDevice::OnSwapBuffers().

The main change is that instead of SoftwareOutputSurface holding a
TaskRunner the SoftwareOutputDevice does. Only the macOS
SoftwareOutputDevice needs a specific TaskRunner provided. All other
SoftwareOutputDevice implementations just grab the current one on
construction.

Bug: 826633
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I97f487db90fe18f4182d2210539f61f2cb694c6a
Reviewed-on: https://chromium-review.googlesource.com/1055476Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557910}

The |dep_libevent| and |use_libevent| vars are for readability not for
compile time configuration, so they don't need to be in a declare_args
block.

Bug: none
Change-Id: I97cc31248b3a5f4bd6e9e0c72b5b7f4cc5533000
Reviewed-on: https://chromium-review.googlesource.com/1055608
Commit-Queue: kylechar <kylechar@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557909}

Reenables a test that was slightly flaky and disabled earlier today.
This test seems to be pretty solid on older builds of Android, so
enabling conditionally.

BUG=841017,837996

Change-Id: I172a2c859d2a85d922319003a525d65fd44d01a5
Reviewed-on: https://chromium-review.googlesource.com/1053101Reviewed-by: vitaliii <vitaliii@chromium.org>
Commit-Queue: Donn Denman <donnd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557908}

Removes document.createTouch and related tests

createTouchList has relatively high UseCount(around 0.015%), see
https://www.chromestatus.com/metrics/feature/timeline/popularity/2368
We need to address these use cases before remove it.

Postpone createTouchList removal to M69


intent to deprecate and Remove:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/GLbUpUUnQzc

PR to touch-events spec:
https://github.com/w3c/touch-events/pull/96

Bug: 518868
Change-Id: If086b51b775e4be59320c4a1329988787ff6f870
Reviewed-on: https://chromium-review.googlesource.com/1041128
Commit-Queue: Ella Ge <eirage@chromium.org>
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Rick Byers <rbyers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557907}

This CL updates TabStripModel's internal implementation to:
  * Use strong ownership semantics for WebContents.
  * Batch tab-removal notifications.

This cannot be broken into two CLs because non-batched removal notifications
required unclear ownership of WebContents. More details to follow.

Previously, closing tabs was not safe for two reasons:
  * TabStripModelObserver callbacks were sending a half-destroyed WebContents
    instance to obsevers, which would then query internal state of the
    WebContents instance.
  * TabStripModelObserver callbacks could cause re-entrancy, which in turn led
    to internal state changes during observer list iteration!

Previous implementation details:
  * TabStripModel would potentially try to close many tabs at once.
  * In a loop [whose iterator would be dynamically modified via WebContents
    observers]
    * TabStripModel would delete the WebContents instance.
    * This triggered TabStripModel's own WebContents destruction observer.
    * Which in turn called TabStripModel::DetachWebContentsAt()
    * Which then sent callbacks to TabStripModel observers using a half-destroyed
      WebContents instance.
      * Some of these observers would then access state on the half-destroyed
        WebContents instance.
      * Other observers would call back into TabStripModel and perform state
        modifications [e.g. remove another tab].

By observing its own WebContents during callbacks to observers, TabStripModel
was able to react to some types of re-entrant behaviors during tab closure [e.g.
closing a tab]. However, it was not able to correctly react to other types of
re-entrant behaviors [e.g. adding a tab].

Furthermore, observers of TabStripModel needed to query internal state of
TabStripModel during observer callbacks. This meant that behavior was dependent
on observer ordering.

e.g. If there are two observers A and B, and A removes tabs on its observer
callback, and B checks for the currently selected index, then the ordering
between A and B will cause behavior differences for B.

This CL fixes both of these issues. Closing tabs now looks like this:
  * TabStripModel will potentially try to close many tabs at once.
  * TabStripModel updates its internal state to reflect this change. It is now
    in an internally consistent state [in case of re-entrancy from observers].
  * For each tab that was removed:
    * TabStripModel dispatches observer callbacks.
    * TabStripModel deletes the WebContents.

WebContents deletion now happens after observer callbacks, so there are no
issues with half-destroyed WebContents instances.

Tab closure is now re-entrant safe, since internal state is consistent before
sending any observer callbacks, and observer callbacks are not affected by
changing internal state.

This CL discovered several issues:
  * Several tests suites were failing to set an active tab before running test
    logic. This meant that they weren't testing real behavior of the
    TabStripModel.
  * Several observers of TabStripModel were relying on assumptions about the
    internal state of the TabStripModel at the time of the observer callback
    [e.g. if a selected tab was detached, then the index of the detached tab in
    TabDetachedAt() is *still* the currently active index of the TabStripModel.]
    This was not robust against earlier observers performing re-entrancy into
    the TabStripModel].
  * Several test suites were deleting WebContents owned by the TabStripModel.
  * Two tests in DetachToBrowserTabDragControllerTest were testing a condition
    that could never occur in the wild. They were testing that the TabStripModel
    behaves correctly if, halfway through a drag when a tab has been detached
    but not attached, the tab is deleted. With strong ownership semantics, the
    only way for a tab to be deleted is through TabStripModel APIs. Which means
    that in the brief period of time when a tab is not attached to any
    TabStripModel, it is not possible for the tab to be deleted. This behavior
    was previously true as well, it's just that it wasn't obvious that this
    condition couldn't occur.
  * Browser::TabClosingAt was unnecessarily calling SetDelegate(). That is also
    called by TabDetachedAtImpl().
  * There are several places in the code that relied on the assumption that the
    TabStripModel WebContentsDestroyed() callbacks would occur before their own
    WebContentsDestroyed() callbacks.

Bug: 826287
Change-Id: Ia44ad3a405844174407ffddb66e3728bbba44515
Reviewed-on: https://chromium-review.googlesource.com/1045790Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Commit-Queue: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557906}

Full test name:
SafeBrowsingDatabaseManagerCookieTest.TestSBUpdateCookies

Link to failure:
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-xenial-rel/54

Bug: 842195
Change-Id: I807a6815fc65e75b3023095d8abd875ad2cf3e14

TBR=jialiul@chromium.org

Change-Id: I807a6815fc65e75b3023095d8abd875ad2cf3e14
Reviewed-on: https://chromium-review.googlesource.com/1055618Reviewed-by: Tommy Martino <tmartino@chromium.org>
Commit-Queue: Tommy Martino <tmartino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557905}

https://chromium.googlesource.com/catapult.git/+log/6ccd021839d2..c458fd6963db

$ git log 6ccd02183..c458fd696 --date=short --no-merges --format='%ad %ae %s'
2018-05-11 chiniforooshan Telemetry: benchmark duration timestamp is wrong

Created with:
  roll-dep src/third_party/catapult


The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=sullivan@chromium.org

Change-Id: I9acd154cf46116ba6731201fd1936144fee40048
Reviewed-on: https://chromium-review.googlesource.com/1055596Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#557904}

When we write to a file, currently we assume the whole chunk is written.
However when users pull out the SD card or disk, base::File::Write will
return a size less than the chunk size, and the next call to
base::File::Write will return an error.

This CL fixed this issue so FILE_FAILED error can be correctly reported
when the SD card is unmounted.

This CL basically makes the core write function back to this revision:
https://chromium.googlesource.com/chromium/src/+/29db19d0c973a8990283ec4b81111db5bdb8d2de/content/browser/download/base_file.cc#101

Bug: 841559,792775
Change-Id: Icfba65833bf3aec07d30d8d3bed57a9abba7f8d1
Reviewed-on: https://chromium-review.googlesource.com/1053233
Commit-Queue: Xing Liu <xingliu@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557903}

Adds support to get the views find bar text to the global pasteboard.
Also fixes a Cocoa bug introduced in the previous pasteboard change
where the selection is always reset to the beginning at every keystroke.

BUG=826478,827189,842131

Change-Id: If1a639f1997e3fea7fee2c66959e7dcdb2fd3bc7
Reviewed-on: https://chromium-review.googlesource.com/1055195
Commit-Queue: Robert Liao <robliao@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557902}

Add UI for listing accounts. Follow-up patches will add UI for Account
addition, removal and re-authentication.

A screenshot is linked in the bug id.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Bug: 833797
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I9fdeec3d67894096ae5212eea6e4771caee1d177
Reviewed-on: https://chromium-review.googlesource.com/1049690Reviewed-by: Jay Civelli <jcivelli@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Pavol Marko <pmarko@chromium.org>
Commit-Queue: Kush Sinha <sinhak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557901}

This doc is an attempt to consolidate spread out information on permissions.
It asks developers to make features that rely on permissions with warnings
optional, therefore making those permissions optional.
Includes tables of different types of permissions.

Bug: None
Change-Id: I1f0cc3934d676f16854c2725a33738916879efa2
Reviewed-on: https://chromium-review.googlesource.com/914866
Commit-Queue: Crystal Lambert <crystallambert@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557900}

Create WithAccount and WithoutAccount versions of NotOptedInToSync and
OptedInToSync.

This will help us learn what percentage of users have an LST for DICe,
and will tell us how much time users spend in permanent auth error states for
sync.

BUG=839048

Change-Id: I64b5e6b1466d3b6723f2fc2491f6254f6e14e067
Reviewed-on: https://chromium-review.googlesource.com/1051808
Commit-Queue: Florian Uunk <feuunk@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557899}

Bug: 840962
Change-Id: I7df6c302cd13a2a0d8085b26cff4e2fa34f6aca0
Reviewed-on: https://chromium-review.googlesource.com/1054358Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557898}

The story is flaky, failing >10% of the time

TBR=nednguyen@chromium.org
CC=vmiura@chromium.org, sadrul@chromium.org

Bug: 841931
Change-Id: Id949871eb6ebb87b4ffca76ebfe6d1f91cbec154
Reviewed-on: https://chromium-review.googlesource.com/1055589Reviewed-by: Charlie Andrews <charliea@chromium.org>
Commit-Queue: Charlie Andrews <charliea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557897}

Change-Id: I147fe1c169d7e5766704eeed76cdbb83b68d6508
Reviewed-on: https://chromium-review.googlesource.com/1053852Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557896}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/e5661887..2bda0ab6

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: Idcf4cb91b8fd177850f9d08dedb498b5a58746a4
Reviewed-on: https://chromium-review.googlesource.com/1054476Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557895}

A follow-up CL of https://chromium-review.googlesource.com/1050618.

TBR=junov@chromium.org

Bug: 802053
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I221087839763bdf3e09f642a659b7ed322f20492
Reviewed-on: https://chromium-review.googlesource.com/1055480Reviewed-by: Olivia Lai <xlai@chromium.org>
Commit-Queue: Olivia Lai <xlai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557894}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/e7273d25017a..fafa09dbe1d3

$ git log e7273d250..fafa09dbe --date=short --no-merges --format='%ad %ae %s'

Created with:
  roll-dep src/third_party/depot_tools


The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=agable@chromium.org

Change-Id: I72458bd599df30fc1687649075a58a745d1e5d9d
Reviewed-on: https://chromium-review.googlesource.com/1055481
Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#557893}

Enabled in RELEASE, now re-enable this test in DEBUG/MSAN/ASAN.

Tbr: fukino
Bug: 836254
Change-Id: I9aa41ba37f9510979cd72f0d91de0705214dfbe4
Reviewed-on: https://chromium-review.googlesource.com/1055035Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557892}

Bug: crashpad:30
Change-Id: Ifd6e5047d3d82c28ac56e83d7bc87e6cfd68a9fc
Reviewed-on: https://chromium-review.googlesource.com/1044500Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Commit-Queue: Joshua Peraza <jperaza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557891}

This change is a component of a larger refactor that transitions
OffscreenCanvas to using CanvasResource.

BUG=788439

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Id58bca5a71ec4eaad2513a099571e073a34ec866
Reviewed-on: https://chromium-review.googlesource.com/1053999
Commit-Queue: Justin Novosad <junov@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557890}

This is a reland of 48f503a8

Original change's description:
> Composite ScrollTimeline scrollSource when appropriate.
>
> This CL makes being the scrollSource of an active (i.e. the scrollSource is
> scrollable) and attached (i.e. it is being used by at least one WorkletAnimation
> as a timeline) ScrollTimeline a compositing reason. It does not change the
> requirement that the scrollSource must be composited for the WorkletAnimation to
> be sent to the compositor, nor does it change the case where a scrollSource stops
> being composited whilst a WorkletAnimation is running. Those will be addressed in
> follow-up CLs.
>
> Bug: 776533
> Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> Change-Id: Icae43e1c9cfe2720cc739401c4766b592571f231
> Reviewed-on: https://chromium-review.googlesource.com/1036934
> Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
> Reviewed-by: Majid Valipour <majidvp@chromium.org>
> Reviewed-by: Philip Rogers <pdr@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#556541}

Bug: 776533
Change-Id: Ideda71c9dcb54dc94dd7ebf837a84890861030b9
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Reviewed-on: https://chromium-review.googlesource.com/1054252
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557889}

Deprecating was a bit too strong as this is still useful in few
browser tests (which don't have TestBrowserThreadBundle since it's a
unit test construct).

R=jam@chromium.org

Bug: 824431
Change-Id: Id1b44632aca4f02cbf579fe3fb2b0a91c2ac0ba4
Reviewed-on: https://chromium-review.googlesource.com/1054632Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557888}

Enabled in RELEASE, re-enable these tests (listed below) on all bots:

  MultiProfileFileManagerBrowserTest/PRE_BasicDownloads
  MultiProfileFileManagerBrowserTest/BasicDownloads
  MultiProfileFileManagerBrowserTest/PRE_BasicDrive

MultiProfileFileManagerBrowserTest/BasicDrive is all bots. Remove old
comments about that test. Trim the "normal operations" comments.

Tbr: fukino
Bug: 836254
Change-Id: Ia283400c34cd902514c2caf6e767dd30b0c8743e
Reviewed-on: https://chromium-review.googlesource.com/1055231Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557887}

The test has been very flaky for some time.

NOTRY=true
TBR=perezju@chromium.org

Bug: 842180
Change-Id: I86b81726d9e6c0c5f1cbe7956f102738f6cba823
Reviewed-on: https://chromium-review.googlesource.com/1055594
Commit-Queue: Charlie Andrews <charliea@chromium.org>
Reviewed-by: Charlie Andrews <charliea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557886}

Bug: 841616
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I6e7d47e3e127ab9f634ea658c25466e2c53bd07e
Reviewed-on: https://chromium-review.googlesource.com/1054472Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557885}

Enabled in RELEASE, now re-enable this test in DEBUG/MSAN/ASAN.

No-Presubmit: true
Tbr: fukino
Bug: 836254
Change-Id: Ib9b497a92e1112a4061c6d863620b3ae07cfa252
Reviewed-on: https://chromium-review.googlesource.com/1055252
Commit-Queue: Noel Gordon <noel@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557884}

Missed from previous CL:
  https://chromium-review.googlesource.com/1047986

Bug: 768439
Change-Id: Icc7cdcdd5084b9203abeec34e0244c43312ff4b6
Reviewed-on: https://chromium-review.googlesource.com/1054173
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557883}

The test has been flaky for some time now.

NOTRY=true
TBR=nednguyen@chromium.org
CC=wkorman@chromium.org,vmpstr@chromium.org

Bug: 842175
Change-Id: I857bbc9e9077d1378d59cdc14d7a03a7e1a67057
Reviewed-on: https://chromium-review.googlesource.com/1055593Reviewed-by: Charlie Andrews <charliea@chromium.org>
Commit-Queue: Charlie Andrews <charliea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557882}

NOTRY=true
TBR=perezju@chromium.org

Bug: 842163
Change-Id: I148198aaa2e8f6dc4eb7ebeba01ef945f5ad6d4f
Reviewed-on: https://chromium-review.googlesource.com/1054166Reviewed-by: Charlie Andrews <charliea@chromium.org>
Commit-Queue: Charlie Andrews <charliea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557881}

Enabled in RELEASE, now re-enable this test in DEBUG/MSAN/ASAN.

Tbr: fukino
Bug: 836254
Change-Id: Ib1ac9ed1fcd0b920134460f1d9fe3e9e65103ae5
Reviewed-on: https://chromium-review.googlesource.com/1053934Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557880}

Bug: 840511, 838937
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr
Change-Id: I4b688d12e0f08ce265c5796df2d96d473b4591c8
Reviewed-on: https://chromium-review.googlesource.com/1048831
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557879}

Bug: 842156
Change-Id: I9867d575ed580e10e9d082514afc00550fb5337c
Reviewed-on: https://chromium-review.googlesource.com/1055475
Commit-Queue: Mathieu Perreault <mathp@chromium.org>
Commit-Queue: anthonyvd <anthonyvd@chromium.org>
Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557878}

What:
Changes the ContentSettingFramebustBlockBubbleModel to behave more like
ContentSettingPopupBubbleModel. It now uses the same content type but differs
in title and what it observes.

Why:
Popups and Framebusting behavior is merging. They'll use many of the same
strings and they will share content setting storage.

A screenshot of the new bubble is here: https://crbug.com/840356#c9

Bug: 840356
Change-Id: I098b0c3c7d94dcad58b2f01ebb02493503ecd835
Reviewed-on: https://chromium-review.googlesource.com/1050198
Commit-Queue: Josh Karlin <jkarlin@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557877}