- 07 Sep, 2018 40 commits
-
-
Theresa authored
BUG=881237 Change-Id: I7dc76e78f958996d1f61ccb45209e7afb8854f67 Reviewed-on: https://chromium-review.googlesource.com/1213927Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#589599}
-
Devlin Cronin authored
Create a place for Chrome App APIs to go, and move the chrome.browser API there. This is the first API moved from Chrome Apps into the apps- specific directory. This involves a number of steps: - Create a chrome/common/apps/platform_apps/ directory, and create ChromeAppsAPIProvider and ChromeAppsAPIPermissions. The APIProvider is then registered with the singleton ExtensionsClient to provide information about the Chrome Apps APIs to the extension system. - Create chrome/common/apps/platform_apps/api. This includes the API schema definitions (right now, just browser.idl), the features files (_api_features.json and _permission_features.json), and the BUILD.gn to generate the C++ types and JSON API strings. Types are generated in the apps:: namespace, instead of the extensions:: namespace. They are similarly generated into chrome/common/apps/platform_apps/api instead of chrome/common/extensions/api. - Add a ChromeAppsBrowserAPIProvider to register the app-related ExtensionFunctions with the Extensions system. - Move the browser API implementation (browser_api.*) to chrome/browser/apps/platform_apps/api/browser/, and consume the generated types. - Register the new API location with the docserver so that it can look up the API schemas, and bump the docserver version. With this, we have all the pieces necessary to continue moving App- specific APIs en masse to the App-specific directories, and begin to carve out the dependency from the extensions system. Bug: 877240 Change-Id: If3eba512c24ef3d1c27ed5ff3f215f56eb13a818 Reviewed-on: https://chromium-review.googlesource.com/1187129 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#589598}
-
Adam Langley authored
This change adds a getTransports() method to AuthenticatorAttestationResponse[1]. This returns a non-empty sequence of AuthenticatorTranports[2] (without duplicates) where the first value is the transport used by the registration and the following are additional transports that the authenticator supports. This is behind a flag for now while under discussion. See https://github.com/w3c/webauthn/pull/1050. TBRs: mnissler: trivial change to keep up with APIs in fake_certificate.cc sergeyu: trivial change to keep up with APIs in rsa_key_pair.cc TBR=sergeyu,mnissler [1] https://www.w3.org/TR/webauthn/#authenticatorattestationresponse [2] https://www.w3.org/TR/webauthn/#transport Change-Id: I63738f2aa6243c3f2ce2ebe684b70f1caa1c7ef3 Reviewed-on: https://chromium-review.googlesource.com/1180083 Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#589597}
-
Jared Saul authored
This reverts commit ca672c42. Reason for revert: Root cause of trybot failures is still unclear. Creating this revert to run trybots. Original change's description: > Revert "[Autofill] Populate ChromeUserContext in Payments requests" > > This reverts commit d9183af5. > > Reason for revert: suspected of causing https://bugs.chromium.org/p/chromium/issues/detail?id=881420 > > Original change's description: > > [Autofill] Populate ChromeUserContext in Payments requests > > > > This change adds |chrome_user_context| and |full_sync_enabled| values to > > Unmask, GetDetails, Upload, and MigrateCards requests, as long as either > > of the appropriate flags are enabled. > > > > Bug: 840703 > > Change-Id: Ieb3baf980b68add43a3111c0902a03b574b1adcf > > Reviewed-on: https://chromium-review.googlesource.com/1208434 > > Commit-Queue: Jared Saul <jsaul@google.com> > > Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> > > Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#589060} > > TBR=sebsg@chromium.org,jsaul@google.com,dlkumar@google.com > > Change-Id: Id88b0a194dad400be5ba95a36f11d8ebb5ccd1ec > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 840703 > Reviewed-on: https://chromium-review.googlesource.com/1211282 > Reviewed-by: John Budorick <jbudorick@chromium.org> > Commit-Queue: John Budorick <jbudorick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#589215} TBR=sebsg@chromium.org,jsaul@google.com,jbudorick@chromium.org,dlkumar@google.com Change-Id: Ibaab351513bef9c23a4da09cfd8c72514d49731a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 840703 Reviewed-on: https://chromium-review.googlesource.com/1211728Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Commit-Queue: Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#589596}
-
Robert Ogden authored
No behaviorial changes, just moves the lite page tests to a separate file. Bug: 864635 Change-Id: I77a2b542febf1b7052085b401d3af13bbb41c825 Reviewed-on: https://chromium-review.googlesource.com/1213472 Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#589595}
-
Eugene But authored
For windows with opener |scriptMessage.frameInfo.securityOrigin| returns opener's security origin, while document URL can be about:blank. This change allows all the messages coming from the main frame, which was the orginal intention of the code. This CL does not have a test because code that filters cross-origin messages will be removed anyway. Bug: 879464 Change-Id: I15dac35bb3911ad93fc6bd2fe18d1b3c2385e649 Reviewed-on: https://chromium-review.googlesource.com/1212402Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#589594}
-
Scott Violet authored
As we may have two envs, WidgetFocusManager needs some context to know which WidgetFocusManager to return. BUG=874554 TEST=covered by tests Change-Id: I397e14496351fc9839273aa7284c55cdb35555c8 Reviewed-on: https://chromium-review.googlesource.com/1212088Reviewed-by:
Jun Mukai <mukai@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#589593}
-
Eugene But authored
Bug: 878755 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I00f53e806094ecda6449def21b12b54fe386fc47 Reviewed-on: https://chromium-review.googlesource.com/1212271Reviewed-by:
Peter Lee <pkl@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#589592}
-
Sean Topping authored
Cast extensions and embedded frames should not navigate by default. Bug: internal b/74124275 Bug: internal b/112805642 Test: Try to navigate extension page, verify the navigation is blocked. Change-Id: I84174d9ed2d48038edfef0fcb17511694dbdbe3c Reviewed-on: https://chromium-review.googlesource.com/1212344Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Sean Topping <seantopping@chromium.org> Cr-Commit-Position: refs/heads/master@{#589591}
-
John Budorick authored
Bug: 754104 Change-Id: I8f2f41bcc2c41310dbdd5f88083f5818373f2613 Reviewed-on: https://chromium-review.googlesource.com/1213473Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#589590}
-
spirv-chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/3e38c99f5d75..40a68547dcda git log 3e38c99f5d75..40a68547dcda --date=short --no-merges --format='%ad %ae %s' 2018-09-07 dj2@everburning.com Roll spirv-headers in DEPS (#1884) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@40a68547dcda The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I3c2b487c20eb1d270cc12d58adcd938deeb90dec Reviewed-on: https://chromium-review.googlesource.com/1213770Reviewed-by:
spirv-chromium-autoroll <spirv-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: spirv-chromium-autoroll <spirv-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#589589}
-
Tim Zheng authored
This was missed in a previous CL crrev.com/c/1200524. BUG=chromium:879737 TEST=Browsertests passed with code that uses this setting. Change-Id: I6ca354c0a781a16d17fb2be5c12203209992e25b Reviewed-on: https://chromium-review.googlesource.com/1211731Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Tim Zheng <timzheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#589588}
-
Xiaoqian Dai authored
Bug: 881642 Change-Id: I3c1f72a6a2c39c86de60ab7132b2384ddcfa1ca4 Reviewed-on: https://chromium-review.googlesource.com/1211371 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#589587}
-
Sean Kau authored
Verify that an empty blacklist and whitelist are handled properly by adding a unit test for the behavior. Bug: None Change-Id: I3eda6222b211f4306acad7a9c0030b834d6e694e Reviewed-on: https://chromium-review.googlesource.com/1211980Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/heads/master@{#589586}
-
Fabio Tirelo authored
This CL eliminates the "Autofill and payments" page and move "Addresses and more" and "Payment methods" into the main Settings page. A follow-up CL will fix allow access to the "Payment methods" page even if the corresponding toggle is enabled by policy, to allow users to access payment apps. Screenshots (Googlers only): https://drive.google.com/open?id=17VDj8kUArJVxilLaT9CvzYYepewsUGMF Bug: 860526 Change-Id: I9120bd7ca21607485b2b6e144aaf8a5e31abc3c3 Reviewed-on: https://chromium-review.googlesource.com/1208191Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#589585}
-
Xianzhu Wang authored
This is a reland of 91779560 The original change was reverted in https://chromium-review.googlesource.com/c/chromium/src/+/1212483 because of crbug.com/881644. This reland CL fixes the bug by ignoring objects other than LayoutInline and LayoutBlock when painting text clip mask. Original change's description: > [PE] Support float, block, table descendants for background-clip:text > > In https://chromium-review.googlesource.com/c/chromium/src/+/1197462 > we changed box_model_.Paint() to LineBoxListPainter so we no longer > supported text clip for descendants other than inline contents. > > This CL calls ToLayoutBlock(box_model_).PaintObject() to support text > clip of other descendants, and still avoid the original double paint > offset issue of box_model_.Paint(). > > Bug: 880825 > Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I2c4b0e23df11bf300c01f9c804fb7e7d129f3aa0 > Reviewed-on: https://chromium-review.googlesource.com/1211244 > Reviewed-by: Philip Rogers <pdr@chromium.org> > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#589314} Bug: 880825 Change-Id: I0d51678f07422743c952e20a880b257a830157c4 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1213371Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#589584}
-
Martin Robinson authored
Since it is quite complicated to go from an X11 window id to an accessibility tree with AT-SPI, add a pattern option that accomplishes essentially the same thing as the PowerShell scripts for Windows. Eventually we can add support for Windows and the PowerShell scripts will no longer be required. Bug: 879147 Change-Id: Ib9fae5af9849df500f8cbdb6766f22092ac3ac90 Reviewed-on: https://chromium-review.googlesource.com/1196448Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Martin Robinson <mrobinson@igalia.com> Cr-Commit-Position: refs/heads/master@{#589583}
-
Daniel Zhang authored
Currently, AppList autocomplete feature handles arrow key events regardless of whether or not there is autocomplete text present, causing unwanted interactions. Change autocomplete so that it only handles arrow keys when autocomplete text is present. Bug: 881039 Change-Id: I7041646e87e5cd4e95d6299017fa2259899f8994 Reviewed-on: https://chromium-review.googlesource.com/1208718Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Daniel Zhang <oxyflush@google.com> Cr-Commit-Position: refs/heads/master@{#589582}
-
Xianzhu Wang authored
This CL is a result of discussion of naming for https://chromium-review.googlesource.com/c/chromium/src/+/1166158: we think 'state' is a better name than 'context' for these scoped data applying to a particular object during a tree walk, while 'context' is more suitable for data shared among multiple objects. The two static functions of SVGPaintContext are moved into a new class SVGObjectPainter. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I556da29c0975de8550cb2aec146b49e264a3a801 Reviewed-on: https://chromium-review.googlesource.com/1211729 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#589581}
-
Reilly Grant authored
This change adds a DCHECK to the ExtensionWebRequestEventRouter constructor in order to catch when there is no ExtensionsAPIClient set for the process. This appears to be the cause of issue 876658 where an unrelated test fails due to asynchronous initialization of the ExtensionWebRequestEventRouter triggering a null pointer dereference. Adding this DCHECK will confirm that this is the cause of the crash. It is still unclear why the ExtensionsAPIClient would be unconfigured in a browser test. Bug: 876658 Change-Id: I55deefd3a94046cfa30ba37f65593914e2dc974e Reviewed-on: https://chromium-review.googlesource.com/1213276Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#589580}
-
Orin Jaworski authored
The keyword hint view had a chip container with "Tab" label, and the background color assigned was incorrectly conditioned on whether the popup is open. This hint doesn't show when omnibox is unfocused, and only OmniboxPart::RESULTS_BACKGROUND gives the correct color so it is used directly instead of logic. Bug: 879935 Change-Id: I29b157054c30f6ef72d44169ef1539dfd0bfc9a5 Reviewed-on: https://chromium-review.googlesource.com/1211963 Commit-Queue: Orin Jaworski <orinj@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#589579}
-
perfetto-chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/cfe528ef2d04..660b95093bcd git log cfe528ef2d04..660b95093bcd --date=short --no-merges --format='%ad %ae %s' 2018-09-07 taylori@google.com Merge "trace_processor: Add parsing and storing of cpu_frequency events." Created with: gclient setdep -r src/third_party/perfetto@660b95093bcd The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I915dd423dfdfc1cd1b4cdcf86cf79da22e120ec8 Reviewed-on: https://chromium-review.googlesource.com/1213465Reviewed-by:
perfetto-chromium-autoroll <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: perfetto-chromium-autoroll <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#589578}
-
Chris Lu authored
Bug: 874471 Change-Id: Ica1ed661560c979893d583b693ac58b59bf3d4d8 Reviewed-on: https://chromium-review.googlesource.com/1213551 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#589577}
-
Wenzhao Zang authored
Bug: 880619 Change-Id: I4847b3166dc2b2b062dd0ef57a64cbf462c07d83 Reviewed-on: https://chromium-review.googlesource.com/1205993Reviewed-by:
Yury Khmel <khmel@chromium.org> Reviewed-by:
Elijah Taylor <elijahtaylor@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#589576}
-
Lei Zhang authored
Change-Id: I2a7bbb760833230b662eaa38571e0180b81792c0 Reviewed-on: https://chromium-review.googlesource.com/1213372Reviewed-by:
Kevin Bailey <krb@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#589575}
-
Friedrich Horschig authored
It is likely, that at least some of the crashes (see linked bugs) are due to |getContentView()| and |getRootWindowInsets()| returning null when the application is detaching the content view. This CL ensures, that nullable methods are only called once. This should prevent null checks to be affected by timeliness of their calls. Furthermore, it makes sure that the Manual Filling component is in an uninitialized state after |destroy()| was called. Bug: 877687, 876231 Change-Id: I2a92d951714e2d67174c08faf4bf6a484cb2479d Reviewed-on: https://chromium-review.googlesource.com/1210505 Commit-Queue: Friedrich Horschig [CEST] <fhorschig@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#589574}
-
Mike West authored
This patch tests [1], which I'd like to keep small for ease of merging. [1]: https://chromium-review.googlesource.com/c/chromium/src/+/1212846 Bug: 881715 Change-Id: Ib046afb94be0995cd0dc3ac2bda2df90ddbc16fa Reviewed-on: https://chromium-review.googlesource.com/1213086 Commit-Queue: Mike West <mkwst@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#589573}
-
agrieve authored
Change-Id: I94c4c9fb89e6e33f2f87345218607a1ea772d800 Reviewed-on: https://chromium-review.googlesource.com/1212564 Commit-Queue: agrieve <agrieve@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#589572}
-
Xiaoqian Dai authored
Currently there is no fling event for browser window in tablet mode. We'll add fling event handling for browser window in tablet mode later. Bug: 881618 Change-Id: I683458455449fb2fe8e903e503c49072c917dc2f Reviewed-on: https://chromium-review.googlesource.com/1212084 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#589571}
-
Ryan Hansberry authored
Change-Id: Iaffbe95ec76df64c104654e2bc40f1dd4d0a99d3 Reviewed-on: https://chromium-review.googlesource.com/1211873Reviewed-by:
Jeremy Klein <jlklein@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#589570}
-
Johannes Henkel authored
Resolve domain dependency cycle Page <-> Network, by moving ResourceType to Network. Also add some "depends on" declarations that were missing. This breaks client code (easy to fix) but won't change the wire protocol. Change-Id: I8b0321d45923b8897f39cb7420e63a7ddffd5357 Reviewed-on: https://chromium-review.googlesource.com/1212091Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Johannes Henkel <johannes@chromium.org> Cr-Commit-Position: refs/heads/master@{#589569}
-
Daniel Zhang authored
Allow AppList autocomplete to complete suggestions if SearchBoxView recieves a tap gesture event. Approved by UX. Bug: 881617 Change-Id: Ic282fef7623c2f9199d9022289d70e96d3f0111a Reviewed-on: https://chromium-review.googlesource.com/1212085Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Daniel Zhang <oxyflush@google.com> Cr-Commit-Position: refs/heads/master@{#589568}
-
Rayan Kanso authored
Bug: 780025 Change-Id: I916782c0e85e4a6fee87389f0b6909ec66eae18b Reviewed-on: https://chromium-review.googlesource.com/1210123Reviewed-by:
Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#589567}
-
Quan Nguyen authored
There are two important bits of nuance behind removing the call to SetIgnoreIdleStatus(false). 1. After calling RequestUpdateCheck(), we will eventually receive a status update with UPDATE_STATUS_CHECKING_FOR_UPDATE. UpdateStatusChanged will see this and no longer ignore UPDATE_STATUS_IDLE, so we don't need to SetIgnoreIdleStatus(false) manually. 2. It is possible to receive an UPDATE_STATUS_IDLE after calling RequestUpdateCheck() and before receiving the UPDATE_STATUS_CHECKING_FOR_UPDATE. This seems to happen a lot when resuming a previous forced-autoupdate. The UpdateScreen should ignore any UPDATE_STATUS_IDLE until it receives either an UPDATE_STATUS_CHECKING_FOR_UPDATE or an UPDATE_STATUS_REPORTING_ERROR_EVENT. Bug: 873270 Change-Id: I3d7d0d05e7abf60579a80a62345e4e755e633894 Reviewed-on: https://chromium-review.googlesource.com/1208138Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Quan Nguyen <qnnguyen@chromium.org> Cr-Commit-Position: refs/heads/master@{#589566}
-
Moe Ahmadi authored
The migration was added for Android only by mistake (crrev.com/c/1194598) Bug: 870328,877801 Change-Id: Ie21b24ce67ef437dfa60755a5ec9ce03d5eb2661 Reviewed-on: https://chromium-review.googlesource.com/1213548Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#589565}
-
Wez authored
- ChildThreadImpl now takes a |quit_closure|, which is provided by all sub-classes when used out-of-process. - Sub-classes which can run in-process instead pass base::DoNothing() to ChildThreadImpl, to instead rely on the in-browser Thread having Stop() invoked on it, to shut them down. Bug: 859095 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I0251db64063601a6a9de8883c8558e25104e5b0b Reviewed-on: https://chromium-review.googlesource.com/1200839Reviewed-by:
enne <enne@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#589564}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/157216ad..98633bd1 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ief253615e1fa4e12de8dd1fbac6284f01362986e Reviewed-on: https://chromium-review.googlesource.com/1213368Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#589563}
-
chaopeng authored
This test failing because it need some rAFs for commit. Bug: 875097 Change-Id: I10aacf4a55ea8fe277fef1fc68b4d6c9ee287190 Reviewed-on: https://chromium-review.googlesource.com/1213545Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Jianpeng Chao <chaopeng@chromium.org> Cr-Commit-Position: refs/heads/master@{#589562}
-
mrefaat authored
LoadQuery is called for commands such as (paste&Go, QRScan and voice search). the query passed to it is not sanitized and can have javascript which shouldn't be executed. This CL sanitize the input of the LoadQuery command to make sure it's safe. The sanitization works by compressing white spaces from the beginning of the query & then strip javascript: scheme if it exists on the beginning of the query. examples of sanitization results: "javascript:abc"->"abc", "javascript:" -> " java" -> " java" Bug: 877984 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I8524632092d3ecb0c4c23f26e3baa25ac305e58b Reviewed-on: https://chromium-review.googlesource.com/1205601Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#589561}
-
Nico Weber authored
They haven't been needed in (at least) the last 4 builds, so lock in the progression. The pak file determinism progression is likely from https://chromium-review.googlesource.com/1164536 The v8 isolate is still nondeterministic in component builds, so add some (hopefully temporary) logic to have files that are nondeterministic only in component builds. Bug: 330263 Change-Id: I721b1ff543410c066d6ef6ea6ffedbc4ba4f180b Reviewed-on: https://chromium-review.googlesource.com/1213525Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#589560}
-