GitLab

Could not repro the issue but based on the stack trace, looks like post
animation code is running after window is destroyed, so stop observing
animations when object is destroyed.

Test: none
Bug: 899459
Change-Id: Ia1ec07057281c91aaa390ab90df28910fa74aaac
Reviewed-on: https://chromium-review.googlesource.com/c/1308610Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604372}

Error page isolation requires process swaps and locking processes to
origin. It isn't clear Android WebView supports these quite yet, so
disable this feature for now.

Bug: 800544, 838161
Change-Id: Idb5c4a22aee3c6d40560a7676a7659d9101ee2e8
Reviewed-on: https://chromium-review.googlesource.com/c/1310566Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Commit-Queue: Nasko Oskov <nasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604371}

Using wpt-import in Chromium 6b65b358.

Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/26812

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

NOAUTOREVERT=true
TBR=lukebjerring

No-Export: true
Change-Id: I7232e61c3fc886786184f92f57849cd43d897fe3
Reviewed-on: https://chromium-review.googlesource.com/c/1310474
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604370}

Updates JNI wrapper to use the version that optimizes the
best with R8, and includes a testing flag/setter.

Bug: 898261
Change-Id: I343dd1a4f470fb8067dfd4cdb31d7c545b5f3717
Reviewed-on: https://chromium-review.googlesource.com/c/1308098
Commit-Queue: Aiden Benner <abenner@google.com>
Reviewed-by: agrieve <agrieve@chromium.org>
Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604369}

Bug: 876117
Test: manual
Change-Id: Icad9c7939161c5b488b0852a59f1ad58c4af5658
Reviewed-on: https://chromium-review.googlesource.com/c/1306414Reviewed-by: Jenny Zhang <jennyz@chromium.org>
Reviewed-by: Weidong Guo <weidongg@chromium.org>
Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604368}

Originally the landing page would be visible briefly until modules
finished initializing. This CL makes it so the whole view-manager is
hidden until steps are ready to be shown. The animation had also been
changed to exit immediately, so 1) the users don't see remnant of
fade-out of the landing view when they land on //welcome/new-user
and //welcome/returning-user directly, 2) prepare the transition to
match mock, which doesn't want a fade-out animation for the exiting view.

Bug: 874151
Change-Id: Ie0d3853639686b51205bd37cd1dc4035bc96b94d
Reviewed-on: https://chromium-review.googlesource.com/c/1306840
Commit-Queue: Scott Chen <scottchen@chromium.org>
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604367}

- Renamed DocumentAttached() to DidAttachDocument() so that function names better express what the function is trying to accomplish
- Remove extraneous GetDocument() calls
- Spellfixing

"I think that DocumentAttached(..) is misleading, since it seems to imply that it's going to find out whether a document is attached and return a boolean representing that. Instead, it's in essence attaching to a document (or rather the document’s context, but with some clearing and such going on as well). Therefore, I'm thinking of perhaps renaming DocumentAttached(..) to AttachDocument(..) or AttachToDocument(..) in another CL." -Darwin in another CL

Bug: 896479
Change-Id: I4b9e2cd9a998f2b18acdbca9e2339c7ca5a124e8
Reviewed-on: https://chromium-review.googlesource.com/c/1300680
Commit-Queue: Darwin Huang <huangdarwin@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604366}

More of third_party/* has been made gn check clean and this CL
enables it for another 14 directories. Most (but not all) of the
rest look non-trivial.

Bug: 898837
Change-Id: I95c7348d8c1fa0bf85e0345aaaa9228f971a300e
Reviewed-on: https://chromium-review.googlesource.com/c/1309743Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#604365}

Enables the injection handler used in Manual Fallback to work on frames.
Adds testing utilities to support tapping an element in a window
frame.
Adds the frame messaging flag to the manual fallback test bot.

Bug: 845472
Change-Id: Id054361af1f4be5450f13cd0afabe46e24ea11ff
Reviewed-on: https://chromium-review.googlesource.com/c/1292409
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604364}

The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio
TBR=cr-fuchsia+bot@chromium.org

Change-Id: If9bfa6f520533a87f923d592ffb658b19d9118c1
Reviewed-on: https://chromium-review.googlesource.com/c/1310557Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#604363}

Bug: 836238
Change-Id: Iafd29fb293af9b284ae9ab98b2f6c12bb27fa9a0
Reviewed-on: https://chromium-review.googlesource.com/c/1308634
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604362}

Helper class to set up state for demo sessions and control how the
Demo Mode resources component loads.

Supports both core Demo Mode unit tests and other unit tests that need
to verify interactions in Demo Mode.

Bug: None
Change-Id: Id465d3f5b9bceaa3d4184feb01506504f49e6a51
Reviewed-on: https://chromium-review.googlesource.com/c/1300494Reviewed-by: Stefan Kuhne <skuhne@chromium.org>
Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Commit-Queue: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604361}

Enable SearchEngineTabHelper to add new TemplateURL to TemplateURLService by following steps:
1. Receive messages of OSDD(Open Search Description Document) <link> in page from Js;
2. Download, parse OSDD XML file, and create TemplateURL;
3. Add TemplateURL to TemplateURLService.

The OSDD functionaliy on Js side has not been changed yet, but SearchEngineTabHelper
and SearchEngineTabHelperTest is decoupled from it. search_engine.js will
change from positive calling into message mechanism for OSDD in another CL.

Bug: 433824
Change-Id: I113e362ed1fa38cff43cea1e8fe2f591fac469c0
Reviewed-on: https://chromium-review.googlesource.com/c/1309746
Commit-Queue: Yi Su <mrsuyi@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604360}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/673cf8fc2ca9..59f591bd4e30


Created with:
  gclient setdep -r src-internal@59f591bd4e30

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: Ib6ab3925b8507eee0d3c6541bf363d2e7a92086d
Reviewed-on: https://chromium-review.googlesource.com/c/1310595Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#604359}

Disable virtual/threaded/http/tests/devtools/tracing/timeline-paint/
timeline-paint-with-layout-invalidations.js on Win as the test is timed
out on Win10 and Win7.

Bug: 899710
Change-Id: I12e86eab3e04485b2a902d30283b6b4be1a6ff43
Tbr: alph@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/1310636Reviewed-by: Owen Min <zmin@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604358}

Followup to https://chromium-review.googlesource.com/c/chromium/src/+/1308992.
From the logging, I've determined that the Keychains folder does not exist on
these simulators when they are created, which is why my original glob did not
work.

I am not sure what differs between these simulators and the ones from
testing bits of test_runner.py locally (where the glob worked), but I am
trying creating the Keychains folder first and copying the certificate, to
see if that is sufficient.

Change-Id: I676ebc109517d3bd2600d53ec2fa38d35f800c39
Reviewed-on: https://chromium-review.googlesource.com/c/1309355Reviewed-by: Sergey Berezin <sergeyberezin@chromium.org>
Commit-Queue: ericale <ericale@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604357}

This implements three parts of the new tab-loading animation:

* Bottom bouncing pill of the indeterminate waiting state.
* Painting the loading state.
* Fading out the loading state animation once progress hits 100%.

This also makes all BrowserView tab animations' indeterminate state run
off of the same timer so this animation stays in sync across multiple
tabs. This timer restarts every time the animation timer starts, so the
first visible animation starts at 0 but following ones use the same
elapsed time as the already-running one.

Bug: chromium:822067
Change-Id: I7f5c38a92dc26556d11a01765831497027913f38
Reviewed-on: https://chromium-review.googlesource.com/c/1060605
Commit-Queue: Peter Boström <pbos@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604356}

- Moves model code from InfobarCoordinator to InfobarContainerMediator.
- Makes InfobarContainerMediator InfobarContainerStateDelegate instead
of InfobarContainerVC, this way all communication to the VC is made via
the consumer protocol.

Bug: 892376
Change-Id: I8d4887f614d0bc1ceb0510d4c6d232c0c13281c0
Reviewed-on: https://chromium-review.googlesource.com/c/1297580
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604355}

Remove implicit cast and convert relevant callsites to work around it.
Add hash, ostream and comparison operators to MLC.

TBR=gab@chromium.org
R=gab@chromium.org
CC=​​​​alexclarke@chromium.org
BUG=891670,826465

Change-Id: I04cda773496e1690160fb7b4236f6db9ab8c7d38
Reviewed-on: https://chromium-review.googlesource.com/c/1292886
Commit-Queue: Alexander Timin <altimin@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604354}

When the user is signed in but not syncing, the title
in the user menu is changed to "Sync is off".

TBR=jochen@chromium.org

Bug: 900252
Change-Id: I29542e2c89fe381339ff8800a78c40a91092fe3d
Reviewed-on: https://chromium-review.googlesource.com/c/1310434Reviewed-by: Thomas Tangl <tangltom@chromium.org>
Commit-Queue: Thomas Tangl <tangltom@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604353}

Give more IDs to ash/ and ui/. Sort some out of order entries.

Change-Id: I202b3516e73ff0b4e34eda2c601d1f6e19f0887a
Reviewed-on: https://chromium-review.googlesource.com/c/1310118Reviewed-by: Tao Wu <wutao@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604352}

Changing common to a static_library was a mistake--the
GuardedPageAllocator is a singleton and needs to be in a separate
component to ensure that duplicate symbols create multiple singletons in
the process.

Bug: 896019
Change-Id: Iaee22e2e52180b6a8a7e59c106d96b10bb31b922
Reviewed-on: https://chromium-review.googlesource.com/c/1309425Reviewed-by: Vitaly Buka <vitalybuka@chromium.org>
Reviewed-by: Albert J. Wong <ajwong@chromium.org>
Commit-Queue: Vitaly Buka <vitalybuka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604351}

This CL disables VoiceSearchNavigationsTest.NotVoiceSearchNavigation.

TBR=justincohen@chromium.org

Bug: 900667
Change-Id: I662e767f993c151ca133b48d0afe654707548c7b
Reviewed-on: https://chromium-review.googlesource.com/c/1310560Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604350}

Currently the chrome-extension scheme is treated as 'insecure' in
cast_shell, and that makes service worker unavailable in cast_shell.
Add chrome-extension scheme to secure_schemes to solve this.

Bug: internal b/111359399
Test: check window.isSecureContext is true
Change-Id: Ic1d68ceac3b522f2c0140910d53e664fd9ff895d
Reviewed-on: https://chromium-review.googlesource.com/c/1308914
Commit-Queue: Jiawei Li <lijiawei@chromium.org>
Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604349}

This reverts commit b68dde46.

Reason for revert:
The test is still flaky. Fails with same error as before.
e.g.
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-dbg/8629

Original change's description:
> Mash: Re-enable a test which may no longer be flaky.
> 
> test is ExtensionDisabledGlobalErrorTest.UninstallWhilePromptBeingShown
> 
> Bug: 883371
> Change-Id: I1ce860a5c25e9b6b791be681e98907aed9ffb9bc
> Reviewed-on: https://chromium-review.googlesource.com/c/1305873
> Reviewed-by: James Cook <jamescook@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#603591}

TBR=jamescook@chromium.org,estade@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 883371
Change-Id: I7b232b609a0f60a3c68c61822871ba8dadd6109f
Reviewed-on: https://chromium-review.googlesource.com/c/1310506Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604348}

Re-enables pixel tests after rebaselining due to the
EnableGpuRasterizationViewportRestriction experiment.

TBR=kbr@chromium.org for second half of pixel test rebaseline

Bug: 899399
Change-Id: Icc11b44b9b2240b4e70ffe5bf78f1a24673db0ff
Reviewed-on: https://chromium-review.googlesource.com/c/1309103
Commit-Queue: Eric Karl <ericrk@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604347}

We are creating a prototype for a Send Tab To Self Feature, in collaboration with
the better together team . the Design Doc was originally written by hansberry@
and can be seen here

https: //docs.google.com/document/d/11WONDgBRJ3kZGQZQ44_6f9lGXsIX7zOoP4PDOjT3shk
Change-Id: Ic3a07d0315336a1308f164a567720bd36a9c5d1a
Reviewed-on: https://chromium-review.googlesource.com/c/1297391Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: ssid <ssid@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604346}

https://chromium.googlesource.com/angle/angle.git/+log/193a284d34d2..5ca3e5a0b285


git log 193a284d34d2..5ca3e5a0b285 --date=short --no-merges --format='%ad %ae %s'
2018-10-31 ynovikov@chromium.org Fix ShaderStorageBlockOutputHLSL::writeEOpIndexDirectOrIndirectOutput
2018-10-31 jiajia.qin@intel.com ES31: add row major matrix support (part 1)


Created with:
  gclient setdep -r src/third_party/angle@5ca3e5a0b285

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=ynovikov@chromium.org

Change-Id: I48a7edc3a87fe4fcb57c313d56b4d38d79de4800
Reviewed-on: https://chromium-review.googlesource.com/c/1310553Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#604345}

GetIncognitoId() (in theme_service.cc) was not providing the incognito variants of control button background colors, so the caption buttons were receiving the non-incognito colors to blend against - causing them to have insufficient contrast in incognito with certain themes.

Bug: 889711
Change-Id: I801ed5b915d67e12b6e998c8d96400baf04c3e40
Reviewed-on: https://chromium-review.googlesource.com/c/1310497
Commit-Queue: Ryan Meier <rameier@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604344}

This is a reland of 491ed062

Original change's description:
> [DevTools] Merge InspectorSession and DevToolsAgent::Session
>
> These are not needed as separate entities anymore, after making
> workers reuse DevToolsAgent::Session. We merge them into a single
> DevToolsSession class.
>
> Bug: 775132
> Change-Id: I213de7e33c5b7ce12d4f58e1b2daa363ad563b12
> Reviewed-on: https://chromium-review.googlesource.com/c/1282207
> Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
> Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#603869}

TBR=caseq@chromium.org

Bug: 775132
Change-Id: I066cb72659bcbd7ad992735c5249503d34578d0d
Reviewed-on: https://chromium-review.googlesource.com/c/1308983Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604343}

This patch is a followup to [1] and paints the LayoutView hit test
rects into the scrolling contents layer, like the background does. This
improves performance because the hit test rect does not need to be
repainted on every scroll change.

With this patch we no longer regress raster in the rendering.desktop
touch_handler_scrolling benchmark.

[1] https://crrev.com/603335

Bug: 888269
Change-Id: I27864ed6d612c26f2258b60805778b2c6f894d62
Reviewed-on: https://chromium-review.googlesource.com/c/1303868
Commit-Queue: Philip Rogers <pdr@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Xianda Sun <sunxd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604342}

Replace "bool is_scripted" with an enum. This makes it clearer what a
true or false argument means, and it sets up the code to potentially
have other print modes in the future.

Change-Id: I498140820b8b6ffc4380c07fa9988a1b33e534e9
Reviewed-on: https://chromium-review.googlesource.com/c/1309416Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604341}

NTP title should be set earlier in DidStartNavigation.  It was previously moved
to didFinish to sync up with changes to ios/web.

Also adds an OWNERS file.

Bug: 826369
Change-Id: I1f65118aa16425b44b96e14802638e67f1acd24d
Reviewed-on: https://chromium-review.googlesource.com/c/1308495
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604340}

It currently uses RepeatingCallback, and resets the callback after
running it.

Also initialize members in the header and fix some nits.

Change-Id: I92248c94993fa09ab4061a7ef17f4a2a82be4d8d
Reviewed-on: https://chromium-review.googlesource.com/c/1308911Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604339}

- Move various ext/ sources to the top, so they are all together.
- Move skia features to the bottom.

Change-Id: I7dcf0cebc8f0ae2bbb8b4950cce2a5dbce703ae0
Reviewed-on: https://chromium-review.googlesource.com/c/1309419Reviewed-by: Ben Wagner <bungeman@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604338}

This test is flaking quite a bit:
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=chrome_public_test_apk&tests=org.chromium.chrome.browser.SubresourceFilterTest%23resourceNotFiltered

TBR=csharrison@chromium.org

Bug: 899903
Change-Id: I4785f8ac1d517a23696aaba40a9a5e245440f47d
Reviewed-on: https://chromium-review.googlesource.com/c/1310503Reviewed-by: Clark DuVall <cduvall@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604337}

Add flaky expectations for virtual/fractional_scrolling_threaded/fast/scrolling/listbox-wheel-event.html

fast/scrolling/listbox-wheel-event.html is flaky on virtual/threaded/ test
suite, virtual/fractional_scrolling_threaded/ is virtual/threaded/ plus
FractionalScrollOffsets flag. It should be same flaky with
virtual/threaded/fast/scrolling/listbox-wheel-event.html.

Bug: 841567
Change-Id: If3e0c7b465ccd3935e105fd52c946cd75c8651dd
Reviewed-on: https://chromium-review.googlesource.com/c/1309993Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Jianpeng Chao <chaopeng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604336}

BrowserSwitcher is no longer controllable by the prefs themselves. They
have to be set through the policies to be effective.

Bug: 876805
Change-Id: I9f819de1d4b30df5ca299653a24fa392060ed820
Reviewed-on: https://chromium-review.googlesource.com/c/1293560
Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604335}

This was broken when PerformPreMainMessageLoopStartup() started
getting called on Android by this CL:
https://chromium-review.googlesource.com/c/chromium/src/+/1213316/

That call made the variations service determine the URL and start
fetches before the restrict mode parameter was set, causing the
issue.

This CL also turns a DCHECK that would have caught this into a
CHECK - which would have caught this had it been enabled on the
release official builds.

Bug: 899058
Change-Id: I66dc658950f3cccb4013a3902b1223ef529936b7
Reviewed-on: https://chromium-review.googlesource.com/c/1309118Reviewed-by: Jesse Doherty <jwd@chromium.org>
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604334}

When a window is focused, the ATK_STATE_ACTIVE state should be available
in the list of object states for a window. Additionally, we should
receive state change, activate, and deactivate events when focus changes.
This change adds those features, but does not produce the appropriate
events for dialog boxes, which is the second part of adding full support
for the active state.


Bug: 866336
Change-Id: I890c39ada3d368c547d3b8a0801cc90fa1e2371a
Reviewed-on: https://chromium-review.googlesource.com/c/1257831
Commit-Queue: Martin Robinson <mrobinson@igalia.com>
Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604333}