GitLab

After crrev.com/c/1915021 that connects the ambient light readings from
powerd to the color transform matrix, we can enable ambient color light
by default.

This CL additionally removes the flag in about://flags since it does
not have any effect on most of devices where ambient color is not
supported.


Bug: 1021193
Change-Id: I2f4b7c57b99e84cc2cf713bb92924b9d57d2d579
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938627Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Daniele Castagna <dcastagna@chromium.org>
Auto-Submit: Daniele Castagna <dcastagna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720606}

After this change, all Telemetry perf testers will use shard maps,
so it will be easier to do some cleanups.

Bug: 902089
Change-Id: I141614659a3b46aa9b67932f28d4f2a817ae3110
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941287
Commit-Queue: Caleb Rouleau <crouleau@chromium.org>
Reviewed-by: John Chen <johnchen@chromium.org>
Auto-Submit: Caleb Rouleau <crouleau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720605}

If SkiaRenderer is missing a texture during draw it tries to allocate an
equivalent fallback texture of the correct size and attributes. This
doesn't work for externally allocated textures.

Currently ImageContextImpl::CreateFallbackImage() creates a
GrBackendTexture of type k2D instead of kExternal. This triggers a later
SkASSERT in GrTextureProxy::onValidateSurface(). When SkAsSSERTs are
disabled it still doesn't draw anything. Just skip drawing the fallback
texture by proving a null SkPromiseImageTexture instead.

Bug: 1029522
Change-Id: I6f370694116e8a47e8885492f1365783c046db65
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946627Reviewed-by: Jonathan Backer <backer@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720604}

Change-Id: Id118c5a81446635f02fc23ae25ffd007ec400c1c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1945330
Commit-Queue: Jarryd Goodman <jarrydg@chromium.org>
Reviewed-by: Jarryd Goodman <jarrydg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720603}

I'm not entirely sure why this fixes the issue, but after a couple hours
it was all I was able to come up with. Interestingly, if I move the line
inside the picker's init, the issue remains.

https://screenshot.googleplex.com/UzOWW6uOVRE.png
https://screenshot.googleplex.com/XPG9EPkODoP.png

Bug: 1028090
Change-Id: I8b6ce7135356c863aa396b238ce9a51b0dac26f9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940955Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Commit-Queue: Alfonso Garza <alfonsogarza@google.com>
Auto-Submit: Alfonso Garza <alfonsogarza@google.com>
Cr-Commit-Position: refs/heads/master@{#720602}

Bug: 1014148
Change-Id: Ib60bc2d53649ad869f5fd121687ba4931d15efa8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940493Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Doug Arnett <dougarnett@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720601}

This CL is fixing the memory leak describe here:
  https://bugs.chromium.org/p/chromium/issues/detail?id=974239

Without this patch, tasks to check the file existence can be
queued for the same download without being executed. This can
lead to terrible scenario with billion of tasks queued.

This CL is adding a set to keep track of the current pending
download queries. This way, there can not be two pending tasks
at the same time for each download item.

Bug: 974239
Change-Id: I52fb23ce50ba8542ed262552dd7f9aaaa5589548
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946783Reviewed-by: François Doray <fdoray@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720600}

Allow passing a URL parameter to specify the sort method to be used upon
page load. This will be used by a storage pressure notification which
optionally navigates the user to all sites. The all-sites page will be
sorted by storage, when the user is forwarded here from a storage
pressure notification.

example usage: chrome://settings/content/all?sort=data-stored

Bug: 997258
Change-Id: I4ccc547c2dc4aad974f06debd6e0d4e461e4a0b3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865259
Commit-Queue: Jarryd Goodman <jarrydg@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720599}

Change-Id: I32fbf0e9e9b7cb1642b044ecc2a2dae1636c34d1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944270Reviewed-by: Roger Tawa <rogerta@chromium.org>
Reviewed-by: Daniel Rubery <drubery@chromium.org>
Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720598}

The --chrome_pass Closure compiler flag is only needed for code that relies on
cr.js (cr.define(), cr.exportPath() and friends). For JS code that has migrated
to JS modules --chrome_pass is not necessary.

Explicitly removing --chrome_pass not only makes type-checking faster, but
also ensures that eventually we don't depend on this pass at all.

Note that using |is_polymer3| also opts out a js_type_check() target from
--chrome_pass, but without the new |uses_js_modules| there is no easy way
for non-Polymer code to opt-out.

Note: With this change any JS code that uses JS modules must specify either
|uses_js_modules| or |is_polymer3| attributes.

Bug: 1028829
Change-Id: I4e019770e36ac460402123c5413be6c95e32fef2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938248Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720597}

Later when experimental tagging support has landed we'll be able to add
an additional test asserting that PDFs are tagged when the right command-line
flag is passed.

Bug: 607777
Change-Id: I5030456efeb0b005d7153eb8c9e36050d6051c72
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1927974Reviewed-by: Eric Seckler <eseckler@chromium.org>
Reviewed-by: Will Harris <wfh@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720596}

The window system can handle mouse events without them, but
this causes a weird conditions like the ones reported in the
bug. More specifically,
- sending a new mouse event enables the mouse event automatically
- on enabling mouse events, NativeCursorManagerAsh can set
  the last mouse location to an unexpected location
  https://cs.chromium.org/chromium/src/ash/wm/native_cursor_manager_ash.cc?sq=package:chromium&g=0&l=158
- further MouseMove / Press / Release / Click APIs can be affected
  by this.

Bug: 1028413
Test: tast run ui.OverviewScrollPerf ui.WindowResizePerf
Change-Id: I93628663444b405501129a96d32889478dba7a41
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940713Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Jun Mukai <mukai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720595}

The flag usage has been removed from devtools-frontend [1].

[1]: https://crrev.com/c/devtools/devtools-frontend/+/1942288

Change-Id: I1436bc8be3258c84a86be9d86df9434647fca180
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942336Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720594}

Now that the flags for browser plugin have been removed, we remove the
code to support browser plugin from the guest view JS implementation.

Bug: 533069
Change-Id: Ida04f0ce856d0f318835d6369558a3e38cac47e9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943579Reviewed-by: James MacLean <wjmaclean@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Commit-Queue: Kevin McNee <mcnee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720593}

The calls to BelongsToCurrentThread appear to be no-ops at the moment, and
assume that they were intended to be DCHECKS, so a quick CL to fix.

Change-Id: I33a6c8e05312b528d5a4e89fd18a0cff6281cd28
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762238
Commit-Queue: Xing Liu <xingliu@chromium.org>
Reviewed-by: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720592}

This test doesn't work on Mac and probably won't ever be made to work.
Issue 899286 obscured this test breakage from us, also.

Bug: 1028239
Change-Id: I9f9865ba7ea4fd626fe50298e60c772876b0439b
Tbr: raymes@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943473Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720591}

MessageLoop is going away soon.

This CL was uploaded by git cl split.

R=mfoltz@chromium.org

Bug: 891670
Change-Id: I1678e50cd81155739b1493f68de637bc781abcb9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943186
Auto-Submit: Carlos Caballero <carlscab@google.com>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Commit-Queue: mark a. foltz <mfoltz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720590}

Change-Id: I7b613853896b4090bf1cd00cdeb6d986c9add676
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926807Reviewed-by: Theresa  <twellington@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Commit-Queue: Brandon Wylie <wylieb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720589}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/6d4b96eb..be74b8b6

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I87065f503e8e28af5a2d58a7938f8b5542bd70df
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946626Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#720588}

These virtual functions were used by the ActionRunner, which has been
refactored in CL 1929863.

Bug: 1027395
Change-Id: I43091b984fc28555234fdbe11366ea91c225a7b9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931383
Commit-Queue: Sorin Jianu <sorin@chromium.org>
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720587}

This is a reland of e38327e1

FindIt automatically reverted this CL but it looks like a false positive

Original change's description:
> Spellcheck cleanups
>
> Introduce a build flag for the remote spelling service, and stop
> compiling/instantiating SpellingServiceClient on platforms that
> don't use it (Android). Also try to reduce the number of platform
> ifdefs in spellcheck code, in favor of buildflag usage. Reduce
> the amount of code that's compiled but never used by removing
> several SpellCheckHostImpl methods on mac/win.
>
> Also remove a couple of obsolete includes.
>
> Change-Id: I5697a5d3f891f69159d5bba855ee72e11a3ca8be
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1927412
> Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
> Reviewed-by: Bo <boliu@chromium.org>
> Commit-Queue: Bo <boliu@chromium.org>
> Auto-Submit: Evan Stade <estade@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#718338}

TBR=boliu@chromium.org,rouslan@chromium.org

Change-Id: Iffed71cfbe5d512db1a054364598445b00672a94
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946825Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720586}

All sharing features for selected text should be in the same group. They
should also be below the entry for "Copy" as that is a more frequently
used option.

Screenshots of the effects: https://imgur.com/a/TInzym5

Bug: 1028981,1009998,1028995
Change-Id: I9f06a4e90c1d4bc18d8e3820ecf8e47dde40777e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940267Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Commit-Queue: Richard Knoll <knollr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720585}

The native-messaging host does a permission-check by launching a child
process. This CL ensures that the child is launched with stdin/stdout
redirected to dev/null, since they are used by the native-messaging
host to communicate with the website.

The native-messaging host actually duplicates the file-descriptors for
stdin/stdout, and uses these FDs instead of the original. It also
unfortunately closes the original FDs. Whenever stdout is closed,
LaunchProcess cannot launch any child process. This CL addresses this
problem by manually redirecting stdout.

A future CL will fix the native-messaging host so that it does not
close FDs 0 and 1, which could potentially lead to unexpected
behavior.

Bug: 1029858
Change-Id: I7d626e9e4817159ec955b66d2338c07a73c9549a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946827
Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org>
Commit-Queue: Jamie Walch <jamiewalch@chromium.org>
Auto-Submit: Lambros Lambrou <lambroslambrou@chromium.org>
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720584}

This reverts commit 3b866120.

Reason for revert: Causing failures with webrtc.RTCPeerConnectionAccelUsed.dec_vp8

Bug: 1029856

Original change's description:
> media/gpu/v4l2: abstract request logic in V4L2 framework
> 
> Currently, the request creation and submission logic are handled
> inside the decoder's backend.
> This patch moves the request handling inside the V4L2 framework and
> provides new classes to abstract the request creation and submission.
> 
> BUG=chromium:1009921
> TEST=tast video.DecodeAccelVD.h264* on veyron_minnie-kernelnext
> TEST=tast video.DecodeAccelVD.vp8* on veyron_minnie-kernelnext
> TEST=tast video.DecodeAccelPerf.vp8* on veyron_minnie-kernelnext
> TEST=tast video.DecodeAccelPerf.h264* on veyron_minnie-kernelnext
> 
> Signed-off-by: Francois Buergisser <fbuergisser@chromium.org>
> Change-Id: Idacff87aa4324c26b287ce2617398c51dee2721a
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918794
> Reviewed-by: Alexandre Courbot <acourbot@chromium.org>
> Commit-Queue: Alexandre Courbot <acourbot@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#720402}

TBR=acourbot@chromium.org,fbuergisser@chromium.org

Change-Id: I2b418ec4d718b81f7bc74f254c82e4772fc9f280
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:1009921
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946923Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720583}

The SplitSettingsSync feature makes it possible to independently
sync Chrome apps (via browser sync) and ARC apps (via OS sync).
The app list data model and UI code can handle references to
missing apps (for example, on Chromebooks that don't support ARC++
the app list data model may have references to ARC++ apps from
sync, but the UI gracefully hides them).

I initially tied the APP_LIST data type to OS apps. However, the
user can end up in an odd state if we sync Chrome apps
without syncing the app list metadata. For example, a user could
disable OS sync, enable browser sync, install some Chrome
apps, move them around in the app list, set up a new Chromebook,
then discover that the apps are in the wrong order or are not
pinned to the shelf.

Ensure we sync the metadata if either browser apps or OS apps are
being synced.

Bug: 1013466
Test: added to sync_integration_tests

Change-Id: Iddc13a978bb84259fadf91fe5fd9454606ba650d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931098
Commit-Queue: James Cook <jamescook@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720582}

This change modifies the PpdProvider class to follow the conventions
required by the presubmit checks. The changes are trivial and will cause
no behavioral changes. They pave the way to moving the implementation of
this class into a "deprecated" source file.

Bug: 1025995
Change-Id: I6bb71439e519a7a71c7e8f87639b6f4719b3be96
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935046Reviewed-by: Sean Kau <skau@chromium.org>
Commit-Queue: Kalvin Lee <kdlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720581}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/37c0baa6b7b4..33ae3e65534f


Created with:
  gclient setdep -r src-internal@33ae3e65534f

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:1017165
Tbr: jbudorick@google.com
Change-Id: I52f2c289b43652a825642252aa522357f82e4ef6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946441Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#720580}

https://chromium.googlesource.com/catapult.git/+log/8adeb1cc5a26..ebec004c878f

git log 8adeb1cc5a26..ebec004c878f --date=short --first-parent --format='%ad %ae %s'
2019-12-02 eseckler@chromium.org telemetry: Increase timeout for trace collection further.

Created with:
  gclient setdep -r src/third_party/catapult@ebec004c878f

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/catapult-autoroll
Please CC nuskos@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: chromium:1029465
Tbr: nuskos@google.com
Change-Id: Id7f91a9834300166f598193b0209535f6b623e7f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946445Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#720579}

This change modifies the CUPS IPP backend to suppress papers whose
vendor IDs are not meant for users' eyes - i.e. the "custom_min" and
"custom_max" sizes that CUPS incidentally exposes.

Bug: 1026938
Change-Id: I047844030e7f7a161bda32755754494567e7734c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935173Reviewed-by: Sean Kau <skau@chromium.org>
Commit-Queue: Kalvin Lee <kdlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720578}

MessageLoop is going away soon.

This CL was uploaded by git cl split.

R=garykac@chromium.org

Bug: 891670
Change-Id: I4de41d7e941a5977044a774884acd3795959c50c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1945168
Auto-Submit: Carlos Caballero <carlscab@google.com>
Reviewed-by: Gary Kacmarcik <garykac@chromium.org>
Commit-Queue: Gary Kacmarcik <garykac@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720577}

This CL cleans up |socket| and |client_request| unused variables
from P2PSocketTcpServerTest.

Bug: 955171
Change-Id: Ic71452734f08090e2954cd1ad07354c422bcdf08
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942686
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720576}

This test does not work as written on Mac. This dialog's default
button is Cancel, but on Mac the cancel button is never allowed to
have initial focus, so this dialog does not start with any element
keyboard-focused on Mac. To fix this, advance focus once before
checking for focus.

We did not notice that this test is broken because of issue 899286.

Bug: 1028239
Change-Id: I174be7583760f2875bc9e586c8682167feae806d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944284
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Robert Liao <robliao@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720575}

There are two CrossThreadFunction implementations, one that accepts
a base::OnceCallback, and another that accepts a base::Callback
(which is implicitly repeating). This change switches to explicitly
using base::RepeatingCallback to eliminate the use of base::Callback.

Also, renaming ConvertToBaseCallback to ConvertToBaseRepeatingCallback
for symmetry with CrossThreadBindRepeating and base::RepeatingCallback.

Bug: 1007835
Change-Id: I0b0a231bf74259194a78af9870960dbba0cc1f49
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919941
Commit-Queue: Chris Mumford <cmumford@google.com>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720574}

We have two different functions that call trace_processor in two
different modules. This CL factors them out to a single module
so that it was easier to reuse them in Results Processor.

Bug: 990304
Change-Id: I1c94b0d48e520841b5c6e8bed08dec07138f02ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939806
Commit-Queue: Mikhail Khokhlov <khokhlov@google.com>
Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720573}

Imagine the following scenario:
1. An embedded object, e.g. a link, spans multiple lines.
2. There is some text before and after the embedded object.
"Before <embedded_object> after".

In IA2 and ATK, embedded objects are represented by an embedded object character in their parent's text.

Calling IAccessibleText::get_textAtOffset, or an equivalent API, and trying to determine the bounds
of the current line should return an offset range that includes the embedded object character, both when the call is made
somewhere inside the text "Before" as well as when the call is made somewhere inside the text "after".
This is necessary in order to signal to ATs that the embedded object starts somewhere inside the first line
and also that it ends somewhere inside the last line.
Otherwise, ATs Jaws and NVDA read only part of the last line when moving by line.
R=aleventhal@chromium.org, dmazzoni@chromium.org

Change-Id: I6f141e4fff5f60c05edbf80ff3f19ba920be7c31
Bug: 1028301
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934312
Commit-Queue: Nektarios Paisios <nektar@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720572}

Expected capacity requirements:
* luci.chromium.ci
  * 0.66 x (builderless:1, cores:8, cpu:x86-64, os:Ubuntu-16.04, ssd:0)
* chromium.tests
  * 1.44 x (device_os:KTU84P, os:Android, device_type:Nexus 5 (hammerhead))
  * 20.32 x (device_os:MMB29Q, os:Android, device_type:Nexus 5x (bullhead))

Capacity requirements are supported by the current headroom.

Bug: 1024641
Change-Id: I5ba96d029af33581cf38124feac22a88e5a1c09f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929265Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: Garrett Beaty <gbeaty@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720571}

This reverts commit f21f4c91.

Reason for revert: Seems to be causing SingleClientStandaloneTransportSyncTest.HandlesResetFromDashboardWhenSyncActive to fail

Bug: 1029869

Original change's description:
> [signin] Don't clear unconsented primary account on cancelling Sync dialog
> 
> The unconsented primary account doesn't necessarily change when the Sync
> confirmation dialog is cancelled.
> In particular this is the case when PrimaryAccountMutator::ClearPrimaryAccount
> is called with RemoveAccountOptions::kKeepAll.
> 
> This CL stops resetting the unconsented primary account as part of the signout
> process.
> The unconsented primary account is recomputed anyway when GoogleSignedOut is
> called.
> 
> 
> Fixed: 1029701
> Change-Id: Id46bb468952efe63170a13872519fcaded076cb1
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944862
> Commit-Queue: David Roger <droger@chromium.org>
> Reviewed-by: Monica Basta <msalama@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#720502}

TBR=droger@chromium.org,msalama@chromium.org

Change-Id: I0632406070243902295db9f9e482f161df6e65ce
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946194Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720570}

* Use WebAssembly backend for .sizediff
* Fix bug where an empty .sizediff included all before/after symbols.
* When displaying diff status, handle case where tree node has no
  children (I think this case only occurs when loading an empty diff).

Change-Id: Ibb9aa309dacc87d92f2166922350a235297d85f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1945361Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Jasper Chapman-Black <jaspercb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720569}

Per spec, a microtask checkpoint should fire after the updates.
Currently, the microtask checkpoint is firing later in the document
lifecycle. For now, we need to force the update to finish synchronously
in order to prevent potential rendering glitches due to a late finish.

Bug: 1029695, 1029567
Change-Id: I1f6a67a81c2a068ba98e4464e2072963ec324b13
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946528
Commit-Queue: Kevin Ellis <kevers@chromium.org>
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720568}

https://chromium.googlesource.com/angle/angle.git/+log/8784a9284f65..19f9f4148196

git log 8784a9284f65..19f9f4148196 --date=short --first-parent --format='%ad %ae %s'
2019-12-02 xinyi.he@arm.com Vulkan: Textures incorrect on Android maps with Vulkan Backend

Created with:
  gclient setdep -r src/third_party/angle@19f9f4148196

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC geofflang@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: geofflang@google.com
Change-Id: I39706e18be0de0d34a424ffc1bba2cacd5d0196b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946433Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#720567}