- 16 Apr, 2020 13 commits
-
-
Karandeep Bhatia authored
Perform the following renames: - rule_indexing_unittest.cc -> declarative_net_request_unittest.cc - RuleIndexingTestBase -> DeclarativeNetRequestUnittest - SingleRulesetIndexingTest -> SingleRulesetTest - MultipleRulesetsIndexingTest -> MultipleRulesetsTest This is necessary because the file and the associated test fixtures now contain non-indexing related tests. It's now meant to be a generic unit test class for declarativeNetRequest. BUG=754526 Change-Id: I71ac1cc1db004b40b0a45f167e43eac97ad6c54e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146290 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#759484}
-
Dominique Fauteux-Chapleau authored
Bug: 1069345 Change-Id: I9b7fdcb0dd813ad5432d45e2a4c90a24df7b6e0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144252Reviewed-by:
Dominique Fauteux-Chapleau <domfc@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Auto-Submit: Dominique Fauteux-Chapleau <domfc@chromium.org> Commit-Queue: Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#759483}
-
Rohit Rao authored
Adds an iOS-specific version of policy_test_cases.json and uses it to generate unittest cases for policy->pref mappings. BUG=1069528 Change-Id: I80a69f96c70ba45ab4bb2fd20332001f92d06595 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151206Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#759482}
-
jchen10 authored
Currently ui/resources/cursors/none.cur is used to hide the cursor, which is a dark 1x1 bit bmp. This may cause DWM to do composition with the underlay video at very frame. To solve it, the hidden cursor should be further removed from the screen. Bug: 1069698 Change-Id: I4122a7a2085dbde5a78053e69f29f988a1b20de4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145234Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Jie A Chen <jie.a.chen@intel.com> Cr-Commit-Position: refs/heads/master@{#759481}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/9e1e913c81cd..edc2dacb3ab5 git log 9e1e913c81cd..edc2dacb3ab5 --date=short --first-parent --format='%ad %ae %s' 2020-04-15 mtklein@google.com convert load_store / stack_load_store to new style 2020-04-15 michaelludwig@google.com Revert "Refactor GL and Metal FinishCallback into a helper object." Created with: gclient setdep -r src/third_party/skia@edc2dacb3ab5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC kjlubick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: kjlubick@google.com Change-Id: I53428dfc2e46ba03bc453972b09666ace5e20bd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151632Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#759480}
-
Mike Wasserman authored
Add 'onscreenschange' global event when ScreenEnumeration is enabled. Add ScreenChangeMonitor helper class to observe screen change events. WebContentsImpl uses this to notify RenderFrameHostImpls on changes. Use blink::mojom::LocalFrame to dispatch kScreensChange on DOMWindow. Add content_browsertest fixtures for getScreens() and onscreenschange. TODO(crbug.com/1068774): Send screen info with the event. TODO(crbug.com/1071233): Investigate test failures/crashes on Fuchsia. This requires the ScreenEnumeration experimental flag to be enabled: chrome://flags#enable-experimental-web-platform-features OR $ chrome --enable-blink-features=ScreenEnumeration Try with: https://github.com/michaelwasserman/window-placement-demo Bug: 994889 Test: Automated, demo w/flags and manual system screen config changes Change-Id: Ib601245bfe0533f2dee5573b9c302f2bb08a6c12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986234 Commit-Queue: Michael Wasserman <msw@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
enne <enne@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#759479}
-
Eric Roman authored
Bug: 960874 Change-Id: Ife05066bac9537f06c787699aaf7b93852090997 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151176 Commit-Queue: Eric Roman <eroman@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Auto-Submit: Eric Roman <eroman@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#759478}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/7b94cdc5..bf321a18 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I3b18f981141f1fa4c8ae2bfb19c2c8a69c312476 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151546Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#759477}
-
Min Qin authored
BUG=1059792 Change-Id: I491e8569a70a83e633e6183455c902594f10004c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147798Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#759476}
-
Karandeep Bhatia authored
This helps the extension to uniquely identify a ruleset. It would be helpful once we start allowing extensions to dynamically change the set of enabled rulesets. This is a breaking change to the API schema, however it's ok since the API is only on Beta and doesn't have significant usage. BUG=754526 Change-Id: I41edf43acdaa1c97c121f4cca0eda5204fd2f9ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146339 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
-
Xianzhu Wang authored
(TBR for passive change in tools/perf/measurements/rasterize_and_record_micro.py.) TBR=wangxianzhu@chromium.org R=pdr@chromium.org Bug: 642885 Change-Id: Ia5c8313ea9e34139e06ff11fcc5d751ff0768c75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149914 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#759474}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ibe6c1b7b84952564237690650c6d1dd0a4840aaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151630Reviewed-by:
-
Akihiro Ota authored
This change makes slight UI adjustements. It implements spacing suggestions given by a designer. It also fixes a bug where item styling wasn't properly updated when hovering over items in the search menu. Bug: 1070743 Change-Id: I10f77d84be8f65521c8004ffc832f8b6d3ce7952 Relnotes: N/A Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149509Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#759472}
-
- 15 Apr, 2020 27 commits
-
-
Lei Zhang authored
In PDFiumEngine, instead of putting ScopedUnsupportedFeature in functions that call PDFium document loading code, and hope their scope is sufficiently, use the narrowest possible scope, which is guaranteed to be just right. Also add a ScopedUnsupportedFeature instatiation for form loading, as PDFium can also report unsupported features during that process. This avoids a potential NOTREACHED() in ScopedUnsupportedFeature code. Bug: 1071223 Change-Id: Iaf79ff2bae7b41a92f7bb69585a7fa9eb6278ac5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151480Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#759471}
-
Etienne Bergeron authored
R=gab@chromium.org Bug: 1036980 Change-Id: I3fe4ca33cd6f7c193ce9cb26da5e7989171793cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150030 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#759470}
-
Xinghui Lu authored
The original intention is to use this field for authentication. But we decided to set the header instead, so this field is now used for debugging purpose only. In this CL, deprecate this field in the RTLookupRequest protocol, but keep displaying the field in chrome://safe-browsing page. Bug: 1061266 Change-Id: I485c8ee60a9d96ede936ab662219966e25abdb74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146798 Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#759469}
-
Karandeep Bhatia authored
This CL attempts to remove some possible sources of flakiness in the declarative net request browsertests by removing all calls to content::RunAllTasksUntilIdle() and replacing them with more deterministic waiting logic. Also re-enable the tests disabled in r758084. Also, enforce that RulesetManager only has a single test observer at a time. BUG=1069665 Change-Id: I29c646d85322195894d2786fbf01fb7c10842cb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146335 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
-
Shelley Vohr authored
Fixes an issue whereby some edit commands were not being sent to the focused WebContents. This fixes the issue by adding the malfunctioning commands to RenderFrameHostDelegate and then calling them that way. Bug: 1067284 Change-Id: I6a325ff57bb93b64f483385d8b13945486152346 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135187 Commit-Queue: Jeremy Apthorp <jeremya@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#759467}
-
Liquan (Max) Gu authored
Before: In order for a TWA to be found as a payment app for an app-store billing method, the TWA: * cannot be a sideloaded one. * must be installed from the same app store of the billing method. After: The TWA does not have to satisfy the above-mentioned requirements. Change: * remove the checking of the TWA installer. * move "isInTWA" into #findAppStoreBillingApp() * these requirements have to be satisfied for a TWA to be found as a payment app: - the merchant is not requesting shipping or contact delegation. - the merchant requests the supported App store billing methods - the TWA is a payment app - the TWA can handle the requested billing methods Bug: 1069489 Change-Id: I6fa1dee5efb35ac8d89eca6f042d974591a63fcd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147016 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#759466}
-
Tibor Goldschwendt authored
On customized NTPs we don't show a doodle since the doodle may not jibe well with the custom background. Before this CL, if a doodle was available we showed a bouncing ball animation - the flower. And, upon clicking the flower, we temporarily set the NTP to the default theme showing the doodle. However, it turned out that the flower causes a significant amount of CPU usage and it is unclear whether users understand the flower lets them peek the doodle. Therefore, this CL removes the flower. Fixed: 1046786 Change-Id: If236a3fc4be4f7ef2cf9deebad1d579103902c59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151318 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#759465}
-
tby authored
This adds the skeleton of a new search provider and result type for settings search results in the launcher. This has no logic yet, and returns no results. The next CL will integrate the provider with the settings service to provide results. Bug: 1068851 Change-Id: Ic11c7142d25116b990affea87c15539b0b842fed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142890Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Thanh Nguyen <thanhdng@chromium.org> Reviewed-by:
Jia Meng <jiameng@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#759464}
-
Trent Begin authored
Update cros_healthd telemetry handling code to check for and log errors from TimezoneInfo request. Bug: chromium:1041153 Change-Id: Icadc8d1461e8b0b34b14a5cc3d7c48682889280f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148656Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Jesse Schettler <jschettler@chromium.org> Reviewed-by:
Paul Moy <pmoy@chromium.org> Commit-Queue: Trent Begin <tbegin@chromium.org> Cr-Commit-Position: refs/heads/master@{#759463}
-
Karandeep Bhatia authored
This key decides whether the ruleset is enabled by default. On extension load, if the set of enabled rulesets, exceeds the rules count limit, not all rulesets will be enabled and a warning is raised. We don't raise a hard error in this case to maintain forward compatibility. Rulesets specified earlier in the manifest will be given priority for being evaluated if not all rulesets can be enabled due to the rules limit. This is a breaking change to the API schema, however it's ok since the API is only on Beta and doesn't have significant usage. In the future, extension functions will be introduced to allow the extensions to dynamically toggle the set of enabled rulesets. BUG=754526 Change-Id: Iff075b142cabb67a75fe58298f9bf7da71a37045 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141204 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#759462}
-
Sharon Yang authored
CastMediaBlocker and CastMediaPlaybackOptions have logic that is applicable to other parts of Chromium. To use these classes, they have been moved to components/media_control and made generic. Bug: 1057860 Change-Id: I3210af669a3c39711eda41999b7303f6df518d2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127416 Commit-Queue: Sharon Yang <yangsharon@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#759461}
-
Shelley Vohr authored
This CL converts a deprecated Callback into a OnceCallback, since the callback is passed to other threads which always bind as OnceCallback. Electron patches into this functionality and this will make it easier for us to do so. Change-Id: I490a750661f41462ab8eab59e8f3a7a74e1256e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138564 Commit-Queue: Jeremy Apthorp <jeremya@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#759460}
-
Czirkos Zoltan authored
Previously, when using --headless --print-to-pdf, three params were given to the PrintToPDF request: .SetDisplayHeaderFooter(true) .SetPrintBackground(true) .SetPreferCSSPageSize(true) Background and page size can be controlled by CSS, however displaying header and footer cannot. This patch adds a new command line flag --print-to-pdf-no-header, which lets the user hide the header and footer when using --print-to-pdf in --headless mode: .SetDisplayHeaderFooter( ...from command line... ) .SetPrintBackground(true) .SetPreferCSSPageSize(true) So now --print-to-pdf=output.pdf uses header and footer, --print-to-pdf=output.pdf --print-to-pdf-no-headers hides them. Bug: 1069477 Change-Id: Idf000ec44446079bfc30a453eccd2fbc7e923e0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144140Reviewed-by:Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#759459}
-
Alexander Cooper authored
When previously splitting xr_device_service into a test/internal interface, one usage within mock_xr_device_hook_base was missed. This change adds a test-specific method for that class as well. This change also exposes an "internal" function that the test functions may call. This is necessary because when xr_test_utils is moved to content/public/test, xr_device_service will not be able to depend on it; however, the reverse dependency (xr_test_utils depending on xr_device_service) is allowed. Bug: 1031622 Change-Id: Iec2efde6b620fc9ce336f3e0d6472410c9156621 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151467 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Commit-Queue: Klaus Weidner <klausw@chromium.org> Auto-Submit: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#759458}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/bd0ce7c933dc..66792cf7d6a9 Created with: gclient setdep -r src-internal@66792cf7d6a9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC ricea@google.com,nektar@google.com,guidou@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1071177 Tbr: ricea@google.com,nektar@google.com,guidou@google.com Change-Id: I76381a8e7392ed6aede6191920e6d83c410f7b75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151084Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#759457}
-
Nnamdi Theodore Johnson-Kanu authored
This CL is in preparation for enabling Polymer3 in ChromeOS settings pages. It fixed issues in os_languages_page/ folder that break semi-automatic Polymer3 migration. These changes include adding missing #cr_define_end comments to JS file which were missing them, as well as making sure that files which use cr.define() include the entire file's content within the cr.define() call, since this is required by Polymer3 conversion tools. Bug: 1045266 Change-Id: I1d6f05c1e2f0f29dc816a81187b091361883061f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147918 Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#759456}
-
Scott Violet authored
The current ordering makes it seem as though removed_request_headers_ can be modified during the start phase, when it can only be modified during the redirect phase. This patch reorder things to make it clear removed_request_headers_ is only applicable to redirect headers. BUG=none TEST=none Change-Id: If840fc0c06c8b9a56dd8f96a8f8899c3ffb81a99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151314Reviewed-by:
-
Scott Violet authored
bottomContentOffsetY is rather confusing, and the comment was some what misleading. It appears unused, so removing. BUG=none TEST=none Change-Id: I0bfa74c77ac040be6d60da3a00dfad1bbef96ccb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148272Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#759454}
-
Nathan Zabriskie authored
RasterImplementation currently has no API for uploading textures directly from CPU memory. The need for an intermediate texture incurs unnecessary copies which decrease performance, especially in repeated use cases. This CL adds one option for uploading a texture stored in CPU memory directly to a shared image mailbox. Bug: 1063725 Change-Id: Iaf0ce530650913cd38f17ade3160b5129e96f0a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141068Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Nathan Zabriskie <nazabris@microsoft.com> Cr-Commit-Position: refs/heads/master@{#759453}
-
Ilya Sherman authored
There was some confusion in cl/305406043 around what should be used in JavaScript. R=chromium-metrics-reviews@google.com Bug: None Change-Id: Id31be2c24bd552ff29c734350feb22ddea41ae24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148163 Auto-Submit: Ilya Sherman <isherman@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
-
Ali Juma authored
This makes SafeBrowsingService expose a method for creating SafeBrowsingUrlCheckerImpls rather than exposing direct access to the Safe Browsing database, and makes SafeBrowsingTabHelper use SafeBrowsingUrlCheckerImpl rather than raw database access. Using SafeBrowsingUrlCheckerImpl aligns iOS with other platforms, allowing us to share logic for querying the database, handling redirects, and keeping track of the state of outstanding database queries. This will also make it easier to reuse existing logic for real-time lookups. Removing direct access to the database from SafeBrowsingService will also simplify creating a FakeSafeBrowsingService for tests, which will be done in a follow-up. Change-Id: Ib02fc25b0201a4866649268d03112bf685be21df Bug: 1049340 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128569 Commit-Queue: Ali Juma <ajuma@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#759451}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/8ac25c44cbe8..9e1e913c81cd git log 8ac25c44cbe8..9e1e913c81cd --date=short --first-parent --format='%ad %ae %s' 2020-04-15 michaelludwig@google.com Add rect subtraction utility function+tests 2020-04-15 jvanverth@google.com Allow to Metal to build with Xcode 10 again. 2020-04-15 mtklein@google.com start on operand refactoring 2020-04-15 tdenniston@google.com [svg] Fix translate() with no ty specified. 2020-04-15 jlavrova@google.com MinIntrinsicWidth should ignore placeholders Created with: gclient setdep -r src/third_party/skia@9e1e913c81cd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC kjlubick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: kjlubick@google.com Change-Id: I9a407fb504b04d3b5327edffc50e85a180fcb2ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151626Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/9f64a3e1686e..4c0a21a0882d git log 9f64a3e1686e..4c0a21a0882d --date=short --first-parent --format='%ad %ae %s' 2020-04-15 changhaohan@chromium.org Rename boolean "closingTag" and "elementCloseTag" to "isClosingTag" Created with: gclient setdep -r src/third_party/devtools-frontend/src@4c0a21a0882d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I664ffa56778688261c402cfe67146bade6ef5323 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151625Reviewed-by:
-
Ilya Sherman authored
Exception: If you want a specific reviewer's expertise, it's fine to send the CL directly to that reviewer. This helps us to load-balance incoming code reviews. R=gab@chromium.org Bug: none Change-Id: I70d77c8575bf59953f5cc53f0fd6d951e35597ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150972 Auto-Submit: Ilya Sherman <isherman@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
-
Nigel Tao authored
The error_code enum is really a private implementation detail. Callers don't care about it (other than it being an error or no error). Removing references (outside of //base/json) to that enum will let us more easily modify the //base/json implementation. Bug: 1070409 Change-Id: Id5c48bb59665d129ec829d9dd447ceac61aa6f0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147531Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#759447}
-
Darren Shen authored
Normally, when showing the keyboard, we have to reduce the viewport size of every window, so that the window contents are not obscured by the keyboard. This is called "overscrolling". When showing the "sticky" a11y keyboard however, the keyboard is considered "locked": all windows will resize accordingly. This naturally reduces the viewport size, so there's no need to do overscrolling again. During the mash project, we accidentally missed this case, so windows are resized AND overscrolled, which causes the contents to shrink twice in some scenarios. Bug: 1030481 Change-Id: Ic62c483e4918cd692d47887d511772183208293e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148897Reviewed-by:
-
Sam Bowen authored
* Don't require an action status, as it's not required in the spec. * Add an override for duration type to allow time values so validator doesn't delete it. * Set live details before checking whether they are there. * Check the URL values for interaction type instead of string. All of the example media feed items are fetched with these changes. Change-Id: I891afc2d1f6650a164f28a402b30ce248be5aa4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149906 Commit-Queue: Sam Bowen <sgbowen@google.com> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#759445}
-
