- 29 Nov, 2016 40 commits
-
-
robertogden authored
Includes a working test case and basic functionality. Much more to come. BUG= Review-Url: https://codereview.chromium.org/2528483004 Cr-Commit-Position: refs/heads/master@{#435047}
-
skia-deps-roller authored
https://skia.googlesource.com/skia.git/+log/e18c97b73a03..56b50792531c $ git log e18c97b73..56b507925 --date=short --no-merges --format='%ad %ae %s' 2016-11-29 mtklein Make gather() look and work more like load(). 2016-11-28 mtklein Use /MD for Windows builds. 2016-11-29 mtklein document x_tail encoding 2016-11-29 bsalomon Reland image storage with fixes. Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel TBR=brianosman@google.com Review-Url: https://codereview.chromium.org/2536193003 Cr-Commit-Position: refs/heads/master@{#435046}
-
mmenke authored
The code was allowing CRs or LFs in remote paths, but DCHECKing that commands including paths don't contain them. This CL makes the request fail if a remote path contains either character. BUG=669407 Review-Url: https://codereview.chromium.org/2538773002 Cr-Commit-Position: refs/heads/master@{#435045}
-
rkjnsn authored
Adds a wrapper to launch me2me script in a proper PAM session. BUG=616962 Review-Url: https://codereview.chromium.org/2323153002 Cr-Commit-Position: refs/heads/master@{#435044}
-
dgozman authored
Migrated navigator tests and compiler-script-mapping away from mock workspace. BUG=none Review-Url: https://codereview.chromium.org/2536733004 Cr-Commit-Position: refs/heads/master@{#435043}
-
apacible authored
BUG=668360 TBR=palmer@chromium.org NOTRY=true Review-Url: https://codereview.chromium.org/2537193002 Cr-Commit-Position: refs/heads/master@{#435042}
-
hzl authored
In this cl, we are trying to add the logcat of each instrumentation test into the corresponding test result object, so that when we are checking the result of each test case, we would be able to see the corresponding logcat for that test case at the same time. BUG=631213 Review-Url: https://codereview.chromium.org/2451523002 Cr-Commit-Position: refs/heads/master@{#435041}
-
twellington authored
Attempt to fix ContextualSearchManagerTest#testImageControl() by running calls to the ContextualSearchImageControl on the UI thread. Also add @RetryOnFailure to #testTapOnRoleIgnored(). BUG=669405,669565 Review-Url: https://codereview.chromium.org/2534193002 Cr-Commit-Position: refs/heads/master@{#435040}
-
bsheedy authored
Adds the chrome_public_test_apk instrumentation tests to the Android VR FYI builder and limits it to VR-related tests using the functionality added in https://bugs.chromium.org/p/chromium/issues/detail?id=658342 BUG= Review-Url: https://codereview.chromium.org/2537633002 Cr-Commit-Position: refs/heads/master@{#435039}
-
bsheedy authored
Adds basic image diffing capabilities to the VR Shell instrumentation tests and adds image diffing versions of the enter/exit VR mode tests. Will require adding new reference images as more devices with different resolutions are tested (currently only has 2560 x 1440). BUG= Review-Url: https://codereview.chromium.org/2455683002 Cr-Commit-Position: refs/heads/master@{#435038}
-
kylechar authored
On daisy devices the physical_size for display is being reported incorrectly as (0, 0). Return a standard DPI in this case. I've filled crbug.com/669554 for the bad physical_size value. BUG=669554 Review-Url: https://codereview.chromium.org/2539843002 Cr-Commit-Position: refs/heads/master@{#435037}
-
liyuqian authored
We no longer use SK_ANALYTIC_AA flag it's now set as default in Chromium. However, we need some flag to guard some bug fixes in Skia wihtout breaking the Chromium layout tests. BUG= Review-Url: https://codereview.chromium.org/2536643004 Cr-Commit-Position: refs/heads/master@{#435036}
-
binji authored
They are no longer working on the project. Review-Url: https://codereview.chromium.org/2539883002 Cr-Commit-Position: refs/heads/master@{#435035}
-
tbarzic authored
Introduce API feature properties to specify an API source and alias. |source| is set on API alias, and is used during API registration - if an API feature has source set, the bindings installed under API name will be the bindings of |source| API. |alias| is used on source API, and is used when checking API availability - when checking availability of an API that has alias set, the API will be deemed available if either one of the API and the API alias are available in the context. Note that this logic should not be used when determining API availability for binding registration - in this case alias availability should be ignored in order to avoid registering source API bindings when only alias bindings are needed. BUG=647415 Review-Url: https://codereview.chromium.org/2494653005 Cr-Commit-Position: refs/heads/master@{#435034}
-
Krishna Govind authored
Cr-Commit-Position: refs/heads/master@{#435033} -
apacible authored
BUG=669572 TBR=davidben@chromium.org NOTRY=true Review-Url: https://codereview.chromium.org/2532253003 Cr-Commit-Position: refs/heads/master@{#435032}
-
alexclarke authored
More than one system wants to be able to enable and disable task queues. The TaskQueue::QueueEnabledVoter lets them safely vote on which queues are enabled and disabled. BUG= Review-Url: https://codereview.chromium.org/2540663002 Cr-Commit-Position: refs/heads/master@{#435031}
-
khmel authored
This fixes the regression caused by refactoring. TEST=Manually BUG=32545771 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2541553002 Cr-Commit-Position: refs/heads/master@{#435030}
-
catapult-deps-roller authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/3950931a913d..c82129405204 $ git log 3950931a9..c82129405 --date=short --no-merges --format='%ad %ae %s' 2016-11-29 nednguyen [Telemetry] Add AddTimelineBasedMetric API for TBM option BUG=669526 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=catapult-sheriff@chromium.org Review-Url: https://codereview.chromium.org/2535263002 Cr-Commit-Position: refs/heads/master@{#435029}
-
yusufo authored
In tab reparenting, we never close but only remove the tab from the model. During this process, both tab observer and also the metrics observer was still kept, which leaked over some custom tab features into the tab even after it was reparented. This removes the observers and fixes the related issues. TEST=CustomTabActivityTest#testTabReparentingBasic BUG=669169 Review-Url: https://codereview.chromium.org/2539643002 Cr-Commit-Position: refs/heads/master@{#435028}
-
slan authored
arm_neon.h throws an error when included in a non-neon build. Only include neon-related sources when use_arm_neon is true. BUG=657874 Review-Url: https://codereview.chromium.org/2427333004 Cr-Commit-Position: refs/heads/master@{#435027}
-
sky authored
This also adds PropertyConverter::GetPropertyValueFromTransformValue() which I need in ash for values used in creation of the window but don't make their way into real properties. BUG=664625 TEST=none R=msw@chromium.org Review-Url: https://codereview.chromium.org/2538633002 Cr-Commit-Position: refs/heads/master@{#435026}
-
timav authored
In android webview the selection handles are implemented in PopupTouchHandleDrawable.java In this CL we make this class an observer that listens to display changes and keep the current dip scale as a member instead of retrieving it from ContentViewCore. We cannot update the bitmaps by the DisplayAndroid signal (i.e. in onDIPScaleChanged()) because the resources are not yet updated at the moment. Instead, we update the bitmap in the subsequent onConfigurationChanged() that should follow the display change. To make sure that the configuration corresponds to the display change we check that the display density in resources is equal to the expected value. BUG=620929 Review-Url: https://codereview.chromium.org/2515343004 Cr-Commit-Position: refs/heads/master@{#435025}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d656dfb5..f796cb3f Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2540553004 Cr-Commit-Position: refs/heads/master@{#435024}
-
zmin authored
BUG=642059 Review-Url: https://codereview.chromium.org/2530943002 Cr-Commit-Position: refs/heads/master@{#435023}
-
ossy.szeged authored
BUG=668208 Review-Url: https://codereview.chromium.org/2525993002 Cr-Commit-Position: refs/heads/master@{#435022}
-
afakhry authored
View Frame Source for iframe of a file:// URL used to show the main frame's filename instead of the expected title derived from the iframe's page URL in the form of "view-source:url". This CL fixes this and adds a browser test. BUG=659040 TEST=browser_tests --gtest_filter=ChromeNavigationBrowserTest.TestViewFrameSource Review-Url: https://codereview.chromium.org/2501083004 Cr-Commit-Position: refs/heads/master@{#435021}
-
patricialor authored
AXNodeData::state is a bitmask used for setting accessible state flags such as ui::AX_STATE_DISABLED. It is initialised to 0xFFFFFF, which turns all flags on. This is done in order to more easily catch bugs where no flags are set at all - it must be cleared to 0x0 before use. Add a comment explaining this. BUG=668569 Review-Url: https://codereview.chromium.org/2528103002 Cr-Commit-Position: refs/heads/master@{#435020}
-
juncai authored
Sometimes UsbDevice::product_string() returns empty string, and the current WebUSB chooser uses it as the device name to be displayed. This CL fixes the blank name issue by displaying, in decreasing order of preference: 1. UsbDevice::product_string() 2. UsbIds::GetProductName() 3. "Unknown device from " + UsbIds::GetVendorName() 4. "Unknown device [$VID:$PID]" BUG=665599 Review-Url: https://codereview.chromium.org/2539593002 Cr-Commit-Position: refs/heads/master@{#435019}
-
georgesak authored
BUG=660868 Review-Url: https://codereview.chromium.org/2514483002 Cr-Commit-Position: refs/heads/master@{#435018}
-
apacible authored
Per discussion with UX. Review-Url: https://codereview.chromium.org/2538573002 Cr-Commit-Position: refs/heads/master@{#435017}
-
avi authored
BUG=629964 Review-Url: https://codereview.chromium.org/2535043002 Cr-Commit-Position: refs/heads/master@{#435016}
-
rsleevi authored
This updates from revision 4dcaacaf593dde7e2a34436913c24af3bf2bdb06 (2016-08-16) to revision b48ff55eab9b82ebc88762eed45277448d1f4f79 (2016-11-29) R=pkasting@chromium.org BUG=669314 Review-Url: https://codereview.chromium.org/2532913003 Cr-Commit-Position: refs/heads/master@{#435015}
-
skia-deps-roller authored
https://skia.googlesource.com/skia.git/+log/e4cd00699167..e18c97b73a03 $ git log e4cd00699..e18c97b73 --date=short --no-merges --format='%ad %ae %s' 2016-11-28 msarett Fix float/int bug in SkRawCodec Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel TBR=brianosman@google.com Review-Url: https://codereview.chromium.org/2537113002 Cr-Commit-Position: refs/heads/master@{#435014}
-
skym authored
BUG= Review-Url: https://codereview.chromium.org/2533193002 Cr-Commit-Position: refs/heads/master@{#435013}
-
phoglund authored
Note that webrtc.stress doesn't measure stats at all (yet), so that needs to happen if we decide to go the Telemetry path. See discussion in the bug. BUG=632299 Review-Url: https://codereview.chromium.org/2522183002 Cr-Commit-Position: refs/heads/master@{#435012}
-
skym authored
When merging, if we're given specifics that correspond to the local guid, we try to access specifics object for the local guid in |all_data_|. The problem with this, is that there isn't always an entry there if reconcile has not happened yet. This only happens when the initial sync round trip finishes before metadata loads from disk, but this race is happening to users, see the bug. The fix could be to check that |all_data_| actually contains an entry for the local guid, but it really doesn't matter. Local data completely cleared when sync is disabled, so reconcile will always create a local entry with a fresh time stamp around the time merge is called. There's no reason to complicate the logic inside of merge for no real benefit, so I've simply removed the set_last_updated_timestamp call. BUG=668938 Review-Url: https://codereview.chromium.org/2536043002 Cr-Commit-Position: refs/heads/master@{#435011}
-
mthiesse authored
BUG=668541 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2536873002 Cr-Commit-Position: refs/heads/master@{#435010}
-
kojii authored
This patch avoids updating layout tree in AXNodeObject::determineAccessibilityRole(). Element::isFocusable() requires styles to be updated. However, when layout code calls determineAccessibilityRole(), updating layout tree should be avoided since it may destroy the calling object. This patch replaces it to supportsFocus(), since the main purpose is to give elements with tabIndex explicitly set get some role. This is a speculative fix. BUG=590369, 647602, 665168 Review-Url: https://codereview.chromium.org/2532023002 Cr-Commit-Position: refs/heads/master@{#435009}
-
jaydasika authored
The DCHECK is invalid because we can have a render surface between the target of scroll parent and scroll child. BUG=663499 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2537053002 Cr-Commit-Position: refs/heads/master@{#435008}
-