1. 03 Feb, 2017 25 commits
    • davidben's avatar
    • xjz's avatar
      Media Remoting: Don't report remote renderer init error to pipeline. · fa3876bf
      xjz authored
      When error occurs during initializing the remote renderer,
      CourierRenderer should not report the failure to media pipeline.
      Instead, it should always report success to the media pipeline, and
      then become a no-op renderer after that point.  The remoting session
      will soon end, and a normal local renderer will be created instead.
      
      BUG=687750
      
      Review-Url: https://codereview.chromium.org/2669033004
      Cr-Commit-Position: refs/heads/master@{#447911}
      fa3876bf
    • hans's avatar
      Turn off LTO again for Official Win/Clang LLD builds · 3ba9c67e
      hans authored
      We're not working on this config at the moment, so having a red buildbot
      testing it is just waste of cycles.
      
      BUG=688123, 598772
      
      Review-Url: https://codereview.chromium.org/2677593002
      Cr-Commit-Position: refs/heads/master@{#447910}
      3ba9c67e
    • estark's avatar
      Add counters for clicking on Form-Not-Secure warnings · b56160fa
      estark authored
      This will measure how often the Form-Not-Secure warnings ("Login not secure" or
      "Payment not secure" in the autofill dropdown) are clicked on to
      show more information about the warning.
      
      BUG=687823
      CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
      
      Review-Url: https://codereview.chromium.org/2665313002
      Cr-Commit-Position: refs/heads/master@{#447909}
      b56160fa
    • boliu's avatar
      android: Add debug url to throw uncaught exception · 7a81c252
      boliu authored
      Currently there are no crash handlers for uncaught java exceptions
      in child processes. Add a chrome debug url to crash the GPU process
      with an uncaught java exception to aid in testing this code path.
      
      The plumbing is same as chrome://gpucrash, except everything is
      behind OS_ANDROID guards. The actual implementation of throwing
      the exception is in base.
      
      BUG=680775
      CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
      
      Review-Url: https://codereview.chromium.org/2664373002
      Cr-Commit-Position: refs/heads/master@{#447908}
      7a81c252
    • alexclarke's avatar
      Adds a FlatDomTreeExtractor to headless · 60157306
      alexclarke authored
      This is very similar to DomTreeExtractor (which we should remove
      later) except it uses DOM.getFlattenedDocument.  This is useful for
      very large documents which might otherwise blow up the JSON parse
      which currently has a nesting depth limit of 200
      
      BUG=546953
      
      Review-Url: https://codereview.chromium.org/2673773002
      Cr-Commit-Position: refs/heads/master@{#447907}
      60157306
    • ericrk's avatar
      Move const ResourceProvider members into Settings struct · a6e7079b
      ericrk authored
      Currently, ResourceProvider members which are set once at init and never
      modified are not clearly identified. This makes it hard to see what
      members can be used in a threadsafe manner.
      
      This change moves these members to a Settings struct and makes the
      settings "const", making it clearer how these may be used.
      
      R=vmpstr@chromium.org
      CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
      
      Review-Url: https://codereview.chromium.org/2662303004
      Cr-Commit-Position: refs/heads/master@{#447906}
      a6e7079b
    • dpapad's avatar
      MD Settings: Remove remaining importHtml() calls from site settings tests. · b69c81cc
      dpapad authored
      This fixes site-details related tests in Vulcanized mode as well as the site
      details view when the --enable-site-settings runtime flag is supplied.
      
      When in Vulcanized mode, the tests can no longer include site_details.html
      directly, since all URLs redirect to the top-level doc. <site-details> was not
      imported anywhere from settings.html's transitive deps, making it impossible for
      the tests to pass in Vulcanized mode.
      
      BUG=673825
      CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
      
      Review-Url: https://codereview.chromium.org/2669033008
      Cr-Commit-Position: refs/heads/master@{#447905}
      b69c81cc
    • sunjian's avatar
      Import navigation timing's wpt tests into chromium · 1b48ba26
      sunjian authored
      BUG=678847
      
      Review-Url: https://codereview.chromium.org/2667283005
      Cr-Commit-Position: refs/heads/master@{#447904}
      1b48ba26
    • pdr's avatar
      Optimize CompositingRecorder::endCompositing to not need an SkPictureBuilder · 424a2d30
      pdr authored
      CompositingRecorder::endCompositing has an optimization [1] to turn
      patterns like [..., begin compositing, drawing, end compositing]
      into [..., composited drawing] which takes advantage of an SkPicture
      recording optimization. An SkPictureBuilder is not needed in this
      case, as we can modify the underlying display list while creating the
      new composited drawing. To do this, a DCHECK in DrawingRecorder that
      the underlying list doesn't change has been suppressed with
      DisableListModificationCheck.
      
      The last user of DisableNullPaintPropertyChecks has been removed which
      lets us delete code from PaintChunker.
      
      [1] https://codereview.chromium.org/2186643002
      
      BUG=628831
      CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
      
      Review-Url: https://codereview.chromium.org/2675773003
      Cr-Commit-Position: refs/heads/master@{#447903}
      424a2d30
    • holte's avatar
      Add shutdown notification and service refs to SyncServiceObserver. · 4ef35706
      holte authored
      Modifies ServiceSyncObserver to recieve SyncService* to the notifying
      service in all of it's methods.
      
      Also adds OnShutdown() notification.
      
      This will support adding a long-lived observer in
      https://codereview.chromium.org/2653693004/
      
      TBR=sdefresne,treib
      
      BUG=
      
      Review-Url: https://codereview.chromium.org/2657673004
      Cr-Commit-Position: refs/heads/master@{#447902}
      4ef35706
    • einbinder's avatar
      DevTools: Introduce ARIAUtils · 652129ce
      einbinder authored
      BUG=none
      
      Review-Url: https://codereview.chromium.org/2655393003
      Cr-Commit-Position: refs/heads/master@{#447901}
      652129ce
    • mcasas's avatar
      Shape detection service: Add QR detection in Mac · 90149a48
      mcasas authored
      This CL lands support for QR/barcode detection in Mac by
      adding the correspondent files in services/shape_detection.
      
      Most of the work is reshuffling code that was specific to
      Face detection, to suit both Face and Barcode detection:
      
      - Removed shape_detection_service_dispatcher.h and merged
       its two methods as statics in render_process_host_impl.cc.
      
      - Moved common service/ code to detection_utils_mac.h/mm
       (1 helper function)
      
      ** Important note re. testing **
      Chromium Mac bots seem to have troubles running CoreImage
      methods, probably because they are virtual machines (no GPU).
      This prevents testing the Barcode detection API properly, and also
      renders void the current Face detection test. So, the plan is:
      a) Remove the current Mac-Face detection test, because is not
      testing anything, really (there was a bug in the error-return path
      that is cleaned up here).
      b) land (imminently) new unit tests for face and barcode, running
      in Mac Gpu bots.
      
      This CL does a); b) will be done in a subsequent CL.
      
      BUG=665150
      TEST=
      ./out/gn/Chromium.app/Contents/MacOS/Chromium --enable-blink-features=ShapeDetection,GeometryInterfaces  https://codepen.io/miguelao/full/wgrYjZ
      NOTE: unittests for {face/barcode}_detection_impl_mac.mm coming
      imminently after this).
      
      Review-Url: https://codereview.chromium.org/2655303005
      Cr-Commit-Position: refs/heads/master@{#447900}
      90149a48
    • einbinder's avatar
      DevTools: Use real focus in TreeOutline · 75dc75e5
      einbinder authored
      BUG=none
      
      Review-Url: https://codereview.chromium.org/2644233007
      Cr-Commit-Position: refs/heads/master@{#447899}
      75dc75e5
    • sadrul's avatar
      display compositor: Fix a use-after-free when a frame sink is destroyed. · 60bd8863
      sadrul authored
      Make a copy of the sink-id before removing it from the map. This is
      because the id variable is owned by the GpuCompositorFrameSink in the
      map. So when the sink is removed from the map, the id is also destroyed.
      But the map can continue to iterate and try to use it. Making a copy of
      it avoids this.
      
      BUG=none
      
      Review-Url: https://codereview.chromium.org/2673823002
      Cr-Commit-Position: refs/heads/master@{#447898}
      60bd8863
    • csharrison's avatar
      Avoid checking for WTFThreadData::staticData in wtfThreadData() · 395b9f9a
      csharrison authored
      This patch initialized the underlying ThreadSpecific<WTFThreadData>*
      in a separate code path during initialization, to avoid a branch in
      wtfThreadData().
      
      BUG=621786
      
      Review-Url: https://codereview.chromium.org/2646003003
      Cr-Commit-Position: refs/heads/master@{#447897}
      395b9f9a
    • ktyliu's avatar
      Revert of Convert make_qualified_names and make_element_factory to use JSON5.... · d50208a9
      ktyliu authored
      Revert of Convert make_qualified_names and make_element_factory to use JSON5. (patchset #5 id:80001 of https://codereview.chromium.org/2645283006/ )
      
      Reason for revert:
      Unexpected compile failure --
      https://build.chromium.org/p/chromium/builders/Linux%20x64/builds/32431
      
      Original issue's description:
      > Convert make_qualified_names and make_element_factory to use JSON5.
      >
      > Convert make_qualified_names.py, make_element_factory.py,
      > make_element_type_helpers.py, and make_element_lookup_trie.py
      > to use JSON5 config format.
      >
      > Converted these config files accordingly:
      >   Source/core/html/HTMLAttributeNames.in
      >   Source/core/html/HTMLTagNames.in
      >   Source/core/html/parser/MathMLAttributeNames.in
      >   Source/core/html/parser/MathMLTagNames.in
      >   Source/core/svg/SVGAttributeNames.in
      >   Source/core/svg/SVGTagNames.in
      >   Source/core/svg/xlinkattrs.in
      >   Source/core/xml/xmlattrs.in
      >   Source/core/xml/xmlnsattrs.in
      >
      > Note that these files are updated together because:
      > 1. make_element_factory.py depends on make_qualified_names.py
      > 2. HTMLTagNames.in is common input to the scripts make_element_factory,
      > make_element_type_helpers and make_element_lookup_trie
      >
      > Removed FIXME in make_element_type_helpers.py since that case
      > no longer occurs.
      >
      > Also fixed bug in json5_generator where parameters should not be
      > validated if default_parameters is not provided.
      > (caught when I had typo on default_parameters in the script)
      >
      > BUG=677884
      >
      > Review-Url: https://codereview.chromium.org/2645283006
      > Cr-Original-Commit-Position: refs/heads/master@{#447450}
      > Committed: https://chromium.googlesource.com/chromium/src/+/f5ca5654596eeda38c2a796bbbad299d92b7f008
      > Review-Url: https://codereview.chromium.org/2645283006
      > Cr-Commit-Position: refs/heads/master@{#447891}
      > Committed: https://chromium.googlesource.com/chromium/src/+/701ccf95a0ec04657b59ad240e28be4085fe033f
      
      TBR=nainar@chromium.org,sashab@chromium.org
      # Skipping CQ checks because original CL landed less than 1 days ago.
      NOPRESUBMIT=true
      NOTREECHECKS=true
      NOTRY=true
      BUG=677884
      
      Review-Url: https://codereview.chromium.org/2677603002
      Cr-Commit-Position: refs/heads/master@{#447896}
      d50208a9
    • xdai's avatar
      Revert of Allow using goma on Windows with symbol_level == 2 (patchset #2... · 169e1ad7
      xdai authored
      Revert of Allow using goma on Windows with symbol_level == 2 (patchset #2 id:20001 of https://codereview.chromium.org/2661023010/ )
      
      Reason for revert:
      It broke amd64-generic Trusty informational build at generate_build_files:
      ERROR at //build/config/compiler/compiler.gni:115:3: Assertion failed.
        assert(is_win_fastlink || !use_goma,
        ^-----
      Goma builds that use symbol_level 2 must use is_win_fastlink.
      See //BUILD.gn:11:1: whence it was imported.
      import("//build/config/compiler/compiler.gni")
      ^--------------------------------------------
      GN gen failed: 1
      step returned non-zero exit code: 1
      @@@STEP_FAILURE@@@
      
      See crbug.com/688203 for more info.
      
      Original issue's description:
      > Allow using goma on Windows with symbol_level == 2
      >
      > Traditionally goma for Chrome has been less useful on Windows than on
      > other platforms because it was incompatible with full debug information.
      > Building with goma requires using /Z7 instead of /Zi, and this causes
      > the linker's memory usage and runtime to blow up as all of the debug
      > information is merged.
      >
      > However, /debug:fastlink makes this work. Because it doesn't merge all
      > of the debug information it makes goma and /Z7 practical. Full release
      > component builds can be done in less than fifteen minutes, with
      > incremental builds taking just a few seconds. Without goma a full
      > release component build of Chrome can easily take 40+ minutes, even on a
      > Z840.
      >
      > Goma's speedup comes from massively parallelizing the compile phase,
      > however even with /debug:fastlink the linking phases are longer with the
      > /Z7 switch that is required by goma. A /debug:fastlink of chrome.dll in
      > a component build goes from ~32 seconds to ~110 seconds on a Z620 when
      > /Z7 (goma) is selected. This penalty will be reduced by VC++ 2017 which
      > claims 30% speed improvements on /debug:fastlink.
      >
      > So, if you frequently need to do full relinks then goma may still be a
      > bad choice. However for most scenarios this change should make goma a
      > good choice for component builds of Chrome, even with full debug
      > information enabled. To make use of this ability you need to explicitly
      > specify the switches below - symbol_level will otherwise default to 1
      > when use_goma == true.
      >
      >     use_goma = true
      >     is_win_fastlink = true
      >     symbol_level = 2
      >
      > The fastlink PDBs work well for most scenarios but there are a few
      > scenarios (rare for most people) where they do not work:
      > - Copying PDBs to another machine (fails due to references to the .obj
      > files)
      > - Reporting on all symbols/globals with SymbolSort or similar fails
      > - ETW tracing fails
      > - VS heap profiling fails
      > Ideally mspdbcmf.exe would let us create "normal" PDBs when needed but
      > in practice this appears to be unusable with /Z7 created PDBs.
      >
      > R=scottmg@chromium.org
      >
      > Review-Url: https://codereview.chromium.org/2661023010
      > Cr-Commit-Position: refs/heads/master@{#447892}
      > Committed: https://chromium.googlesource.com/chromium/src/+/4a3cadb2d998fb8f477d0ebc7ff13619b123a805
      
      TBR=scottmg@chromium.org,dpranke@chromium.org,brucedawson@chromium.org
      # Skipping CQ checks because original CL landed less than 1 days ago.
      NOPRESUBMIT=true
      NOTREECHECKS=true
      NOTRY=true
      
      Review-Url: https://codereview.chromium.org/2669373002
      Cr-Commit-Position: refs/heads/master@{#447895}
      169e1ad7
    • catapult-deps-roller's avatar
      Roll src/third_party/catapult/ b61c782e8..53604dda6 (3 commits). · 2686c2ee
      catapult-deps-roller authored
      https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/b61c782e8622..53604dda661b
      
      $ git log b61c782e8..53604dda6 --date=short --no-merges --format='%ad %ae %s'
      2017-02-02 benjhayden Merge Breakdown diagnostics.
      2017-02-02 benjhayden Add chromium and v8 commit positions to RevisionInfo.
      2017-02-02 benjhayden Fix related histogram links.
      
      Documentation for the AutoRoller is here:
      https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
      
      If the roll is causing failures, see:
      http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls
      
      CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
      TBR=catapult-sheriff@chromium.org
      
      Review-Url: https://codereview.chromium.org/2673723003
      Cr-Commit-Position: refs/heads/master@{#447894}
      2686c2ee
    • ccameron's avatar
      Towards deleting YUV to RGB computation redundancy · 5f73187d
      ccameron authored
      Make the GetTransferMatrix and GetRangeAdjustMatrix functions part of
      gfx::ColorSpace instead of gfx::ColorSpaceTransform, and call them from
      GLRenderer to compute the YUV to RGB matrix and offset.
      
      Do not actually use the new computation results yet, because they break
      pixel tests. Rather, add a DCHECK that the new results are very close to
      the previous values being used (within 1/255.f).
      
      Fix the transfer matrix for SMPTE170M to have Kb=0.114 instead of 0.144.
      
      Change the definition of gfx::ColorSpace::CreateJPEG to use the Rec601
      transfer matrix, not Rec709. This is necessary for the resulting YUV to
      RGB conversion to match the previous behavior.
      
      BUG=667966
      CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
      
      Review-Url: https://codereview.chromium.org/2670773002
      Cr-Commit-Position: refs/heads/master@{#447893}
      5f73187d
    • brucedawson's avatar
      Allow using goma on Windows with symbol_level == 2 · 4a3cadb2
      brucedawson authored
      Traditionally goma for Chrome has been less useful on Windows than on
      other platforms because it was incompatible with full debug information.
      Building with goma requires using /Z7 instead of /Zi, and this causes
      the linker's memory usage and runtime to blow up as all of the debug
      information is merged.
      
      However, /debug:fastlink makes this work. Because it doesn't merge all
      of the debug information it makes goma and /Z7 practical. Full release
      component builds can be done in less than fifteen minutes, with
      incremental builds taking just a few seconds. Without goma a full
      release component build of Chrome can easily take 40+ minutes, even on a
      Z840.
      
      Goma's speedup comes from massively parallelizing the compile phase,
      however even with /debug:fastlink the linking phases are longer with the
      /Z7 switch that is required by goma. A /debug:fastlink of chrome.dll in
      a component build goes from ~32 seconds to ~110 seconds on a Z620 when
      /Z7 (goma) is selected. This penalty will be reduced by VC++ 2017 which
      claims 30% speed improvements on /debug:fastlink.
      
      So, if you frequently need to do full relinks then goma may still be a
      bad choice. However for most scenarios this change should make goma a
      good choice for component builds of Chrome, even with full debug
      information enabled. To make use of this ability you need to explicitly
      specify the switches below - symbol_level will otherwise default to 1
      when use_goma == true.
      
          use_goma = true
          is_win_fastlink = true
          symbol_level = 2
      
      The fastlink PDBs work well for most scenarios but there are a few
      scenarios (rare for most people) where they do not work:
      - Copying PDBs to another machine (fails due to references to the .obj
      files)
      - Reporting on all symbols/globals with SymbolSort or similar fails
      - ETW tracing fails
      - VS heap profiling fails
      Ideally mspdbcmf.exe would let us create "normal" PDBs when needed but
      in practice this appears to be unusable with /Z7 created PDBs.
      
      R=scottmg@chromium.org
      
      Review-Url: https://codereview.chromium.org/2661023010
      Cr-Commit-Position: refs/heads/master@{#447892}
      4a3cadb2
    • ktyliu's avatar
      Convert make_qualified_names and make_element_factory to use JSON5. · 701ccf95
      ktyliu authored
      Convert make_qualified_names.py, make_element_factory.py,
      make_element_type_helpers.py, and make_element_lookup_trie.py
      to use JSON5 config format.
      
      Converted these config files accordingly:
        Source/core/html/HTMLAttributeNames.in
        Source/core/html/HTMLTagNames.in
        Source/core/html/parser/MathMLAttributeNames.in
        Source/core/html/parser/MathMLTagNames.in
        Source/core/svg/SVGAttributeNames.in
        Source/core/svg/SVGTagNames.in
        Source/core/svg/xlinkattrs.in
        Source/core/xml/xmlattrs.in
        Source/core/xml/xmlnsattrs.in
      
      Note that these files are updated together because:
      1. make_element_factory.py depends on make_qualified_names.py
      2. HTMLTagNames.in is common input to the scripts make_element_factory,
      make_element_type_helpers and make_element_lookup_trie
      
      Removed FIXME in make_element_type_helpers.py since that case
      no longer occurs.
      
      Also fixed bug in json5_generator where parameters should not be
      validated if default_parameters is not provided.
      (caught when I had typo on default_parameters in the script)
      
      BUG=677884
      
      Review-Url: https://codereview.chromium.org/2645283006
      Cr-Original-Commit-Position: refs/heads/master@{#447450}
      Committed: https://chromium.googlesource.com/chromium/src/+/f5ca5654596eeda38c2a796bbbad299d92b7f008
      Review-Url: https://codereview.chromium.org/2645283006
      Cr-Commit-Position: refs/heads/master@{#447891}
      701ccf95
    • shrike's avatar
      Add comments explaining Task Manager idle wakeups computation. · 36fa3dee
      shrike authored
      Adds some comments that would have been helpful to me as I traced the code to understand it. I think they will be helpful to future readers of the code.
      
      BUG=687424
      
      Review-Url: https://codereview.chromium.org/2667023004
      Cr-Commit-Position: refs/heads/master@{#447890}
      36fa3dee
    • skia-deps-roller's avatar
      Roll src/third_party/skia/ 78b6786be..1db215a8e (5 commits). · c61a3771
      skia-deps-roller authored
      https://skia.googlesource.com/skia.git/+log/78b6786beccb..1db215a8efb4
      
      $ git log 78b6786be..1db215a8e --date=short --no-merges --format='%ad %ae %s'
      2017-02-02 mtklein iOS: dequote args one level
      2017-02-02 mtklein iOS: try running the binary
      2017-02-02 bsalomon Revert "Revert "Spot shadow cleanup and optimization""
      2017-02-02 halcanary bin/list-skia-bots
      2017-02-02 msarett Blacklist large images on 32-bit Win 2k8
      
      Documentation for the AutoRoller is here:
      https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
      
      If the roll is causing failures, see:
      http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls
      
      CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
      TBR=halcanary@google.com
      
      Review-Url: https://codereview.chromium.org/2669203004
      Cr-Commit-Position: refs/heads/master@{#447889}
      c61a3771
    • ellyjones's avatar
      harmony: partly harmonize permissions bubble · 2e942b32
      ellyjones authored
      This change:
      1) Changes the title string to not include the trailing colon (this affects the
         non-Harmony version too)
      2) Switches from 9px to 8px for the spacing between items (affects non-Harmony)
      3) Makes the indent on permission entries conditional on non-Harmony
      
      BUG=605667
      
      Review-Url: https://codereview.chromium.org/2654123004
      Cr-Commit-Position: refs/heads/master@{#447888}
      2e942b32
  2. 02 Feb, 2017 15 commits