- 28 Jun, 2018 40 commits
-
-
Marc Treib authored
https://crrev.com/c/1113746 introduced a GetDisableReasons which replaces it. This CL updates all callers to use the new GetDisableReasons instead. Bug: 839834 Change-Id: If832ffb12f24308e08890a7c073d5827c0ef44a7 Reviewed-on: https://chromium-review.googlesource.com/1114959 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#571059}
-
Rohit Rao authored
This reverts commit add11c4c. Reason for revert: Breaks egtests when UIRefresh is disabled. Test Case '-[RecentTabsTableTestCase testRecentTabSigninPromoReloaded]' started. ../../ios/chrome/browser/ui/authentication/signin_earlgrey_utils.mm:39: error: -[RecentTabsTableTestCase testRecentTabSigninPromoReloaded] : Exception: NoMatchingElementException Exception Name: NoMatchingElementException Exception Reason: Cannot find UI Element. Exception with Assertion: { "Assertion Criteria": "assertWithMatcher:isNotNil", "Element Matcher": "((respondsToSelector(accessibilityIdentifier) && accessibilityID('kSigninPromoPrimaryButtonId')) && matcherForSufficientlyVisible(>=0.750000))", "Recovery Suggestion": "Check if the element exists in the UI hierarchy printed below. If it exists, adjust the matcher so that it accurately matches element." } Exception Details: Error Trace: [ { "Description": "Interaction cannot continue because the desired element was not found.", "Error Domain": "com.google.earlgrey.ElementInteractionErrorDomain", "Error Code": "0", "File Name": "GREYElementInteraction.m", "Function Name": "-[GREYElementInteraction matchedElementsWithTimeout:error:]", "Line": "124", "TestCase Class": "RecentTabsTableTestCase", "TestCase Method": "testRecentTabSigninPromoReloaded" } ] Original change's description: > [ios] Creates SigninPromoView UIRefresh styling. > > - Updates SigninPromoView to support a new UI Layout based on UIRefresh Phase 1 flag and a new > flag received on init. > - Some minor refactoring to stop calling self on init in SigninPromoView. > > Screenshots: > https://drive.google.com/open?id=1FnR436FEX9_3GwFbIIrJsQ8qHZOdqJpl > https://drive.google.com/open?id=1__aPHb1ye3WkiHKHJp9kIyJ6hhABq1Y6 > https://drive.google.com/open?id=1ibjz3nnXHBrO_akJm4e9tgghpD85f3u0 > https://drive.google.com/open?id=1dCVkiMW1IMQjWkxcegVxi8r1PLh5ZCqM > > Bug: 805188 > Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet > Change-Id: I1268388da06c57eb9c1610c3547314929bb8c107 > Reviewed-on: https://chromium-review.googlesource.com/1107216 > Commit-Queue: Sergio Collazos <sczs@chromium.org> > Reviewed-by: edchin <edchin@chromium.org> > Reviewed-by: Jérôme Lebel <jlebel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#570864} TBR=rohitrao@chromium.org,jlebel@chromium.org,edchin@chromium.org,sczs@chromium.org Change-Id: I2bf65f4e8848786eb3d60c2db4adb768eed3692b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 805188 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Reviewed-on: https://chromium-review.googlesource.com/1118178Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#571058}
-
Koji Ishii authored
This patch fixes a failure to create inline box fragments when they contain only bidi controls. A pair of PrepareForReorder() and UpdateAfterReorder() re-establishes relationship between inline boxes and its children after bidi reorder. When inline boxes have only bidi controls, the relationship was not re-established correctly, resulting DCHECK failures and incorrect positioning of such inline box fragments. Found in r570132 (CL:1108509) thanks to xiaochengh@. Bug: 636993 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I2fbbd60e230fea872af38d6c133bb26a50e67e4e Reviewed-on: https://chromium-review.googlesource.com/1116415 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#571057}
-
Makoto Shimazu authored
Currently we don't read the cached metadata (= blob's side data) at the subresource loader. This patch is to read it and send it back to the client. Bug: 856521 Change-Id: I8ba4010e6551ba32ff227e47390d974c64bfbfdc Reviewed-on: https://chromium-review.googlesource.com/1116630Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#571056}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/d96c63379000..ac9c7e7edefa git log d96c63379000..ac9c7e7edefa --date=short --no-merges --format='%ad %ae %s' 2018-06-28 benjhayden@chromium.org Fix order of min_start_revision, min_end_revision in Anomaly.QueryAsync. Created with: gclient setdep -r src/third_party/catapult@ac9c7e7edefa The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I447b8b0cce75847d5f4ff56cb90e5432255f2d79 Reviewed-on: https://chromium-review.googlesource.com/1117978Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#571055}
-
Morten Stenshorne authored
This fixes two tests, but will also eventually benefit floats-wrap-inside-inline-00[1234].htm in fast/block/float/, which are currently passing because the absolutely positioned box in the test forces its container to have block children. There's special-code for NG (which we should remove) in LayoutBlockFlow::AddChild() that forces this (and causes other problems). Added a new test, to make it clear what this fix is about. Bug: 734554 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Ia2c0e0b2ab61999207114fdf935880fabc2e677c Reviewed-on: https://chromium-review.googlesource.com/1116959Reviewed-by:
Aleks Totic <atotic@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#571054}
-
Tatiana Gornak authored
Bug: 801985 Change-Id: I8ccb1f7d351c143008e0f66bcf06b8561669a006 Reviewed-on: https://chromium-review.googlesource.com/1088697Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Commit-Queue: Tatiana Gornak <melandory@chromium.org> Cr-Commit-Position: refs/heads/master@{#571053}
-
Roman Sorokin authored
TBR=jonann@chromium.org Bug: b/110714442 Change-Id: I0db647ea3df6c897b6cc367c045842e19bf62162 Reviewed-on: https://chromium-review.googlesource.com/1117690Reviewed-by:
Roman Sorokin <rsorokin@chromium.org> Commit-Queue: Roman Sorokin <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#571052}
-
Kent Tamura authored
serialized_script_value.h is used in 2,000+ compilation units, and this CL reduces its pre-processed size from 5.11MB to 1.79MB. Also, this CL removes unnecessary #includes for serialzied_script_value.h. Bug: 242216 Change-Id: I8bbd09c96461d658770abe40df782d37871d3847 Reviewed-on: https://chromium-review.googlesource.com/1116410Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#571051}
-
Lutz Justen authored
BUG=None TEST=third_party/depot_tools/watchlists.py components/policy/resources/policy_templates.json Change-Id: I8cc5c168f5d374c141456c02db3cc9e43de1eddc Reviewed-on: https://chromium-review.googlesource.com/1114843Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Lutz Justen <ljusten@chromium.org> Cr-Commit-Position: refs/heads/master@{#571050}
-
Jean-denis Muys authored
Converting code base away from direct useage of components/signin. In this case the 4 include files were unused. Also added include of signin_metrics.h, directly used in method AddGlobalErrorMenuItems, but only included indirectly previously. Bug: 797897 Change-Id: Ifa9af45e12da9651bab558d2c898f8ce6fa56299 Reviewed-on: https://chromium-review.googlesource.com/1057332Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Jean-Denis Muys <jdmuys@chromium.org> Cr-Commit-Position: refs/heads/master@{#571049}
-
Ramin Halavati authored
The new binary for traffic_annotation_auditor after the change in crrev.com/c/1117264 is rolled. Bug: 856884 Change-Id: I76523df5e58ace767ac19c619c9bb32da5a25674 TBR: georgesak@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1117686Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#571048}
-
Hirokazu Honda authored
By crrev.com/c/1102224, VDA is actually deleted in TearDownTiming test case. Before deleting decoder and VDA client's state becomes CS_DESTROYED, VDA can invoke PictureReady and those are processed after DeleteDecoder(). At that time, state is CS_DESTROYED and thus LOG_ASSERT(state < CS_RESET) throws an exception. The LOG_ASSERT should be executed only if VDA is not deleted. BUG=chromium:834170 TEST=VDA unittest at veyron_minnie Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I1d18ca4f48f6c0e7129f7364e8d7b0ea083b513f Reviewed-on: https://chromium-review.googlesource.com/1118081 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Pawel Osciak <posciak@chromium.org> Cr-Commit-Position: refs/heads/master@{#571047}
-
Koji Ishii authored
Following bot results are included. 7176 7178 7183 7190 7194 7196 7205 7215 7218 7223 7250 7261 7264 7270 3 lines were removed and 0 lines were deflaked by consecutive results since 7183. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I95462370070f876dcc6302bd010c2e166438678a Reviewed-on: https://chromium-review.googlesource.com/1114878 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#571046}
-
Henrik Grunell authored
This reverts commit 3ebcc06d. Reason for revert: Could be breaking unit_tests on Linux. It's the only suspicious CL I can find. https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Tests%20%28dbg%29%281%29%2832%29/50975 Original change's description: > Implement and wire in NetworkServiceClient::OnFileUploadRequested. > > This checks ChildProcessSecurityPolicy before opening the requested > files for upload. > > Bug: 845612 > Cq-Include-Trybots: luci.chromium.try:linux_mojo > Change-Id: I16538e38bcb0a44acaf8c6dab4342dea8872f81f > Reviewed-on: https://chromium-review.googlesource.com/1098150 > Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> > Reviewed-by: Matt Menke <mmenke@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Cr-Commit-Position: refs/heads/master@{#570986} TBR=jam@chromium.org,mmenke@chromium.org,rmcelrath@chromium.org Change-Id: I00955100281cb36567b570e04742eece69367cf7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 845612 Cq-Include-Trybots: luci.chromium.try:linux_mojo Reviewed-on: https://chromium-review.googlesource.com/1118118Reviewed-by:
Henrik Grunell <grunell@chromium.org> Commit-Queue: Henrik Grunell <grunell@chromium.org> Cr-Commit-Position: refs/heads/master@{#571045}
-
mrefaat authored
Move the logic from shouldOpenURL in tab.mm to ShouldOpenURL in crw_web_controller.mm ShouldOpenURL method should be entirley removed from tab.mm and preload_controller.mm once crbug.com/546402 is addressed. Bug: 850760 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ia7f017942c2095e9ed12e58fe3a790aa53551d35 Reviewed-on: https://chromium-review.googlesource.com/1112646Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#571044}
-
Oscar Johansson authored
When building using Jumbo unnamed namespaces gets merged and variables with the same name conflict. This happens when building in Chrome OS for the variables kErrorNotAvailable in: chrome/browser/extensions/api/input_ime/input_ime_api.cc chrome/browser/extensions/api/input_ime/input_ime_api_chromeos.cc This commit solves the issue by renaming the variables to something more file specific. It also renames other variables in the same namespace, so the naming is locally consistent. Bug: 850484 Change-Id: Id2282be73d75c76bb820c0946fc1caf09aeca8a4 Reviewed-on: https://chromium-review.googlesource.com/1116698Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Oscar Johansson <oscarj@opera.com> Cr-Commit-Position: refs/heads/master@{#571043}
-
Oscar Johansson authored
When building using jumbo the WRITE_RESULT constants defined in net/disk_cache/memory/mem_entry_impl.cc and in net/disk_cache/simple/simple_entry_impl.cc conflict with each other. This commit solves the issue by renaming the constants to something more file specific. Bug: 772146 Change-Id: I118bea2e4943983975640ce178a48adb597f25f3 Reviewed-on: https://chromium-review.googlesource.com/1117066Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: Oscar Johansson <oscarj@opera.com> Cr-Commit-Position: refs/heads/master@{#571042}
-
Ramin Halavati authored
The new binary for traffic_annotation_auditor after the change in crrev.com/c/1117264 is rolled. Bug: 856884 Change-Id: Ief41cd698f8190b3642582a2ddabf15724f91a2f TBR: georgesak@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1117682Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#571041}
-
Takumi Fujimoto authored
Before this CL, selecting desktop in the sources menu immediately brought up the desktop picker. After this CL, the user will have to first choose desktop, then click on the "Cast" button to show the desktop picker. This CL also temporarily removes local files from the list of sources, until the feature is implemented. Screenshot of the sources menu: https://drive.google.com/open?id=1XAyTz05w3ZZdFuQay8QE2QC8NvFgWdwu Bug: 857167 Change-Id: Id55fc8c020e667fb0a081be0d62effeb3684cf8f Reviewed-on: https://chromium-review.googlesource.com/1117567 Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#571040}
-
afdo-chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://afdo-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I1fe9f90fb8bfcccbe88e49cb7a905c8e0b1ee682 Reviewed-on: https://chromium-review.googlesource.com/1117998 Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#571039}
-
Adam Rice authored
Modify IsClosed() and IsErrored() in blink::ReadableStreamOperations to take an ExceptionState& parameters. Modify the wrappers in BodyStreamBuffer to also take ExceptionState&, and make the callers handle exceptions from them correctly. Bug: 853189 Change-Id: I64a806571bd2c080de3ee2b5966cad6142ba0e15 Reviewed-on: https://chromium-review.googlesource.com/1116634 Commit-Queue: Adam Rice <ricea@chromium.org> Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#571038}
-
fuchsia-sdk-chromium-autoroll authored
The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: I241fd842df3fbe4eb135965159b4ecd3c6cd0bcd Reviewed-on: https://chromium-review.googlesource.com/1117934 Commit-Queue: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#571037}
-
Tetsui Ohkubo authored
In UnifiedSystemTray, a11y feature pod button can be shown in collapsed state. In that case, when the button is clicked, the a11y detailed view was shown without expanding the system tray. See the screenshot. Screenshot of the bug: http://screen/wWb2MxGwxMM TEST=manual BUG=856035 Change-Id: Ib345450a07f258156ac82a4f62584c058ec9b35d Reviewed-on: https://chromium-review.googlesource.com/1116627Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#571036}
-
Yuki Awano authored
- Remove focus stealer and directly attach ax tree to contents view of widget delegate of focused widget. - Returns contents view of widget delegate as focused view if no view is focused. Bug: 852653 Test: Enable ChromeVox arc native support and confirm that it works. Change-Id: Ib370a6a2efa11d04211d8dbeae92b95a7e125dfb Reviewed-on: https://chromium-review.googlesource.com/1117720Reviewed-by:
David Reveman <reveman@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Yuki Awano <yawano@chromium.org> Cr-Commit-Position: refs/heads/master@{#571035}
-
Ramin Halavati authored
win-annotator-rel FYI bot performs lenghtly tests on network traffic annotation test tools and requires more time to complete the tests. Bug: 844014 Change-Id: I4fc58618427eb4a1c4c403cd09f5b5aa57ba3e25 Reviewed-on: https://chromium-review.googlesource.com/1107920 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#571034}
-
Kent Tamura authored
wrapper_type_info.h is used in 5,000+ compilation units, and this CL reduces its pre-processed size from 2.24MB to 1.61MB. This CL uninlines WrapperTypeInfo::WrapperCreated() and WrapperTypeInfo::WrapperDestroyed(). It might affect performance slightly. Bug: 242216 Change-Id: I8219835eee87e7b56f85437be8e01c1e69c15f31 Reviewed-on: https://chromium-review.googlesource.com/1117736Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#571033}
-
Tarun Bansal authored
Initialize the value of a variable to avoid triggering use of uninitialized variable error Bug: 819244 Change-Id: Ida4ccc55c872ebaeb54d41c35f237e6930c8aa7b TBR: xunjieli@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1117932 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#571032}
-
Scott Graham authored
This is a reland of https://chromium-review.googlesource.com/c/chromium/src/+/1112840. The gn binary will be downloaded into third_party/gn. This CL rolls buildtools forward to a revision where the gn binary is a stub that prints an error message and returns 1. This is to avoid depending on the old location, and helping users relying on gn auto regen. Update mb.py to use the new location. Update explicit location in ios/web_view/BUILD.gn for the new location. Update explicit location in tools/traffic_annotation/auditor/traffic_annotation_auditor.cc for the new location. Update explicit location in tools/licenses.py with for the new location. Update explicit location in testing/libfuzzer/gen_fuzzer_owners.py. Bug: 855791 Bug: 856883 Bug: 856884 Bug: 856878 Bug: 856899 Bug: 857107 Bug: 857110 Change-Id: Iedaa29161e56cc90beafd802efca3a6c12859c58 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Reviewed-on: https://chromium-review.googlesource.com/1117264 Commit-Queue: Scott Graham <scottmg@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#571031}
-
Mitsuru Oshima authored
This also fixes touch to drag/resize. * Use ash's resizer and removed unecessary code. * added event location for gesture_target in WmToplevelWindowEventHandler. This is necessary to enable touch drag/resize. * mark remote_shell_move as deprecated. BUG=801666 TEST=updated unit test. tested manually with gtk3-demo. Change-Id: I86b785937335bfe31392f42e7d590410576d73ee Reviewed-on: https://chromium-review.googlesource.com/1112932 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#571030}
-
Han Leon authored
This CL renames the interface ServiceWorkerVersion::Listener to ServiceWorkerVersion::Observer and updates ServiceWorkerVersion::{Add,Remove}Listener() to ServiceWorkerVersion::{Add,Remove}Observer(). This renaming is in order to align with ScopedObserver impl which call {Add,Remove}Observer() rather than {Add,Remove}Listener() on the source class. Thus it'll be easier for all observers of ServiceWorkerVersion to leverage ScopedObserver. BUG=855852 Change-Id: Id98e78fc90b96267bc68a69e18a731b71623779d Reviewed-on: https://chromium-review.googlesource.com/1116522 Commit-Queue: Han Leon <leon.han@intel.com> Reviewed-by:Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#571029}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 147ba250. With Chromium commits locally applied on WPT: ab4fb5ca "Update links to feature policy documentation." Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/20270 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: meade@chromium.org: external/wpt/web-animations TBR=markdittmer No-Export: true Change-Id: Ic6e02c91c71570d8a4ae3d352247e44db0b108c7 Reviewed-on: https://chromium-review.googlesource.com/1117921 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#571028}
-
John Budorick authored
Bug: 857001 Change-Id: I89c070724cb540f2ea37fe1c34bfee27f2977549 Reviewed-on: https://chromium-review.googlesource.com/1117648Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#571027}
-
Tim Brown authored
There are two upcoming experiments targeting Windows which will both add a bookmark and want to highlight this feature to the user. This CL adds the ability for the experiments to show a promo bubble to highlight the added bookmarks. Bug: 832933 Change-Id: Ie7dfc219e6ca3552f594d949b43a30786ef000a6 Reviewed-on: https://chromium-review.googlesource.com/1107005 Commit-Queue: Tim Brown <timbrown@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#571026}
-
Adam Rice authored
Modify blink::ReadableStreamOperations::IsLocked() to take an ExceptionState& parameter. Modify all callers so that the ExceptionState is passed through all the way from the bindings layer. Make Body::IsBodyLocked() return an enum { kLocked, kUnlocked, kBroken } similar to IsBodyUsed. Bug: 853189 Change-Id: I3b2350c845bfa57c0123c4426ef8c0b2e3eb6ddc Reviewed-on: https://chromium-review.googlesource.com/1114938Reviewed-by:Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#571025}
-
Philip Rogers authored
with PaintArtifactCompositor::RootLayer. This is a very simple cleanup. PaintArtifactCompositor: :CcLayer is no longer needed and can be replaced Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ie3a4c07f0a514fc96ad2692eb22d6e5b3e106b27 Reviewed-on: https://chromium-review.googlesource.com/1117710 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#571024}
-
rbpotter authored
Bug: 773928 Change-Id: I4a9b62249ac7ac45a73fe2345e7a41bd41525d27 Reviewed-on: https://chromium-review.googlesource.com/1103305Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#571023}
-
Wez authored
The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: Ib0d06bc67ff6ed1fde81d2f5f6a6752f8cf0ad9d Reviewed-on: https://chromium-review.googlesource.com/1117896Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#571022}
-
Joel Hockey authored
* Updated FindCrostiniTasks to stop filtering for entries outside of crostini. * FilesApp FileTasks.execute takes chrome.fileManagerPrivate.FileTask rather than just the taskId so that the task.title is available to show in the error dialgo. * Fixed js docs in file_tasks.js to use correct FileTask rather than generic Object. Added FileTasks.ComboButtonItem type which is used by some functions. * FileTasks.executeInternal_ checks if the selected task type is crostini and any of the entries being operated on are not crostini. If this is detected, error dialog is shown. * Updated existing crostini UI tests to assume crostini is enabled by default. * Added crostini.testErrorOpeningDownloadsWithCrostiniApp test which verifies error dialog is shown when opening Downloads file with crostini app. Bug: 854858 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ic89c70bf4bfec3167f329fd3dc3fef40939e2657 Reviewed-on: https://chromium-review.googlesource.com/1116878 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#571021}
-
chrome://drive-internalsAnand K. Mistry authored
With DriveFS, a number of DriveIntegrationService fields are nullptr because they are no longer used by DriveFS. BUG=845393 Change-Id: Ibafa2d02264059d3383c91c491ee770deb6e4632 Reviewed-on: https://chromium-review.googlesource.com/1116202 Commit-Queue: Anand Mistry <amistry@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#571020}
-