GitLab

This CL fixes some edge condition interactions when being loaded as
a ReadableStream.  In particular, it:

1. Properly distinguishes between the end of the DataPipe and a closed
   DataPipe with bytes left to be read.  A ReadableStream that is not
   actively draining the pipe could get closed too early.
2. Responses must support explicit completion in order to handle error
   conditions properly.  This CL makes DataPipeBytesConsumer wait
   for an explicit signal before closing.
3. Service worker navigation preload is updated to provide the explicit
   completion signals.

Bug: 894815
Change-Id: I8cff3de94aa2dcbc8deb4a9601a95c13b8ab94d9
Reviewed-on: https://chromium-review.googlesource.com/c/1272715
Commit-Queue: Ben Kelly <wanderview@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599192}

Change-Id: I9bac8317577feaadfa00ec88661175b7338ced4a
Reviewed-on: https://chromium-review.googlesource.com/c/1267596Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Shu Chen <shuchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599191}

This reverts commit 5cd8c123.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 599026 as the
culprit for flakes in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vNWNkOGMxMjNlNDUyYzBiNzZmYmJjYWY1M2U4MmQ4NmNhN2Q1NDkzMAw

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Linux%20ChromiumOS%20MSan%20Tests/9016

Sample Failed Step: viz_browser_tests

Sample Flaky Test: FileDisplay/FilesAppBrowserTest.Test/fileDisplayWithoutVolumesThenMountDrive_DriveFs

Original change's description:
> Files app: Select My files when there are no volumes
> 
> Make Files app select "My files" when there are no available volumes,
> this to allow Files app to behave properly when volumes subsequently
> become available.
> 
> Change DirectoryModel.onVolumeInfoListUpdated_ method to check for
> non-null |displayRoot| before trying to change to |displayRoot|. This
> fixes the error "Cannot read property 'getParent' of null" when Drive
> volume becomes available before Downloads volume, which is the default
> volume/root.
> 
> Change FakeDriveFs to unbind the two mojo bindings if they're bound, so
> DriveFsTestVolume can re-mount itself.
> 
> Test: browser_tests --gtest_filter="*/fileDisplayWithoutVolumesThenMount*"
> Bug: 893161, 884967
> Change-Id: Ic813b25261530495c11c9f641a92f6e07f883702
> Reviewed-on: https://chromium-review.googlesource.com/c/1272418
> Reviewed-by: Noel Gordon <noel@chromium.org>
> Reviewed-by: Sam McNally <sammc@chromium.org>
> Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#599026}

Change-Id: I883485c8fc1bdcc22dba93cc4b03b7c157dcb5f2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 893161, 884967, 889703
Reviewed-on: https://chromium-review.googlesource.com/c/1278063
Cr-Commit-Position: refs/heads/master@{#599190}

ProfileSyncServiceBundle owns and exposes signin-related objects for
use by sync tests. These signin-related objects include ones that are
deprecated by IdentityManager and no longer used directly in the
production code being tested; however, up until now it has not been
feasible to convert this test utility to using IdentityTestEnvironment,
as doing so would have required converting the widespread usage of this
utility in one go.

We recently introduced an IdentityTestEnvironment usage mode wherein
it can be supplied with IdentityManager's dependencies from the
external client, precisely to enable incremental conversion in use cases
like this. This CL exploits this usage mode to introduce
IdentityTestEnvironment in ProfileSyncServiceBundle.h and provide an
example of its usage to eliminate a direct usage of the deprecated
classes. Once the conversion is complete, ProfileSyncServiceBundle can
then be changed to *only* hold an IdentityTestEnvironment object.

Bug: 886600, 886599
Change-Id: I205c3567fc0a9bcd6f7b613c00a247c302d71be5
Reviewed-on: https://chromium-review.googlesource.com/c/1273065
Commit-Queue: Colin Blundell <blundell@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599189}

Using wpt-import in Chromium 68550e48.

Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/25974

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

NOAUTOREVERT=true
TBR=lukebjerring

No-Export: true
Change-Id: I132a332cdc953a69e5c54c550a9bb4e5d08c9bb5
Reviewed-on: https://chromium-review.googlesource.com/c/1277603
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599188}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f37e9866851d..2cecd6e79600


Created with:
  gclient setdep -r src-internal@2cecd6e79600

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: Iac9c77c5c0927e0ca3862bf5171f5972e5c40ca7
Reviewed-on: https://chromium-review.googlesource.com/c/1278711Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#599187}

Needed some rebaselining on Mac.

Attempted to mark it as passing here:
https://chromium-review.googlesource.com/c/1277649

Then a sheriff marked it as failing again:
https://chromium-review.googlesource.com/c/chromium/src/+/1278785

TBR=kojii@chromium.org,orphis@chromium.org

Change-Id: I4b282cba19e6c94f032c127f70672cf4cfe133ab
Reviewed-on: https://chromium-review.googlesource.com/c/1278805
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599186}

We currently log the UserDeletedCookieOrCacheFromDialog histogram from
Desktop. On Android we only know about total cookie/cache deletion
and not those started from CBD.
This CL adds logging of the UserDeletedCookieOrCacheFromDialog histogram
to the CBD dialog on Android.

Change-Id: I51c1ff6d3c5dc6f531f5bfccc59f522718b1abef
Reviewed-on: https://chromium-review.googlesource.com/c/1276605
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599185}

The call site of this function is resetting the |allowed_touch_action_|
only, so rename this function to ForceResetTouchActionForTest.

This CL should not introduce any behavior change.

Bug: None
Change-Id: I253d73f4f21bdb6268f43ce535453412f4b32c51
Reviewed-on: https://chromium-review.googlesource.com/c/1277947
Commit-Queue: Xida Chen <xidachen@chromium.org>
Reviewed-by: James MacLean <wjmaclean@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599184}

https://webrtc.googlesource.com/src.git/+log/28d200c24624..55d1af14751a


git log 28d200c24624..55d1af14751a --date=short --no-merges --format='%ad %ae %s'
2018-10-12 terelius@webrtc.org Remove support for microsecond resolution in RtcEventLogs.
2018-10-12 sprang@webrtc.org Move TemporalLayers to api/video_codecs.


Created with:
  gclient setdep -r src/third_party/webrtc@55d1af14751a

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I15b74c4ebe322c1004b1ba8d1cfb25d82b65614c
Reviewed-on: https://chromium-review.googlesource.com/c/1278709Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#599183}

This is a reland of 475bfe9d. Fixed test
failures which happened because some DCHECKs had side effects.

Original change's description:
> [sync::test] Add single client integration test for custom passphrase
>
> Add a Sync integration test which exercises custom passphrase flows, including
> the handling and proper functioning of the newly added key derivation method
> (scrypt).
>
> Add an integration test helper file for encryption-related tasks and modify
> FakeServer and LoopbackServer to allow easier modification of persistent
> entities such as Nigori. Add passphrase-related functionality to
> ProfileSyncServiceHarness to give tests better control over how and when
> passphrase-based encryption is enabled.
>
> The test uses a gray-box approach, where it tests the client at the
> ProfileSyncService granularity, but injects and inspects entities on the (fake)
> server to ensure that encryption is performed properly. This is necessary
> because, when it comes to encryption, we are not interested merely in that it
> does not hinder existing functionality (e.g. two clients are syncing data
> properly in the presence of a custom passphrase), but also that it provides the
> expected security to the user. For this reason, we use our knowledge of the
> encryption architecture internals to ensure that the data committed to the
> server is encrypted in the expected way.
>
> Bug: 894148
> Change-Id: I728f7f18cc0db7b1da50f747a87a640877d0b023
> Reviewed-on: https://chromium-review.googlesource.com/c/1274205
> Commit-Queue: David Davidović <davidovic@google.com>
> Reviewed-by: vitaliii <vitaliii@chromium.org>
> Reviewed-by: Marc Treib <treib@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#598912}

Bug: 894148
Change-Id: I752acff5815531c0c83ebefb43fb620a785e3ca3
Reviewed-on: https://chromium-review.googlesource.com/c/1278790
Commit-Queue: David Davidović <davidovic@google.com>
Reviewed-by: Marc Treib <treib@chromium.org>
Reviewed-by: vitaliii <vitaliii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599182}

WebNode::IsFocusable() updated style and layout tree, without ignoring
pending stylesheets, which meant generating a display:none placeholder
style for the root node. Instead, early return from IsFocusable() when
we are blocking rendering.

Bug: 521692

Change-Id: Idd6cfcf800e4173cfc1bdcb916728c7a0186edf9
Reviewed-on: https://chromium-review.googlesource.com/c/1245787Reviewed-by: Stefan Zager <szager@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599181}

This reverts commit 7bd91635.

Reason for revert: fast/css-grid-layout/grid-columns-rows-get-set.html is flaky
Bug: 894792, 894795

Original change's description:
> [blink] Control ScriptStreamer with ScriptResource
> 
> Move the ScriptStreamer control logic from ClassicPendingScript to
> ScriptResource. In the future, this will allow us to start streaming
> a ScriptResource before the ClassicPendingScript is available, e.g on
> preload.
> 
> The ClassicPendingScript now only sends one "finished" callback, from
> ScriptResource. This callback is either when the streaming completes,
> or when there is no streaming and the ClassicPendingScript has told
> the ScriptResource that it doesn't intend to start streaming. In the
> long run, we want all scripts to go through the streaming interface,
> and we want ScriptResource to control when streaming starts, so the
> "no more streaming" call will disappear -- however it is necessary to
> maintain the current behaviour, and be able to control it with a
> runtime flag.
> 
> Bug: chromium:865098
> Change-Id: I2c4cc16635a6538b7ff24a24463fe6f34efd8a2e
> Reviewed-on: https://chromium-review.googlesource.com/c/1181430
> Commit-Queue: Leszek Swirski <leszeks@chromium.org>
> Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#599148}

TBR=kinuko@chromium.org,rmcilroy@chromium.org,hiroshige@chromium.org,kouhei@chromium.org,vogelheim@chromium.org,leszeks@chromium.org

Change-Id: Id8e8df8f960c60c88762cdf837e7ba9eb74944d6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:865098
Reviewed-on: https://chromium-review.googlesource.com/c/1278758Reviewed-by: Florent Castelli <orphis@chromium.org>
Commit-Queue: Florent Castelli <orphis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599180}

This reverts commit e9c79d56.

Reason for revert: single_process_mash_browser_tests failing on chromium.memory/Linux ChromiumOS MSan Tests
Bug: 894799

Original change's description:
> Make DriveFS opt-out in FilesApp tests.
> 
> Bug: 891197
> Change-Id: Id3101a43cfe97e652d71f720b5f312b933af1113
> Reviewed-on: https://chromium-review.googlesource.com/c/1277133
> Reviewed-by: Noel Gordon <noel@chromium.org>
> Commit-Queue: Sam McNally <sammc@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#599117}

TBR=noel@chromium.org,sammc@chromium.org

Change-Id: If9140eb468d1e27aeb217a3202b638aa0f4e20f7
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 891197
Reviewed-on: https://chromium-review.googlesource.com/c/1278757Reviewed-by: Florent Castelli <orphis@chromium.org>
Commit-Queue: Florent Castelli <orphis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599179}

Currently, IdentityTestEnvironment internally constructs all the
dependencies of IdentityManager as well as the IdentityManager object
itself. This behavior is nice for hiding the fact that IdentityManager
has these dependencies from consumers, but doesn't allow for
usage of IdentityTestEnviroment in incremental conversion of tests that
have broad direct usage of these dependencies. Concretely,
profile_sync_test_util.h provides one such problematic case: it
constructs and directly exposes these dependencies, which are then
broadly used by a set of tests that consume this utility class.
Converting all these tests in one go is not practical.

This CL adds an alternate IdentityTestEnvironment constructor that
takes in the dependencies and constructs IdentityManager via those
passed-in dependencies. To enable this constructor, the CL also
encapsulates the fact that IdentityTestEnvironment otherwise obtains
these dependencies from an internal object within the current
IdentityTestEnvironment constructor.  It also moves ownership of
IdentityManager from that internal object to IdentityTestEnvironment
itself so that it can be created/owned independent of that internal
object.

A followup CL will use this new constructor.

Bug: 886599
Change-Id: I4c6a503dcc11c327193f80bc7d7c48e467c6919b
Reviewed-on: https://chromium-review.googlesource.com/c/1273298
Commit-Queue: Colin Blundell <blundell@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599178}

This CL makes it possible to append values to list-valued properties.

To do this, we must produce a CSSStyleValueVector which holds the final
value produced by the append (i.e. the concatenation of the existing
values and the incoming values). Then (like for StylePropertyMap.set),
a CSSVariableReferenceValue with equivalent tokens is created from that
vector.

Bonus: Fix names of some tests to make it easier to read the output.

R=chrishtr@chromium.org

Bug: 641877
Change-Id: I0d58f66255a9ff7e14c1ee8f4d243353b9a4a0da
Reviewed-on: https://chromium-review.googlesource.com/c/1270967
Commit-Queue: Anders Ruud <andruud@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599177}

This CL allows to create the NavigationRequest directly from
LoadURLParams for new navigations.

Bug: 803859
Change-Id: Ic0f3f368ade86fe57bb549ae6c1d5711f1b58d0e
Reviewed-on: https://chromium-review.googlesource.com/c/1097407
Commit-Queue: Camille Lamy <clamy@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599176}

Since FaviconView name is not used anymore, it makes sense now.

Bug: none
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I0549111a1ade2f8cc61664d1de07160c8687b6de
Reviewed-on: https://chromium-review.googlesource.com/c/1278807Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599175}

symbol_level=1 builds seem to work now and the bot builds with it, so the
entries for crashpad_snapshot_test_image_reader and
crashpad_snapshot_test_image_reader_module.dll are no longer needed.

mini_installer.exe now has a corresponding .pdb that's also non-deterministic
(since the exe itself isn't, the pdb can't be), so add an entry for that.

TBR=erikchen

Bug: 330260
Change-Id: Ic1cde1f5a52a953d74285e4bd6a02e74c70e75b5
Reviewed-on: https://chromium-review.googlesource.com/c/1278306Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599174}

It was using SigninManagerBase API to get the primary (authenticated)
account id. It's now using the IdentityManager API.

Bug: 890792
Change-Id: Ia8cdd8e491f29256af2c015a9127b0766e81b99e
Reviewed-on: https://chromium-review.googlesource.com/c/1276965
Commit-Queue: Sergio Villar <svillar@igalia.com>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599173}

Currently, this does essentially nothing apart from providing basic
resizing and moving functionality. In a follow-up CL, we can add
snap-to-edge, swipe-to-dismiss, and interaction with system ui regions
like the virtual keyboard.

Bug: 841886
Bug: b/115291749
Test: Able to move and resize an Android PIP window.
Change-Id: Iaecc43154fd38dc5f9d3b83549e97dc44a89d749
Reviewed-on: https://chromium-review.googlesource.com/c/1219428
Commit-Queue: Eliot Courtney <edcourtney@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599172}

Speculative fix for crbug.com/789094

Bug: 789094
Change-Id: I1ea9215d049d84b4117f8836754f467c3d8ec9bc
Reviewed-on: https://chromium-review.googlesource.com/c/823582Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599171}

This class is useless now that URL.createObjectURL(MediaStream) has
been removed from the Web platform.

Bug: 591719
Change-Id: I4a56bd8c0cbb86dacab8dafa6acb807509a86367
Reviewed-on: https://chromium-review.googlesource.com/c/1221320Reviewed-by: Camille Lamy <clamy@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599170}

Using wpt-import in Chromium afc97ac0.

Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/25973

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
binji@chromium.org:
  external/wpt/wasm
jsbell@chromium.org:
  external/wpt/resources

NOAUTOREVERT=true
TBR=lukebjerring

No-Export: true
Change-Id: I02e2714a05f60a13999e2efa76ad5039324ed566
Reviewed-on: https://chromium-review.googlesource.com/c/1278537
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599169}

This reverts commit 2ec52056.

Reason for revert: This original CL was reverted as in emergency for M70 as it was in the CL dependency chain for the signin allowed pref CL.

Original change's description:
> Revert "Remove IDC_SHOW_SYNC_SETUP"
> 
> This reverts commit eafee2dc.
> 
> Reason for revert: Still needed for http://crbug.com/888776
> 
> Original change's description:
> > Remove IDC_SHOW_SYNC_SETUP
> > 
> > IDC_SHOW_SYNC_SETUP and IDC_SHOW_SIGNIN have the same integer value. This
> > CL removes IDC_SHOW_SYNC_SETUP to avoid confusion. It also cleans up
> > the code in browser_command_controller that was setting both IDC_SHOW_SYNC_SETUP
> > and IDC_SHOW_SIGNIN without knowing that they are in fact the same thing.
> > 
> > Bug: 870239
> > Change-Id: I3b1ac005d3230fc581e6163a53ad20a84d124402
> > Reviewed-on: https://chromium-review.googlesource.com/1236263
> > Commit-Queue: Mihai Sardarescu <msarda@chromium.org>
> > Reviewed-by: Scott Violet <sky@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#593138}
> 
> TBR=sky@chromium.org,msarda@chromium.org
> 
> # Not skipping CQ checks because original CL landed > 1 day ago.
> 
> Bug: 870239
> Change-Id: I50cd0042f2630dca0bafe4540c2c32411acf0338
> Reviewed-on: https://chromium-review.googlesource.com/1245381
> Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
> Commit-Queue: Mihai Sardarescu <msarda@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#594261}

TBR=sky@chromium.org,msarda@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 870239
Change-Id: Icde4e75988dd24b5bb2add35be055177708c7bfe
Reviewed-on: https://chromium-review.googlesource.com/c/1278745
Commit-Queue: Mihai Sardarescu <msarda@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599168}

Bug: 865114
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: If08aa34d7c17e9f5a6dabb818669012275443587
Reviewed-on: https://chromium-review.googlesource.com/c/1278670
Commit-Queue: Scott Wu <scottwu@chromium.org>
Reviewed-by: Hiroshi Ichikawa <ichikawa@chromium.org>
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599167}

Add an optional callback to proxy override methods introduced in change
https://chromium-review.googlesource.com/c/chromium/src/+/1148384

This adds an optional callback developers can use to know when the
changes have been made to the network settings, since the methods are
not synchronous with the UI thread.

Bug: 851995
Change-Id: I08dc7cc87c57d213b67774d3391562ca07fd0217
Reviewed-on: https://chromium-review.googlesource.com/c/1258770
Commit-Queue: Laís Minchillo <laisminchillo@chromium.org>
Reviewed-by: Eric Roman <eroman@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599166}

Bug: 865114
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: Ibf5ee92330172532dff87f9752d301a134ec49fc
Reviewed-on: https://chromium-review.googlesource.com/c/1264455Reviewed-by: John Wu <jzw@chromium.org>
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Hiroshi Ichikawa <ichikawa@chromium.org>
Commit-Queue: Scott Wu <scottwu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599165}

This adds support for setting multiple values with TypedOM for list-valued
custom properties. For example, for a property --x with syntax <length>+,
it will now be possible to do:

  element.attributeStyleMap.set('--x', CSS.px(1), CSS.px(2));

This is done by producing a CSSVariableReferenceValue holding tokens
equivalent to the incoming CSSStyleValues, provided that those values
match the grammar of the custom property.

R=chrishtr@chromium.org

Bug: 641877
Change-Id: Ic28497edbbea894a9c09b840dcb6c8fb825d99bb
Reviewed-on: https://chromium-review.googlesource.com/c/1270963
Commit-Queue: Anders Ruud <andruud@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599164}

Screenshot before: https://screenshot.googleplex.com/5zbTV7W40Rh.png
Screenshot after: https://screenshot.googleplex.com/59OsupD4J5o.png

Binary-Size: Increase is due to adding new bottom bar background.
Bug: 806868
Change-Id: Ie6863f6922eca210f3e823c22318cd6bd323be81
Reviewed-on: https://chromium-review.googlesource.com/c/1273518
Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org>
Reviewed-by: Ganggui Tang <gogerald@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599163}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/e2727ef6f5dc..03ec3c699be2


git log e2727ef6f5dc..03ec3c699be2 --date=short --no-merges --format='%ad %ae %s'
2018-10-12 vapier@chromium.org cros_portage_upgrade_unittest: convert to mock
2018-10-12 vapier@chromium.org gsutil: add wrapper script for our pinned version


Created with:
  gclient setdep -r src/third_party/chromite@03ec3c699be2

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: I9f381f438b01450da63805d85cec801baa22ec4d
Reviewed-on: https://chromium-review.googlesource.com/c/1278706Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#599162}

Now that the scroll proxy's contentInset is not guaranteed to be zero,
we need to check against the contentInset instead of CGPointZero.

Bug: 894617
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I5ba5131c969a4584879be905a92f0736a34d7f46
Reviewed-on: https://chromium-review.googlesource.com/c/1277674Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599161}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7781cb9daa22..f37e9866851d


Created with:
  gclient setdep -r src-internal@f37e9866851d

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: I1d534c0a85bbd4bb0af445e93060dbd898251de6
Reviewed-on: https://chromium-review.googlesource.com/c/1278707Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#599160}

Drop Dynamic from CreateIncomingDynamicStream, ShouldCreateIncomingDynamicStream and ShouldCreateOutgoingDynamicStream.

Merge internal change: 214983203

R=rch@chromium.org

Change-Id: Iacfc81d8ed6e4a8931aab9fcc52ce8d847bd0e06
Reviewed-on: https://chromium-review.googlesource.com/c/1276445Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Fan Yang <fayang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599159}

VEA unittest is only able to test I420 format input file.
This enables it to test any yuv format stream.

NV12, NV12 and YV21 formated raw videos are created by following commands.
$ ffmpeg -s 320x192 -i bear_320x192_40frames.yuv -pix_fmt nv12 bear_320x192_40frames.nv12.yuv
$ ffmpeg -s 320x192 -i bear_320x192_40frames.yuv -pix_fmt nv21 bear_320x192_40frames.nv21.yuv
$ ffmpeg -s 320x192 -i bear_320x192_40frames.yuv -pix_fmt yuv420p -vf shuffleplanes=0:2:1 bear_320x192_40frames.yv12.yuv

BUG=chromium:894381
TEST=[kevin] ./video_encode_accelerator_unittest --test_stream_data=bear_320x192_40frames.nv12.yuv:320:192:1:bear.out:200000:30:::6 --ozone-platform=gbm

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I8a6b142671fc0532ba872f7eff966d43a2848ad9
Reviewed-on: https://chromium-review.googlesource.com/c/1135106
Commit-Queue: Hirokazu Honda <hiroh@chromium.org>
Reviewed-by: Kuang-che Wu <kcwu@chromium.org>
Reviewed-by: Alexandre Courbot <acourbot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599158}

The second radio button in the passphrase section
was not visibly checked on selection.

To solve this, move the spans containing the conditional
strings inside one radio-button, instead off having two
conditional radio buttons.

Additional change:
 - Remove aria-label attribute because the visible text
   is used automatically as radio button title.

Bug: 894385
Change-Id: Ie339def905ca976444880166552ba580068b9271
Reviewed-on: https://chromium-review.googlesource.com/c/1276645Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Thomas Tangl <tangltom@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599157}

It's a follow-up to https://chromium-review.googlesource.com/c/chromium/src/+/1270922

Bug: 890336
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: Iea3b7be1d588cdcdbdded5409927e18c069812b4
Reviewed-on: https://chromium-review.googlesource.com/c/1277287Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599156}

This CL adds the SwitchToTab image and handling to the omnibox popup
row. It allows to switch easily to an opened tab based on omnibox
suggestions.

Bug: 893121
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: Ib440267802c1210ea416066c679a2ff4e963fbb6
Reviewed-on: https://chromium-review.googlesource.com/c/1268344
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599155}

This CL adds a security check for cross origin with
BindingSecurity::ShouldAllowAccessToCreationContext().
|js_event|, a V8 wrapper object for event object, must be created in the
relevant realm of the event target, but it is possible that listener's
relevant context cannnot access the relevant realm of event target
(ex. when Document.origin is changed).
We have to check this before invoking event listener.

Bug: 872138, 884516
Change-Id: Ic5d0c8e6cda4db57a2097ce230e75cc59905b350
Reviewed-on: https://chromium-review.googlesource.com/c/1270300
Commit-Queue: Yuki Yamada <yukiy@google.com>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599154}

This CL changes the string displayed when the ReadingList is empty so
it doesn't overflow below the bottom and top toolbar when the font is
too big. It does that by limiting the font size.

Bug: 893535
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I03335f2c1fee192a765b6e85011627c0f5ae2019
Reviewed-on: https://chromium-review.googlesource.com/c/1276925
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599153}