- 25 Jun, 2018 40 commits
-
-
Esmael El-Moslimany authored
Bug: 854732 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I4ce3bb683bf41bc46e4bcc896d5705b75b714938 Reviewed-on: https://chromium-review.googlesource.com/1114006Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#570183}
-
Stephen Martinis authored
This is the standard way isolated scripts allow for callers to specify a subset of tests to run. This CL adds this argument, and integrates it with the existing method for specifying a subset of tests to run. Bug: 533481 Change-Id: Ib63c18cfa5cb3db8a5256b7969dccb9541d4f9cc Reviewed-on: https://chromium-review.googlesource.com/1112767 Commit-Queue: Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#570182}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/27d3aa2ed234..5339261bb349 git log 27d3aa2ed234..5339261bb349 --date=short --no-merges --format='%ad %ae %s' 2018-06-25 rharrison@chromium.org Update code coverage documentation Created with: gclient setdep -r src/third_party/pdfium@5339261bb349 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Iba35eea5b5899dccd5fdfce1328648467a25dc86 Reviewed-on: https://chromium-review.googlesource.com/1113826Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#570181}
-
Stefan Zager authored
This extends to the other EmbeddedContentView subclasses the same fix as was made to LocalFrameView in: https://chromium-review.googlesource.com/1055675 BUG=855950 R=skobes@chromium.org Change-Id: I4c9f29fc1e04213ff22e5debd9630ebb81eb1812 Reviewed-on: https://chromium-review.googlesource.com/1114071 Commit-Queue: Stefan Zager <szager@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#570180}
-
Takumi Fujimoto authored
This CL adds a dialog that allows users to enable cloud services in Cast (Hangouts/Meet, Cast for EDU), and notifies that those services are governed by the Google Privacy Policy. The dialog is shown when the user tries to enable cloud services via the context menu of the Cast toolbar icon ("Enable cloud services") if the user has not previously acknowledged this dialog or the first run flow of the old WebUI dialog. If the user clicks on the "Enable" button in the dialog, we enable the preferences kMediaRouterEnableCloudServices and kMediaRouterCloudServicesPrefSet. If the dialog is closed in another way, we make no pref changes. Screenshot: https://drive.google.com/open?id=1MSonPoMLYt0lfLeq9NfP5yoH15EeVZ6c Bug: 848891 Change-Id: I9f565e328ea0fbc84131eef5e0fa3cb179284886 Reviewed-on: https://chromium-review.googlesource.com/1096403 Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Reviewed-by:Bret Sepulveda <bsep@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#570179}
-
Jacob Dufault authored
Fixed ASAN issue where an animation sequence was being used after it was scheduled. In a test, the sequence is destroyed immediately after scheduling. This was a pre-existing issue exposed by the new test. Bug: 855725 Change-Id: I07a475374df775465e4a9f110df6d2759fdf38d6 Reviewed-on: https://chromium-review.googlesource.com/1113997Reviewed-by:
Xiaoyin Hu <xiaoyinh@chromium.org> Commit-Queue: Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#570178}
-
kylechar authored
This CL ensures that if the set of referenced surfaces from the active tree changes then a new CompositorFrame will be submitted. Before this CL LayerTreeHostImpl didn't look at referenced surfaces in HasDamage() so if there is no other damage then it will skip submitting a CompositorFrame. For this to happen the SurfaceLayer can't be visible, as updating the fallback SurfaceId will otherwise contribute to the damage rect. Bug: 854798 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Id3f196bc151d6118e31c51f2bedc62fc773ee65f Reviewed-on: https://chromium-review.googlesource.com/1114066Reviewed-by:
enne <enne@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#570177}
-
Xianzhu Wang authored
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ic84d0a864f37c0917346e3e3479e1856f5c5f2e9 Reviewed-on: https://chromium-review.googlesource.com/1112940 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#570176}
-
Bret Sepulveda authored
Under Refresh the minimum window size increases to more than the value the test is attempting to set the window to. This patch increases the test values. Bug: 846410 Change-Id: I6af5dce66424249402773a07d852d6245e8bfce3 Reviewed-on: https://chromium-review.googlesource.com/1114123Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#570175}
-
Michael Spang authored
This is cleaned up replacement for the functionality provided by "surfaceless" GLSurface implementations that present to platform windows (i.e. objects returned from CreateSurfacelessViewGLSurface()). It is intended for use with vulkan although it currently does not currently have any dependencies on any vulkan APIs. Bug: 1097208 Test: ozone_demo --enable-vulkan on eve (with full series) Change-Id: Ie5318e848f804c8b9f8fbc78372016286d0c3e6b Reviewed-on: https://chromium-review.googlesource.com/1104864 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#570174}
-
Steven Bennetts authored
Bug: 798569 Change-Id: I68aa4c7f08458324a6a59aa9cd2d8bfafeb95c99 Reviewed-on: https://chromium-review.googlesource.com/1111024 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#570173}
-
Tom Anderson authored
Sized deletion was added in c++14. Now that Chrome is building with c++14, we must override sized operator delete for symbol linkage consistency (see bug 855773). R=thakis BUG=855773 Change-Id: Idb673307939119ec520f71911e2074db2496b5ae Reviewed-on: https://chromium-review.googlesource.com/1112731 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#570172}
-
Aleks Totic authored
Part 1: PhysicalLineFragment ScrollableOverflow ScrollableOverflow was not taking relative position into account. PhyiscalLineFragment used to recompute overflow when created. This can't be done if relative position is needed, because resolving % relative position needs size of containing block. New code computes ScrollbleOverflow dynamically for PhysicalLineFragment. Part 2: Make RelativeUtils API physical. It is a better fit for PhysicalFragments. Part 3: NGMixin::AddScrollableOverflow should also add overflow from oof children. Another tricky bug: If ContainingBlock() is inline, Legacy positions OOF block wrt inline block, while NG positions OOF block wrt inline's block container. Because OOF blocks affect scrollable overflow, NG must be responsible for making sure OOF block is included in container's overflow. This patch makes 3 tests pass, and 1 new test fail: compositing/culling/tile-occlusion-boundaries.html The failure is caused by NG not using transfroms for scrollable overflow computation. To fix this, we must make fragments tranform-aware. Filed a bug to do so. Bug: 728378 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Ib511a95cc71648e806d0cc1376f1f6303152ecee Reviewed-on: https://chromium-review.googlesource.com/1113030 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#570171}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ed55419d859b..ff168d9258e0 git log ed55419d859b..ff168d9258e0 --date=short --no-merges --format='%ad %ae %s' 2018-06-25 bsalomon@google.com Put GrPrimitiveProcessor/GrGeometryProcessor before GrPipeline in param lists. 2018-06-25 enne@chromium.org Validate transformed SkPaintImageFilter rects 2018-06-25 hcm@google.com update externally published milestone schedule 2018-06-25 reed@google.com remove bad assert Created with: gclient setdep -r src/third_party/skia@ff168d9258e0 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium: 852048,chromium:855854 TBR=jcgregorio@chromium.org Change-Id: I66cbf0f9efc9793ac60c1d969b4ad7207eea857e Reviewed-on: https://chromium-review.googlesource.com/1113825Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#570170}
-
John Abd-El-Malek authored
Bug: 844927 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Ib0b437f76822800bc393253250ed2660527f276b Reviewed-on: https://chromium-review.googlesource.com/1110666Reviewed-by:
Xi Han <hanxi@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#570169}
-
Peter Kasting authored
Callers outside Tab only referred to the vertical insets, which are now either 0 or Tab::GetStrokeWidth(), a new function added for this purpose, depending on the context. Inside Tab this is subsumed into GetTabEndcapWidth(), which itself has been split into two parts: a general-purpose routine and a pre-refresh-specific "paint" width routine. This may be cleaned up further depending on how I solve narrow tabs in the end. BUG=none TEST=none Change-Id: Ifca96b76b694f3f922e0252cf5198c7a9bb475e3 Reviewed-on: https://chromium-review.googlesource.com/1112773Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#570168}
-
Hongchan Choi authored
AudioIOCallback is specifically designed for real-time audio IO and is not appropriate for AudioDestinationNode. This CL moves the class to DefaultAudioDestinationNode. Bug: 854229 Change-Id: Icb0df6414b944ea1dde3e957d2f36c314b079e0e Reviewed-on: https://chromium-review.googlesource.com/1113955Reviewed-by:
Raymond Toy <rtoy@chromium.org> Commit-Queue: Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#570167}
-
Kenneth Russell authored
There aren't enough Windows AMD machines to run this test suite on AMD GPUs against all ANGLE CLs. The suite runs on NVIDIA and Intel GPUs, and the AMD-specific version doesn't catch many errors at this point, so accept the potential for waterfall-only failures. Bug: 854698 Tbr: geofflang@chromium.org Change-Id: Ifaacd8f559ab339bde24d345548fdf5257d6082e Reviewed-on: https://chromium-review.googlesource.com/1112766Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#570166}
-
manuk hovanesian authored
This reverts commit b7e58d9d. Reason for revert: Introduced regression issues relating to omnibox text being cleared. Original change's description: > omnibox: reset display url when re-navigating to the current page by clicking a link > > Previously, if navigating a link did not cause a url change (e.g. clicking on the `stackoverflow` logo on the `stackoverflow.com` homepage reloads the same page), then the display url remained unchanged. If the user had deleted or edited the url, his changes would remain. Now, the url is reset. > > Bug: 830491 > Change-Id: If1aa07715175d7d5bd5b12a65d9e1d9529aca3b5 > Reviewed-on: https://chromium-review.googlesource.com/1103233 > Commit-Queue: manuk hovanesian <manukh@chromium.org> > Reviewed-by: Tommy Li <tommycli@chromium.org> > Cr-Commit-Position: refs/heads/master@{#568831} TBR=tommycli@chromium.org,manukh@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 830491 Change-Id: If20093795454513c9734fa2c8ed686843e83a683 Reviewed-on: https://chromium-review.googlesource.com/1113879Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#570165}
-
Jordy Greenblatt authored
Change-Id: Ia035745cc311bb7683ad74a446e60468f4dbacaf Reviewed-on: https://chromium-review.googlesource.com/1114082Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Jordy Greenblatt <jordynass@chromium.org> Cr-Commit-Position: refs/heads/master@{#570164}
-
Nico Weber authored
Reapplies https://chromium-review.googlesource.com/c/chromium/src/+/757880, which got removed in https://chromium-review.googlesource.com/c/762380/ when we removed all crashpad_tests from all win/asan bots. crashpad_tests runs on the win/asan bots again, so this one test needs to be disabled again. (See bug; root cause bugs.llvm.org/PR35137) Bug: 856174 Change-Id: I0796efd9ba306ea5a304a5ae85eeb4af9eec656e Reviewed-on: https://chromium-review.googlesource.com/1113664Reviewed-by:
Reid Kleckner <rnk@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#570163}
-
Xianzhu Wang authored
- Remove unused parameters of BoxClipper, RoundedInnerRectClipper and BoxPainterBase; - Remove accumulated scroll offset from PaintLayer; - Remove PaintLayer::MaskBlendingAppliedByCompositor() which always returned true for SPv175. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I4295b6d770294e3ab18a084a88887ec1a17131b9 Reviewed-on: https://chromium-review.googlesource.com/1112954 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#570162}
-
Ehsan Karamad authored
The test virtual/threaded/external/wpt/feature-policy/experimental-features/vertical-scroll-touch-block-manual.tentative.html times out on Linux and Windows quite regularly and is not supported on Mac. Instead of pass-timeout just skip it. TBR=foolip@chromium.org Bug: 853852 Change-Id: Id1e14f95284c93b680e71d27055f107c54e52352 Reviewed-on: https://chromium-review.googlesource.com/1113663Reviewed-by:
Ehsan Karamad <ekaramad@chromium.org> Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Cr-Commit-Position: refs/heads/master@{#570161}
-
Nico Weber authored
Introduce a move-only ScopedWlArray to make sure all wl_arrays in the tests get wl_array_release()d when they are no longer needed. Also rename SetWlArrayWithState() to AddStateToWlArray() since it appends to its argument and doesn't replace the contents (this part has no behavior change). TBR=kbr Bug: 855588 Change-Id: I384ca182b44c9cb864d2d3e94c8ed4f0a0a16f77 Reviewed-on: https://chromium-review.googlesource.com/1113658 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#570160}
-
Kurt Horimoto authored
This has been renamed to ReadingListListViewAccessibilityDelegate, and its interface has been updated to use ListItems rather than CollectionViewItems so the protocol can be shared between implementations. Bug: 805209 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ief145a21be03ae1bfeb23419e57875be8128c1d6 Reviewed-on: https://chromium-review.googlesource.com/1102125Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#570159}
-
Tessa Nijssen authored
When text is selected in a textfield, the touch bar displays options to replace the selected text. Clicking on one of the options will replace the selected text with the selected option. Currently, there are no functional unit tests for the suggested text touch bar. As functionality is fleshed out, unit tests will be created. A new folder (chrome/browser/ui/cocoa/touchbar) was created to house all files related to the Mac touch bar. The CreditCardAutofillTouchBarController files and the WebTextfieldTouchBarController files were moved to this new folder. Dependencies and header guards were updated to reflect this change. New files: - suggested_text_touch_bar_controller.h - suggested_text_touch_bar_controller.mm - suggested_text_touch_bar_controller_browsertest.mm Moved files: - credit_card_autofill_touch_bar_controller.h - credit_card_autofill_touch_bar_controller.mm - credit_card_autofill_touch_bar_controller_unittest.mm - web_textfield_touch_bar_controller.h - web_textfield_touch_bar_controller.mm BUILD files were updated to accommodate the change in location for the moved files and to include the new files. RenderWidgetHostViewMac now informs its RenderWidgetHostDelegate (WebContentsImpl) when RenderWidgetHostViewMac::OnTextSelectionChanged() is called. WebContentsImpl then notifies its observers that the text selection changed. A feature flag SuggestedTextTouchBar was created and added to chrome://about so that the new touch bar is disabled by default and can be enabled via command line or chrome://flags with the flag This CL includes the following browser tests for SuggestedTextTouchBarController: - SetTextTest - TouchBarTest - TextSelectionChangedTest This is a reland of crrev/c/1096443 with the following addition: A check was added to see if the SuggestedTextTouchBar feature flag is enabled around the initialization of SuggestedTextTouchBarController and its WebContentsObserver. This way, the controller and observer are not initialized unless they are actually going to be used. Bug: 717553 Change-Id: Ib591a6791700f79f8f683ee3f6c629f00b612cb0 Reviewed-on: https://chromium-review.googlesource.com/1101306Reviewed-by:
Ehsan Karamad <ekaramad@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Sarah Chan <spqchan@chromium.org> Commit-Queue: Tessa Nijssen <tnijssen@google.com> Cr-Commit-Position: refs/heads/master@{#570158}
-
Victor Costan authored
This CL integrates the following issues: https://github.com/WICG/cookie-store/issues/54 - startsWith -> starts-with https://github.com/WICG/cookie-store/issues/51 - remove cookieStore.has Bug: 729800 Change-Id: If296a9e1eb896cb0ef344a889b1715836610bc6d Reviewed-on: https://chromium-review.googlesource.com/1112912 Commit-Queue: Joshua Bell <jsbell@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#570157}
-
Sadrul Chowdhury authored
Change-Id: I6f561871d9f41994519274731bb766dddcad20e9 Reviewed-on: https://chromium-review.googlesource.com/1113823Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#570156}
-
rbpotter authored
Bug: 855003 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I0b9d3d14c6d1efdbc3b12cfd38d23da4d5d9a112 Reviewed-on: https://chromium-review.googlesource.com/1111336Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#570155}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/8396e3498fd4..d5b8ee1e175e git log 8396e3498fd4..d5b8ee1e175e --date=short --no-merges --format='%ad %ae %s' 2018-06-25 mbonadei@webrtc.org Re-enable PeerConnectionEndToEndTest.Call on TSan. 2018-06-25 nisse@webrtc.org Delete unused methods for replacing the "default filesystem". Created with: gclient setdep -r src/third_party/webrtc@d5b8ee1e175e The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I67a939e672b06578804d0f32aefa4b8cd8717b58 Reviewed-on: https://chromium-review.googlesource.com/1113822Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#570154}
-
Fady Samuel authored
We don't need to ship updated RenderFrameMetadata on change in root scroll offset. Shipping RenderFrameMetadata is expensive and so we should minimize shipping them to the browser process as it also involves synchronization with Viz. We initially decided to plumb this value via RenderFrameMetadata in order to properly support the overscroll glow on Android but this turned out to be too expensive and so we are now investigating ways to compute the overscroll glow at least partially in the renderer. Bug: 672962, 855473 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I139f773eaf673785fec04c9f989abb36e0941ad9 Reviewed-on: https://chromium-review.googlesource.com/1113799 Commit-Queue: Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#570153}
-
Lei Zhang authored
Change-Id: I6f90580f977ca2ccb19d3f1196bd26bbcbb98898 Reviewed-on: https://chromium-review.googlesource.com/1112909 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#570152}
-
afdo-chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://afdo-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: Id76ef2699bcc5f5e1d316ba27026dcc351bba718 Reviewed-on: https://chromium-review.googlesource.com/1114093 Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#570151}
-
Xi Cheng authored
Bug: 851163 Change-Id: Ia6d200535697101d6c76edbfe2b117a3f5d3d733 Reviewed-on: https://chromium-review.googlesource.com/1113201 Commit-Queue: Xi Cheng <chengx@chromium.org> Reviewed-by:
Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#570150}
-
Peter Mayo authored
Add new bug numbers for types of failures seen in animations failures when enabling blink-gen-property-trees. TBR=flackr@chromium.org BUG=836897 Change-Id: I3375acfaac7470834de65e905714e5244b1715c3 Reviewed-on: https://chromium-review.googlesource.com/1113904Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Peter Mayo <petermayo@chromium.org> Commit-Queue: Peter Mayo <petermayo@chromium.org> Cr-Commit-Position: refs/heads/master@{#570149}
-
Ryan Daum authored
Fails in memory sanitizer test downstream. Bug: none Test: unit test Change-Id: If03106801056d192dd70eefd6d4ffaa443505391 Reviewed-on: https://chromium-review.googlesource.com/1114087Reviewed-by:
Alex Sakhartchouk <alexst@chromium.org> Commit-Queue: Alex Sakhartchouk <alexst@chromium.org> Cr-Commit-Position: refs/heads/master@{#570148}
-
David Tseng authored
Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I09802d7786ef583c37a33489516eea2200a5d7c1 Reviewed-on: https://chromium-review.googlesource.com/1112584 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#570147}
-
Eric Karl authored
Updating owners as khushalsagar@ and ericrk@ have been maintaining compositor_impl_android* and would like owners for this and related android code under renderer_host. Change-Id: I2d549bbfd307c0d6e931bfcb47001e2349b6aace Reviewed-on: https://chromium-review.googlesource.com/1114060Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#570146}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/abae09e75336..c8a626f49c09 git log abae09e75336..c8a626f49c09 --date=short --no-merges --format='%ad %ae %s' 2018-06-25 xdai@chromium.org Revert "Add Android mojo_core binaries to Chrome deployment" Created with: gclient setdep -r src/third_party/chromite@c8a626f49c09 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:822034 TBR=chrome-os-gardeners@chromium.org Change-Id: I6f0bc61794ea73128958886893bebc99251997ea Reviewed-on: https://chromium-review.googlesource.com/1113824Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#570145}
-
dpapad authored
When disabled, calling click() (which simulates a 'click' event) should not change the state of the toggle. Bug: None Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I2f1950c698fbc99abd7620d1573f592607f160e2 Reviewed-on: https://chromium-review.googlesource.com/1112719Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#570144}
-