- 04 Jan, 2018 40 commits
-
-
Elad Alon authored
The tests were flaky because of a race with WebRtcEventLogManager::task_runner_. The problem is that SequencedTaskRunner's destructor does not block, allowing us to destroy a WebRtcEventLogManager objects while its |task_runner_| is still executing a task that operates on the WebRtcEventLogManager object. We solve this by making WebRtcEventLogManager work synchronously when it's used in WebRTCInternals' unit tests (but nowhere else). Bug: 796047 Change-Id: I76606b9394c1e5c02a3626fd8d3824bea587d1e4 Reviewed-on: https://chromium-review.googlesource.com/850697 Commit-Queue: Elad Alon <eladalon@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#527083}
-
Dave Schuyler authored
The README.md referred to pretty-print.py (which looks like a typo) and pretty_print.py. This CL changes them both to use underscores (e.g. pretty_print.py). (doc change) Bug: None Change-Id: If13ccf79bfd805cd8cfa3ea3111d318bbe45b545 Reviewed-on: https://chromium-review.googlesource.com/849699Reviewed-by:
Brett Wilson <brettw@chromium.org> Commit-Queue: Brett Wilson <brettw@chromium.org> Cr-Commit-Position: refs/heads/master@{#527082}
-
Xida Chen authored
TBR=skyostil@chromium.org NOTRY=true Bug: 799127 Change-Id: Ic432554bdc50e3e2b438fc78115d939c96fa0e08 Reviewed-on: https://chromium-review.googlesource.com/851156Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#527081}
-
Eugene But authored
_documentURL is not needed for WK-based navigation manager so there is not much value in adding unit tests for this new code. Bug: 796777 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ib4635f6d6d20934ea3fb07793d460ac3c1a786e0 Reviewed-on: https://chromium-review.googlesource.com/846020Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#527080}
-
Joe Downing authored
This change introduces a workaround and a TODO for the WebRTC DCHECK that we have been manually working around. We will continue to work on the proper solution and remove this workaround once it is ready. Note: I also updated the name of the method being commented out due to an error that occurs during CL validation prior to uploading. BUG=793486 Change-Id: Ibb77bf509f28698a4c3564c85386b6362a98daad Reviewed-on: https://chromium-review.googlesource.com/850442 Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org> Reviewed-by:
Lambros Lambrou <lambroslambrou@chromium.org> Cr-Commit-Position: refs/heads/master@{#527079}
-
Daniel Bratell authored
There are two HeaderFlattener classes that do similar things but not identical things. If they end up in the same translation unit (can happen in some extreme jumbo configurations) there will be a clash so this patch renames one of them to HeaderToString. Bug: 746953 Change-Id: I1fa37f86bcf13487fd8b18da766f440b3ad85545 Reviewed-on: https://chromium-review.googlesource.com/848915 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#527078}
-
Xida Chen authored
TBR=chenwilliam@chromium.org NOTRY=true Bug: 799164 Change-Id: I6f264e8e99d472398368151b9f10349f7b3cbe8f Reviewed-on: https://chromium-review.googlesource.com/850636Reviewed-by:
-
Donn Denman authored
This is a reland of 5bd4f41d Original change's description: > [TTS] Fix ML bug: tap near previous selection, initialization. > > Fixes a problem with ML not being applied correctly on a "retap", a tap > near the previous selection. The problem is that the Search is still in > progress and the Bar still active when the retap is processed. > > Adds a new Internal State TAP_GESTURE_COMMIT that allows code to run > during the initial stage of tap gesture processing. This new state is > used to handle the retap by detecting if the panel is still open. > > Loading the Ranker predictor is now moved to an earlier stage of tap > processing (using the new internal state) to allow it to be fully loaded > and ready to predict by the time all the prediction features have been > gathered. > > Refactored writing the outcomes to Ranker in > ContextualSearchPanelMetrics so it can be called when appropriate. Now > logging outcomes and resetting the CSRankerLogger is done whenever the > UI is hidden or a retap is detected. > > BUG=783995 > > Change-Id: I3122a20200696682205379fdd619e655262520f9 > Reviewed-on: https://chromium-review.googlesource.com/802540 > Commit-Queue: Donn Denman <donnd@chromium.org> > Reviewed-by: Theresa <twellington@chromium.org> > Cr-Commit-Position: refs/heads/master@{#524452} Bug: 783995 Change-Id: I3f224ecc53cd18d84d1a8e97316245b817d5f4db Reviewed-on: https://chromium-review.googlesource.com/841244Reviewed-by:
Donn Denman <donnd@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#527076}
-
Wenzhao Zang authored
1) Moved the wallpaper_manager.cc code that's only used by customized default wallpapers to a separate file under //chrome/browser/chromeos/customization. That should be a better place than ash/wallpaper. 2) customization_wallpaper_downloader_browsertest.cc already tests this code path. 3) Deprecate the |CustomizedWallpaperRescaledFiles| class for simplicity. 4) Changed the API to SetCustomizedWallpaperPaths that only sends paths instead of images. Previously, several places that called the method had to supply empty images as placeholders. Bug: 779221 Change-Id: Ia8d38b25444a1a04e81cd39eb3c553ae14e7d4a1 Reviewed-on: https://chromium-review.googlesource.com/831386 Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#527075}
-
Chris Palmer authored
New onwers, more specific label, additional team. Bug: None Change-Id: Id4a3ea39b4f57b68b2d115ad38730c7e153a65cb Reviewed-on: https://chromium-review.googlesource.com/843238Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Commit-Queue: Chris Palmer <palmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#527074}
-
Peter Kotwicz authored
This CL: - Makes WebappActivity#mWebappInfo private - Makes WebappActivity#getWebappInfo() public instead of package private BUG=None Change-Id: I3cec990487e8f6f01ecb4f832d9ae6269859c20a Reviewed-on: https://chromium-review.googlesource.com/843817Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#527073}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/898d5b203487..02a32b0fa432 $ git log 898d5b203..02a32b0fa --date=short --no-merges --format='%ad %ae %s' 2018-01-04 fmalita [skotty] Add polystar support 2018-01-04 benjaminwagner Add support for Build...ParentRevision tasks. 2018-01-04 brianosman Fix android framework build 2018-01-04 benjaminwagner Only uninstall if install failed. 2018-01-04 angle-skia-autoroll Roll skia/third_party/externals/angle2/ 02f152399..c71862aa3 (1 commit) Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=jcgregorio@chromium.org Change-Id: Ied6821d6d3561f93547a778cacd9583412c863de Reviewed-on: https://chromium-review.googlesource.com/850835 Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#527072}
-
Lei Tian authored
CCT android support lib makes the BrowserActionsItemId enum @hide which will not be accessible for Chromium. Bug: Null Change-Id: I0551bb5b23fa9820c7838acbed50fbdc5afd75cd Reviewed-on: https://chromium-review.googlesource.com/849658Reviewed-by:
-
Mike Reed authored
Bug: Change-Id: Ife8c994a3874f74d00143761db4b2ac613a6cd10 Reviewed-on: https://chromium-review.googlesource.com/850920Reviewed-by:
Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Reed <reed@chromium.org> Cr-Commit-Position: refs/heads/master@{#527070}
-
Mike Reed authored
Bug: Change-Id: I005e47b7c46f16154c0fca58c06e4e726a5f7fbf Reviewed-on: https://chromium-review.googlesource.com/850741Reviewed-by:
Florin Malita <fmalita@chromium.org> Reviewed-by:
-
Sandra Sun authored
When we overscroll a scroller with non-auto overscroll-behavior at its scroll extent, no node will be added to the scroll chain, because the scroller can not consume the current delta. However, if we then scroll the scroller to the opposite direction in the same gesture, the scroller won't respond to that because it's not the CurrentlyScrollingNode. This patch adds the first node with non-auto overscroll-behavior to the scroll chain regardlessly, as it's the only node we can latch to, even if it cannot consume the current delta. So when we change the scroll direction, the scroller can still respond to the later events. Bug: 798543 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I8baa77ae6690e095de3018cb112185f48f0854a8 Reviewed-on: https://chromium-review.googlesource.com/848314Reviewed-by:
Ali Juma <ajuma@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Sandra Sun <sunyunjia@chromium.org> Cr-Commit-Position: refs/heads/master@{#527068}
-
jdoerrie authored
This change replaces std::unique_ptr<Value> usages with Optional<Value> in base::JSONParser. Bug: 646113 Change-Id: Id7ab2249e7d2f3ecb15c9ad48436b0a6ebf17259 Reviewed-on: https://chromium-review.googlesource.com/570441Reviewed-by:
-
Wenzhao Zang authored
The code in wallpaper_decoder.cc ([1]) uses the data decoder service but forgot to update the manifest. Because of CL[2], it results in crash. [1] https://cs.chromium.org/chromium/src/ash/wallpaper/wallpaper_decoder.cc?type=cs&l=45 [2] https://chromium-review.googlesource.com/c/chromium/src/+/815995 Bug: 798922 Change-Id: I252a98f0e56821b3df4f46fb383cf2fee09f9ad7 Reviewed-on: https://chromium-review.googlesource.com/849431Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#527066}
-
Jialiu Lin authored
For Win/Mac/Linux, when user signs into Chrome, password manager saves their password hash to profile prefs. This hash is later used for detecting password reuse on potentitial phishing sites (PhishGuard project). On Chrome OS, things are slightly different, since when user signs in, there is no profile object created yet. And password manager objects are not available either since they are tied to profile too. This CL computes the SyncPasswordData based on plain text password, and store it in user_context, which will be passed along until user profile is created. Then it saves the password hash, salt and length to user profile prefs. This CL covers the existing Gaia (online) login flow as well as webui-based offline login flow. There will be a follow-up CL to address the up-coming view-based offline login flow. Bug: 777994 Change-Id: Ia64a63c4d78267a53de50d609c2bb48c5b9ebebe Reviewed-on: https://chromium-review.googlesource.com/827709 Commit-Queue: Jialiu Lin <jialiul@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#527065}
-
depot-tools-roller@chromium.org authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/edac7184bc0b..1adc91f99fe0 $ git log edac7184b..1adc91f99 --date=short --no-merges --format='%ad %ae %s' 2018-01-03 iannucci [download_from_google_storage] Use vpython to invoke gsutil.py. Created with: roll-dep src/third_party/depot_tools The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=phajdan.jr@chromium.org Change-Id: I80224765d21a76c7c96ad7f3ab7b3be48a283b7d Reviewed-on: https://chromium-review.googlesource.com/850435Reviewed-by:
depot-tools-roller . <depot-tools-roller@chromium.org> Commit-Queue: depot-tools-roller . <depot-tools-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#527064}
-
Thanh Le authored
Before screenshot: https://drive.google.com/file/d/16YllngmNnAqhAv-9BfRTeJZ3GPQPTzG9 After screenshot: https://drive.google.com/file/d/1TcfLwcwlm-odd05KfHyHwuDDrsVvC1VZ Bug: 798874 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I38608bf5ccb5baac4939fc44a8567af4879086f5 Reviewed-on: https://chromium-review.googlesource.com/848356Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Thanh Le <thanhdle@chromium.org> Cr-Commit-Position: refs/heads/master@{#527063}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/a12ad0b2..e5cf9fb5 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I5981499b8b7c520d47b461372086839b6c41d77b Reviewed-on: https://chromium-review.googlesource.com/850739Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#527062}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/a0af75cc4d1e..d9dfb6cc16f6 $ git log a0af75cc4..d9dfb6cc1 --date=short --no-merges --format='%ad %ae %s' 2018-01-04 dsinclair Merge CXFA_WidgetData into CXFA_WidgetAcc 2018-01-04 dsinclair Make CXFA_WidgetData constructor protected 2018-01-04 dsinclair Remove CXFA_DataData Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Iedbc18180871bb5a017ae32e183e4e86eb266da3 Reviewed-on: https://chromium-review.googlesource.com/850948 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#527061}
-
Kristian H. Kristensen authored
Change-Id: I2d249bd32a0e173926a2dd1b897a95da759868be Reviewed-on: https://chromium-review.googlesource.com/851032Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#527060}
-
Elly Fong-Jones authored
Harmony Textfields have focus rings, which are 2pt wide and draw outside the Textfield's normal bounds. Since TreeView leaves only 2pt of padding between the Textfield's bounds and the icon on a row, the focus ring can overdraw the icon. To fix that, when focus rings are present, leave a bit of extra space. This doesn't look too bad when not editing since Harmony has more padding across the board, and when editing the focus ring no longer overdraws the icon. Bug: 788128 Change-Id: I4b0752fdec652d6ef3a6f47756ac21d777fa6468 Reviewed-on: https://chromium-review.googlesource.com/850915 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#527059}
-
Matt Reynolds authored
This reverts commit 29212f31. Reason for revert: Crashing on Canary builds, see crbug.com/798987 Original change's description: > Move WifiPollingPolicy to a global instance > > The WifiPollingPolicy controls how frequently the network location > provider will initiate Wi-Fi scans. Previously, the policy was attached > to the WifiDataProvider, which is destroyed when there are no active > geolocation API calls. Destruction of the provider causes us to lose track > of our polling policy. > > The policy allows the first scan to be performed immediately and schedules > subsequent scans at regular intervals. When the provider is destroyed and > recreated rapidly it considers each scan to be "first", which allows many > Wi-Fi scans to be performed in a short window. > > This change moves the policy state to a global instance so it can be saved > when the provider is destroyed and recreated. The new policy allows the > first-ever scan to be performed immediately, and subsequent scans may also > be performed immediately if enough time has lapsed since the previous scan. > In all other situations, the configured polling interval is enforced. > > BUG=764954 > > Change-Id: I00649dde2a707127e53e0330511172fef4a43471 > Reviewed-on: https://chromium-review.googlesource.com/834988 > Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> > Reviewed-by: Reilly Grant <reillyg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#526782} TBR=reillyg@chromium.org,mattreynolds@chromium.org Change-Id: I25d5596418df55e9de9e0f09e6ba7546b54551a4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 764954 Reviewed-on: https://chromium-review.googlesource.com/851132Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#527058}
-
Xiyuan Xia authored
TraySupervisedUser should observe user session addition and switch as well as the user session update. Otherwise, it might miss some session info as in http://crbug.com/796758, where user child info is now only set at user session creation with no user session update followed. Bug: 796758 Change-Id: Ic275ccfa174a21451077e6ec9225901f188e2a63 Reviewed-on: https://chromium-review.googlesource.com/848020 Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#527057}
-
Michał Pichliński authored
Report ContentMainRunner fatal error during initialization to the delegate, which may gracefuly exit with some message instead crashing. Default behavior is CHECK(false). Bug: 792839 Change-Id: I1e7c85c58f1a008e8818e2efb00dbba7f4774826 Reviewed-on: https://chromium-review.googlesource.com/815054Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#527056}
-
Vladimir Levin authored
DrawTextBlob pose an issue to the equality fuzzer in that we don't reconstruct typefaces at deserialization, making the op impossible to serialize again (it asserts). This patch ignores these ops in the equality fuzzer. R=enne@chromium.org Bug: 798939 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I50c039e88737ac443c834b2207f77acb798c3612 Reviewed-on: https://chromium-review.googlesource.com/850538Reviewed-by:
enne <enne@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#527055}
-
Shenghua Zhang authored
yaml_file variable is not passed to pkg_yaml_file in def UploadSdkPackage, this CL fixes that bug. Bug: 659808 Change-Id: I20fb5ca685993f540b4b4699ed5ebdc006e636ff Reviewed-on: https://chromium-review.googlesource.com/848293Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Shenghua Zhang <shenghuazhang@chromium.org> Cr-Commit-Position: refs/heads/master@{#527054}
-
webrtc-autoroll@chromium.org authored
https://webrtc.googlesource.com/src.git/+log/3b116ad3d868..085bb64c8579 $ git log 3b116ad3d..085bb64c8 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ifad898db0c928aba70efc40c404b58773f133e7d Reviewed-on: https://chromium-review.googlesource.com/850932Reviewed-by:
WebRTC Roll Bot <webrtc-autoroll@chromium.org> Commit-Queue: WebRTC Roll Bot <webrtc-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#527053}
-
Raymond Toy authored
The channelInterprtation for a ChannelSplitterNode should be 'discrete', not 'speakers', and cannot be changed. Update tests to verify this. Bug: 795586 Test: constructors/channelsplitter.html Change-Id: Icc909ff0ce8652d6fc63b367129da032182f03f2 Reviewed-on: https://chromium-review.googlesource.com/833008Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#527052}
-
Xida Chen authored
TBR=beccahughes@chromium.org NOTRY=true Bug: 799137 Change-Id: Ia0d1557e9570e4b76263ce9ee386e95c6327220d Reviewed-on: https://chromium-review.googlesource.com/851093 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
-
Marijn Kruisselbrink authored
Bug: 750468 Change-Id: I4b6367418a8f11de8a6702cb137c02343be3b233 Reviewed-on: https://chromium-review.googlesource.com/842856 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#527050}
-
dpapad authored
Bug: 797357 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ia5ee932ad218174a121f27838a089e85b308980f Reviewed-on: https://chromium-review.googlesource.com/843144Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#527049}
-
Charlie Andrews authored
NOTRY=true TBR=nednguyen@google.com CC=perezju@chromium.org Bug: 799106, 799122 Change-Id: I605dd95215ce0a3cfcaacf81be3a7b81ae5ec7c6 Reviewed-on: https://chromium-review.googlesource.com/850436Reviewed-by:
Charlie Andrews <charliea@chromium.org> Commit-Queue: Charlie Andrews <charliea@chromium.org> Cr-Commit-Position: refs/heads/master@{#527048}
-
Xida Chen authored
TBR=skyostil@chromium.org NOTRY=true Bug: 799127 Change-Id: Ib5e99e16a5f49eea7e51fa34b9f901c9c143df76 Reviewed-on: https://chromium-review.googlesource.com/850541Reviewed-by:
-
Abhishek Arya authored
This reverts commit 4766c501. Reason for revert: Multiple security regressions. See crbug.com/799128 and others. Original change's description: > Merge anonymous table boxes when appropriate. > > When a table part box is removed from the layout tree, we may end up > with two anonymous layout part siblings which needs to be merged. We > move the children of the latter into the former. When children of the > latter are themselves anonymous, skip down the layout tree until we find > non-anonymous boxes. This will make sure we merge multiple levels of > anonymous boxes although it means we will have to recreate the anonymous > ancestors of the moved box when the preceding box we are moving it to > does not have anonymous descendants. > > Bug: 181374 > Change-Id: I8a14cec2e036fb4e5b937f89c4a35411dcc98785 > Reviewed-on: https://chromium-review.googlesource.com/846861 > Reviewed-by: Morten Stenshorne <mstensho@chromium.org> > Commit-Queue: Rune Lillesveen <futhark@chromium.org> > Cr-Commit-Position: refs/heads/master@{#526969} TBR=dgrogan@chromium.org,mstensho@chromium.org,futhark@chromium.org Change-Id: I50d510fedeb749cb401b39d0b79674adc9c4384c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 181374 Reviewed-on: https://chromium-review.googlesource.com/851072Reviewed-by:
Abhishek Arya <inferno@chromium.org> Commit-Queue: Abhishek Arya <inferno@chromium.org> Cr-Commit-Position: refs/heads/master@{#527046}
-
Wenzhao Zang authored
Created |UpdateCustomWallpaperLayout| so that |SetWallpaperInfo| is made private. Also, WallpaperManager::UpdateWallpaper can be deprecated due to this CL and the previous CL. Bug: 779221 Change-Id: I27ec8095e0ca21eee8bea3216b930d9bef9e4f4e Reviewed-on: https://chromium-review.googlesource.com/828696Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
-
Kevin McNee authored
Now that crbug.com/798708 is fixed, ContextMenuAllowedScope can be in a base::Optional. We delete the copy and assign constructors to prevent the accidental copying of a ContextMenuAllowedScope into an Optional instead of the construction being done in place. Bug: None Change-Id: Ife88ea31a5aaf31f0c8c55ceb4bc7ca816eef98a Reviewed-on: https://chromium-review.googlesource.com/850936Reviewed-by:
-
