- 16 Sep, 2020 40 commits
-
-
Takashi Sakamoto authored
third_party/vulkan_memory_allocator uses posix_memalign inside vma_aligned_alloc only when defined(__linux__) && defined(__GLIBCXX__) && !defined(_GLIBCXX_HAVE_ALIGNED_ALLOC). When building chrome on linux-rel (using libc), aligned_alloc will be used instead. Since libc allocator shim overrides free, freeing memory allocated by aligned_alloc causes crash. Bug: 1121427 Change-Id: I4d6c34e493a685520bb0c561b1b1c6b16ceb38e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392230Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#807423}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ff50ca34..b09e7729 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I78265e6b1a6a8e18408ffc940243634a7546c7d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410767Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#807422}
-
Raphael Kubo da Costa authored
Tests using generic-sensor-iframe-tests.sub.js have been flaky on the Mac bots for a long time. The flakiness is usually seen in the same-origin iframe focus traversal test, where the "is_sensor_suspended" command returns true rather than false. The cause is the same one as r805674 ("sensors: Rewrite the frequency hint test"): the mock platform sensor uses window.setInterval() to simulate the periodic reading of sensor data, but setInterval()'s actual frequency can vary a lot (especially on the Mac bots), to the point that we cannot rely on the other timer we created in iframe_sensor_handler.html will consistently have a period longer than setInterval()'s. The only way to reliably check if a sensor is suspended or not is to query the mock platform sensor directly at the expense of no longer using only the public API: we now have a isReadingData() method in MockSensor that we use to query if the sensor is fetching new readings or not. Bug: 1073865 Change-Id: I99941b88722fc68163cca54e44ac6fc61a6425cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411933 Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#807421}
-
Reda Tawfik authored
This CL adds favicons to each credential row int the bottom sheet or a default icon if no icon is available for a site. Screenshot: https://bugs.chromium.org/p/chromium/issues/detail?id=1104132#c14 Bug: 1104132 Change-Id: I44c6486a4534498107404c3ee3906ae7e6306ca9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2396238Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Reda Tawfik <redatawfik@google.com> Cr-Commit-Position: refs/heads/master@{#807420}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/97fd79e5180b..588efd970283 2020-09-16 changhaohan@chromium.org TypeScriptify elements/DOMLinkifier.js If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1093296 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I0829d5cc93d71ead5dfc2bdbcceda175e4e7253f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412437Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#807419}
-
Benoit Lize authored
From the dev/beta/stable experiments, this reduces memory by multiple MiB per renderer @95th percentile, with larger savings on popular websites (7MiB on Facebook at the median on desktop, for instance). Enable it by default. Bug: 1029320 Change-Id: Iaa355d50f80617b2a8eb763984761a5cc3d5aae3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410041Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#807418}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/d48ef5f7ddc8..5e931ebb24fb 2020-09-16 fmayer@google.com Merge "Clarify experimental_flamegraph example." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ia2a4817d247c53d545a25864c2620c4afaff8b1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413787Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#807417}
-
Danil Chapovalov authored
This is a temporary solution. pending on help from abseil team to resolve this SI properly As side effect it disables absl's stack traces for mac. Bug: 1127002 Change-Id: I7be2c1d15af50ba50c7a9df2d56ae00939c4aa12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409693Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Commit-Queue: Danil Chapovalov <danilchap@chromium.org> Cr-Commit-Position: refs/heads/master@{#807416}
-
Adlai Holler authored
We already have the GrDirectContext available, so just use that. Change-Id: I49436e7a8fefc0cc3bdd9e6425bd730c4a897e03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410539 Auto-Submit: Adlai Holler <adlai@google.com> Reviewed-by:
Robert Phillips <robertphillips@google.com> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Commit-Queue: Adlai Holler <adlai@google.com> Cr-Commit-Position: refs/heads/master@{#807415}
-
Changhao Han authored
Frontend CL: https://crrev.com/c/2410229 Bug: chromium:1047356 Change-Id: Id1c4e2bbb00ab1edda81f8f95d9c9cb7705c206c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410069Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Changhao Han <changhaohan@chromium.org> Auto-Submit: Changhao Han <changhaohan@chromium.org> Cr-Commit-Position: refs/heads/master@{#807414}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/4d3a0f602852..5453e7b7795f 2020-09-16 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 1960f3b2 to e4cbd27e (817 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: jmadill@google.com Change-Id: I64d469b86a8b365c36a475b71b88180c58696544 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413403Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#807413}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome TBR=chrome-os-gardeners@google.com Change-Id: I5416f18adfa6e7f14452094ec3b6c2ef9791a48b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413553Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#807412}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/deacaf80c273..0f21b6caecea If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC rhalavati@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: rhalavati@google.com Change-Id: I8384f8a883daeaf328d4ba74621ed79b6fab8244 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413406Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#807411}
-
Yutaka Hirano authored
Expose WebTransport interface so that we can use the interface for various protocols such as QUIC and HTTP/3. We keep QuicTransport for some time to make the transition easier. https://github.com/WICG/web-transport/issues/129 Bug: 1123413 Change-Id: I8a6cc835fa0ae44804b5cb21bf6e5553c371334a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386692 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Victor Vasiliev <vasilvv@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#807410}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: I56926c9c55c099b654b66a5d3e47274d8cccee28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413405Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#807409}
-
Satoshi Niwa authored
The search query will be used to perform a search in the selected folder at Files app start up. This is required for DocumentsUI CTS (See go/arc-r-documents-ui) TEST=unit_tests --gtest_filter="FileManagerUrlUtilTest.* Bug: 1126742 Change-Id: I298100e70cea260c8c89acead13d63a152e4ca7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402926Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Satoshi Niwa <niwa@chromium.org> Auto-Submit: Satoshi Niwa <niwa@chromium.org> Cr-Commit-Position: refs/heads/master@{#807408}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/8e500174f4bb..2595f13f7e0c 2020-09-16 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: Ia727531ae1eda80117153015ce7e280cc5af89d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413404Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#807407}
-
Milica Selakovic authored
Automated password change fails if it is started with empty username. Without username flow cannot pass login stage. Bug: 1128880 Change-Id: I5a934f3fbf1ca0f992bae23afcd0717deca6decc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413262Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Milica Selakovic <selakovic@google.com> Cr-Commit-Position: refs/heads/master@{#807406}
-
Rune Lillesveen authored
AttachContext.force_legacy_layout was not initialized for slot elements when attaching for assigned flat tree children. We did not fall back to legacy layout for children of a slot styled as a multicol container. Bug: 1127874 Change-Id: I092ce2bb6f1af6a0af67c47d692f8f41284eedb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410487 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#807405}
-
Swapnil authored
ForceInstalledMetrics::ReportMetrics is a large method and it would be good to break it down into smaller sub-methods. This CL adds new methods to report error codes for force installed extensions when the failure reason is either MANIFEST_FETCH_FAILED or CRX_FETCH_FAILED. Bug: 1127851 Change-Id: I4e3d0ac6c393a4f1af14a5979c80f08641159ee9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409960Reviewed-by:
Oleg Davydov <burunduk@chromium.org> Commit-Queue: Swapnil Gupta <swapnilgupta@google.com> Cr-Commit-Position: refs/heads/master@{#807404}
-
Alex Rudenko authored
Re-enables the test and fixes it to account for async rendering of the styles panel. Bug: chromium:1075869 Change-Id: Ia148e6dc7e99a29fd14df22ea3f80253bdd10827 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412731 Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#807403}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I94f292cadd364a941585809da4fa7855557141da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412981Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#807402}
-
Denis Kuznetsov authored
Bug: 1024092 Change-Id: I76cf85b16b2d3bc65445dd8559357529f0798011 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404453Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#807401}
-
Hiroki Sato authored
This change exposes the docked magnifier preferences via chrome.accessibilityFeatures API. Bug: 1125420 Test: browser_test AccessibilityFeaturesApiTest Change-Id: I327c987d52c02ba08455716b213a31a1ba45eb0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402924 Commit-Queue: Hiroki Sato <hirokisato@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#807400}
-
Andrei-Laurențiu Olteanu authored
Reorder GetService() and OnDisconnect from diagnostics_service.h. Fix wrong service name from comment. Added DiagnosticRoutineEnum Convert to diagnostics_service_converters.h because vector Convert method uses it and needs to be the first method of the file. Reorder methods from diagnostics_service_converters.h. Bug: b:166723291 Change-Id: Iaf2d2484701393e7a9abc4ad387e2a8e4c0bece4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410241 Commit-Queue: Laurențiu Olteanu <lolteanu@google.com> Reviewed-by:
Oleh Lamzin <lamzin@google.com> Reviewed-by:
Mahmoud Gawad <mgawad@google.com> Cr-Commit-Position: refs/heads/master@{#807399}
-
Hiroki Nakagawa authored
This CL moves the tests for prerender from core/exported/ to core/loader/ to support core/exported/ deprecation. See the following doc for details of the deprecation: https://docs.google.com/document/d/1lzGeXN4nwnANdFSpVxmJ1TUgb3QBPFCjVxLsFVBlKdE/edit?usp=sharing This CL also renames prerendering_test.cc to prerender_test.cc, and PrerenderingTest to PrerenderTest for consistency with other prerender components. Bug: n/a Change-Id: Ia1af6176b3cb2e01e5fa9f7f514801f1c352a10d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409431 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#807398}
-
Jan Wilken Dörrie authored
This change moves the utilities base::invoke, base::identity and several type traits used in the implementation for base::ranges from base/ranges to base/stl_util.h and base/template_util.h, so that they can be more easily consumed by other code. Bug: 1071094 Change-Id: I8e2bacd5e8b83f1b374b4e6db118c37af5db7c3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404854 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#807397}
-
Hiroki Nakagawa authored
For code simplification, this CL replaces WebPrerenderRelType with mojom::PrerenderRelType. Before this change, WebPrerenderRelType was represented as bit-field. This is because it was allowed to specify both "prerender"[1] and "next"[2] types at the same time in the link rel attribute like <link rel="prefetch next">. However, in that case, "prerender" is just prioritized[3], so it was unnecessary to keep both the types in the bit-field. Therefore this CL introduces the mojom::PrerenderRelType as enum instead of bit-field. This would make code simpler and more readable. [1] https://html.spec.whatwg.org/C/#link-type-prerender [2] https://html.spec.whatwg.org/C/#link-type-next [3] https://source.chromium.org/chromium/chromium/src/+/master:components/prerender/browser/prerender_manager.cc;l=177;drc=ee49bcdf8e3a7764fa22b8e9d1ec1d0c9332870f Bug: n/a Change-Id: Ida2957a659c7578930bdeac136c72ebc8cacb8b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409890Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#807396}
-
Joanmarie Diggs authored
AXLayoutObject::TextAlternative calls LayoutText::PlainText which has special handling for generated content which depends on TextBoxes returning a non-empty InlineTextBoxList. But if we're in a Layout NG context, an empty list is returned so AXLayoutObject::TextAlternative falls back on the LayoutObject's text which includes whitespace that is not included in the child AXInlineTextBox. Because the AXPosition which corresponds with the end of the generated content is at the end of the child kInlineTextBox, but not at the end of the kStaticText parent, we were hitting an infinite loop between AXPosition::CreateParentPosition and AXPosition::AtStartOfLine. The infinite loop was fixed in http://crrev.com/c/2369681. But we still need LayoutText::PlainText's special handling for generated content to work regardless of which layout engine is being used, and for the text exposed via accessibility APIs to not include collapsed whitespace from generated content. Because we can get the TextBoxInfo regardless of the layout engine, use that instead of the actual InlineTextBox instances in LayoutText::PlainText to fix both issues. AX-RelNotes: N/A Bug: 1122637 Change-Id: Ic5a99a92e05bcd751f8ecd2aa236350c909ebe35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2395719 Commit-Queue: Joanmarie Diggs <jdiggs@igalia.com> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Oriol Brufau <obrufau@igalia.com> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#807395}
-
sandromaggi authored
This removes a possible asynchronous state when an out-of-loop write to the |UserData| happens. This may be caused by a PDM update. Check Patchset 1 for a test case that shows such a failure. Bug: b/168445878 Change-Id: Iae9fb3aa823d1c6e64acd598a1b31be587c0493c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410036Reviewed-by:
Clemens Arbesser <arbesser@google.com> Reviewed-by:
Marian Fechete <marianfe@google.com> Commit-Queue: Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#807394}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/726af6f78f80..e8ce4355ae1c 2020-09-15 andreperezmaselco.developer@gmail.com spirv-fuzz: Add bit instruction synonym transformation (#3775) 2020-09-15 vasniktel@gmail.com spirv-fuzz: Skip unreachable blocks (#3729) 2020-09-15 afdx@google.com Fix build errors (#3804) 2020-09-15 vasniktel@gmail.com spirv-fuzz: Handle invalid ids in fact manager (#3742) 2020-09-15 vasniktel@gmail.com spirv-fuzz: Support memory instructions MoveInstructionDown (#3700) 2020-09-15 stefanomil@google.com spirv-fuzz: Pass submanagers to other submanagers when necessary (#3796) 2020-09-15 stefanomil@google.com spirv-fuzz: Transformation to flatten conditional branch (#3667) 2020-09-14 46493288+sfricke-samsung@users.noreply.github.com spirv-val: Add BaseInstance, BaseVertex, DrawIndex, and ViewIndex (#3782) 2020-09-14 dnovillo@google.com Properly mark IR changed if instruction folder creates more than one constant. (#3799) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,jmadill@google.com Change-Id: I5dfd8b4c49b7783fd25f375eacba608e766ab12e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413401Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#807393}
-
Boris Sazonov authored
Plumbs OnGaiaCookieDeletedByUserAction through JNI and exposes it to the Java code. Bug: 1095112 Change-Id: I0e47a48ba26f70c3e5d9706dca0904974ea2b852 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410256Reviewed-by:
Alice Wang <aliceywang@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#807392}
-
sauski authored
Bug: 1081866 Change-Id: I8d472c78e4251c3549b24ee4eda01a20f97df75a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404925Reviewed-by:
Rainhard Findling <rainhard@chromium.org> Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Cr-Commit-Position: refs/heads/master@{#807391}
-
Sylvain Defresne authored
set_sources_assignment_filter() is considered as a mis-feature of gn (as it makes it difficult to reason about the BUILD.gn files individually). Bug: 1018739 Change-Id: I95e88c9c5592c1425f2a3ded0b59d72c6a1bd0e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410397 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#807390}
-
Hidehiko Abe authored
https://chromium.googlesource.com/chromium/deps/icu.git/+log/79326efe26e5..d7eebbfb276a $ git log 79326efe2..d7eebbfb2 --date=short --no-merges --format='%ad %ae %s' 2020-09-16 hidehiko icu: Expand is_linux to is_linux || is_chromeos. 2020-09-11 fdegans [fuchsia] Bring more changes from the Fuchsia copy 2020-09-01 fdegans Upstream Fuchsia changes in build file 2020-06-29 adetaylor Add CPEPrefix. Created with: roll-dep src/third_party/icu Bug: 1110266 Change-Id: I41906106d93794e7d11d65571512e9bea85352e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413511Reviewed-by:
Eliot Courtney <edcourtney@chromium.org> Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#807389}
-
Finnur Thorarinsson authored
When the user navigates to a PWA, we should show 'Install app' instead of 'Add to homescreen'. Bug: 1128364 Change-Id: Ie778478a1c0484158b4724100ad83f827d34634f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398503Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#807388}
-
François Beaufort authored
This CL makes sure a USB Webcam device on macOS properly advertises its PTZ support. When supported, the pan, tilt, and zoom controls (ranges and values) are available to websites that user has granted access to. Bug: 934063 Change-Id: I9d92d41fba0a6e9d518efb2501355d66cf77998f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368596Reviewed-by:
François Beaufort <beaufort.francois@gmail.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#807387}
-
Christian Biesinger authored
The previous code did not do the right thing for abspos boxes. R=ikilpatrick@chromium.org, mstensho@chromium.org Bug: 1083010 Change-Id: I0ec70519d8b4501c67718ab9baabc6bf1d11ac36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412136 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#807386}
-
Alex Ilin authored
RevertReason enum used to be used for recording histograms but it's no longer the case. This CL removes this enum to simplify the code in preparation to upcoming refactoring (see the bug). Bug: 1128451 Change-Id: I497c9b53ba5b3acade5bb9a9cfeeee4445443f5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412308Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#807385}
-
Camillo Bruni authored
- Add better assertion failure messages - Use better content for document.write The tests assume that the ignore-destructive-writes counter is only incremented during the synchronous part of module evaluation (see https://github.com/whatwg/html/pull/4352#issuecomment-611193922). This also fixes document-write/module-delayed.html which accidentally had wrong test expectations checked in that made it pass. Bug: 1127215 Bug: 1022182 Bug: v8:9344 Change-Id: I01a75534f7efd0bd8e376dfd049432e52661604d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397696Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#807384}
-