- 15 Mar, 2020 11 commits
-
-
Rouslan Solomakhin authored
Before this patch, Chrome dimmed the screen after the user has payment in minimal UI, because the reconciler was not aware that a bottom sheet was being displayed. This patch applies the same bottom sheet logic from reconciler to both expandable payment handler UI and minimal UI. After this patch, Chrome UI is not dimmed after user confirms payment in minimal UI. Bug: 1005076 Change-Id: Id9e5f220cb8ba7bef4bb06c6f72e725e971ce9e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097415 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#750427}
-
Koji Ishii authored
This patch has no behavior changes. TBR=wangxianzhu@chromium.org, yosin@chromium.org Bug: 1025341 Change-Id: I254f3dbe4624b9f6bc7f0c5af870e7e4f60d754c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103828Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#750426}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: Ibeab6f65af9e3a216ddd5eed7cba18b2b1c1bff5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104097Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#750425}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/8578f9bc732f..222b156b486b git log 8578f9bc732f..222b156b486b --date=short --first-parent --format='%ad %ae %s' 2020-03-15 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@222b156b486b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ie912c0091ed4ce0eca1350d32f0886479be1904f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104135Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#750424}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/db3f042bb8f2..869e901ad7dd git log db3f042bb8f2..869e901ad7dd --date=short --first-parent --format='%ad %ae %s' 2020-03-15 jmadill@chromium.org Temporarily disable optimizations in angle_perftests. Created with: gclient setdep -r src/third_party/angle@869e901ad7dd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jmadill@google.com Change-Id: Id7f7824287d32128792532ba598abba38fc7bb4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104134Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#750423}
-
Xianzhu Wang authored
The runtime feature TransferableStreams is implied by RTCInsertableStreams which is in origin trial which means the enabled status can depend on the execution context, which requires TransferableStreams also to be in origin trial in order to be execution context aware. The problem was that RTCInsertableStreams could be enabled for some particular execution context, while REF::TransferableStreamsEnabled() didn't know that and might return false in the execution context, breaking the "implied_by" rule defined in runtime_enabled_features.json5. A followup CL will add rules checking such wrong definition in runtime_enabled_features.json5. Bug: 954679 Change-Id: Id1e0a430f5bff6bf05944cb91cb570116ea5bac3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104014 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#750422}
-
Nico Weber authored
The code causes a new compile warning, and it's unused. So stop building it. (See also https://github.com/aappleby/smhasher/pull/81 failing to get traction.) Bug: 1054220,1058381 Change-Id: I68758e94cd2728df70e78c60e9be0bb4006a847a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103719 Auto-Submit: Nico Weber <thakis@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#750421}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/1b512b2a65c5..8578f9bc732f git log 1b512b2a65c5..8578f9bc732f --date=short --first-parent --format='%ad %ae %s' 2020-03-15 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@8578f9bc732f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I32b242fa6ea8f94454af73113c19ae1c37e57767 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104132Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#750420}
-
Julie Jeongeun Kim authored
This is a reland of 9321f32f Original change's description: > a11y: Use more g_return_val_if_fail in AXPlatformNodeAuraLinux > > These macros are used when implementing GObject interfaces to help > mitigate accidental misuse of the API. We were using them, but not > consistently in the AuraLinux accessibility implementation. This change > makes their use more consistent. > > The original author of this CL is Martin Robinson<mrobinson@igalia.com> > > Bug: 1032019 > Change-Id: I75ee57eea79ab11202924f9b04bd1def78dd5fc6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096167 > Commit-Queue: Julie Kim <jkim@igalia.com> > Reviewed-by: Martin Robinson <mrobinson@igalia.com> > Cr-Commit-Position: refs/heads/master@{#749059} Bug: 1032019 Change-Id: I750767f3ed9c370b1dee942015db203f1e913a2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100366Reviewed-by:
Martin Robinson <mrobinson@igalia.com> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#750419}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/a3cf06ac1718..db3f042bb8f2 git log a3cf06ac1718..db3f042bb8f2 --date=short --first-parent --format='%ad %ae %s' 2020-03-15 jmadill@chromium.org Trace Tests: Rebase path to relative dir. Created with: gclient setdep -r src/third_party/angle@db3f042bb8f2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jmadill@google.com Change-Id: Ic8ba470901793aae21cb64bc79585e6a3bb50523 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104131Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#750418}
-
Nico Weber authored
This reverts commit c7fc8475. Reason for revert: breaks tot bots, see e.g. https://logs.chromium.org/logs/chrome/buildbucket/cr-buildbucket.appspot.com/8885810891742311184/+/steps/gclient_runhooks/0/stdout Original change's description: > Change to download and build zlib every time, in case a bot happens to die during a build > > Change-Id: I04e3bfcf520eef8b7fe41cfa1cb04e87de413363 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052585 > Commit-Queue: Amy Huang <akhuang@google.com> > Reviewed-by: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#750365} TBR=thakis@chromium.org,hans@chromium.org,akhuang@google.com Change-Id: I753aaa490176448d2a78a8ea540de3066ac78b39 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104210Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#750417}
-
- 14 Mar, 2020 29 commits
-
-
Arthur Eubanks authored
The warning was changed to be emitted under -Wpointer-to-int-cast in https://reviews.llvm.org/rG51d7f645448b49c7d3b029a60532bac019da1348. Since -Wno-microsoft-cast is on right now with the pinned Clang, I think it makes sense to not add this under llvm_force_head_revision. We can remove -Wno-microsoft-cast after the pinned Clang contains the LLVM change above. Bug: 1054220 Change-Id: I2b989cbe4936fa237e7cfb2f725d14873d5abaf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104127Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#750416}
-
Toni Barzic authored
Fixes an oversight from CL:2099591 - the drag handle nudge should not be hidden just because ShouldShowNudge returns false. The nudge is automatically shown once a day, so just showing the nudge would cause ShouldShowNudge return false (so the next shelf state change, for example extending hotseat, might cause the nudge to get hidden). BUG=1060462 Change-Id: I8024031dc319105dc7f56b8e42e41886222cdf63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104128 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#750415}
-
chromium-autoroll authored
Roll silvermont AFDO profile from 82-4072.0-1583746630-benchmark-82.0.4082.0-r1 to 82-4072.0-1583746630-benchmark-82.0.4084.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-silvermont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I713dea2dacb72b22495fbade085e0f60ab87c1ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104093Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#750414}
-
chromium-autoroll authored
Roll airmont AFDO profile from 82-4072.0-1583751487-benchmark-82.0.4082.0-r1 to 82-4072.0-1583751487-benchmark-82.0.4084.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-airmont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I286d641e9961a6b75e0a466e45d0d244cbc0716f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104094Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#750413}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: Ia1e2cc4a0d85bf5790ae3109fc7bf772b1e03011 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103900Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#750412}
-
Piotr Bialecki authored
Add test case for the DOM overlay and hit test API interaction - hit test results should be suppressed if the input source is interacting with cross-origin content. Change-Id: Ib7af656c19177ef725205e8bd27bac57b81b9cce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103302Reviewed-by:
Klaus Weidner <klausw@chromium.org> Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#750411}
-
Kurt Horimoto authored
Bug: 1030357 Change-Id: I871783a06b7ddbe25dfbea1368565bd4aad54ba1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041190 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#750410}
-
Daniele Castagna authored
Roll src/chromeos/assistant/internal/ d3a99ca02..4e7273378 added a parameter to CrosActionModule ctor, but the code what was instantiating one still assumes there are only three parameters. This CL adds the fourth parameter where we instantiate CrosActionModule. Bug: b:149570650 Test: Now chrome for chromeos compiles Change-Id: I950a3557df7d996b5d0695b9fa2de4633c448afe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103717Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Auto-Submit: Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#750409}
-
chromium-autoroll authored
Roll ChromeOS orderfile from 82-4072.0-1583746630-benchmark-82.0.4079.0-r1 to 82-4072.0-1583746630-benchmark-82.0.4081.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-orderfile-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: If6c9db0c285132f3eb2978ebfc917f68180862a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104089Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#750408}
-
Tarun Bansal authored
Remove warmup prober and secure proxy checker from data reduction proxy (DRP). Change-Id: Id975cc66fdec5eaff14bd5baaf58ea951c0d3055 Bug: 1048736 TBR: waffles@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101718 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Auto-Submit: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#750407}
-
Scott Violet authored
Without this when line-clamp is reached the box does not include the bottom border. BUG=none TEST=wpt/compat/webkit-box-clamp-bottom-border.html Change-Id: Ib67baa655b66e4a81ca30a4d55c202496b6f8e7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103399Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#750406}
-
Rouslan Solomakhin authored
This patch adds an android_browsertest for Minimal UI. Bug: 1005076 Change-Id: Idb24584eb47adce9cd4e89f65c98786fb14a19e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093164 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Danyao Wang <danyao@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#750405}
-
Mehran Mahmoudi authored
This CL: 1. renames the existing paint_preview_test flag to paint_preview_demo. This can only be enabled from about:flags. 2. Hooks up the app menu item that is bound to this flag to the PaintPreviewDemoManager class. When the menu item is selected, a Paint Preview of the current page is captured and shown. If the back button is clicked or the page is refreshed, the Paint Preview will be removed. Bug: 1058405 Change-Id: Ifc96249609d3754508cd2ff8ae55ee0c7237bc7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087418 Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#750404}
-
Jan Wilken Dörrie authored
Passing the end iterator to std::vector::erase(iterator) is undefined behavior. Thus in order to avoid UB in base::flat_tree this change adds a CHECK that the passed in iterator is not the end iterator. Bug: 682254 Change-Id: I11f746a335b817c31ea5b6431a0f042c613579a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102733 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#750403}
-
Jacobo Aragunde Pérez authored
The F6 (rotate pane focus) and Alt+Shift+A (focus dialog) hotkeys ignored the existence of the "restore pages" dialog and probably also similar ones. This dialog is outside the views hierarchy but it's anchored to the AppMenuButton, so we can get it through the kAnchoredDialogKey property. This will also work with other kinds of dialogs that may be anchored there. BrowserView::ActivateFirstInactiveBubbleForAccessibility() has been created so the callbacks for both hotkeys can use it. Bug: 1042010 Change-Id: I9befe07d92847279726d8f51d5f5fa9e0a6e5cf6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055624 Commit-Queue: Jacobo Aragunde Pérez <jaragunde@igalia.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#750402}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/acd3faab763a..7146ea83c0c4 git log acd3faab763a..7146ea83c0c4 --date=short --first-parent --format='%ad %ae %s' 2020-03-14 lalitm@google.com Merge "tp: refactor JSON code to remove ifdefs, consolidate ingestion into args" Created with: gclient setdep -r src/third_party/perfetto@7146ea83c0c4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I4ad9f910804401005f9eb142130fe37d9258d93d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104009Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#750401}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/f22fed0345ad..1b512b2a65c5 git log f22fed0345ad..1b512b2a65c5 --date=short --first-parent --format='%ad %ae %s' 2020-03-14 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@1b512b2a65c5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I53907df269c0bcb8adff41ce6c6539a32bb01c62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104007Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#750400}
-
Frédéric Wang authored
This CL exposes italic correction from the OpenType MATH table, for individual glyphs [1] and for glyph assemblies [2]. These will be used by the StretchyOperatorShaper to expose italic correction of stretchy operators and then will be used for MathML layout. [1] https://docs.microsoft.com/en-us/typography/opentype/spec/math#mathglyphinfo-table [2] https://docs.microsoft.com/en-us/typography/opentype/spec/math#glyphassembly-table Bug: 6606 Change-Id: I280aa404632683867b73e1682a5aa051ce682fbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100940 Commit-Queue: Frédéric Wang <fwang@igalia.com> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#750399}
-
Thomas Tellier authored
Change-Id: I884973176ee99a5c622cdb787f08e49e934e5057 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102536Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Thomas Tellier <tellier@google.com> Cr-Commit-Position: refs/heads/master@{#750398}
-
chromium-autoroll authored
Roll broadwell AFDO profile from 82-4044.31-1583749230-benchmark-82.0.4082.0-r1 to 82-4044.31-1583749230-benchmark-82.0.4084.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-broadwell-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: If494f79de43b634145ad580272421991f28c23f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103406Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#750397}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 3bdff94d. With Chromium commits locally applied on WPT: d5cd6b98 "SharedWorker: Assign unique names to SharedWorkers to avoid unintentional matching" acf33020 "Add testing for the scrolling attribute" 79933afe "Reland "[ScrollTimeline] Support composited scroll-linked Web Animation"" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ie85a6995bc63f0583bb8e6fb9c714e147e5c04f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102515Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#750396}
-
Chromium WPT Sync authored
Using wpt-import in Chromium eb657d93. With Chromium commits locally applied on WPT: d5cd6b98 "SharedWorker: Assign unique names to SharedWorkers to avoid unintentional matching" acf33020 "Add testing for the scrolling attribute" 79933afe "Reland "[ScrollTimeline] Support composited scroll-linked Web Animation"" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools jsbell@chromium.org: external/wpt/resources NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ib020836e7358755de282560f413f720fab6ef2f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103463Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#750395}
-
Sergey Ulanov authored
1. Added FuchsiaAudioCapturerSource that implements AudioCapturerSource on top of fuchsia::media::AudioCapturer. 2. Added FuchsiaAudioDeviceFactory to create FuchsiaAudioCapturerSource instead of AudioInputDevice. 3. Updated RendererMainPlatformDelegate to create FuchsiaAudioDeviceFactory on Fuchsia. 4. Added RequestMediaAccessPermission() implementation in FrameImpl. Bug: 1047390 Change-Id: Ia9164cc189f58c11ad15f454793efd533fbab96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071042 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#750394}
-
Toni Barzic authored
Back gesture nudge would check whether the back nudge can be shown on session change, or tablet mode change, and if that wasn't the case, it would stop monitoring window changes. This way, if back nudge was not shown initially, it would not get shown again unless tablet mode or session state change, even if sufficient time to make the back nudge available passed. This cl updates the logic to schedule a delayed task to reevaluate whether window monitoring should start if the nudge is not shown initially. The task delay is provided by the contextual_tooltip::ShouldShowNudge, and it indicates when the nudge is expected to be showable again. BUG=1061556 Change-Id: I4b961d1b6272903cb379086e9557886bd6239e5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103509 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#750393}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/04cb5c48dbb3..f22fed0345ad git log 04cb5c48dbb3..f22fed0345ad --date=short --first-parent --format='%ad %ae %s' 2020-03-14 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@f22fed0345ad If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I8614bda441bbe581fac4b7736d7da87cbf2814d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103855Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#750392}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/459c2f930fbb..463c39490599 git log 459c2f930fbb..463c39490599 --date=short --first-parent --format='%ad %ae %s' 2020-03-13 enga@chromium.org Slab-allocate OpenGL bind groups 2020-03-13 enga@chromium.org Slab-allocate frontend D3D12 bind groups 2020-03-13 enga@chromium.org Slab-allocate frontend Vulkan bind groups Created with: gclient setdep -r src/third_party/dawn@463c39490599 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: Ib17e4b81a6a6171eaf8635ed4dc0b5ea13ea0d5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103854Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#750391}
-
Mike Dougherty authored
In order to support testing of these breadcrumbs, extend FakeInfobarIOS to be created with a custom delegate FakeInfobarDelegate. FakeInfobarDelegate is also extended to support initialization with a custom infobar identifier. Bug: 1059110 Change-Id: Ib936f6103f2289e97c72be9ab9935697ebd66cdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095213 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#750390}
-
Oksana Zhuravlova authored
Example of failing build: https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%281%29/100727 TBR=jbudorick@chromium.org Bug: 1061624 Change-Id: I409c682f7e8314fa897d98c2d80ce6e415cc362a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103611Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#750389}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/41b7ff99df43..04cb5c48dbb3 git log 41b7ff99df43..04cb5c48dbb3 --date=short --first-parent --format='%ad %ae %s' 2020-03-14 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@04cb5c48dbb3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I214d6acbf899877d19b8e1ad4c7e57aa4babf240 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103848Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#750388}
-