- 14 Feb, 2020 40 commits
-
-
Peter Boström authored
This fixes a bug when ShrinkDownThenClearText() is used by ToolbarButton as the label-side insets need to be cleared when the text goes away. There may be other root causes for layout issues in the linked bug, but this fixes at least one layout problem. I haven't been able to reproduce the second reliably. Possibly because my window manager is weird. Bug: chromium:1045013 Change-Id: Ia0191754673d3bd545af61145f7cc4ac0d6f3a0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055432 Commit-Queue: Peter Boström <pbos@chromium.org> Commit-Queue: Taylor Bergquist <tbergquist@chromium.org> Auto-Submit: Peter Boström <pbos@chromium.org> Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#741306}
-
Darwin Huang authored
Mechanical find/replace from "Trace(blink::Visitor*" to "Trace(Visitor*". Refactoring change only. No functional changes intended. Bug: 1051193 Change-Id: If666c97e208838a2b53483cbe3f7319ce66a9f3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055687Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#741305}
-
Wanming Lin authored
NDEFRecordInit#data for smart-poster record contains more than one uri record should throw TypeError. BUG=520391 Change-Id: I5d876f7cdf0f6a847412b34ce06b50a922138874 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053985 Commit-Queue: Wanming Lin <wanming.lin@intel.com> Reviewed-by:
Leon Han <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#741304}
-
Nicholas Verne authored
The upgrade flow progress bar is now indeterminate (we don't have a good way of measuring progress.) The act of canceling the RESTORE phase leads to the ERROR state now (because RESTORE is only offered after an upgrade error). Bug: 1024693 Change-Id: I92bcecc44c075499ea17a9daa8cc45f8d3673aec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050291Reviewed-by:
David Munro <davidmunro@google.com> Commit-Queue: Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#741303}
-
Alex Newcomer authored
Move ownership of the metrics reporter up, so it outlives the HotseatWidget. TBR=mpearson@chromium.org,manucornet@chromium.org Bug: 1049385 Change-Id: Ic06978898ce022cac54de2b94e42e825e3e5c4dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055738 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#741302}
-
Dominic Mazzoni authored
Previous work added support for exporting a tagged PDF, but only enabled it to work from the command-line using headless. This change enables the --export-tagged-pdf command-line switch to work when using Chrome's Print dialog on desktop platforms. The important changes are: * In PrintRenderFrameHelper, AXTreeSnapshotter needs to be alive throughout the duration of printing, in order to ensure that the document is printed with the extra node ID annotations and to ensure that the IDs match the ones from the accessibility tree snapshot. * The accessibility tree snapshot needs to be sent to PdfCompositorImpl. Because finishing the PDF document happens immediately upon receiving the final page, we can't wait until after finishing before sending it - so I added this code to send the tree before the first page. I excluded some of the code from compilation on Android to ensure the binary size doesn't grow. There are no plans to enable this feature on Android currently. Bug: 607777 Change-Id: Ie0b16a224cc02a719b07b257b01a8d7b67889746 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1996158 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#741301}
-
Eric Willigers authored
WebAppBrowserController::GetTitle() uses the web app's short name when the custom tab bar is being shown. .../extensions/hosted_app_browsertest.cc no longer contains any web app browser tests - they have all been moved to .../web_applications/... Bug: 966290 Change-Id: I699b28db635647541823e798dc90ff2ff7bcf9c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050286 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#741300}
-
James Cook authored
PrivetNotificationService uses IdentityManager::HasPrimaryAccount to detect if a Profile is for a signed-in user. However, that method returns false if the user has not consented to browser sync. Historically all Chrome OS users were consented to browser sync, but the SplitSettingsSync project is making it possible for users to opt-out. Change the call site to the new API, indicating that browser sync consent is not required. The updated call returns true for any signed-in user. See go/cros-primary-account and go/consent-aware-api-dd Also fix the startup delay timing, which was trying to generate a TimeDelta between 0 and 1.25 seconds, but always chose exactly 0 or exactly 1. Bug: 349098, 1042400, 1046746 Test: added to unit_tests Change-Id: Ic7484428cd718937173d5097e57672d74c8db614 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055963Reviewed-by:
-
Asanka Herath authored
`scripts/utilities.py`'s `write_file()` did not handle the case where the file being written is in the current directory. Bug: None Change-Id: I3bb294aa1c45ed3caed9153e2cbb6e73d151391c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055424 Auto-Submit: Asanka Herath <asanka@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#741298}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/ca1907e58b82..86fbe04c6633 git log ca1907e58b82..86fbe04c6633 --date=short --first-parent --format='%ad %ae %s' 2020-02-13 yiwzhang@google.com Roll bb tool to @ 1ab4441 Created with: gclient setdep -r src/third_party/depot_tools@86fbe04c6633 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1039823 Tbr: agable@chromium.org Change-Id: I0f06158afd50f4df51df145a4cc749de767b9573 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055770Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#741297}
-
Kurt Horimoto authored
The previous implementation of InfobarOverlayRequestInserter and InfobarOverlayRequestFactoryImpl crashed if an unsupported infobar overlay was requested. This ultimately should be the case, as it helps future users of these classes to remember to add the request factory. However, when there are infobars that haven't been converted yet, this requirement makes debugging difficult becuase the app crashes when the session restoration infobar is added. This CL replaces this crash behavior with early returns to make debugging easier before the remaining infobars are converted. Bug: 1030357 Change-Id: I68ef5b758444e65b0985d970c92de0bf935785cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041032 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#741296}
-
Manu Cornet authored
Bug: 1044306, 1052077 Change-Id: I0471dfbfa622162015432617e5449853bb0c65f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055586 Commit-Queue: Manu Cornet <manucornet@chromium.org> Reviewed-by:
-
Kurt Horimoto authored
When an InfoBar is removed from its InfoBarManager while an OverlayRequest is in a queue, that request is cancelled, which triggers an animated dismissal of the UI. However, by the time the UI is finished being dismissed, the InfoBar object has already been destroyed. This CL updates InfobarOverlayRequestConfig to hold a weak pointer to the InfoBar to prevent the destroyed infobar from being used after destruction. It also updates all callbacks to early return if the request's InfoBar has already been destroyed. Bug: 1030357 Change-Id: I66adbed780f6472c562eb2164193b8836da66670 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040953 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
-
Istiaque Ahmed authored
VerifierObserver previously exposed completed_fetches(), which is only used to ensure we wait for OnFetchComplete of a particular extension. This CL unifies those methods into EnsureFetchCompleted, which would wait for OnFetchComplete if we haven't seen it for an extension. Bug: 796395 Change-Id: Iffd23fa52df7a656ff453ac92829137283afe35a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044413 Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Oleg Davydov <burunduk@chromium.org> Cr-Commit-Position: refs/heads/master@{#741293}
-
Max Moroz authored
- Move the FDP section upper in the page, as the class became even more helpful and widely used, plus we had feedback about its documentation in Chromium. - Remove the section about manually splitting the fuzz input into pieces, as FDP is a better and less error-prone way to do it. - Clarify upsides and downsides of FDP and hash-based argument solutions. Bug: 539572 Change-Id: I8a0d46008d36bf6a8f8df8007664411b3f32d4b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051298Reviewed-by:
Abhishek Arya <inferno@chromium.org> Commit-Queue: Abhishek Arya <inferno@chromium.org> Cr-Commit-Position: refs/heads/master@{#741292}
-
Daniel Hosseinian authored
Bug: 477699 Change-Id: I7377c6693f49232206b061c5cc1d9c9e80717a55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055845 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#741291}
-
Alex Danilo authored
Bug: 992823 Change-Id: I7a220f111fbd0ee624efc6fd450f9f1cb5eff15b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053646 Commit-Queue: Alex Danilo <adanilo@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#741290}
-
Carlos IL authored
Setting this to default on in preparation for launch, also change default behavior to exclude images since that is the mode launching in 80. Bug: 1025274 Change-Id: I6689b4fa90a345e4e6ecc193790757a11e54c6aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052250 Auto-Submit: Carlos IL <carlosil@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#741289}
-
David Munro authored
Test: Load page, check for no errors in console Bug: None Change-Id: I5a83a112f742d5b86af941aa661df8dc5fcd0bc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054626 Commit-Queue: David Munro <davidmunro@google.com> Commit-Queue: Julian Watson <juwa@google.com> Auto-Submit: David Munro <davidmunro@google.com> Reviewed-by:
Julian Watson <juwa@google.com> Cr-Commit-Position: refs/heads/master@{#741288}
-
Richard Townsend authored
MSVC's support for Arm intrinsics is incomplete. To restore the build and make sure MSVC-compiled downstream projects can compile V8 for Windows on Arm, temporarily disable these optimizations until we can fix them or MSVC improves. Bug: v8:10012 Change-Id: Iaa599aa20ace167e0fcc2a2472e97e7f2ac53773 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054884 Commit-Queue: Adenilson Cavalcanti <cavalcantii@chromium.org> Reviewed-by:
Adenilson Cavalcanti <cavalcantii@chromium.org> Reviewed-by:
Chris Blume <cblume@chromium.org> Cr-Commit-Position: refs/heads/master@{#741287}
-
Chromium WPT Sync authored
Using wpt-import in Chromium e71d7d88. With Chromium commits locally applied on WPT: acd8a467 "SharedWorker: Use CSP headers to outside settings" ec83d167 "Update performance.measureMemory to the latest proposal" ce4a5462 "[css-scroll-anchoring] Add WPT for zero scroll offset suppression." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: binji@chromium.org: external/wpt/wasm drott@chromium.org: external/wpt/css/css-text-decor foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools hbos@chromium.org, hta@chromium.org: external/wpt/webrtc hongchan@chromium.org, rtoy@chromium.org: external/wpt/webaudio jsbell@chromium.org: external/wpt/IndexedDB external/wpt/resources ksakamoto@chromium.org, npm@chromium.org: external/wpt/resource-timing mkwst@chromium.org: external/wpt/secure-contexts external/wpt/trusted-types mkwst@chromium.org, andypaicu@chromium.org: external/wpt/content-security-policy panicker@chromium.org: external/wpt/user-timing yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ida26cb93d2ffd34309caf08890c823feed90147b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055704Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#741286}
-
Dominic Mazzoni authored
I made these categories of histograms expire never, for now (understanding that this may be done automatically at some point): * Core histograms that track usage of an important accessibility feature * Histograms that track a system setting that's important for accessibility In both of those cases, we look at long-term trends of those histograms to see how usage is growing and to determine how many users might be affected by potential changes. We shouldn't let those expire. I left alone any accessibility histograms that are tied to a smaller option or experiment. Many of those should expire after a while. Bug: 1045994, 1045992, 1041514, 1036908, 1036905, 1036904, 1036902, 1006995 Change-Id: I2104ebf2df81f0ac4d090f87ea2dfca06ad4c92d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036484Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Katie Dektar <katie@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#741285}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e3ebc4f9..4deaf25c Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ibc7c56472829512d29736ffe1abe036fc3c80e6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054567Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#741284}
-
Collin Baker authored
Bug: 1043374 Change-Id: I02be554b2346ff53b226fc783db565e3e02c37bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2045031 Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#741283}
-
Olivier Li authored
There is nothing wrong with having coverage in those files but for some reason my crrev.com/2046404 change that includes them breaks angle_unittests by making code coverage tooling add some output to stderr of one of their binaries. Until the problem of the stderr output is resolved I need a way to pass CQ. Here I'm adding the files I think are causing the problem to see if my cl will pass CQ after. Bug: 1051561 Change-Id: I14c4b195bda151bbddc57fdd573b2c93c2a59b63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054527 Commit-Queue: Oliver Li <olivierli@chromium.org> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#741282}
-
Eric Willigers authored
The HostedAppPWAOnlyTestWithAutoupgradesDisabled tests have been moved to PWAMixedContentBrowserTestWithAutoupgradesDisabled as they no longer depended on the extensions-based implementation. Note that the HostedAppTestWithAutoupgradesDisabled and HostedAppPWAOnlyTestWithAutoupgradesDisabled tests in hosted_app_browsertest.cc have not been run recently, as there was no INSTANTIATE_TEST_SUITE_P entry for these tests. Some mixed content now loads with warnings (due to security changes that occurred while the tests were not enabled). Previously landed as https://chromium-review.googlesource.com/c/chromium/src/+/2049407 and reverted due to linux-chromeos-chrome failures. Bug: 1026808 Change-Id: I4328328da72001d9005abe3792d8a30e02d684b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054604 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/04a7136fd704..6a950951c780 Created with: gclient setdep -r src-internal@6a950951c780 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1044252 Tbr: jbudorick@google.com Change-Id: Ic27f3c35aae0fd86baee534a9b092e1dbb8ba23f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055768Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#741280}
-
Austin Tankiang authored
ThumbnailLoader generates thumbnails for drive files from the file if the file is cached locally. Bug: 1043068 Change-Id: Ib8f3f795923316fff37cdef7eebf3004c5b3e43a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049409Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Austin Tankiang <austinct@chromium.org> Cr-Commit-Position: refs/heads/master@{#741279}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/e90568eeef90..f9f999f5a2eb git log e90568eeef90..f9f999f5a2eb --date=short --first-parent --format='%ad %ae %s' 2020-02-13 jonahr@google.com Implement HostMappedForeignMemory DeviceMemory Created with: gclient setdep -r src/third_party/swiftshader@f9f999f5a2eb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1965434 Tbr: swiftshader-team+autoroll@google.com Change-Id: I5f8df80eb8b139a1de7991252541a3f0ddeae517 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055493Reviewed-by:
-
Kent Tamura authored
According to https://html.spec.whatwg.org/C/#face-submission-value, the initial value should be null, not an empty string. Bug: 1051292 Bug: https://github.com/whatwg/html/issues/5263 Change-Id: Ifa92aaca47bfce1e51aa0fd3dc9ebb9ab9b15d91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050148Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#741277}
-
Eugene But authored
Metadata in additional information which can help to find steps to reproduce the crash. This CL adds the following metadata: For DidStartNavigation event: - navigation-id (this allows to match corresponding DidFinishNavigation, which has different set of metadata) - #ntp (this allows to ignore noise like Opening NTP Tab, but still keep useful information like going back to NTP) - #renderer-user (indicates that user interacted with the page causing a navigation) - #renderer-script (indicates client side redirect) For DidFinishNavigation event: - navigation-id (this allows to match corresponding DidStartNavigation, which has different set of metadata) - #download (indicates download navigation) For PageLoaded event: - #ntp (this allows to ignore noise like Opening NTP Tab, but still keep useful information like going back to NTP) - #success/#failure (converted existing ": Success"/": Failure" strings for consistency) Bug: 1046223 Change-Id: I0f5586ab182d81c6157ad2a40180200e4ee82c37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2045205 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Auto-Submit: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#741276}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/b28e57e72580..0618cbc98994 git log b28e57e72580..0618cbc98994 --date=short --first-parent --format='%ad %ae %s' 2020-02-13 peah@webrtc.org AEC3: Avoid heap-allocations in sums of the values in nested vectors 2020-02-13 philipel@webrtc.org Added java interface VideoEncoderFactory.VideoEncoderSelector and implemented VideoEncoderSelectorWrapper. 2020-02-13 kthelgason@webrtc.org Update RTCEncodedImage to not use deprecated mutable_data call. 2020-02-13 oseg@google.com Use webrtc::DataRate when referring to bitrates 2020-02-13 minyue@webrtc.org Add AbsoluteCaptureTimeReceiver to audio ChannelReceive. 2020-02-13 sprang@webrtc.org Refactors UlpFec and FlexFec to use a common interface. 2020-02-13 alessiob@webrtc.org iSAC unit test: test encode/decode via API wrapper 2020-02-13 alessiob@webrtc.org iSAC fixed point: fix int overflows 2020-02-13 kron@webrtc.org Populate sdp_fmtp_line and channels of RTCCodecStats Created with: gclient setdep -r src/third_party/webrtc@0618cbc98994 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1052086 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ieb593888521ca005aef66414b5b2166888ecec9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055375Reviewed-by:
-
Brian Ho authored
This CL hooks up all of the previous work on Ozone-based SharedImages with the WebGPU pipeline by setting the interop factory to SharedImageBackingFactoryOzone on Chrome OS. The only valid usage right now is for shared images to be used with WebGPU and GLRenderer as only ProduceDawn and ProduceGLTexture are implemented in the shared image. Bug: 1023997,996470 Change-Id: I95f27e9b9d161aeb198839f316917a6e1eb48a83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912831Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Brian Ho <hob@chromium.org> Cr-Commit-Position: refs/heads/master@{#741274}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/55f040bcb943..475def0059a2 git log 55f040bcb943..475def0059a2 --date=short --first-parent --format='%ad %ae %s' 2020-02-13 bryct@amazon.com Update Skia build instructions in build.md 2020-02-13 fmalita@chromium.org Undo suspect gn format 2020-02-13 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2020-02-13 mtklein@google.com move clamp until just before store 2020-02-13 mtklein@google.com skvm support for 888x, 1010102, 101010x 2020-02-13 egdaniel@google.com Remove all remaining uses of origin getter on proxy. 2020-02-13 benjaminwagner@google.com [infra] Pin iOS tasks to old libimobiledevice 2020-02-13 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2020-02-13 robertphillips@google.com Revert "Carve some helper functions off of GPUSink" 2020-02-13 egdaniel@google.com Store render target dirty msaa rect in real dst space. 2020-02-13 kjlubick@google.com Remove chromecast jobs 2020-02-13 robertphillips@google.com Carve some helper functions off of GPUSink 2020-02-13 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2020-02-13 robertphillips@google.com Add createBackendFormat and createFBO0 helper methods to SkSurfaceCharacterization 2020-02-13 fmalita@chromium.org [skottie] Refactor keyframe encoding 2020-02-13 bsalomon@google.com Update texel_subset_* GMs. 2020-02-13 robertphillips@google.com Add makeNotCurrent to TestContext 2020-02-13 reed@google.com threshold rtshader 2020-02-13 mtklein@google.com more sophisticated opacity in SkImageShader 2020-02-13 mtklein@google.com relax asserts to what we'd clamp to 2020-02-13 mtklein@google.com extend opacity tests in SkVM blits 2020-02-13 brianosman@google.com Harden runtime shader/colorfilter CreateProc against bad child counts 2020-02-13 bungeman@google.com Skip degenerate contours in glyphs. 2020-02-13 mtklein@google.com more MSAN dbg->rel cycling Created with: gclient setdep -r src/third_party/skia@475def0059a2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC stani@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: stani@google.com Change-Id: I1b0cf5a13907290ad4abb2eacbb24b057d1011db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055374Reviewed-by:
-
Xing Liu authored
Download.InterruptedReason is a core metric used in download dashboard. Bug: 1037486 Change-Id: If33a8802509561607c1e84be4e5094ec35f45cac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048910Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#741272}
-
Tao Bai authored
This make the DEPS clear. Bug: 1042048 Change-Id: Ia66d2158080f9f63856adb1dca583733a9d246b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055594Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Tao Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#741271}
-
Anand K. Mistry authored
Changes: - Update to new-style MOCK_METHOD - Add constants for active directory auth - Remove unused test fixture member variables - Rename kMountPath to the more appropriate kShareUrl This is to prepare for additional unit tests for mounting using SmbFs. Bug: 939235 Change-Id: I848ca10e04ed9646faa6f1df9b8b62eaeb1636be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055904Reviewed-by:
-
nancy authored
This is the follow up based on CL:2050217 review comments. BUG=1051066 Change-Id: I22011a7bfded29ad0b976a648a8429be40484ebb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053664Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#741269}
-
Piotr Bialecki authored
Mostly mechanical change: - move maps that track plane state to a separate ArCorePlaneManager class - make some of the helpers shared between arcore_impl.cc and arcore_plane_manager.cc (scoped arcore objects, conversions from ARCore entities to mojo for cases where ArSession* is needed) - instead of passing mojo's `const TypePtr&` around, pass `const Type&` Step 1/N - preparing from creating anchors from hit test results since plane state will need to be tracked independently from plane detection feature - hit test feature will also need to be aware of the planes. Change-Id: Ic4cc008ce4466e85fe65b3901a4848ebb03d6dc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055587Reviewed-by:
Klaus Weidner <klausw@chromium.org> Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#741268}
-
Manu Cornet authored
Bug: 1050383c Change-Id: I3f6e1478366ec772d751c2cc6cd967a8b66ba9a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055804 Commit-Queue: Manu Cornet <manucornet@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
-
