- 25 Aug, 2018 40 commits
-
-
Alexey Kozyatinskiy authored
R=lushnikov@chromium.org Bug: chromium:646849 Change-Id: I8141bcdcfef7d9734ee9f1c97bfa552160fdcd9d Reviewed-on: https://chromium-review.googlesource.com/1182865 Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#586149}
-
Alexey Kozyatinskiy authored
Blackbox manager may update location that we show for console message when top frame is blackboxed / unblackboxed. R=luoe@chromium.org Bug: chromium:873789 Change-Id: I8500d07877dfa6f08b57ccfb7236ad44e124137a Reviewed-on: https://chromium-review.googlesource.com/1183682Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/8f582e98..0093536e Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I1a2091733637a84c9ebba2ba05698ba6d2fe084a Reviewed-on: https://chromium-review.googlesource.com/1188693Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#586147}
-
Wez authored
- Fix AXPlatformUniqueIdTest.TestIdsNotReused, which made invalid assumptions about the specific identifier values that would be assigned. - Remove unused AXPlatformUniqueIdTest base-class. - Renamed both AXPlatformUniqueIdTests to better reflect their purpose. TBR: aleventhal Bug: 877777, 797992 Change-Id: I0f86092e4e785843522913fa98b0222e04dbd67d Reviewed-on: https://chromium-review.googlesource.com/1188698Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#586146}
-
Ned Nguyen authored
Change-Id: I401964008d178401c1066dc7968944ecbfee2bbe TBR=mythria@chromium.org Change-Id: I401964008d178401c1066dc7968944ecbfee2bbe Reviewed-on: https://chromium-review.googlesource.com/1184971Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#586145}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/95be425f5b30..305498942654 git log 95be425f5b30..305498942654 --date=short --no-merges --format='%ad %ae %s' 2018-08-25 reed@google.com do reject vertical lines if they are outside of the clip Created with: gclient setdep -r src/third_party/skia@305498942654 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=fmalita@chromium.org Change-Id: I50ce9ceae5c85ae5e65e63834ebb71f4a2e05220 Reviewed-on: https://chromium-review.googlesource.com/1189035Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#586144}
-
Sadrul Habib Chowdhury authored
crrev.com/562737 made a change to update the surface-layer with the appropriate primary/fallback surfaces (and bounds) during surface activation. This was to improve performance with surface-sync. However, this ended up triggering a regression in the input pipeline (see linked bugs). So, update the code so that when surface-sync is not used, the surface-layer is destroyed during eviction, and recreated as needed. BUG=867581 Change-Id: I0c07f5782c06de171bec131014b66eab9a09b879 Reviewed-on: https://chromium-review.googlesource.com/1187277 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#586143}
-
Ravi Mistry authored
This is a temporary workaround till we figure out a better way to do it. TBR=agrieve@chromium.org Bug: chromium:787005 Bug: skia:8284 Change-Id: Ibc30bf17a22d4fcca31dab20addfd36b6a14f596 Reviewed-on: https://chromium-review.googlesource.com/1189187 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
Ravi Mistry <rmistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#586142}
-
Kurt Horimoto authored
Only one browser UI is shown at a time, so a single FullscreenController is needed for both the normal and incognito BrowserStates. Bug: none Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ic08edb4a6c622a8dbeefc4ce02afbb35dbca9f0d Reviewed-on: https://chromium-review.googlesource.com/1184163 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#586141}
-
Kushagra Sinha authored
Add a submenu for Chrome OS Account Manager in the People section of Settings. This will link to the Chrome OS Account Manager Settings subpage. This will be visible only if the Chrome OS Account Manager feature is enabled. Bug: 833797 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Id9e6a339ef16db6dbd14a6827df6fdf02c66d913 Reviewed-on: https://chromium-review.googlesource.com/1186584Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#586140}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/8dabf7bda37f..cd12ac0efdbd git log 8dabf7bda37f..cd12ac0efdbd --date=short --no-merges --format='%ad %ae %s' 2018-08-25 vapier@chromium.org cros_run_unit_tests: run unittests for common.mk packages Created with: gclient setdep -r src/third_party/chromite@cd12ac0efdbd The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I64f2c084c399e94ddd269bb1263cf4e29c98f90d Reviewed-on: https://chromium-review.googlesource.com/1189343Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#586139}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 3cef5025. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/23279 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lukebjerring No-Export: true Change-Id: I2b9d055130eb28143f219d445e059ad713d3b447 Reviewed-on: https://chromium-review.googlesource.com/1188831 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#586138}
-
Miguel Casas authored
- s/arraysize/base::size/ (see crbug.com/837308#c15 for decltype trick). - s/base::bind/base::BindRepeating/ (and s/Closure/RepeatingClosure/). Bug: 876810, 837308 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I0068d55985c5c4fdcf1ed987e278f402fd0e6ac0 Reviewed-on: https://chromium-review.googlesource.com/1189103Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#586137}
-
Koji Ishii authored
NGColumnLayoutAlgorithm produces a fragment for the multi- column container, then fragments for column bxoes, and flow the content into the column boxes. In the current implementation, the multi-column container and the column boxes have the same LayoutBlockFlow and that we have some places we need to handle the column containers differently. With this patch, such fragments have kColumnBox box type so that they are explicitly distinguishable. Bug: 714962 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Iefb7c5ac0c5869bf30b053f435a3408403d2e9f9 Reviewed-on: https://chromium-review.googlesource.com/1175588Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#586136}
-
Alexander Alekseev authored
TBR=jdufault@chromium.org Bug: 864679 Change-Id: I2b28552eff792cceae30c18d93bf1a094af18949 Reviewed-on: https://chromium-review.googlesource.com/1188424 Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#586135}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/7b7eb8800be0..2d0e03cb5ddc git log 7b7eb8800be0..2d0e03cb5ddc --date=short --no-merges --format='%ad %ae %s' 2018-08-25 tandrii@chromium.org git cl: safe fallback for Gerrit RPCs even if gerrit project is unknown. Created with: gclient setdep -r src/third_party/depot_tools@2d0e03cb5ddc The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:876910 TBR=agable@chromium.org Change-Id: Iea89e24017951b3d180ff3f0c710b59b8d0efd49 Reviewed-on: https://chromium-review.googlesource.com/1188937Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#586134}
-
Alexander Alekseev authored
Bug: 862852 Change-Id: I045023abf2a303f9ee0f08afc340ccbac9929a55 Reviewed-on: https://chromium-review.googlesource.com/1188485 Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#586133}
-
Calder Kitagawa authored
This is phase 4 of the work to update the WebShareTarget spec. This CL removes the old style url_template. All clients only use the new action and parameter based model. Bug: 871788 Change-Id: I0c4b3a20a4afa0d1b24bde7f52941d399ac7048e Reviewed-on: https://chromium-review.googlesource.com/1185847Reviewed-by:
Xi Han <hanxi@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#586132}
-
Findit authored
This reverts commit a0f6eb42. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 586121 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2EwZjZlYjQyY2FkYTk4NDZmYjQ0ZTA0MzkyMTcwZGRiOWM1YzQ4ODgM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-dbg/7482 Sample Failed Step: unit_tests Original change's description: > Allow to use ARC IMEs only in tablet mode. > > This CL also changes InputMethodManagerImpl and language settings api to > allow ArcInputMethodManagerService to restrict ARC IMEs. > > Bug: 845079 > Test: Ran on DUT and unit tests. > Change-Id: I61516b3c6a65775f42aae7e51583e933d55ab1b6 > Reviewed-on: https://chromium-review.googlesource.com/1179733 > Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> > Reviewed-by: Yusuke Sato <yusukes@chromium.org> > Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> > Cr-Commit-Position: refs/heads/master@{#586121} Change-Id: I8d75017944b0b048af795e4826d5ec5fb0a7256e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 845079 Reviewed-on: https://chromium-review.googlesource.com/1188826 Cr-Commit-Position: refs/heads/master@{#586131}
-
Niels Möller authored
The latter class is from webrtc/api/test, hence publicly advertised by webrtc, while the former is unused in webrtc and likely to be deleted, see https://webrtc-review.googlesource.com/c/src/+/95421 Bug: None Change-Id: I5843bf26c64cdac7f3b30a9c631ea81e15ab1a89 Reviewed-on: https://chromium-review.googlesource.com/1186322 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#586130}
-
Daniel Cheng authored
The nonce allows a unique origin to be same origin with itself, as well as copies of itself. blink::SecurityOrigin and IPC are not yet updated to propagate the necessary information through all the layers. Bug: 768460 Change-Id: I1bfce592f3fa576dff18eb7fe2071742e82d1768 Reviewed-on: https://chromium-review.googlesource.com/745986 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Nick Carter <nick@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#586129}
-
Noel Gordon authored
Fix CL:1188178 landed. Re-enable renameNewFolderDownloads test. Tbr: lucmult Bug: 877557 Change-Id: I45ccfa03001f1622aab4fd07abde224ccef45ef0 Reviewed-on: https://chromium-review.googlesource.com/1189322Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#586128}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/1e5937821868..95be425f5b30 git log 1e5937821868..95be425f5b30 --date=short --no-merges --format='%ad %ae %s' 2018-08-25 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 337bd6984078..8707af516c46 (1 commits) Created with: gclient setdep -r src/third_party/skia@95be425f5b30 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=fmalita@chromium.org Change-Id: I16b63d892da1b5633be6eacf1bb1cfa5effae972 Reviewed-on: https://chromium-review.googlesource.com/1189094Reviewed-by:
-
Koji Ishii authored
Following bot results are included. 9001 9002 9003 9006 9019 9021 9025 9027 9032 9039 9045 9049 9051 9055 9057 9063 9067 9070 9079 9081 9086 9091 9097 9099 9102 9107 9110 9115 9117 9119 9123 9126 9131 9134 9141 9145 9149 9151 7 lines were removed and 132 lines were deflaked by consecutive results since 9110. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I6a37ca3a23cd143c6c0071eece3b9af83f34fb41 Reviewed-on: https://chromium-review.googlesource.com/1181011 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#586126}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/e6ff2ebfaa19..441ef218c20b git log e6ff2ebfaa19..441ef218c20b --date=short --no-merges --format='%ad %ae %s' 2018-08-25 npm@chromium.org More cleanup in CPDF_TextPage Created with: gclient setdep -r src/third_party/pdfium@441ef218c20b The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ic4591d21d07f9446aa57f6934ca7a2c50c87ef72 Reviewed-on: https://chromium-review.googlesource.com/1189093Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#586125}
-
Eugene But authored
This change only affects SlimNavigationManager. SlimNavigationManager uses pushState JS API for restoring the session. WKWebView does not allow pushing more than 100 items per 30 seconds. Limiting max session size to 75 will allow web pages to use push state calls. Bug: 877671 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ia16c4bc88f3b42b638b895daef542cf8e086c33f Reviewed-on: https://chromium-review.googlesource.com/1187551 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#586124}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/92bc476c8c49..1e5937821868 git log 92bc476c8c49..1e5937821868 --date=short --no-merges --format='%ad %ae %s' 2018-08-25 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@1e5937821868 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=fmalita@chromium.org Change-Id: Iefc9d90c827a4cdc6fb539f850a1e8211ea50bc6 Reviewed-on: https://chromium-review.googlesource.com/1188938Reviewed-by:
-
Noel Gordon authored
Test is flaky on the slower bots MSAN/ASAN with selection failures. Add more steps, add step result checking. Use more precise selectors on the file list operations. Do an initial focus on the file list. Load photos only in SetUpAndWaitUntilReady (for more speed). Check that the renamed folder is shown in the directory tree and the file list. The new steps are cargo-culted from the create_new_folder.js test which is a similar test, with similar selection flakes (fixed on CL:1186008). Tbr: lucmult Bug: 874954,877557 Change-Id: Ib9f988e0dadafd0a52bd509ae664aa3cbfe395fb Reviewed-on: https://chromium-review.googlesource.com/1188178Reviewed-by:
-
Yuichiro Hanada authored
This CL also changes InputMethodManagerImpl and language settings api to allow ArcInputMethodManagerService to restrict ARC IMEs. Bug: 845079 Test: Ran on DUT and unit tests. Change-Id: I61516b3c6a65775f42aae7e51583e933d55ab1b6 Reviewed-on: https://chromium-review.googlesource.com/1179733Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#586121}
-
John Abd-El-Malek authored
TBR=cmumford@chromium.org Change-Id: I3126e1df73ffcf02f191ab3abc0ab0f5e1f26fe6 Reviewed-on: https://chromium-review.googlesource.com/1189172Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#586120}
-
Gabriel Charette authored
Reland "[RenderProcessHost/Desktop] Update process priority on process launch and fix navigation priority inversion" This is a reland of c492203d Reverted @ https://crrev.com/c/1188963 per the new test being flaky. I'm pretty sure it's just because 10us for the recurring check was too aggressive for that kernel and starved the test (which also explains why ASAN was flaking -- looking back it was a termination failure (timeout) not an ASAN failure -- so I've re-enabled both. Original change's description: > [RenderProcessHost/Desktop] Update process priority on process launch and fix navigation priority inversion > > This is a second take on > https://chromium-review.googlesource.com/c/chromium/src/+/754299 > > It's under an experiment to (1) be able to see the side-effects and (2) > make merge to M69 easier. Intentionally kept old (and buggy) behavior > intact under the non-experimental branch for comparison. > > This fixes all aspects of crbug.com/560446: > 1) Fixes the OP better than r385608 did. > 2) Fixes the side-effect of r385608 which was to default all tabs > created backgrounded to run at foreground priority until visiblity > was toggle on/off again. > 3) Fixes a major priority inversion on foreground navigation which > could cause them to background their associated renderer while > navigation (which reintroduced the OP but worse since all background > tabs were running foregrounded per r385608)... > See https://crbug.com/560446#c74 for details. > > Updated ChildProcessLauncherPriority::is_background() to consistently > reflect backgrounding decision to all callers and renamed > |ChildProcessLauncherPriority::foreground| to > |ChildProcessLauncherPriority::visible| to better reflect that it's a > property but not the resulting foreground/background state. > > See in code comment on ShouldBoostPriorityForPendingViews() for more > details. > > TBR=haraken@chromium.org (side-effect in third_party/blink) > > Bug: 560446 > Change-Id: I901b702506a44704b53c007bcdd498fb60824e94 > Reviewed-on: https://chromium-review.googlesource.com/1142593 > Commit-Queue: Gabriel Charette <gab@chromium.org> > Reviewed-by: Nasko Oskov <nasko@chromium.org> > Reviewed-by: Lei Zhang <thestig@chromium.org> > Reviewed-by: Bo <boliu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#585918} TBR=nasko@chromium.org (trivial reland) Bug: 560446 Change-Id: Ib8daff024edabd488afda0b4b9da6f6e0fda77d4 Reviewed-on: https://chromium-review.googlesource.com/1189204Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#586119}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 1c9af66d. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/23257 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org: external/wpt/compat NOAUTOREVERT=true TBR=lukebjerring No-Export: true Change-Id: Ib6ca7496379ae8a349f7b15c08bccc2983cb24ff Reviewed-on: https://chromium-review.googlesource.com/1189167 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
-
Alexander Alekseev authored
This Cl updates Chrome OS Discover Welcome module code to match the latest specs. Bug: 864686 Change-Id: Icbfb4c98976055daaa49bce51e1eb399aa6da078 Reviewed-on: https://chromium-review.googlesource.com/1186188 Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by:
-
Dominik Laskowski authored
Bug: 877254 Test: gtk3-demo Test: exo_unittests Change-Id: Iec316067589088e85dec3429df4fe9f5a5604a65 Reviewed-on: https://chromium-review.googlesource.com/1188343Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Dominik Laskowski <domlaskowski@chromium.org> Cr-Commit-Position: refs/heads/master@{#586116}
-
Antonio Gomes authored
URLFetcher will stop working with advent of Network Service, and SimpleURLLoader is the replacement API for most clients. This CL migrates HttpBridge and FinancialPing away from URLFetcher. Note that this CL slightly changes the flow of the HttpBridge{Factory} code. Previously, an URLRequestContextGetter instance was acquired on UI thread, passed to the Sync and IO threads. However, URLLoaderFactory and SimpleURLLoader have stricter threading restrictions than URLFetcher and URLRequestContextGetter. For instance, a SharedURLLoaderFactory instance needs to be created, used and deleted on the same thread. For this reason methods like HttpBridgeFactory::OnSignalReceived can not simply null out |url_loader_factory_| which is created on the "sync" thread. Additionally, some preexisting tests do not seem relevant for the context of network service, and got removed, eg TestUsesSameHttpNetworkSession, RequestContextGetterReleaseOrder and EarlyAbortFactory. Particularly, the last two used to deal with URLRequestContextGetter destruction. With the URLLoader migration, HttpBridge now holds on to mojo pipes instead of URLRequestContextGetter. BUG=773295,844968 Change-Id: I185f814ba171dca69fec55b913b86a0cc9993ef1 Reviewed-on: https://chromium-review.googlesource.com/1174655 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:Nicolas Zea <zea@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#586115}
-
Victor Vasiliev authored
R=rch@chromium.org Change-Id: I1a89779519bc63ca669d0d9ba01a81fb2e9952e0 Reviewed-on: https://chromium-review.googlesource.com/1189102Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Victor Vasiliev <vasilvv@chromium.org> Cr-Commit-Position: refs/heads/master@{#586114}
-
Aaron Krajeski authored
Bug: 806581 Change-Id: I26467c5fc2c9fc9ecf918a5229a97650bd29a5e5 Reviewed-on: https://chromium-review.googlesource.com/1185370Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#586113}
-
Alexander Alekseev authored
This CL updates OOBE Discover code to make it loadable as an app. Bug: 864686 Change-Id: I1e9840041f193ce2d69e0defd34f2ab56f8dcbb1 Reviewed-on: https://chromium-review.googlesource.com/1186185 Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by:
-
Sadrul Habib Chowdhury authored
Report how long it takes to update the views hierarchy in response to a search-string. Also report how long it takes before the update is visible on screen. BUG=865295 Change-Id: I103aa5cbd86be3189ab44121e72d375e6d742b4b Reviewed-on: https://chromium-review.googlesource.com/1188755Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#586111}
-
Eugene But authored
This metric will help to diagnose possible URL spoofing bugs in Slim Navigation feature. _documentURL is used as proxy for legacy navigation manager URL, which is generally reliable and almost always match last committed URL. Collection review doc: https://docs.google.com/document/d/14SygQ8BzLkzedTLuDfOHhakQHZOOJSU8TAJT3rxBGv4/edit# Bug: 1182320 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I6dcf5711f0fd42063b67afb0fa0a99b77ce4c7a0 Reviewed-on: https://chromium-review.googlesource.com/1187014 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
-
