- 04 Sep, 2019 40 commits
-
-
Jan Krcal authored
This CL extends the latency metric for initial sync to all data types (previously, we recorded that only for types with ephemeral storage). Bug: 998501 Change-Id: If11f0969b74c699de8c6d9ae665932083379a806 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773147 Commit-Queue: Jesse Doherty <jwd@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Auto-Submit: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#693397}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Iebd8212bac32c3bc19df732845b300b07a8b987a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783916Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#693396}
-
dalyk authored
Now includes OpenDNS FamilyShield mapping. Bug: 985589 Change-Id: Ia526ddfb19eafe236c01c5f3b78b00b00c3c36f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784971Reviewed-by:
Eric Orth <ericorth@chromium.org> Commit-Queue: Katharine Daly <dalyk@google.com> Cr-Commit-Position: refs/heads/master@{#693395}
-
John Lee authored
Bug: 999094 Change-Id: I830363d723b495669eb22c0ed30c32ffb41182e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783664Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#693394}
-
Bettina authored
The current code does not decipher between multiple signed-in content area accounts. However, the SecurityEventRecorder only supports one signed-in account, whether it's consented or unconsented. The modal warning still shows for all signed-in content area accounts. Pingining is now only for unconsented signed-in account. All other content area signed-in accounts will not get pings. Bug: 999369,914410 Change-Id: If197c4085794025a4355c3d2a89c173f4c310178 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777068 Commit-Queue: Bettina Dea <bdea@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#693393}
-
Nick Harper authored
Bug: 994899 Change-Id: I458f7fdd5b925ab58b3bb522301d10be7612fee5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772493 Commit-Queue: Nick Harper <nharper@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#693392}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/aea4bca2621b..a6b07058f952 git log aea4bca2621b..a6b07058f952 --date=short --no-merges --format='%ad %ae %s' 2019-09-04 thestig@chromium.org Add a test for glyph path rendering. 2019-09-04 thestig@chromium.org Add a pixel test for a fixed JBIG2 bug. 2019-09-04 thestig@chromium.org Remove CRLF line endings from link_annots.in. 2019-09-03 thestig@chromium.org Roll third_party/freetype/src/ 9adc3b35f..543a3b939 (31 commits) 2019-08-28 gourabk@microsoft.com Add embedder tests for progressive render public APIs Created with: gclient setdep -r src/third_party/pdfium@a6b07058f952 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=pdfium-deps-rolls@chromium.org Bug: chromium:601362,chromium:963885 Change-Id: Ib95fe39d0b40e4f159dd0dd4493b6bc4070d53d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783561Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/f38bc1796282..183971ca2a9f git log f38bc1796282..183971ca2a9f --date=short --no-merges --format='%ad %ae %s' 2019-09-04 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@183971ca2a9f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: None Change-Id: Ifd857731807e36960cae9958e6a41b580dd3612f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783914Reviewed-by:
-
Lan Wei authored
When I changed dispatching events from synchronously to asynchronously, it causes some regression because we have not received the result from the actions but the tests already finished. We should make the default way of dispatching events as synchronously, when we really need send events asynchronously then we add this flag. Now I added this flag so I can enable the tests again. Bug: 999750 Change-Id: Ibe6185b63db4a731674e758cdf484896a6ced766 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783641 Commit-Queue: Lan Wei <lanwei@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#693389}
-
chrome://os-settingsBailey Berro authored
- Show the gear favicon when navigating to the chrome://os-settings page - Note: this is only relevant when os-settings is opened in a browser tab Bug: 977889 Change-Id: Id3c9ad8c8a06cb65e8c43b7ec5f0a9cdb580233c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771595 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Auto-Submit: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#693388}
-
Joey Arhar authored
Bug: 856777, 849483, 868407 Change-Id: Iebcdfe2adb4fdfc55281ebd91fe8da100a08f926 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639277 Commit-Queue: Joey Arhar <jarhar@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#693387}
-
jimmy gong authored
This reverts commit 56118b17. Reason for revert: <INSERT REASONING HERE> Original change's description: > Make CupsPrintersManager a CrosNetworkConfigObserver > > - CupsPrinterManager will now detect for network changes. > - Previously, when the network changes CupsPrintersManager would > wait until ZeroConfDetector updates with new printers. > - This resulted in a small time frame in which CupsPrintersManager > would still retain stale printers from the previous network. > - This fixes that bug by clearing the all printers upon a network > change, ensuring only new printers are populated. > > Bug: 779602 > Test: unittests, end to end manual > Change-Id: I0efe9e0a2252378bca178dc4b6dcea4da6baa978 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764677 > Commit-Queue: jimmy gong <jimmyxgong@chromium.org> > Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org> > Reviewed-by: Bailey Berro <baileyberro@chromium.org> > Cr-Commit-Position: refs/heads/master@{#693364} TBR=zentaro@chromium.org,baileyberro@chromium.org,jimmyxgong@chromium.org Change-Id: I1a5ca385c7babae571722722890276efe9b65dd4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 779602 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1785897 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#693386}
-
Anushruth authored
Added chrome tast tests with informational tests enabled to chromeos-kevin-rel-hw-tests We seem to have capacity for now (http://shortn/_StppJowPoi) R=bpastene@chromium.org Bug: 988581 Change-Id: Iba8d5acb1ccde68a7dc15a6ddc8555de0bc67c8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1781771Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Anushruth <anushruth@chromium.org> Cr-Commit-Position: refs/heads/master@{#693385}
-
Robert Ma authored
See https://crbug.com/944117#c44 for more context. Also clean up redundant Mac-related configs in test_suite_exceptions.pyl Bug: 1000762, 944117 Change-Id: If9fac657e841543a5b6f671131e5c9a4fe6f154a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784941Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#693384}
-
Sebastien Marchand authored
Bug: 995542 Change-Id: I4d0cd3f588fc71f3d203cc6135bcc994dfaa4c16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774794 Auto-Submit: Sébastien Marchand <sebmarchand@chromium.org> Commit-Queue: Jesse Doherty <jwd@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/7a63ee7f8a8b..88b1ffcb482a git log 7a63ee7f8a8b..88b1ffcb482a --date=short --no-merges --format='%ad %ae %s' 2019-09-04 wbbradley@chromium.org build api metrics: implement emit_metric tool Created with: gclient setdep -r src/third_party/chromite@88b1ffcb482a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Ib68c336d911e485353eaa658356f9d793051da15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783913Reviewed-by:
-
Ryan Hansberry authored
This filters out Bluetooth devices which cannot be paired to. The experiment conducted in crbug.com/976334 shows positive or neutral impact on all relevant metrics. Notably: * Bluetooth.ChromeOS.DeviceSelectionDuration.Settings.NotPaired.BLE: 95th percentile reduced from 26.8 seconds to 22.7 seconds. * Bluetooth.ChromeOS.DeviceSelectionDuration.Settings.NotPaired.Dual: 95th percentile reduced from 28.3 seconds to 26.6 seconds. Bug: 976334 Change-Id: Icff5f41553435ecc9f0a631460f7e8a01be1d9ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784979 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Auto-Submit: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#693381}
-
Jun Mukai authored
The code still assumes AppListItemView is a direct child of AppsGridView. This fixes the correct bounds calculation. Bug: 999314 Test: the new test case Change-Id: I260137a2db41d943d6f7ddbf5176fb15dbc49810 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779131 Commit-Queue: Jun Mukai <mukai@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#693380}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/1f2782e0602c..7e44ec26d652 git log 1f2782e0602c..7e44ec26d652 --date=short --no-merges --format='%ad %ae %s' 2019-09-04 mihu@microsoft.com GL_EXT_multisampled_render_to_texture extension. Part 1. Created with: gclient setdep -r src/third_party/angle@7e44ec26d652 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jmadill@chromium.org,jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jmadill@chromium.org,jmadill@google.com Bug: None Change-Id: I1cb14684301b93d79af75af1710d8bd0d0913f35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783915Reviewed-by:
-
Vasiliy Telezhnikov authored
When Skia is running in ES2 mode over ES3 context (use_es2_for_oopr workaround) using R8 textures causes internal checks in Skia. This CL change format to LUMINANCE8 in these cases. Bug: 998882 Change-Id: Ifb350141c0b332fc2fbe6bc6155fff69a031a65a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783526 Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#693378}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/bc0b4a6f0420..142d30cdaa58 Created with: gclient setdep -r src-internal@142d30cdaa58 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Ic14d3e8954ec3538054ba33247f26684ace5559f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784347Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#693377}
-
Ryan Hansberry authored
Remove speculative debug CHECK added in crrev.com/c/1705014. Bug: 969135 Change-Id: I18d7867d6ba82818db2eb9992687c1541886b420 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783881 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Auto-Submit: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
-
Daniel Clark authored
Change the LocalizedLandmarkType and LocalizedControlType for the contentinfo aria role from "content info" to "content information" per https://www.w3.org/TR/core-aam-1.1/#role-map-contentinfo. Also update the LocalizedLandmarkType for <footer> when scoped to the body element to "content information", since it inherits this from the contentinfo role per https://w3c.github.io/html-aam/#el-footer. Note that this doesn't affect <footer>'s LocalizedControlType, which should be "footer" (but is currently still "content info"). That is handled in the separate change at https://chromium-review.googlesource.com/c/chromium/src/+/1763243. Bug: 997897 Change-Id: If958b2090447010f0c0f3839739354dd4a0ea683 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772228Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Commit-Queue: Dan Clark <daniec@microsoft.com> Cr-Commit-Position: refs/heads/master@{#693375}
-
Miguel Casas-Sanchez authored
This CL creates a chrome:flags entry for UseFakeDeviceForMediaStream, allowing for ChromeOS clients to replace the audio/video capture devices in the system with a fake capture device, a venerable PacMan with a timestamp. Such fake webcam has been around forever for testing and verification, in the form of a command line, that is used in a bazillion places, so this CL basically checks the FeatureFlag and appends the command line if needed, in MediaStreamManager, the singleton hanging from BrowserMainLoop where media capture first starts. The purpose of this flag is to facilitate debugging of webrtc+video capture on ChromeOS, by allowing the developers to switch off the capture stack entirely, verifying the WebRTC stack in isolation. Bug: b:140250310 Change-Id: Iac8ff27ac3cc1a178d58661f53b0ea9737f6d10f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783308Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#693374}
-
Lukasz Anforowicz authored
Bug: 992121, 992381, 988351, 997741 Change-Id: Ib243ea0a34fb001ea2ace63cef9017927c27c13a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779424 Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#693373}
-
Hiroshige Hayashizaki authored
This CL regenerates mixed-content test files that reflects changes [1] and previous changes in https://crbug.com/906850 and removes old files. Purely mechanical. This CL largely renames test file names, and [2] contains old->new file name mapping data. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1586548 [2] https://chromium-review.googlesource.com/c/chromium/src/+/1783799 Bug: 906850 Change-Id: Ic13f66750bd3f45a362ed92fc5aaa4844420b474 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783800Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#693372}
-
Xiaocheng Hu authored
This patch turns a DCHECK into CHECK to verify if the DCHECK is still hit on production builds. This patch will be landed into version 3903, and will be reverted in the next version. Bug: 996037 Change-Id: Ice5237e9a0761b991425b1dbe402350a6ddd9b86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784161Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#693371}
-
Ionel Popescu authored
The current behavior for a popup is to destroy it, create it and destroy it again if the element which was clicked/tapped was already owning the popup. This behavior is causing a flicker effect when animation/drop shadow is added to the popup. This behavior can be changed to just store the popup, send the event to the element and later destroy the popup if needed. The popup will be destroyed in the following cases: 1. when another element which could open a popup was clicked/tapped - WebViewImpl::OpenPagePopup is going to call CancelPagePopup 2. when the user has clicked/tapped outside of the popup or on the element which had already a popup opened - by checking if the saved popup is the same as the current one Because of the way EventSender::HandleInputEventOnViewOrPopup is implemented adding a web_test will not be able to test the impacted scenarios: a popup should be dismissed when clicking outside of its area and another one should be opened when clicked/tapped on an element which supports having a popup (if first popup owner != second popup owner). Currently EventSender::HandleInputEventOnViewOrPopup will always send the input event to the popup if there is one. The real world implementation is that the popup will not receive the event if the click/tap event is outside of its area and the WebView is responsible for dismissing it. Bug: 992238 Change-Id: I13b7848e6e734e981d4fb9782e68a3d8123bc5ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1745769Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Ionel Popescu <iopopesc@microsoft.com> Cr-Commit-Position: refs/heads/master@{#693370}
-
Mirko Bonadei authored
Example of failure: https://ci.chromium.org/p/chromium/builders/webrtc.fyi/WebRTC%20Chromium%20FYI%20Win%20Builder/4011 Bug: 997673 Change-Id: I25453b2750346e5ee460d76dc4ead6555de11fad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1785218Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#693369}
-
Mugdha Lakhani authored
Bug: 988639 Change-Id: I354df80a573bf76e114e7f693017c00266621a57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783442 Auto-Submit: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#693368}
-
Richard Knoll authored
This adds UMA metrics when a user clicks on the help text in a Click to Call dialog. We also log which dialog type was shown at that time. Bug: 995253 Change-Id: If22ca2ee5ec984015f8ef4c771997aa815abe2ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774933 Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Alex Chau <alexchau@chromium.org> Cr-Commit-Position: refs/heads/master@{#693367}
-
Nicholas Verne authored
The feature is currently default enabled and the flag is expired. Bug: 1000506 Change-Id: I51911054286297e2bdc071379940603008898422 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784022 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Auto-Submit: Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#693366}
-
Vadym Doroshenko authored
This update contains implementation of lock which covers Windows. That makes libphonenumber thread-safe on all platforms. updated for >2 years. Binary-Size: this is an update of third_party library, which wasn't Bug: 976328 Change-Id: I1a2ea13436e2e735eb18a8da481ddd9d630c5fe3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761271 Commit-Queue: Dominic Battré <battre@chromium.org> Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#693365}
-
Jimmy Gong authored
- CupsPrinterManager will now detect for network changes. - Previously, when the network changes CupsPrintersManager would wait until ZeroConfDetector updates with new printers. - This resulted in a small time frame in which CupsPrintersManager would still retain stale printers from the previous network. - This fixes that bug by clearing the all printers upon a network change, ensuring only new printers are populated. Bug: 779602 Test: unittests, end to end manual Change-Id: I0efe9e0a2252378bca178dc4b6dcea4da6baa978 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764677 Commit-Queue: jimmy gong <jimmyxgong@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
-
Evan Stade authored
Bug: 998625 Change-Id: I97a94d94e8fb0e364c0c595c2289079b7e062e83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1785100Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#693363}
-
Balazs Engedy authored
This CL adds separate NotificationChannels for quiet (icon only) and heads-up (icon + pop-up) permission request notifications, and uses the newly added kQuietNotificationPrompt value to select the appropriate channel when displaying a notification permission request. Bug: 986737 Change-Id: I9b181fb4bcb964fdd065df51b6370ba327070b2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1766488 Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#693362}
-
Ayu Ishii authored
This change adds the following metrics to measure if the option of having the infobar is the best UI option and how disruptive the experience of having the infobar be automatically replaced by the keyboard while the keboard is active. Metrics: - Number of times the keyboard is automatically replaced by the Infobar - Duration from when the keyboard is replaced until when the user decides to cancel the infobar (not click confirm) to get out of the verification flow. Bug: 999238 Change-Id: I743028063e8f788270c6c17c15e646b4558df236 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777118Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Ayu Ishii <ayui@chromium.org> Cr-Commit-Position: refs/heads/master@{#693361}
-
Bailey Berro authored
Per UX guidance on crbug.com/978380, hide the list of users who are allowed to sign in when the "Restrict sign-in to the following users" toggle is in the off position, rather than disabling it. Bug: 978380 Change-Id: I139955f79ca00efd7024b1626f49521bf472447a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784964Reviewed-by:
-
François Doray authored
Test fails on Windows. TBR=dalecurtis@chromium.org Bug: 1000396 Change-Id: I7afae1373abe4afeb88b6993852c35934f63fe36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784131Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#693359}
-
Jeremy Roman authored
Noticed this as part of another CL. No need to bind the interface (which associates it with a task runner and creates the necessary objects to receive replies) until adoption actually occurs. This makes the parallel construction between the Portal and PortalClient more obvious (they're both pending or not-pending at the same time). Change-Id: Icd0b92501eb97f0903faf3cc53a650fc6f5de815 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784940 Commit-Queue: Jeremy Roman <jbroman@chromium.org> Commit-Queue: Lucas Gadani <lfg@chromium.org> Auto-Submit: Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#693358}
-
