- 02 Jan, 2018 40 commits
-
-
Juan Antonio Navarro Perez authored
Test has been consistently failing on webview bots. Bisect was unable to find culprit. TBR=nednguyen@google.com NOTRY=true Bug: 797261 Change-Id: Ia0bf67071777bc98e5aea77c729ce5d7f2971e2d Reviewed-on: https://chromium-review.googlesource.com/847575Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#526482}
-
John Budorick authored
Moving over from chromium_tests configurations. Change-Id: Ia5fa5f4a3d8b0d8bd66fe08446a202748bd1d576 Reviewed-on: https://chromium-review.googlesource.com/845128Reviewed-by:
Abhishek Arya <inferno@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#526481}
-
maxmorin authored
Bug: 798116 Change-Id: I3e13b4f313edac0a951d417b919df0be4332778a TBR: Reviewed-on: https://chromium-review.googlesource.com/847478Reviewed-by:
Max Morin <maxmorin@chromium.org> Commit-Queue: Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#526480}
-
Mark Cogan authored
For most of the TabModel notifications, the only observer is the BVC, which is already a TabModelObserver. This CL starts the process of folding all of the TabModel notifications into TabModelObserver calls. All of the changes in this CL are straightforward: instead of sending a notification, instead the caller calls a method on TabModel (in the same pattern as -notifyTabChanged), which calls TabModelObserver methods that map to the old notifications. The BVC's notification handling code is moved into these new methods and relocated as appropriate, but is otherwise unchanged. This removes all but two of the notifications. Follow-up CLs will remove the others. Bug: 320877 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I1d17178181b69f9b083aed137856c11255b94429 Reviewed-on: https://chromium-review.googlesource.com/847532 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#526479}
-
maxmorin authored
Bug: 780555 Change-Id: I2868681e763958b200735bb27a6c423b170393f4 Tbr: peconn Reviewed-on: https://chromium-review.googlesource.com/846991Reviewed-by:
-
Robert Hogan authored
Bug: 797185 Change-Id: I2521e1cf552be56abba6513eada51cad571d2cca Reviewed-on: https://chromium-review.googlesource.com/844074Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Robert Hogan <robhogan@gmail.com> Cr-Commit-Position: refs/heads/master@{#526477}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 7fc07bf6. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/9445 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: mstensho@chromium.org: external/wpt/css/css-multicol TBR=foolip No-Export: true Change-Id: I1132285ea830bb082b493e1c551d2c083f0c908a Reviewed-on: https://chromium-review.googlesource.com/847412 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#526476}
-
Jochen Eisinger authored
We pass the suggested filename along with the request and use that as a signal that the navigation should result in a download. The next step will be to ignore this hint for cross origin downloads, so that only files with a content-disposition will end up being downloaded. Bug: 714373,797292 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo;master.tryserver.chromium.linux:linux_site_isolation Change-Id: I508d7abe1cba9b75d65132b0688984cdebfc6fd4 Reviewed-on: https://chromium-review.googlesource.com/758236 Commit-Queue: Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Min Qin(OOO 12/7-1/10) <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#526475}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/a06e01c8..bfbaf6ac Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I07666a0f22f945ab1b10572c5a343329cab92ea9 Reviewed-on: https://chromium-review.googlesource.com/847416Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#526474}
-
Mike West authored
Chrome is failing 7 cookie tests. Amazingly, Firefox and Safari are failing the same tests! How shocking. This patch fixes the tests, which were broken in three ways: 1. `fetch()` needs to accept credentials explicitly via a `credential` parameter. 2. Invalid `path` components default to the directory of the file setting the cookie, which was distinct between `//cookies/path/echo-cookie.html` and `//cookies/resources/set-cookie.py`. 3. `ws://` is blocked when requested from HTTPS. Change-Id: I0a8f0869e35c2e8316fb36e796d4c657d931b967 Reviewed-on: https://chromium-review.googlesource.com/839520Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#526473}
-
Sriram authored
Upstream the below tests from media/track/ to wpt 1. track-cues-missed.html 2. track-cues-pause-on-exit.html 3. track-cues-seeking.html 4. track-cues-sorted-before-dispatch.html Bug: 782555 Change-Id: I5d80f910a048b74702625806dea148096ac89fc2 Reviewed-on: https://chromium-review.googlesource.com/847396Reviewed-by:
Fredrik Söderquist <fs@opera.com> Commit-Queue: srirama chandra sekhar <srirama.m@samsung.com> Cr-Commit-Position: refs/heads/master@{#526472}
-
maxmorin authored
fast/history/history-back-twice-with-subframes-assert.html flakily times out. Bug: 798121 Change-Id: Idfb693776a84ca1946ec0771fcd2fd2f71a80f10 Tbr: Reviewed-on: https://chromium-review.googlesource.com/846990Reviewed-by:
-
Daniel Bratell authored
Several files include highcontrast_classifier.h so jumbo builds got duplicate instances of everything in the header file. Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ibfe824f52d4b1f6046b75e4621f662ce0bf1d0c3 Reviewed-on: https://chromium-review.googlesource.com/847572Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#526470}
-
k2.nagaraju authored
updated the line, position and size properties to double updated test cases and expected results Bug: 699063 Change-Id: Icc179032077e0e1351efed64cc5a965ee254ca09 Reviewed-on: https://chromium-review.googlesource.com/836576Reviewed-by:
-
Mythri Alle authored
Now V8 has an API to request code cache. Earlier, we had to request code cache along with compile requests. Since we have an explicit API to request code cache, we want to decouple compile and code caching. As a part of this, we want to change v8::ScriptCompiler::CompileOptions by removing kProduceCodeCache, kProduceFullCodeCache and adding kCompileEager. To smoothly integrate these changes into chromium, introducing a default case in the switch statements using CompileOptions. This will be removed once the V8 roll that adds these options is rolled into chromium. Bug: chromium:783124 Change-Id: Ia4e72e2a00f72f81e21949f6e892250bf4bfb7c5 Reviewed-on: https://chromium-review.googlesource.com/831951Reviewed-by:
Alexei Filippov <alph@chromium.org> Commit-Queue: Mythri Alle <mythria@chromium.org> Cr-Commit-Position: refs/heads/master@{#526468}
-
Daniel Bratell authored
There are two identical GetImageInfo functions in the blink/html code and only one of them is used. This patch deletes the unused one. This was noticed in a non-standard jumbo configuration because both instances ended up in the same translation unit. Change-Id: I4b0959fcc1bf9a0902a6d8574023e9b59de60375 Reviewed-on: https://chromium-review.googlesource.com/847474Reviewed-by:
-
maxmorin authored
These tests are now very flaky. Bug: 775415, 787809, 787938, 791022, 796047 Tbr: phoglund@chromium.org Notry: True Change-Id: I3ace2542e573d533aab6cfbc1558e4a7ebccce30 Reviewed-on: https://chromium-review.googlesource.com/846882Reviewed-by:
Patrik Höglund <phoglund@chromium.org> Commit-Queue: Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#526466}
-
Mounir Lamouri authored
Bug: 797901 Change-Id: Ifd4e4d658777d22e78117eedd9251f120ea48e24 Reviewed-on: https://chromium-review.googlesource.com/845684Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#526465}
-
Rune Lillesveen authored
Change-Id: Ia61e2fdc14d5df0f8ba05a93509667565b834261 Reviewed-on: https://chromium-review.googlesource.com/846764Reviewed-by:
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/3cbf26e8..a06e01c8 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I48c74700800382d39318cc76a458cadf6311811f Reviewed-on: https://chromium-review.googlesource.com/847452Reviewed-by:
-
Becca Hughes authored
Single tap on controls to toggle the UI instead of play/pause. BUG=794592 Change-Id: Idfc6ea6eb1ade43344955a48512385db083a06ba Reviewed-on: https://chromium-review.googlesource.com/833915 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#526462}
-
maxmorin authored
Bug: 798253 TBR: kinuko Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I98878c3452c00dccaecfd1c73223176f474d782c Reviewed-on: https://chromium-review.googlesource.com/847434Reviewed-by:
-
webrtc-autoroll@chromium.org authored
https://webrtc.googlesource.com/src.git/+log/75f18fca8eef..5f99e656792b $ git log 75f18fca8..5f99e6567 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I68606e58d4d140241b98861ff36020719672d92c Reviewed-on: https://chromium-review.googlesource.com/846202Reviewed-by:
WebRTC Roll Bot <webrtc-autoroll@chromium.org> Commit-Queue: WebRTC Roll Bot <webrtc-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#526460}
-
Sriram authored
Upstream the below tests from media/track/ to wpt 1. text-track-cue-constructor.html 2. track-add-remove-cue.html 3. track-add-track.html 4. track-addtrack-kind.html Bug: 782555 Change-Id: I83586a3a9135398837073533d74fee1a3838b586 Reviewed-on: https://chromium-review.googlesource.com/838902Reviewed-by:
-
Gauthier Ambard authored
This CL moves the image_util files to its own folder under ui/. It also moves the ImageSaving code from BVC to this folder. Bug: 797271 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Id72d988e2d610906d038c8ef54c74d427859dc27 Reviewed-on: https://chromium-review.googlesource.com/842405 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#526458}
-
vitaliii authored
Both old and new sign-in flows were changed, which broke sync integration tests. In this CL the sign-in code is updated for both flows: - for the old flow, only "Next" button id has been changed; - for the new flow: + new element ids; + different mechanism to wait for password field to appear. Previously this was achieved via javascript delay, however, the new flow has a redirect, which seems to reset injected javascript. The new approach is to inject new javascript for the check every second. Also the detection of the flow had to be changed, because now the flows do not share field ids anymore. Thus, the test just waits for either of the email fields to appear. Bug: 795071 Change-Id: I5bb940ab9e410837b0ce91c6bdcb38c91b95b29f Reviewed-on: https://chromium-review.googlesource.com/840000 Commit-Queue: vitaliii <vitaliii@chromium.org> Reviewed-by:Mihai Sardarescu (OOO until Jan 2nd) <msarda@chromium.org> Reviewed-by:
Patrick Noland <pnoland@google.com> Cr-Commit-Position: refs/heads/master@{#526457}
-
Rune Lillesveen authored
Change-Id: I47a842f04b0f4356b89320a3f0f0512265dfee1d Reviewed-on: https://chromium-review.googlesource.com/846763Reviewed-by:
-
Sriram authored
Upstream the below tests from media/track/ to wpt 1. track-cue-empty-crash.html 2. track-cue-inline-assertion-crash.html 3. track-cue-mutable-fragment.html 4. track-cue-mutable.html Bug: 782555 Change-Id: If3b561bed0d908c22a1ac424e851320a18c11e52 Reviewed-on: https://chromium-review.googlesource.com/846160 Commit-Queue: srirama chandra sekhar <srirama.m@samsung.com> Reviewed-by:
-
Gauthier Ambard authored
This CL moves the layout of the toolbar, including the creation of the buttons, the subviews and the constraints between them from the ToolbarViewController to the ToolbarView. It allows the ToolbarViewController to be only about managing the view and not about layouting it. Bug: 791979 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ia1ed63b9fdc73b22b465953dce0599e7092e0dc6 Reviewed-on: https://chromium-review.googlesource.com/842647 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#526454}
-
Morten Stenshorne authored
The WebCore namespace got renamed to blink already a few years ago. Change-Id: If69572ecd12c0b6c3fb21d826d6942498135143d Reviewed-on: https://chromium-review.googlesource.com/844694Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
-
Gauthier Ambard authored
The check is failing because it was written as if the content of the file returned with f.NewContents() is a string. It is actually a list. This CL fixes it. The check never worked. Bug: 798289 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Icfd216bbcaee78671878b65ac412b9063bd24509 Reviewed-on: https://chromium-review.googlesource.com/847372 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
-
Mark Cogan authored
This CL groups the internal methods of the BVC by function and arranges them together such that the ordering and grouping in the source code matches the ordering of the forward declarations. Most of the changes are just adding comments and pragmata and moving methods around. Additionally: - The ivar _fullScreenAlertShown was initialized but never used; it's deleted. - Several methods that were forward-declared but were only protocol-specific helpers have their forward declarations removed, and they are grouped with their protocols. - A few private methods have forward declarations added (with comments, which were not present before). - -currentWebstate is declared as a property and call sites are updated to use dot notation. - Two other properties have their implementations moved with the other property implementations. Bug: Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I4ae47a316c37a095f3114245b4c49e3a81e16444 Reviewed-on: https://chromium-review.googlesource.com/846770 Commit-Queue: Mark Cogan <marq@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
-
Gauthier Ambard authored
The factory is already creating the buttons only for the toolbar. It makes sense to have the configuration of the button to be moved to the factory. Bug: 791979 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I953f1ef012d5bb43cf2b3e266a3ad9f2ebf445ac Reviewed-on: https://chromium-review.googlesource.com/808605 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
-
Raphael Kubo da Costa authored
Blink's code no longer follows WebKit's style so the entire section about different line limits and indentation can be removed. R=drott Change-Id: If06ba22acf674d0746d698ce9b7516e6f688d739 Reviewed-on: https://chromium-review.googlesource.com/845621 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#526449}
-
Yoav Weiss authored
There's some confusion when preloaded resources are not used, and the current warning message is not clear enough. On the issue Paul Irish suggested a better warning message, that may help reduce the confusion. This CL implemented that message. Bug: 678429 Change-Id: I4d7bda73d243de9d323a007ee336dfd571586d64 Reviewed-on: https://chromium-review.googlesource.com/846980Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Yoav Weiss <yoav@yoav.ws> Cr-Commit-Position: refs/heads/master@{#526448}
-
Koji Ishii authored
A small utility function that creates a ShapeResult and CopyRange. Used in one place, and another coming in line breaker WIP. Also changed |primary_font_| field to const to eliminate a const_cast. Bug: 636993 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I293bf245a360841ddc5ce87e805b60770b2ec553 Reviewed-on: https://chromium-review.googlesource.com/846603 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#526447}
-
Eddy Mead authored
Change-Id: Ie738b4ede6c6a610ba6ddb1e640eaa47531073b9 Reviewed-on: https://chromium-review.googlesource.com/823509Reviewed-by:
nainar <nainar@chromium.org> Commit-Queue: meade_UTC10 <meade@chromium.org> Cr-Commit-Position: refs/heads/master@{#526446}
-
Darren Shen authored
Spec: https://drafts.css-houdini.org/css-typed-om-1/#positionvalue-normalization Note that our implementation is much simpler than the spec algorithm because the parser already handles a lot of the logic. Bug: 788570 Change-Id: Ice161237890222b6f28437a3846d8eb84bc0050c Reviewed-on: https://chromium-review.googlesource.com/846579 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
meade_UTC10 <meade@chromium.org> Cr-Commit-Position: refs/heads/master@{#526445}
-
Zhuoyu Qian authored
This patch makes BoxSide to be an enum class for better type safety. Bug: 684966 Signed-off-by:
Zhuoyu Qian <zhuoyu.qian@samsung.com> Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I871dd622e8b42a980b0d9f4a64b781f2893800e3 Reviewed-on: https://chromium-review.googlesource.com/844297Reviewed-by:
-
Zhuoyu Qian authored
Made StylePropertyMap::setProperty take a const CSSValue& instead of a const CSSValue*. This is more semantically correct and safe since StylePropertyMaps cannot store nullptrs, and is also an attempt to fix a strange performance issue caused from introducing const CSSValue*s. BUG=526586 R=sashab@chromium.org Signed-off-by:
Sasha Morrissey <sashab@chromium.org> Cr-Commit-Position: refs/heads/master@{#526443}
-
