GitLab

This fetches them from GTK using the same logic as is used in
the GTK port.

BUG=chromium-os:3916
TEST=built and ran it for GTK and Chrome OS Views

Review URL: http://codereview.chromium.org/3198013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57271 0039d316-1c4b-4281-b951-d872f2087c98

TEST=none
BUG=53140
TBR=rohitrao

Review URL: http://codereview.chromium.org/3191025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57270 0039d316-1c4b-4281-b951-d872f2087c98

I added an asynchronous API to libcros for setting the Owner's key
on Chrome OS.  This CL wires that out through LoginLibrary and also
refactors the OwnerManager class into the OwnershipService, a
Singleton that will provide access to the entire Ownership API --
which includes methods for whitelisting users and signed preferences.
The OwnerManager class is now just there to manage the Owner's
key and operations with that key.

A consumer of this API can call methods of OwnershipService, which will post tasks to run methods from OwnerManager (on the FILE thread if appropriate).  The OwnerManager will, in turn, call methods of LoginLibrary to perform owner key operations.  Since these calls to LoginLibrary are asyncrhonous, OwnerManager implements LoginLibrary::Delegate and passes |this|, so that LoginLibrary can call back to the OwnerManager when asynchronous operations are completed.

BUG=chromium-os:4488
TEST=unit tests

Review URL: http://codereview.chromium.org/3141031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57269 0039d316-1c4b-4281-b951-d872f2087c98

TEST=none
BUG=none
TBR=rolandsteiner

Review URL: http://codereview.chromium.org/3108045

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57268 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3191022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57267 0039d316-1c4b-4281-b951-d872f2087c98

mode in all cases (now uses same code path for --keep-alive-for-test and for
background apps) - this is necessary because ExtensionsService does not
generate EXTENSION_UNLOADED notifications when the app shuts down as I thought.

With this fix, the extension API tests for background apps pass without
disabling background mode.

BUG=53021
TEST=extension API tests pass now with background mode enabled.

Review URL: http://codereview.chromium.org/3198007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57266 0039d316-1c4b-4281-b951-d872f2087c98

having some problems, and on Mac, those problems show up the most when
running this test suite.

TEST=none
BUG=53140

Review URL: http://codereview.chromium.org/3119042

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57265 0039d316-1c4b-4281-b951-d872f2087c98

BUG=52924
TEST=none
Review URL: http://codereview.chromium.org/3174026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57263 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=Verify preference UI works properly in dom-ui options window.
Review URL: http://codereview.chromium.org/3170042

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57262 0039d316-1c4b-4281-b951-d872f2087c98

Changed mft_h264_decoder's API to match with video_decode_engine.h. Also changed the example and unittests.

Implementation of mft_h264_decoder.cc is similar to ffmpeg_video_decode_engine.cc. For now, a d3d surface output from the decoder is converted from NV12 to YV12 and stored in regular memory. So rendering with --enable-dxva is a bit
slower for now. Once we figure out how to connect with ANGLE, we won't need the conversion / transfer.

basic_renderer.* is now replaced with a simpler implementation of EventHandler inside the example code. d3d_util.* is also removed because d3d9 initialization is now moved inside the initialization of the decoder and it is the only place where it is used.

BUG=none
TEST=included in this patch

Review URL: http://codereview.chromium.org/3156046

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57261 0039d316-1c4b-4281-b951-d872f2087c98

exists so it can't be enabled.

Review URL: http://codereview.chromium.org/3157038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57259 0039d316-1c4b-4281-b951-d872f2087c98

BUG=52900
TEST=Valgrind Linux gets greener.
Review URL: http://codereview.chromium.org/3192009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57258 0039d316-1c4b-4281-b951-d872f2087c98

Revert 57254 - Share one thread between all AudioOutputControllers instead of creating one per stream.
TEST=unittests
BUG=39825

Review URL: http://codereview.chromium.org/3185022

TBR=sergeyu@chromium.org
Review URL: http://codereview.chromium.org/3192017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57256 0039d316-1c4b-4281-b951-d872f2087c98

Rename HostMessage and ClientMessage to Chromoting{Host|Client}Message to
avoid conflicts with messages in X11.

Actually, only ClientMessage needs to be changed due to conflict, but HostMessage is changed to keep the names consistent.

BUG=none
TEST=remoting unittests

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57112

Review URL: http://codereview.chromium.org/3161034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57255 0039d316-1c4b-4281-b951-d872f2087c98

TEST=unittests
BUG=39825

Review URL: http://codereview.chromium.org/3185022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57254 0039d316-1c4b-4281-b951-d872f2087c98

Useful for plugins that make heavy use of background threads.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57233

Review URL: http://codereview.chromium.org/3104031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57253 0039d316-1c4b-4281-b951-d872f2087c98

This reverts commit r57234

TBR: stevenjb

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57252 0039d316-1c4b-4281-b951-d872f2087c98

in http://crbug.com/49862.  That crash no longer occurs.

Fix cpplint.py nit: add a "// namespace" comment.

R=vandebo
BUG=49862
TEST=none
Review URL: http://codereview.chromium.org/3165057

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57250 0039d316-1c4b-4281-b951-d872f2087c98

BUG=53176
TEST=None.
Review URL: http://codereview.chromium.org/3204003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57249 0039d316-1c4b-4281-b951-d872f2087c98

Change search engine dialog image to be transparent, and use this image flipped as the RTL dialog top.

BUG=none
TEST=search engine dialog looks fine in LTR and RTL modes

Review URL: http://codereview.chromium.org/3171028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57248 0039d316-1c4b-4281-b951-d872f2087c98

pass important values (the return value of WaitForSingleObject
and the error code) as function arguments so that they are
available in crash dumps.

R=eroman
BUG=51950,52008
TEST=none
Review URL: http://codereview.chromium.org/3107032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57247 0039d316-1c4b-4281-b951-d872f2087c98

Modifies AutoFill heuristics to match middle initial at end of string instead of strict match of whole string.  Also, adds form_field_unittest.cc with specific unit tests for pattern matching.

BUG=45123
TEST=FormFieldTest.Match, NameFieldTest.MiddleInitialAtEnd

Review URL: http://codereview.chromium.org/3127030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57246 0039d316-1c4b-4281-b951-d872f2087c98

With this change, the feature extractor will keep track of how long it has been
working, and if it exceeds a predefined time limit, it will pause and post a
task to continue extraction.  This will allow other MessageLoop tasks to run on
the render thread.  There is also a total time limit, after which the extractor
will give up altogether -- this is a sanity check in case of a bug or an
especially large page.  Also includes some UMA histograms so that we can see
how well this performs in practice.

TEST=PhishingDOMFeatureExtractorTest.Continuation
BUG=none

Review URL: http://codereview.chromium.org/3130039

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57243 0039d316-1c4b-4281-b951-d872f2087c98

TBR=brettw

TEST=browser_tests
BUG=53247

Review URL: http://codereview.chromium.org/3141040

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57242 0039d316-1c4b-4281-b951-d872f2087c98

TBR=rohitrao

Review URL: http://codereview.chromium.org/3110036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57240 0039d316-1c4b-4281-b951-d872f2087c98

BUG=49094
TEST=none

Review URL: http://codereview.chromium.org/3140026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57238 0039d316-1c4b-4281-b951-d872f2087c98

[Mac] if someone overrides FILE_EXE/DIR_EXE in the path service, it can cause the calculation for DIR_SOURCE_ROOT to go wrong.  Avoid this by not using the value from the path service.

BUG=52918
TEST=green tree
Review URL: http://codereview.chromium.org/3176036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57237 0039d316-1c4b-4281-b951-d872f2087c98

to avoid crashes.

TBR=dhollowa, sky, erikkay

TEST=unit_tests, browser_tests
BUG=52731, 52643
Review URL: http://codereview.chromium.org/3150034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57236 0039d316-1c4b-4281-b951-d872f2087c98

This reverts commit r57233

TBR: brettw

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57235 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:5601 (http://code.google.com/p/chromium-os/issues/detail?id=5601)
TEST=Check that hover text over status bar icons seems reasonable. Test different states of network (disconnected, ethernet, connecting to a wifi network, connected to a wifi network) and battery (plugged in, unplugged).

Review URL: http://codereview.chromium.org/3158014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57234 0039d316-1c4b-4281-b951-d872f2087c98

Useful for plugins that make heavy use of background threads.

Review URL: http://codereview.chromium.org/3104031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57233 0039d316-1c4b-4281-b951-d872f2087c98

- Add a check to make sure the helper isn't used without --type
- Add a check to make sure the main app isn't used with --type.
- Make inproc browser tests invoke the helper that is within the app bundle on disk to recreate the real world environment.

BUG=23645,52858
TEST=green tree, invoking the main app with --type fails, and invoking the helper without it fails.
Review URL: http://codereview.chromium.org/3171027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57231 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:6059
TEST=none

Review URL: http://codereview.chromium.org/3157037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57230 0039d316-1c4b-4281-b951-d872f2087c98

The new file, render_messages_params.h, is included in 57 files, while
render_messages.h is included in 176 files. Moving the Params structs to their
own file allow pruning the included headers.

(Part 2 of this cleanup will be sorting the individual structs into themes
to further minimize header inclusion.)

BUG=51411
TEST=compiles

Review URL: http://codereview.chromium.org/3119035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57229 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/3165050

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57228 0039d316-1c4b-4281-b951-d872f2087c98

Cleanup all files the tests might have created in the download dir.

Review URL: http://codereview.chromium.org/3141039

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57227 0039d316-1c4b-4281-b951-d872f2087c98

This is based on existing code/math. I have removed all the unused code for our usage and adapted to the chromium coding style.

TEST=unit_tests --gtest_filter=EndpointerTest.*
BUG=none

Review URL: http://codereview.chromium.org/3117026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57226 0039d316-1c4b-4281-b951-d872f2087c98

BUG=53173
TEST=none yet (will add tests when BackgroundModeManager handles prefs notifications)

Review URL: http://codereview.chromium.org/3200007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57225 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/3108043

TBR=mnaganov@chromium.org
Review URL: http://codereview.chromium.org/3203003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57224 0039d316-1c4b-4281-b951-d872f2087c98

1. Treats ASCII double/single quoation marks between Hebrew letters as MidLetter
   for Hebrew spellchecker because they're commonly used in place of Geresh and Gershayim.
2. Pass through ASCII double/single quotation marks and Geresh and Gershayim in OutputHebrew.

See http://www.unicode.org/reports/tr29/proposed.html (version 6.0.0.0 draft2) about Hebrew
tailoring.

This alone does not fix bug 22909 completely. This CL will be followed with an ICU data fix. 

BUG=22909
TEST=unit_tests --gtest_filter=SpellcheckWordIteratorTest.*

Review URL: http://codereview.chromium.org/3112015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57223 0039d316-1c4b-4281-b951-d872f2087c98