- 12 Sep, 2017 40 commits
-
-
Xiaohui Chen authored
Previously, some places would change voice interaction states without notifying ash. Now we make sure each change would properly send out notifications so ash could updates its UI. BUG=b:65496623 TEST=build and flash locally, manually test UI updates properly Change-Id: I6e9eae6c98b4e02469a3d84a53d6f181d5378330 Reviewed-on: https://chromium-review.googlesource.com/658558 Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#501331}
-
Chris Mumford authored
leveldb_proto::Options is a small subset (mostly) of leveldb::Options. It had two leveldb::Options members (shared_cache and write_buffer_size), and a (possibly empty) database_name. This change deletes leveldb_proto::Options in lieu of using leveldb::Options. This simplifies the code as well as adds support for the remaining options specified in leveldb::Options. Bug: 762587 Change-Id: Ia7872ecb09b2b181354c820ac3296ea6304a80b0 Reviewed-on: https://chromium-review.googlesource.com/655697Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
John Mellor <johnme@chromium.org> Commit-Queue: Chris Mumford <cmumford@chromium.org> Cr-Commit-Position: refs/heads/master@{#501330}
-
MinChen authored
Changes: 1. Call TrayBackgroundView::Inialize in PaletteTray::Initialize to add the widget observer for palette tray widget. Then when palette tray anchor changed its AnchorUpdated() can be called. 2. Call SystemTray's UpdateClippingWindowBounds() in WebNotificationTray::UpdateAnchored(). Since when the shelf is bottom alignment, the anchor tray of WebNotificationTray bubble is SystemTray. Bug: 759233 Change-Id: I036e3d2a58541398821424ed31b6534c50b5033b Reviewed-on: https://chromium-review.googlesource.com/653313Reviewed-by:
Stefan Kuhne <skuhne@chromium.org> Commit-Queue: min c <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#501329}
-
Xu Xing authored
This is a reland of aa28a986 Original change's description: > viz: Move CreateResourceFromTextureMailbox from Display to LayerTree in GLRendererTest > > As a step of moving SingleReleaseCallbackImpl/CreateResourceFromTextureMailbox > into LayerTreeREsourceProvider, move the call of > DisplayResourceProvider::CreateResourceFromTextureMailbox > into LayerTreeResourceProvider::CreateResourceFromTextureMailbox. > > The usage of CreateResourceFromTextureMailbox is listed here: > https://docs.google.com/spreadsheets/d/1lnyONBganHkiQKw8J-3e3xC7STZkYvSh7dkzxSUFmPw/edit > > BUG=757291 > > Change-Id: I41e5d44c5f2ac03b3a5b3da1951a5ca09b3b4529 > Reviewed-on: https://chromium-review.googlesource.com/654444 > Commit-Queue: Xing Xu <xing.xu@intel.com> > Reviewed-by: danakj <danakj@chromium.org> > Cr-Commit-Position: refs/heads/master@{#500974} Bug: 757291 Change-Id: I3a480f72dd6761e940f67f56d636eaf2340df4cc Reviewed-on: https://chromium-review.googlesource.com/662437Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Xing Xu <xing.xu@intel.com> Cr-Commit-Position: refs/heads/master@{#501328}
-
Scott Violet authored
This is needed to properly convert pixels to DIPs, otherwise things like the the magnification controller don't work. BUG=706200 TEST=covered by test Change-Id: Ie5c841c75080f239b0b3e01469ca0af1435e0756 Reviewed-on: https://chromium-review.googlesource.com/662057Reviewed-by:
Elliot Glaysher <erg@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#501327}
-
Bernhard Bauer authored
This is a reland of 6d4871d1 Original change's description: > Reland "Split ThumbnailProviderImpl cache into a LRU and a deduplication cache." > > This is a reland of a4f8bff1 > Original change's description: > > Split ThumbnailProviderImpl cache into a LRU and a deduplication cache. > > > > Bug: 718925 > > Change-Id: I8bfe2d4b743c8fdb014b2112683aba1f74835753 > > Reviewed-on: https://chromium-review.googlesource.com/582958 > > Reviewed-by: Theresa <twellington@chromium.org> > > Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> > > Commit-Queue: Bernhard Bauer <bauerb@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#500574} > > TBR: twellington@chromium.org > Bug: 718925 > Change-Id: I68b0184d30c4bc4e712e3ceb1522879b15f5e1d7 > Reviewed-on: https://chromium-review.googlesource.com/659879 > Commit-Queue: Bernhard Bauer <bauerb@chromium.org> > Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> > Cr-Commit-Position: refs/heads/master@{#500948} Bug: 718925 Change-Id: I5101af7da3a470499901e57fab08d1ec580eec04 Reviewed-on: https://chromium-review.googlesource.com/663017Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#501326}
-
Henrik Boström authored
It turned out that without making this event dispatching conditional on the flag it would fire anyway. It only fires if you listen to the event using addEventListener('track', X), not if you use ontrack = X. When it fires and the flag is off it looks like RTCTrackEvent members such as track and streams are undefined because RTCTrackEvent is behind flag. With this change you get the expected behavior with and without the flag enabled. Also fixes https://github.com/webrtc/apprtc/issues/481 Bug: 761612 Change-Id: Ideaf636633821b0bd9718ef0d2a7a8e7e8b289c1 Reviewed-on: https://chromium-review.googlesource.com/663259Reviewed-by:Guido Urdaneta <guidou@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#501325}
-
Yuke Liao authored
Origianlly, the code coverage script uses "llvm-cov export" to get the code coverage, but the problem was that it took too long to run and contains a lot of unrelated information, and for example, it took more than 5 minutes to generate code coverage data for ios_chrome_unittests. This CL speeds up the report generation by changing to use "llvm-cov report", it's more hacky, but it's significantly faster. This change reduced the time to generate code coverage report for ios_chrome_unittests from more than 5 minutes to less than 1 minute. Bug: 763956 Change-Id: Ib62a29fef67ea6973e063893af2164b34a25841c Reviewed-on: https://chromium-review.googlesource.com/661677 Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Mike Baxley <baxley@chromium.org> Cr-Commit-Position: refs/heads/master@{#501324}
-
Theresa authored
This reverts commit 7b2e0e41. Reason for revert: Failing on Android Tests (dbg) Original change's description: > Initialize PathUtils for the decoder service > > This should fix the crashes that we've been seeing on the bots, so those > have been re-enabled as well. > > BUG=761060 > > Change-Id: I75dfcc04e972e5dd9a0478cc297701603fa71551 > Reviewed-on: https://chromium-review.googlesource.com/663219 > Reviewed-by: Finnur Thorarinsson <finnur@chromium.org> > Commit-Queue: Peter Beverloo <peter@chromium.org> > Cr-Commit-Position: refs/heads/master@{#501265} TBR=peter@chromium.org,finnur@chromium.org Change-Id: I2f41b0d15b06f55f978e81e7503e52d9301260c5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 761060 Reviewed-on: https://chromium-review.googlesource.com/663420Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#501323}
-
Nicolas Dossou-gbete authored
Bug: 762549 Change-Id: Iebd5c5dc7d3c3d3d46c4acb8bb03142413e82515 Reviewed-on: https://chromium-review.googlesource.com/663341Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Reviewed-by:
vitaliii <vitaliii@chromium.org> Commit-Queue: Nicolas Dossou-Gbété <dgn@chromium.org> Cr-Commit-Position: refs/heads/master@{#501322}
-
Tomasz Garbus authored
On iOS calling navigator.credentials.get() would result in an error saying "Check failed: false. Trying to read an unregistered pref: profile.was_auto_sign_in_first_run_experience_shown" In this CL the preference is being registered in PasswordManager::RegisterProfilePrefs() Bug: 453048 Change-Id: I744bfa19e018a3543de3349c0833d4d062a016e6 Reviewed-on: https://chromium-review.googlesource.com/663220Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Tomasz Garbus <tgarbus@chromium.org> Cr-Commit-Position: refs/heads/master@{#501321}
-
Sadrul Habib Chowdhury authored
chromeos always builds with ozone, and no longer has direct dependency on x11. So USE_X11 is no longer applicable for chromeos code. BUG=750642 Change-Id: Iade4e609dbbb5d20d7a683153d23f84fc7848b46 Reviewed-on: https://chromium-review.googlesource.com/663403 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#501320}
-
Fredrik Söderquist authored
Change-Id: If895e92065d23e3da4f5d659c114abf024038b38 Reviewed-on: https://chromium-review.googlesource.com/663537 Commit-Queue: Fredrik Söderquist <fs@opera.com> Commit-Queue: Daniel Bratell <bratell@opera.com> Reviewed-by:
Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#501319}
-
David Reveman authored
This adds trilinear filtering support to layers. All layers with this type of filtering a rendered to a render surface and mipmaps are generated for the render surface when supported by renderer. This allows for more efficient and higher quality down-sampling. It can provide a significant performance improvement when combined with render surface caching. BUG=757020 TEST=cc_unittests --gtest_also_run_disabled_tests --use-gpu-in-tests --gtest_filter=GLRendererPixelTest.DISABLED_TrilinearFiltering Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I14eb1b06231c9732651670f0cd4b95f95344f5b2 Reviewed-on: https://chromium-review.googlesource.com/621540Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#501318}
-
Jun Cai authored
This CL changes code at PlatformSensorAndProviderTest.java to use assertTrue and assertFalse instead of assertEquals for boolean to improve code readability. Bug: None Change-Id: Ieb77fd683dc4c3b135e7498b6a2443a91d17b4bd Reviewed-on: https://chromium-review.googlesource.com/660411Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Jun Cai <juncai@chromium.org> Cr-Commit-Position: refs/heads/master@{#501317}
-
James Forshaw authored
This reverts commit 251a3311. Reason for revert: People building with actual VS2015 according to the official instructions don't have the definitions for some of the AC functions. I'd argue they shouldn't be building with that but it seems that it's part of the official instructions. Reverting for now. Original change's description: > Implemented changes to Sid class for AC support. > > This CL implements changes to the sandbox Sid class to support the creation > of Capability Sid objects. It also contains a few refactoring efforts to > cleanup up older code. > > Bug: 760977 > Cq-Include-Trybots: master.tryserver.chromium.win:win10_chromium_x64_rel_ng > Change-Id: Id9c05b8017abb81896c1bc30f23599441812d1fd > Reviewed-on: https://chromium-review.googlesource.com/649026 > Commit-Queue: James Forshaw <forshaw@chromium.org> > Reviewed-by: Will Harris <wfh@chromium.org> > Reviewed-by: Penny MacNeil <pennymac@chromium.org> > Cr-Commit-Position: refs/heads/master@{#501229} TBR=pennymac@chromium.org,forshaw@chromium.org,wfh@chromium.org Change-Id: Icafd0c2281d8442562fc24c869ca88595277f065 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 760977 Cq-Include-Trybots: master.tryserver.chromium.win:win10_chromium_x64_rel_ng Reviewed-on: https://chromium-review.googlesource.com/663698Reviewed-by:
James Forshaw <forshaw@chromium.org> Commit-Queue: James Forshaw <forshaw@chromium.org> Cr-Commit-Position: refs/heads/master@{#501316}
-
Irmak Kavasoglu authored
This cl completes the password selection feature functionality for linux/chromeos/windows platforms. Now we are actually saving the selected password when user clicks save button. Bug: 753806 Change-Id: Ia61c2f49bf43b4c7fc456cb99ed0eb5582e89df5 Reviewed-on: https://chromium-review.googlesource.com/663317 Commit-Queue: Irmak Kavasoğlu <irmakk@google.com> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#501315}
-
Alex Moshchuk authored
All but two of these tests appear to be now passing. Bug: 174705, 242167, 84719, 241245, 242196, 241164, 243648, 169622, 232340, 763808 Change-Id: I50732446c54a1de54b3b6a233650855e7f785742 Reviewed-on: https://chromium-review.googlesource.com/661997 Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#501314}
-
kylechar authored
This CL makes CompositorFrameSinkSupport into a mojom::CompositorFrameSink. CompositorFrameSinkSupport already implements the interface so this is a trivial change. This CL also replaces CompositorFrameSinkSupportClient with mojom::CompositorFrameSinkClient. The two interfaces were almost identical, minus WillDrawSurface() method, which was only used in DelegatedFrameHost. WillDrawSurface() is replaced with a callback. This simplifies [Root]CompostiorFrameSinkImpl. CompositorFrameSinkImpl only needs to hold the Binding/InterfacePtr and delegate calls into CompositorFrameSinkSupport. The client can be passed in directly. This CL also cleans up test implementations of CompositorFrameSink[Support]Client. Bug: 762743 TBR: weiliangc@chromium.org Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ib4f1fd6a22badce9ae77a7bb484c6ab465e4d7c5 Reviewed-on: https://chromium-review.googlesource.com/641990 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#501313}
-
Koji Ishii authored
Collapsed spaces are defined as "zero advance width, invisible, but retains its soft wrap opportunity". When the first space does not create break opportunities, collapsed spaces should create one. Example: <span nowrap>a </span> b The space before "b" is collapsed, but needs to create a break opportunity, because the space after "a" does not. This patch improves following tests, though they fail for other reasons. fast/text/whitespace/inline-whitespace-wrapping-3.html fast/text/whitespace/inline-whitespace-wrapping-4.html fast/text/whitespace/inline-whitespace-wrapping-5.html [1] https://drafts.csswg.org/css-text-3/#collapse Bug: 636993 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I5dd0468909f28c7db610c115fdaece4418ba86c8 Reviewed-on: https://chromium-review.googlesource.com/660937Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#501312}
-
Jun Cai authored
Currently there are radian and degree conversion constants in both generic_sensor_consts.h and orientation_util.h. This CL moves them to generic_sensor_consts.h. Bug: None Change-Id: I7de69b7e9536bb003158ab9d3611ec9a621211fc Reviewed-on: https://chromium-review.googlesource.com/661077 Commit-Queue: Jun Cai <juncai@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#501311}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e3965fde..00f454c9 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org Change-Id: I6fb4cdadad58665dbf973f6b66353a7f6e45a235 Reviewed-on: https://chromium-review.googlesource.com/663238Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#501310}
-
dpapad authored
Bug: None Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I5ea2f55259f3d4edd6335248f45d3bb5f3a0b83b Reviewed-on: https://chromium-review.googlesource.com/661719Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#501309}
-
Brett Wilson authored
The context information is set by PartitionAlloc to save some extra context for the allocation. This is written to the "types" field of the trace. Since the number of parameters to the Export functions was getting high, this moves most of them into a struct where they can be named. Currently, no grouping by allocator is done, this will be done in a followup. Bug: 763173 Change-Id: Id690a4012855c1714d6e6984436fda2bc8367eab Reviewed-on: https://chromium-review.googlesource.com/661893 Commit-Queue: Brett Wilson <brettw@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#501308}
-
Pavel Kalinnikov authored
This is necessary to share the enum with U2F over BLE implementation. Bug: 763303 Change-Id: Id31326c6cd42e0027de7e6c788c7e24b3795faa9 Reviewed-on: https://chromium-review.googlesource.com/659817 Commit-Queue: Pavel Kalinnikov <pkalinnikov@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#501307}
-
Theresa Wellington authored
* Fixes bug where button appearance animation run at incorrect time * Restricts location bar width when hiding tab switcher button on NTP * Fixes offset for RTL location bar animation BUG=730550 Change-Id: I8e9abfef1872d2a6951c2cc94537ebd9dd97625f Reviewed-on: https://chromium-review.googlesource.com/662243Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#501306}
-
Chandan Padhi authored
This CL replaces GURL with url::Origin as |security_origin|'s type. Bug: 683115 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation Change-Id: I852bbd7e55ae210f32875408c6400e2057df7c5f Reviewed-on: https://chromium-review.googlesource.com/643346Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Chandan Padhi <c.padhi@samsung.com> Cr-Commit-Position: refs/heads/master@{#501305}
-
Ryan Sturm authored
Bug: Change-Id: I29b9c78a9e23afa819fe7d4ebf96ede206a1ac91 Reviewed-on: https://chromium-review.googlesource.com/661577Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#501304}
-
John Chen authored
ChromeDriver relies on the user-data-dir switch for its operations, and ignores attempts by the client to exclude this switch. This CL adds a warning message if the client attempts to exclude user-data-dir. Bug: chromedriver:1981 Change-Id: I733f16fbdb6bea5dcf130ce7ad97664036f689be Reviewed-on: https://chromium-review.googlesource.com/662598 Commit-Queue: John Chen <johnchen@chromium.org> Reviewed-by:
Shuotao Gao <stgao@chromium.org> Cr-Commit-Position: refs/heads/master@{#501303}
-
Helen Li authored
Use JUnit4 for UploadDataProvidersTest. Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester Change-Id: I511a999a02a91d1f9c1f4ca076b96a4bc986d854 Reviewed-on: https://chromium-review.googlesource.com/663401 Commit-Queue: Helen Li <xunjieli@chromium.org> Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Cr-Commit-Position: refs/heads/master@{#501302}
-
sebsg authored
Bug: 764338 Tbr: oshima@chromium.org, reveman@chromium.org Change-Id: I8057386a40ee245786bd4a424e9f456aeee87673 Reviewed-on: https://chromium-review.googlesource.com/663560Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#501301}
-
Gauthier Ambard authored
To hide the ink on the empty items, ContentSuggestions was using a transparent color for the ink instead of not starting the animation due to an MDC bug. As the bug is fixed, the correct method can be used. Bug: 724493 Change-Id: Id4a63ddcc9977b9c017f882bcf17c2a026ee13b2 Reviewed-on: https://chromium-review.googlesource.com/663340Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#501300}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/ff72a0857f4d..74dac545488c $ git log ff72a0857..74dac5454 --date=short --no-merges --format='%ad %ae %s' 2017-09-11 stephana Make output of all tests verbose Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=stephana@chromium.org Change-Id: I2338f153c51a8a07d4c6a67559a2615425a7abda Reviewed-on: https://chromium-review.googlesource.com/663658Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#501299}
-
Gauthier Ambard authored
The users were not classified by NTP usage. This is needed to adjust fetching interval and metrics. Bug: 764257 Change-Id: I647b331332aa39237791667f9a43d9b34c445005 Reviewed-on: https://chromium-review.googlesource.com/663339Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#501298}
-
Xiaocheng Hu authored
TextIterator currently may add two consecutive newlines after an H4, H5 or H6 element, while the spec of innerText doesn't have this case at all. This patch removes the extra newline to make TextIterator more spec-complicant. Note: TextIterator should eventually remove double newline emission also for H1~3. This patch removes it only for H4~6 to keep the amount of rebaselined tests small. Bug: 752672,758816 Change-Id: I32583c194a829f52411555125e77590e36ccf838 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Reviewed-on: https://chromium-review.googlesource.com/661937Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#501297}
-
Peter Beverloo authored
BUG= Change-Id: Ib353c4cc5ae0fcbca4f9f5b69961a7c31edcdcf9 Reviewed-on: https://chromium-review.googlesource.com/657279 Commit-Queue: Peter Beverloo <peter@chromium.org> Reviewed-by:
John Mellor <johnme@chromium.org> Reviewed-by:
Nicolas Zea <zea@chromium.org> Cr-Commit-Position: refs/heads/master@{#501296}
-
Gauthier Ambard authored
When the user scrolls with voice over activated, the scroll is done by increasing the collection scroll by the height of the collection view. As the collection is displaying the fake omnibox as an overlay, the content hidden by the omnibox is not taken into account by the default computation. This CL fixes it by taking it into account. Bug: 763940 Change-Id: I3111037cbee73521096bbe9dbe264d809ac5088c Reviewed-on: https://chromium-review.googlesource.com/660220Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#501295}
-
Devlin Cronin authored
Extract a RendererMessagingService base class that can be used with both JS-based and native extension bindings. Pull out the logic that will be common to both implementations and put it in the base class, and have JSRendererMessagingService retain the JS-specific implementation logic. Bug: 653596 Change-Id: I6ccc81f45a32b4f83d75b34941fed73d9ee857de Reviewed-on: https://chromium-review.googlesource.com/658496 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#501294}
-
Ella Ge authored
spec: https://drafts.csswg.org/css-ui-3/#cursor 1. When cursor:auto, cursor should be "text" over selectable text, default otherwise. Changed SelectAutoCursor and ShouldShowIBeamForNode to match spec. Use UA stylesheet to achieve different cursor on different element. (browser default behavior) 2. When cursor:text, use VerticalTextCursor when vertical-text. 3. Show pointer cursor when mouse hovering resizers no matter what cursor style set for its owner element. 4. When selecting anchor text, use I-beam when style cursor:pointer, otherwise keep style cursor. Bug: 737452 Change-Id: I71e0a63b1518cde261755c9339eb62f8e3e2c21f Reviewed-on: https://chromium-review.googlesource.com/600252 Commit-Queue: Ella Ge <eirage@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by:
nainar <nainar@chromium.org> Cr-Commit-Position: refs/heads/master@{#501293}
-
smcgruer authored
This change adds a WorkletAnimation object accessible in the main js scope, when the CompositorWorker (the old name for AnimationWorklet) Blink runtime feature is enabled. WorkletAnimation objects are hooked up to the document's animation lifecycle, owned by a WorkletAnimationController. The controller will attempt to start them on the compositor, but this currently fails due to lack of support in the animation logic. BUG=720080 Review-Url: https://chromiumcodereview.appspot.com/2869183002 Cr-Commit-Position: refs/heads/master@{#501292}
-