- 30 Nov, 2017 40 commits
-
-
Herb Derby authored
This reverts commit 270b4e2b. Reason for revert: causes msan regression in fuzzer BUG=789812 TBR=danakj@chromium.org Original change's description: > Turn on new image blur for chrome. > > BUG=472742 > > Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel > Change-Id: Iddaaf37132faf2698c09ae0851c741fb78d97656 > Reviewed-on: https://chromium-review.googlesource.com/791010 > Reviewed-by: danakj <danakj@chromium.org> > Reviewed-by: Florin Malita <fmalita@chromium.org> > Commit-Queue: Herb Derby <herb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#519831} TBR=danakj@chromium.org,fmalita@chromium.org,herb@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 472742 Change-Id: Ia7a31e8ec46679b69e2bad02896921da45dc279a Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/801150 Commit-Queue: Herb Derby <herb@chromium.org> Reviewed-by:
Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#520628}
-
Alexander Timin authored
R=skyostil@chromium.org BUG=699541 Change-Id: I8809b1f1486a6d92be56deaee7e135540cc0c03f Reviewed-on: https://chromium-review.googlesource.com/800639Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#520627}
-
Benoît Lizé authored
85023f02 rolled clang past r318199 adding an option to insert instrumentation calls after inlining. This drastically decreases the instrumented build size: before: -rwxr-x--- 1 lizeb eng 257M Nov 29 14:20 libchrome.so* after: -rwxr-x--- 1 lizeb eng 67M Nov 29 14:49 libchrome.so* This should reduce compilation time on the orderfile bot. Bug: 776702 Change-Id: I37549e5f6611286ff09238d428b05458f8f2397c Reviewed-on: https://chromium-review.googlesource.com/796478Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Egor Pasko <pasko@chromium.org> Reviewed-by:
Matthew Cary <mattcary@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#520626}
-
Chandan Padhi authored
media_devices.mojom is moved from //content to //WebKit/public to allow MediaDevicesDispatcherHost mojom interface's access from Blink. This CL is the first step towards migration of MediaDevices.enumerateDevices() processing from content to Blink. Bug: 764680 Change-Id: I2abdf63b7601cc24aa74434384cd0b7d28d69656 Reviewed-on: https://chromium-review.googlesource.com/790119Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Chandan Padhi <c.padhi@samsung.com> Cr-Commit-Position: refs/heads/master@{#520625}
-
Peng Huang authored
This CL adds a PresentationCallback for gl::GLSurface::SwapBuffers, gl::GLSurface::PostSubBuffer, etc. This callback is used for getting presentation information (timestamp for when the buffer is presented on screen, etc). This CL also plumbs the presentation information from GLSurface to viz::Display to trigger FrameSink presentation feedbacks. Bug: 776877 Test: Tested with wayland_rects_client which uses FrameSink presentation feedback. Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ifefc21fd1e88ebaea083760115a55ab0033573ce Reviewed-on: https://chromium-review.googlesource.com/741451Reviewed-by:
Brian Anderson <brianderson@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Biao She <bshe@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#520624}
-
Devlin Cronin authored
Currently, native extension bindings use the same method to execute script whether or not JS is suspended at the time. The difference instead is that we expect JS to finish synchronously in the sync case. This is nice, because it means that we never circumvent script suspension. Unfortunately, this is insufficient. We need to execute script synchronously in order to respond to certain JS calls, and script can be running at multiple times even though JS is suspended (though it perhaps shouldn't be). Instead, change RunJSFunctionSync() to use APIs that guarantee script execution (WebLocalFrame::CallFunctionEvenIfScriptDisabled and v8::Function::Call). Since these should only be used in response to direct JS entry points, this shouldn't introduce any new areas of running script while suspended. Bug: 786957, 653596 Change-Id: Ibc2f066bd562ab071dbd7cb2bd7de7b46d9d6892 Reviewed-on: https://chromium-review.googlesource.com/786894 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#520623}
-
Robert Sesek authored
Bug: 598854 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: If8a541dbd650663d255c04b8bd70bbf0f8d8342e Reviewed-on: https://chromium-review.googlesource.com/794541Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#520622}
-
bsheedy authored
Makes the VR FYI bot upload its results to the chromium-result-details bucket (same as other tests on other bots) so we can get logcat output and post-failure screenshots. Bug: Change-Id: I67f8615ae4184b864f8557821b798d1ae75d2bee Reviewed-on: https://chromium-review.googlesource.com/798396Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#520621}
-
Philip Jägenstedt authored
There is no spec for this, but an old open spec issue: https://github.com/whatwg/fullscreen/issues/15 Bug: 787867 Change-Id: Icde796405fca96e910480aef6f0d6be835f7a27a Reviewed-on: https://chromium-review.googlesource.com/788052 Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#520620}
-
Antoine Labour authored
At this point it's only used to get to the IO thread, pass that explicitly instead. Bug: 566273 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I374215f47024361af958ca0c94250949920f1bd0 Reviewed-on: https://chromium-review.googlesource.com/797917Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#520619}
-
Robert Liao authored
Now that WebRTC has disabled these hooks we can fail builds that previously patched COM. This ensures that the hook is running where we expect it to run instead of failing silently. BUG=737090 Change-Id: I28b6f8203ecff3c3f54396848a70c78a17c9055e Reviewed-on: https://chromium-review.googlesource.com/801250Reviewed-by:
Scott Graham <scottmg@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#520618}
-
Katie Dektar authored
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I982ee390c102a32d4c3813027d124cca5fb2a3b4 Reviewed-on: https://chromium-review.googlesource.com/801113Reviewed-by:
-
David Dorwin authored
Change-Id: Id83e00d500fff45c00d1e648715741ba1f71be03 Reviewed-on: https://chromium-review.googlesource.com/795315Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
-
xlai authored
Bug: 776826 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I4c1d8898a5a983fc0368e792620696f5d90d788b Reviewed-on: https://chromium-review.googlesource.com/800750 Commit-Queue: Olivia Lai <xlai@chromium.org> Reviewed-by:
Justin Novosad <junov@chromium.org> Cr-Commit-Position: refs/heads/master@{#520615}
-
Nate Chapin authored
This removes the sole purpose of ScriptResourceClient, so change its user to just be plain ResourceClients. Bug: 789198 Change-Id: Id72163ad4c7e81492e9f74fa5f1ee68d2b510215 Reviewed-on: https://chromium-review.googlesource.com/792253Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#520614}
-
Evgene Gubernatorov authored
R=wez@chromium.org,rsesek@chromium.org Bug: 772552 Change-Id: I666f2ae1ea4a423250b53715b2957d3a87165935 Reviewed-on: https://chromium-review.googlesource.com/787891Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#520613}
-
rbpotter authored
Bug: 773928 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I55754b306707a8f4a7b32c30c5596263925359a9 Reviewed-on: https://chromium-review.googlesource.com/794433 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#520612}
-
Luis Hector Chavez authored
In order to reduce the number of base::Bind/base::Callback uses added to the codebase while we are in the process of a migration, we can add a global PRESUBMIT.py hook to nudge people to use the new interfaces. Bug: 714018 Test: git cl try Change-Id: I60741a1532a060fc75f3aeb1533e88abbdf9cfe7 Reviewed-on: https://chromium-review.googlesource.com/794879Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Taiju Tsuiki <tzik@chromium.org> Commit-Queue: Luis Hector Chavez <lhchavez@chromium.org> Cr-Commit-Position: refs/heads/master@{#520611}
-
Mike West authored
Bug: 788936 Change-Id: Icd4e22745561d57c691fd0f0e75bb8c3e4a59303 Reviewed-on: https://chromium-review.googlesource.com/795717 Commit-Queue: Mike West <mkwst@chromium.org> Reviewed-by:
nainar <nainar@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#520610}
-
kapishnikov authored
BUG=706515 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I4e5a3fb4b42c8367abb0e46d8f5383950442e064 Reviewed-on: https://chromium-review.googlesource.com/801050Reviewed-by:
Misha Efimov <mef@chromium.org> Reviewed-by:
Andrei Kapishnikov <kapishnikov@chromium.org> Commit-Queue: Andrei Kapishnikov <kapishnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#520609}
-
Ivan Sandrk authored
Bug: Change-Id: I2325e83ced67c5388a36d38790ba6e366152bc8f Reviewed-on: https://chromium-review.googlesource.com/793711Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Ivan Šandrk <isandrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#520608}
-
Gauthier Ambard authored
The toolbar's buttons are updated on screen rotation. In particular their alpha value is set to 1 even if the omnibox is focused. It displays the back/forward button as they are hidden during the animation of the omnibox focus. This CL fixes it by not updating the alpha value if the omnibox is focused. Bug: 788816 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I604126cb2f80095f35229c0a3c2ae1a14deb3225 Reviewed-on: https://chromium-review.googlesource.com/796071 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#520607}
-
Gary Kacmarcik authored
This is requires so that the clipboard code can access the Permission methods (since core/ can't reach into modules/). Permission checks will be added in a follow-up cl. Bug: 677564 Change-Id: Ia5dbf39a05ab5acb0b0aa5504bdf8a783751a6fb Reviewed-on: https://chromium-review.googlesource.com/798125Reviewed-by:
-
Nasko Oskov authored
When over the process limit, same-site navigations in new tabs (ctrl+click, middle click, context menu "open in new tab") should try to reuse an existing process suitable for hosting the initial target of the navigation. This CL fixes the current behavior by creating a SiteInstance for the URL the new tab is created with. Bug: 774723 Change-Id: I2e35b7bc1d62826a9a220f2e021c6119d9abcccf Reviewed-on: https://chromium-review.googlesource.com/794952Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
-
Michael Giuffrida authored
Adds unit tests that simulate tab activity and test the UKMs logged by TabMetricsLogger. Bug: 784639 Change-Id: Id5854b3e2b38b98ecc3d654ac93a24578e26ae3d Reviewed-on: https://chromium-review.googlesource.com/791868 Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/e053e0fd169a..646257d65c65 $ git log e053e0fd1..646257d65 --date=short --no-merges --format='%ad %ae %s' 2017-11-30 dsinclair Run clang-tidy google-readability-casting on //third_party/pdfium 2017-11-30 dsinclair Run clang-tidy modernize-use-nullptr on //third_party/pdfium 2017-11-30 jose.dapena GCC build fix: access from global function to private methods in CJS_PublicMethods. 2017-11-30 jose.dapena Add LG Electronics to the AUTHORS 2017-11-30 dsinclair Run clang-tidy modernize-use-bool-literals on //third_party/pdfium 2017-11-30 dsinclair Run clang-tidy modernize-use-auto on //third_party/pdfium 2017-11-30 dsinclair Run clang-tidy modernize-use-equals-{delete,default} on //third_party/pdfium Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Id46ddaa6bda8deb93cd88350e2d743c71609cc68 Reviewed-on: https://chromium-review.googlesource.com/801190 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#520603}
-
Kevin Bailey authored
Bottom wasn't lined up. Bug: 780835 Change-Id: Id4f7dcc4d590e2f5f3f83457cea2095e7a1011cf Reviewed-on: https://chromium-review.googlesource.com/800791Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#520602}
-
danakj authored
If gpu compositing is disabled globally, or for a single compositor, don't make contexts and don't give them to the ui::Compositor so it knows to generate software resources. R=kylechar@chromium.org Bug: 730660 Change-Id: I192934b798e0ab81b39231066ff80fbc2f3f0774 Reviewed-on: https://chromium-review.googlesource.com/797444Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#520601}
-
kapishnikov authored
[delegate_ totalBytesReceivedPerTask][task] returns a NSNumber that should be converted to integer for proper printing. BUG=706515 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I57c7ecea727a13ef5a79a205dee1c134dfe93eea Reviewed-on: https://chromium-review.googlesource.com/797952Reviewed-by:
-
Mihai Sardarescu authored
This CL uses the /signin/chrome/sync Gaia endpoint when signing in to Chrome when DICE is enabled. Bug: 789578 Change-Id: Ide40f5b7cc1d3f34f07a482f369d6826c1e2ca29 Reviewed-on: https://chromium-review.googlesource.com/800619 Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
-
kapishnikov authored
It is not entirely correct to use "<" to compare number of failed requests. E.g. it will always fail if the total number of requests is '1'. If the total number of requests is 3 then no failures are tolerated while one should be allowed. BUG=706515 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I77469141d5b789ca793a1cf8c3a79a9de5206a84 Reviewed-on: https://chromium-review.googlesource.com/800973 Commit-Queue: Andrei Kapishnikov <kapishnikov@chromium.org> Reviewed-by:
-
Marc Treib authored
This includes DefaultSearchProviderInstantURL, DefaultSearchProviderInstantURLPostParams, and DefaultSearchProviderSearchTermsReplacementKey. These all haven't had any effect for a while, so let's mark them as such. Bug: 476079 Change-Id: I168dfd781e4a2eaa0e69855e7ba7fc875e5bb83c Reviewed-on: https://chromium-review.googlesource.com/785933Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#520597}
-
Dave Tapuska authored
The fake mouse move event gets fired for mojo input messages and causes the layout test to be flaky. Ensure we have a spacer so that the hover events that the fake mouse move generate are contained in there. BUG=789485 Change-Id: I3a6d659e9f51906536333f78fa32cf40e4ad99c6 Reviewed-on: https://chromium-review.googlesource.com/797850Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#520596}
-
Joe Mason authored
Move the behaviour controlled by ExperimentalSwReporterEngine and ExperimentalSwReporterEngineOnAllArchitectures outside the feature checks so it is always on. The exception is the "tag" parameter which is used in testing so must still be set through a feature until the test scripts are updated. Bug: 786964 Change-Id: I06bd7a599b3ab61121daca939d3df60967b3c0e6 Reviewed-on: https://chromium-review.googlesource.com/779302 Commit-Queue: Joe Mason <joenotcharles@chromium.org> Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#520595}
-
John Abd-El-Malek authored
Add a unit test to ensure that if RESOURCE_TYPE_PREFETCH is specified in content::ResourceRequest, it's translated into the proper net:: flag on URLRequest. The test is for the network service case. The old navigation code path has this covered already in RequestDataResourceDispatcherHostBrowserTest.LinkRelPrefetch. The motivation is to convert a few prefetch browser tests from checking the URLLRequest object (which won't work with network service) to instead look at the ResourceRequest object. Also de-duplicate BuildLoadFlagsForRequest. BUG=776589 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I29a66944d17a7e99b2bacbcb0766fa1b1174bd57 Reviewed-on: https://chromium-review.googlesource.com/797926Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#520594}
-
Peter Qiu authored
Bug: 789688 Test: manual Change-Id: I5821af5fd79931197dad45b13b365e909c83a0a4 Reviewed-on: https://chromium-review.googlesource.com/798016Reviewed-by:
Christian Fremerey <chfremer@chromium.org> Commit-Queue: Peter Qiu <zqiu@chromium.org> Cr-Commit-Position: refs/heads/master@{#520593}
-
Gheorghe Comanici authored
This CL adds a fallback to display MostVisited URLs when personalized zero-query is enabled with ChromeHomePersonalizedOmniboxSuggestions but the user is not signed-in. TBR=rohitrao for mechanical changes to ios/c/b/a/* Bug: 781994 Change-Id: Id4f46c74115d88003d34df9e6b93190cf4c97368 Reviewed-on: https://chromium-review.googlesource.com/796451 Commit-Queue: Gheorghe Comanici <gcomanici@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#520592}
-
dpapad authored
This also allows for some simplifications - No longer need to specify --cr-toolbar-field-width. - Removed unnecessary dev-controls div wrapper. Bug: 788981 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ie9425e3eaecde952dff93a7d1af483abc98518e1 Reviewed-on: https://chromium-review.googlesource.com/797935Reviewed-by:
Dave Schuyler <dschuyler@chromium.org> Reviewed-by:
-
xlai authored
Bug: 787972 Change-Id: Ie0cc0594451cbab0d46320d5997813596c442270 Reviewed-on: https://chromium-review.googlesource.com/788280 Commit-Queue: Olivia Lai <xlai@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
-
Becca Hughes authored
Add an "autoplay" feature that controls autoplay and delegate activation state through frames. BUG=788390 TBR=skyostil@chromium.org,iclelland@chromium.org Change-Id: I67e40ae00b0ca7acad7bbef4b4cb4525a9e65fb3 Reviewed-on: https://chromium-review.googlesource.com/800851 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
-
