GitLab

BUG=666616

Review-Url: https://codereview.chromium.org/2522313003
Cr-Commit-Position: refs/heads/master@{#434734}

Adding EmbeddedTestServer handlers after the server has started isn't
thread safe.

This CL fixes the threading issues by either starting the server after
the handlers are added or by splitting the server start into two phases.
This is needed when the server's base URL is required for registering
the handlers.

BUG=546060

Review-Url: https://codereview.chromium.org/2522283002
Cr-Commit-Position: refs/heads/master@{#434733}

BUG=652332

Review-Url: https://codereview.chromium.org/2528553002
Cr-Commit-Position: refs/heads/master@{#434732}

Use an int instead of a StaticAtomicSequenceNumber to generate the ids for
the gpu memory buffers. This should be sufficient since this is used only
in the same thread.

BUG=none

Review-Url: https://codereview.chromium.org/2532763003
Cr-Commit-Position: refs/heads/master@{#434731}

This adds signature validation for the component cloud policy
(e.g. policy for extensions). The signature is validated against
the same key that is used for the "superior" policy (e.g. the
user policy, the device local account policy, etc.).

This CL also adds keeping a copy of the most recent component
cloud policy and rechecking it when some of the credentials
change. This allows to handle key rotations gracefully: even
though the component cloud policy may fail the validation
immediately after the cloud policy refresh with the rotated key,
it will be re-validated and applied when the superior policy gets
processed and the credentials get propagated.

BUG=644632
TEST=existing tests (now with the signature checks enabled),
     new unit tests and new browser test

Review-Url: https://codereview.chromium.org/2493603002
Cr-Commit-Position: refs/heads/master@{#434730}

https://pdfium.googlesource.com/pdfium.git/+log/e421327725da..c92e26defaa6

$ git log e42132772..c92e26def --date=short --no-merges --format='%ad %ae %s'
2016-11-28 npm Merge CPDF_ImageLoader with its handle
2016-11-28 npm Nits in fx_ge_linux
2016-11-28 npm Fix leak in cpdf_document_unittest

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2539513002
Cr-Commit-Position: refs/heads/master@{#434729}

Both type name and stack deduplicators need to estimate their memory
overhead. Previously they were using simplistic models and estimated
only half of their actual memory usage. This CL changes estimation
methods to use EstimateMemoryUsage(), resulting in better accuracy.

Review-Url: https://codereview.chromium.org/2514913002
Cr-Commit-Position: refs/heads/master@{#434728}

The DCHECK was mostly benign, though Chrome would close the socket
without waiting for a response to its QUIT messages, which has unclear
consequences.

BUG=668759

Review-Url: https://codereview.chromium.org/2532873003
Cr-Commit-Position: refs/heads/master@{#434727}

* When making a function to get offline pages using query public, we
  missed making it run only when the model is loaded.
  This patch fixes that by deferring the actually execution after the
  model is loaded.

BUG=668174

Review-Url: https://codereview.chromium.org/2536573003
Cr-Commit-Position: refs/heads/master@{#434726}

BUG=546953

Review-Url: https://codereview.chromium.org/2534873002
Cr-Commit-Position: refs/heads/master@{#434725}

It is no longer possible to explicitly construct and destroy surfaces. A
SurfaceFactory instance now handles only one surface at a time. Once the
local frame id passed to SubmitCompositorFrame changes, the factory gets
rid of the old surface and creates a new one.

BUG=658607

Committed: https://crrev.com/b902fd366ba91757dbee99d5f821f00d2de1d181
Cr-Commit-Position: refs/heads/master@{#432312}
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2485473003
Cr-Commit-Position: refs/heads/master@{#434724}

The Bar has main bar text that can either show the Search Term or the
Context.  When the user taps we show the Context first, and the Search
Term is not yet visible, so calculations based on its size are invalid.

We now check to see if the Search Term text is visible before using any
attribute of it.

BUG=658771

Review-Url: https://codereview.chromium.org/2518503004
Cr-Commit-Position: refs/heads/master@{#434723}

This CL creates a content_renderer service manifest overly for android_webview
to enable autofill mojo interfaces to be accessed well from content_browser
service.

BUG=662040

Review-Url: https://codereview.chromium.org/2523193002
Cr-Commit-Position: refs/heads/master@{#434722}

Just as with the client group the window_manager group should include
most of the client interfaces.

BUG=none
TEST=none
R=sadrul@chromium.org, tsepez@chromium.org

Review-Url: https://codereview.chromium.org/2528983002
Cr-Commit-Position: refs/heads/master@{#434721}

It was removed upstream in a few months ago in rL268670
(https://reviews.llvm.org/D19892)

No behavior change.

BUG=none

Review-Url: https://codereview.chromium.org/2530413003
Cr-Commit-Position: refs/heads/master@{#434720}

Revert of Improve fallback for Burmese with leading punctuation + spacing mark (patchset #3 id:30009 of https://codereview.chromium.org/2530153002/ )

Reason for revert:
This seems to be causing test failures for fast/text/international/text-spliced-font.html on https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win10/builds/17622

Original issue's description:
> Improve fallback for Burmese with leading punctuation + spacing mark
>
> Issue 618178 describes an example where a Burmese text run starts with a
> leading punctuation character followed by a combining spacing mark. This
> grapheme cannot be shaped with the default font, since Times for example
> cannot display the combination of a left quote with a Burmese combining
> mark. Our fallback code attempts to find a fallback font based on the
> first character at the beginning of an extracted unshaped sub-run, which
> does not lead to finding a font suitable for Myanmar text in this case.
> So in a way it runs into a fallback trap, where no fallback hint helps
> to find the right fallback font and the whole run ends up as notdef
> glyphs.
>
> This CL attempts to resolve this by looking for a better fallback hint
> character, which is not script common or inherited, if such is
> available. This improves the situation for the Burmese text from the
> issue report.
>
> In addition, as a better fix we should give higher importance to the
> locale information in font fallback, filed as issue 668706.
>
> BUG=618178
> R=eae,kojii,behdad
>
> Committed: https://crrev.com/d9280a5e951415e1b2c6c7958adda19b731a99fa
> Cr-Commit-Position: refs/heads/master@{#434665}

TBR=behdad@chromium.org,eae@chromium.org,kojii@chromium.org,drott@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=618178

Review-Url: https://codereview.chromium.org/2532253002
Cr-Commit-Position: refs/heads/master@{#434719}

This patch fixes an issue where the first enumeration of USB devices on
Linux would only return a single device and observers would not be
notified of additional devices. This was because the logic to determine
if enumeration callbacks should be called was checking only that all
previously seen devices (of which there was only one at that point) were
ready and not that the sysfs tree had been completely walked.

BUG=662486

Review-Url: https://codereview.chromium.org/2523403002
Cr-Commit-Position: refs/heads/master@{#434718}

BUG=666450

Review-Url: https://codereview.chromium.org/2535773004
Cr-Commit-Position: refs/heads/master@{#434717}

These are from two recent CLs:
https://codereview.chromium.org/2463953002
https://codereview.chromium.org/2494553002

Note: This CL is a test of the WPT export process. Do not make changes
in LayoutTests/imported/wpt/ without coordination or changes may be
lost.

BUG=657117

Review-Url: https://codereview.chromium.org/2509983007
Cr-Commit-Position: refs/heads/master@{#434716}

StreamTextureHost is always created with a valid |route_id|, and it also
does not handle OnChannelError().

This change removes the useless |route_id| checks, sets |channel_| to
nullptr when OnChannelError() is called, and adds appropriate |channel_|
null checks.

This change also removes raw pointers from StreamTextureProxy, to fix
style conformance and StreamTextureHost ownership clearer.

BUG=667162

Review-Url: https://codereview.chromium.org/2530443002
Cr-Commit-Position: refs/heads/master@{#434715}

Usually custom tabs force-load URLs or redirects to URLs that can be
handled by apps inside custom tabs. For instant-apps enabled clients
override the default behaviour and launch the instant app, if possible.

BUG=659301

Review-Url: https://codereview.chromium.org/2532223002
Cr-Commit-Position: refs/heads/master@{#434714}

Neither dvh@ nor grv@ still work on Chromium.

BUG=None

Review-Url: https://codereview.chromium.org/2533033002
Cr-Commit-Position: refs/heads/master@{#434713}

Currently, when we create the Physical Web data source, we do not
populate it with any initial data, which can lead to onLosts occuring
when there has not even been an onFound.  This change call onFound for
currently known URLs when first creating the data source.

BUG=667754

Review-Url: https://codereview.chromium.org/2521333002
Cr-Commit-Position: refs/heads/master@{#434712}

BUG=666630

Review-Url: https://codereview.chromium.org/2517693002
Cr-Commit-Position: refs/heads/master@{#434711}

This patch fixes spellcheck caching in the following case:
1. paragraph is edited by removing text from the back and
2. paragraph does not contain misspelled words.

Currently this case results in a cache miss and consequently
spellcheck requests being sent to the spellchecking service
while completely unnecessary. This fix applies to all
platforms.

This patch also adds a few unit tests for the relevant
caching specific behavior.

BUG=664247,629609

Review-Url: https://codereview.chromium.org/2494123002
Cr-Commit-Position: refs/heads/master@{#434710}

Also fixed and reenabled the fullscreen test in BrowserWindowControllerBrowserTest

BUG=599119, 643418

Review-Url: https://codereview.chromium.org/2516803002
Cr-Commit-Position: refs/heads/master@{#434709}

Remove superfluous closeUI call from onDismiss, this is
already done in disconnectFromClientWithDebugMessage.

BUG=587995

Review-Url: https://codereview.chromium.org/2536783002
Cr-Commit-Position: refs/heads/master@{#434708}

Move struct VideoFrameInfo from content/common/video_capture.mojom to
media/capture/mojo/video_capture_types.mojom. This will allow us to use the
struct in code that transports frames through the browser-process. This will,
in turn, allow us to (in a later CL) switch between the existing in-process
implementation and the new Mojo service.

This CL is part of the Mojo Video Capture work. For the bigger picture,
see [1] CL1.9.6

BUG=584797
TEST=video_capture_unittests, content_unittests, capture_unittests

[1] https://docs.google.com/a/chromium.org/document/d/1Qw7rw1AJy0QHXjha36jZNiEuxsxWslJ_X-zpOhijvI8/edit?usp=sharing

Review-Url: https://codereview.chromium.org/2524103002
Cr-Commit-Position: refs/heads/master@{#434707}

Remove the restriction that, under certain conditions, we require
the protocol of an auto-created custom search engine be HTTP.  The
condition has no connection with a need for privacy.  There is no
problem with creating custom search engines for secure sites.  In
fact, we should be encouraging more sites to be secure, not penalizing
those that do so by making it more difficult for them to create a
custom search engine.

BUG=642848
TEST=amazon.com now gets a custom search engine created

Review-Url: https://codereview.chromium.org/2505933005
Cr-Commit-Position: refs/heads/master@{#434706}

Revert of ImageCapture: move image_capture.mojom from media/mojo/interfaces/ to media/capture/mojo/ (patchset #2 id:40001 of https://codereview.chromium.org/2526953002/ )

Reason for revert:
imagecapture layout tests started failing in https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.9/builds/40056

Original issue's description:
> ImageCapture: move image_capture.mojom to media/capture/mojo/
>
> This CL moves image_capture.mojom from media/mojo/interfaces/ to
> media/capture/mojo/ where it belongs logically speaking, and
> updates BUILD.gns and include paths.
>
> image_capture.mojom was in media/mojo/interfaces because
> when it landed, media/capture/mojo was not existing.
>
> BUG=518807
> TEST=No code touched, if compile passes, it works
> (but there's also content_browsertests).
>
> TBR=xhwang@chromium.org for the removal in media/mojo/interfaces/BUILD.gn
>
> Committed: https://crrev.com/d7c801bb7ed0393d1634e547a696ced5040bc93c
> Cr-Commit-Position: refs/heads/master@{#434675}

TBR=mkwst@chromium.org,chfremer@chromium.org,jochen@chromium.org,tsepez@chromium.org,mcasas@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=518807

Review-Url: https://codereview.chromium.org/2537573002
Cr-Commit-Position: refs/heads/master@{#434705}

Revert of Disable dromaeo.jslibmodifyjquery on Windows (patchset #1 id:1 of https://codereview.chromium.org/2529673003/ )

Reason for revert:
Re-enable tests as we fixed a problem with wrapper tracing.

Original issue's description:
> Disable dromaeo.jslibmodifyjquery on Windows
>
> R=sullivan@chromium.org
> BUG=668164
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq
>
> Committed: https://crrev.com/98679f8f94d5beb4b7a0715edef85f8ba250f34b
> Cr-Commit-Position: refs/heads/master@{#434268}

TBR=sullivan@chromium.org,fmeawad@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=668164
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq

Review-Url: https://codereview.chromium.org/2532653002
Cr-Commit-Position: refs/heads/master@{#434704}

https://pdfium.googlesource.com/pdfium.git/+log/0354ccf37f05..e421327725da

$ git log 0354ccf37..e42132772 --date=short --no-merges --format='%ad %ae %s'
2016-11-28 npm Replace ASSERT with error return in bmp_read_header

BUG=659497

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2530373004
Cr-Commit-Position: refs/heads/master@{#434703}

So far, passing a function or function pointer to a check such as DCHECK_EQ
would cause the values to be implicitly converted to bool, resulting in a
confusing message like this

    Check failed: x == y (1 vs. 1)

instead of

    Check failed: x == y (0x779410 vs. 0x778fe0)

Add a specific overload for functions and function pointers that explicitly
cast them to const void* to have them call the right operator<< overload.

This fixes warnings on both new GCC versions (-Waddress complains that passing a function or function pointer to operator<< would always become '1') and clang on Windows (see https://bugs.chromium.org/p/chromium/issues/detail?id=550065#c12).

BUG=550065
R=danakj@chromium.org,thakis@chromium.org,jbroman@chromium.org

Review-Url: https://codereview.chromium.org/2515283002
Cr-Commit-Position: refs/heads/master@{#434702}

BUG=630464

Review-Url: https://codereview.chromium.org/2502153002
Cr-Commit-Position: refs/heads/master@{#434701}

BUG=661676

Review-Url: https://codereview.chromium.org/2528793002
Cr-Commit-Position: refs/heads/master@{#434700}

Because of a missing 's' the generated client API was always considered out of
date.

BUG=669077

Review-Url: https://codereview.chromium.org/2531363002
Cr-Commit-Position: refs/heads/master@{#434699}

Add a watch list definition for Generic Sensor API [1] implementation updates.

[1] ED specification: https://w3c.github.io/sensors/

NOTRY=True

Review-Url: https://codereview.chromium.org/2526253002
Cr-Commit-Position: refs/heads/master@{#434698}

BUG=542537

Review-Url: https://codereview.chromium.org/2536513002
Cr-Commit-Position: refs/heads/master@{#434697}

Chrome currently leaves the alert around which causes subsequent commands to fail.

https://buganizer.corp.google.com/u/0/issues/6507465#comment12
BUG=chromedriver:877

Review-Url: https://codereview.chromium.org/1827003004
Cr-Commit-Position: refs/heads/master@{#434696}

BUG=

Review-Url: https://codereview.chromium.org/2530373003
Cr-Commit-Position: refs/heads/master@{#434695}