- 02 Jul, 2018 40 commits
-
-
Yutaka Hirano authored
It's needed to workaround the DISALLOW_NEW_EXCEPT_PLACEMENT_NEW annotation for ResourceResponse, which is unproductive. This CL also adds some const qualifiers to express invariants. Bug: 570946 Change-Id: I05a13178253b66267ea91652f2f32636df98cbbb Reviewed-on: https://chromium-review.googlesource.com/1122142Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#572023}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/4d01146f1679..312466a20450 git log 4d01146f1679..312466a20450 --date=short --no-merges --format='%ad %ae %s' 2018-07-02 buildbot@webrtc.org Roll chromium_revision c2072685..a1981d69 (571826:571936) 2018-07-02 qingsi@google.com Add ADAPTER_TYPE_ANY in AdapterType. 2018-07-02 yinwa@webrtc.org In ULP FEC fuzzer test, make sure sequence number is not the same as previous sequence number. Created with: gclient setdep -r src/third_party/webrtc@312466a20450 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:None,chromium:859265 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ibe3ca6c450a7f021ed739daea306e9fc9f395562 Reviewed-on: https://chromium-review.googlesource.com/1123079Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#572022}
-
spqchan authored
Test is flaky on Nexus 5X TBR=perezju@chromium.org Bug: 859500 Change-Id: Ide9926b503a4f2b7faeaba3791694cff69b0cf81 Reviewed-on: https://chromium-review.googlesource.com/1123260 Commit-Queue: Sarah Chan <spqchan@chromium.org> Reviewed-by:
Sarah Chan <spqchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#572021}
-
Peter Kasting authored
* During tab closure, don't modify whether the favicon is centered. This prevents the favicon from appearing to slide left at the very end of tab closure. * When closing a tab, keep its left edge pinned to the right edge of the previous tab (to the degree currently possible; this goes awry when closing multiple tabs, see comments in code), instead of closing it wherever it is. * When opening or closing a tab, make the narrowest width the overlap width instead of zero. This ensures the opened/closed tab animates its bounds at the same speed as the surrounding tabs. * When opening a tab, start with its left edge at the current right edge of the previous tab, instead of the ideal right edge. This way when a tab is opened to the right of an existing tab that's shrinking to give it room, the new tab appears to expand into the available space instead of being overlapped in a strange way. * In AnimateToIdealBounds(), skip any views already animating to their updated ideal bounds. This prevents hitches and discontiguous appearance when e.g. moving the mouse out of the strip while animating. Bug: none Change-Id: I8f87c9585dda778fafc53b8f38a7a475c107059b Reviewed-on: https://chromium-review.googlesource.com/1121793 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#572020}
-
Stuart Langley authored
Some cleanup work for chrome/browser/chromeos/drive briging it in line with recomended practices/c++ modernization. - Use ThreadChecker macros. - s/DCHECK(!callback.is_null())/DCHECK(callback)/ Ths CL introduces no logic changes. Bug: 841659 Change-Id: I5a5784d2de7d8f1be0e6240414d7c64c921d3cff Reviewed-on: https://chromium-review.googlesource.com/1122029Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#572019}
-
Stuart Langley authored
$ /usr/local/google/code/llvm/tools/clang/tools/extra/clang-tidy/tool/run-clang-tidy.py \ -p ../.. \ -clang-tidy-binary /usr/local/google/code/build/bin/clang-tidy \ -clang-apply-replacements-binary /usr/local/google/code/build/bin/clang-apply-replacements \ -checks=-*,modernize-use-equals-default,modernize-use-emplace \ -header-filter= \ -fix chrome/browser/chromeos/drive $ git cl format No logic changes in this cl. Bug: 841659 Change-Id: Ie62dcf1cf34065d88cc31dfae481fbb7fa90ef9e Reviewed-on: https://chromium-review.googlesource.com/1122017Reviewed-by:
-
perfetto-chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/b56a7a2a1a62..ce3f7b384d77 git log b56a7a2a1a62..ce3f7b384d77 --date=short --no-merges --format='%ad %ae %s' 2018-07-02 oysteine@google.com Merge "Chrome: Export needed symbols to avoid direct external dependencies on protozero files" 2018-07-02 oysteine@google.com Chrome: Export needed symbols to avoid direct external dependencies on protozero files Created with: gclient setdep -r src/third_party/perfetto@ce3f7b384d77 The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:78791178 TBR=perfetto-bugs@google.com Change-Id: I9762f57d69803411eca9b5bc6095bdfb05c0f0cf Reviewed-on: https://chromium-review.googlesource.com/1123277 Reviewed-by: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#572017}
-
tzik authored
This CL replaces MockTimer with MockOneShotTimer or MockRepeatingTimer as a preparation of OnceCallback support of base::Timer. Also, this CL fixes unneeded usages of |retain_user_task| flag. Bug: 850247 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I04ab3df4e85cdf28ca2585f455f79ab9336f585e Reviewed-on: https://chromium-review.googlesource.com/1114560Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#572016}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/d38a2da9f150..605dd3126a6c git log d38a2da9f150..605dd3126a6c --date=short --no-merges --format='%ad %ae %s' 2018-07-02 dproy@chromium.org Format typescript with git cl format --js Created with: gclient setdep -r src/third_party/depot_tools@605dd3126a6c The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I62ae3a741366ec348b4cf5e897bce3fd22dbdbc5 Reviewed-on: https://chromium-review.googlesource.com/1123078Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#572015}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/9626d3959de1..b71f42943166 git log 9626d3959de1..b71f42943166 --date=short --no-merges --format='%ad %ae %s' 2018-07-02 dgarrett@google.com chromeos_config: Move release builders to swarming. Created with: gclient setdep -r src/third_party/chromite@b71f42943166 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:853969 TBR=chrome-os-gardeners@chromium.org Change-Id: I65d05628ef596e7b01a804289e9501916f7cf7e9 Reviewed-on: https://chromium-review.googlesource.com/1123276Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#572014}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/319ef06b2f69..61ff9b659a5b git log 319ef06b2f69..61ff9b659a5b --date=short --no-merges --format='%ad %ae %s' 2018-07-02 tsepez@chromium.org Comment some raw pointers that cant become UnownedPtr<>. Created with: gclient setdep -r src/third_party/pdfium@61ff9b659a5b The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: If0b12b245ecfd8035f39592e67a1bc72b2e2b6d1 Reviewed-on: https://chromium-review.googlesource.com/1123081Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#572013}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 2fcc6147. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/20621 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=kereliuk No-Export: true Change-Id: Id65756fe2f776c20e0d0616fbdf5d24f5e8ba296 Reviewed-on: https://chromium-review.googlesource.com/1123168 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#572012}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2309ee36a10b..5155d38fdcd4 git log 2309ee36a10b..5155d38fdcd4 --date=short --no-merges --format='%ad %ae %s' 2018-07-02 skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll skia/third_party/skcms 14ea609fa6ca..99b01c076f47 (1 commits) 2018-07-02 fmalita@chromium.org [skottie] Add support for comp time remapping 2018-07-02 skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll skia/third_party/skcms 4268c0b12bf2..14ea609fa6ca (1 commits) Created with: gclient setdep -r src/third_party/skia@5155d38fdcd4 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ethannicholas@chromium.org Change-Id: I2ba79adf65c09a6404907ecaf183a8a6a7e4c7d0 Reviewed-on: https://chromium-review.googlesource.com/1123080Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#572011}
-
Ben Pastene authored
TBR=jbudorick@chromium.org Bug: 836447 Change-Id: Ief0cbfbfe135265115d46e777d7701fe9515d485 Reviewed-on: https://chromium-review.googlesource.com/1123113Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#572010}
-
Peter Kasting authored
The change in bounds_animator.cc looks scary (because it casts away const), but is actually safe; view bounds are (correctly) stored in the data map as pointer-to-non-const (since the animator will change the views' positions), but this prevents lookup into the map by pointer-to-const. The const cast allows lookup, and the explicit use of find() instead of [] ensures the function is actually const. Bug: none Change-Id: I3c217fc6ca931f6113cd661f1beeeb7e0a697475 Reviewed-on: https://chromium-review.googlesource.com/1121784 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#572009}
-
Peter Kasting authored
This ensures these tests are testing the actual harmony/refresh behavior, and makes sure as people add more calls to ChromeLayoutProvider to the code they don't result in unexpected test crashes. Bug: none Change-Id: If21b7eec387dc47be448e2dbb2730ddacb7b51fe Reviewed-on: https://chromium-review.googlesource.com/1121787 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#572008}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/39f347b1..3166e28a Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Icf6fea49532b41f9222cbdbe840f09ca97ca4da9 Reviewed-on: https://chromium-review.googlesource.com/1123173Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#572007}
-
John Budorick authored
was implicit previously, leading to the weird "... on Linux" step text on browser_tests. TBR=martiniss@chromium.org Bug: 855301 Change-Id: I06e927a6c60f0d8d296370a756496a73e0aa03b1 Reviewed-on: https://chromium-review.googlesource.com/1121831Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#572006}
-
Sky Malice authored
Strongly own the UserClassifier in the FeedSchedulerHost, allowing ShouldRefresh() and IsContentStale() to perform meaningful logic. Some functionality that was added in previous CLs gets better testing now that decisions have thresholds they're compared against. Bug: 831648 Change-Id: Ie215332bbc9654f3a58b20f5f462bbc0a8c0b523 Reviewed-on: https://chromium-review.googlesource.com/1105388 Commit-Queue: Sky Malice <skym@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#572005}
-
Ned Nguyen authored
NOTRY=true # test by PRESUBMIT TBR=eyaich@chromium.org Bug: 857395 Change-Id: I2f8038451a7669f162efdbbe0388a705c7f88407 Reviewed-on: https://chromium-review.googlesource.com/1123270Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#572004}
-
Theresa authored
Add a feature flag that controls whether opting out of EoC is enabled. The opt-out is enabled by default so that users in our live experiment groups don't lose their ability to opt-out. When experimentation configurations are updated, we will have the ability to disable the opt-out for new groups. Also fixes a bug where the toolbar button incorrectly started showing up on all tabs after opting out. BUG=859564 Change-Id: Ib0e5f90a0f3c80a928688ddd8bb33036b7b5e247 Reviewed-on: https://chromium-review.googlesource.com/1123098Reviewed-by:
Becky Zhou <huayinz@chromium.org> Reviewed-by:
-
Chris Harrelson authored
This reverts commit 1a41279a. virtual/threaded/animations/cancel-unattached-animation.html was failing because PaintLayerCompositor::CanBeComposited has an early out if the LocalFrameView's IsVisible bit is false. When that bit changes, compositing inputs need to re-computed, to get a correct value for PaintLayer::DescendantHasDirectOrScrollingCompositingReason. Bug: 859304,856808 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I4eb61112f3d396df1361486007c6efd2c6f7b339 Reviewed-on: https://chromium-review.googlesource.com/1123027Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#572002}
-
Eric Roman authored
Change the order of path building attempts in CertVerifyProcBuiltin to favor certificates with strong signature algorithms, even if that means needing to chase AIA. The initial attempts at path building for EV and DV now disallow SHA1, which forces path building to consider AIA. In the absence of a strong certificate chain, a weaker one will still be returned as before. Bug: 845652 Change-Id: Ibfb16fd266b3aa03708fd8d33d0716af31273612 Reviewed-on: https://chromium-review.googlesource.com/1091798 Commit-Queue: Eric Roman <eroman@chromium.org> Reviewed-by:
Matt Mueller <mattm@chromium.org> Reviewed-by:
Doug Steedman <dougsteed@chromium.org> Cr-Commit-Position: refs/heads/master@{#572001}
-
Peter Kasting authored
The separation into different helpers was obscuring a lot of code duplication. This de-dupes things and will make it easier to fix some bugs in tab insertion/closing. Bug: none Change-Id: I8b26a1f973f8b2ce6c4bebcc0168f5c2dfcfb880 Reviewed-on: https://chromium-review.googlesource.com/1121789Reviewed-by:
-
Yannic Bonenberger authored
This CL adds a rewriter to //tools/clang/base_bind_rewriters which removes calls to base::AdaptCallbackForRepeating when the returned base::RepeatingCallback is immediately converted to a base::OnceCallback. Change-Id: I14ca9af2b3abc095b978c2cd7cf1fea1844ef428 Reviewed-on: https://chromium-review.googlesource.com/817740 Commit-Queue: Yannic Bonenberger <contact@yannic-bonenberger.com> Reviewed-by:
Taiju Tsuiki <tzik@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#571999}
-
Xi Cheng authored
Bug: 851163 Change-Id: Id21482d92a93c79097caae6f9de8bbc5d524dde0 Reviewed-on: https://chromium-review.googlesource.com/1123074Reviewed-by:
Mike Wittman <wittman@chromium.org> Commit-Queue: Xi Cheng <chengx@chromium.org> Cr-Commit-Position: refs/heads/master@{#571998}
-
Charlie Andrews authored
As decided in https://goo.gl/g5Srzn, the low number of regressions caught by the power metrics alone doesn't justify the high cost of maintaining the BattOrs on the waterfall. Bug: 859514 Change-Id: I012e2692963c30793b6843e2844d77cdf75d7d3e Reviewed-on: https://chromium-review.googlesource.com/1122485 Commit-Queue: Charlie Andrews <charliea@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#571997}
-
spqchan authored
TBR=carlosk@chromium.org Bug: 859616, 859617, 859615 Change-Id: Ibc6fd6db390a7e3a42dd9cc929efb7a079ac9a37 Reviewed-on: https://chromium-review.googlesource.com/1123222Reviewed-by:
-
Philip Rogers authored
Link highlights have two cc::Layers: one for clipping and one for the contents. The clip layer is unused today and may have never been implemented (see: original patch without clip support [1]). [1] https://chromium.googlesource.com/chromium/src/+/7baf240818b3b0c1be0ea64209881b8cebded493 Bug: 857501 Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I1261c1ccbb9b81534ca0db5bcbc369d73ca00173 Reviewed-on: https://chromium-review.googlesource.com/1121694Reviewed-by:
Tien-Ren Chen <trchen@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#571995}
-
Xiaocheng Hu authored
Currently, LayoutNG hit test code uses FallbackAccumulatedOffset() to calculate the |accumulated_offset| parameter at two places: 1. When falling back to LayoutBox::HitTestAllPhases/NodeAtPoint 2. When falling back to LayoutInline::HitTestCulledInline However, the parameter actually has different semantics in the two legacy functions. This makes the function complicated and hard to modify. This patch breaks the function, which results in simplification at both fallback sites. Besides, it also fixes the offset calculation at the first site in 'vertical-rl' writing mode, making two layout tests pass. Bug: 855279, 856730 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Iaa59cbfbb2396f2df7c1550fca45eb4ae84e3052 Reviewed-on: https://chromium-review.googlesource.com/1119639 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#571994}
-
Alex Newcomer authored
Add a NotificationItemView::NotificationItemViewDelegate, which: - Activates notifications. - Acts as the SlideOutController::Delegate. - Allows for easier testing of NotificationMenuView. Make NotificationMenuController a NotificationItemViewDelegate. Pass NotificationMenuController AppMenuModelAdapter: - Allows NotificationMenuController to close the menu. Also added tests. Bug: 843761 Change-Id: I20474838a0fb5360196a3d0585b7e84620b86e9f Reviewed-on: https://chromium-review.googlesource.com/1120842 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#571993}
-
Greg Kraynov authored
- Private constructor for ref-counted class. - Remove redundant includes. - Minor style fixes and TODOs. - Add platform_export.h where needed. Bug: 783309 Change-Id: I14cc00ef31526ae76f692fd48e3045fa483edb13 Reviewed-on: https://chromium-review.googlesource.com/1122976Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Greg Kraynov <kraynov@chromium.org> Cr-Commit-Position: refs/heads/master@{#571992}
-
Greg Kraynov authored
Bug: 783309 Change-Id: I92091b358d312b12c9fd88f26b4763dc984a6b33 Reviewed-on: https://chromium-review.googlesource.com/1122870 Commit-Queue: Greg Kraynov <kraynov@chromium.org> Reviewed-by:
-
Aleks Totic authored
Bug: 819372 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I8e1dfc647673327587fbc5505488a68ebc62e139 Reviewed-on: https://chromium-review.googlesource.com/1123170 Commit-Queue: Aleks Totic <atotic@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#571990}
-
Tien-Ren Chen authored
Replaced contents are clipped by the content box. Normally this is not an issue because we size the contents layer of a directly composited replaced element to the clipped area. However in the case of a clip with rounded corner, a clip still needs to be applied. Previously we incorrectly applied the main layer state to its contents layer, which did not include the rounded corner clip. This CL corrects that. BUG=853943 Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Id9a1a10e651ff2be73d43471ce94d85daf082f67 Reviewed-on: https://chromium-review.googlesource.com/1121538Reviewed-by:
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/a14d6738e1fb..153acbd707c0 git log a14d6738e1fb..153acbd707c0 --date=short --no-merges --format='%ad %ae %s' 2018-07-02 thomasanderson@chromium.org Remove manual reference to exe_and_shlib_deps Created with: gclient setdep -r src/third_party/catapult@153acbd707c0 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:845700 TBR=sullivan@chromium.org Change-Id: If682edec4b9cced3c22128c14c89fde52554cc11 Reviewed-on: https://chromium-review.googlesource.com/1123136Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#571988}
-
Corentin Wallez authored
BUG=chromium:852089 Change-Id: Ie4222eb6ef0056a060a5101dae1ecdd04c091fbf Reviewed-on: https://chromium-review.googlesource.com/1096289 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#571987}
-
Tarun Bansal authored
This CL adds WPT tests for http-equiv accept-ch header: (1) The header is not honored on HTTP pages (2) Malformed header is not honored (3) When the header is present, client hints are attached only on the same-origin subresources, and not on cross-origin subresources in the same navigation. (4) When the header is present, client hints are attached only on the same origin subresources, and not on subresources in a new navigation. Bug: 856700 Change-Id: I3f82df8cd02816b06542256062eb291577ebe8b7 Reviewed-on: https://chromium-review.googlesource.com/1120953 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:Yoav Weiss <yoav@yoav.ws> Cr-Commit-Position: refs/heads/master@{#571986}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/e353d72449a9..319ef06b2f69 git log e353d72449a9..319ef06b2f69 --date=short --no-merges --format='%ad %ae %s' 2018-07-02 tsepez@chromium.org Add pdfium::Vector2D<>() Created with: gclient setdep -r src/third_party/pdfium@319ef06b2f69 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: If115371f4c97a14e7e8b96d64bdf6103755fac95 Reviewed-on: https://chromium-review.googlesource.com/1122878Reviewed-by:
-
spqchan authored
TBR=carlosk@chromium.org Bug: 859605 Change-Id: I8a4c2d01321437cb5c9386f1f2195b2761b8c413 Reviewed-on: https://chromium-review.googlesource.com/1123110Reviewed-by:
-
