- 25 Jun, 2020 40 commits
-
-
Rachel Wong authored
Previously, if Suggested Content was disabled, old results would still appear in the cache. This change ensures that results cache is always cleared. Change-Id: If9e09c95e65ff9b731195da5832803ee7505d956 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264182Reviewed-by:
Jia Meng <jiameng@chromium.org> Commit-Queue: Rachel Wong <wrong@chromium.org> Cr-Commit-Position: refs/heads/master@{#782221}
-
Tanya Gupta authored
Change-Id: Ie55e5d1b1bdb972db055ecb6e7c28b23badc22b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265432Reviewed-by:
Kyle Milka <kmilka@chromium.org> Commit-Queue: Tanya Gupta <tgupta@chromium.org> Cr-Commit-Position: refs/heads/master@{#782220}
-
Mohamed Heikal authored
This reverts commit 8a3e6a28. Reason for revert: Revert before next branch cut, was only required for a cherry-pick to M84 Original change's description: > Rollback protobuf lite runtime to 3.0.1 > > As a temporary fix for android webview regression b/157318961 this cl > rolls back the protobuf lite runtime to 3.0.1 using the codegen plugin. > > Binary-Size: This is temporary and there is not really much we could do. > Bug: 1093059, b/157318961 > Change-Id: I2bbaf6d3b434221b667901423c4616e26a7550c5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238872 > Reviewed-by: Dan H <harringtond@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: Yaron Friedman <yfriedman@chromium.org> > Commit-Queue: Mohamed Heikal <mheikal@chromium.org> > Cr-Commit-Position: refs/heads/master@{#777495} TBR=yfriedman@chromium.org,agrieve@chromium.org,mheikal@chromium.org,harringtond@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1093059, b/157318961 Change-Id: Ieda4530327ff3de513601ae3fe0ad5e9c99eeed0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264466Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Dan H <harringtond@chromium.org> Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#782219}
-
Caroline Rising authored
This also hides the pin button from the extensions menu as well as the pin option for an extension's context menu. Bug: 943702 Change-Id: Ib489b5dd55d2e94ffcee511bb625662bdbe1c259 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261354 Commit-Queue: Caroline Rising <corising@chromium.org> Reviewed-by:
Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#782218}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/054aeeed3b4c..18d412cba8ce 2020-06-25 jdarpinian@chromium.org Fix readBuffer validation If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cwallez@google.com Change-Id: I93088a6aeea57037a5e84809bd7b2b08fde553ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265560Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#782217}
-
Darwin Huang authored
Add logging for read and write with the platform clipboard. This logs all reads and writes, as well as their formats, that go through Chrome and hit the clipboard, from all endpoints (context menu, shortcut, web APIs, etc). This may be useful for determining usage of various formats and their change over time. An enumeration is used to understand which format is used for each read or write. Function calls for NOTIMPLEMENTED() reads or writes are not logged. The following clipboards are also omitted, as these don't really reflect use on "real" platforms: - TestClipboard[1], which is used for automated web / WPT tests, and the MockClipboardHost. - HeadlessClipboard[2], which is used for Selenium, Puppeteer, and other automated, non-UI platforms[3]. [1]: https://cs.chromium.org/chromium/src/ui/base/clipboard/test/test_clipboard.h [2]: https://cs.chromium.org/chromium/src/headless/lib/browser/headless_clipboard.h [3]: https://developers.google.com/web/updates/2017/04/headless-chrome Bug: 1079036 Change-Id: Ia90c447018221a839842497896cdc1b8f8d13e09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255741 Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#782216}
-
Timothy Loh authored
The change in https://crrev.com/c/2249239 was accidentally removed in https://crrev.com/c/2249245 due to a bad rebase. This CL relands it. Bug: 1094946, 1094944 Change-Id: I8ff7523933203c225b5befe70f20be664ab26a8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264181 Auto-Submit: Timothy Loh <timloh@chromium.org> Reviewed-by:
Jason Lin <lxj@google.com> Commit-Queue: Jason Lin <lxj@google.com> Cr-Commit-Position: refs/heads/master@{#782215}
-
Alexandre Courbot authored
The V4L2 video decoder "slice" name is a relic from the time this decoder could only handle stateless decoders. Now that it can handle both types, rename it a something more generic and accurate. BUG=b:149663704 TEST=VDAtest --use_vd runs on Hana-kernelnext. Change-Id: If516bb0fbf5c245a131feaefbf550affcc4f6fe5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2262753 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Chih-Yu Huang <akahuang@chromium.org> Reviewed-by:
David Staessens <dstaessens@chromium.org> Reviewed-by:
Fritz Koenig <frkoenig@chromium.org> Cr-Commit-Position: refs/heads/master@{#782214}
-
jameshollyer authored
The change makes the RenderWidgetMouseLockDispatcher::SendLockMouseRequest function bind the RenderWidgetMouseLockDispatcher::OnLockMouseACK to be called when the request is fulfilled. Previously it bound the Parent classes OnLockMouseACK function which stopped the WebWidget from being notified. Bug: 1098093 Change-Id: I367d84ad69997b8de81c629d1ddc7efd5ca47b6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258954 Commit-Queue: James Hollyer <jameshollyer@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#782213}
-
Henrique Nakashima authored
WebContentsStateBridge#createHistoricalTab() can be accomplished by calling other methods: - WebContentsStateBridge#restoreContentsFromByteBuffer() - WebContentsStateBridge#createHistoricalTabFromContents() - WebContents#destroy() Replace it with these calls. Bug: 1090048 Change-Id: I048f2aca26af8be92dfe450c124435264fb8c750 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265133Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#782212}
-
Eric Willigers authored
ChromeLauncherControllerWebAppTest tests ChromeLauncherController with a web app. This reverts commit d975d2ed and relands https://chromium-review.googlesource.com/c/chromium/src/+/2247992 The MSAN AssistiveWindowControllerTest unit test failure https://bugs.chromium.org/p/chromium/issues/detail?id=1096592 has been fixed by an unrelated CL: https://chromium-review.googlesource.com/c/chromium/src/+/2251862 Bug: 1087686 Change-Id: Ia7c432562933e06f696e1dbf5704f9727881d7b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264178 Commit-Queue: Dominick Ng <dominickn@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#782211}
-
Varun Khaneja authored
The feature continues to be disabled by default for mobile platforms. Bug: 1044212 Change-Id: Ia4e1056a9c54786071d236a0df007060b8faf287 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264797 Auto-Submit: Varun Khaneja <vakh@chromium.org> Commit-Queue: Bettina Dea <bdea@chromium.org> Reviewed-by:
Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/master@{#782210}
-
Xing Liu authored
Adds the "ask when to download" setting in download setting page. Bug: 1078454 Change-Id: I8974413fc720694ca1cb39cd3ba740d47c480e6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265174 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#782209}
-
Kyle Horimoto authored
Previously, a query for "Google" would only show results related to the Google Assistant. This CL downgrades the default ranking for several of these search tags so that other Google-related content is surfaced. Fixed: 1096809 Change-Id: I75c2ade1a5997742fa18840a2d81e5ca112ccf40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265438 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#782208}
-
Alexandre Courbot authored
The new VD-based video decoder was initially built to support stateless (slice-based) decoders, but it is now able to handle both stateless and stateful ones now. Rename its source files to a shorter and more accurate name. BUG=b:149663704 TEST=VDAtest --use_vd runs on Hana-kernelnext. Change-Id: Ief2250ee88d7c64a5b98b3dd57cef61e861a9eb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2262752 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Chih-Yu Huang <akahuang@chromium.org> Reviewed-by:
David Staessens <dstaessens@chromium.org> Reviewed-by:
Fritz Koenig <frkoenig@chromium.org> Cr-Commit-Position: refs/heads/master@{#782207}
-
Scott Violet authored
This makes text-to-speech stop if the hosting WebContents is hidden, which differs from Clank (Clank stops when all activities are hidden). I think stopping when hidden is good for the current use case, but will need to be revisted at some point. BUG=1025626 TEST=wpt tests should cover this Change-Id: I631da77676f7822583e379cf2e51d5534d8199cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264621 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#782206}
-
Nico Weber authored
I want to use this to make the new fyi bot use the 11 SDK. Downstream projects will have to add 'mac_xcode_version': 'default', to the `vars = {` section of their toplevel DEPS section to roll in build/ with this change. Bug: 1098738,1098454 Change-Id: I3939da4c83d733c6c08deded4520e824dbd89043 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264867 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#782205}
-
Mounir Lamouri authored
The flag was technically removed but some crumbs stayed behind. Bug: None Change-Id: Iceff8d8a307761d3829cd59ee9144e85d1d7a4a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261692 Commit-Queue: David Trainor <dtrainor@chromium.org> Auto-Submit: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#782204}
-
Scott Violet authored
This changes the following: . only start utterances that were created from a WebContents if the WebContents still exists and is not hidden. . stop utterances if the WebContents is destroyed. . Makes TtsPlatformImpl.java work without ApplicationStatus. ApplicationStatus is not used in webview/weblayer. . Adds the ability to stop speaking if the hosting WebContents is hidden. I will make this the default in WebLayer, where there is no ApplicationStatus and it's not as clear that speaking should continue if the WebContents is hidden. Patch that enables TTS for WebLayer is here: https://chromium-review.googlesource.com/c/chromium/src/+/2264621 BUG=1025626 Change-Id: I061cadfb50c35dff64a76e2b9953ef60aff36bc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261098 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Katie Dektar <katie@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#782203}
-
Mike Dougherty authored
The flaky part of this test is the same implementation as the other tests in this file. The test is not flaky locally. Re-enable the test, but also improve error logging to better debug this issue if it re-occurs. Fixed: 1098758 Change-Id: I9f09329f155a9b0824b88ed05cea4801cf6195b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264625 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Auto-Submit: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#782202}
-
Ben Pastene authored
Accidentally used 'betty-arc-r' when adding the configs in crrev.com/c/2258681 instead of the correct 'eve-arc-r' board. Whoops. This replaces the typos. Bug: 1092973 Change-Id: Id4cc7d116cda526dfd3de4232b90041b20f71830 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264948 Commit-Queue: Ben Pastene <bpastene@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Auto-Submit: Ben Pastene <bpastene@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#782201}
-
Yoshifumi Inoue authored
This patch changes "editing/deleting/delete-line-011.html" to utilize |selection_test()| for ease of maintenance and enabling EditingNG. Bug: 679977, 707656 Change-Id: Idea7bfc5d30c9b6b1b33ccc07928097347299127 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2262078 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#782200}
-
Owen Rodley authored
These are currently in Gatekeeper. The Gatekeeper version will be removed once this is live. Bug: 1094768 Change-Id: Iceac783b4d307c1a09655dba7f901683b994e2ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2262554Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Auto-Submit: Owen Rodley <orodley@chromium.org> Cr-Commit-Position: refs/heads/master@{#782199}
-
Daniel Hosseinian authored
On some platforms, printing backends may have printer settings that are intended to be sent during print jobs, but those are currently dropped. Place those settings/options in the job settings in the |advanced_settings| field and send them in Linux print jobs. That way the lpoptions can be sent. Bug: 466717 Change-Id: I9950cd352dad00897d8378df24d405c6b6341525 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240282Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#782198}
-
Becca Hughes authored
This is a reland of 30e7e503 TBR=ellyjones@chromium.org,dcheng@chromium.org,huangs@chromium.org,steimel@chromium.org Original change's description: > [Kaleidoscope] Add native parts to OSS repo > > Add the Kaleidoscope native parts to the OSS repo. > > BUG=1044741 > > Change-Id: I8562c8e35db2d1fa0ef8ce140ddbbc57ca7a9991 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255563 > Commit-Queue: Becca Hughes <beccahughes@chromium.org> > Reviewed-by: Samuel Huang <huangs@chromium.org> > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Tommy Steimel <steimel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#782073} Bug: 1044741 Change-Id: I469ed19af1e056f7b62c7abc764933e707b94e94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264608Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#782197}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/d626fbec817d..dd834a700e0c 2020-06-24 rwkeane@google.com Force CodeCoverage Full Build If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: I637f1398cc26ec2c048e232586f67193c83a90b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265572Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#782196}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1593028798-f93250a81e374d70a67d584bcb245354b4612f62.profdata to chrome-win64-master-1593032304-90202fa1b4038f00c77b47bcef25599006092a46.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I50212f1398d264f073ea14d49fc2a3c178c9420f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265557Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#782195}
-
Fergal Daly authored
All uses of it are for main frame. We do not want any new uses of it, so renaming makes things clearer. Also, add a DCHECK to enforce it. Change-Id: I7c34f4b6bc7bbf3f02572a684aeb3ecb34e090c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2263512Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Auto-Submit: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#782194}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I0ec739e8176d747c5b6fee4d4052e0e9a066d90b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265485Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#782193}
-
Chong Gu authored
Disable failing test. Bug: 1058255 Change-Id: I608bd247ee19cfdabb972e5f8dc6122286d4c703 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264937 Commit-Queue: Chong Gu <chonggu@google.com> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#782192}
-
Daniel Hosseinian authored
The Epson "Ink" PPD attribute is causing bloated monochrome print jobs. Temporarily remove support until a fix is found. Bug: 1081705 Change-Id: I9f45384ece665209e27489b847ad57849ba1321c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265436Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#782191}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2639a144ff41..34878824fc18 2020-06-24 michaelludwig@google.com Revert "Implement Skottie vs Lottie perf tool" 2020-06-24 bsalomon@google.com Add another make_get_error_with_random_oom valgrind suppression 2020-06-24 egdaniel@google.com Revert "Make glPatchParameteri required when tessellation is supported" 2020-06-24 michaelludwig@google.com Revert "Simplify GrClip API" 2020-06-24 jmbetancourt@google.com update gradle version for android projects 2020-06-24 senorblanco@chromium.org Fix RTHeight for SkRuntimeEffectSimple case. 2020-06-24 egdaniel@google.com Fix d3d PromiseImageTest 2020-06-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll dawn from 92379bff49c2 to 8ab3719fc486 (2 revisions) 2020-06-24 brianosman@google.com Reland "Remove SkSpecialImage::makeTextureImage" 2020-06-24 johnstiles@google.com Add support for magenta highlights on shader mouseover in Metal. 2020-06-24 stani@google.com Implement Skottie vs Lottie perf tool 2020-06-24 michaelludwig@google.com Revert "simplify freeAll" 2020-06-24 rmistry@google.com Update path to fix Android ASAN bots 2020-06-24 bsalomon@google.com Add GrContext::oomed() and implement for GL and VK. 2020-06-24 johnstiles@google.com Fix crash in Viewer when attempting to view shaders in Metal. 2020-06-24 johnstiles@google.com Rename MakeResult so that it can be used more broadly. 2020-06-24 robertphillips@google.com Add GM::gpuSetup call in fm 2020-06-24 michaelludwig@google.com Simplify GrClip API 2020-06-24 robertphillips@google.com Misc changes to get *ooprdll configs running 2020-06-24 mtklein@google.com update ApplyMatrix signature 2020-06-24 egdaniel@google.com Make sure we hold refs to sampled textures in d3d. 2020-06-24 robertphillips@google.com Revert "Ignore calls to freeGpuResources on abandoned contexts" 2020-06-24 brianosman@google.com Revert "Remove SkSpecialImage::makeTextureImage" 2020-06-24 jvanverth@google.com Disable one more D3D test 2020-06-24 robertphillips@google.com Update viewer to call the gpuSetup GM entry point 2020-06-24 kjlubick@google.com [canvaskit] High performance Path APIs 2020-06-24 fmalita@google.com Reland "[skottie] skottie_tool updates" 2020-06-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 9daab8cbffb7 to 1496de215a39 (13 revisions) 2020-06-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 9167e1e22a46 to eb0a25a189b7 (3 revisions) 2020-06-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from adf736e2 to 66992a84 (532 revisions) 2020-06-24 fmalita@chromium.org [skrive] Parse ellipse data 2020-06-24 reed@google.com add simple pathbuilder 2020-06-23 brianosman@google.com Supply device and local coords to SkShader_Base::onProgram 2020-06-23 scroggo@google.com Roll NDK to r21d 2020-06-23 jvanverth@google.com Adjust which Direct3D tests are disabled 2020-06-23 jvanverth@google.com Disable PromiseImageTextureShutdown test for D3D 2020-06-23 herb@google.com make internal shared methods 2020-06-23 csmartdalton@google.com Make glPatchParameteri required when tessellation is supported 2020-06-23 herb@google.com simplify freeAll 2020-06-23 brianosman@google.com Remove SkSpecialImage::makeTextureImage 2020-06-23 kjlubick@google.com [demos] Move to subdir If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC lovisolo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1093997,chromium:812428 Tbr: lovisolo@google.com Test: Test: ran run_perf.sh and it outpus perf metrics Change-Id: I5a5830bbcac8ef05570c7f5de4467985b290934d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264930Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#782190}
-
Haiyang Pan authored
This reverts commit 25269f24. Reason for revert: test testSetUp_SuppressingSignInPromo fails constantly in android-arm64-proguard-rel (and fyi builder android-marshmallow-x86-fyi-rel) since * https://ci.chromium.org/p/chromium/builders/ci/android-arm64-proguard-rel/2020 * https://ci.chromium.org/p/chromium/builders/ci/android-marshmallow-x86-fyi-rel/767 Original change's description: > [HomepagePromo] Add finch param supressing_sign_in_promo > > Adding the option for homepage promo to suppress the sign in promo when > user is not signed in. > > Bug: 1068831 > Change-Id: I854109c4623c47f98aab1faa34f94f2d55961474 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252379 > Commit-Queue: Wenyu Fu <wenyufu@chromium.org> > Reviewed-by: Theresa <twellington@chromium.org> > Cr-Commit-Position: refs/heads/master@{#781109} TBR=twellington@chromium.org,wenyufu@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1068831 Change-Id: I97f226e93962469cc8a705e922a3db72d7e84cd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265398Reviewed-by:
Haiyang Pan <hypan@google.com> Reviewed-by:
Wenyu Fu <wenyufu@chromium.org> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#782189}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1593021431-7b0ea0cd42ff146f154f99cb6b34c129710780a4.profdata to chrome-mac-master-1593043069-f3715f15f4d35968d8c3bf9fcf15b306aa3a92c4.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I3b76f8af9939a80066b89b3689a164f620e1aee3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265486Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#782188}
-
Connie Wan authored
See attached bug for screencasts of before/after (note that the After screencast comes first). Notable differences: - It's now possible to drag past the last few tabs in the tabstrip (bug fix). - There is no longer a big gap to the left of the dragging header when dragging right. This essentially makes the header feel like it's the size of a tab, whenever the slots switch. Remaining issue: - Dragging past a group (expanded or collapsed) still leaves a big gap to the left of the dragging header. This is an existing issue that I'm not prioritizing, since it's not strictly a bug and the solution is likely in a different part of the code. Bug: 1095799 Change-Id: Ieff4b9cba9d5568a0c1aefcdb67525d156c0668a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265556Reviewed-by:
Charlene Yan <cyan@chromium.org> Commit-Queue: Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#782187}
-
Xing Liu authored
This CL adds a job id for download later job, also does some refactor for auto resumption handler test, which prepares for adding the scheduling logic to auto resumption handler. Bug: 1078454 Change-Id: I6eb27477ba7b12ef657bdcfe3a4f11fc9ad3d6ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2262124Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#782186}
-
Ilia Samsonov authored
Bug: 1068400 Change-Id: Id88ff78abbb1e5906208d13bd7034ddefd3ba038 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258332Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#782185}
-
Zentaro Kavanagh authored
- Test WeakPtr before using it - Previous code was DCHECK'ing but that was incorrect BUG=1086012 TEST=manual Change-Id: Id1aefa57f9b92580fd47d1aeb213ca922bf78116 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265243 Auto-Submit: Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
jimmy gong <jimmyxgong@chromium.org> Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#782184}
-
Nate Chapin authored
DOMWindowSppechSynthesis exists only to act as a Supplement to hang the SpeechSynthesis off a LocalDOMWindow. There's no need for two objects here: the SpeechSynthesis can be the Supplement<LocalDOMWindow>, so long as it implements the static getter required by the IDL. This also allows us to take a LocalDOMWindow& in the SpeechSynthesis constructor, which removes the need to DCHECK what kind of ExecutionContext the constructor is given. Change-Id: I5ae8ef8877a0d4f308475ec76dfc3b661e6bbb3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261712 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Auto-Submit: Nate Chapin <japhet@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#782183}
-
Sahel Sharify authored
This cl refetches missing icons for already installed payment apps with web app manifests. Screencast of the fix is attached to the bug. Bug: 1069010 Change-Id: Ibd1e191f199295fb8301a4202cc7512b66408f05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264860 Commit-Queue: Sahel Sharify <sahel@chromium.org> Reviewed-by:
Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#782182}
-