GitLab

This fixes a longstanding issue where guest mode users cannot change
the browser's preferred language list.

The main profile in guest mode is an off-the-record/incognito profile.
This CL from 2.5 years ago https://codereview.chromium.org/2499093002
changed the settingsPrivate API in guest mode to use the backing
("recording") profile instead of the main incognito profile for pref
writes. The languages UI continued to function because the incognito
profile's preferences were "overlaid" onto the recording profile prefs.

By default, all prefs were overlaid, except for a block-list. That
block-list was changed to a whitelist, and the whitelisted prefs
were gradually removed. This CL removed the language prefs from the
list:
https://chromium-review.googlesource.com/c/chromium/src/+/1174118/
which made the guest mode language section stop working.

For guest mode we want to use the incognito pref store where possible.
The incognito pref store is in-memory. The backing user profile is
deleted after logout (it is on a tmpfs) but it's better to just avoid
writing the prefs.

Change the BCKSFactories to prefer the incognito profile. Return null
services in tests because unit tests with TestingProfile generally
don't need these services.

Bug: 887383
Test: added to browser_tests, manual test in guest mode on eve

Change-Id: Ib4bbe45662b13aa3b733eaddc4342de5b68086b9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1653748
Commit-Queue: James Cook <jamescook@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#668434}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/286660f0dde0..889ec0706417


git log 286660f0dde0..889ec0706417 --date=short --no-merges --format='%ad %ae %s'
2019-06-12 saklein@chromium.org BinhostService: Fix prebuilts path fetch.


Created with:
  gclient setdep -r src/third_party/chromite@889ec0706417

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel
TBR=chrome-os-gardeners@google.com

Change-Id: I06bf84c08a4878aad73e4fece6fe9959a9736fe4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655046Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#668433}

This cl is part of the effort to use CoreAccountId instead of std::string
to denote account_id. The virtual functions of this class has been refactored
as part of another cl.

Bug: 959157
Change-Id: Ia73f41bcbb9bc1d4a8bfe1e57337e0d77be8dbf6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649550
Commit-Queue: Tanmoy Mollik <triploblastic@google.com>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#668432}

This CL adds ScopedAllowRendererCrashes to browser tests that
(expectedly or unexpectedly) might trigger a renderer crash.

Right now a browser test might pass, even if a renderer process crashed
during the test execution.  After https://crrev.com/c/1650463 a renderer
crash will trigger an explicit test failure, but before this enforcement
can start, existing tests that experience renderer crashes (expectedly
or unexpectedly) need to declare this via ScopedAllowRendererCrashes.

This CL was uploaded by git cl split.

R=ssid@chromium.org

Bug: 972220
Change-Id: Ie70039609720ed091aa7efa5cb1ce5a3fd2f0c40
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1653629
Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: ssid <ssid@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#668431}

This CL adds ScopedAllowRendererCrashes to browser tests that
(expectedly or unexpectedly) might trigger a renderer crash.

Right now a browser test might pass, even if a renderer process crashed
during the test execution.  After https://crrev.com/c/1650463 a renderer
crash will trigger an explicit test failure, but before this enforcement
can start, existing tests that experience renderer crashes (expectedly
or unexpectedly) need to declare this via ScopedAllowRendererCrashes.

This CL was uploaded by git cl split.

R=lfg@chromium.org

Bug: 972220
Change-Id: Ia48b122e05426652171a4bbe3f95fef603823f15
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1652379
Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Lucas Gadani <lfg@chromium.org>
Commit-Queue: Lucas Gadani <lfg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#668430}

https://webrtc.googlesource.com/src.git/+log/da1c65fb53c3..e794243650a0


git log da1c65fb53c3..e794243650a0 --date=short --no-merges --format='%ad %ae %s'
2019-06-12 sprang@webrtc.org Remove PacedSender::PacketSender interface and use PacketRouter directly
2019-06-12 nisse@webrtc.org Delete StartRtcEventLog and StopRtcEventLog methods from FakeVoiceEngine
2019-06-12 chxg@google.com Add a tracker for RTCRtpContributingSource and RTCRtpSynchronizationSource.


Created with:
  gclient setdep -r src/third_party/webrtc@e794243650a0

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I753757483084b7fc9315a8ee1f7044940d4da32d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655044Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#668429}

This CL fixes comments about type CHECKs in base/value.h
The comments used to say "fataly asserts if type is not dictionary" and
was updated to "CHECKs if type is not dictionary" in
https://chromium-review.googlesource.com/c/chromium/src/+/1550471
This CL updates removes the "not" from the comment.

Bug: 646113
Change-Id: I50992da3fc82b67ad2d0cdeaa0ed3330444cfd15
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649495Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Auto-Submit: Alexander Hendrich <hendrich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#668428}

Need to move notifications down whenever there is free space below.

Bug: 920110
Change-Id: Ib49a4e22ee1cbb287095125fc29c623e47d20339
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638142Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Reviewed-by: Tim Song <tengs@chromium.org>
Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#668427}

The experiment using the no-op service has been run, and it is no longer
needed.

Bug: 923101
Change-Id: I927dd3f9815a9f67f0d12231f387e60b0245ea66
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1652803
Auto-Submit: Clark DuVall <cduvall@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#668426}

I've verified locally that this works for the four possible
configurations of offscreen canvas:

1. On main thread with new OffscreenCanvas()
2. On main thread with canvas.transferControlToOffscreen()
3. On a worker with new OffscreenCanvas()
4. On a worker with canvas.transferControlToOffscreen()

AFAIK there is no way to capture console output for testing.

Bug: 967581
Change-Id: If06c7f15919f029e6f5f97b216f5ec4ac0698d70
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1651060Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Commit-Queue: Aaron Krajeski <aaronhk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#668425}

Fixes include:
 - Using the system python when trying to invoke a python script.
 - Don't run the test via swarming on mac since there's no mac VMs
   available in chrome-swarming's test pool.

Bug: 961548
Change-Id: Idad126d8b90ea77d772fc239d55f799864127eb2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1654268Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#668424}

Web Platform Tests for computed values of CSS Text properties
https://drafts.csswg.org/css-text-3/#property-index

Change-Id: I52b3de169752db63c96c8662819d3b8a1141d721
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1653608
Auto-Submit: Eric Willigers <ericwilligers@chromium.org>
Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org>
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/master@{#668423}

When trying to retrieve the target of an in-page link accessibility node, testing if the node IsAnchor() is not enough.
The accessibility node may have the correct role to be an anchor, but no anchor element might be present in the DOM.
The user facing bug is that "Reply All" crashes in Gmail.
TBR=aleventhal@chromium.org, gilmanmh@google.com

Bug: 971188
Change-Id: I119e51678ddaf03d6142d70f0872af4538d7a820
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1654808Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Reviewed-by: Aran Gilman <gilmanmh@google.com>
Commit-Queue: Nektarios Paisios <nektar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#668422}

https://chromium.googlesource.com/angle/angle.git/+log/2589cdcc88ec..fce1e2d1e279


git log 2589cdcc88ec..fce1e2d1e279 --date=short --no-merges --format='%ad %ae %s'
2019-06-12 jonahr@google.com Extend eglGetPlatformDisplay to allow feature overrides.


Created with:
  gclient setdep -r src/third_party/angle@fce1e2d1e279

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=jmadill@google.com

Change-Id: Ia0649a281fa1ad236fb7967e34a19fabb9bf0709
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655038Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#668421}

https://android.googlesource.com/platform/external/perfetto.git/+log/0b2e12b08cdc..07b9e9354427


git log 0b2e12b08cdc..07b9e9354427 --date=short --no-merges --format='%ad %ae %s'
2019-06-12 primiano@google.com Merge "trace_processor: fix asan leak in gzip decoding"


Created with:
  gclient setdep -r src/third_party/perfetto@07b9e9354427

The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=perfetto-bugs@google.com

Change-Id: Id21e4b186df4bd3d4a82cd5a24048dbe2b3d77cd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655040Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#668420}

This is the first CL in a series of changes to the add printer dialog
flow that will remove the configuring dialog where possible, switching
to promises rather than WebUI events, and move setup errors to be shown
inline rather than as a toast on the cups_printers settings page.

This change removes the configuring dialog between the manually add
printer dialog and the model/manufacturer dialog

Change-Id: I43100a99c8ade7a5df582c3d2f6e06f9ee52671a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637531Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#668419}

Adds tests for:
-Accessibility
-Toggling the Translate Switch
-Adding a language
-Changing language details

Bug: 957688
Change-Id: Icadc52b121c18f823bcd37515b46daa1a3bec949
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1653250
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#668418}

The default command line set up by InProcessBrowserTest for browser
tests should also be used by AndroidBrowserTest. Move the set up of
that command line to chrome/test/base/test_launcher_utils.cc and have
AndroidBrowserTest call it.

Some clean up in InProcessBrowserTest while we there, moving the shared
constructor code into an Initialize() method, so that #ifdefs around
TOOLKIT_VIEWS are more clear, move variable initialization to the
header declaration, and pass in the ViewsDelegate directly instead of
going through a Bind and a lambda when it is just called synchronously
anyhow.

R=jam@chromium.org

Bug: 961849
Change-Id: I3c3fad2b18fbead231e24b4ece32049ca9d43fe9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1652195Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#668417}

Previously, we created a SplitInstallManager _before_ calling
SplitCompat.install(-), which breaks the module install flow on Android
pre-Q.

Bug: b/133669491
Change-Id: I0b317732ed364a592047eeb7387c74dd1ea1b258
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1646903
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#668416}

R:tienmai,yusufsn

Bug: 973105
Change-Id: Ib7c05f3d9cc70cab53b2a106f1ec5d44096d95c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1652735Reviewed-by: Tien Mai <tienmai@chromium.org>
Commit-Queue: Rakesh Soma <rakeshsoma@google.com>
Cr-Commit-Position: refs/heads/master@{#668415}

Bug: 945335
Change-Id: I5671a91452f9c286dbf656da6cb9f0b219f34a80
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1652084
Commit-Queue: Allen Bauer <kylixrd@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#668414}

This cl is part of the effort to use CoreAccountId instead of std::string
to denote account_id. The virtual functions of this class has been refactored
as part of another cl.

Bug: 959157
Change-Id: I9f1354af8d8958f4df097816a70e78278f319c8e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649682
Commit-Queue: Tanmoy Mollik <triploblastic@google.com>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#668413}

Bug: 720159
Test: compiles
Change-Id: I54d5836d71f41b7ce4367e9d89e12e14ded587f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1652663
Auto-Submit: James Cook <jamescook@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#668412}

We need to unref root_obj.

Bug: 973185
Change-Id: Ie0a326c125fda8ef397d4c8f4b68cabd2c8e7365
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655674Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Commit-Queue: Joanmarie Diggs <jdiggs@igalia.com>
Cr-Commit-Position: refs/heads/master@{#668411}

In some cases in this class, we already return early if no Browser is
found for the web contents. This updates one callsite of
FindBrowserWithWebContents with an early return, and another with
a DCHECK.

See also crbug.com/737346

Bug: 971468
Change-Id: I04bbc26679d96f58c7a6d6402cde4bec1409375b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649374
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#668410}

The HTML spec says:
  "The href attribute on a and area elements is not
   required; when those elements do not have href
   attributes they do not create hyperlinks."

Background:
Chrome already excludes unclickable <area>s, <area>s
without a href attribute, from the tab order.

Problem:
Unclickable <area>s still show a "click me" hint.

Solution:
Mimick Firefox. Only show the pointer for actual
<area> links.

Note:
Found during crrev.com/c/1632231. We don't want
unclickable <area>s to act navigable.

Bug: 972556
Change-Id: I9214171290659b8b800db3e462478e2a1327c832
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1653009
Commit-Queue: Hugo Holgersson <hholgersson@fb.com>
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#668409}

Simplify the favicon loader API by converting the FaviconLoader's
methods to non-return-value methods.

Unit tests are rewritten according to the new API.

Bug: 967660
Change-Id: I23c0ec34ecaba1cd363a4e99d13b8aa3a45ccb08
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645305Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Nazerke Kalidolda <nazerke@google.com>
Cr-Commit-Position: refs/heads/master@{#668408}

If the focused field changes between the user manually requesting to
generate a password and the callback coming back from the renderer to
show the dialog, the callback should be ignored and the dialog should
not be shown. This is because it is no longer relevant to the current
focused field.

Bug: 835234
Change-Id: Ic778d504b9aa07c12238ddc8ad4dada317801542
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655433Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Ioana Pandele <ioanap@chromium.org>
Cr-Commit-Position: refs/heads/master@{#668407}

BitmapCache is more of a utility than a fundamental base package class
like ChromeApplication.java. This paves the way for moving it out of
chrome_java into //chrome/lib/util.

Bug: 846440
Change-Id: I7b465f0915c6b107da1b648d94a3b00c8300f26d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1646412
Commit-Queue: Peter Wen <wnwen@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Auto-Submit: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#668406}

iOS 13 supports running UpsideDown on phone, so this test is updated
with new expectations.

BUG=973398

Change-Id: Ic4fad631af1a01b3a35423d9272d9ae5de92b062
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655669Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#668405}

Change-Id: Id57b2d1e2f2749903f50c2c20e721faa650c2beb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655035
Auto-Submit: Sam Maier <smaier@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Reviewed-by: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#668404}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/337c6daadba3..2875b88d0b00


Created with:
  gclient setdep -r src-internal@2875b88d0b00

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=haraken@google.com,tangltom@google.com,flackr@google.com

Change-Id: Ica9c2a5f7efb2a54c663cd007c5744e3244030d8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655251Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#668403}

iOS 13 adds a new type of scroll indicator that needs to be explicitly
excluded from ChromeSigninViewControllerTest.

BUG=973398

Change-Id: I79048368b78fe862765eaca1b53092a578b31921
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655668Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#668402}

This CL fixes a bug where the LaunchHostBrowserSelector would be called
twice when a user selects a host browser:
- once with the host browser package
- once with null.
This CL surpresses the second callback by disabling the OnDismissListener
when a 'button is clicked' or 'host browser is chosen'

This CL also fixes the same bug in InstallHostBrowserDialog

BUG=972922

Change-Id: I6b33cc6a600f170e92e44de329f0d3eb24b6f23b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1652291Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#668401}

Bug: 972781
Change-Id: I8254e2c67e5807f549a2a4a782ffb294683b5ea1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1653529
Auto-Submit: Brian White <bcwhite@chromium.org>
Commit-Queue: Robert Kaplow (slow) <rkaplow@chromium.org>
Reviewed-by: Robert Kaplow (slow) <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#668400}

These should have been removed with CL1631403 and CL1641882 but
I forgot to do it, so let's remove them now to keep the tree clean.

Bug: 939943
Change-Id: Ie185baf8cf653e68d5f9a10bbc4a5b39982e631f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655469
Commit-Queue: Mario Sanchez Prada <mario@igalia.com>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#668399}

This is the first step to wipe WebThreadSupportingGC from the tree. It's
basically a wrapper over WorkerThread adding some GC capabilities.

This CL adds GC handling support to WorkerThread. It uses a new class called
GCSupport which is in charge of creating the GCTaskRunner apart from
attaching/detaching the current thread to ThreadState.

This new machinery is disabled ATM, it'll be enabled later in followup CLs which
will convert callsites to use WorkerThread instead of WebThreadSupportingGC.

Bug: 961743
Change-Id: Ibee4e3ce40500398d5794c13e18984e52fc2c39e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655430Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Sergio Villar <svillar@igalia.com>
Cr-Commit-Position: refs/heads/master@{#668398}

https://webrtc.googlesource.com/src.git/+log/5cf390386bdd..da1c65fb53c3


git log 5cf390386bdd..da1c65fb53c3 --date=short --no-merges --format='%ad %ae %s'
2019-06-12 titovartem@webrtc.org Change reporting of time_between_freezes.


Created with:
  gclient setdep -r src/third_party/webrtc@da1c65fb53c3

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: Iad17c389bf5c9237b6e754397232795ea8e59cd0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655252Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#668397}

Lifecycle is a self-contained package for managing Android application
and activity lifecycles:
https://developer.android.com/guide/components/activities/activity-lifecycle

This CL moves the java target from //chrome/android/public to
//chrome/lib as it is not specific to //chrome/android and can be reused
by other //chrome layer features.

Bug: 846440, 966644
Change-Id: I5b3a516b0818b39044ee757695203e915512acf2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1630740Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Auto-Submit: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#668396}

Using wpt-import in Chromium db82c1cf.
With Chromium commits locally applied on WPT:
9e3affdd "Ship `referer` header length limitation."
723f9a78 "Prevent leaking Sec-CH-/Sec-Fetch- Request Headers on HTTPS Downgrade Redirects."


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
atotic@chromium.org:
  external/wpt/css/CSS2/abspos
chcunningham@chromium.org, wolenetz@chromium.org:
  external/wpt/media-source

NOAUTOREVERT=true
TBR=foolip

No-Export: true
Change-Id: I229152a38214541c11e387a718a4ec67e05df260
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655027Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#668395}