GitLab

This cl is pure style-targeted refactoring. 
No functional changes were made. 

BUG=339176

Review URL: https://codereview.chromium.org/148663003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247865 0039d316-1c4b-4281-b951-d872f2087c98

Remoting host on windows contains latest revision number so parts
of remoting are rebuilt every time revision number changes. Removed
dependency on LASTCHANGE to prevent ninja from rebuilding remoting
every time. The file is still used.

BUG=332679

Review URL: https://codereview.chromium.org/142713006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247864 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none

Review URL: https://codereview.chromium.org/130803011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247863 0039d316-1c4b-4281-b951-d872f2087c98

Perform /ListAccounts check before session merge to see if there is a need for session merge at all.

BUG=338543
TEST=manual, added OAuth2Test.PRE_PRE_MergeSession to test existing user with fresh cookies, modified OAuth2Test.PRE_MergeSession to test existing user with stale GAIA cookies

Review URL: https://codereview.chromium.org/148463004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247862 0039d316-1c4b-4281-b951-d872f2087c98

BUG=161119

Review URL: https://codereview.chromium.org/148093011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247861 0039d316-1c4b-4281-b951-d872f2087c98

BUG=329384

Review URL: https://codereview.chromium.org/149213004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247860 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/149073004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247859 0039d316-1c4b-4281-b951-d872f2087c98

Since we are only testing correctness and not performance in Debug, we
can use much smaller images and still get decent coverage.

This reduces the runtime in Debug from 17092ms to 191ms.

BUG=338133

Review URL: https://codereview.chromium.org/149063009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247858 0039d316-1c4b-4281-b951-d872f2087c98

Add method to ServiceDiscoveryClient that will allow it to actively refresh
stale services when their TTL runs out.

BUG=336883

Review URL: https://codereview.chromium.org/141583010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247857 0039d316-1c4b-4281-b951-d872f2087c98

BUG=339117

Review URL: https://codereview.chromium.org/137383007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247856 0039d316-1c4b-4281-b951-d872f2087c98

This patch replaces currentDirectoryPath with currentDirectoryURL, and same for the selectionPath. As a result, the entire appState does not depend on paths anymore.

TEST=browser_tests, also tested manually.
BUG=333168

Review URL: https://codereview.chromium.org/132453007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247855 0039d316-1c4b-4281-b951-d872f2087c98

It's a bit ugly--I wish I could get the text and the dropdown indented a bit (the width of one checkbox) so it lines up with the other text. But it's not a big deal and not worth my time figuring out.

BUG=265675

Review URL: https://codereview.chromium.org/149683005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247854 0039d316-1c4b-4281-b951-d872f2087c98

This registers accelerator table entries for VKEY_BROWSER_(BACK|FORWARD)
to IDC_(BACK|FORWARD) for linux platforms (linux desktop and ChromeOS) so
that hardward back/forward keys navigate the browser.

BUG=338945

Review URL: https://codereview.chromium.org/149273002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247853 0039d316-1c4b-4281-b951-d872f2087c98

Previous implementation of GrantFullAccessToExtension() granted permissions
only for paths that are mounted at that moment, and required hack for
one dynamically mounted path, namely, Google Drive directory.

It's not what is meant for GrantFullAccessToExtension(). Rather, it
should just simply allow access for the extension any time.
In multi-profile settings, more directories, i.e., Downloads/Drive
directories from other profiles are going to be dynamically added.

BUG=337705

Review URL: https://codereview.chromium.org/148233008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247852 0039d316-1c4b-4281-b951-d872f2087c98

In particular:

 - Switch to 1-based indexing.
 - Use 0 instead of -1 as the "invalid index" value.
 - Add "host" header to the static table.
 - Add HpackEncodingContext::GetMutableEntryCount() function.

This lands server change 60493594 by akalin.

Review URL: https://codereview.chromium.org/145353017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247851 0039d316-1c4b-4281-b951-d872f2087c98

When we run content_shell in the single process mode with tests using the clipboard, the renderer thread passes WebString to the browser thread. It causes leak.
To avoid this, change the member WebString to NullableString16.

BUG=328158
TEST=content_shell --dump-render-tree --single-process ../../third_party/WebKit/LayoutTests/editing/pasteboard/createMarkup-assert.xml

Review URL: https://codereview.chromium.org/135853010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247850 0039d316-1c4b-4281-b951-d872f2087c98

Credential slot field has been removed from SYN_STREAM frame.

This lands server change 59587408 by mlavan.

Also update affected Chromium portions of QUIC & SPDY.

Review URL: https://codereview.chromium.org/141953004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247849 0039d316-1c4b-4281-b951-d872f2087c98

BUG=339204

Review URL: https://codereview.chromium.org/141713004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247848 0039d316-1c4b-4281-b951-d872f2087c98

BUG=313530

Review URL: https://codereview.chromium.org/147593006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247845 0039d316-1c4b-4281-b951-d872f2087c98

TBR=oshima@chromium.org,stevenjb@chromium.org,bajones@chromium.org,rch@chromium.org

Review URL: https://codereview.chromium.org/149573004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247844 0039d316-1c4b-4281-b951-d872f2087c98

Pinch zoom should not affect native-looking UI. This patch disabled zoom
in all cases except for the browser view.

BUG=232098

Review URL: https://codereview.chromium.org/134683004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247843 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/150053002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247842 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247840 0039d316-1c4b-4281-b951-d872f2087c98

Set excutable bits on python files:
https://codereview.chromium.org/130513006

Refactor obj_int_extract:
https://codereview.chromium.org/130563008

Roll libvpx, enable vp9 encoder, automatically disable avx2:
https://codereview.chromium.org/148913004

Remove defunct example binaries:
https://codereview.chromium.org/139903014

Fix OUTPUT_FMT usage in obj_int_extract:
https://codereview.chromium.org/144033005

Set flags for NEON intrinsic files:
https://codereview.chromium.org/148963005

Include correct NEON configuration files:
https://codereview.chromium.org/131103019

Fix copy_src.py:
https://codereview.chromium.org/133213007

Refactor dropped 'python' on action:
https://codereview.chromium.org/148123003

Disable vp9 encoder:
https://codereview.chromium.org/149883003

Cast away warning:
https://codereview.chromium.org/135183020

R=tomfinegan@chromium.org

Review URL: https://codereview.chromium.org/148173012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247839 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247836 0039d316-1c4b-4281-b951-d872f2087c98

Perform copy locally if the file is dirty or it doesn't have a resource ID.
Fix Copy()'s behavior to overwrite existing file.
Remove dependency from MoveOperationTest to CopyOperation.

BUG=260539,331985
TEST=unit_tests
R=kinaba@chromium.org

Review URL: https://codereview.chromium.org/149413002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247834 0039d316-1c4b-4281-b951-d872f2087c98

Implements the new audio player of Files.app. See the issue for detail. Although it has still room to implement and improve, but basically it works.

BUG=273308
TEST=manually tested
R=dgozman@chromium.org, mtomasz@chromium.org

Review URL: https://codereview.chromium.org/144883002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247833 0039d316-1c4b-4281-b951-d872f2087c98

BUG=260539
TEST=unit_tests
R=kinaba@chromium.org

Review URL: https://codereview.chromium.org/148283003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247832 0039d316-1c4b-4281-b951-d872f2087c98

BUG=339094

Review URL: https://codereview.chromium.org/149723003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247831 0039d316-1c4b-4281-b951-d872f2087c98

This issue was found by a linter.

R=frankf@chromium.org

BUG=

Review URL: https://codereview.chromium.org/149543004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247830 0039d316-1c4b-4281-b951-d872f2087c98

This checks with GAIA to reconfirm whether a given user is permitted
to log in to a device. The check complements the existing login
whitelist check based on device policy.

BUG=chromium:336284
TEST=Manual

Review URL: https://codereview.chromium.org/148843002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247829 0039d316-1c4b-4281-b951-d872f2087c98

This is a prep CL to fix crbug.com/247517 and crbug.com/272583.

BUG=none
TEST=none
TBR=cevans@chromium.org

Review URL: https://codereview.chromium.org/148683002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247828 0039d316-1c4b-4281-b951-d872f2087c98

Cleanup: remove BlockedWriterInterface from QuicPacketWriter.
No behavior changes.

Merge internal change: 60499316
https://codereview.chromium.org/135363006/


Properly trigger OnCanWrite processing from PacketDroppingTestWriter.
Re-enable the LargePostWithPacketLossAndBlockedSocket test.

Testing only.

Dialing back the loss from 30% to 10% seems to have stabilized the test.

Merge internal change: 60479729
https://codereview.chromium.org/131503016/


Use LOG_IF instead of LOG_IF_FIRST_N in a few places, as per avd's
suggestion.

Merge internal change: 60382807
https://codereview.chromium.org/149163004/


Change the default RTT from 60ms to 100ms, which is more typical of
internal server's.

Merge internal change: 60366147
https://codereview.chromium.org/146583006/


Remove an impossible check in QuicConnection for when a packet is
retransmitted before it is sent.

Updating the tests also found and fixed an edge case where a truncated
ack could cause the SentPacketManager to raise the high water mark above
a pending packet.

Merge internal change: 60169343
https://codereview.chromium.org/145123003/


Export primary insecure and secure QUIC config id via internal server
status pages.

Merge internal change: 60108488
https://codereview.chromium.org/137423015/


Export SCIDs, QUIC secret seed names and orbits to varz.

Merge internal change: 60107113
https://codereview.chromium.org/144033006/


Refactor QuicConnection to use explicit notification for getting onto
the write blocked list. Remove the PacketWriter interface from
QuicDispatcher.

Merge internal change: 60103466

Fix build. Build got broken by a race between presubmit tests and me
editing the file that was in the process of being submitted. :(

Merge internal change: 60104577
https://codereview.chromium.org/149263002/


Remove the word Payload from AddFrame methods in QUIC framer.

Merge internal change: 60101552
https://codereview.chromium.org/131513022/


Fixes QUIC's Cubic sender to use correct alpha when in Reno mode.

Merge internal change: 60088487
https://codereview.chromium.org/136453013/


Add DFATALs to QuicFramer branches where packet creation fails.

Merge internal change: 60077767

https://codereview.chromium.org/148073002/


Fix a QUIC bug where previously undecryptable packets were not decrypted
before sending out an ack when the encryption level changed.

Merge internal change: 60051502

Added logging for all frame types.

Added code to dump frames and packet_headers. Changes to make
QuicHttpStreamTest work.
https://codereview.chromium.org/144063012/

R=rch@chromium.org

Review URL: https://codereview.chromium.org/146033003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247827 0039d316-1c4b-4281-b951-d872f2087c98

In r239446 I carelessly inserted '.ico' to the array but
I should have not. The array is for indexing enum of metric
stat that need to match with remote side config.

Let me just revert the addition. I think we are not so eager
to count '.ico''s popularity.

BUG=339023
R=hirono@chromium.org

Review URL: https://codereview.chromium.org/130803008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247826 0039d316-1c4b-4281-b951-d872f2087c98

* Let ContentViewCore manage more than one GestureStateListener.
* Change GestureStateListener to be an empty implementation.
* ContentViewCore alerts its GestureStateListeners of any scrolls
  or flings, and alerts it of changes in the vertical scroll offset
  or extent.  That last bit is admittedly a bit strange to put in
  the GestureStateListener, but it's going to be listening to starts
  and stops already anyway...

Downstream CL that uses it: https://chrome-internal-review.googlesource.com/#/c/152640/
BUG=332281

Review URL: https://codereview.chromium.org/145953005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247825 0039d316-1c4b-4281-b951-d872f2087c98

BUG=338618

Review URL: https://codereview.chromium.org/145353014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247824 0039d316-1c4b-4281-b951-d872f2087c98

BUG=338900

Review URL: https://codereview.chromium.org/145353013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247823 0039d316-1c4b-4281-b951-d872f2087c98

> Add UMA stats for ExtensionCache
> 
> Reported metrics:
> - number of extensions in cache
> - size of cache on disk
> 
> BUG=316371
> TEST=manual
> 
> Review URL: https://codereview.chromium.org/148013004

This causes compile failures on ChromeOS. See comments on original CL for
details.
TBR=dpolukhin@chromium.org

Review URL: https://codereview.chromium.org/139173009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247822 0039d316-1c4b-4281-b951-d872f2087c98

Event-targeters (e.g. wm::EasyResizeWindowTargeter) now do the necessary work
for allowing a window to receive events outside of its bounds. So these methods
on aura::Window are no longer necessary.

BUG=318879
R=ben@chromium.org

Review URL: https://codereview.chromium.org/133873004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247821 0039d316-1c4b-4281-b951-d872f2087c98

ui/gfx/ depended on net/ for two things, SortedDisplayURL and gfx::ElideUrl().
SortedDisplayURL was not used by anything other than its own unit test and is
deleted in this patch.  ElideUrl() is only used from
chrome/browser/ui/(gtk|cocoa|views), so this patch moves the functionality up
to chrome/browser/ui/elide_url.(h|cc) and the unit test to
chrome/browser/ui/tests/elide_url_unittest.cc.

R=sky

Review URL: https://codereview.chromium.org/143463006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247820 0039d316-1c4b-4281-b951-d872f2087c98