GitLab

This matches the protected content screen.

BUG=446700

Review URL: https://codereview.chromium.org/939413002

Cr-Commit-Position: refs/heads/master@{#317195}

there are event listeners still registered with chrome.dial.  This is not an
issue as all owned objects will be cleaned up anyway by following the normal dtor
sequence DialAPI -> DialRegistry -> DialService.

BUG=460197

Review URL: https://codereview.chromium.org/916103007

Cr-Commit-Position: refs/heads/master@{#317194}

Along the way, add r prefix to regex patterns.

BUG=456014
TEST=N/A

Review URL: https://codereview.chromium.org/932133005

Cr-Commit-Position: refs/heads/master@{#317193}

BUG=459556
TBR=ssid@chromium.org

Review URL: https://codereview.chromium.org/943863002

Cr-Commit-Position: refs/heads/master@{#317192}

Metrics service uses sys info to determine if user opted out metrics
reporting.

BUG=internal b/19432329

Review URL: https://codereview.chromium.org/940163005

Cr-Commit-Position: refs/heads/master@{#317191}

BUG=457513

Review URL: https://codereview.chromium.org/909313003

Cr-Commit-Position: refs/heads/master@{#317190}

Updating with to new OTS repo from https://github.com/khaledhosny/ots.git
Hash tag imported: c24a839b1c66c4de09e58fabaacb82bf3bd692a4

Some important differences between new and old version of OTS:
1. Support for MATH table
2. Implementation changes related to new WOFF 2.0
3. Bug fixes related to OTF tables (GDEF, GSUB etc) parsing
4. Accept platform 0 encoding 1 cmap subtables
5. Allow fonts with CMAP format-12 or format-13 table

A dummy version of EnableWOFF() is added to get Blink compiled.
After the following CL is landed in Blink, it'll be removed.
Blink CL: https://codereview.chromium.org/774253008

TEST: Blink layout tests: fast/css/font-face*
BUG=339857

Committed: https://crrev.com/3b6cd2d4bf9e0b4a9311343a2997ef9363530b14
Cr-Commit-Position: refs/heads/master@{#308054}

Review URL: https://codereview.chromium.org/775893002

Cr-Commit-Position: refs/heads/master@{#317189}

TBR=dzhioev@chromium.org
R=michaelpg@chromium.org
BUG=460269

Review URL: https://codereview.chromium.org/939683005

Cr-Commit-Position: refs/heads/master@{#317188}

remoting.ClientPluginImpl has grown organically over the years and become
a dumping ground of all functionality related to the plugin.

This CL moves all  host desktop related implementation from
remoting.ClientPluginImpl into remoting.ClientPlugin.HostDesktopImpl.

BUG=457890
NOTRY=true
TEST=Unit test passed locally and manually verified ShrinkToFit, bumpScrolling and resizeToClient works

Review URL: https://codereview.chromium.org/929323003

Cr-Commit-Position: refs/heads/master@{#317187}

The newest version of GN replaces the 'cpu_arch' and 'os' variables with 'current_cpu', 'target_cpu', 'current_os', and 'target_os', and also replaces 'build_cpu' with 'host_cpu', and 'build_os' with 'host_os'.

The roll also picks up the change to add a new 'gn clean'
command, some absolute path handling fixes, a check_includes fix for action_foreach(), and some minor
internal fixes.

This patch also updates the build config files to accommodate the GN changes in a backwards-compatible manner, i.e., the configs now will set cpu_arch and os correctly in the right contexts. They will also allow the users to continue to set os= and cpu_arch= in an args file, so no user builds (or bots) will break.

Once all of the bots and all of the build files have been updated to refer to the new variables instead of the old ones, we can drop the backwards-compatible versions.

TBR=brettw@chromium.org
BUG=344767
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg

Review URL: https://codereview.chromium.org/936103003

Cr-Commit-Position: refs/heads/master@{#317186}

This CL implements upload support for the new async APIs.
Most of this CL is patched from mmenke@'s CL 740673003.

BUG=412942

Review URL: https://codereview.chromium.org/849903002

Cr-Commit-Position: refs/heads/master@{#317185}

R=vmiura
BUG=454500

Review URL: https://codereview.chromium.org/940213002

Cr-Commit-Position: refs/heads/master@{#317184}

Review URL: https://codereview.chromium.org/939803002

Cr-Commit-Position: refs/heads/master@{#317183}

This was forgotten in the initial pass.

R=estade@chromium.org

Review URL: https://codereview.chromium.org/944633002

Cr-Commit-Position: refs/heads/master@{#317182}

It already uses the factory in one case, so using it here for consistency.

BUG=NONE

Review URL: https://codereview.chromium.org/942633002

Cr-Commit-Position: refs/heads/master@{#317181}

Previously, all instant renderers would reload if a search provider changed. With this patch, some of the renderers are redirected to the local NTP in the case that both the old and new search providers are google.<tld>.

BUG=456681
TEST=BrowserInstantControllerTest*, InstantService* unit_tests

Review URL: https://codereview.chromium.org/930853005

Cr-Commit-Position: refs/heads/master@{#317180}

BUG=454992

Review URL: https://codereview.chromium.org/928473002

Cr-Commit-Position: refs/heads/master@{#317179}

Added DCHECKs to all public methods of MessagePortService to make sure it is used in a thread safe manner.

BUG=459115

Review URL: https://codereview.chromium.org/937503003

Cr-Commit-Position: refs/heads/master@{#317178}

NtQuerySection should use ULONG instead of SIZE_T as it is dealing with PE section sizes.

NtQueryVirtualMemory should use SIZE_T instead of ULONG as it is dealing with memory sizes.

DynamoRIO, another project that consumes these native APIs, uses the prototypes introduced by this change.

R=robertshield@chromium.org,rvargas@chromium.org
BUG=458690

Review URL: https://codereview.chromium.org/921353002

Cr-Commit-Position: refs/heads/master@{#317177}

BUG=460285
TBR=reveman@chromium.org,avi@chromium.org

Review URL: https://codereview.chromium.org/944653002

Cr-Commit-Position: refs/heads/master@{#317176}

Rationale: ocassionally I find it useful to look at json_output to debug.
Indenting the file make it a lot more readable. The downside is this increases
the file size, but it shouldn't matter for small files like these.

An example Results.json with ~2000 values tested on local machine:
Without indent: 472K
With indentation: 692K

Review URL: https://codereview.chromium.org/940123003

Cr-Commit-Position: refs/heads/master@{#317175}

BUG=454031

Review URL: https://codereview.chromium.org/917053002

Cr-Commit-Position: refs/heads/master@{#317174}

BUG=459132

Review URL: https://codereview.chromium.org/932023003

Cr-Commit-Position: refs/heads/master@{#317173}

BUG=

Review URL: https://codereview.chromium.org/937013002

Cr-Commit-Position: refs/heads/master@{#317172}

This makes video stop relying on the TextureUploader class. I've ported
the stride-handling code from TextureUploader to the
VideoResourceUpdater class, since it is the only place that will make
use for it for now.

R=enne
BUG=454575

Review URL: https://codereview.chromium.org/935383004

Cr-Commit-Position: refs/heads/master@{#317171}

TBR=jam@chromium.org
BUG=454655

Review URL: https://codereview.chromium.org/943763003

Cr-Commit-Position: refs/heads/master@{#317170}

padding-left and padding-right should be subtracted from clientWidth to measure
the available width for grid items.

BUG=453764
TEST=adjust window width of Files.app and check that the problem doesn't occur.

Review URL: https://codereview.chromium.org/916353002

Cr-Commit-Position: refs/heads/master@{#317169}

BUG=451020
R=mnaganov@chromium.org,phajdan.jr@chromium.org

Review URL: https://codereview.chromium.org/935753003

Cr-Commit-Position: refs/heads/master@{#317168}

In the context of a dialog, inputs are preferred over spinners, because it's bad to show popups on top of popups.

BUG=437116

Review URL: https://codereview.chromium.org/936293002

Cr-Commit-Position: refs/heads/master@{#317167}

BUG=458300

Review URL: https://codereview.chromium.org/933113002

Cr-Commit-Position: refs/heads/master@{#317166}

Review URL: https://codereview.chromium.org/936333003

Cr-Commit-Position: refs/heads/master@{#317165}

The previous fix only made the offset calculation more stable, but
it still seems to race with when the device can go idle. I think
this is due to the trace command not being flushed. Since beginning
a trace is an asynchronous command, it is possible that the GPU can
still go idle after the we synchronize the timer because that is a
synchronous command. In order to guarantee that we are calculating
the offset after the asynchronous command has already begun, I have
made it so the offset is calculated before we issue the asynchronous
end trace call instead.

Technically this is still not completely fool proof because we can
have a case where we issue a trace begin and trace end immediately
and calculate the offset time before both commands are flushed, but
assuming we are actually tracing some GPU command that takes GPU time,
this should not happen very often.

BUG=None
TEST=local, trace a page for a minute.

Review URL: https://codereview.chromium.org/929543002

Cr-Commit-Position: refs/heads/master@{#317164}

and GetWifiPHYLayerProtocol

BUG=422516
R=rch@chromium.org, vadimt@chromium.org

Review URL: https://codereview.chromium.org/940133002

Cr-Commit-Position: refs/heads/master@{#317163}

This is the size_t to integer conversion warning. Using the config prevents flag duplication and is clearer to read.

Minor updates to Win64 build, including some fixes for size_t to int conversions.

Review URL: https://codereview.chromium.org/929793006

Cr-Commit-Position: refs/heads/master@{#317162}

Remove the old SSL version gathering logic in ConnectionType. Those metrics
are very difficult to read because the denominator is wrong.

In the meantime, claim the ConnectionType metrics since they're unowned.
They'll be deprecated once this new one has gathered numbers and the
SPDY use case for them has also been accounted for.

BUG=459710

Review URL: https://codereview.chromium.org/941743002

Cr-Commit-Position: refs/heads/master@{#317161}

R=dpranke
TBR=armansito@chromium.org (bluetooth)

Review URL: https://codereview.chromium.org/940613002

Cr-Commit-Position: refs/heads/master@{#317160}

This adds additional matching and output capabilities to the various GN introspection commands (desc, ls, refs). It adds --as for controlling output, and --testonly and --type for controlling which ones to show.

It adds support for matching multiple input arguments for the refs, ls, and check commands.

It adds support for finding which targets reference a config in the refs command.

Review URL: https://codereview.chromium.org/937003002

Cr-Commit-Position: refs/heads/master@{#317159}

* Adds support for tracking which domains trigger app banners.
  These metrics are split between native apps and web apps
  since developers are likely to prefer one over the other.

* Changes rappor.xml to have information about the new metrics.

BUG=458548

Review URL: https://codereview.chromium.org/939263002

Cr-Commit-Position: refs/heads/master@{#317158}

TBR=morrita@chromium.org
BUG=460243

Review URL: https://codereview.chromium.org/941063002

Cr-Commit-Position: refs/heads/master@{#317157}

BUG=
TBR=avi@chromium.org

Review URL: https://codereview.chromium.org/938163003

Cr-Commit-Position: refs/heads/master@{#317156}