- 25 Jun, 2018 40 commits
-
-
chrome://flags#arc-cups-apiLuum Habtemariam authored
This cl adds a flag to toggle the support of libcups apis from ARC. Disabled by default. Bug: chromium:832262 Test: flag unused thus far Change-Id: Ib745f034f0c426456e2c0777e15757629399d07a Reviewed-on: https://chromium-review.googlesource.com/1091640 Commit-Queue: Luum Habtemariam <luum@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#570209}
-
Simeon Anfinrud authored
This makes Controller<Unit> behavior a bit less surprising and is probably a better fit for some applications of Observable#unique(). Bug: None Test: cast_base_junit_tests Change-Id: Ic66544b5db6970df1bada2fd0925b5bfe4ab869b Reviewed-on: https://chromium-review.googlesource.com/1114203Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Simeon Anfinrud <sanfin@chromium.org> Cr-Commit-Position: refs/heads/master@{#570208}
-
Kevin Marshall authored
Services (applications run by "svcmgr") and components obey different service directory semantics. Services export their services to a flat service namespace, whereas components export services to a hierarchy, organized into groups like "public" or "debug". This CL adds support for both types. The chromium service must export to the legacy/flat type, and webrunner must export to the structured directory type. Bug: 822474 Change-Id: I14abf74fa528c13c0cbfafa23b169b430dea1c0b Reviewed-on: https://chromium-review.googlesource.com/1112627 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#570207}
-
Mike West authored
Because that would be silly. Bug: 845961 Change-Id: I69de2cb093a3629de63c48652c9499f7387b8334 Reviewed-on: https://chromium-review.googlesource.com/1109757 Commit-Queue: Mike West <mkwst@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#570206}
-
Cathy Li authored
This is to make it clear that it is its own snowflake and should be fixed later. Bug: 852075 Change-Id: I30991e144e6e39b433757a7aaa3749a6bb20c85a Reviewed-on: https://chromium-review.googlesource.com/1113619Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Cathy Li <chili@chromium.org> Cr-Commit-Position: refs/heads/master@{#570205}
-
Marijn Kruisselbrink authored
And rename from MockBlob to FakeBlob as that seems like a better name. Bug: none Change-Id: I560756e200a8712f7ba335130522158195633c5a Reviewed-on: https://chromium-review.googlesource.com/1114126 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#570204}
-
Ovidio Henriquez authored
This change adds a test for the case when a reference to a WebUSB object from an iframe is attempted to be used after the iframe has disconnected. Bug: 841510 Change-Id: I8b8d5f5d50af6d062bdc3cab9b516f598bcf8fae Reviewed-on: https://chromium-review.googlesource.com/1112346 Commit-Queue: Ovidio Henriquez <odejesush@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Chong Zhang <chongz@chromium.org> Cr-Commit-Position: refs/heads/master@{#570203}
-
David Black authored
The observed region will be used to initiate a bounded contextual search. Bug: b:110700892 Change-Id: I5488886a01f8ec53fb200bef794b60443e84bd26 Reviewed-on: https://chromium-review.googlesource.com/1112377Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#570202}
-
Bailey Berro authored
This change moves the initialization of the TempFileManager to the SmbService setup flow. Moving the initialization to setup cleans up the mount code and ensure the TempFileManager is initialized for both mount and remount calls. The SmbService Setup flow is as follows: 1) Check to see that there is a logged in user 2) Kerberos Setup (if necessary) 3) TempFileManager initialization 4) SmbShareFinder setup 5) Restore Mounts flow Bug: chromium:757625 Change-Id: I3098cb5b74a10f16f7b3ba376e709a9ede3f1084 Reviewed-on: https://chromium-review.googlesource.com/1102002Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#570201}
-
Donn Denman authored
Updates the Status Bar to match the scrim color when Contextual Search shows the Overlay Panel. Also updates the FadingBackgroundView to allow no anchor view. BUG=848922 Change-Id: I085c57f1ae9b991518c5fc2925243505d751e70a Reviewed-on: https://chromium-review.googlesource.com/1098455Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#570200}
-
Mounir Lamouri authored
This reverts commit e34efffb. Reason for revert: see bug 855215 Original change's description: > InMemory MediaCapabilities DB for Guest/Incognito profiles > > Prior to this change, Guest mode has an empty read-only DB and Incongito > has a read-only DB. This CL allows both profiles to write to an "in > memory" database that disapears when the profile is destroyed. > > This improves the experience for the user and avoids the possibility > of using MediaCapabilites to detect incognito/guest profiles. > > R=jam@chromium.org > > Bug: 796280 > Change-Id: I37e25478ce6efe8c25bf49f77929f94c9ca27655 > Reviewed-on: https://chromium-review.googlesource.com/1092156 > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> > Cr-Commit-Position: refs/heads/master@{#569046} TBR=sky@chromium.org,jam@chromium.org,mlamouri@chromium.org,chcunningham@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 796280 Change-Id: Idc97eee2871e940e36b9c19f820d9f6207d7f6ef No-Try: True Reviewed-on: https://chromium-review.googlesource.com/1113958 Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#570199}
-
Scott Chen authored
This fixes a few bugs introduced by 1103002 to cr-input, as well as making cr-input more robust against edge-cases: likely cases: - |tabindex| initially set by element are mistakenly set to 0. - if element has both |tabindex| and |disabled| set, element would not know what to set |tabindex| to once |disabled| is removed. - clicking on a |disabled| cr-input would set its |tabindex| to 0 again. edge case: - if |disabled| is changed to true in the same cycle as pointerdown is fired, then |tabindex| state gets messed up. Bug: 832177, 856118 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I91161ecde90e816340aa38db4646b3f8eedd7a8b Reviewed-on: https://chromium-review.googlesource.com/1111201 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#570198}
-
Anna Offenwanger authored
Unifying the function names for getting WebXR data as a step towards merging the mojo interfaces for sessions into a single interface. This will help make it so that when requesting a session in the renderer process, we don't need to know anything about how supplying the interface is implemented. Bug: 828321 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I56a7d02189bc8c15acca7c8b5893a6ae8b795057 Reviewed-on: https://chromium-review.googlesource.com/1106294 Commit-Queue: Anna Offenwanger <offenwanger@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Bill Orr <billorr@chromium.org> Cr-Commit-Position: refs/heads/master@{#570197}
-
Lei Zhang authored
BUG=137767 Change-Id: I50276dbabe85024e5314aa24f4cbc87cc666a686 Reviewed-on: https://chromium-review.googlesource.com/1112819Reviewed-by:
Xiangjun Zhang <xjz@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#570196}
-
Alexei Filippov authored
The link was previous available in a tooltip which is barely discoverable. BUG=851197 Change-Id: Ia69d0c9a2b39afe54b4802b9fd1a392104e150e0 Reviewed-on: https://chromium-review.googlesource.com/1112843 Commit-Queue: Alexei Filippov <alph@chromium.org> Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#570195}
-
Matthew Jones authored
This patch introduces UiUtils.isSystemUiThemingDisabled that allows us to fall back to black system nav and status bar on devices that do not completely support Android's APIs. Bug: 831737,823264 Change-Id: I753ea586a6c017cc07249e707fd29e3810a709f8 Reviewed-on: https://chromium-review.googlesource.com/1111263 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#570194}
-
Boris Sazonov authored
This CL replaces android:contentDescription="@null" attributes on ImageViews and ImageButtons with tools:ignore="ContentDescription". As default content description for these views is already null, this doesn't change the behavior, while reducing binary size and saving cycles during inflation. Bug: 853247 Change-Id: I1d20e477b1b3c27f897f49bdd95941e22ad2f543 Reviewed-on: https://chromium-review.googlesource.com/1102684 Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#570193}
-
Tommy C. Li authored
Bug report suggests that we are not refreshing the favicons correctly when they are delivered asynchronously. This reproduces sporadically, so this CL is a semi-speculative fix. That being said - there is indeed a missing Invalidate call, so this CL has a good chance of fixing the bug. Bug: 856218 Change-Id: I8a3c83053d765769e4f6a71bffcd947afaa9566e Reviewed-on: https://chromium-review.googlesource.com/1114154Reviewed-by:
Dave Schuyler <dschuyler@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#570192}
-
Luum Habtemariam authored
net::URLFetcher is no longer being maintained in lieu of network::SimpleURLLoader. This cl brings PpdProvider inline with this api change. Test: passes unittests && manual tests Bug: chromium:827741 Change-Id: I12c329b5a62809a56eca158baaed40f70b7b839a Reviewed-on: https://chromium-review.googlesource.com/1095537Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Luum Habtemariam <luum@chromium.org> Cr-Commit-Position: refs/heads/master@{#570191}
-
Marijn Kruisselbrink authored
Add some basic tests for previously untested methods. Bug: none Change-Id: Ic5c43df360d268520cc954873446e6bebc49d146 Reviewed-on: https://chromium-review.googlesource.com/1114129 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#570190}
-
Valdrin Koshi authored
This CL imports the latest virtual-scroller implementation (previously virtual-list) as-is except for renaming virtual-scroller-element.js to index.js. Original implementation: https://github.com/valdrinkoshi/virtual-scroller Diff from last import: https://github.com/valdrinkoshi/virtual-scroller/compare/4bbc08999515cdf3ce944a150bc6d9949add8978...58659cee10c5d9237821d5c475dac89720bd995d All imported code were written and contributed by Googlers who are Chromium Contributors. R=domenic@chromium.org, hiroshige@chromium.org, kinuko@chromium.org, kouhei@chromium.org, ojan@chromium.org, slightlyoff@chromium.org Change-Id: Ic541c4123c3744e944b03333e609ee5162412710 Reviewed-on: https://chromium-review.googlesource.com/1106905 Commit-Queue: Valdrin Koshi <valdrin@google.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#570189}
-
Michael Spang authored
This adds an implementation of the OverlaySurface interface for DRM. Bug: 851997 Test: compile Change-Id: Ia5d2a9a8f7b334914635f3c15e6fb88d6d6c5e6f Reviewed-on: https://chromium-review.googlesource.com/1104865 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Alex Sakhartchouk <alexst@chromium.org> Cr-Commit-Position: refs/heads/master@{#570188}
-
Peter Kasting authored
This prevents error accumulation (rounded origin + rounded size) in intermediate values, which can lead to cracks between adjacent rects as they're animated. These can be visible in MD refresh if background tabs have a different color from the frame. BUG=none TEST=none Change-Id: I8f8dce1c8d2189014ac4bf4ab13598f935f30a24 Reviewed-on: https://chromium-review.googlesource.com/1107241Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#570187}
-
Esmael El-Moslimany authored
cr-slider wraps paper-slider and applies the necessary style changes. paper-slider needed two small changes to allow this to work. This CL changes the style for sliders in settings. A subsequent CL will change the slider styles outside of settings (all usages of paper-slider will be replaced with cr-slider). Bug: 850243 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I70771521ff2d4cb7ec9ef69b0dca7cc0e436ad5f Reviewed-on: https://chromium-review.googlesource.com/1102158 Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#570186}
-
Boris Sazonov authored
This CL modifies SigninFirstRunFragment to use onAttach(Context) instead of onAttach(Activity) that has been deprecated. Bug: 537049 Change-Id: If6615a4eb2efa9908f7b9f21e9aa1039457a43a2 Reviewed-on: https://chromium-review.googlesource.com/1113927Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#570185}
-
Peter Kasting authored
This moves a couple of constants that are really local to individual files out of layout_constants.* (which should only be used for cross-file concepts). Along the way it makes two behavioral changes: (1) The standard tab width in refresh and touchable refresh, not including endcaps, is increased from 193 to 268, per spec. (2) The stacked tab width in touchable refresh is narrowed by about 8 DIP, because endcaps are actually narrower there than in touchable non-refresh, but the old code didn't take that into account. I'm not aware of any particular spec on this. I don't think there's a bug that covers making the standard tab width match the sspec, interestingly enough. BUG=none TEST=none Change-Id: Iddc6bbbff7730245b802f5a9faa6e40ee0baea02 Reviewed-on: https://chromium-review.googlesource.com/1112865Reviewed-by:Allen Bauer <kylixrd@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#570184}
-
Esmael El-Moslimany authored
Bug: 854732 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I4ce3bb683bf41bc46e4bcc896d5705b75b714938 Reviewed-on: https://chromium-review.googlesource.com/1114006Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#570183}
-
Stephen Martinis authored
This is the standard way isolated scripts allow for callers to specify a subset of tests to run. This CL adds this argument, and integrates it with the existing method for specifying a subset of tests to run. Bug: 533481 Change-Id: Ib63c18cfa5cb3db8a5256b7969dccb9541d4f9cc Reviewed-on: https://chromium-review.googlesource.com/1112767 Commit-Queue: Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#570182}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/27d3aa2ed234..5339261bb349 git log 27d3aa2ed234..5339261bb349 --date=short --no-merges --format='%ad %ae %s' 2018-06-25 rharrison@chromium.org Update code coverage documentation Created with: gclient setdep -r src/third_party/pdfium@5339261bb349 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Iba35eea5b5899dccd5fdfce1328648467a25dc86 Reviewed-on: https://chromium-review.googlesource.com/1113826Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#570181}
-
Stefan Zager authored
This extends to the other EmbeddedContentView subclasses the same fix as was made to LocalFrameView in: https://chromium-review.googlesource.com/1055675 BUG=855950 R=skobes@chromium.org Change-Id: I4c9f29fc1e04213ff22e5debd9630ebb81eb1812 Reviewed-on: https://chromium-review.googlesource.com/1114071 Commit-Queue: Stefan Zager <szager@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#570180}
-
Takumi Fujimoto authored
This CL adds a dialog that allows users to enable cloud services in Cast (Hangouts/Meet, Cast for EDU), and notifies that those services are governed by the Google Privacy Policy. The dialog is shown when the user tries to enable cloud services via the context menu of the Cast toolbar icon ("Enable cloud services") if the user has not previously acknowledged this dialog or the first run flow of the old WebUI dialog. If the user clicks on the "Enable" button in the dialog, we enable the preferences kMediaRouterEnableCloudServices and kMediaRouterCloudServicesPrefSet. If the dialog is closed in another way, we make no pref changes. Screenshot: https://drive.google.com/open?id=1MSonPoMLYt0lfLeq9NfP5yoH15EeVZ6c Bug: 848891 Change-Id: I9f565e328ea0fbc84131eef5e0fa3cb179284886 Reviewed-on: https://chromium-review.googlesource.com/1096403 Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Reviewed-by:Bret Sepulveda <bsep@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#570179}
-
Jacob Dufault authored
Fixed ASAN issue where an animation sequence was being used after it was scheduled. In a test, the sequence is destroyed immediately after scheduling. This was a pre-existing issue exposed by the new test. Bug: 855725 Change-Id: I07a475374df775465e4a9f110df6d2759fdf38d6 Reviewed-on: https://chromium-review.googlesource.com/1113997Reviewed-by:
Xiaoyin Hu <xiaoyinh@chromium.org> Commit-Queue: Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#570178}
-
kylechar authored
This CL ensures that if the set of referenced surfaces from the active tree changes then a new CompositorFrame will be submitted. Before this CL LayerTreeHostImpl didn't look at referenced surfaces in HasDamage() so if there is no other damage then it will skip submitting a CompositorFrame. For this to happen the SurfaceLayer can't be visible, as updating the fallback SurfaceId will otherwise contribute to the damage rect. Bug: 854798 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Id3f196bc151d6118e31c51f2bedc62fc773ee65f Reviewed-on: https://chromium-review.googlesource.com/1114066Reviewed-by:
enne <enne@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#570177}
-
Xianzhu Wang authored
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ic84d0a864f37c0917346e3e3479e1856f5c5f2e9 Reviewed-on: https://chromium-review.googlesource.com/1112940 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#570176}
-
Bret Sepulveda authored
Under Refresh the minimum window size increases to more than the value the test is attempting to set the window to. This patch increases the test values. Bug: 846410 Change-Id: I6af5dce66424249402773a07d852d6245e8bfce3 Reviewed-on: https://chromium-review.googlesource.com/1114123Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#570175}
-
Michael Spang authored
This is cleaned up replacement for the functionality provided by "surfaceless" GLSurface implementations that present to platform windows (i.e. objects returned from CreateSurfacelessViewGLSurface()). It is intended for use with vulkan although it currently does not currently have any dependencies on any vulkan APIs. Bug: 1097208 Test: ozone_demo --enable-vulkan on eve (with full series) Change-Id: Ie5318e848f804c8b9f8fbc78372016286d0c3e6b Reviewed-on: https://chromium-review.googlesource.com/1104864 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#570174}
-
Steven Bennetts authored
Bug: 798569 Change-Id: I68aa4c7f08458324a6a59aa9cd2d8bfafeb95c99 Reviewed-on: https://chromium-review.googlesource.com/1111024 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#570173}
-
Tom Anderson authored
Sized deletion was added in c++14. Now that Chrome is building with c++14, we must override sized operator delete for symbol linkage consistency (see bug 855773). R=thakis BUG=855773 Change-Id: Idb673307939119ec520f71911e2074db2496b5ae Reviewed-on: https://chromium-review.googlesource.com/1112731 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#570172}
-
Aleks Totic authored
Part 1: PhysicalLineFragment ScrollableOverflow ScrollableOverflow was not taking relative position into account. PhyiscalLineFragment used to recompute overflow when created. This can't be done if relative position is needed, because resolving % relative position needs size of containing block. New code computes ScrollbleOverflow dynamically for PhysicalLineFragment. Part 2: Make RelativeUtils API physical. It is a better fit for PhysicalFragments. Part 3: NGMixin::AddScrollableOverflow should also add overflow from oof children. Another tricky bug: If ContainingBlock() is inline, Legacy positions OOF block wrt inline block, while NG positions OOF block wrt inline's block container. Because OOF blocks affect scrollable overflow, NG must be responsible for making sure OOF block is included in container's overflow. This patch makes 3 tests pass, and 1 new test fail: compositing/culling/tile-occlusion-boundaries.html The failure is caused by NG not using transfroms for scrollable overflow computation. To fix this, we must make fragments tranform-aware. Filed a bug to do so. Bug: 728378 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Ib511a95cc71648e806d0cc1376f1f6303152ecee Reviewed-on: https://chromium-review.googlesource.com/1113030 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#570171}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ed55419d859b..ff168d9258e0 git log ed55419d859b..ff168d9258e0 --date=short --no-merges --format='%ad %ae %s' 2018-06-25 bsalomon@google.com Put GrPrimitiveProcessor/GrGeometryProcessor before GrPipeline in param lists. 2018-06-25 enne@chromium.org Validate transformed SkPaintImageFilter rects 2018-06-25 hcm@google.com update externally published milestone schedule 2018-06-25 reed@google.com remove bad assert Created with: gclient setdep -r src/third_party/skia@ff168d9258e0 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium: 852048,chromium:855854 TBR=jcgregorio@chromium.org Change-Id: I66cbf0f9efc9793ac60c1d969b4ad7207eea857e Reviewed-on: https://chromium-review.googlesource.com/1113825Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#570170}
-